guoyunhe updated this revision to Diff 17538.
guoyunhe marked an inline comment as done.
guoyunhe added a comment.
Improve image transition animation. Image transition and blur background
transition are now synchronous and smooth.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
fvogt added inline comments.
INLINE COMMENTS
> anthonyfieroni wrote in client.cpp:1428
> QByteArray has a move constructor, it's not copy.
That does not matter in this instance.
`QString::fromUtf8(QByteArray(reply.name, reply.name_len));` does two copies:
- QByteArray copies name_len bytes fro
anthonyfieroni added inline comments.
INLINE COMMENTS
> fvogt wrote in client.cpp:1428
> Why not directly `QString::fromUtf8(reply.name, reply.name_len)` here? It
> would save one unnecessary copy. Alternatively,
> `QByteArray::fromRawData(reply.name, reply.name_len)`, but that's more
> verbos
fvogt added inline comments.
INLINE COMMENTS
> graesslin wrote in client.cpp:1428
> fromRawData is dangerous as we delete the data with the wipe call again.
> That's why I didn't use it. QString::fromUtf8 is something I didn't use as
> QString from ascii is discouraged and can result in compile
graesslin added inline comments.
INLINE COMMENTS
> fvogt wrote in client.cpp:1428
> Why not directly `QString::fromUtf8(reply.name, reply.name_len)` here? It
> would save one unnecessary copy. Alternatively,
> `QByteArray::fromRawData(reply.name, reply.name_len)`, but that's more
> verbose.
f
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
The parameter is not used anywhere in KWin. Only the default value was
used. So let's drop this.
TEST PLAN
Compiles
REPOSITORY
R10
guoyunhe marked 2 inline comments as done.
guoyunhe added inline comments.
INLINE COMMENTS
> broulik wrote in main.qml:213
> Is it possible to re-use the currentImage instead of creating yet another
> `Image` item? I know with `ShaderEffect` you can do `hideSource: false` but I
> don't see this
guoyunhe updated this revision to Diff 17518.
guoyunhe added a comment.
Solve some coding issue. Use two GaussianBlur to keep sync with image
slideshow.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7047?vs=17517&id=17518
REVISION DETAIL
https
fvogt added a comment.
Built and tested - works fine! I only added two rather nitpicky comments.
INLINE COMMENTS
> client.cpp:1428
> +if (reply.encoding == atoms->utf8_string) {
> +retVal = QString::fromUtf8(QByteArray(reply.name,
> reply.name_len));
> +
I have made a simple program that generates a plasma colorscheme from an
image. I am hoping to integrate it into plasma, making it so it takes the
current wallpaper (or any image) and allows the user to generate a colorscheme
based off of that.
However, I am unfamiliar with working with large c
broulik added a comment.
Pretty cool idea!
INLINE COMMENTS
> WallpaperDelegate.qml:73
> +
> +GaussianBlur {
> +visible: cfg_Blur
I think for the preview a `FastBlur` is sufficient, or perhaps even just
scaling up a tiny pixmap
> config.qml:142
> +id:
guoyunhe created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Add a checkbox to wallpaper configuration dialog. By checking this option,
empty space surround image will be filled by blurred image rather
broulik added inline comments.
INLINE COMMENTS
> client.cpp:1433
> +xcb_icccm_get_text_property_reply_wipe(&reply);
> +return retVal;
> +}
Missing a `simplified()`
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D7046
To: graesslin, #kwin,
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REVISION SUMMARY
The KWindowSystem call which we used doesn't work on Wayland as it's only
implemented in the xcb variant and cannot be made available fo
mart added a comment.
any update on this?
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D6549
To: apol, #kirigami, sitter, mart
Cc: plasma-devel, apol, mart
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R169 Kirigami
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7039
To: apol, #kirigami, mart
Cc: plasma-devel, apol, mart
mart accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R242 Plasma Framework (Library)
REVISION DETAIL
https://phabricator.kde.org/D6894
To: broulik, #plasma, mart
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai,
ali-mohamed, j
mart added a comment.
+1
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D6938
To: broulik, #plasma, hein
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, lukas
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
Thanks
REVISION DETAIL
https://phabricator.kde.org/D7036
To: carewolf, sandsmark, jriddell, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai
subdiff added a comment.
I'm currently on a tight time budget, so this will need to wait a little bit.
I'll roll with the change on my machine for a while and if everything works
fine add a unit test in the end.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7038
graesslin added inline comments.
INLINE COMMENTS
> surface_interface.cpp:841
>
> +SurfaceInterface *SurfaceInterface::inputSurfaceAt(const QPointF &position)
> +{
Could you try to share the logic between surfaceAt and inputSurfaceAt methods?
I cannot spot a difference except the method it cal
graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.
Please verify that this does not break Qt! (Qt has a very special handling of
subsurfaces and we have lots of workarounds for Qt there)
Also please add a unit test which
apol created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
[3/3] Linking CXX executable examples/galleryapp/kirigami2gallery
FAILED: examples/galleryapp/kirigami2gallery
: && /usr/bin/clang++ -std=c
subdiff created this revision.
subdiff added a project: Plasma on Wayland.
Restricted Application added a subscriber: plasma-devel.
Restricted Application added a project: Frameworks.
REVISION SUMMARY
I noticed that while working on my GSoC Xwayland project and using
sub-surfaces with empty inp
carewolf added reviewers: sandsmark, jriddell.
REVISION DETAIL
https://phabricator.kde.org/D7036
To: carewolf, sandsmark, jriddell
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a1e2ddd67a12: Fix group dialog no longer resizing/closing
as windows are closed and the group… (authored by hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R119 Plasma Desktop
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D7035
To: hein, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreute
carewolf updated this revision to Diff 17496.
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7036?vs=17495&id=17496
REVISION DETAIL
https://phabricator.kde.org/D7036
AFFECTED FILES
CMakeLists.txt
processui/CMakeLists.txt
processui/scripting.cpp
To: carewolf
Cc: plasma-devel, Z
carewolf created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
libksysguard does not appear to use QtScript, but just includes it.
Removing it makes it build with a clean Qt5.9 where QtScript no longe
hein updated this revision to Diff 17493.
hein added a comment.
Better code for closing on dissolve.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7035?vs=17492&id=17493
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D7035
AFFE
hein updated this revision to Diff 17492.
hein marked an inline comment as done.
hein added a comment.
Cleanup from older version.
Sorry, got distracted by an IRC meeting.
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7035?vs=17491&id=17492
BR
broulik added inline comments.
INLINE COMMENTS
> cfeck wrote in ConfigGeneral.qml:115
> Maybe it should also specify a minimum value, e.g. 0.05 sec. for 20 updates
> per second.
I just did what ksysguard does where a 0 interval pauses updating, for whatever
reason this may be useful..
REPOSIT
broulik added inline comments.
INLINE COMMENTS
> GroupDialog.qml:138
> property bool aboutToPopulate: false
> +property int oldCount: 0
>
Unused
> GroupDialog.qml:153
> +onItemRemoved: {
> +if (groupDialog.vi
hein created this revision.
Restricted Application added a project: Plasma.
REVISION SUMMARY
Also delays the dialog resize until after the move transition ends
if there's going to be one, for a less jarring experience.
BUG:382638
REPOSITORY
R119 Plasma Desktop
BRANCH
Plasma/5.8
REV
hein abandoned this revision.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D7032
To: hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
hein created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
BUG:382638
REPOSITORY
R119 Plasma Desktop
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D7032
AFFECTED FILES
applets/t
Notes from the KDeclarative/PlasmaComponents BoF:
CC'ing frameworks devel even though there's a good chance that it won't
make much sense unless you follow Plasma development.
About:
Since KF5.0 lots has changed. QtQuickControls2 was made, Q_GADGET was made,
Kirigami happened and more.
We've ende
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:999568ada13b: Stop unnecessarily killing IBus when
applying keyboard layouts config (authored by hein).
REPOSITORY
R119 Plasma Desktop
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6956?v
On Monday 31 July 2017 23:28:32 kainz.a wrote:
> 3. update all KCM
> This task is HUGE we are talking about 70 (by default installed KCM's) and
> additionally some other KCM's. Update all KCM's would be a big (maybe to
> big) step. So I separte the KCM's in the 4 major sections
> - 1. Appearance
g
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7e2a29b0b18a: [Notifications] Improve mouse handling
(authored by broulik).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7029?vs=17477&id=17482
REVISION
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.
LGTM, thanks!
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7029
To: broulik, #plasma, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, j
This revision was automatically updated to reflect the committed changes.
Closed by commit R856:a56dd8a1760c: Fix occasional abort in the krunner plugin
(authored by fvogt).
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6718?vs=17480&id=174
fvogt updated this revision to Diff 17480.
fvogt added a comment.
!= 1
REPOSITORY
R856 Plasma Browser Integration
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D6718?vs=16746&id=17480
BRANCH
crashfix (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D6718
A
broulik accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R856 Plasma Browser Integration
BRANCH
crashfix (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D6718
To: fvogt, #plasma, broulik, davidedmundson
Cc: heikobecker, plasma-devel, Z
On Fri, Jul 28, 2017 at 2:27 PM, David Edmundson
wrote:
> Please can someone review kde:scratch/davidedmundson/drkonqi
LGTM
(not split defects but: README, AUTHORS, LICENSE, ToDo and doc could
be moved into the main dir, conversely config-x11.h could be merged
into config-drkonqi.h and removed f
broulik edited the summary of this revision.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7029
To: broulik, #plasma, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart, lukas
broulik updated this revision to Diff 17477.
broulik edited the test plan for this revision.
broulik added a comment.
Removed debugging output
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7029?vs=17476&id=17477
REVISION DETAIL
https://phabrica
broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
- Make links clickable again
- Don't pass visualParent to context menu as we already give it a position,
fixes it being positioned incorrect
48 matches
Mail list logo