D7046: Use xcb-icccm to read the name property

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> graesslin wrote in client.cpp:1428
> fromRawData is dangerous as we delete the data with the wipe call again. 
> That's why I didn't use it. QString::fromUtf8 is something I didn't use as 
> QString from ascii is discouraged and can result in compile error depending 
> on the compile flags.
> 
> So in short: the copy is intended.

`QString::fromUtf8` is always available and has nothing to do at all with the 
CAST_(FROM|TO)_ASCII macros.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7046

To: graesslin, #kwin, #plasma
Cc: fvogt, broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D7046: Use xcb-icccm to read the name property

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> fvogt wrote in client.cpp:1428
> Why not directly `QString::fromUtf8(reply.name, reply.name_len)` here? It 
> would save one unnecessary copy. Alternatively, 
> `QByteArray::fromRawData(reply.name, reply.name_len)`, but that's more 
> verbose.

fromRawData is dangerous as we delete the data with the wipe call again. That's 
why I didn't use it. QString::fromUtf8 is something I didn't use as QString 
from ascii is discouraged and can result in compile error depending on the 
compile flags.

So in short: the copy is intended.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7046

To: graesslin, #kwin, #plasma
Cc: fvogt, broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D7059: Drop the stripped parameter from AbstractClient::caption

[Martin Flöser]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  The parameter is not used anywhere in KWin. Only the default value was
  used. So let's drop this.

TEST PLAN
  Compiles

REPOSITORY
  R108 KWin

BRANCH
  client-caption-no-stripped

REVISION DETAIL
  https://phabricator.kde.org/D7059

AFFECTED FILES
  abstract_client.h
  client.cpp
  client.h
  shell_client.cpp
  shell_client.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7047: Wallpaper blur background filling effect feature

[Yunhe Guo]

guoyunhe marked 2 inline comments as done.
guoyunhe added inline comments.

INLINE COMMENTS

> broulik wrote in main.qml:213
> Is it possible to re-use the currentImage instead of creating yet another 
> `Image` item? I know with `ShaderEffect` you can do `hideSource: false` but I 
> don't see this in `GaussianBlur` :/

If we re-use currentImage, the image must be scaled up. It results in much 
lower blur quality. So I think a new Image item is still necessary.

Later I found if only provide one blur, when slideshow switching, the image and 
background doesn't change at the same time. So I have to use two blur, one for 
imageA, one for imageB. Though blur rendering is still a little lag on low end 
hardware, but much better than before.

> broulik wrote in main.qml:226
> You might want to set the source to `null` when it's disabled otherwise we 
> end up blurring (even when disabled):
> 
>   source: wallpaper.configuration.Blur ? blurBackgroundSource : null

Yes, it is good to disable blurring when not using this option. But if I add 
this line, blur will not be rendered. I cannot figure out the reason for the 
moment.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7047

To: guoyunhe, #plasma_workspaces
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7047: Wallpaper blur background filling effect feature

[Yunhe Guo]

guoyunhe updated this revision to Diff 17518.
guoyunhe added a comment.


  Solve some coding issue. Use two GaussianBlur to keep sync with image 
slideshow.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7047?vs=17517=17518

REVISION DETAIL
  https://phabricator.kde.org/D7047

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml

To: guoyunhe, #plasma_workspaces
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7046: Use xcb-icccm to read the name property

[Fabian Vogt]

fvogt added a comment.


  Built and tested - works fine! I only added two rather nitpicky comments.

INLINE COMMENTS

> client.cpp:1428
> +if (reply.encoding == atoms->utf8_string) {
> +retVal = QString::fromUtf8(QByteArray(reply.name, 
> reply.name_len));
> +} else if (reply.encoding == XCB_ATOM_STRING) {

Why not directly `QString::fromUtf8(reply.name, reply.name_len)` here? It would 
save one unnecessary copy. Alternatively, `QByteArray::fromRawData(reply.name, 
reply.name_len)`, but that's more verbose.

> client.cpp:1433
> +xcb_icccm_get_text_property_reply_wipe();
> +return retVal;
> +}

This omits the call to `QString::simplified` that is done in the old rev and 
for the `info->name()` case. Intentional?

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7046

To: graesslin, #kwin, #plasma
Cc: fvogt, broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

Implementing a plasma colorscheme generator

[Andrew]

I have made a simple program that generates a plasma colorscheme from an 
image. I am hoping to integrate it into plasma, making it so it takes the 
current wallpaper (or any image) and allows the user to generate a colorscheme 
based off of that.

However, I am unfamiliar with working with large codebases such as KDE, so I 
am not sure where to start. Could some one point me in the right direction, 
by, for example, telling me where the files that the system settings for the 
colorschemes are? 

Sorry if I am doing something wrong, this is my first time using a mailing 
list.

D7047: Wallpaper blur background filling effect feature

[Kai Uwe Broulik]

broulik added a comment.


  Pretty cool idea!

INLINE COMMENTS

> WallpaperDelegate.qml:73
> +
> +GaussianBlur {
> +visible: cfg_Blur

I think for the preview a `FastBlur` is sufficient, or perhaps even just 
scaling up a tiny pixmap

> config.qml:142
> +id: blurCheckBox
> +text: i18nd("plasma_applet_org.kde.image", "Use blur background 
> filling")
> +checked: true

I'm not too happy with this label but I can't think of a better phrase either..

> main.qml:213
>  
>  Image {
> +id: blurBackgroundSource

Is it possible to re-use the currentImage instead of creating yet another 
`Image` item? I know with `ShaderEffect` you can do `hideSource: false` but I 
don't see this in `GaussianBlur` :/

> main.qml:226
> +anchors.fill: parent
> +source: blurBackgroundSource
> +radius: 32

You might want to set the source to `null` when it's disabled otherwise we end 
up blurring (even when disabled):

  source: wallpaper.configuration.Blur ? blurBackgroundSource : null

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7047

To: guoyunhe, #plasma_workspaces
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7047: Wallpaper blur background filling effect feature

[Yunhe Guo]

guoyunhe created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Add a checkbox to wallpaper configuration dialog. By checking this option, 
empty space surround image will be filled by blurred image rather than a color.
  
  F3827701: Screenshot_20170801_223505.png 

  
  F3827700: Screenshot_20170801_224020.png 

  
  F3827699: Screenshot_20170801_224015.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7047

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/WallpaperDelegate.qml
  wallpapers/image/imagepackage/contents/ui/config.qml
  wallpapers/image/imagepackage/contents/ui/main.qml

To: guoyunhe, #plasma_workspaces
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7046: Use xcb-icccm to read the name property

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> client.cpp:1433
> +xcb_icccm_get_text_property_reply_wipe();
> +return retVal;
> +}

Missing a `simplified()`

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D7046

To: graesslin, #kwin, #plasma
Cc: broulik, plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
hardening, jensreuterberg, abetts, sebas, apol, mart, lukas

D7046: Use xcb-icccm to read the name property

[Martin Flöser]

graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.

REVISION SUMMARY
  The KWindowSystem call which we used doesn't work on Wayland as it's only
  implemented in the xcb variant and cannot be made available for Wayland
  in an easy way as it is still XLib based.
  
  This change turns the optional XCB-ICCCM dependency in a required one
  and thus can use the functionality provided by said library to implement
  what KWindowSystem provided.
  
  BUG: 382789

TEST PLAN
  New test case which failed with old code

REPOSITORY
  R108 KWin

BRANCH
  xcb-iccm-name

REVISION DETAIL
  https://phabricator.kde.org/D7046

AFFECTED FILES
  CMakeLists.txt
  autotests/integration/x11_client_test.cpp
  client.cpp

To: graesslin, #kwin, #plasma
Cc: plasma-devel, kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6549: Look for QtGraphicalEffects, so packagers don't forget it

[Marco Martin]

mart added a comment.


  any update on this?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D6549

To: apol, #kirigami, sitter, mart
Cc: plasma-devel, apol, mart

D7039: Fix build on linux

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7039

To: apol, #kirigami, mart
Cc: plasma-devel, apol, mart

D6894: [Containment Interface] always emit contextualActionsAboutToShow for containment

[Marco Martin]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6894

To: broulik, #plasma, mart
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6938: [Folder View Config] Make model writable and drop custom setRowChecked method

[Marco Martin]

mart added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6938

To: broulik, #plasma, hein
Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, lukas

D7036: Remove fake dependency on QtScript

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Thanks

REVISION DETAIL
  https://phabricator.kde.org/D7036

To: carewolf, sandsmark, jriddell, davidedmundson
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

[Roman Gilg]

subdiff added a comment.


  I'm currently on a tight time budget, so this will need to wait a little bit. 
I'll roll with the change on my machine for a while and if everything works 
fine add a unit test in the end.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7038

To: subdiff, #frameworks, graesslin
Cc: graesslin, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

[Martin Flöser]

graesslin added inline comments.

INLINE COMMENTS

> surface_interface.cpp:841
>  
> +SurfaceInterface *SurfaceInterface::inputSurfaceAt(const QPointF )
> +{

Could you try to share the logic between surfaceAt and inputSurfaceAt methods? 
I cannot spot a difference except the method it calls and that could be handled 
in a more generic way (e.g. function pointer).

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7038

To: subdiff, #frameworks, graesslin
Cc: graesslin, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

[Martin Flöser]

graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  Please verify that this does not break Qt! (Qt has a very special handling of 
subsurfaces and we have lots of workarounds for Qt there)
  
  Also please add a unit test which exposes the problem.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7038

To: subdiff, #frameworks, graesslin
Cc: graesslin, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D7039: Fix build on linux

[Aleix Pol Gonzalez]

apol created this revision.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  [3/3] Linking CXX executable examples/galleryapp/kirigami2gallery
  FAILED: examples/galleryapp/kirigami2gallery
  : && /usr/bin/clang++  -std=c++0x -fno-operator-names -fno-exceptions 
-Wno-gnu-zero-variadic-macro-arguments -Wall -Wextra -Wcast-align 
-Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef 
-Wnon-virtual-dtor -Woverloaded-virtual -Werror=return-type -Wvla -Wdate-time 
-fdiagnostics-color=always -Wall -std=c++0x -g  -Wl,--enable-new-dtags 
-rdynamic examples/galleryapp/CMakeFiles/kirigami2gallery.dir/main.cpp.o 
examples/galleryapp/CMakeFiles/kirigami2gallery.dir/qrc_resources.cpp.o 
examples/galleryapp/CMakeFiles/kirigami2gallery.dir/kirigami2gallery_autogen/moc_compilation.cpp.o
  -o examples/galleryapp/kirigami2gallery  
-Wl,-rpath,/home/apol/devel/kde5/lib 
/home/apol/devel/kde5/lib/libQt5Svg.so.5.9.2 
/home/apol/devel/kde5/lib/libQt5QuickControls2.so.5.9.2 
/home/apol/devel/kde5/lib/libQt5Widgets.so.5.9.2 
/home/apol/devel/kde5/lib/libQt5Quick.so.5.9.2 
/home/apol/devel/kde5/lib/libQt5Qml.so.5.9.2 
/home/apol/devel/kde5/lib/libQt5Network.so.5.9.2 
/home/apol/devel/kde5/lib/libQt5Gui.so.5.9.2 
/home/apol/devel/kde5/lib/libQt5Core.so.5.9.2 && :
  /home/apol/devel/kde5/lib/libQt5QuickTemplates2.so.5:(*IND*+0x0): multiple 
definition of `_end'
  /home/apol/devel/kde5/lib/libQt5QuickTemplates2.so.5:(*IND*+0x0): multiple 
definition of `__bss_start'
  clang-4.0: error: linker command failed with exit code 1 (use -v to see 
invocation)
  ninja: build stopped: subcommand failed.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D7039

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt

To: apol, #kirigami, mart
Cc: plasma-devel, apol, mart

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

[Roman Gilg]

subdiff created this revision.
subdiff added a project: Plasma on Wayland.
Restricted Application added a subscriber: plasma-devel.
Restricted Application added a project: Frameworks.

REVISION SUMMARY
  I noticed that while working on my GSoC Xwayland project and using 
sub-surfaces with empty input region. KWayland takes always the top-most child 
surface at a given position for its pointer input.
  
  But if a sub-surface sets its input region, it should not select this one 
when the position is out of its input region, but rather try the surface below.

TEST PLAN
  My testing was only on my Xwayland branch.

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7038

AFFECTED FILES
  src/server/pointer_interface.cpp
  src/server/surface_interface.cpp
  src/server/surface_interface.h

To: subdiff, #frameworks
Cc: plasma-devel, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein, lukas

D7036: Remove fake dependency on QtScript

[Allan Sandfeld Jensen]

carewolf added reviewers: sandsmark, jriddell.

REVISION DETAIL
  https://phabricator.kde.org/D7036

To: carewolf, sandsmark, jriddell
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7035: Fix group dialog no longer resizing/closing as windows are closed and the group is dissolved

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:a1e2ddd67a12: Fix group dialog no longer resizing/closing 
as windows are closed and the group… (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7035?vs=17493=17498

REVISION DETAIL
  https://phabricator.kde.org/D7035

AFFECTED FILES
  applets/taskmanager/package/contents/ui/GroupDialog.qml
  applets/taskmanager/package/contents/ui/Task.qml

To: hein, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7035: Fix group dialog no longer resizing/closing as windows are closed and the group is dissolved

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D7035

To: hein, #plasma, broulik
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7036: Remove fake dependency on QtScript

[Allan Sandfeld Jensen]

carewolf updated this revision to Diff 17496.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7036?vs=17495=17496

REVISION DETAIL
  https://phabricator.kde.org/D7036

AFFECTED FILES
  CMakeLists.txt
  processui/CMakeLists.txt
  processui/scripting.cpp

To: carewolf
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7036: Remove fake dependency on QtScript

[Allan Sandfeld Jensen]

carewolf created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  libksysguard does not appear to use QtScript, but just includes it.
  
  Removing it makes it build with a clean Qt5.9 where QtScript no longer exists.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D7036

AFFECTED FILES
  CMakeLists.txt
  processui/CMakeLists.txt
  processui/scripting.cpp

To: carewolf
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7035: Fix group dialog no longer resizing/closing as windows are closed and the group is dissolved

[Eike Hein]

hein updated this revision to Diff 17493.
hein added a comment.


  Better code for closing on dissolve.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7035?vs=17492=17493

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D7035

AFFECTED FILES
  applets/taskmanager/package/contents/ui/GroupDialog.qml
  applets/taskmanager/package/contents/ui/Task.qml

To: hein, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7035: Fix group dialog no longer resizing/closing as windows are closed and the group is dissolved

[Eike Hein]

hein updated this revision to Diff 17492.
hein marked an inline comment as done.
hein added a comment.


  Cleanup from older version.
  
  Sorry, got distracted by an IRC meeting.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7035?vs=17491=17492

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D7035

AFFECTED FILES
  applets/taskmanager/package/contents/ui/GroupDialog.qml

To: hein, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6864: [System Monitor Applet] Add setting for update interval

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> cfeck wrote in ConfigGeneral.qml:115
> Maybe it should also specify a minimum value, e.g. 0.05 sec. for 20 updates 
> per second.

I just did what ksysguard does where a 0 interval pauses updating, for whatever 
reason this may be useful..

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6864

To: broulik, #plasma
Cc: cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7035: Fix group dialog no longer resizing/closing as windows are closed and the group is dissolved

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> GroupDialog.qml:138
>  property bool aboutToPopulate: false
> +property int oldCount: 0
>  

Unused

> GroupDialog.qml:153
> +onItemRemoved: {
> +if (groupDialog.visible && index > 0 && index == 
> count) {
> +updateSize();

`count` will already reflect the new count here? So essentially `index == 
count` means "the last item was removed"?

> TaskList.qml:23
>  Flow {
> +id: taskList
> +

Unused?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7035

To: hein, #plasma
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D7035: Fix group dialog no longer resizing/closing as windows are closed and the group is dissolved

[Eike Hein]

hein created this revision.
Restricted Application added a project: Plasma.

REVISION SUMMARY
  Also delays the dialog resize until after the move transition ends
  if there's going to be one, for a less jarring experience.
  
  BUG:382638

REPOSITORY
  R119 Plasma Desktop

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D7035

AFFECTED FILES
  applets/taskmanager/package/contents/ui/GroupDialog.qml
  applets/taskmanager/package/contents/ui/TaskList.qml

To: hein, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7032: Fix group dialog no longer resizing/closing as windows are closed and the group is dissolved

[Eike Hein]

hein abandoned this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D7032

To: hein
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

Notes from Plasma Components BOF

[David Edmundson]

Notes from the KDeclarative/PlasmaComponents BoF:

CC'ing frameworks devel even though there's a good chance that it won't
make much sense unless you follow Plasma development.

About:
Since KF5.0 lots has changed. QtQuickControls2 was made, Q_GADGET was made,
Kirigami happened and more.
We've ended up with a lot of duplication (3 items to draw an icon!) and
there's not a clear definition for each.

We went through all imports and made some notes and plans.

KDeclarative:

KQuickControls:
  Definition: exposing KDE Widget frameworks paarts to QtQuick. (i.e.
globalshortcuts, colour picker etc) with any UI QQC themed.

KQuickControlsAddons:
  Definition: "fixes" for Qt and things not exposed to QML.

  Medium term TODOs:
KDeclarative.KQuickControlsAddons.IconDialog and KcmShell should
probably in KQuickControls
KQuickControls: Needs QQC2 port under new import version (assgigned to
David E)

  Long term: needs a clearer name.

KDeclarative.CoreAddons
KDeclarative.KIOPlugin
KDeclarative.KConfig
KDeclarative.KWindowSystemPlugin

  Definition: Wrapper for existing frameworks exposed in a QML friendly way.

  Long term TODO: Merge into the relevant frameworks for KF6 using
Q_gadget. KWindowSystemPlugin probably doesn't make sense.

PlasmaExtras:
  Most this stuff is in Kirigami.
  TODO: deprecate app specific stuff (assigned to Marco)

  *IF* we can get 2 different QQC themes in one app, kill this completely.
  Fallback plan. Keep it.

PlasmaComponents2:
  Definition: QQC1 wrapper with a plasma theme + API additions.

PlasmaComponents3:
  Definition: QQC2 wrapper. Currently no API additions.

  We can't port many plasmoids, as we need those additions.
  Decided there's no rush.

  Plan:
 - Put icons in buttons in Qt (possibly done already) - ivan
 - Get textinput clear/showpassword into Qt - d_ed
 - put themed Highlight class into PlasmaExtras - marco

  *IF* we can't get the stuff into Qt, we put things into Kirigrami, and a
depending on the if above, a plasma themed version in PlasmaExtras.

Other:
  ColorScope to also enter Kirigrami (Kube uses something similar, so it is
something useful), ideally try to find a solution that makes less QObjects
than the version we have in PlasmaCore.

PlasmaCore:
  Controversial idea. Low level SVG theming is potentially useful for
external use.

Split Plasma theme out of plasma-framework, move that to a tier 2 framework
(with PlasmaComponents). This leave just the shell stuff as a new
framework, and we deprecate Plasma. Depends on some of the changes above.

D6956: Stop unnecessarily killing IBus when applying keyboard layouts config

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:999568ada13b: Stop unnecessarily killing IBus when 
applying keyboard layouts config (authored by hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6956?vs=17363=17485

REVISION DETAIL
  https://phabricator.kde.org/D6956

AFFECTED FILES
  kcms/keyboard/keyboard_daemon.cpp
  kcms/keyboard/xkb_helper.cpp
  kcms/keyboard/xkb_helper.h

To: achauvel, xapienz, xuetianweng
Cc: hein, xapienz, plasma-devel, #plasma, ZrenBot, progwolff, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

Re: System settings KCM redesign

[Marco Martin]

On Monday 31 July 2017 23:28:32 kainz.a wrote:
> 3. update all KCM
> This task is HUGE we are talking about 70 (by default installed KCM's) and
> additionally some other KCM's. Update all KCM's would be a big (maybe to
> big) step. So I separte the KCM's in the 4 major sections
> - 1. Appearance

going in blocks of section by section is a good idea

-- 
Marco Martin

D7029: [Notifications] Improve mouse handling

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7e2a29b0b18a: [Notifications] Improve mouse handling 
(authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7029?vs=17477=17482

REVISION DETAIL
  https://phabricator.kde.org/D7029

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: broulik, #plasma, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7029: [Notifications] Improve mouse handling

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  LGTM, thanks!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7029

To: broulik, #plasma, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D6718: Fix occasional abort in the krunner plugin

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:a56dd8a1760c: Fix occasional abort in the krunner plugin 
(authored by fvogt).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6718?vs=17480=17481

REVISION DETAIL
  https://phabricator.kde.org/D6718

AFFECTED FILES
  tabsrunner/tabsrunner.cpp

To: fvogt, #plasma, broulik, davidedmundson
Cc: heikobecker, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6718: Fix occasional abort in the krunner plugin

[Fabian Vogt]

fvogt updated this revision to Diff 17480.
fvogt added a comment.


  != 1

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6718?vs=16746=17480

BRANCH
  crashfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D6718

AFFECTED FILES
  tabsrunner/tabsrunner.cpp

To: fvogt, #plasma, broulik, davidedmundson
Cc: heikobecker, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

D6718: Fix occasional abort in the krunner plugin

[Kai Uwe Broulik]

broulik accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  crashfix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D6718

To: fvogt, #plasma, broulik, davidedmundson
Cc: heikobecker, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart, lukas

Re: Re: DrKonqi dependencies

[Harald Sitter]

On Fri, Jul 28, 2017 at 2:27 PM, David Edmundson
 wrote:
> Please can someone review kde:scratch/davidedmundson/drkonqi

LGTM

(not split defects but: README, AUTHORS, LICENSE, ToDo and doc could
be moved into the main dir, conversely config-x11.h could be merged
into config-drkonqi.h and removed from the main dir)

HS

D7029: [Notifications] Improve mouse handling

[Kai Uwe Broulik]

broulik edited the summary of this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7029

To: broulik, #plasma, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7029: [Notifications] Improve mouse handling

[Kai Uwe Broulik]

broulik updated this revision to Diff 17477.
broulik edited the test plan for this revision.
broulik added a comment.


  Removed debugging output

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7029?vs=17476=17477

REVISION DETAIL
  https://phabricator.kde.org/D7029

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: broulik, #plasma, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas

D7029: [Notifications] Improve mouse handling

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  - Make links clickable again
  - Don't pass visualParent to context menu as we already give it a position, 
fixes it being positioned incorrectly
  - Open context menu on press already like is done everywhere else
  - Give "Copy" the edit-copy icon
  
  BUG: 382263
  FIXED-IN: 5.10.5

TEST PLAN
  - I can now click links in notifications again.
  - Verified that the clicked link is correct even when the notification area 
is scrollabe.
  - Context menu is positioned at mouse position now

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D7029

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: broulik, #plasma, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart, lukas