davidedmundson added a comment.
> So from KWayland Server side we have a selection
from KWayland server side we have a Seat:selection, we don't check if that
has a DDI::selection
If a client had called wl_set_selection(dataDevice, nulltptr) the server
would still have a
Kanedias added a comment.
Gentle reminder
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D1231
To: Kanedias, graesslin, davidedmundson
Cc: #frameworks, davidedmundson, plasma-devel, leezu, ZrenBot, progwolff,
lesliezhai, ali-mohamed, jensreuterberg, abetts,
This revision was automatically updated to reflect the committed changes.
Closed by commit R846:ad23b86c758b: Updated to newer version (authored by Aiix).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D6851?vs=17056=18064#toc
REPOSITORY
R846 Mycroft Plasma integration
CHANGES SINCE
davidedmundson added a comment.
There's a visual quirk I'd like fixing.
Each delegate has a line on the bottom.
However, there's no line between the persistent notifications and the
history, so it looks weird.
Maybe a heading "history" would also work.
Also in your last
graesslin added a comment.
I like that refactoring - though processAt might not be the best fitting
name. Don't have a good name idea, maybe findChildSurfaceAt?
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7038
To: subdiff, #frameworks, graesslin
Cc:
graesslin added a comment.
In https://phabricator.kde.org/D7273#134905, @bshah wrote:
> In https://phabricator.kde.org/D7273#134903, @graesslin wrote:
>
> > @apol any idea why several of the packages are reported not found?
>
>
> Please try to run `qmlplguindump QtQuick.Controls
subdiff marked an inline comment as done.
REPOSITORY
R127 KWayland
REVISION DETAIL
https://phabricator.kde.org/D7038
To: subdiff, #frameworks, graesslin
Cc: graesslin, plasma-devel, leezu, ZrenBot, progwolff, lesliezhai,
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein,
subdiff updated this revision to Diff 18059.
subdiff added a comment.
Use function pointers.
REPOSITORY
R127 KWayland
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7038?vs=17500=18059
REVISION DETAIL
https://phabricator.kde.org/D7038
AFFECTED FILES
bshah added a comment.
In https://phabricator.kde.org/D7273#134903, @graesslin wrote:
> @apol any idea why several of the packages are reported not found?
Please try to run `qmlplguindump QtQuick.Controls 1.2` for instance and paste
it's output here.
REPOSITORY
R108 KWin
graesslin added a subscriber: apol.
graesslin added a comment.
@apol any idea why several of the packages are reported not found?
-- The following RUNTIME packages have not been found:
* QtQuick.Controls-QMLModule , QML module 'QtQuick.Controls' is a runtime
dependency.
graesslin created this revision.
Restricted Application added a project: KWin.
Restricted Application added subscribers: kwin, plasma-devel.
REPOSITORY
R108 KWin
BRANCH
ecmqmlmodules
REVISION DETAIL
https://phabricator.kde.org/D7273
AFFECTED FILES
CMakeLists.txt
To: graesslin, #kwin,
progwolff updated this revision to Diff 18051.
progwolff added a comment.
- fix property name
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7271?vs=18050=18051
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7271
AFFECTED FILES
progwolff updated this revision to Diff 18050.
progwolff added a comment.
- uncomment unintentionally commented line
- rename counters
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7271?vs=18045=18050
BRANCH
master
REVISION DETAIL
progwolff marked 2 inline comments as done.
progwolff added inline comments.
INLINE COMMENTS
> davidedmundson wrote in Notifications.qml:243
> ?
sorry, missed to revert this...
> davidedmundson wrote in Notifications.qml:257
> How does this differ to the persistent delegate?
>
> Can we share
progwolff marked 2 inline comments as done.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7271
To: progwolff, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
davidedmundson added a comment.
Thanks for looking into this.. first round of comments.
INLINE COMMENTS
> Notifications.qml:243
> }
> -onPopupShown: notificationsRoot.popupShown(popup)
> +//onPopupShown: notificationsRoot.popupShown(popup)
> }
?
>
progwolff created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Bug 378032.
With these changes, notifications can be configured to always persist
in the notifications applet.
Todo: filter by
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:a65b2c062cb0: Move event filtering for overlay window
into an X11EventFilter (authored by graesslin).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7197?vs=17864=18043#toc
REPOSITORY
R108
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:bbca8c6677fe: Implement the shortcut caption suffix for
Wayland windows (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7093?vs=17627=18041
This revision was automatically updated to reflect the committed changes.
Closed by commit R108:b4a79d30e64f: Move the X11 specific OverlayWindow into
the platform/x11 (authored by graesslin).
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7193?vs=17842=18042
graesslin updated this revision to Diff 18039.
graesslin added a comment.
Add back a debug message which got lost while moving code around
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7259?vs=18022=18039
BRANCH
scene-qpainter-plugin
REVISION DETAIL
graesslin added a comment.
In https://phabricator.kde.org/D6549#134794, @apol wrote:
> I was thinking: should I wait for a month so that ECM has been released
with it maybe? Otherwise it will be a hard dependency and people won't be able
to use the master branch...
I think it's
graesslin updated this revision to Diff 18038.
graesslin added a comment.
Restricted Application edited projects, added Plasma; removed KWin.
Added new debug category to org_kde_kwin.categories
REPOSITORY
R108 KWin
CHANGES SINCE LAST UPDATE
davidedmundson added inline comments.
INLINE COMMENTS
> tasksmodel.cpp:1553
> +
> +// If we moved a group parent, consolidate sort map for children.
> +if (groupMode() != GroupDisabled &&
> d->groupingProxyModel->rowCount(groupingRowIndex)) {
This is the only bit that's
davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> MouseHandler.qml:102
> +// Reject drags between different TaskList instances.
> +if (tasks.dragSource.parent !=
25 matches
Mail list logo
