D7316: Avoid sending data offers from an invalid source.

davidedmundson created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY A DataDevice will have a source when offers are available, but it can also be legitimately cleared.

Re: Minutes Monday Plasma Hangout

​Fabian also added some comments just after: ‎[12:06] ‎<‎fvogt‎>‎ * Did some strace-based profiling of plasma startup - discovered two things: ‎[12:06] ‎<‎fvogt‎>‎ ** The applicationDir is added as first entry to the QML and Library search paths, slowing lookups down considerably ‎[12:06]

D7315: Don't duplicate UI option for automatic speed detection

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Network speed is determined automatically if "auto-negotiate" is set. NM Spec says if that is not set a speed and duplex should be

Minutes Monday Plasma Hangout

Check. -- sebas http://vizZzion.org ⦿http://www.kde.org Plasma Team meeting, 31-7-2017 Present: notmart, Sho, kbroulik, fvogt, d_ed, bshah, sebas notmart: * https://codereview.qt-project.org/#/c/200788/ merged in Qt 5.9 \o/ * work mostly on the foreign rotocol implementation, to

D7306: concept of Layers

mart created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Introduce the concept of layers: the main page row contents are in a StackView: normally one would push things as columns in the main page

Re: Implementing a plasma colorscheme generator

On zaterdag 5 augustus 2017 17:10:59 CEST Andrew wrote: > On Friday, August 4, 2017 8:16:57 PM EDT Andrew wrote: > > On Friday, August 4, 2017 7:03:43 PM EDT Aleix Pol wrote: > > > On Fri, Aug 4, 2017 at 5:13 PM, Andrew wrote: > > > >> > On donderdag 3 augustus 2017

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

graesslin added a comment. > If your patch works, then mine would too. It's checking the exact same pointer, just one frame earlier. But then it's an easy thing: let's do both. Your patch and mine. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D7078 To:

D7271: optionally show a history of notifications

progwolff added a comment. In https://phabricator.kde.org/D7271#135544, @davidedmundson wrote: > Cool, do you have commit access? I have commit access, yes REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7271 To: progwolff, #plasma, #vdg Cc:

D7271: optionally show a history of notifications

progwolff updated this revision to Diff 18139. progwolff added a comment. - fix typo REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7271?vs=18135=18139 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7271 AFFECTED FILES

D7271: optionally show a history of notifications

davidedmundson added a comment. Cool, do you have commit access? INLINE COMMENTS > Notifications.qml:92 > +//create a copy of the notification. > +//Disable actions in this copy as they will stop working once > the original notification ist closed. > +

D7271: optionally show a history of notifications

progwolff updated this revision to Diff 18135. progwolff added a comment. - simplify object copy REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7271?vs=18134=18135 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7271 AFFECTED

D7271: optionally show a history of notifications

progwolff updated this revision to Diff 18134. progwolff added a comment. - use the same delegate for persistent notifications and history items REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7271?vs=18075=18134 BRANCH master REVISION DETAIL

Re: DrKonqi

Yay for split! Well done \o/ On Sun, Aug 13, 2017 at 10:16 PM, David Edmundson wrote: > Harald, can you sort out all the cmake of both relating to your fancy unit > test. cmake logic is isolated inside the tests dir, so plasma-workspace and the new drkonqi should be

D7304: Do not leak symbols of pimpl classes, protect with Q_DECL_HIDDEN

davidedmundson created this revision. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY Nested classes inherit the visibility of their outer class, so all the KClass::Private symbols have

D6899: support X-KDE-OnlyShowOnQtPlatforms

This revision was automatically updated to reflect the committed changes. Closed by commit R297:937ade5d7357: support X-KDE-OnlyShowOnQtPlatforms (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D6899?vs=17177=18132#toc REPOSITORY R297 KDED CHANGES SINCE LAST UPDATE

D7256: emit previously shown notifications after resume from idle

davidedmundson added a comment. edit. 3 things. INLINE COMMENTS > notificationsengine.cpp:419 > removeSource(source); > emit NotificationClosed(id, closeReason); > } We need to be careful to not emit this twice. That would be a protocol error. I think we'll have

D7256: emit previously shown notifications after resume from idle

davidedmundson added a comment. I'm not particularly convinced. You watch a movie, you get some notifications, but ignore them. You move the mouse, you get told now completely out-of-date info. Also any notification created by KNotification with actions simply won't work. The

D7256: emit previously shown notifications after resume from idle

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. i like it! REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D7256 To: progwolff, #plasma, mart Cc: mart, plasma-devel, ZrenBot, progwolff,

D7271: optionally show a history of notifications

mart added inline comments. INLINE COMMENTS > progwolff wrote in Notifications.qml:257 > It's almost the same. Only the models differ (NotificationsModel is used in > NotificationDelegate, NotificationsHistoryModel is used in > NotificationHistoryDelegate). > > I also thought it might be a

D7257: Set the QtQuick Controls 1 style name explicitly

This revision was automatically updated to reflect the committed changes. Closed by commit R120:053d54488cdd: Set the QtQuick Controls 1 style name explicitly (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7257?vs=18020=18130

D7271: optionally show a history of notifications

davidedmundson added a comment. @notmart, click the "show older changes" and see reply to my first comment asking the same thing. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7271 To: progwolff, #plasma, #vdg Cc: mart, graesslin, davidedmundson,

D7259: Move QPainter compositor into plugin

mart added a comment. +1 REVISION DETAIL https://phabricator.kde.org/D7259 To: graesslin, #kwin, #plasma Cc: mart, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas

D7257: Set the QtQuick Controls 1 style name explicitly

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. thanks for looking into that REPOSITORY R120 Plasma Workspace BRANCH warnfix REVISION DETAIL https://phabricator.kde.org/D7257 To: fvogt, #plasma, mart Cc: mart, plasma-devel, ZrenBot,

D7271: optionally show a history of notifications

mart added inline comments. INLINE COMMENTS > NotificationHistoryDelegate.qml:27 > + > +PlasmaComponents.ListItem { > +id: notificationItem Why a different delegate for this? all the delegates, persistent or history should be the same REPOSITORY R120 Plasma Workspace REVISION DETAIL

D6964: Force Plasma style for QQC2 in applets

mart added a comment. ping? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D6964 To: mart, #plasma Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D6899: support X-KDE-OnlyShowOnQtPlatforms

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R297 KDED BRANCH master REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma, davidedmundson Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff,

D6899: support X-KDE-OnlyShowOnQtPlatforms

mart added a comment. ping? REPOSITORY R297 KDED REVISION DETAIL https://phabricator.kde.org/D6899 To: mart, #frameworks, #plasma Cc: dfaure, plasma-devel, broulik, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas

D7267: Add support for moving group members within a group.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:592dc9e0bc79: Add support for moving group members within a group. (authored by hein). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7267?vs=18120=18128

D7268: Use new libtm API to enable DND reordering within group dialogs.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7db2a6fbe394: Use new libtm API to enable DND reordering within group dialogs. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D7248: Microoptimise: don't change fillMode of image just before deleting itIt is still set for when a source is applied for the next transistion.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a44d84ef4749: Don't change fillMode of image just before deleting it (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D7078: [server] Fix crash when sending selection to a DDI without a DataSource

davidedmundson added a comment. > of course we do that :-) We're not. Kwin does not check if a client has a selection. It merely checks if the client has an interface from a selection can be fetched, it does not check that device actually has a valid selection. > you think

D7267: Add support for moving group members within a group.

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. +2 on either patch. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D7267 To: hein, #plasma, davidedmundson, argonel Cc:

D7267: Add support for moving group members within a group.

davidedmundson added a comment. If you don't want to do it, don't do it. Though I don't really understand what your concern is. If the parent is invalid, then it's invalid. The code will be the same. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D7267

D7268: Use new libtm API to enable DND reordering within group dialogs.

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D7268 To: hein, #plasma, davidedmundson, argonel Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D5579: Introduce QQuickItem to nest kwin_wayland

bdhruve added a subscriber: davidedmundson. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5579 To: bdhruve, #plasma_on_wayland, #kwin Cc: davidedmundson, graesslin, plasma-devel, kwin, leezu, ZrenBot, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg,

D7268: Use new libtm API to enable DND reordering within group dialogs.

hein updated this revision to Diff 18121. hein added a comment. Move check into dragging block. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7268?vs=18034=18121 BRANCH master REVISION DETAIL https://phabricator.kde.org/D7268 AFFECTED FILES

D7267: Add support for moving group members within a group.

hein updated this revision to Diff 18120. hein added a comment. Reduce code duplication. A bit queasy about just passing through parent though. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7267?vs=18033=18120 BRANCH master REVISION

D5579: Introduce QQuickItem to nest kwin_wayland

bdhruve added a subscriber: graesslin. bdhruve added a comment. Ping @graesslin @davidedumndson, should I do any more changes or this can be submitted? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D5579 To: bdhruve, #plasma_on_wayland, #kwin Cc: graesslin,

D7267: Add support for moving group members within a group.

hein added inline comments. INLINE COMMENTS > davidedmundson wrote in tasksmodel.cpp:1553 > This is the only bit that's different from the new code. > > Can we share the above and guard this with if(!parent) I was uncomfortable just always passing parent through in beginMoveRows without