D9353: Fix the user switcher not updating open sessions

fernando added a comment. Thanks. Here's an updated diff without the console.log(). As for commit access, I had it a very long time ago, but I have no idea if my key will still work. I'll try to push and let you know if I can't. REPOSITORY R114 Plasma Addons REVISION DETAIL

D9353: Fix the user switcher not updating open sessions

fernando updated this revision to Diff 24815. fernando marked an inline comment as done. fernando added a comment. Removed log statement I originally added for debugging. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9353?vs=23979=24815 REVISION

D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness

Zren marked an inline comment as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D6392 To: Zren, #plasma Cc: davidedmundson, broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D6392: [Panel Config] Scrolling over size button increments size by 2 and shows current thickness

Zren updated this revision to Diff 24808. Zren retitled this revision from "[Panel Config] Scrolling over size button increments size by 1 and shows current thickness" to "[Panel Config] Scrolling over size button increments size by 2 and shows current thickness". Zren edited the summary of this

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 54 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/54/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 06 Jan 2018 01:31:33 + Build duration: 10 min and counting JUnit Tests

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 53 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/53/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Sat, 06 Jan 2018 01:24:23 + Build duration: 5 min 20 sec and counting CONSOLE

D8922: Avoid jumping of items toward right/botton when dropping

hein added a comment. I'm going to revert this commit. It has made the DND experience very poor (icons jump around like crazy on drop). My review comment was ignored, and it went in after an accept by a developer who is not involved with Plasma development and doesn't maintain the codebase.

D9201: Slightly reduce vertical gutter width.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5ae880f84626: Slightly reduce vertical gutter width. (authored by Zren). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9201?vs=24677=24805 REVISION DETAIL

D9689: [WIP] Add a per-process CPU usage graph shown in the process list

fvogt updated this revision to Diff 24804. fvogt added a comment. Remove the history tail before appending the head to never exceed the reserved vector size REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9689?vs=24803=24804 BRANCH history

D9689: [WIP] Add a per-process CPU usage graph shown in the process list

fvogt created this revision. fvogt added a reviewer: Plasma. Restricted Application added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY By adding a new PercentageHistoryRole returning a QVector with timestamps and values, the delegate can show the history of the

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta, abetts Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai,

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta, abetts Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai,

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

rkflx added a comment. Thanks for the update. I won't need to test again, as the screenshots clearly show it working fine ;) If Hugo is happy with the code, this could land. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg,

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

ngraham edited the summary of this revision. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta, abetts Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

ngraham updated this revision to Diff 24801. ngraham added a comment. - Make Small replicate the old default shadow size - Rename Normal to Medium - Call the new default "Large" REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9627?vs=24771=24801 BRANCH

D9019: [Calendar] Adjust the calendar toolbar anchors

aacid added a comment. In https://phabricator.kde.org/D9019#172645, @akulichalexandr wrote: > In https://phabricator.kde.org/D9019#172612, @broulik wrote: > > > Thanks! It's the little things that make it feel polished :) > > > > Do you have commit access? > > > Yes, I have

D6567: Do not leak XVisualInfo (GLX path)

This revision was automatically updated to reflect the committed changes. Closed by commit R102:d1355c3a1ca9: Do not leak XVisualInfo (GLX path) (authored by madcatx, committed by aacid). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D6567?vs=16334=24798

D9684: Load config specified by the LnF theme

graesslin added a comment. I like it! REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D9684 To: davidedmundson, #plasma Cc: graesslin, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

rkflx added a comment. In https://phabricator.kde.org/D9627#186637, @ngraham wrote: > In https://phabricator.kde.org/D9627#186631, @rkflx wrote: > > > Works for the menu, but the window shadow is not as before for me. Maybe insert Tiny with 16px + 16px? > > > Are you sure? the

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

ngraham added a comment. In https://phabricator.kde.org/D9627#186631, @rkflx wrote: > As we now have three comboboxes (sizes of shadow, border, window buttons) all with slightly different options, we could think about unifying these, both in the number of options (not too many) and the

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

rkflx added a comment. In https://phabricator.kde.org/D9627#186592, @ngraham wrote: > FWIW, I rather prefer abstract words instead of numbers, since then we have more freedom to tweak the numbers under the hood in the future. The actual numbers aren't important enough to show to the

D9684: Load config specified by the LnF theme

davidedmundson updated this revision to Diff 24791. davidedmundson added a comment. Debug-- REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9684?vs=24788=24791 BRANCH master REVISION DETAIL https://phabricator.kde.org/D9684 AFFECTED FILES

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

abetts accepted this revision. abetts added a comment. Thanks guys! REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta, abetts Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9685: Add config for the lockscreen to toggle media controls

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY See related patch to kscreenlocker

D9658: Use explicit palette interface

This revision was automatically updated to reflect the committed changes. Closed by commit R135:0490a151f95b: Use explicit palette interface (authored by davidedmundson). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

hpereiradacosta added a comment. In https://phabricator.kde.org/D9627#186592, @ngraham wrote: > FWIW, I rather prefer abstract words instead of numbers, since then we have more freedom to tweak the numbers under the hood in the future. The actual numbers aren't important enough to show

D9684: Load config specified by the LnF theme

davidedmundson updated this revision to Diff 24788. davidedmundson added a comment. Remove unintended change to .ui file REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9684?vs=24787=24788 BRANCH master REVISION DETAIL

D9684: Load config specified by the LnF theme

davidedmundson added a comment. F5622292: Spectacle.fjteac.png REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D9684 To: davidedmundson, #plasma Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D9684: Load config specified by the LnF theme

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This is loaded in a QQuickView like the

D9601: Make media controls configurable

graesslin added a comment. In https://phabricator.kde.org/D9601#186415, @davidedmundson wrote: > > maybe we need a lnf specific config module? It's not the first feature where I would say that this actually doesn't belong into kscreenlocker kcm as it's specific to the theme. > > I

D9658: Use explicit palette interface

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. Soon my kdevelop will be black again! REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D9658 To:

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

ngraham added a comment. FWIW, I rather prefer abstract words instead of numbers, since then we have more freedom to tweak the numbers under the hood in the future. The actual numbers aren't important enough to show to the user IMHO. And if we do expose the number, people will eventually

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

abetts added a comment. In https://phabricator.kde.org/D9627#186584, @hpereiradacosta wrote: > In https://phabricator.kde.org/D9627#186582, @abetts wrote: > > > Would you consider changing the word "Normal" for something more related to measurements? For example, regular, default,

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

rkflx added a comment. In https://phabricator.kde.org/D9627#186583, @ngraham wrote: > How about "Medium"? It's not really of size medium, isn't it? However, compared to before 3 different sizes are not that many anyway, so we could insert an extra / actual "Medium", rename the

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

hpereiradacosta added a comment. In https://phabricator.kde.org/D9627#186582, @abetts wrote: > Would you consider changing the word "Normal" for something more related to measurements? For example, regular, default, current. Normal works better in other languages like Spanish where it

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

ngraham added a comment. How about "Medium"? REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta, abetts Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

abetts added a comment. Would you consider changing the word "Normal" for something more related to measurements? For example, regular, default, current. Normal works better in other languages like Spanish where it is related to measurements. In English that link is not as strong.

D9661: [TabBox] Don't show "Show desktop" window when cycling through application windows

graesslin accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9661 To: broulik, #plasma, #vdg, graesslin Cc: graesslin, plasma-devel,

Re: detecting tablet mode

Am 2018-01-05 16:11, schrieb Marco Martin: debugging a bit what happens currently on my machine, i don't seem to have any event device which libinput_device_switch_has_switch, however, when i flip it, i do get an event, but oddly from the event device called "intel virtual button driver" and i

Re: detecting tablet mode

Am 2018-01-05 12:48, schrieb Marco Martin: I would like to give it a try about it if you don't mind(ie had precise plans or code started).. I don't mind :-) so i was thinking about a property for the current state, plus a signal for state change. as for the location, into ConnectionAdaptor

D9201: Slightly reduce vertical gutter width.

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Thanks Chris! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9201 To: Zren, #plasma, hein Cc: ngraham, abetts, Zren, plasma-devel, ZrenBot, progwolff,

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

ngraham edited the summary of this revision. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta, abetts Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D9682: Don't build pci module on ARM

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R102:5d022b435fc4: Dont build pci module on ARM (authored by mart). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST

D9682: Don't build pci module on ARM

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D9682 To: mart, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9682: Don't build pci module on ARM

mart updated this revision to Diff 24783. mart removed a reviewer: broulik. mart added a comment. This revision now requires review to proceed. also exclude aarch64 REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9682?vs=24782=24783 BRANCH

D9671: Show only available profiles in Pulseaudio KCM

drosca requested changes to this revision. drosca added a comment. I'm ok with the part of the patch that moves availability property from Port to Profile. Adding availableProfiles is not a good way to achieve what you want though. Profiles should be filtered on QML side. REPOSITORY R115

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

ngraham edited the summary of this revision. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta, abetts Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D9678: Delay loading most used model

broulik added a comment. Seems to cause weird crashes regularly for me :/ (probably the `callLater`?) #0 0x722611b5 in QV4::QObjectWrapper::wrap(QV4::ExecutionEngine*, QObject*) () from /usr/lib/x86_64-linux-gnu/libQt5Qml.so.5 #1 0x722d9816 in ?? () from

Re: detecting tablet mode

debugging a bit what happens currently on my machine, i don't seem to have any event device which libinput_device_switch_has_switch, however, when i flip it, i do get an event, but oddly from the event device called "intel virtual button driver" and i get a key event of id 240. do you think it's a

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

ngraham edited the summary of this revision. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta, abetts Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D9072: make ksshaskpass work with git-lfs

mkoller added a comment. ping REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9072 To: mkoller, cfeck, jriddell, whiting Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

ngraham retitled this revision from "Use combobox to choose shadow size and reduce menu shadows to 25% of window shadow size" to "Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes". REPOSITORY R31 Breeze BRANCH master REVISION DETAIL

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

ngraham edited the test plan for this revision. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta, abetts Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D9627: Use combobox to choose shadow size and use more appropriate values for menu & tooltip shadow sizes

ngraham edited the test plan for this revision. REPOSITORY R31 Breeze BRANCH master REVISION DETAIL https://phabricator.kde.org/D9627 To: ngraham, #vdg, #breeze, hpereiradacosta, abetts Cc: rkflx, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D9627: Use combobox to choose shadow size and reduce menu shadows to 25% of window shadow size

ngraham retitled this revision from "Reduce menu shadows to 25% of the window shadow size" to "Use combobox to choose shadow size and reduce menu shadows to 25% of window shadow size". ngraham edited the summary of this revision. ngraham edited the test plan for this revision. REPOSITORY R31

D9627: Reduce menu shadows to 25% of the window shadow size

ngraham updated this revision to Diff 24771. ngraham added a comment. Use combobox to determine shadow size (massive amount of help from Hugo) REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9627?vs=24674=24771 BRANCH master REVISION DETAIL

D9478: Drop use of qtpaths in startkde

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. davidedmundson marked an inline comment as done. Closed by commit R120:fd7d1ca3d705: Drop use of qtpaths in startkde (authored by

D9668: Fix keyboard navigation not working after opening Folder View popup.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1466a873db05: Fix keyboard navigation not working after opening Folder View popup. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D9600: [Look and feel package definition] Add X-Plasma-Capabilities

broulik abandoned this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D9600 To: broulik, #plasma, davidedmundson Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D9601: Make media controls configurable

davidedmundson added a comment. > maybe we need a lnf specific config module? It's not the first feature where I would say that this actually doesn't belong into kscreenlocker kcm as it's specific to the theme. I like half of that. I think configuring the look and feel package

D9600: [Look and feel package definition] Add X-Plasma-Capabilities

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. I don't think this can work (as per comment in kscreenlocker review) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL

D9658: Use explicit palette interface

davidedmundson updated this revision to Diff 24765. davidedmundson added a comment. Lazy create the palette manager REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9658?vs=24722=24765 BRANCH master REVISION DETAIL

Re: detecting tablet mode

I would like to give it a try about it if you don't mind(ie had precise plans or code started).. so i was thinking about a property for the current state, plus a signal for state change. as for the location, into ConnectionAdaptor would probably be the easiest, iff makes semantically sense it

Re: detecting tablet mode

i am more than a little interested in having something like this to listen to. Windows being the only system with this detection in place (for several years now) just seems so silly... Also because it breaks every few weeks on there, where i expect we might be able to do /slightly/ better, at

D9659: Remove now unused set window property

This revision was automatically updated to reflect the committed changes. Closed by commit R135:ba25aa68afda: Remove now unused set window property (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9659?vs=24723=24764#toc REPOSITORY R135 Integration for Qt

D9643: Support submenus in context menu for systray icon

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D9643 To: volkov, #plasma, graesslin, davidedmundson Cc: broulik, davidedmundson,

D9643: Support submenus in context menu for systray icon

broulik added a comment. +1 I can verify that it makes VLC player's "Speed" sub menu in its tray icon work, checked that Qt's code is identical. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9643 To: volkov, #plasma,

D9657: Add manual test for win deco palettes

This revision was automatically updated to reflect the committed changes. Closed by commit R135:189a19f4e40d: Add manual test for win deco palettes (authored by davidedmundson). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 50 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/50/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 05 Jan 2018 09:56:07 + Build duration: 17 min and counting JUnit Tests

D9657: Add manual test for win deco palettes

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma BRANCH master REVISION DETAIL https://phabricator.kde.org/D9657 To: davidedmundson, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff,

D9658: Use explicit palette interface

broulik added a comment. lgtm INLINE COMMENTS > kwaylandintegration.cpp:72 > +if (paletteManagerInterface .name != 0) { > +m_paletteManager = > registry->createServerSideDecorationPaletteManager(paletteManagerInterface.name, > paletteManagerInterface.version,

D9659: Remove now unused set window property

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R135 Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D9659 To: davidedmundson, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 49 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/49/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 05 Jan 2018 09:24:52 + Build duration: 6 min 36 sec and counting CONSOLE

D9655: [Kickoff] Hide tab bar if only one tab button is configured

broulik edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D9655 To: broulik, #plasma, #vdg, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9655: [Kickoff] Hide tab bar if only one tab button is configured

This revision was automatically updated to reflect the committed changes. Closed by commit R119:cc0e08dc8846: [Kickoff] Hide tab bar if only one tab button is configured (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D9635: [AppMenuModel] Monitor window properties

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b12647946e19: [AppMenuModel] Monitor window properties (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9635?vs=24658=24758 REVISION

D9631: [DBusMenuImporter] Send "opened" signal alongside about to show

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b711b7073fd5: [DBusMenuImporter] Send opened signal alongside about to show (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D8529: Plasma change icons should exit after its work finished.

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH Plasma/5.11 REVISION DETAIL https://phabricator.kde.org/D8529 To: xuetianweng, apol, mart, #plasma, broulik Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai,

D9601: Make media controls configurable

broulik edited the test plan for this revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D9601 To: broulik, #plasma, #vdg, graesslin, davidedmundson Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D9601: Make media controls configurable

broulik updated this revision to Diff 24754. broulik added a comment. - Always show media controls config REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9601?vs=24567=24754 REVISION DETAIL https://phabricator.kde.org/D9601 AFFECTED FILES

D9661: [TabBox] Don't show "Show desktop" window when cycling through application windows

broulik updated this revision to Diff 24753. broulik added a comment. Restricted Application edited projects, added Plasma; removed KWin. - Check for != application windows REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9661?vs=24728=24753 REVISION DETAIL

D9668: Fix keyboard navigation not working after opening Folder View popup.

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D9668 To: hein, #plasma, broulik Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9601: Make media controls configurable

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in kcm.cpp:136 > This won't work. > > Kpacakges don't inherit metadata, so I think if you changed to breeze-dark > you'd get the controls but lose the ability to turn them off. > You can't assume that authors should copy