D10170: Added optional transparency/blur to menu frames

anemeth updated this revision to Diff 26407. anemeth added a comment. Added breezeblurhelper files REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10170?vs=26406=26407 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10170 AFFECTED FILES

D10170: Added optional transparency/blur to menu frames

anemeth updated this revision to Diff 26406. anemeth added a comment. Moved blur handling to breezeblurhelper REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10170?vs=26329=26406 BRANCH master REVISION DETAIL https://phabricator.kde.org/D10170 AFFECTED

D10263: Fix being unable to close the toolbox menu by clicking outside

hein created this revision. hein added reviewers: Plasma, mart. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY This also sort of broke using ESC to close, because that's what users try next, but after clicking on the desktop the dialog

D10262: [Look and feel KCM] Fix creating a broken colors scheme file in KcmTest

kossebau created this revision. kossebau added a reviewer: mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Writing just a sausage name into the test color scheme file

D10259: [Look and feel KCM] Fix copying color scheme data

kossebau added a comment. Oh, and this fixes the unit test "KcmTest::testKCMSave()" which is failing since https://phabricator.kde.org/R119:cf49d415e7bb30e98c0e7529e7307d8449b8ffcd (both in 5.12 and master after yesterday's merge). REPOSITORY R119 Plasma Desktop REVISION DETAIL

D10259: [Look and feel KCM] Fix copying color scheme data

kossebau edited the summary of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10259 To: kossebau, broulik, davidedmundson, mart Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10259: [Look and feel KCM] Fix copying color scheme data

kossebau added a comment. Another option would be to move the configGroup.writeEntry("ColorScheme", scheme); behind the config-copy loop. But then I would think that we do not want to blend in the kdeglobals config into the color schemes files data in general, or? There is

D10259: [Look and feel KCM] Fix copying color scheme data

kossebau created this revision. kossebau added reviewers: broulik, davidedmundson, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. kossebau requested review of this revision. REVISION SUMMARY Using one argument with

D10148: KCM: Show only available device profiles

nicolasfella requested changes to this revision. nicolasfella added a comment. This revision now requires changes to proceed. This leads to the wrong profile being selected. Because some profiles are excluded from the model the indices don't match anymore. REVISION DETAIL

D10148: KCM: Show only available device profiles

broulik added inline comments. INLINE COMMENTS > CardListItem.qml:57 > Layout.fillWidth: true > -model: Profiles > +model: { > +var m = []; model: Profiles.filter(function (profile) { return profile.availability === Profile.Available;

D10253: Fix dupe handling in requestAddLauncherToActivities; improve unit test

hein created this revision. hein added reviewers: Plasma, kossebau. Restricted Application added a project: Plasma. hein requested review of this revision. REVISION SUMMARY The business logic was using the resolved URL in lookups in internal data structures, instead of the internal key it

KDE CI: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 - Build # 27 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20stable-kf5-qt5%20FreeBSDQt5.9/27/ Project: Plasma plasma-desktop stable-kf5-qt5 FreeBSDQt5.9 Date of build: Fri, 02 Feb 2018 18:39:05 + Build duration: 3 min 40 sec and counting

D10251: [RFC] Use mipmap filtering in window thumbnails

hein added a comment. It's definitely nicer, but could we go for the full thing and make it crisper too? REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10251 To: fredrik, #plasma, #vdg Cc: hein, plasma-devel, #frameworks, michaelh, ZrenBot,

Re: Re: Plasma 4 bug reports: Open for bugs

Done.

D10252: Applet: Use new device icons

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D10252 To: drosca, #plasma, andreask, davidedmundson Cc: ngraham, plasma-devel, ZrenBot, progwolff,

Re: Re: Plasma 4 bug reports: Open for bugs

On Fri, 02 Feb 2018 07:46:11 -0800 Marco Martin wrote >On Thu, Feb 1, 2018 at 10:19 PM, David Edmundson > wrote: >> In bugzilla a product can be "Open for bug entry" or not. >> It can also be done at a per-version level. >> >> When unset a user will not

D10252: Applet: Use new device icons

drosca created this revision. drosca added reviewers: Plasma, andreask. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. drosca requested review of this revision. REVISION SUMMARY They were now added to Breeze icon theme REPOSITORY R115

D10188: Sanitise notification HTML

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in notificationsanitizer.cpp:45 > They don't, because that's not what we're parsing. > > We will parse Auml; which is handled > > Sending Ä will get Ä > Sending will show > > Old code is the same. I see. Nevermind

D10188: Sanitise notification HTML

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in notificationsanitizer.cpp:45 > We need a `QXmlStreamEntityResolver` like `KNotification` has otherwise HTML > entities like `` (for `Ä`) will error out. They don't, because that's not what we're parsing. We will parse

D10197: Fix krunner's alt+f2 on wayland

broulik added inline comments. INLINE COMMENTS > view.cpp:246 > - > m_plasmaShellSurface->setPanelBehavior(PlasmaShellSurface::PanelBehavior::WindowsGoBelow); > -m_plasmaShellSurface->setPanelTakesFocus(true); > -

D10250: track the validity of the texture

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Good analysis on the plotter. Thanks for looking into it. > but in some rare cases, it can be deleted too by some external cause, usually when a widget

D10188: Sanitise notification HTML

broulik added a comment. Thanks for taking care of this. INLINE COMMENTS > notificationsanitizer.cpp:45 > + > +QXmlStreamReader r(QStringLiteral("") + t + > QStringLiteral("")); > +QString result; We need a `QXmlStreamEntityResolver` like `KNotification` has otherwise HTML

D10184: Port mediawiki runner to Plasma5/Qt5

broulik added a comment. Lgtm INLINE COMMENTS > mediawiki.cpp:60 > //FIXME: at the moment KIO doesn't seem to work in threads > d->manager = new QNetworkAccessManager( this ); > //d->manager = new KIO::AccessManager( this ); Make sure to enable `QNetworkAccessManager`

D10250: track the validity of the texture

broulik added inline comments. INLINE COMMENTS > managedtexturenode.cpp:42 > +{ > +if (s_d.contains(this)) { > +delete s_d[this]; `delete s_d.take(this);` > managedtexturenode.cpp:50 > +{ > +if (s_d.contains(this)) { > +return s_d[this]; auto *d = s_d.value(this); if

Re: Plasma 4 bug reports: Open for bugs

On Thu, Feb 1, 2018 at 10:19 PM, David Edmundson wrote: > In bugzilla a product can be "Open for bug entry" or not. > It can also be done at a per-version level. > > When unset a user will not see it in the "enter bug" list, or the version > won't be listed. If they

D10247: Add a width ratio to the OverlaySheet

icota abandoned this revision. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10247 To: icota, #kirigami Cc: mart, plasma-devel, apol, davidedmundson, hein

D10251: [RFC] Use mipmap filtering in window thumbnails

fredrik added a comment. Before and after: F5688790: before-after.png REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10251 To: fredrik, #plasma, #vdg Cc: plasma-devel, #frameworks, michaelh, ZrenBot,

D10251: [RFC] Use mipmap filtering in window thumbnails

fredrik created this revision. fredrik added reviewers: Plasma, VDG. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. fredrik requested review of this revision. REVISION SUMMARY Blit the contents of the window texture

D10243: Improve visibility of disconnected Wi-Fi icons

ngraham added a comment. If this is only a change for the "disconnected wifi" icon, then maybe we should mimic the "disconnected wired network" icon and make the color red, rather than fiddling with the lightness, which will never satisfy everyone (if this merged, I predict bug reports that

D10247: Add a width ratio to the OverlaySheet

mart added a comment. hmm I don't think this is the right approach to it.. it should rather use size hints from the sheet contents (which if you want can also be a ratio of whatever the parent, but that would be user-specific) REPOSITORY R169 Kirigami REVISION DETAIL

D10247: Add a width ratio to the OverlaySheet

icota added a reviewer: Kirigami. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D10247 To: icota, #kirigami Cc: plasma-devel, apol, davidedmundson, mart, hein

D10250: track the validity of the texture

mart created this revision. mart added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. mart requested review of this revision. REVISION SUMMARY the texture of ManagedTextureNode gets deleted by

D10243: Improve visibility of disconnected Wi-Fi icons

ngraham added a comment. Thanks @andreask. Could we also see what it looks like next to the icon with all bars filled, or with only a few filled? This looks better for disconnected ones, but without seeing those use cases, it do worry that the presentation becomes too muddy for weak

D10151: Correction with the & problem in tabs

ngraham resigned from this revision. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D10151 To: carlavilla, mlaurent Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10151: Correction with the & problem in tabs

ngraham edited the summary of this revision. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D10151 To: carlavilla, mlaurent, ngraham Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D8054: Show headset icons for devices identifying as "Headset" in Description

andreask added a comment. icons are added to breeze-icons REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D8054 To: antlarr, #plasma, davidedmundson, drosca Cc: andreask, drosca, sebas, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10151: Correction with the & problem in tabs

carlavilla retitled this revision from "Solved bug 382512" to "Correction with the & problem in tabs". carlavilla edited the summary of this revision. carlavilla edited the test plan for this revision. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D10151 To:

D10151: Correction with the & problem in tabs

carlavilla added a comment. Sorry for my late response, but I've been moving all week. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D10151 To: carlavilla, mlaurent, ngraham Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10151: Solved bug 382512

mlaurent added a comment. Ping ? REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D10151 To: carlavilla, mlaurent, ngraham Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Plasma 4 bug reports: Open for bugs

On Fri, Feb 2, 2018 at 5:43 AM, Martin Flöser wrote: > Am 2018-02-01 22:19, schrieb David Edmundson: > >> In bugzilla a product can be "Open for bug entry" or not. >> It can also be done at a per-version level. >> >> When unset a user will not see it in the "enter bug" list,

D10247: Add a width ratio to the OverlaySheet

icota created this revision. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. icota requested review of this revision. REVISION SUMMARY Instead of hardcoding the OverlaySheet to half the mainItem width multiply by the ratio to enable

D10243: Improve visibility of disconnected Wi-Fi icons

andreask added a comment. F5688471: wifi icon.png top after - breeze(light) - breeze-dark bottom before - breeze(light) REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10243 To: andreask,

D5209: Load translations from KPackage files if bundled

ltoscano removed a dependency: D10215: Make KReport use marble component, KEXI & KEXI frameworks stable is 3.1. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D5209 To: davidedmundson, #plasma, mart Cc: ltoscano, Zren, plasma-devel, #frameworks,

D10243: Improve visibility of disconnected Wi-Fi icons

andreask retitled this revision from "Improve visibility of disconnected Wi-Fi icon" to "Improve visibility of disconnected Wi-Fi icons". REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10243 To: andreask, #plasma, #plasma_accessibility, sebas,

D10243: Improve visibility of disconnected Wi-Fi icon

andreask retitled this revision from "Disconnected wi-fi icons are almost invisible BUG:384018" to "Improve visibility of disconnected Wi-Fi icon". andreask edited the summary of this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10243

D10236: [libinput] Ensure Event::device returns a proper Device

avaragic accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH libinput-event-device REVISION DETAIL https://phabricator.kde.org/D10236 To: graesslin, #kwin, #plasma, fvogt,