Re: status of kde/plasma kiosk framework in kf5

2018-02-04 Thread Martin Flöser
Am 4. Februar 2018 22:33:02 MEZ schrieb Thomas Weissel : >Hello everybody, >Because this topic is still very important for me i continued to work >on - >and with the KDE Kiosk framework. > >I wanted to inform you about my latest project: >

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

2018-02-04 Thread Christoph Feck
cfeck requested changes to this revision. cfeck added a comment. This revision now requires changes to proceed. Please use the summary to describe what the patch does, not why you added it. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To:

D10305: Fix "Moving the mouse over a different application icon immediately changes the window list"

2018-02-04 Thread Christoph Feck
cfeck retitled this revision from "Framework patch: Moving the mouse over a different application icon immediately changes the window list" to "Fix "Moving the mouse over a different application icon immediately changes the window list"". cfeck edited the summary of this revision. REPOSITORY

D10305: Framework patch: Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Christoph Feck
cfeck set the repository for this revision to R242 Plasma Framework (Library). Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10305 To:

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2018-02-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=369676 Nate Graham changed: What|Removed |Added CC||pointedst...@zoho.com

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2018-02-04 Thread Nate Graham
https://bugs.kde.org/show_bug.cgi?id=369676 Nate Graham changed: What|Removed |Added See Also|

D10304: Plasma-desktop patch: Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Nathaniel Graham
ngraham added a comment. If the other patch applies properly, and is correctly marked as a dependency of this one, I //think// you can re-base this on master and it will work. But I'm pretty rubbish at dependent patches myself and will let someone else take over, REVISION DETAIL

D10188: Sanitise notification HTML

2018-02-04 Thread Albert Astals Cid
aacid added a comment. In https://phabricator.kde.org/D10188#201099, @zx2c4 wrote: > In https://phabricator.kde.org/D10188#201097, @davidedmundson wrote: > > > That would break very core functionality of existing clients and goes against the notification spec. > > > Then the

D10188: Sanitise notification HTML

2018-02-04 Thread Jason A . Donenfeld
zx2c4 added a comment. In https://phabricator.kde.org/D10188#201097, @davidedmundson wrote: > That would break very core functionality of existing clients and goes against the notification spec. Then the spec itself is vulnerable and needs to change. Switch people to data:

D10188: Sanitise notification HTML

2018-02-04 Thread David Edmundson
davidedmundson closed this revision. davidedmundson added a comment. That would break very core functionality of existing clients and goes against the notification spec. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10188 To: davidedmundson, #plasma,

D10188: Sanitise notification HTML

2018-02-04 Thread Jason A . Donenfeld
zx2c4 reopened this revision. zx2c4 added a comment. This revision is now accepted and ready to land. + const QUrl url(src); + if (url.isLocalFile()) { + out.writeAttribute(QStringLiteral("src"), src); + } else { + //image denied for security reasons! Do not copy the image src here!

D7087: Add "Copy Info" button to the About System KCM

2018-02-04 Thread gregormi
gregormi added a comment. In https://phabricator.kde.org/D7087#200541, @gregormi wrote: > - Add tooltip. Add keyboard shortcut Ctrl+C in the .ui file but it does not work (I will remove it if that's not easily fixable) @dhaumann: any idea why the shortcut does not work here?

D7087: Add "Copy Info" button to the About System KCM

2018-02-04 Thread gregormi
gregormi added inline comments. INLINE COMMENTS > ngraham wrote in Module.cpp:29 > Is this necessary for this patch? If not, let's address it in a different > patch or commit. This was a suggestion from the discussion on ReviewBoard. Is there an obvious way to tell arc to do this in a

D7087: Add "Copy Info" button to the About System KCM

2018-02-04 Thread gregormi
gregormi added a comment. In https://phabricator.kde.org/D7087#201047, @dhaumann wrote: > Translation is not yet working correctly, see above comment. In the comment of the function copyToClipboard(); I wrote the following: "Copies the software and hardware information to

D7087: Add "Copy Info" button to the About System KCM

2018-02-04 Thread Dominik Haumann
dhaumann requested changes to this revision. dhaumann added a comment. This revision now requires changes to proceed. Translation is not yet working correctly, see above comment. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham,

D7087: Add "Copy Info" button to the About System KCM

2018-02-04 Thread Dominik Haumann
dhaumann added a comment. All the keys in collectedData are not properly translated. As such, creating a final string out of this is not translation friendly. Given you seem to know exactly what data is going to be exported, you could also create a small helper class that gets filled.

D10304: Plasma-desktop patch: Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi added a comment. Can't seem to get the patches to apply properly. Anyone else that's gotten them to work? REVISION DETAIL https://phabricator.kde.org/D10304 To: lshoravi, #plasma, #plasma_accessibility Cc: ngraham, anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai,

D10305: Framework patch: Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi added a dependent revision: D10304: Plasma-desktop patch: Moving the mouse over a different application icon immediately changes the window list. REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility Cc: ngraham, plasma-devel, ZrenBot,

D10304: Plasma-desktop patch: Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi edited the summary of this revision. lshoravi added a dependency: D10305: Framework patch: Moving the mouse over a different application icon immediately changes the window list. REVISION DETAIL https://phabricator.kde.org/D10304 To: lshoravi, #plasma, #plasma_accessibility Cc:

D10304: Plasma-desktop patch: Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi removed a dependent revision: D10305: Framework patch: Moving the mouse over a different application icon immediately changes the window list. REVISION DETAIL https://phabricator.kde.org/D10304 To: lshoravi, #plasma, #plasma_accessibility Cc: ngraham, anthonyfieroni, plasma-devel,

D10305: Framework patch: Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi removed a dependency: D10304: Plasma-desktop patch: Moving the mouse over a different application icon immediately changes the window list. REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility Cc: ngraham, plasma-devel, ZrenBot, progwolff,

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2018-02-04 Thread Navid Zamani
https://bugs.kde.org/show_bug.cgi?id=369676 --- Comment #8 from Navid Zamani --- (In reply to Navid Zamani from comment #7) Oh, and with a black background, the outer glow would just be invisible. :) -- You are receiving this mail because: You are the assignee for

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

2018-02-04 Thread Navid Zamani
https://bugs.kde.org/show_bug.cgi?id=369676 Navid Zamani changed: What|Removed |Added CC|

D10302: [x11] Fix interactive point selection

2018-02-04 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH x11-point-selection REVISION DETAIL https://phabricator.kde.org/D10302 To: graesslin, #kwin, #plasma,

D10232: Include a pixel more in the dirty area

2018-02-04 Thread Mark Gaiser
markg requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D10232 To: mart, #plasma, #konsole, markg Cc: markg, hindenburg, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,

D10232: Include a pixel more in the dirty area

2018-02-04 Thread Mark Gaiser
markg added a comment. Please add a comment to the code for that. It might be obvious now, but the next person that looks at that code without knowledge of this change probably has a "huh, what is that?" moment and left wondering why it's done. REPOSITORY R319 Konsole REVISION DETAIL

Re: status of kde/plasma kiosk framework in kf5

2018-02-04 Thread Thomas Weissel
Hello everybody, Because this topic is still very important for me i continued to work on - and with the KDE Kiosk framework. I wanted to inform you about my latest project: https://github.com/valueerrorx/life-kiosk The github page has all the information so i'll try keeping it short: I

D10304: Plasma-desktop patch: Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi retitled this revision from "[BUG 358930] Moving the mouse over a different application icon immediately changes the window list" to "Plasma-desktop patch: Moving the mouse over a different application icon immediately changes the window list". lshoravi edited the summary of this

D10304: Plasma-desktop patch: Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D10304 To: lshoravi, #plasma, #plasma_accessibility Cc: ngraham, anthonyfieroni, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10305: Framework patch: Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility Cc: ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10305: Framework patch: Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi added a comment. Ah, got it. Updating the titles and reviews, working on the new diffs after that. Just got arcanist set up as well. Thanks for the help Nathan :) REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility Cc: ngraham,

D10148: KCM: Show only available device profiles

2018-02-04 Thread Nathaniel Graham
ngraham added a comment. Does this fully fix 365723? And if not, what more is needed there? REPOSITORY R115 Plasma Audio Volume Applet BRANCH arcpatch-D10148 REVISION DETAIL https://phabricator.kde.org/D10148 To: drosca, #plasma, nicolasfella Cc: ngraham, nicolasfella, broulik,

D10305: Framework patch: Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Nathaniel Graham
ngraham added a comment. Actually it's the opposite: the other patch depends on this one. This is the framework, and that other one uses the changes in this one. REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility Cc: ngraham, plasma-devel,

D10304: [BUG 358930] Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi added a dependent revision: D10305: Framework patch: Moving the mouse over a different application icon immediately changes the window list. REVISION DETAIL https://phabricator.kde.org/D10304 To: lshoravi, #plasma, #plasma_accessibility Cc: ngraham, anthonyfieroni, plasma-devel,

D10305: Framework patch: Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi retitled this revision from "[BUG 358930] Moving the mouse over a different application icon immediately changes the window list" to "Framework patch: Moving the mouse over a different application icon immediately changes the window list". lshoravi edited the summary of this revision.

D10232: Include a pixel more in the dirty area

2018-02-04 Thread Kurt Hindenburg
hindenburg added a comment. so this is a workaround? Where's the actual bug at? REPOSITORY R319 Konsole REVISION DETAIL https://phabricator.kde.org/D10232 To: mart, #plasma, #konsole Cc: hindenburg, ngraham, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10308: Send hoverLeave or hoverMotion after touch up on decoration

2018-02-04 Thread Martin Flöser
graesslin added a reviewer: ngraham. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10308 To: graesslin, #kwin, #plasma, ngraham Cc: plasma-devel, kwin, iodelay, bwowk, ZrenBot, progwolff, lesliezhai,

D10308: Send hoverLeave or hoverMotion after touch up on decoration

2018-02-04 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

D10305: [BUG 358930] Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Nathaniel Graham
ngraham added a comment. Thanks for doing this! A few notes: - Put "CCBUG: 358930" on its own line in the Summary; this will cause the commit to show up in that biug, without closing it. - No need to mention the bug number in the title (which becomes the commit message). - The title

D10304: [BUG 358930] Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Nathaniel Graham
ngraham added a comment. Thanks for doing this! A few notes: - Put "BUG: 358930" on its own line in the Summary; this will cause that bug to get closed once this goes in. - Put "Depends on https://phabricator.kde.org/D10305; on its own line in the Summary to mark that this patch

D10304: [BUG 358930] Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Anthony Fieroni
anthonyfieroni added a comment. You should increase minimal required plasma-framework version to 5.44 but when you do this this patch goes to master i.e. 5.13. REVISION DETAIL https://phabricator.kde.org/D10304 To: lshoravi, #plasma, #plasma_accessibility Cc: anthonyfieroni, plasma-devel,

D10305: [BUG 358930] Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10304: [BUG 358930] Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D10304 To: lshoravi, #plasma, #plasma_accessibility Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10305: [BUG 358930] Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D10305 To: lshoravi, #plasma, #plasma_accessibility Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10305: [BUG 358930] Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi created this revision. lshoravi added reviewers: Plasma, Plasma Accessibility. lshoravi added a project: Plasma. Restricted Application added a subscriber: plasma-devel. lshoravi requested review of this revision. REVISION SUMMARY Submitting Renées patch for bug 358930, as I can't find

D10304: [BUG 358930] Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi edited the summary of this revision. REVISION DETAIL https://phabricator.kde.org/D10304 To: lshoravi, #plasma, #plasma_accessibility Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10304: [BUG 358930] Moving the mouse over a different application icon immediately changes the window list

2018-02-04 Thread Linus Shoravi
lshoravi created this revision. lshoravi added reviewers: Plasma, Plasma Accessibility. lshoravi added a project: Plasma Accessibility. Restricted Application edited projects, added Plasma; removed Plasma Accessibility. Restricted Application added a subscriber: plasma-devel. lshoravi requested

D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed

2018-02-04 Thread David Edmundson
davidedmundson accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland BRANCH subsurface-parent-destroyed REVISION DETAIL https://phabricator.kde.org/D10300 To:

D7087: Add "Copy Info" button to the About System KCM

2018-02-04 Thread Nathaniel Graham
ngraham added a comment. The UI is much better now! Looks great and works fine. If you can't easily figure out how to make ctrl+c work, that's fine for now, and we can investigate that in a later patch. INLINE COMMENTS > Module.cpp:29 > #include > -#if KCOREADDONS_VERSION >=

D10300: [server] Don't crash when a subsurface gets commited whose parent surface got destroyed

2018-02-04 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: Frameworks, KWin, Plasma. Restricted Application added projects: Plasma on Wayland, Frameworks. Restricted Application added a subscriber: plasma-devel. graesslin requested review of this revision. Restricted Application edited projects,

D10297: Add new "Tools" button above System Monitor's process list

2018-02-04 Thread gregormi
gregormi added a comment. In https://phabricator.kde.org/D10297#200680, @ngraham wrote: > You can't just add the appropriate arrow icon to a regular button; you have to actually use the correct type of button from the start, and then it gets the icon in the right place automatically.

D10297: Add new "Tools" button above System Monitor's process list

2018-02-04 Thread Nathaniel Graham
ngraham added a comment. You can't just add the appropriate arrow icon to a regular button; you have to actually use the correct type of button from the start, and then it gets the icon in the right place automatically. Check out how the "All Processes" button is constructed, and you can

D10297: Add new "Tools" button above System Monitor's process list

2018-02-04 Thread gregormi
gregormi added a reviewer: floeser. gregormi added a comment. In https://phabricator.kde.org/D10297#200668, @ngraham wrote: > Seems useful! Couple of nitpicks: > > - `KsysGuard` itself appears in the menu :) Yes, I know :-(. When someone presses Ctrl+Esc then the System

D10297: Add new "Tools" button above System Monitor's process list

2018-02-04 Thread Nathaniel Graham
ngraham added a comment. Seems useful! Couple of nitpicks: - `KsysGuard` itself appears in the menu :) - The button should look like a dropdown menu button and have a downward-pointing arrow on the right side REPOSITORY R111 KSysguard Library REVISION DETAIL

D10297: Add new "Tools" button above System Monitor's process list

2018-02-04 Thread gregormi
gregormi edited the summary of this revision. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To: gregormi Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10297: Add new "Tools" button above System Monitor's process list

2018-02-04 Thread gregormi
gregormi added a comment. Add screenshot: F5691853: grafik.png REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To: gregormi Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10297: Add new "Tools" button above System Monitor's process list

2018-02-04 Thread gregormi
gregormi retitled this revision from "- Migrate from ReviewBoard https://git.reviewboard.kde.org/r/128854/ - fix QStringLiteral - Remove drop down arrow because it looks inconsistent with the widget left to it" to "Add new "Tools" button above System Monitor's process list". gregormi edited the

D10297: - Migrate from ReviewBoard https://git.reviewboard.kde.org/r/128854/- fix QStringLiteral- Remove drop down arrow because it looks inconsistent with the widget left to it

2018-02-04 Thread gregormi
gregormi created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gregormi requested review of this revision. TEST PLAN - Verify that each action in the menu works. - Verify that if the global keyboard shortcut for Kill

D10057: Require libinput and udev

2018-02-04 Thread Martin Flöser
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R108:bbf00fdd9808: Require libinput and udev (authored by graesslin). Restricted Application edited projects, added KWin;

D10156: Block geometry updates on move resize finish and don't configure xdg shell surfaces while blocked

2018-02-04 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:aefa11f11a25: Block geometry updates on move resize finish and dont configure xdg shell… (authored by graesslin). Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108

D10060: Enable blending if a subsurface has an alpha channel

2018-02-04 Thread Martin Flöser
This revision was automatically updated to reflect the committed changes. Closed by commit R108:e22d9d957b12: Enable blending if a subsurface has an alpha channel (authored by graesslin). Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin CHANGES SINCE

[Powerdevil] [Bug 362831] Do not increase brightness when entering low battery mode

2018-02-04 Thread Piotr Kloc
https://bugs.kde.org/show_bug.cgi?id=362831 --- Comment #2 from Piotr Kloc --- It seems to work better right now, instead of increasing brightness, it is being decreased. Can someone confirm? 5.11.95 on Arch -- You are receiving this mail because: You are the assignee for

D10294: Init the icon in ShellClient::init

2018-02-04 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

D10148: KCM: Show only available device profiles

2018-02-04 Thread Nicolas Fella
nicolasfella accepted this revision. nicolasfella added a comment. This revision is now accepted and ready to land. Looks good to me REPOSITORY R115 Plasma Audio Volume Applet BRANCH arcpatch-D10148 REVISION DETAIL https://phabricator.kde.org/D10148 To: drosca, #plasma, nicolasfella

D7087: Add "Copy Info" button to the About System KCM

2018-02-04 Thread gregormi
gregormi retitled this revision from "WIP: Add menu with "Copy to Clipboard" to the About System module" to "Add "Copy Info" button to the About System KCM". REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham Cc: ltoscano, sebas,

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

2018-02-04 Thread gregormi
gregormi updated this revision to Diff 26493. gregormi added a comment. - Add tooltip. Add keyboard shortcut Ctrl+C in the .ui file but it does not work (I will remove it if that's not easily fixable) REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D10280: Fix output device context menu

2018-02-04 Thread Nicolas Fella
This revision was automatically updated to reflect the committed changes. Closed by commit R115:f5c2a04e8d87: Fix output device context menu (authored by nicolasfella). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10280?vs=26463=26492

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

2018-02-04 Thread gregormi
gregormi updated this revision to Diff 26491. gregormi added a comment. - fix cleanup old code from previous revision REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7087?vs=26490=26491 BRANCH arcpatch-D7087 REVISION DETAIL

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

2018-02-04 Thread gregormi
gregormi updated this revision to Diff 26490. gregormi added a comment. - cleanup old code from previous revision REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7087?vs=26489=26490 BRANCH arcpatch-D7087 REVISION DETAIL

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

2018-02-04 Thread gregormi
gregormi updated this revision to Diff 26489. gregormi added a comment. - remove menu and update button position REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D7087?vs=17613=26489 BRANCH arcpatch-D7087 REVISION DETAIL

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

2018-02-04 Thread gregormi
gregormi added a comment. Screenshot of new button location: F5691627: grafik.png Updated code follows. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham Cc: ltoscano, sebas, elvisangelaccio,

D7087: WIP: Add menu with "Copy to Clipboard" to the About System module

2018-02-04 Thread gregormi
gregormi edited the summary of this revision. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D7087 To: gregormi, ngraham Cc: ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D10197: Fix krunner's alt+f2 on wayland

2018-02-04 Thread Martin Flöser
graesslin reopened this revision. graesslin added a comment. This revision is now accepted and ready to land. I just verified with KWin's debug console: KRunner window is now marked as NET::Normal and not as NET::Dock. This is a problem, KRunner needs to be a dock. REPOSITORY R120 Plasma

D10148: KCM: Show only available device profiles

2018-02-04 Thread David Rosca
drosca updated this revision to Diff 26480. drosca added a comment. Fixed issues REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10148?vs=26080=26480 BRANCH arcpatch-D10148 REVISION DETAIL https://phabricator.kde.org/D10148

D10197: Fix krunner's alt+f2 on wayland

2018-02-04 Thread Martin Flöser
graesslin added a comment. I fear this broke some functionality of KRunner. It is important to be a dock window! Otherwise KRunner might not be able to go above fullscreen windows and won't be on all desktops. Also without being a PlasmaSurface the manual positioning cannot work. If it