D10438: increase left/right margin of menuitems

2018-02-11 Thread Vlad Zagorodniy
zzag added a comment. > What other DE or OS that you used has such a wide menu that it feels natural to you? WIndows and macOS. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: abetts, anemeth,

D10438: increase left/right margin of menuitems

2018-02-11 Thread Vlad Zagorodniy
zzag added a comment. @ngraham, @abetts F5706528: without-checkboxes.png F5706532: with-checkboxes.png Margins: - left: 20 - right: 6 - top: 3 - bottom: 3 What do you think of this?

Re: Closing old Plasma 4 bugs

2018-02-11 Thread Ben Cooksley
On Mon, Feb 12, 2018 at 8:52 AM, Nate Graham wrote: > All right, so let's give it a shot. How about we make it so that normal > users have full privilages except the following: > > - Can't bulk change > - Can't change Importance field > - Can't re-open bugs in the CLOSED

D10438: increase left/right margin of menuitems

2018-02-11 Thread Vlad Zagorodniy
zzag updated this revision to Diff 26980. zzag added a comment. allow changing individual margins(e.g. left/right/top/bottom margin) REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10438?vs=26906=26980 BRANCH menuitem-margins REVISION DETAIL

[Powerdevil] [Bug 358957] laptop won't hybrid-suspend when Plasma is running

2018-02-11 Thread Navid Zamani
https://bugs.kde.org/show_bug.cgi?id=358957 Navid Zamani changed: What|Removed |Added CC|

D10438: increase left/right margin of menuitems

2018-02-11 Thread Andres Betts
abetts added a comment. This could work, just the left padding is too much in this patch. Maybe reduce by a 3rd? or Half? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: abetts, anemeth, plasma-devel,

D10438: increase left/right margin of menuitems

2018-02-11 Thread Nathaniel Graham
ngraham added a comment. I could //maybe// see this working for the left edge, but having such a lot of padding between the right edge and the arrows seems a little weird to me. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham,

D10438: increase left/right margin of menuitems

2018-02-11 Thread Alex Nemeth
anemeth added a comment. How does it look when a menu has a checkbox on it, for example the 'View' menu on Konsole F5705719: Screenshot_20180212_011947.png What other DE or OS that you used has such a wide menu that it feels natural to you?

D9875: Extend parsing ssh prompt

2018-02-11 Thread Pali Rohár
pali added a comment. Hi! Can somebody review/comment this patch? REPOSITORY R105 KDE SSH Password Dialog REVISION DETAIL https://phabricator.kde.org/D9875 To: pali Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-desktop kf5-qt5 SUSEQt5.9 - Build # 419 - Still unstable!

2018-02-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.9/419/ Project: Plasma plasma-desktop kf5-qt5 SUSEQt5.9 Date of build: Sun, 11 Feb 2018 21:56:29 + Build duration: 9 min 7 sec and counting JUnit Tests

D10297: Add new "Tools" button above System Monitor's process list

2018-02-11 Thread Nathaniel Graham
ngraham added a comment. In D10297#204581 , @rkflx wrote: > @ngraham Sorry, was busy working on Spectacle and Gwenview so did not get around to this yet. Would you mind filing the bug? https://bugs.kde.org/show_bug.cgi?id=390285 >

D10297: Add new "Tools" button above System Monitor's process list

2018-02-11 Thread Henrik Fehlauer
rkflx added a comment. In D10297#203197 , @ngraham wrote: > +2, wanna open a new bug for that? @andreaska can probably whip it up really quickly; he's a wizard with icons. @ngraham Sorry, was busy working on Spectacle and Gwenview so did

Re: Closing old Plasma 4 bugs

2018-02-11 Thread Nate Graham
All right, so let's give it a shot. How about we make it so that normal users have full privilages except the following: - Can't bulk change - Can't change Importance field - Can't re-open bugs in the CLOSED state Nate On 02/11/2018 09:17 AM, David Edmundson wrote: Interesting. If the

KDE CI: Plasma plasma-desktop kf5-qt5 SUSEQt5.9 - Build # 418 - Failure!

2018-02-11 Thread CI System
BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.9/418/ Project: Plasma plasma-desktop kf5-qt5 SUSEQt5.9 Date of build: Sun, 11 Feb 2018 17:18:28 + Build duration: 8 min 42 sec and counting CONSOLE OUTPUT

KDE CI: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 - Build # 139 - Still unstable!

2018-02-11 Thread CI System
BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20FreeBSDQt5.9/139/ Project: Plasma plasma-desktop kf5-qt5 FreeBSDQt5.9 Date of build: Sun, 11 Feb 2018 17:18:28 + Build duration: 8 min 36 sec and counting JUnit

Re: Closing old Plasma 4 bugs

2018-02-11 Thread David Edmundson
> Interesting. If the broader community is okay with this I see no > reason why we couldn't rearrange the permissions and how they're > currently setup. > I would prefer to restrict the bulk change tools to developers still > (as undoing the damage they do is much harder) but one-by-one changes >

Re: Closing old Plasma 4 bugs

2018-02-11 Thread Albert Astals Cid
El diumenge, 11 de febrer de 2018, a les 4:06:58 CET, Nate Graham va escriure: > + kde-devel to widen the conversation > > On 02/10/2018 05:48 PM, Nicolás Alvarez wrote: > > Meanwhile... maybe you can do some loud blog posts calling for triagers? > > :) > > Sounds good. Before then, we need to

Re: Closing old Plasma 4 bugs

2018-02-11 Thread Michael Pyne
On Sun, Feb 11, 2018 at 07:29:01PM +1300, Ben Cooksley wrote: > On Sun, Feb 11, 2018 at 4:06 PM, Nate Graham wrote: > > On 02/10/2018 05:48 PM, Nicolás Alvarez wrote: > >> > >> Meanwhile... maybe you can do some loud blog posts calling for triagers? > >> :) > > > > > >

D10342: From 1.03% to 0.08% cpu usage moving 50.000 files

2018-02-11 Thread Jaime Torres Amate
jtamate updated this revision to Diff 26937. jtamate edited the test plan for this revision. jtamate added a comment. In https://phabricator.kde.org/D9840 I noticed a high i/o and cpu usage when using the vivaldi browser, opening 10 tabs just caused a 40% cpu usage. Now, opening 10 tabs or

[Breeze] [Bug 364849] Tooltip Text in several qt apps such as Amarok and Krusader is unreadable (white on white) with the Breeze/Breeze Dark color schemes

2018-02-11 Thread Edmund Kasprzak
https://bugs.kde.org/show_bug.cgi?id=364849 Edmund Kasprzak changed: What|Removed |Added CC||edk...@gmail.com ---

D8267: Correcting symlinks between col- and row-resize and split_v and _hBug 384864

2018-02-11 Thread Anthony Fieroni
anthonyfieroni added a reviewer: apol. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D8267 To: ostroffjh, #plasma, apol Cc: apol, asturmlechner, cfeck, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D8267: Correcting symlinks between col- and row-resize and split_v and _hBug 384864

2018-02-11 Thread Andreas Sturmlechner
asturmlechner added a subscriber: apol. asturmlechner added a comment. It seems to me there was no change to these files since they were imported into this reporitory with 8ba33ca2a934dc1f2a34659eab1eef11f89c170c , so

D10425: Improve appearance of the logout dialog on wayland

2018-02-11 Thread Fabian Vogt
This revision was automatically updated to reflect the committed changes. Closed by commit R120:4d7c1345b784: Improve appearance of the logout dialog on wayland (authored by fvogt). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10425?vs=26891=26920

Re: Fullscreen and skip taskbar window

2018-02-11 Thread Bhushan Shah
Hello Martin, On Sat, Feb 10, 2018 at 05:38:25PM +0100, Martin Flöser wrote: > Just remove everything related to the shellsurface. You don't need that as > Qt takes care of creating the shell surface. So I made the changes and commented out the shellsurface related code.. However that again

D10440: Support modifier mouse/scroll action on internal decorated windows

2018-02-11 Thread Martin Flöser
graesslin created this revision. graesslin added reviewers: KWin, Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. graesslin requested review of this revision. Restricted Application edited projects, added Plasma; removed KWin.

D10438: increase left/right margin of menuitems

2018-02-11 Thread Vlad Zagorodniy
zzag edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10438: increase left/right margin of menuitems

2018-02-11 Thread Vlad Zagorodniy
zzag edited the summary of this revision. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D10438 To: zzag, #breeze, #vdg, ngraham, hpereiradacosta Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10438: increase left/right margin of menuitems

2018-02-11 Thread Vlad Zagorodniy
zzag created this revision. zzag added reviewers: Breeze, VDG, ngraham, hpereiradacosta. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY At a given moment, there is a small

D10383: Fix pinning apps when their .desktop file has a space in the file name.

2018-02-11 Thread Eike Hein
hein added a comment. In D10383#203804 , @ngraham wrote: > Is this expected to fully fix https://bugs.kde.org/show_bug.cgi?id=385942? No, because the reporters there used the ticket for multiple distinct issues. D10405

D10420: Make sure the FrameSvg and Svg instances have the right devicePixelRatio

2018-02-11 Thread Eike Hein
hein added a comment. Sanity check question: Did you make sure this doesn't introduce an extra render when things start up? (Initial vs. change.) Otherwise makes sense (and finally fixes some Wayland uglyness I've been annoyed by ...). REPOSITORY R242 Plasma Framework (Library)

D10408: Add option to enable shared folderview content per desktop

2018-02-11 Thread Eike Hein
hein added a comment. This should go into master only for now. BRANCH master REVISION DETAIL https://phabricator.kde.org/D10408 To: amantia, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10408: Add option to enable shared folderview content per desktop

2018-02-11 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. BRANCH master REVISION DETAIL https://phabricator.kde.org/D10408 To: amantia, #plasma, hein Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10407: Disable positioning in popup folderviews

2018-02-11 Thread Eike Hein
hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D10407 To: amantia, hein Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D10383: Fix pinning apps when their .desktop file has a space in the file name.

2018-02-11 Thread Eike Hein
hein added a comment. @ivan Could you suggest a good testcase? I'm a bit wary of pushing this into the LTS branch with a low amount of confidence. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D10383 To: hein, #plasma, broulik, ivan Cc: ngraham,