D10747: Implement zwp_linux_dmabuf_v1

2018-02-23 Thread Roman Gilg
romangg added a task: T8067: Support zwp_linux_dmabuf. Restricted Application edited projects, added Plasma on Wayland; removed Plasma. REPOSITORY R127 KWayland REVISION DETAIL https://phabricator.kde.org/D10747 To: fredrik, #kwin, #plasma, graesslin, davidedmundson, mart Cc: plasma-devel,

D10750: wayland: Add support for zwp_linux_dmabuf

2018-02-23 Thread Roman Gilg
romangg added a task: T8067: Support zwp_linux_dmabuf. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10750 To: fredrik, #kwin, #plasma, davidedmundson, mart, graesslin Cc: anthonyfieroni, plasma-devel,

D9414: Implement OSD to select action when unknown monitors is connected

2018-02-23 Thread Daniel Vrátil
This revision was automatically updated to reflect the committed changes. Closed by commit R104:5feb84305560: Merge branch dvratil/osd (authored by dvratil). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9414?vs=25635=27873#toc REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D9414: Implement OSD to select action when unknown monitors is connected

2018-02-23 Thread Daniel Vrátil
dvratil added a comment. @ngraham Yes, the screenshot is still accurate. If you want a screenshot with more of background or another background, I can provide one. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To: dvratil, sebas, davidedmundson, #vdg Cc:

D10750: wayland: Add support for zwp_linux_dmabuf

2018-02-23 Thread Anthony Fieroni
anthonyfieroni added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > abstract_egl_backend.cpp:117 > +for (auto *dmabuf : qAsConst(m_dmabufBuffers)) { > +dmabuf->destroyImage(); > +} Call delete dmabuf will have same effect.

D10659: [AppletConfiguration] Let applet override Return closing the dialog

2018-02-23 Thread Friedrich W . H . Kossebau
kossebau added a subscriber: mart. kossebau added a comment. In D10659#209961 , @broulik wrote: > > Can this property become something more official, with real documentation > > Sure. If you tell me where the other features of the config

D10774: [Shell Handler] Port from own QQmlEngine to using QmlObjectSharedEngine

2018-02-23 Thread Kai Uwe Broulik
broulik updated this revision to Diff 27862. broulik added a comment. - Remove debug REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10774?vs=27861=27862 REVISION DETAIL https://phabricator.kde.org/D10774 AFFECTED FILES shell/shellmanager.cpp

D10774: [Shell Handler] Port from own QQmlEngine to using QmlObjectSharedEngine

2018-02-23 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I noticed in GammaRay there were two `QQmlEngine` instances in a

D10762: Fix the build on armhf/aarch64

2018-02-23 Thread Martin Flöser
graesslin requested changes to this revision. graesslin added inline comments. This revision now requires changes to proceed. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > kwinglplatform.cpp:22 > #include "kwinglplatform.h" > +#include

D10773: Port to QmlObjectSharedEngine in all remaining places

2018-02-23 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY OSD, Applet Alternatives, and Interactive Console were still

D10750: wayland: Add support for zwp_linux_dmabuf

2018-02-23 Thread Fredrik Höglund
fredrik edited projects, added Plasma; removed KWin. fredrik added a comment. Restricted Application edited projects, added KWin; removed Plasma. In D10750#211784 , @graesslin wrote: > Concerning the tests: the ones requiring OpenGL work best if

D10769: [Dialog] Remove now obsolete KWindowSystem::setState calls

2018-02-23 Thread Kai Uwe Broulik
broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY The comment says it's resolved in Qt 5.6.1+

D10767: Multiple Layout, General Improvements and Bug Fixes

2018-02-23 Thread Aditya Mehra
This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R846:8f7fcb4d0a94: Multiple Layout, General Improvements and Bug Fixes (authored by Aiix). REPOSITORY R846 Mycroft

D10767: Multiple Layout, General Improvements and Bug Fixes

2018-02-23 Thread Aditya Mehra
Aiix created this revision. Aiix added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. Aiix requested review of this revision. REVISION SUMMARY Ref T7175 Multiple Layout and General

D9414: Implement OSD to select action when unknown monitors is connected

2018-02-23 Thread Nathaniel Graham
ngraham added a comment. Is the screenshot in the Summary section still accurate? I'd like to feature this in the coming weekend's Usability & Productivity blog post (assuming it lands today or tomorrow; if not, next week's post), and people love looking at screenshots. REPOSITORY R104

D10764: [AppletQuickItem] Preload applet expander only if not already expanded

2018-02-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R242:48b62d1a2763: [AppletQuickItem] Preload applet expander only if not already expanded (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D10764: [AppletQuickItem] Preload applet expander only if not already expanded

2018-02-23 Thread Marco Martin
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10764 To: broulik, #plasma, mart, lbeltrame Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed,

D10753: Provide the source selection as a contextual action

2018-02-23 Thread Aleix Pol Gonzalez
apol added a comment. > I see what you're going for here, but the "Sources" menu you're trying to add still doesn't actually work, same as the Sort menu. Is there an open Kirigami patch that this depends upon? No, please look into how it's possible that it's not working for you. I'll be

D10753: Provide the source selection as a contextual action

2018-02-23 Thread Aleix Pol Gonzalez
apol updated this revision to Diff 27842. apol added a comment. Remove the description part of origin switching REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10753?vs=27816=27842 BRANCH sourcesUI REVISION DETAIL

D10764: [AppletQuickItem] Preload applet expander only if not already expanded

2018-02-23 Thread Luca Beltrame
lbeltrame added a comment. +1 from me, fixes the issue I had. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D10764 To: broulik, #plasma, mart, lbeltrame Cc: plasma-devel, #frameworks, michaelh, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D10692: parent full representation to the proper window at start

2018-02-23 Thread Marco Martin
This revision was automatically updated to reflect the committed changes. Closed by commit R120:b17fa4bea6f4: parent full representation to the proper window at start (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D10692: parent full representation to the proper window at start

2018-02-23 Thread Marco Martin
mart updated this revision to Diff 27840. mart added a comment. - remove useless z reassignment REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10692?vs=27767=27840 BRANCH arcpatch-D10692 REVISION DETAIL https://phabricator.kde.org/D10692

D10692: parent full representation to the proper window at start

2018-02-23 Thread Kai Uwe Broulik
broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D10692 REVISION DETAIL https://phabricator.kde.org/D10692 To: mart, #plasma, broulik Cc: apol, broulik, hein, davidedmundson, plasma-devel, ZrenBot,

D9414: Implement OSD to select action when unknown monitors is connected

2018-02-23 Thread Sebastian Kügler
sebas added a comment. When landing, can you merge the whole branch into master, the history here is relevant and it will make continuing work on my kscreen kcm qmlification branch a lot easier. Thanks! REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To:

D10563: Place toolbox in the top right corner of the screen

2018-02-23 Thread Kai Uwe Broulik
This revision was automatically updated to reflect the committed changes. Closed by commit R119:b2588104cc56: Place toolbox in the top right corner of the screen (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10563?vs=27306=27839

D9414: Implement OSD to select action when unknown monitors is connected

2018-02-23 Thread Sebastian Kügler
sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To: dvratil, sebas, davidedmundson, #vdg Cc: abetts, broulik, kamathraghavendra, graesslin, ngraham, plasma-devel, mlaurent, ZrenBot,

D10660: [Weather applet] Let Return invoke search

2018-02-23 Thread Kai Uwe Broulik
broulik edited the summary of this revision. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D10660 To: broulik, #plasma, kossebau Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D10764: [AppletQuickItem] Preload applet expander only if not already expanded

2018-02-23 Thread Kai Uwe Broulik
broulik created this revision. broulik added reviewers: Plasma, mart, lbeltrame. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. broulik requested review of this revision. REVISION SUMMARY When an applet is placed on

D10723: hide primary display combo when not supported

2018-02-23 Thread Sebastian Kügler
This revision was automatically updated to reflect the committed changes. Closed by commit R104:cd3b350e0225: hide primary display combo when not supported (authored by sebas). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10723?vs=27721=27835 REVISION

D10762: Fix the build on armhf/aarch64

2018-02-23 Thread Bhushan Shah
bshah updated this revision to Diff 27834. bshah added a comment. Restricted Application edited projects, added Plasma; removed KWin. cover all the cases of epoxy I am not really sure if this is right approch, suggestions welcome REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D10755: Add a MsmApp::skillsPath method so the skills folder is not hardcoded

2018-02-23 Thread Phabricator
This revision was automatically updated to reflect the committed changes. Closed by commit R846:ab71b7d7b05b: Add a MsmApp::skillsPath method so the skills folder is not hardcoded (authored by Antonio Larrosa antonio.larr...@gmail.com). REPOSITORY R846 Mycroft Plasma integration CHANGES