D11253: Improve discoverability for changing the wallpaper

[Richard Bowen]

richardbowen added a comment.


  The preferences-desktop-wallpaper icon beside "Configure Desktop" works.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ragreen, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11253: Improve discoverability for changing the wallpaper

[Nathaniel Graham]

ngraham added a comment.


  Is everyone still ambivalent about this? Is there anything I can do to make 
it more palatable, or should I give up?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11253

To: ngraham, #plasma, davidedmundson
Cc: mart, hein, broulik, richardbowen, plasma-devel, ragreen, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11722: If GL context creation fails fall back to the software renderer

[Martin Flöser]

graesslin added a comment.


  I like this change

INLINE COMMENTS

> desktopview.cpp:63
>  [this, corona]() {
> +qDebug() << QQuickWindow::sceneGraphBackend();
>  // check whether the GL Context supports OpenGL

This looks like too much debug or like a need of qcdebug

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11722

To: davidedmundson, #plasma
Cc: graesslin, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11663: Add InlineMessage type and Gallery app example page

[David Edmundson]

davidedmundson added a comment.


  Very nice!

INLINE COMMENTS

> InlineMessage.qml:225-226
> +wrapMode: Text.WordWrap
> +elide: Text.ElideRight
> +verticalAlignment: lineCount > 1 ? Qt.AlignVCenter : 
> Qt.AlignTop
> +

I don't think either of these two lines will work as you intend as you've not 
constrained the label height anywhere

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: davidedmundson, ngraham, broulik, plasma-devel, apol, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein added subscribers: broulik, ngraham.
hein added a comment.


  Adding back subscribers, sorry, my arc invocation to do the above removed you.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: ngraham, broulik, plasma-devel, apol, davidedmundson, mart, hein

D11726: Vastly simplify image wallpaper code

[David Edmundson]

davidedmundson updated this revision to Diff 30649.
davidedmundson added a comment.


  update

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11726?vs=30648=30649

BRANCH
  davidedmundson/wallpaperrewrite

REVISION DETAIL
  https://phabricator.kde.org/D11726

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11726: Vastly simplify image wallpaper code

[David Edmundson]

davidedmundson updated this revision to Diff 30648.
davidedmundson added a comment.


  use a better variable name before anyone sees it

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11726?vs=30647=30648

BRANCH
  davidedmundson/wallpaperrewrite

REVISION DETAIL
  https://phabricator.kde.org/D11726

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11726: Vastly simplify image wallpaper code

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The image wallpaper is a mess of 4 different fade functions, some not in
  sync, and very complicated swapping images about.
  
  This simplifies the whole thing by using a StackView, we just pop our
  setup with a new configuration on and it handles deleting old objects
  when the transition ends.
  
  Code is 1/3 the size, whislt doing the same thing and should result in 
  having fewer items about.
  
  In addition with this patch changing the transition effect in future 
  would be super trivial.

TEST PLAN
  Set as both image and wallpaper
  Renders stuff as before

REPOSITORY
  R120 Plasma Workspace

BRANCH
  davidedmundson/wallpaperrewrite

REVISION DETAIL
  https://phabricator.kde.org/D11726

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/main.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11722: If GL context creation fails fall back to the software renderer

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  If we cannot create a GL context, instead of showing an error and
  quitting, switch to using the QtQuick software renderer and restart.
  
  If software mode is already set, then show the error as before. This
  could happen in the case of the software renderer not being installed.

TEST PLAN
  After doing some driver changing, I ended up with the annoying "plasma can't 
start" 
  message.
  
  Without the entry in kdeglobals I now start plasma and it seamlessly comes up
  working.
  
  It's almost too seamless, I probably need to add an SNI with a message
  but it's blocked on a decision on handling that KCM.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11722

AFFECTED FILES
  shell/desktopview.cpp
  shell/main.cpp
  shell/shellcorona.cpp
  shell/shellcorona.h
  shell/shellmanager.cpp
  shell/shellmanager.h

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma plasma-pa kf5-qt5 FreeBSDQt5.9 - Build # 22 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-pa%20kf5-qt5%20FreeBSDQt5.9/22/
 Project:
Plasma plasma-pa kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 26 Mar 2018 17:16:41 +
 Build duration:
9 min 21 sec and counting
   CONSOLE OUTPUT
  [...truncated 145.25 KB...]Unknown property type for key "X-KDE-Keywords[sl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavian]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavianlatin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@latin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sv]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[tr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[uk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[x-test]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_CN]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_TW]" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma plasma-pa kf5-qt5 FreeBSDQt5.9/build/src/kcm/kcm_pulseaudio.json" [ 12%] Built target org.kde.plasma.volume-plasmoids-metadata-json[ 12%] Built target kcm_pulseaudio-kcms-metadata-json[ 15%] Automatic MOC for target kcm_pulseaudio[ 15%] Built target kcm_pulseaudio_autogenScanning dependencies of target kcm_pulseaudio[ 20%] Building CXX object src/kcm/CMakeFiles/kcm_pulseaudio.dir/kcm_pulseaudio_autogen/mocs_compilation.cpp.o[ 20%] Building CXX object src/kcm/CMakeFiles/kcm_pulseaudio.dir/module.cpp.o[ 20%] Built target doc-kcontrol-plasma-pa-index-cache-bz2[ 22%] Linking CXX shared module kcm_pulseaudio.so[ 22%] Built target kcm_pulseaudio[ 22%] Built target plasma-volume-declarative_autogen[ 25%] Generating osdservice.cpp, osdservice.h[ 27%] Generating osdservice.mocScanning dependencies of target plasma-volume-declarative[ 30%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/osdservice.cpp.o[ 32%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/context.cpp.o[ 35%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/card.cpp.o[ 37%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/client.cpp.o[ 40%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/maps.cpp.o[ 42%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/device.cpp.o[ 45%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/operation.cpp.o[ 47%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/port.cpp.o[ 50%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/profile.cpp.o[ 52%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/pulseaudio.cpp.o[ 55%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/pulseobject.cpp.o[ 57%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/sink.cpp.o[ 60%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/sinkinput.cpp.o[ 62%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/modulemanager.cpp.o[ 65%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/gconfitem.cpp.o[ 67%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/source.cpp.o[ 70%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/sourceoutput.cpp.o[ 72%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/stream.cpp.o[ 75%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/volumeobject.cpp.o[ 77%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/debug.cpp.o[ 80%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/server.cpp.o[ 82%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/streamrestore.cpp.o[ 85%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/module.cpp.o[ 87%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/qml/globalactioncollection.cpp.o[ 90%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/qml/plugin.cpp.o[ 92%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/qml/volumeosd.cpp.o[ 95%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/qml/volumefeedback.cpp.o[ 97%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/plasma-volume-declarative_autogen/mocs_compilation.cpp.o[100%] Linking CXX shared library libplasma-volume-declarative.so[100%] Built target plasma-volume-declarative[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Installing)[Pipeline] sh[Plasma plasma-pa kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/install-build.py --product Plasma --project plasma-pa --branchGroup kf5-qt5 --platform FreeBSDQt5.9 --installTo 

D11721: Fix issues in models to pass ModelTest

[David Rosca]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:d498ec301bb3: Fix issues in models to pass ModelTest 
(authored by drosca).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11721?vs=30639=30640

REVISION DETAIL
  https://phabricator.kde.org/D11721

AFFECTED FILES
  src/maps.h
  src/pulseaudio.cpp
  src/pulseaudio.h

To: drosca, #plasma, broulik
Cc: davidedmundson, broulik, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11721: Fix issues in models to pass ModelTest

[David Rosca]

drosca updated this revision to Diff 30639.
drosca added a comment.


  fix issues

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11721?vs=30638=30639

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11721

AFFECTED FILES
  src/maps.h
  src/pulseaudio.cpp
  src/pulseaudio.h

To: drosca, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11721: Fix issues in models to pass ModelTest

[David Rosca]

drosca added inline comments.

INLINE COMMENTS

> broulik wrote in maps.h:116
> This creates a temporary list just to iterate it, better use iterators and 
> then `key()` provided by it (I bet there's even a fancy `std` algorithm for 
> what you're trying to do here)

Some fancy `std` algorithm gives me iterator, but I need index (and 
`std::distance` is another traverse because map iterator is not 
RandomAccessIterator).

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11721

To: drosca, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11721: Fix issues in models to pass ModelTest

[David Edmundson]

davidedmundson added a comment.


  Other than Kai's coments, ++ good stuff. thanks

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11721

To: drosca, #plasma
Cc: davidedmundson, broulik, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11721: Fix issues in models to pass ModelTest

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> maps.h:116
> +int modelIndex = 0;
> +const auto keys = m_data.keys();
> +for (quint32 key : keys) {

This creates a temporary list just to iterate it, better use iterators and then 
`key()` provided by it (I bet there's even a fancy `std` algorithm for what 
you're trying to do here)

> pulseaudio.h:41
>  
> +~AbstractModel();
>  QHash roleNames() const Q_DECL_FINAL;

`override`?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11721

To: drosca, #plasma
Cc: broulik, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11721: Fix issues in models to pass ModelTest

[David Rosca]

drosca updated this revision to Diff 30638.
drosca added a comment.


  whitespace

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11721?vs=30637=30638

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11721

AFFECTED FILES
  src/maps.h
  src/pulseaudio.cpp
  src/pulseaudio.h

To: drosca, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11721: Fix issues in models to pass ModelTest

[David Rosca]

drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
drosca requested review of this revision.

TEST PLAN
  Did all sort of things with pulseaudio and all ModelTest tests passed.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11721

AFFECTED FILES
  src/maps.h
  src/pulseaudio.cpp
  src/pulseaudio.h

To: drosca, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Vlad Zagorodniy]

zzag added a comment.


  In D9848#234654 , @anemeth wrote:
  
  > > `GLRenderTarget::setTextureDirty`
  >
  > I added this because on line (1101 <---> 1124) the `disable()` function 
that also sets the texture dirty was moved into a condition.
  >  I don't know where the dirty parameter is used or checked, I didn't go 
look that far into it.
  
  
  It does nothing pretty much. 
https://github.com/KDE/kwin/blob/master/libkwineffects/kwingltexture.cpp#L569
  
  > For functions that are not used feel free to create a patch that removes 
them.
  
  No, I just asked why you added those changes, that's all. :)
  Also, I'm not a KWin developer so that's not up to me to decide whether they 
should be removed. ;-)

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin, fredrik
Cc: hein, dos, luebking, broulik, romangg, zzag, anthonyfieroni, mart, 
davidedmundson, fredrik, ngraham, plasma-devel, kwin, #kwin, ragreen, iodelay, 
bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, 
sebas, apol

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

[Alex Nemeth]

anemeth added a comment.


  In D9848#234268 , @zzag wrote:
  
  >
  
  
  
  
  > `GLRenderTarget::attachTexture`
  
  This was not changed.
  It was used by old blur and simple blur.
  Looks like it's not used anymore.
  
  > `GLRenderTarget::detachTexture`
  
  This was used by simple blur, but that has been removed in D10181 

  I left it in in case something might use it in the future.
  
  > empty GLRenderTarget constructor
  
  Also was used by simple blur.
  
  > `GLRenderTarget::setTextureDirty`
  
  I added this because on line (1101 <---> 1124) the `disable()` function that 
also sets the texture dirty was moved into a condition.
  I don't know where the dirty parameter is used or checked, I didn't go look 
that far into it.
  
  For functions that are not used feel free to create a patch that removes them.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D9848

To: anemeth, #plasma, #kwin, fredrik
Cc: hein, dos, luebking, broulik, romangg, zzag, anthonyfieroni, mart, 
davidedmundson, fredrik, ngraham, plasma-devel, kwin, #kwin, ragreen, iodelay, 
bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, 
sebas, apol

KDE CI: Plasma plasma-pa kf5-qt5 FreeBSDQt5.9 - Build # 21 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-pa%20kf5-qt5%20FreeBSDQt5.9/21/
 Project:
Plasma plasma-pa kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 26 Mar 2018 14:15:10 +
 Build duration:
2 min 7 sec and counting
   CONSOLE OUTPUT
  [...truncated 144.85 KB...]Unknown property type for key "X-KDE-Keywords[sl]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavian]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@ijekavianlatin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sr@latin]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[sv]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[tr]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[uk]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[x-test]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_CN]" -> falling back to stringUnknown property type for key "X-KDE-Keywords[zh_TW]" -> falling back to stringGenerated  "/usr/home/jenkins/workspace/Plasma plasma-pa kf5-qt5 FreeBSDQt5.9/build/src/kcm/kcm_pulseaudio.json" [ 12%] Automatic MOC for target kcm_pulseaudio[ 12%] Built target kcm_pulseaudio_autogenScanning dependencies of target doc-kcontrol-plasma-pa-index-cache-bz2[ 15%] Generating index.cache.bz2[ 15%] Built target doc-kcontrol-plasma-pa-index-cache-bz2Scanning dependencies of target kcm_pulseaudio[ 17%] Building CXX object src/kcm/CMakeFiles/kcm_pulseaudio.dir/module.cpp.o[ 20%] Building CXX object src/kcm/CMakeFiles/kcm_pulseaudio.dir/kcm_pulseaudio_autogen/mocs_compilation.cpp.o[ 20%] Built target plasma-volume-declarative_autogen[ 22%] Generating osdservice.cpp, osdservice.h[ 25%] Generating osdservice.mocScanning dependencies of target plasma-volume-declarative[ 27%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/osdservice.cpp.o[ 30%] Linking CXX shared module kcm_pulseaudio.so[ 30%] Built target kcm_pulseaudio[ 32%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/card.cpp.o[ 35%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/client.cpp.o[ 37%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/context.cpp.o[ 40%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/device.cpp.o[ 42%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/maps.cpp.o[ 45%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/operation.cpp.o[ 47%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/port.cpp.o[ 50%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/profile.cpp.o[ 52%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/pulseaudio.cpp.o[ 55%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/pulseobject.cpp.o[ 57%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/sink.cpp.o[ 60%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/sinkinput.cpp.o[ 62%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/modulemanager.cpp.o[ 65%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/gconfitem.cpp.o[ 67%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/source.cpp.o[ 70%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/sourceoutput.cpp.o[ 72%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/stream.cpp.o[ 75%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/volumeobject.cpp.o[ 77%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/debug.cpp.o[ 80%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/server.cpp.o[ 82%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/streamrestore.cpp.o[ 85%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/module.cpp.o[ 87%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/qml/globalactioncollection.cpp.o[ 90%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/qml/plugin.cpp.o[ 92%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/qml/volumeosd.cpp.o[ 95%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/qml/volumefeedback.cpp.o[ 97%] Building CXX object src/CMakeFiles/plasma-volume-declarative.dir/plasma-volume-declarative_autogen/mocs_compilation.cpp.o[100%] Linking CXX shared library libplasma-volume-declarative.so[100%] Built target plasma-volume-declarative[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Installing)[Pipeline] sh[Plasma plasma-pa kf5-qt5 FreeBSDQt5.9] Running shell script+ python3.5 -u ci-tooling/helpers/install-build.py --product Plasma --project plasma-pa --branchGroup kf5-qt5 --platform FreeBSDQt5.9 --installTo /usr/home/jenkins/install-prefix/ --divertTo 

D11613: call beginRemoveRows before removing the data

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:722ee38399a1: call beginRemoveRows before removing the 
data (authored by davidedmundson).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11613?vs=30315=30633

REVISION DETAIL
  https://phabricator.kde.org/D11613

AFFECTED FILES
  src/maps.h
  src/pulseaudio.cpp

To: davidedmundson, #plasma, drosca
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11606: [WebBrowser Plasmoid] Support opening external links

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:0319b3e9c96f: [WebBrowser Plasmoid] Support opening 
external links (authored by broulik).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11606?vs=30291=30632

REVISION DETAIL
  https://phabricator.kde.org/D11606

AFFECTED FILES
  applets/webbrowser/package/contents/ui/main.qml

To: broulik, #plasma, #vdg
Cc: davidedmundson, Murz, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11613: call beginRemoveRows before removing the data

[David Rosca]

drosca added a comment.


  Into Plasma/5.12 please.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11613

To: davidedmundson, #plasma, drosca
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> libinput_settings.cpp:26
> +{
> +KConfig config("kcminputrc");
> +KConfigGroup group = config.group("Mouse");

KConfig("foo")
will load foo and parse it every time.

> libinput_settings.h:27
> +template
> +T load(QString key, T defVal);
>  

this use of templates doesn't match the implementation

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11469

To: romangg, #plasma
Cc: davidedmundson, hein, mart, abetts, ngraham, plasma-devel, ragreen, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D11469: [Mouse KCM] Add X11 libinput exclusive backend and UI

[Roman Gilg]

romangg added a comment.


  In D11469#234225 , @ngraham wrote:
  
  > @romangg so is this more of a request just for code review review, then?
  
  
  Yes. You can also just compile and test it to see if there are no 
regressions. And in case not accept it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11469

To: romangg, #plasma
Cc: hein, mart, abetts, ngraham, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol

D11559: Fix default colour used by Swap monitor

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:dad98acf635d: Fix default colour used by Swap monitor 
(authored by davidedmundson).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11559?vs=30149=30621#toc

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11559?vs=30149=30621

REVISION DETAIL
  https://phabricator.kde.org/D11559

AFFECTED FILES
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml

To: davidedmundson, #plasma, dhaumann
Cc: dhaumann, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11712: kcm_energyinfo: Allow changing of the timespan if no data available

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:fadf1008e452: kcm_energyinfo: Allow changing of the 
timespan if no data available (authored by fvogt).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11712?vs=30615=30616

REVISION DETAIL
  https://phabricator.kde.org/D11712

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: fvogt, #plasma, broulik
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11712: kcm_energyinfo: Allow changing of the timespan if no data available

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Plasma.
Restricted Application added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  Without this, it's only possible to change the timespan if data is available.
  Which means that if there is not data available for i.e. the last 24 hours,
  you can't switch back to a longer span.

TEST PLAN
  I can change to a timespan with data.

REPOSITORY
  R102 KInfoCenter

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D11712

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: fvogt, #plasma
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11711: Update launchfeedback docbook to 5.12

[Burkhard Lück]

lueck created this revision.
lueck added reviewers: Plasma, Documentation.
Restricted Application added a project: Plasma.
Restricted Application added subscribers: kde-doc-english, plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  proofread + update
  bump date + releaseinfo
  adapt to changed gui strings
  replace kde with plasma

TEST PLAN
  checkXML5 index.docbook

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11711

AFFECTED FILES
  doc/kcontrol/kcmlaunchfeedback/index.docbook

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D6096: Add Wayland RemoteAccess capabilities to KRfb

[Oleg Chernovskiy]

Kanedias added a comment.


  Sure, I'll be updating diff this week, will address concerns raised here

REPOSITORY
  R437 Desktop Sharing

REVISION DETAIL
  https://phabricator.kde.org/D6096

To: Kanedias, davidedmundson, graesslin
Cc: alexeymin, plasma-devel, ragreen, schernikov, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D6096: Add Wayland RemoteAccess capabilities to KRfb

[Alexey Min]

alexeymin added a comment.


  While I'm here and still remember some things that I don't like here - naming:
  
  There is a class `EventsPlugin` and files `eventsplugin.{h,cpp}`, class 
`EventsManager` and files `eventsmanager.{h,cpp}` and this is fine.
  But there is also class `EventHandler`, but files are called 
`events.{h,cpp}`, it makes it a little bit harder to quickly read the code; 
maybe it makes sense to rename file also to `eventhandler.h` ?
  Also class `FakeInputEventHandler` in file `fakeinputevents.h`; it may be 
also better to name the file `fakeinputeventhandler.h`...
  
  And the most important suggestion I have: can this work be split in 2 parts:
  
  - first part, split event handling into a separate type of plugin, and add a 
new event handler plugins, so we can test it on X11 first (even without 
wayland) and be sure it still works? (Hopefully this part can be done fast 
enough)
  - second part, add a new shiny GBM framebuffer plugin, and new dependencies 
on libdrm, libgbm, epoxy...
  
  Will be a bit easier to review and test, step by step.
  What do you think?

REPOSITORY
  R437 Desktop Sharing

REVISION DETAIL
  https://phabricator.kde.org/D6096

To: Kanedias, davidedmundson, graesslin
Cc: alexeymin, plasma-devel, ragreen, schernikov, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D11707: [Card] Use own "findIndex" implementation

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:e7fd9e62674b: [Card] Use own findIndex 
implementation (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11707?vs=30598=30606#toc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11707?vs=30598=30606

REVISION DETAIL
  https://phabricator.kde.org/D11707

AFFECTED FILES
  src/controls/Card.qml

To: broulik, #plasma, mart, hein
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11708: [Folder View] Fix selecting text with Shift+Home/End

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5d719c1bb374: [Folder View] Fix selecting text with 
Shift+Home/End (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11708?vs=30604=30605

REVISION DETAIL
  https://phabricator.kde.org/D11708

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11708: [Folder View] Fix selecting text with Shift+Home/End

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hein.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  BUG: 392318
  FIXED-IN: 5.12.4

TEST PLAN
  Home and End still move the cursor to the beginning and end, respectively, 
also when text wrapped into multiple lines. Ctrl+Home/End also still works
  Shift+Home/End now moves selects from the cursor to the beginning or end as 
one would expect

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D11708

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein updated this revision to Diff 30603.
hein edited the summary of this revision.
hein removed subscribers: broulik, ngraham.
hein added a comment.


  Minor fixes to commit message & mention more compact layout; sync summary.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11663?vs=30602=30603

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11663

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/InlineMessagesGallery.qml
  kirigami.qrc
  src/controls/InlineMessage.qml
  src/controls/plugins.qmltypes
  src/controls/templates/InlineMessage.qml
  src/enums.h
  src/kirigamiplugin.cpp
  src/qmldir

To: hein, #kirigami, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein, broulik, ngraham

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein updated this revision to Diff 30602.
hein added a comment.


  Drop noisy debug from Kai's findIndex.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11663?vs=30601=30602

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11663

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/InlineMessagesGallery.qml
  kirigami.qrc
  src/controls/InlineMessage.qml
  src/controls/plugins.qmltypes
  src/controls/templates/InlineMessage.qml
  src/enums.h
  src/kirigamiplugin.cpp
  src/qmldir

To: hein, #kirigami, mart
Cc: broulik, ngraham, plasma-devel, apol, davidedmundson, mart, hein

D11707: [Card] Use own "findIndex" implementation

[Eike Hein]

hein added inline comments.

INLINE COMMENTS

> Card.qml:107
> +function findIndex(array, cb) {
> +console.log("FIND IDX", array);
> +for (var i = 0, length = array.length; i < length; ++i) {

Debug

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11707

To: broulik, #plasma, mart, hein
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein marked an inline comment as done.
hein added inline comments.

INLINE COMMENTS

> broulik wrote in InlineMessage.qml:364
> `findIndex` is new in Qt 5.9
> 
> [1] https://doc.qt.io/qt-5/qtqml-javascript-functionlist.html

Switched to homebrew implementation from your D11707 
.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: broulik, ngraham, plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein updated this revision to Diff 30601.
hein added a comment.


  Use homebrew findIndex from D11707  to 
lower deps below Qt 5.9.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11663?vs=30599=30601

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11663

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/InlineMessagesGallery.qml
  kirigami.qrc
  src/controls/InlineMessage.qml
  src/controls/plugins.qmltypes
  src/controls/templates/InlineMessage.qml
  src/enums.h
  src/kirigamiplugin.cpp
  src/qmldir

To: hein, #kirigami, mart
Cc: broulik, ngraham, plasma-devel, apol, davidedmundson, mart, hein

D11661: Fix docbook installation for doc/kcontrol/kcmlaunchfeedback

[Burkhard Lück]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:d6e3d6ffbf2f: Fix docbook installation for 
doc/kcontrol/kcmlaunchfeedback (authored by lueck).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11661?vs=30498=30600

REVISION DETAIL
  https://phabricator.kde.org/D11661

AFFECTED FILES
  doc/kcontrol/CMakeLists.txt
  doc/kcontrol/kcmlaunch/CMakeLists.txt
  doc/kcontrol/kcmlaunch/index.docbook
  doc/kcontrol/kcmlaunchfeedback/CMakeLists.txt
  doc/kcontrol/kcmlaunchfeedback/index.docbook

To: lueck, #plasma, #localization, #documentation, davidedmundson, hein
Cc: kde-doc-english, aacid, hein, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein marked an inline comment as done.
hein added inline comments.

INLINE COMMENTS

> broulik wrote in InlineMessagesGallery.qml:115
> There's no `start-here` in Breeze, just `start-here-kde` which won't fall 
> back to `start-here` (which is distro-branded for you apparently)

Replaced with system-run.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: broulik, ngraham, plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein updated this revision to Diff 30599.
hein added a comment.


  Use more generic icon as custom icon example.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11663?vs=30596=30599

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11663

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/InlineMessagesGallery.qml
  kirigami.qrc
  src/controls/InlineMessage.qml
  src/controls/plugins.qmltypes
  src/controls/templates/InlineMessage.qml
  src/enums.h
  src/kirigamiplugin.cpp
  src/qmldir

To: hein, #kirigami, mart
Cc: broulik, ngraham, plasma-devel, apol, davidedmundson, mart, hein

D11707: [Card] Use own "findIndex" implementation

[Kai Uwe Broulik]

broulik updated this revision to Diff 30598.
broulik added a comment.


  Remove unrelated change

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11707?vs=30597=30598

REVISION DETAIL
  https://phabricator.kde.org/D11707

AFFECTED FILES
  src/controls/Card.qml

To: broulik, #plasma, mart, hein
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11707: [Card] Use own "findIndex" implementation

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, mart, hein.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `Array.findIndex` has only been added in Qt 5.9 [1]
  
  [1] https://doc.qt.io/qt-5/qtqml-javascript-functionlist.html

TEST PLAN
  Overflow of Cards in gallery app still works, shows only the items that are 
actually overflowing

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11707

AFFECTED FILES
  src/controls/Card.qml

To: broulik, #plasma, mart, hein
Cc: plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein updated this revision to Diff 30596.
hein marked 5 inline comments as done.
hein added a comment.


  - Correct gallery page heading (note to Marco: also wrong in one of the Cards 
gallery pages).
  - Use hasOwnProperty.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11663?vs=30594=30596

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11663

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/InlineMessagesGallery.qml
  kirigami.qrc
  src/controls/InlineMessage.qml
  src/controls/plugins.qmltypes
  src/controls/templates/InlineMessage.qml
  src/enums.h
  src/kirigamiplugin.cpp
  src/qmldir

To: hein, #kirigami, mart
Cc: broulik, ngraham, plasma-devel, apol, davidedmundson, mart, hein

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 122 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/122/
 Project:
Plasma kwin kf5-qt5 FreeBSDQt5.9
 Date of build:
Mon, 26 Mar 2018 07:07:57 +
 Build duration:
33 min and counting
   JUnit Tests
  Name: (root) Failed: 12 test(s), Passed: 111 test(s), Skipped: 0 test(s), Total: 123 test(s)Failed: TestSuite.kwin-testClientMachineFailed: TestSuite.kwin-testDebugConsoleFailed: TestSuite.kwin-testDecorationInputFailed: TestSuite.kwin-testDecorationInput-waylandonlyFailed: TestSuite.kwin-testDontCrashCursorPhysicalSizeEmptyFailed: TestSuite.kwin-testDontCrashCursorPhysicalSizeEmpty-waylandonlyFailed: TestSuite.kwin-testInternalWindowFailed: TestSuite.kwin-testInternalWindow-waylandonlyFailed: TestSuite.kwin-testLockScreenFailed: TestSuite.kwin-testShadeWobblyWindowsFailed: TestSuite.kwin-testShellClientFailed: TestSuite.kwin-testShellClient-waylandonly

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein marked 5 inline comments as done.
hein added inline comments.

INLINE COMMENTS

> broulik wrote in InlineMessagesGallery.qml:45
> Wrong class name

Thanks, will fix.

> broulik wrote in InlineMessagesGallery.qml:115
> There's no `start-here` in Breeze, just `start-here-kde` which won't fall 
> back to `start-here` (which is distro-branded for you apparently)

I need something generic that's not tied to Breeze, hmm ... suggestions?

> broulik wrote in InlineMessage.qml:364
> `findIndex` is new in Qt 5.9
> 
> [1] https://doc.qt.io/qt-5/qtqml-javascript-functionlist.html

This was copy-pasted from the Cards code (that's why Marco's copyright is in 
the header). Marco?

> broulik wrote in InlineMessage.qml:387
> Note that `visible` propagates recursively so when the component containing a 
> default-visible message widget isn't shown this will still animate. But then 
> I don't know if that's a thing and how to fix that..

I'm not sure it's a problem it will animate when you unhide with a parent.

> broulik wrote in InlineMessage.qml:100
> Should this be a `var` property so you could also pass a `QIcon` or "QtQuick 
> Controls Icon"?

I wouldn't have any objections, but Kirigami.Icon.source is 'string' too, so it 
wouldn't work currently.

> broulik wrote in InlineMessage.qml:113
> `KMessageWidget` names it `closeButtonVisible`

Yes, but as mentioned in the review description I named it showCloseButton for 
consistency with another Kirigami component.

> broulik wrote in InlineMessage.qml:127
> `contentItem.hasOwnProperty("animating")`

Will do.

> broulik wrote in enums.h:39
> With Qt 5.8 this could become
> 
>   namespace InlineMessageType
>   {
>   Q_NAMESPACE
>   enum Type {
>   ...
> 
> with `qmlRegisterUncreatableMetaObject`
> (purely informational comment)

Could be a nice follow-up, but it's good practice to emulate surrounding style 
in a patch.

> broulik wrote in enums.h:42
> `Q_ENUM`
> 
> (also informational, the code around it does the same, could be cleaned up 
> eventually)

See above.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: broulik, ngraham, plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> InlineMessagesGallery.qml:45
> +Layout.fillWidth: true
> +text: "CardsLayout"
> +}

Wrong class name

> InlineMessagesGallery.qml:115
> +
> +icon: "start-here"
> +

There's no `start-here` in Breeze, just `start-here-kde` which won't fall back 
to `start-here` (which is distro-branded for you apparently)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: broulik, ngraham, plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Kai Uwe Broulik]

broulik added a comment.


  Sweet

INLINE COMMENTS

> InlineMessage.qml:364
> +
> +visible: 
> actionsLayout.overflowSet.findIndex(function(act) {
> +return act == modelData}) > -1 && 
> modelData.visible

`findIndex` is new in Qt 5.9

[1] https://doc.qt.io/qt-5/qtqml-javascript-functionlist.html

> InlineMessage.qml:387
> +Component.onCompleted: {
> +contentItem.opacity = visible ? 1.0 : 0.0;
> +complete = true;

Note that `visible` propagates recursively so when the component containing a 
default-visible message widget isn't shown this will still animate. But then I 
don't know if that's a thing and how to fix that..

> InlineMessage.qml:100
> + */
> +property string icon
> +

Should this be a `var` property so you could also pass a `QIcon` or "QtQuick 
Controls Icon"?

> InlineMessage.qml:113
> + */
> +property bool showCloseButton: false
> +

`KMessageWidget` names it `closeButtonVisible`

> InlineMessage.qml:127
> + */
> +readonly property bool animating: "animating" in contentItem && 
> contentItem.animating
> +}

`contentItem.hasOwnProperty("animating")`

> enums.h:39
>  
> +class InlineMessageType : public QObject
> +{

With Qt 5.8 this could become

  namespace InlineMessageType
  {
  Q_NAMESPACE
  enum Type {
  ...

with `qmlRegisterUncreatableMetaObject`
(purely informational comment)

> enums.h:42
> +Q_OBJECT
> +Q_ENUMS(Type)
> +

`Q_ENUM`

(also informational, the code around it does the same, could be cleaned up 
eventually)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: broulik, ngraham, plasma-devel, apol, davidedmundson, mart, hein

D1230: GBM remote access support for KWin

[Bhushan Shah]

bshah added a comment.


  In D1230#234333 , @Kanedias wrote:
  
  > I'll take a look once I'm home
  
  
  I've fixed the issue on git master so don't worry.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: bshah, bcooksley, kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, 
kwin, #kwin, davidedmundson, plasma-devel, ragreen, schernikov, iodelay, zzag, 
bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, 
eliasp, sebas, apol, mart, hein

D1230: GBM remote access support for KWin

[Oleg Chernovskiy]

Kanedias added a comment.


  I'll take a look once I'm home

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: bcooksley, kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, 
#kwin, davidedmundson, plasma-devel, ragreen, schernikov, iodelay, zzag, bwowk, 
ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, 
sebas, apol, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein added a comment.


  After everyone I talked to universally preferring this option, the code in 
the latest diff now produces this:
  
  F5767042: inlinemessages6.png 
  
  I'm out of todos on this, so please review now!

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D11663

To: hein, #kirigami, mart
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D11663: Add InlineMessage type and Gallery app example page

[Eike Hein]

hein updated this revision to Diff 30594.
hein added a comment.


  - Switch to the rounded border + pale fill style most people seem to prefer. 
This is a proper implementation with better inside corners and the border width 
matching the seperator width. The radius is the same as for passive 
notifications.
  - Fix a Component.onCompleted being in the wrong scope.

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11663?vs=30458=30594

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11663

AFFECTED FILES
  examples/galleryapp/CMakeLists.txt
  examples/galleryapp/resources.qrc
  examples/gallerydata/contents/ui/MainPage.qml
  examples/gallerydata/contents/ui/gallery/InlineMessagesGallery.qml
  kirigami.qrc
  src/controls/InlineMessage.qml
  src/controls/plugins.qmltypes
  src/controls/templates/InlineMessage.qml
  src/enums.h
  src/kirigamiplugin.cpp
  src/qmldir

To: hein, #kirigami, mart
Cc: ngraham, plasma-devel, apol, davidedmundson, mart, hein

D1230: GBM remote access support for KWin

[Ben Cooksley]

bcooksley added a comment.


  Sorry, that was the wrong log - I intended to post 
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/121/consoleText

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: bcooksley, kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, 
#kwin, davidedmundson, plasma-devel, ragreen, schernikov, iodelay, zzag, bwowk, 
ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, 
sebas, apol, mart, hein

D1230: GBM remote access support for KWin

[Oleg Chernovskiy]

Kanedias added a comment.


  @bcooksley this file was merged in D1231 

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: bcooksley, kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, 
#kwin, davidedmundson, plasma-devel, ragreen, schernikov, iodelay, zzag, bwowk, 
ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, 
sebas, apol, mart, hein

D1230: GBM remote access support for KWin

[Ben Cooksley]

bcooksley added a comment.


  The introduction of this has broken the FreeBSD Build.
  Please see 
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/120/consoleText

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D1230

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: bcooksley, kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, 
#kwin, davidedmundson, plasma-devel, ragreen, schernikov, iodelay, zzag, bwowk, 
ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, 
sebas, apol, mart, hein

D11661: Fix docbook installation for doc/kcontrol/kcmlaunchfeedback

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  Thanks! :)

REVISION DETAIL
  https://phabricator.kde.org/D11661

To: lueck, #plasma, #localization, #documentation, davidedmundson, hein
Cc: kde-doc-english, aacid, hein, plasma-devel, ragreen, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart