D12496: Add .arcconfig

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R121:bd0833f6cb52: Add .arcconfig (authored by sharvey, 
committed by ngraham).

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12496?vs=32986=33032

REVISION DETAIL
  https://phabricator.kde.org/D12496

AFFECTED FILES
  .arcconfig

To: sharvey, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

[Chris Holland]

Zren added a comment.


  I use `gcc --version 5.4.0`, so I've no idea. I assume that is a QPointer 
feature though? We can always check the other DownloadDialog initializations:
  
  - Image Wallpapers added `m_newStuffDialog->setWindowModality(...)` 9 months 
ago:
- 
https://github.com/KDE/plasma-workspace/blame/master/wallpapers/image/image.cpp#L600
- 
https://github.com/KDE/plasma-workspace/commit/3558afa9579edffb5f86d36973cf42c560126569
  - Widget Explorer only uses `data()` 
https://github.com/KDE/plasma-workspace/blame/master/components/shellprivate/widgetexplorer/widgetexplorer.cpp#L443
  - Desktop Theme uses `data()` and  
`m_newStuffDialog->setWindowModality(...)`, but it was changed today:
- 
https://github.com/KDE/plasma-desktop/blame/master/kcms/desktoptheme/kcm.cpp#L126
- It was using `dialog->open()` before today, which was last changed 2 
years ago: 
https://github.com/KDE/plasma-desktop/blame/9a333b48ca1af8fc9ea07ee4b154fe09d5485e1b/kcms/desktoptheme/kcm.cpp#L97
  - Look and Feel only uses `data()` 
https://github.com/KDE/plasma-desktop/blame/master/kcms/lookandfeel/kcm.cpp#L109
  - Icon Themes uses `dialog.exec()` ... which is blocking I think. Doesn't 
mention `data()` anywhere though.  
https://github.com/KDE/plasma-desktop/blame/master/kcms/icons/iconthemes.cpp#L319
  - Cursor Theme is similar to Icon Theme with `dialog.exec()` 
https://github.com/KDE/plasma-desktop/blame/master/kcms/cursortheme/kcmcursortheme.cpp#L446
  - Emoticon Themes  is similar to Icon Theme with `dialog.exec()` 
https://github.com/KDE/plasma-desktop/blame/master/kcms/emoticons/emoticonslist.cpp#L426
  - Color Themes is similar to Icon Theme with `dialog.exec()` 
https://github.com/KDE/plasma-desktop/blame/master/kcms/colors/colorscm.cpp#L293

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12040

To: Zren, #plasma
Cc: cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

[Christoph Feck]

cfeck added a comment.


  In D12040#253335 , @Zren wrote:
  
  > Remove `.data()` since it seems to work without it.
  
  
  Even with gcc 4.8 (openSUSE Leap)?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12040

To: Zren, #plasma
Cc: cfeck, mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D10079: [Draft] Port baloo krunner plugin to KDBusRunner

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 33027.
kossebau retitled this revision from " [Draft] Port baloo krunner plugin to 
KDBusRunner" to "[Draft] Port baloo krunner plugin to KDBusRunner".
kossebau added a comment.


  update to latest kdbusrunner

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10079?vs=25889=33027

BRANCH
  portBalooRunnerToKDBusRunner

REVISION DETAIL
  https://phabricator.kde.org/D10079

AFFECTED FILES
  CMakeLists.txt
  runners/baloo/CMakeLists.txt
  runners/baloo/baloosearchrunner.cpp
  runners/baloo/baloosearchrunner.h
  runners/baloo/dbusutils_p.h
  runners/baloo/org.kde.krunner1.xml

To: kossebau, davidedmundson, broulik, mart
Cc: michaelh, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

[Chris Holland]

Zren updated this revision to Diff 33024.
Zren changed the repository for this revision from R131 Plasma Wallpapers to 
R120 Plasma Workspace.
Zren added a comment.


  Remove `.data()` since it seems to work without it.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12040?vs=32247=33024

REVISION DETAIL
  https://phabricator.kde.org/D12040

AFFECTED FILES
  components/shellprivate/CMakeLists.txt
  components/shellprivate/shellprivateplugin.cpp
  components/shellprivate/wallpaperplugin/wallpaperplugin.cpp
  components/shellprivate/wallpaperplugin/wallpaperplugin.h
  components/shellprivate/wallpaperplugin/wallpaperplugin.knsrc

To: Zren, #plasma
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D7181: [Task Manager] Elide context menu entries

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Revision".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2bf23482a1bf: [Task Manager] Elide context menu entries 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D7181?vs=17822=33019#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7181?vs=17822=33019

REVISION DETAIL
  https://phabricator.kde.org/D7181

AFFECTED FILES
  applets/taskmanager/package/contents/ui/ContextMenu.qml
  applets/taskmanager/package/contents/ui/code/layout.js

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9608: [KScreen Effect] Fade opacity only for transparent windows

[David Edmundson]

davidedmundson updated this revision to Diff 33018.
davidedmundson added a comment.


  A better version

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9608?vs=24579=33018

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D9608

AFFECTED FILES
  effects/kscreen/kscreen.cpp

To: davidedmundson, #plasma, graesslin, broulik
Cc: luebking, plasma-devel, kwin, #kwin, ragreen, jackyalcine, Pitel, iodelay, 
zzag, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, 
abetts, sebas, apol, mart

D9951: [KUserProxy] Adjust to accounts service

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R296:6655238c0282: [KUserProxy] Adjust to accounts service 
(authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D9951?vs=25552=33017#toc

REPOSITORY
  R296 KDeclarative

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9951?vs=25552=33017

REVISION DETAIL
  https://phabricator.kde.org/D9951

AFFECTED FILES
  src/qmlcontrols/kcoreaddons/kuserproxy.cpp

To: broulik, #plasma, davidedmundson
Cc: ngraham, davidedmundson, apol, plasma-devel, #frameworks, ragreen, Pitel, 
michaelh, ZrenBot, bruns, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, mart

D12503: [Desktop Theme KCM] Adjust to changes in other KCMs

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:03f29a85739c: [Desktop Theme KCM] Adjust to changes in 
other KCMs (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12503?vs=33011=33015

REVISION DETAIL
  https://phabricator.kde.org/D12503

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/main.qml

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Kai Uwe Broulik]

broulik added a comment.


  Well, the original design also only showed it on error

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Nathaniel Graham]

ngraham added a comment.


  I know, that's what I'm saying. For Caps Lock, we actually show the status. 
For this, it seems weird not to do the same. In other words, I like your 
original wording (or something like it) better. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Kai Uwe Broulik]

broulik added a comment.


  We do have a capslock indication that shows up as soon as capslock is enabled.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Nathaniel Graham]

ngraham added a comment.


  I dunno about "Check your keyboard layout". Would we say "Check your caps 
lock key?" Instead, we actually show you whether your caps lock key is pressed 
or not.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Kai Uwe Broulik]

broulik updated this revision to Diff 33013.
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added a comment.


  - Simplify

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D3790?vs=9288=33013

REVISION DETAIL
  https://phabricator.kde.org/D3790

AFFECTED FILES
  lookandfeel/contents/components/KeyboardLayoutButton.qml
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D12503: [Desktop Theme KCM] Adjust to changes in other KCMs

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  - Implement undo delete feature
  - Introduce `currentIndex` property instead of `indexOf()` method
  - Make GHNS dialog window modal instead of application modal
  - Support drag and drop to install themes
  - Use `InlineMessage` for installation error/success notifications

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12503

AFFECTED FILES
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/main.qml

To: broulik, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12476: kcm_opengl: Fix retrieval of DRI information

[Alexey Min]

alexeymin added a comment.


  I've tested this and it seems to work!
  
  F5821132: kinfocenter DRI info wayland.png 

  
  But in wayland I had to add some changes: set `IsDirect = true;` before 
calling `print_screen_info()` in `get_gl_info_egl_qt()` line ~ 929.
  Otherwise, `get_dri_device()` is never called in this block in 
`print_screen_info()`:
  
if (IsDirect) {
if (get_dri_device())  {
l2 = newItem(l1, i18n("3D Accelerator"));
l2->setExpanded(true);
l3 = newItem(l2, l3, i18n("Vendor"), dri_info.vendor);
l3 = newItem(l2, l3, i18n("Device"), dri_info.device);
l3 = newItem(l2, l3, i18n("Subvendor"), dri_info.subvendor);
l3 = newItem(l2, l3, i18n("Revision"), dri_info.rev);
} else {
l2 = newItem(l1, l2, i18n("3D Accelerator"), i18n("unknown"));
}
}
  
  For X11, `IsDirect` is initialized in `get_gl_info_glx()` line 767 by:
  
IsDirect = glXIsDirect(dpy, ctx);
  
  Fow wayland path, it stays false forever, I guess. Though direct rendering 
**IS** used.
  
  Without this hack I only get this:
  F5821138: kinfocenter DRI info wayland bad.png 

  
  `3D Accelerator` section is gone, and `Driver` section lacks kernel module 
information. :(

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D12476

To: roberts, #plasma
Cc: alexeymin, wbauer, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9037: use desktop file actions instead of global shortcuts

[David Edmundson]

davidedmundson added a comment.


  I have a plan for a kconf_update v2 which would resolve the problem above 
nicely
  Probably means this would be 5.14.
  
  Otherwise you can copy my 4ae36aee91a23dcb0736418295269da14152 
 in 
powerdevil

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9037

To: mart, #plasma, davidedmundson
Cc: broulik, apol, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D10338: Don't show tooltips for inactive windows

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Since tooltip behavior has been improved and the buttons are actually 
clickable when the window does not have focus, probably should still show them

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D10338

To: broulik, #plasma, graesslin, McPain
Cc: aleksejshilin, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D4353: [Applet Configuration] Add mnemonics for dialog buttons

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  Just tried, porting it to QQC2 will give it auto mnemonics \o/ will look into 
that

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4353

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12498: Fully remove `Application Name` from Details panel

[Scott Harvey]

sharvey updated this revision to Diff 33002.
sharvey marked an inline comment as done.
sharvey added a comment.


  - Changed `Not Available` to `Missing`

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12498?vs=33000=33002

BRANCH
  remove-appname (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12498

AFFECTED FILES
  AuthDialog.cpp
  AuthDialog.h
  authdetails.ui

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11955: [Folder View] Set Refresh shortcut on Refresh/Reload

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:9a333b48ca1a: [Folder View] Set Refresh shortcut on 
Refresh/Reload (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11955?vs=32995=33001

REVISION DETAIL
  https://phabricator.kde.org/D11955

AFFECTED FILES
  containments/desktop/plugins/folder/autotests/foldermodeltest.cpp
  containments/desktop/plugins/folder/foldermodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12498: Fully remove `Application Name` from Details panel

[Scott Harvey]

sharvey updated this revision to Diff 33000.
sharvey added a comment.


  - Correct for use of `isEmpty()`; changed `Action ID` to simply `ID`

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12498?vs=32993=33000

BRANCH
  remove-appname (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12498

AFFECTED FILES
  AuthDialog.cpp
  AuthDialog.h
  authdetails.ui

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12476: kcm_opengl: Fix retrieval of DRI information

[Lindsay Roberts]

roberts marked an inline comment as done.
roberts added inline comments.

INLINE COMMENTS

> wbauer wrote in opengl.cpp:211
> Using just "/driver" (instead of "/driver/module") makes it display "radeon" 
> instead of "drm" here as I would expect.
> 
> OTOH, as it already runs lspci to get the other information, wouldn't it be 
> better to get the kernel module from lspci as well?
> Additionally specifying the '-k' parameter to lspci adds these two lines to 
> lspci's output here:
> Driver: radeon
> Module: radeon
> (the first one is the driver in use, the second one lists all available 
> modules for that device, see also "man lspci")
> That should be independent of the kernel version and also work the same in 
> the get_dri_device_proc() case.
> 
> Just a thought though.

Have changed to use `/driver` instead of `/driver/module`.

Am preferring to err on the side of not adding more numbered line reads from 
lspci output.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D12476

To: roberts, #plasma
Cc: wbauer, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12498: Fully remove `Application Name` from Details panel

[Stefan Brüns]

bruns added inline comments.

INLINE COMMENTS

> AuthDialog.cpp:345
>  // neither isEmpty() or isNull() worked (?)
>  if (actionDescription.description() == "") {
>  QFont descrFont(action_label->font());

` == ""` should be identical to .isEmpty(), please recheck

> AuthDialog.cpp:349
>  action_label->setFont(descrFont);
> -action_label->setText(i18n("Not Applicable"));
> +action_label->setText(i18n("Not Available"));
>  } else {

According to 
https://www.freedesktop.org/software/polkit/docs/latest/polkit.8.html#polkit-rules
`description` is not optional, so the correct statement is "Missing"

> authdetails.ui:26
>   
> -  Action:
> +  Action ID:
>   

I think "ID" is sufficient

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12498

To: sharvey, bruns, ngraham, davidedmundson
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12476: kcm_opengl: Fix retrieval of DRI information

[Lindsay Roberts]

roberts updated this revision to Diff 32999.
roberts added a comment.


  Update to use /driver over /driver/module per review.

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12476?vs=32904=32999

BRANCH
  kcm_opengl_fix_dri_info

REVISION DETAIL
  https://phabricator.kde.org/D12476

AFFECTED FILES
  Modules/opengl/opengl.cpp

To: roberts, #plasma
Cc: wbauer, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12499: kcm_opengl: Update to use /driver over /driver/module per review.

[Lindsay Roberts]

roberts created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
roberts requested review of this revision.

REPOSITORY
  R102 KInfoCenter

BRANCH
  kcm_opengl_fix_dri_info

REVISION DETAIL
  https://phabricator.kde.org/D12499

AFFECTED FILES
  Modules/opengl/opengl.cpp

To: roberts
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D4281: [Task Manager] Limit context menu width

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  Cut-off text is ugly

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4281

To: broulik, #plasma, davidedmundson, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Nathaniel Graham]

ngraham added a comment.


  In D3790#253155 , @abetts wrote:
  
  > Also, will this message show even though there is only one keyboard layout 
enabled?
  
  
  No
  
  > Or will it only show when there are multiple layouts?
  
  Yes

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Andres Betts]

abetts added a comment.


  Can it say something like "Unlocking failed. Check your keyboard layout" ? I 
feel it is more generic. Also, will this message show even though there is only 
one keyboard layout enabled? Or will it only show when there are multiple 
layouts?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: abetts, ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Seems sane to me since it's only shown for the minority of users with 
multiple keyboard layouts, for whom this may be a legitimate problem.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma, #vdg, ngraham
Cc: ngraham, colomar, gregormi, mart, graesslin, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D11955: [Folder View] Set Refresh shortcut on Refresh/Reload

[Kai Uwe Broulik]

broulik updated this revision to Diff 32995.
broulik edited the summary of this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  - Drop "reload" action

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11955?vs=31383=32995

REVISION DETAIL
  https://phabricator.kde.org/D11955

AFFECTED FILES
  containments/desktop/plugins/folder/autotests/foldermodeltest.cpp
  containments/desktop/plugins/folder/foldermodel.cpp

To: broulik, #plasma, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11961: Add QtQuickSettings

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Changes 
Planned".
This revision was automatically updated to reflect the committed changes.
Closed by commit R124:eb65088efe79: Add QtQuickSettings (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11961?vs=31401=32994#toc

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11961?vs=31401=32994

REVISION DETAIL
  https://phabricator.kde.org/D11961

AFFECTED FILES
  app/CMakeLists.txt
  app/main.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12497: Fully remove "Application Name" from details panel

[Scott Harvey]

sharvey added a comment.


  In D12497#253114 , @ngraham wrote:
  
  > No need to abandon this revision; you could pull down master, re-branch, do 
your changes there, and then issue `arc diff --update D12497`, and it will 
replace the diff here with what you have locally.
  
  
  Added to my "Phab/arc" notes for the future.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12497

To: sharvey, bruns, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12498: Fully remove `Application Name` from Details panel

[Scott Harvey]

sharvey created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
sharvey requested review of this revision.

REVISION SUMMARY
  `Application Name` removed from PolicyKit details panel (backend code removed 
long ago)

TEST PLAN
  @bruns @ngraham @davidedmundson

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  remove-appname (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12498

AFFECTED FILES
  AuthDialog.cpp
  AuthDialog.h
  authdetails.ui

To: sharvey
Cc: davidedmundson, bruns, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7724: [ListItemBase] Open options menu on right click

[Nathaniel Graham]

ngraham added a comment.


  I'd also prefer for the menu to open under the mouse, if it's not 
ridiculously difficult to implement.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D7724

To: broulik, #plasma, #vdg, drosca
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12497: Fully remove "Application Name" from details panel

[Nathaniel Graham]

ngraham added a comment.


  No need to abandon this revision; you could pull down master, re-branch, do 
your changes there, and then issue `arc diff --update D12497`, and it will 
replace the diff here with what you have locally.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12497

To: sharvey, bruns, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12497: Fully remove "Application Name" from details panel

[Scott Harvey]

sharvey added a comment.


  In D12497#253108 , @ngraham wrote:
  
  > For a removal patch, I see a suspicious amount of green here...
  
  
  Forgot to pull a fresh master after you committed my previous change. 
Abandoning and reworking. Argh.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12497

To: sharvey, bruns, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12497: Fully remove "Application Name" from details panel

[Nathaniel Graham]

ngraham added a comment.


  For a removal patch, I see a suspicious amount of green here...

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12497

To: sharvey, bruns, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12497: Fully remove "Application Name" from details panel

[Scott Harvey]

sharvey updated this revision to Diff 32991.
sharvey added a comment.


  - Corrected `Not Applicable` to `Not Available`

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12497?vs=32990=32991

BRANCH
  remove-appname (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12497

AFFECTED FILES
  AuthDialog.cpp
  AuthDialog.h
  authdetails.ui

To: sharvey, bruns, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12497: Fully remove "Application Name" from details panel

[Scott Harvey]

sharvey created this revision.
sharvey added reviewers: bruns, ngraham, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
sharvey requested review of this revision.

REVISION SUMMARY
  Remove `Application Name` from details panel; backend code removed long ago

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  remove-appname (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12497

AFFECTED FILES
  AuthDialog.cpp
  AuthDialog.h
  authdetails.ui

To: sharvey, bruns, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12496: Add .arcconfig

[Scott Harvey]

sharvey created this revision.
sharvey added reviewers: ngraham, davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
sharvey requested review of this revision.

REVISION SUMMARY
  Add standard `.arcconfig` file

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  add-arcconfig (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12496

AFFECTED FILES
  .arcconfig

To: sharvey, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D4281: [Task Manager] Limit context menu width

[Eike Hein]

hein added a comment.


  Does it still have the issues mentioned above? Because then not really ...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4281

To: broulik, #plasma, davidedmundson, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D4900: RFC: [Folder View] Use fallback icon if failed to load

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  I think this is the wrong layer to do this

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4900

To: broulik, #plasma, hein
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D10571: [AppletAppearance] Remove d QtObject

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5f59b7338949: [AppletAppearance] Remove d QtObject 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10571?vs=27325=32984

REVISION DETAIL
  https://phabricator.kde.org/D10571

AFFECTED FILES
  containments/desktop/package/contents/ui/AppletAppearance.qml

To: broulik, #plasma, davidedmundson, mart
Cc: apol, mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

[Nathaniel Graham]

ngraham added a comment.


  Just open a new revision, it's easier.

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12479

To: sharvey, davidedmundson, ngraham, #plasma
Cc: bruns, abetts, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D7724: [ListItemBase] Open options menu on right click

[David Rosca]

drosca added a comment.


  In D7724#253041 , @broulik wrote:
  
  > Should we go for it or abandon this?
  
  
  If it gets +1 from VDG.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D7724

To: broulik, #plasma, #vdg, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D9037: use desktop file actions instead of global shortcuts

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> krunnerglobalshortcuts.cpp:34
>  
> -migrateEnabledPlugins();
> +KSharedConfig::Ptr config = 
> KSharedConfig::openConfig("kglobalshortcutsrc");
> +KConfigGroup runnergroup(config, "krunner");

1. you don't need an exe to do that, this whole thing could have been

File=kglobalshortcutsrc
RemoveGroup=krunner

in the .upd. The syntax allows for quite a lot of manipulation.

2. I did something similar for a powerdevil shortcut migration, it has a huge 
problem.

kconf_update runs, the config updates, kglobalacceld is still running so later 
syncs undoing your script.

Sorry :/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D9037

To: mart, #plasma, davidedmundson
Cc: broulik, apol, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D6864: [System Monitor Applet] Add setting for update interval

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:2e129f84ce03: [System Monitor Applet] Add setting for 
update interval (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D6864?vs=17090=32983#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6864?vs=17090=32983

REVISION DETAIL
  https://phabricator.kde.org/D6864

AFFECTED FILES
  applets/systemmonitor/common/contents/config/main.xml
  applets/systemmonitor/common/contents/ui/Applet.qml
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D9037: use desktop file actions instead of global shortcuts

[Marco Martin]

mart updated this revision to Diff 32982.
mart added a comment.


  - Merge branch 'master' into arcpatch-D9037
  - add a config update

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D9037?vs=23123=32982

BRANCH
  arcpatch-D9037

REVISION DETAIL
  https://phabricator.kde.org/D9037

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop
  krunner/main.cpp
  krunner/update/CMakeLists.txt
  krunner/update/krunnerglobalshortcuts.cpp
  krunner/update/krunnerglobalshortcuts.upd
  krunner/update/krunnerplugins.cpp
  krunner/update/main.cpp
  krunner/view.cpp

To: mart, #plasma
Cc: broulik, apol, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

[Scott Harvey]

sharvey added a subscriber: bruns.
sharvey added a comment.


  In D12479#252978 , @ngraham wrote:
  
  > Since you're doing a lot of work in this repo, perhaps your next patch 
should be to ad an `.arccconfig` file! :)
  
  
  Hm, can your commit be undone? I need to push the update @bruns identified in 
R121:b340539eca13 
 - 
or should it just be a new revision?

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

REVISION DETAIL
  https://phabricator.kde.org/D12479

To: sharvey, davidedmundson, ngraham, #plasma
Cc: bruns, abetts, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D7724: [ListItemBase] Open options menu on right click

[Kai Uwe Broulik]

broulik added a comment.


  Should we go for it or abandon this?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D7724

To: broulik, #plasma, #vdg, drosca
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D4979: Add places:/ KIO slave

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  Will revisit shortly (famous last words)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4979

To: broulik, #plasma, hein, dfaure
Cc: ngraham, elvisangelaccio, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D3982: [Panel Containment] Correctly compare applets without order

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  The code I did that broke it was reverted so this doesn't apply anymore. 
Should be revisited at some point perhaps but this particular patch is moot.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D3982

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D3790: RFC: [Lock Screen] Indicate keyboard layout when unlocking failed

[Kai Uwe Broulik]

broulik added a comment.


  So, should I go forward with this now or abandon it?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D3790

To: broulik, #plasma:_design, #plasma
Cc: colomar, gregormi, mart, graesslin, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D6864: [System Monitor Applet] Add setting for update interval

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Please add the "." that cfeck said, then ship it

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6864

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, cfeck, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D3837: [Calendar] Optimize Backend

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.


  marking as request changes based on my comments

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D3837

To: broulik, #plasma, davidedmundson
Cc: #frameworks, davidedmundson, plasma-devel, ragreen, Pitel, michaelh, 
ZrenBot, bruns, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D6795: Honor system font settings

[Kai Uwe Broulik]

broulik abandoned this revision.
broulik added a comment.


  I've been using it for a while and for 99% of websites it makes no difference 
as they have a custom font set and for the other 1% (fefe basically) it makes 
it look weird.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D6795

To: broulik, davidedmundson, fvogt
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12495: [Desktop Theme KCM] Workaround bug in FileDialog

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:c5c756623a34: [Desktop Theme KCM] Workaround bug in 
FileDialog (authored by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D12495?vs=32973=32976#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12495?vs=32973=32976

REVISION DETAIL
  https://phabricator.kde.org/D12495

AFFECTED FILES
  kcms/desktoptheme/package/contents/ui/main.qml

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12495: [Desktop Theme KCM] Workaround bug in FileDialog

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> main.qml:230
>  active: false
>  sourceComponent: FileDialog {
>  title: i18n("Open Theme")

would a

Component.onCompleted: open() in here work?  it would be more self-contained

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12495

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12494: Show lockscreen controls when hitting a modifier

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b9f9581f99ef: Show lockscreen controls when hitting a 
modifier (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12494?vs=32966=32974

REVISION DETAIL
  https://phabricator.kde.org/D12494

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: davidedmundson, #plasma, broulik, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12495: [Desktop Theme KCM] Workaround bug in FileDialog

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When `FileDialog` is created with `visible` set to `true` it will open the 
dialog immediately before its properties are set leading to a dialog with no 
title and filter.

TEST PLAN
  5.12 branch
  
  Opened dialog, verified title said "Open Theme" and file name filter was set
  `QtDialogs` is pretty much unmaintained and to be replaced by some platform 
import(?) so a qt bug report probably won't help

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12495

AFFECTED FILES
  kcms/desktoptheme/package/contents/ui/main.qml

To: broulik, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12040: Add wallpaperplugin.knsrc + QML function to open GHNS dialog

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> Zren wrote in wallpaperplugin.cpp:26
> I copy pasted from `image.cpp` ... which apparently hasn't been touched in 4 
> years since the import from kde-workspace.
> 
> - 
> https://github.com/KDE/plasma-workspace/blame/master/wallpapers/image/image.cpp#L600
> 
> Will that function need updating too?

yeah, possibly, that may ome from early Qt4 days which didn't have ->

REPOSITORY
  R131 Plasma Wallpapers

REVISION DETAIL
  https://phabricator.kde.org/D12040

To: Zren, #plasma
Cc: mart, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

[Christian]

Fuchs added a comment.


  In D12462#252982 , @mart wrote:
  
  > I like the idea a lot,
  >  tough i am not sure i like the implementation: right now is kindof 
hortogonal to pinned tasks and gets confusing as it has a partial, but not 
complete overlap.
  >  I think this should just be the behavior for pinned tasks, in order to map 
perfectly to the workflow of browser pinned tasks (and have only one option, 
pin task, instead of pin task and remove text)
  
  
  Pinned tasks, right now, are bound to activities iff the amount of activities 
is >= 2. So these do different things  (arguably current "pin" is badly named):
  
  1. The current "pin" is based on activities, whilst my "always show only 
icon" is completely unrelated to activities. There are proper usecases for the 
former.
  2. My "always show only ucib" is only available in regular task manager, 
whilst current "pin" is obviously available in icon only task manager, as it is 
a seperate use case  ("launcher")
  
  So they can't be fusioned easily.
  
  I agree that a launcher (currently called pin) looks, when not running, 
almost the same as "always show only icon". The difference is the small bar on 
top (bottom if your panel is top), which correctly makes it look like an open 
window (which it is) and it's state  (active, demands attention., minimized, 
whatnot)
  
  I think both have valid use cases and potentially both are needed, but maybe 
they could both be polished a bit so they are aptly named and look and act 
distinguishable.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12462

To: Fuchs, hein
Cc: mart, fabianr, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D12462: Add support for icon-only tasks (what browsers call pinned tabs)

[Marco Martin]

mart added a comment.


  I like the idea a lot,
  tough i am not sure i like the implementation: right now is kindof hortogonal 
to pinned tasks and gets confusing as it has a partial, but not complete 
overlap.
  I think this should just be the behavior for pinned tasks, in order to map 
perfectly to the workflow of browser pinned tasks (and have only one option, 
pin task, instead of pin task and remove text)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12462

To: Fuchs, hein
Cc: mart, fabianr, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R121:b340539eca13: Polish `Details` panel; added Not 
Applicable to fill otherwise blank spaces (authored by sharvey, committed 
by ngraham).

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12479?vs=32938=32971

REVISION DETAIL
  https://phabricator.kde.org/D12479

AFFECTED FILES
  AuthDialog.cpp
  authdetails.ui

To: sharvey, davidedmundson, ngraham, #plasma
Cc: abetts, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

[Nathaniel Graham]

ngraham added a comment.


  Since you're doing a lot of work in this repo, perhaps your next patch should 
be to ad an `.arccconfig` file! :)

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  polish-detail-panel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12479

To: sharvey, davidedmundson, ngraham, #plasma
Cc: abetts, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D12479: Polish `Details` panel; added "Not Applicable" to fill otherwise blank spaces

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  LTGM!

REPOSITORY
  R121 Policykit (Polkit) KDE Agent

BRANCH
  polish-detail-panel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12479

To: sharvey, davidedmundson, ngraham, #plasma
Cc: abetts, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D12494: Show lockscreen controls when hitting a modifier

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Works for me. Excellent change; I do exactly the same thing!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12494

To: davidedmundson, #plasma, broulik, ngraham
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12494: Show lockscreen controls when hitting a modifier

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  I tend to press left control to wake my screen. This doesn't reveal the 
controls
  which I found mildly annoying.

TEST PLAN
  Locked screen pressed random letter, it removed blur and appeared in textbox
  Locked screen pressed shift, it removed blur and didn't alter textbox. It 
timed out as before
  Pressed escape. Toggles as before

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12494

AFFECTED FILES
  lookandfeel/contents/lockscreen/LockScreenUi.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12476: kcm_opengl: Fix retrieval of DRI information

[Wolfgang Bauer]

wbauer added a comment.


  I gave the patch a try (openSUSE Leap 42.3 with kernel 4.4).
  
  The 3D accelerator info is displayed again now (as with kernel < 3.12), but 
it shows "drm" as kernel module instead of "radeon" as I would expect.

INLINE COMMENTS

> opengl.cpp:211
> +dri_info.pci = get_sysfs_link_name(sysPath);
> +dri_info.module = get_sysfs_link_name(sysPath + 
> QStringLiteral("/driver/module"));
> +

Using just "/driver" (instead of "/driver/module") makes it display "radeon" 
instead of "drm" here as I would expect.

OTOH, as it already runs lspci to get the other information, wouldn't it be 
better to get the kernel module from lspci as well?
Additionally specifying the '-k' parameter to lspci adds these two lines to 
lspci's output here:
Driver: radeon
Module: radeon
(the first one is the driver in use, the second one lists all available modules 
for that device, see also "man lspci")
That should be independent of the kernel version and also work the same in the 
get_dri_device_proc() case.

Just a thought though.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D12476

To: roberts, #plasma
Cc: wbauer, plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12491: [Mouse Cursor KCM] Improve installation workflow

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:edeb3d3b8773: [Mouse Cursor KCM] Improve installation 
workflow (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12491?vs=32962=32964

REVISION DETAIL
  https://phabricator.kde.org/D12491

AFFECTED FILES
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/cursortheme/package/contents/ui/main.qml

To: broulik, mart, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12491: [Mouse Cursor KCM] Improve installation workflow

[Kai Uwe Broulik]

broulik created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12491

AFFECTED FILES
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/cursortheme/package/contents/ui/main.qml

To: broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D6313: Support Icon Scale from Icon naming specification 0.13

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> cfeck wrote in kiconloader.h:279
> loadIcon("test", mygroup, 2);
> 
> Which overload is called?

Looks like it's always taking the one without `scale`. Meh.

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: hein, rkflx, acrouthamel, ngraham, elvisangelaccio, mart, kvermette, cfeck, 
davidedmundson, plasma-devel, #frameworks, ragreen, Pitel, michaelh, ZrenBot, 
bruns, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D8054: Show headset icons for devices identifying as "Headset" in Description

[Guilherme Silva]

guilhermesilva added a comment.


  Hi guys! Sorry to "necro-bump" this issue, but I wanted to share my opinion 
on this new approach of setting the device icon. From what I've been seeing in 
random screenshots of the `plasma-pa` applet, most of the times they all have 
the same icon: `audio-card.svg`. That's because, apparently, for a lot of 
people (myself included), the `device.form_factor` property is set to 
`internal` in all sinks:
  
$ pacmd list sinks | grep device.form_factor
device.form_factor = "internal"
device.form_factor = "internal"
device.form_factor = "internal"
device.form_factor = "internal"
  
  So, the the device list in `plasma-pa` end up looking like this:
  
  F5820254: new.png 
  
  While that's not really a big deal for most people, I really think the 
previous "hacky" approach delivered better-looking results:
  
  F5820257: previous.png 
  
  I don't know if that's an issue with PulseAudio, but for now I decided to 
downgrade the `plasma-pa` package back to version `5.11.5`. I've also made an 
adaptation in `contents/ui/DeviceListItem.qml`, because my speakers port is 
named `analog-output-lineout`, so I wasn't getting the proper icon as well. Ah, 
I've also changed the `audio-speakers-symbolic` icon to just `audio-speakers` 
because I didn't like it:
  
diff --git a/applet/contents/ui/DeviceListItem.qml 
b/applet/contents/ui/DeviceListItem.qml
index 642ca02..2302160 100644
--- a/applet/contents/ui/DeviceListItem.qml
+++ b/applet/contents/ui/DeviceListItem.qml
@@ -27,8 +27,8 @@ ListItemBase {
 label: currentPort ? i18nc("label of device items", "%1 (%2)", 
currentPort.description, Description) : Description
 icon: {
 if (currentPort) {
-if (currentPort.name.indexOf("speaker") != -1) {
-return "audio-speakers-symbolic";
+if (currentPort.name.indexOf("speaker") != -1 || 
currentPort.name.indexOf("lineout") != -1) {
+return "audio-speakers";
 } else if (currentPort.name.indexOf("headphones") != -1) {
 return "audio-headphones";
 } else if (currentPort.name.indexOf("hdmi") != -1) {
  
  I hope you guys can reconsider the decision of relying on 
`device.form_factor`.
  
  Thanks a lot!

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D8054

To: antlarr, #plasma, davidedmundson, drosca
Cc: guilhermesilva, andreask, drosca, sebas, plasma-devel, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart

D12063: Add a hidden config option for showing icons on the root level of the menu

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6bc448a8ea7d: Add a hidden config option for showing 
icons on the root level of the menu (authored by aacid).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12063?vs=31725=32955

REVISION DETAIL
  https://phabricator.kde.org/D12063

AFFECTED FILES
  applets/kicker/package/contents/config/main.xml
  applets/kicker/package/contents/ui/MenuRepresentation.qml

To: aacid, hein
Cc: plasma-devel, #plasma, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12463: Add support for icon-only tasks (what browsers call pinned tabs)

[Fabian Riethmayer]

fabianr added a comment.


  +1
  As soon as there are enough tasks in the task bar, that you can not any 
longer read the title at a glimpse or the tasks start to group the task bar, it 
looses so much of its usefulness. 
  In groups you have to hover , wait, move the mouse and click to activate a 
task and if the labels are too small you either have to wait for the hover or 
guess.
  
  With this possibility to make applications with only one instance open like 
an IDE, a music player, chat, mail, ... to show as icon only in the task bar, 
the point where the tab bar looses it usefulness comes much later.
  
  To mee, this is very similar to pinning tabs in browsers. And in my opinion 
that is one of the best UI improvements in browsers in the recent years. It 
makes tab organization so much clearer, since one can have a lot more tabs open 
before you need to scroll to see all.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12463

To: Fuchs, hein
Cc: fabianr, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart