D12777: Fixed access to current slideshow image using correct field in action_open

odeda added a comment. Thanks! My email address is o...@geek.co.il REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12777 To: odeda, #plasma_workspaces, ngraham, broulik Cc: broulik, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12855: Move Widget search field to its own row so it doesn't get compressed

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. (Please don't land this until at least one Plasma developer has also approved it) REPOSITORY R119 Plasma Desktop BRANCH new-search-row (branched from master) REVISION DETAIL

D12855: Move Widget search field to its own row so it doesn't get compressed

ngraham added a comment. Well this looks good to me. Let's let some of the Plasma devs have a say in the matter now! INLINE COMMENTS > sharvey wrote in WidgetExplorer.qml:235 > A method to my madness! The size is there so the search bar announces its > arrival by expanding the row, pushing

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.10 - Build # 3 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/3/ Project: Plasma plasma-vault kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 15 May 2018 03:38:22 + Build duration: 53 sec and counting CONSOLE OUTPUT

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked 13 inline comments as done. sharvey added inline comments. INLINE COMMENTS > ngraham wrote in WidgetExplorer.qml:235 > I mean, could we do something like `newSearchRow.height = searchInput.height > + (units.smallSpacing * 2)` or something like that? Would that work? > > Now that

D12882: [Notifications] Move "Open With" items into the top group of the menu

ngraham created this revision. ngraham added a reviewer: broulik. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Move the Open With items into the top group of the context menu

KDE CI: Plasma ksysguard kf5-qt5 FreeBSDQt5.10 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20ksysguard%20kf5-qt5%20FreeBSDQt5.10/2/ Project: Plasma ksysguard kf5-qt5 FreeBSDQt5.10 Date of build: Mon, 14 May 2018 23:11:36 + Build duration: 0.82 sec and counting CONSOLE OUTPUT

D12713: Make some strings easier to translate

aacid added inline comments. INLINE COMMENTS > mart wrote in FancyPlotter.cpp:597 > maybe it's worth to have an i18nc here or it looks pretty mysterious? Problem is i don't really understand what lastValue and mlotter->valueAsString are supposed to be  But the nice thing is that at least the

D12713: Make some strings easier to translate

aacid closed this revision. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D12713 To: aacid, #plasma, #localization, mart Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R114:b0fc4805e961: [QuickShare] Respect units.iconSizeHints.panel for panel icon (authored by Zren). REPOSITORY R114

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked an inline comment as done. sharvey added inline comments. INLINE COMMENTS > ngraham wrote in WidgetExplorer.qml:389 > Looks like it's still there? Not a huge deal, but it would be good to figure > out why your changes keep adding or removing whitespace. F5848538:

D12855: Move Widget search field to its own row so it doesn't get compressed

ngraham added inline comments. INLINE COMMENTS > sharvey wrote in WidgetExplorer.qml:235 > We from my (albeit limited) comprehension of `units`, they're all > derived programatically somehow, either from an icon size, a font size, or at > the lowest level, DPI. > > The API page for

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked 7 inline comments as done and 5 inline comments as done. sharvey added inline comments. INLINE COMMENTS > sharvey wrote in WidgetExplorer.qml:235 > We from my (albeit limited) comprehension of `units`, they're all > derived programatically somehow, either from an icon

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked 3 inline comments as not done. sharvey added inline comments. INLINE COMMENTS > ngraham wrote in WidgetExplorer.qml:235 > `units.gridUnit * 2` = 36 pixels. That seems a bit tall, no? Is there any way > we can derive this height value programmatically? We from my (albeit

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey updated this revision to Diff 34160. sharvey marked an inline comment as done and an inline comment as not done. sharvey added a comment. - Remove unneeded commented-out code REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey marked 2 inline comments as done and 2 inline comments as done. sharvey added a comment. More revising in progress. Units. Bah humbug. INLINE COMMENTS > ngraham wrote in WidgetExplorer.qml:203 > Can we use some multiple of `units.smallSpacing` or something here instead of > a

D12855: Move Widget search field to its own row so it doesn't get compressed

ngraham added inline comments. INLINE COMMENTS > WidgetExplorer.qml:235 > +} else { > + newSearchRow.height = units.gridUnit * 2 > } `units.gridUnit * 2` = 36 pixels. That seems a bit tall, no? Is there any way we can derive this height value

D12855: Move Widget search field to its own row so it doesn't get compressed

sharvey updated this revision to Diff 34158. sharvey marked an inline comment as done and an inline comment as not done. sharvey added a comment. - Units changed to `gridUnits` instead of `smallSpacing`; whitespace cleanup REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

bugfix in frameworks vital for 5.13

Hi all, about https://bugs.kde.org/show_bug.cgi?id=394134 which makes many new kcms look borked, the problem actually wasn't the upstream qt bug (which is an issue as well) but another one which was actually in qqc2-desktop-style now, since released frameworks is the one that 5.13 has to depend,

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

Pitel added a comment. @martinkostolny I will try to give it some testing this week. REPOSITORY R884 Active Window Control Applet for Plasma REVISION DETAIL https://phabricator.kde.org/D11071 To: Pitel, #plasma, martinkostolny Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

Re: Cursor sizes on wayland

We definitely need to scale the cursor image to device pixels in DRM Output. That's code we need to add that I simply haven't done yet; it wasn't a high priority as we also have the concept of just cursors being bigger X-style. Your Qt patch will allow us to do that whilst keeping assets drawn in

D12849: Improve layout of fonts kcm

abetts added a comment. In D12849#262405 , @progwolff wrote: > You mean like this? > F5848305: Screenshot_fonts_layout_nocheckableitems.png > > Not sure if I like this better... This way "Exclude

D12849: Improve layout of fonts kcm

ngraham added a comment. In D12849#262405 , @progwolff wrote: > Not sure if I like this better... This way "Exclude range" seems to be somewhat unrelated to "Anti-Aliasing". Also, it is not very clear what the checkbox after "Fonts DPI"

Re: Cursor sizes on wayland

On Sun, May 13, 2018 at 5:34 PM, Martin Flöser wrote: > Am 2018-05-09 12:08, schrieb Aleix Pol: >> >> On Tue, May 8, 2018 at 8:57 PM, Martin Flöser wrote: >>> >>> >>> >>> Am 8. Mai 2018 17:05:57 MESZ schrieb Aleix Pol : Hi,

D12849: Improve layout of fonts kcm

progwolff added a comment. You mean like this? F5848305: Screenshot_fonts_layout_nocheckableitems.png Not sure if I like this better... This way "Exclude range" seems to be somewhat unrelated to "Anti-Aliasing". Also, it is not very clear what

D12804: Fix window frame rounding when scaling is used

anemeth added a comment. Here is Breeze close button modified to use `QPainter::drawRoundedRect()` and uses the same radius (3) as the titlebar: F5848210: aa.PNG This scales well, so I don't think it is a bug in Qt. REPOSITORY R31 Breeze

D12701: Remove D10890 workaround

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ada8fca90381: Remove D10890 workaround (authored by aleksejshilin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12701?vs=33655=34150 REVISION DETAIL

D12804: Fix window frame rounding when scaling is used

anemeth added a comment. In D12804#262333 , @zzag wrote: > Also, what session it is? (X11 or Wayland) > > I think you're facing one of X11 issues. X11 On Wayland it scales right REPOSITORY R31 Breeze REVISION DETAIL

D12804: Fix window frame rounding when scaling is used

zzag added a comment. Also, is it X11 or Wayland session? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D12804 To: anemeth, #breeze, #vdg, hpereiradacosta, davidedmundson Cc: zzag, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12804: Fix window frame rounding when scaling is used

zzag added a comment. In D12804#262301 , @hpereiradacosta wrote: > Most likely the actual issue is in kdecoration2 ... I don't think so. Again, IIRC, decoration render does the following: - create backing store - sets device pixel

D12849: Improve layout of fonts kcm

abetts added a comment. In D12849#262088 , @rkflx wrote: > The checkboxes wildly floating around on the left look a bit weird to me. How about this (I guess your original intention was to avoid having checkboxes under the wrong text label?):

D12804: Fix window frame rounding when scaling is used

hpereiradacosta added a comment. In D12804#262291 , @davidedmundson wrote: > > IIRC, decoration renderer sets device pixel ratio, so in theory, you should not multiply frame radius by dpr. > > For some reason my comment went missing, but as

D12855: Move Widget search field to its own row so it doesn't get compressed

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12855 To: sharvey, ngraham, davidedmundson Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon

abetts added a comment. +1 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12859 To: Zren, #plasma, apol Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D12804: Fix window frame rounding when scaling is used

davidedmundson added a comment. > IIRC, decoration renderer sets device pixel ratio, so in theory, you should not multiply frame radius by dpr. For some reason my comment went missing, but as zzag said, with high DPI here the only things we should ever change are pixmap sizes and

D12870: [SourcesModel] Check changed file name before reloading configuration

This revision was automatically updated to reflect the committed changes. Closed by commit R112:c0fa968c08fc: [SourcesModel] Check changed file name before reloading configuration (authored by broulik). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE

D12870: [SourcesModel] Check changed file name before reloading configuration

broulik added a comment. `KDirWatch` is a singleton and when this is used from within plasmashell (e.g. Kickoff's search model) it will cause changes as `Units` adds watchers on plasma configs REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D12870 To: broulik,

D12777: Fixed access to current slideshow image using correct field in action_open

ngraham added a comment. @odeda, can you provide your email address so that we can land this with proper authorship information? Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12777 To: odeda, #plasma_workspaces, ngraham, broulik Cc: broulik,

D12686: Fix sidebar view regression of not prompting about unsaved changes

This revision was automatically updated to reflect the committed changes. Closed by commit R124:0aa7fd015b0c: Fix sidebar view regression of not prompting about unsaved changes (authored by davidedmundson). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE

D12794: [weather applet] Improve name & comment metadata

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Ship it! Ship it now! :) https://www.youtube.com/watch?v=NflTOYuVJ0E REPOSITORY R114 Plasma Addons BRANCH fixweatherappletmetadata REVISION DETAIL

D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon

Zren updated this revision to Diff 34138. Zren added a comment. Remove unrelated brace formatting. If there's nothing else, I'll merge it this evening. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12859?vs=34090=34138 REVISION DETAIL

D12794: [weather applet] Improve name & comment metadata

kossebau updated this revision to Diff 34137. kossebau added a comment. pick up proposed wording, thanks for that Will push this version then CET tonight, unless someone objects "shipit"s still welcome as well :) REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D12855: Move Widget search field to its own row so it doesn't get compressed

ngraham added a comment. A few more code comments that I missed in the first go-around, sorry. Behavior-wise, I think this is a huge improvement! INLINE COMMENTS > WidgetExplorer.qml:155 > } > + > /* whitespace change :) > WidgetExplorer.qml:236 > +} else { > +

D12835: Draw borders around side panels by default

romangg added subscribers: hein, romangg. romangg added a comment. I agree with you @ngraham that the current design is not optimal and is not standardized enough in our HIG nor in practical usage by KDE apps and Plasma. But simply changing the default and by that adding more frames

D12794: [weather applet] Improve name & comment metadata

sharvey added a comment. +1 for "Forecast & Current Conditions" - I think this is what they use on the American cable network "The Weather Channel" REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12794 To: kossebau, #plasma Cc: sharvey, jriddell, ngraham,

D12870: [SourcesModel] Check changed file name before reloading configuration

apol added a comment. It doesn't look like other files are being added to the KDirWatch, no? REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D12870 To: broulik, #plasma Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D12794: [weather applet] Improve name & comment metadata

jriddell added a comment. I also like "Forecast and current conditions" REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12794 To: kossebau, #plasma Cc: jriddell, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D12855: Move search field to its own row so it doesn't get compressed

sharvey updated this revision to Diff 34129. sharvey added a comment. - Remove hardcoded pixel sizes; misc code cleanup REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12855?vs=34083=34129 BRANCH new-search-row (branched from master) REVISION

D12870: [SourcesModel] Check changed file name before reloading configuration

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Avoid needlessly reloading configuration if something completely

D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Looks good to me, please fix the comment Kay mentioned so we can land the change. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D12859 To: Zren,

Re: minutes meeting week 20

On Mon, May 14, 2018 at 04:18:07PM +0530, Bhushan Shah wrote: > (See logs for more discussion) and ofcourse logs I forgot to attach, attached now -- Bhushan Shah http://blog.bshah.in IRC Nick : bshah on Freenode GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D 15:31

minutes meeting week 20

Hello, Attached are notes from meeting week 20: * kbroulik and bshah were sick and execused from meeting Present: bshah, kbroulik, Sho_, notmart, romangg, Riddell Sho_: * [PBI] Finished David's browser integration extension installation reminder for him, since went on vacation * [SysSe]

D12102: Port Language KCM to Qt Quick

This revision was automatically updated to reflect the committed changes. Closed by commit R119:6055cfb94e1e: Port Language KCM to Qt Quick (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12102?vs=34121=34123 REVISION DETAIL

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 34121. hein added a comment. Move removal into the C++ model code to avoid another model reset and speed up the UX. Please re-review now for 5.13 inclusion. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D12102: Port Language KCM to Qt Quick

hein updated this revision to Diff 34120. hein added a comment. Add back Move up/down actions. DND won't be ready in Kirigami for 5.13, but as this port fixes critical bugs vs. the old version - such as not actually saving settings ... - we still want this in 5.13. To prepare for

D12855: Move search field to its own row so it doesn't get compressed

sharvey added inline comments. INLINE COMMENTS > ngraham wrote in WidgetExplorer.qml:157 > ? Not sure The extra comment adds anything. Instead we should just remove the > commented-out code in a new patch IMHO. I'm always unclear what to do when I find blocks of other people's comments. Some

D12849: Improve layout of fonts kcm

rkflx added a comment. The checkboxes wildly floating around on the left look a bit weird to me. How about this (I guess your original intention was to avoid having checkboxes under the wrong text label?): Anti-Aliasing: Enabled [ ] Exclude range from 8pt to 15pt

D12822: Added null check in OverlayDrawer

mart added a comment. ok this can be abandoned then REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12822 To: Dax Cc: mart, apol, plasma-devel, davidedmundson, hein

D12823: Workaround for binding loop in Material Theme

mart added a comment. this would break the binding loop, and things should be able to dynamically change color, so the proper cause should be found REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D12823 To: Dax Cc: mart, apol, plasma-devel, davidedmundson, hein

D12849: Improve layout of fonts kcm

mart accepted this revision. mart added a comment. This revision is now accepted and ready to land. for me, good to go REPOSITORY R119 Plasma Desktop BRANCH fonts_kcm_layout (branched from master) REVISION DETAIL https://phabricator.kde.org/D12849 To: progwolff, mart, abetts, ngraham

D12849: Improve layout of fonts kcm

mart added a comment. In D12849#262026 , @progwolff wrote: > In D12849#261837 , @ngraham wrote: > > > We might want to take the opportunity to also center-align the titles, which it better-looking

D12849: Improve layout of fonts kcm

mart added a comment. In D12849#261837 , @ngraham wrote: > Alignment looks great to me! We might want to take the opportunity to also center-align the titles, which it better-looking for these centered formlayout style UIs. And maybe use a bit

D12698: Show SNI to install browser-side extension

This revision was automatically updated to reflect the committed changes. Closed by commit R856:2723ef0c80a6: WIP: Show SNI to install browser-side extension (authored by davidedmundson, committed by hein). REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE

D12698: Show SNI to install browser-side extension

hein updated this revision to Diff 34112. hein added a comment. Switch icon REPOSITORY R856 Plasma Browser Integration CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12698?vs=33976=34112 BRANCH arcpatch-D12698 REVISION DETAIL https://phabricator.kde.org/D12698 AFFECTED

D7087: Add "Copy Info" button to the About System KCM

gregormi updated this revision to Diff 34111. gregormi added a comment. - Apply comments by reviewers: - move declaration near to usage - Reuse label texts - Rename label to more speaking name REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D12698: Show SNI to install browser-side extension

broulik accepted this revision. broulik added a comment. Thanks a lot! INLINE COMMENTS > browserintegrationreminder.cpp:133 > +m_sni->setTitle(i18n("Get Plasma Browser Integration")); > +m_sni->setIconByName("internet-web-browser"); > +m_sni->setStandardActionsEnabled(false);

D12849: Improve layout of fonts kcm

progwolff added a comment. In D12849#261837 , @ngraham wrote: > We might want to take the opportunity to also center-align the titles, which it better-looking for these centered formlayout style UIs. Section titles in form layouts are

D12775: Always set applet title, even when label is disabled

broulik added inline comments. INLINE COMMENTS > FolderViewLayer.qml:85 > +property: "title" > +value: labelGenerator.displayLabel > +} > Except when we're a containment. Isn't a `when: !isContainment` nicer, then? (Just asking, no need to change it) REPOSITORY R119

D12777: Fixed access to current slideshow image using correct field in action_open

broulik accepted this revision. broulik added a comment. Works fine. Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12777 To: odeda, #plasma_workspaces, ngraham, broulik Cc: broulik, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon

broulik added a comment. +1 INLINE COMMENTS > main.qml:65 > > -function urlsMimetype(urls) > -{ > +function urlsMimetype(urls) { > return mimeDb.mimeTypeForUrl(urls[0]); Unrelated change REPOSITORY R114 Plasma Addons REVISION DETAIL