D12777: Fixed access to current slideshow image using correct field in action_open

[Oded Arbel]

odeda added a comment.


  Thanks!
  
  My email address is o...@geek.co.il

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12777

To: odeda, #plasma_workspaces, ngraham, broulik
Cc: broulik, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12855: Move Widget search field to its own row so it doesn't get compressed

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  (Please don't land this until at least one Plasma developer has also approved 
it)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  new-search-row (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12855

To: sharvey, ngraham, davidedmundson
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D12855: Move Widget search field to its own row so it doesn't get compressed

[Nathaniel Graham]

ngraham added a comment.


  Well this looks good to me. Let's let some of the Plasma devs have a say in 
the matter now!

INLINE COMMENTS

> sharvey wrote in WidgetExplorer.qml:235
> A method to my madness! The size is there so the search bar announces its 
> arrival by expanding the row, pushing the widget grid downward, and 
> appearing. And then again in reverse.
> 
> Otherwise, there's just an empty space there, waiting for the search box to 
> appear.
> 
> It's not much eye candy, but just a little bit.

Ah, I see what you mean now!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12855

To: sharvey, ngraham, davidedmundson
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.10 - Build # 3 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/3/
 Project:
Plasma plasma-vault kf5-qt5 FreeBSDQt5.10
 Date of build:
Tue, 15 May 2018 03:38:22 +
 Build duration:
53 sec and counting
   CONSOLE OUTPUT
  [...truncated 64.56 KB...]XDG_CURRENT_DESKTOP   = 'KDE'EXECUTOR_NUMBER   = '0'SHELL = '/bin/tcsh'RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/3/display/redirect'JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/display/redirect'WORKSPACE = '/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.10'STAGE_NAME= 'Configuring Build'JENKINS_HOME  = '/home/production/data'EDITOR= 'vi'BUILD_URL = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/3/'MAIL  = '/var/mail/jenkins'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:symbolize=1'XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'VENDOR= 'amd'JOB_NAME  = 'Plasma plasma-vault kf5-qt5 FreeBSDQt5.10'PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'USER  = 'jenkins'BUILD_DISPLAY_NAME= '#3'NODE_NAME = 'FreeBSD Builder 3'BUILD_NUMBER  = '3'JOB_URL   = 'https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/'TERM  = 'su'BUILD_TAG = 'jenkins-Plasma plasma-vault kf5-qt5 FreeBSDQt5.10-3'JENKINS_URL   = 'https://build.kde.org/'HOME  = '/usr/home/jenkins/'QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins'JAVA_HOME = '/usr/local/openjdk8-jre'BLOCKSIZE = 'K'MACHTYPE  = 'x86_64'LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'PWD   = '/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.10'BUILD_ID  = '3'HOSTTYPE  = 'FreeBSD'XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'HOST  = 'freebsd-node3'NODE_LABELS   = 'FreeBSD Builder 3 FreeBSDQt5.10'LANG  = 'en_US.UTF-8'SHLVL = '1'PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/usr/home/jenkins//bin'QT_SELECT = 'qt5'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins//install-prefix/"  "/usr/home/jenkins/workspace/Plasma plasma-vault kf5-qt5 FreeBSDQt5.10"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.46.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.46.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.46.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.46.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.46.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.46.0") -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found 

D12855: Move Widget search field to its own row so it doesn't get compressed

[Scott Harvey]

sharvey marked 13 inline comments as done.
sharvey added inline comments.

INLINE COMMENTS

> ngraham wrote in WidgetExplorer.qml:235
> I mean, could we do something like `newSearchRow.height = searchInput.height 
> + (units.smallSpacing * 2)` or something like that? Would that work?
> 
> Now that I think about it, instead of conditionally adjusting the height in 
> this if/else block, could we just have this toggle the `showingSearch` 
> property? Does that not work? In fact, I wonder why we need the `onClicked` 
> as well as `onCheckedChanged` lines at all. Perhaps those could be simplified 
> into just one.

A method to my madness! The size is there so the search bar announces its 
arrival by expanding the row, pushing the widget grid downward, and appearing. 
And then again in reverse.

Otherwise, there's just an empty space there, waiting for the search box to 
appear.

It's not much eye candy, but just a little bit.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12855

To: sharvey, ngraham, davidedmundson
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D12882: [Notifications] Move "Open With" items into the top group of the menu

[Nathaniel Graham]

ngraham created this revision.
ngraham added a reviewer: broulik.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Move the Open With items into the top group of the context menu for 
notifications with images or files that you can open and see in the filesystem.
  
  I didn't move them all the way to the top because my sense is that Open 
containing folder is the more common action and deserves to be the top item. 
Also, putting it below the Open With actions would result in an extra ugly 
separator.

TEST PLAN
  [image goes here]

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12882

AFFECTED FILES
  applets/notifications/plugin/thumbnailer.cpp

To: ngraham, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma ksysguard kf5-qt5 FreeBSDQt5.10 - Build # 2 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20ksysguard%20kf5-qt5%20FreeBSDQt5.10/2/
 Project:
Plasma ksysguard kf5-qt5 FreeBSDQt5.10
 Date of build:
Mon, 14 May 2018 23:11:36 +
 Build duration:
0.82 sec and counting
   CONSOLE OUTPUT
  Started by an SCM changeRunning in Durability level: MAX_SURVIVABILITY[Pipeline] nodeRunning on FreeBSD Builder 2 in /usr/home/jenkins/workspace/Plasma ksysguard kf5-qt5 FreeBSDQt5.10[Pipeline] {[Pipeline] timestamps[Pipeline] {[Pipeline] catchError[Pipeline] {[Pipeline] stage[Pipeline] { (Checkout Sources)[Pipeline] deleteDir[Pipeline] checkoutCloning the remote Git repositoryCloning repository git://anongit.kde.org/ksysguard > git init /usr/home/jenkins/workspace/Plasma ksysguard kf5-qt5 FreeBSDQt5.10 # timeout=10Fetching upstream changes from git://anongit.kde.org/ksysguard > git --version # timeout=10 > git fetch --tags --progress git://anongit.kde.org/ksysguard +refs/heads/*:refs/remotes/origin/* # timeout=120ERROR: Error cloning remote repo 'origin'hudson.plugins.git.GitException: Command "git fetch --tags --progress git://anongit.kde.org/ksysguard +refs/heads/*:refs/remotes/origin/*" returned status code 128:stdout: stderr: fatal: unable to connect to anongit.kde.org:anongit.kde.org[0: 31.216.41.69]: errno=Connection refused	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandIn(CliGitAPIImpl.java:1996)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.launchCommandWithCredentials(CliGitAPIImpl.java:1715)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl.access$300(CliGitAPIImpl.java:72)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$1.execute(CliGitAPIImpl.java:405)	at org.jenkinsci.plugins.gitclient.CliGitAPIImpl$2.execute(CliGitAPIImpl.java:614)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:153)	at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler$1.call(RemoteGitImpl.java:146)	at hudson.remoting.UserRequest.perform(UserRequest.java:212)	at hudson.remoting.UserRequest.perform(UserRequest.java:54)	at hudson.remoting.Request$2.run(Request.java:369)	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)	at java.util.concurrent.FutureTask.run(FutureTask.java:266)	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)	at java.lang.Thread.run(Thread.java:748)	Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to FreeBSD Builder 2		at hudson.remoting.Channel.attachCallSiteStackTrace(Channel.java:1741)		at hudson.remoting.UserRequest$ExceptionResponse.retrieve(UserRequest.java:357)		at hudson.remoting.Channel.call(Channel.java:955)		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.execute(RemoteGitImpl.java:146)		at sun.reflect.GeneratedMethodAccessor469.invoke(Unknown Source)		at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)		at java.lang.reflect.Method.invoke(Method.java:498)		at org.jenkinsci.plugins.gitclient.RemoteGitImpl$CommandInvocationHandler.invoke(RemoteGitImpl.java:132)		at com.sun.proxy.$Proxy74.execute(Unknown Source)		at hudson.plugins.git.GitSCM.retrieveChanges(GitSCM.java:1120)		at hudson.plugins.git.GitSCM.checkout(GitSCM.java:1160)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep.checkout(SCMStep.java:113)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:85)		at org.jenkinsci.plugins.workflow.steps.scm.SCMStep$StepExecutionImpl.run(SCMStep.java:75)		at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution$1$1.call(AbstractSynchronousNonBlockingStepExecution.java:47)		at hudson.security.ACL.impersonate(ACL.java:290)		at org.jenkinsci.plugins.workflow.steps.AbstractSynchronousNonBlockingStepExecution$1.run(AbstractSynchronousNonBlockingStepExecution.java:44)		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)		... 4 more[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: Error cloning remote repo 'origin'[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

D12713: Make some strings easier to translate

[Albert Astals Cid]

aacid added inline comments.

INLINE COMMENTS

> mart wrote in FancyPlotter.cpp:597
> maybe it's worth to have an i18nc here or it looks pretty mysterious?

Problem is i don't really understand what lastValue and mlotter->valueAsString 
are supposed to be 

But the nice thing is that at least the message won't be worse than it was.

REPOSITORY
  R106 KSysguard

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12713

To: aacid, #plasma, #localization, mart
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D12713: Make some strings easier to translate

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D12713

To: aacid, #plasma, #localization, mart
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon

[Chris Holland]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R114:b0fc4805e961: [QuickShare] Respect 
units.iconSizeHints.panel for panel icon (authored by Zren).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12859?vs=34138=34162

REVISION DETAIL
  https://phabricator.kde.org/D12859

AFFECTED FILES
  applets/quickshare/plasmoid/contents/ui/main.qml

To: Zren, #plasma, apol, broulik
Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D12855: Move Widget search field to its own row so it doesn't get compressed

[Scott Harvey]

sharvey marked an inline comment as done.
sharvey added inline comments.

INLINE COMMENTS

> ngraham wrote in WidgetExplorer.qml:389
> Looks like it's still there? Not a huge deal, but it would be good to figure 
> out why your changes keep adding or removing whitespace.

F5848538: Screenshot_20180514_142722.png 
Look! An empty line at the bottom of the file. Not sure what's trimming them 
off. I'm editing in Sublime (since QtCreator doesn't "see" this QML file), but 
I get a handy red + from an instant git diff.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12855

To: sharvey, ngraham, davidedmundson
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D12855: Move Widget search field to its own row so it doesn't get compressed

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> sharvey wrote in WidgetExplorer.qml:235
> We from my (albeit limited) comprehension of `units`, they're all 
> derived programatically somehow, either from an icon size, a font size, or at 
> the lowest level, DPI.
> 
> The API page for `Units::gridUnits` reads
> 
> > The fundamental unit of space that should be used for sizes, expressed in 
> > pixels.
> > 
> > Given the screen has an accurate DPI settings, it corresponds to a width of 
> > the capital letter M
> 
> So if I understand your question correctly, deriving the row size from a font 
> size would be redundant. Wouldn't it?

I mean, could we do something like `newSearchRow.height = searchInput.height + 
(units.smallSpacing * 2)` or something like that? Would that work?

Now that I think about it, instead of conditionally adjusting the height in 
this if/else block, could we just have this toggle the `showingSearch` 
property? Does that not work? In fact, I wonder why we need the `onClicked` as 
well as `onCheckedChanged` lines at all. Perhaps those could be simplified into 
just one.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12855

To: sharvey, ngraham, davidedmundson
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D12855: Move Widget search field to its own row so it doesn't get compressed

[Scott Harvey]

sharvey marked 7 inline comments as done and 5 inline comments as done.
sharvey added inline comments.

INLINE COMMENTS

> sharvey wrote in WidgetExplorer.qml:235
> We from my (albeit limited) comprehension of `units`, they're all 
> derived programatically somehow, either from an icon size, a font size, or at 
> the lowest level, DPI.
> 
> The API page for `Units::gridUnits` reads
> 
> > The fundamental unit of space that should be used for sizes, expressed in 
> > pixels.
> > 
> > Given the screen has an accurate DPI settings, it corresponds to a width of 
> > the capital letter M
> 
> So if I understand your question correctly, deriving the row size from a font 
> size would be redundant. Wouldn't it?

Plus, `gridUnit * 2` doesn't //seem// excessively large. There's some 
whitespace, but I don't think it's overkill.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12855

To: sharvey, ngraham, davidedmundson
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D12855: Move Widget search field to its own row so it doesn't get compressed

[Scott Harvey]

sharvey marked 3 inline comments as not done.
sharvey added inline comments.

INLINE COMMENTS

> ngraham wrote in WidgetExplorer.qml:235
> `units.gridUnit * 2` = 36 pixels. That seems a bit tall, no? Is there any way 
> we can derive this height value programmatically?

We from my (albeit limited) comprehension of `units`, they're all 
derived programatically somehow, either from an icon size, a font size, or at 
the lowest level, DPI.

The API page for `Units::gridUnits` reads

> The fundamental unit of space that should be used for sizes, expressed in 
> pixels.
> 
> Given the screen has an accurate DPI settings, it corresponds to a width of 
> the capital letter M

So if I understand your question correctly, deriving the row size from a font 
size would be redundant. Wouldn't it?

> ngraham wrote in WidgetExplorer.qml:264
> Delete code, don't comment it out.

Self = kicked.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12855

To: sharvey, ngraham, davidedmundson
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D12855: Move Widget search field to its own row so it doesn't get compressed

[Scott Harvey]

sharvey updated this revision to Diff 34160.
sharvey marked an inline comment as done and an inline comment as not done.
sharvey added a comment.


  - Remove unneeded commented-out code

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12855?vs=34158=34160

BRANCH
  new-search-row (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12855

AFFECTED FILES
  desktoppackage/contents/explorer/WidgetExplorer.qml

To: sharvey, ngraham, davidedmundson
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D12855: Move Widget search field to its own row so it doesn't get compressed

[Scott Harvey]

sharvey marked 2 inline comments as done and 2 inline comments as done.
sharvey added a comment.


  More revising in progress. Units. Bah humbug.

INLINE COMMENTS

> ngraham wrote in WidgetExplorer.qml:203
> Can we use some multiple of `units.smallSpacing` or something here instead of 
> a hardcoded pixel value?

Switched to regular `gridUnit` sizing. `Units` would appear to be the de facto 
measurement in Plasmaworld. They're based on DPI and are supposed to scale 
independently, so, yes - better than pixels. Whether `units.gridUnits` or 
`units.smallSpacing` is used seems to depend solely on the scale needed and 
your willingness to do multiplication. Both variations are used in the 
(unmodified) scroll area of this Explorer.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12855

To: sharvey, ngraham, davidedmundson
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D12855: Move Widget search field to its own row so it doesn't get compressed

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> WidgetExplorer.qml:235
> +} else {
> + newSearchRow.height = units.gridUnit * 2
>  }

`units.gridUnit * 2` = 36 pixels. That seems a bit tall, no? Is there any way 
we can derive this height value programmatically?

> WidgetExplorer.qml:264
> +
> +   // height: 0
> +visible: heading.showingSearch

Delete code, don't comment it out.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12855

To: sharvey, ngraham, davidedmundson
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D12855: Move Widget search field to its own row so it doesn't get compressed

[Scott Harvey]

sharvey updated this revision to Diff 34158.
sharvey marked an inline comment as done and an inline comment as not done.
sharvey added a comment.


  - Units changed to `gridUnits` instead of `smallSpacing`; whitespace cleanup

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12855?vs=34129=34158

BRANCH
  new-search-row (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12855

AFFECTED FILES
  desktoppackage/contents/explorer/WidgetExplorer.qml

To: sharvey, ngraham, davidedmundson
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

bugfix in frameworks vital for 5.13

[Marco Martin]

Hi all,
about https://bugs.kde.org/show_bug.cgi?id=394134 which makes many new kcms 
look borked, the problem actually wasn't the upstream qt bug (which is an 
issue as well)
but another one which was actually in qqc2-desktop-style
now, since released frameworks is the one that 5.13 has to depend, how to 
proceed, respin the tarball?

the commit that's needed is 
https://commits.kde.org/qqc2-desktop-style/
8790d850c4343b9f615457f0926cc3cdcef8d0c7

-- 
Marco Martin

D11071: [RFC] [Active Window Control] Allow global menu be left alligned with buttons on right

[Radek Hušek]

Pitel added a comment.


  @martinkostolny I will try to give it some testing this week.

REPOSITORY
  R884 Active Window Control Applet for Plasma

REVISION DETAIL
  https://phabricator.kde.org/D11071

To: Pitel, #plasma, martinkostolny
Cc: mart, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol

Re: Cursor sizes on wayland

[David Edmundson]

We definitely need to scale the cursor image to device pixels in DRM
Output. That's code we need to add that I simply haven't done yet; it
wasn't a high priority as we also have the concept of just cursors being
bigger X-style.
Your Qt patch will allow us to do that whilst keeping assets drawn in
native resolutions.

> For a cursor wl_surface KWin neither emits the output information nor
uses the scale information. Both would be relative easy to implement. But
only makes sense if toolkits support it. Last time I looked at Qt code, Qt
did not (but that's some time ago).

I think having cursors match the surface is absolutely fine (Qt's current
state). If everything was working properly in the worst case it gets
upscaled/downscaled, but should still be the same size on screen.

---

However, that's all somewhat unrelated to the bug Aleix showed me.

Me not implementing wl_output style scaling would put the cursor simply
always too small or always too big. Especially as Qt didn't do anything at
the time.
Yet we saw it bounce about all over the place. That seems more a bug of the
X-style scaling

David

D12849: Improve layout of fonts kcm

[Andres Betts]

abetts added a comment.


  In D12849#262405 , @progwolff 
wrote:
  
  > You mean like this?
  >  F5848305: Screenshot_fonts_layout_nocheckableitems.png 

  >
  > Not sure if I like this better... This way "Exclude range" seems to be 
somewhat unrelated to "Anti-Aliasing". Also, it is not very clear what the 
checkbox after "Fonts DPI" belongs to.
  
  
  Yes! I share your concerns too!
  
  What about this?
  
  For example:
  
  Sub pixel rendering: ENABLED
  
  CHECKBOX Exclude range from
  SPINNER BOX to SPINNER box
  
  And we end up with 3 lines and not 2 and lines 2-3 are aligned to the 
checkbox?
  
  Also, if we feel that the settings are co-dependant, we could use a model 
like this:
  
  F5848319: change-dns-mac-os-x.jpg 
  
  Where you see that there is a clear section title, and subsequent checkboxes 
are below and aligned to the first item

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fonts_kcm_layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12849

To: progwolff, mart, abetts, ngraham
Cc: rkflx, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12849: Improve layout of fonts kcm

[Nathaniel Graham]

ngraham added a comment.


  In D12849#262405 , @progwolff 
wrote:
  
  > Not sure if I like this better... This way "Exclude range" seems to be 
somewhat unrelated to "Anti-Aliasing". Also, it is not very clear what the 
checkbox after "Fonts DPI" belongs to.
  
  
  I like the original better too.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fonts_kcm_layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12849

To: progwolff, mart, abetts, ngraham
Cc: rkflx, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Cursor sizes on wayland

[Aleix Pol]

On Sun, May 13, 2018 at 5:34 PM, Martin Flöser  wrote:
> Am 2018-05-09 12:08, schrieb Aleix Pol:
>>
>> On Tue, May 8, 2018 at 8:57 PM, Martin Flöser  wrote:
>>>
>>>
>>>
>>> Am 8. Mai 2018 17:05:57 MESZ schrieb Aleix Pol :

 Hi,
 I've been looking into getting a consistent cursor look on wayland,
 which is specially daunting because of scaling.

 I'd like to look into fixing it for xwayland clients. Would somebody
 be able to shed some light into the issue so I can understand it and
 fix it?

>>> Xwayland clients use the normal X11 API to set cursors. Xwayland just
>>> forwards them through the Wayland protocol. The env variable for cursor size
>>> is the same on Wayland and X11, so there should not be any difference.
>>>
>>> I'm not sure what exactly you want to look into. Personally I had the
>>> feeling that apps started to act crazy concerning cursor sizes - on Wayland
>>> and on X11. Normally there just should not be any difference. There's one
>>> env variable controlling it and if all apps would just use it and not do
>>> crazy stuff instead it would just work.
>>
>>
>> Well, setting the cursor size isn't any useful if you have two
>> monitors. I have it configured at resolution-dependent at the moment
>> and sometimes I lose my cursor on my high dpi screen.
>> If I use something bigger, when I move it to my external monitor I get
>> a monstrosity.
>>
>> David mentioned at the sprint that we maybe should be correcting its
>> scale on the kwin size, if it's not being scaled yet.
>
>
> This might be part of the solution. This needs a more general solution and
> might require changes to Wayland protocols and each toolkit and KWin.
>
> For "normal" windows we use the wl_surface::enter to inform on which output
> they are. Thus they can adjust for different dpi. Similar there is the scale
> information on a wl_surface.
>
> For a cursor wl_surface KWin neither emits the output information nor uses
> the scale information. Both would be relative easy to implement. But only
> makes sense if toolkits support it. Last time I looked at Qt code, Qt did
> not (but that's some time ago).
>
> So to get this properly working, I would suggest to add the output
> enter/leave information to cursor surfaces and honor scale in KWin. Then add
> the same to QtWayland if it doesn't exist already.
>
> Cheers
> Martin

The scale information should already be available in the surface, and
if it's not, then it should be added:
https://codereview.qt-project.org/#/c/227665/

Still we need to use this information.

Aleix

D12849: Improve layout of fonts kcm

[Julian Wolff]

progwolff added a comment.


  You mean like this?
  F5848305: Screenshot_fonts_layout_nocheckableitems.png 

  
  Not sure if I like this better... This way "Exclude range" seems to be 
somewhat unrelated to "Anti-Aliasing". Also, it is not very clear what the 
checkbox after "Fonts DPI" belongs to.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fonts_kcm_layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12849

To: progwolff, mart, abetts, ngraham
Cc: rkflx, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12804: Fix window frame rounding when scaling is used

[Alex Nemeth]

anemeth added a comment.


  Here is Breeze close button modified to use `QPainter::drawRoundedRect()` and 
uses the same radius (3) as the titlebar:
  
  F5848210: aa.PNG 
  
  This scales well, so I don't think it is a bug in Qt.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D12804

To: anemeth, #breeze, #vdg, hpereiradacosta, davidedmundson
Cc: zzag, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12701: Remove D10890 workaround

[Алексей Шилин]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ada8fca90381: Remove D10890 workaround (authored by 
aleksejshilin).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12701?vs=33655=34150

REVISION DETAIL
  https://phabricator.kde.org/D12701

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/taskmanager/plugin/backend.cpp

To: aleksejshilin, #plasma, broulik, hein
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12804: Fix window frame rounding when scaling is used

[Alex Nemeth]

anemeth added a comment.


  In D12804#262333 , @zzag wrote:
  
  > Also, what session it is? (X11 or Wayland)
  >
  > I think you're facing one of X11 issues.
  
  
  X11
  On Wayland it scales right

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D12804

To: anemeth, #breeze, #vdg, hpereiradacosta, davidedmundson
Cc: zzag, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12804: Fix window frame rounding when scaling is used

[Vlad Zagorodniy]

zzag added a comment.


  Also, is it X11 or Wayland session?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D12804

To: anemeth, #breeze, #vdg, hpereiradacosta, davidedmundson
Cc: zzag, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12804: Fix window frame rounding when scaling is used

[Vlad Zagorodniy]

zzag added a comment.


  In D12804#262301 , 
@hpereiradacosta wrote:
  
  > Most likely the actual issue is in kdecoration2 ...
  
  
  I don't think so. Again, IIRC, decoration render does the following:
  
  - create backing store
  - sets device pixel ratio
  - creates QPainter
  - passes the QPainter instance to decoration (->paint(, ...))
  
  So, that's maybe an issue in Qt or KWin.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D12804

To: anemeth, #breeze, #vdg, hpereiradacosta, davidedmundson
Cc: zzag, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12849: Improve layout of fonts kcm

[Andres Betts]

abetts added a comment.


  In D12849#262088 , @rkflx wrote:
  
  > The checkboxes wildly floating around on the left look a bit weird to me. 
How about this (I guess your original intention was to avoid having checkboxes 
under the wrong text label?):
  >
  >   Anti-Aliasing: Enabled
  >  [ ] Exclude range from 8pt to 15pt
  >   (…)
  >   Fonts DPI: [ ] Force to 96 dpi
  >
  >
  >
  >
  >  ---
  >
  > A more general comment: Compared to the state before the redesign, the 
dialog now looks like two separate KCMs slapped together, as can be seen by the 
need to include two title headers and the separating line. Also, the settings 
on the top are easily understandable by any word processor user, while the 
terminology on the bottom requires more expert knowledge.
  >
  > It might be worth thinking about a different way to group both sections. 
I'm not suggesting going back to the modal dialog, but maybe group boxes, two 
tabs, or a `KCollapsibleGroupBox` would be better?
  
  
  I was just thinking the same thing! In my original design, I did not want to 
manipulate the organization so deep but I feel your suggestion is a sensible 
suggestion. If someone has the time to redo the floating checkboxes placement, 
that would be great!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fonts_kcm_layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12849

To: progwolff, mart, abetts, ngraham
Cc: rkflx, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12804: Fix window frame rounding when scaling is used

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D12804#262291 , @davidedmundson 
wrote:
  
  > > IIRC, decoration renderer sets device pixel ratio, so in theory, you 
should not multiply frame radius by dpr.
  >
  > For some reason my comment went missing, but as zzag said, with high DPI 
here the only things we should ever change are pixmap sizes and  
QPixmap::setDevicePixelRatio  not changing the (logical) size of what's 
actually being painted.
  
  
  So do I interpret this right when saying that the issue (which is real, 
judging from the screenshots), is "elsewhere" ? meaning "upstream" ? Meaning 
also that fixing it here will break in the future, once the upstream issue is 
found and fixed ?
  
  Most likely the actual issue is in kdecoration2 ...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D12804

To: anemeth, #breeze, #vdg, hpereiradacosta, davidedmundson
Cc: zzag, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12855: Move Widget search field to its own row so it doesn't get compressed

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12855

To: sharvey, ngraham, davidedmundson
Cc: abetts, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12859

To: Zren, #plasma, apol
Cc: abetts, broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D12804: Fix window frame rounding when scaling is used

[David Edmundson]

davidedmundson added a comment.


  > IIRC, decoration renderer sets device pixel ratio, so in theory, you should 
not multiply frame radius by dpr.
  
  For some reason my comment went missing, but as zzag said, with high DPI here 
the only things we should ever change are pixmap sizes and  
QPixmap::setDevicePixelRatio  not changing the (logical) size of what's 
actually being painted.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D12804

To: anemeth, #breeze, #vdg, hpereiradacosta, davidedmundson
Cc: zzag, davidedmundson, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12870: [SourcesModel] Check changed file name before reloading configuration

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R112:c0fa968c08fc: [SourcesModel] Check changed file name 
before reloading configuration (authored by broulik).

REPOSITORY
  R112 Milou

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12870?vs=34127=34142

REVISION DETAIL
  https://phabricator.kde.org/D12870

AFFECTED FILES
  lib/sourcesmodel.cpp
  lib/sourcesmodel.h

To: broulik, #plasma, davidedmundson
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D12870: [SourcesModel] Check changed file name before reloading configuration

[Kai Uwe Broulik]

broulik added a comment.


  `KDirWatch` is a singleton and when this is used from within plasmashell 
(e.g. Kickoff's search model) it will cause changes as `Units` adds watchers on 
plasma configs

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D12870

To: broulik, #plasma
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D12777: Fixed access to current slideshow image using correct field in action_open

[Nathaniel Graham]

ngraham added a comment.


  @odeda, can you provide your email address so that we can land this with 
proper authorship information? Thanks!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12777

To: odeda, #plasma_workspaces, ngraham, broulik
Cc: broulik, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12686: Fix sidebar view regression of not prompting about unsaved changes

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:0aa7fd015b0c: Fix sidebar view regression of not 
prompting about unsaved changes (authored by davidedmundson).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12686?vs=33629=34140

REVISION DETAIL
  https://phabricator.kde.org/D12686

AFFECTED FILES
  sidebar/SidebarMode.cpp
  sidebar/package/contents/ui/CategoriesPage.qml
  sidebar/package/contents/ui/SubCategoryPage.qml

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12794: [weather applet] Improve name & comment metadata

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Ship it! Ship it now! :)
  
  https://www.youtube.com/watch?v=NflTOYuVJ0E

REPOSITORY
  R114 Plasma Addons

BRANCH
  fixweatherappletmetadata

REVISION DETAIL
  https://phabricator.kde.org/D12794

To: kossebau, #plasma, ngraham
Cc: sharvey, jriddell, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon

[Chris Holland]

Zren updated this revision to Diff 34138.
Zren added a comment.


  Remove unrelated brace formatting.
  
  If there's nothing else, I'll merge it this evening.

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12859?vs=34090=34138

REVISION DETAIL
  https://phabricator.kde.org/D12859

AFFECTED FILES
  applets/quickshare/plasmoid/contents/ui/main.qml

To: Zren, #plasma, apol
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12794: [weather applet] Improve name & comment metadata

[Friedrich W . H . Kossebau]

kossebau updated this revision to Diff 34137.
kossebau added a comment.


  pick up proposed wording, thanks for that
  
  Will push this version then CET tonight, unless someone objects
  "shipit"s still welcome as well :)

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12794?vs=33917=34137

BRANCH
  fixweatherappletmetadata

REVISION DETAIL
  https://phabricator.kde.org/D12794

AFFECTED FILES
  applets/weather/package/metadata.desktop

To: kossebau, #plasma
Cc: sharvey, jriddell, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12855: Move Widget search field to its own row so it doesn't get compressed

[Nathaniel Graham]

ngraham added a comment.


  A few more code comments that I missed in the first go-around, sorry. 
Behavior-wise, I think this is a huge improvement!

INLINE COMMENTS

> WidgetExplorer.qml:155
>  }
> +
>  /*

whitespace change :)

> WidgetExplorer.qml:236
> +} else {
> + newSearchRow.height = units.smallSpacing * 5
>  }

Could this be expressed in terms of the search field's actual height? That way 
we wouldn't be vulnerable to height issues if the `units.smallSpacing value` 
changed at some point.

> WidgetExplorer.qml:265
> +
> +height: 0   
> +

Is this needed?

> sharvey wrote in WidgetExplorer.qml:157
> I'm always unclear what to do when I find blocks of other people's comments. 
> Some reviewers absolutely loathe comments being left in; others don't seem to 
> object as much. I've asked for a comment policy to be put together as part of 
> the new-onboarding initiative. I was taught to comment my code for clarity, 
> but not to leave blocks of work-in-progress code like this behind. I 
> hesitated to take it out in case someone was planning on returning to it, but 
> I probably shouldn't have added the graffiti. I'll remove my unnecessary side 
> comment.

In general, KDE policy is to remove code rather than commenting it out. But we 
also try to encourage patches to be as focused as possible. Hence, what I think 
makes sense is to ignore the commented-out block in this patch, and remove it 
entirely in another one.

> ngraham wrote in WidgetExplorer.qml:389
> Unrelated whitespace change

Looks like it's still there? Not a huge deal, but it would be good to figure 
out why your changes keep adding or removing whitespace.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12855

To: sharvey, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12835: Draw borders around side panels by default

[Roman Gilg]

romangg added subscribers: hein, romangg.
romangg added a comment.


  I agree with you @ngraham that the current design is not optimal and is not 
standardized enough in our HIG nor in practical usage by KDE apps and Plasma.
  
  But simply changing the default and by that adding more frames again as 
already said by others here is not the right way forward. I personally like 
@abetts mockups for System Settings in this regard featuring "inverted" colors 
[1]. It's also what other modern UIs currently seem to favor and also what for 
example @hein chose for his Konversation QML rewrite [2]
  
  If we want to go into such a direction in general (i.e. in Breeze, Plasma and 
Apps and above all the HIG) this needs to be discussed in the VDG. It should 
also become part of T7983 . See our comments 
there in regards to the usage of color, light and geometric objects to express 
functionality and/or structure. What I mean by that is: this needs to be 
discussed on a more abstract level being valid for all KDE software with modern 
Ui and a concrete decision then deduced.
  
  [1] M112 
  [2] http://i.imgur.com/7G0rBOL.png

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D12835

To: ngraham, andreaska, hpereiradacosta
Cc: romangg, hein, dhaumann, hpereiradacosta, abetts, rkflx, cfeck, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D12794: [weather applet] Improve name & comment metadata

[Scott Harvey]

sharvey added a comment.


  +1 for "Forecast & Current Conditions" - I think this is what they use on the 
American cable network "The Weather Channel"

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12794

To: kossebau, #plasma
Cc: sharvey, jriddell, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12870: [SourcesModel] Check changed file name before reloading configuration

[Aleix Pol Gonzalez]

apol added a comment.


  It doesn't look like other files are being added to the KDirWatch, no?

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D12870

To: broulik, #plasma
Cc: apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, mart

D12794: [weather applet] Improve name & comment metadata

[Jonathan Riddell]

jriddell added a comment.


  I also like "Forecast and current conditions"

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12794

To: kossebau, #plasma
Cc: jriddell, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12855: Move search field to its own row so it doesn't get compressed

[Scott Harvey]

sharvey updated this revision to Diff 34129.
sharvey added a comment.


  - Remove hardcoded pixel sizes; misc code cleanup

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12855?vs=34083=34129

BRANCH
  new-search-row (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12855

AFFECTED FILES
  desktoppackage/contents/explorer/WidgetExplorer.qml

To: sharvey, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12870: [SourcesModel] Check changed file name before reloading configuration

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Avoid needlessly reloading configuration if something completely unrelated, 
such as plasma appletsrc, changed.

TEST PLAN
  - Disabled a runner, codepath was executed and runner was no longer queried. 
Enabled a runner, it was queried again.
  - No longer needlessly reparses krunnerrc on plasmashell startup

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D12870

AFFECTED FILES
  lib/sourcesmodel.cpp
  lib/sourcesmodel.h

To: broulik, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon

[Aleix Pol Gonzalez]

apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  Looks good to me, please fix the comment Kay mentioned so we can land the 
change.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12859

To: Zren, #plasma, apol
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: minutes meeting week 20

[Bhushan Shah]

On Mon, May 14, 2018 at 04:18:07PM +0530, Bhushan Shah wrote:
> (See logs for more discussion)

and ofcourse logs I forgot to attach, attached now

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D
15:31  alright Sho_ starts
15:31  
15:31  * [PBI] Finished David's browser integration extension 
installation reminder for him, since went on vacation
15:31  * [SysSe] Finished Language KCM port (w/ DND coming in 5.14)
15:31  * [SysSe] Spent Sunday working with my GSoC student on our 
keyboard/input KCM rewrite, very productive day
15:31  ** He's getting set up with a git account and a blog, first blog 
report soonish
15:31  * [FV] Always set applet title even when the label is disabled in 
settings, so FV always gets a nice tab title in the grouping apple
15:31  * [Kicker] Fixed recent regression (by dfaure! :) breaking submenu 
updating when switching between categories of the same size
15:31  * [Kicker] Looking into bug 394202
15:31  KDE bug 394202 in plasmashell (Application Menu (Kicker)) 
"Single letter upper case search hides Application and System Settings 
categories" [normal,] https://bugs.kde.org/show_bug.cgi?id=394202
15:31  * [Plasma] Spent some time butting heads with the 
org.kde.plasma:force-create stuff and wrote bug 394034 about it
15:31  KDE bug 394034 in plasmashell (general) "Convention of passing 
"org.kde.plasma:force-create" as argument to Containment::createApplet is crap" 
[normal,] https://bugs.kde.org/show_bug.cgi?id=394034
15:31  * [Other] Thursday was a holiday
15:31  next()
15:32  kbroulik: your turn
15:32  been sick all week, not much from me :(
15:32  ++meetingIt;
15:32  aww
15:32  notmart: your turn
15:32  ok
15:32   * fixed a bug in the base qml kcm classes that broke the 
language kcm rewrite
15:33   * Continued working primarly on the virtual desktop wayland 
protocol, it's on Phab D12820, now will be review period in which will change a 
lot
15:33  Diff 12820 "Add KWayland virtual desktop protocol" [Needs 
Review] https://phabricator.kde.org/D12820
15:33   ** this week added the plasmawindow part, windows can enter 
and exit desktops
15:33   ** an attempt to make the manager to keep internally coherence 
in the desktop grid. It will probably have to be reworked further. 
15:33   * Kirigami: fixing a bug in the DelegateRecycler, which 
involved a minimal refactoring
15:33   * Kirigami: working on a component to reorder ListViews by 
drag and drop, will be used in the language kcm (post-5.13) 
15:33  questions/next
15:33  romangg: your turn
15:33  * pushed D12739, fix for kdesrc-build
15:33  Diff 12739 "Ignore system standard path when prepending 
environment variables" [Closed] https://phabricator.kde.org/D12739
15:33  * reviewed patches for Martin and notmart
15:34  Still blocked otherwise on my patches for KWin/KWayland through 
missing reviews. There seems to be a problem in general at the moment. Should 
we discuss this now or later?
15:34  (maybe also because d_ed was away last week)
15:35  I think we got review-backlogged because of David/Kai absence, 
notmart digging into VDs (sorely needed), generally people wanting to get back 
to their work after sprint travel
15:35  It's good to note that we need to get back to reviews now, but I 
don't think it's a fundamental problem just yet
15:35  yeah, will review more stuff this week
15:35  same
15:35  except.. forgot one thing, tomorrow i'll be away :)
15:36  I actually have a half day off tmrw too, wedding suit fitting
15:36  but apart from that.. yeah
15:36  Well, I see the "fundamental" problem in KWin/KWayland more in 
the sense that often it's dependent on Martin, who can't be so active anymore 
than in the past.
15:36  (scared of post-sprint fatness ...)
15:36  romangg: Not sure,  Igot the EGL context priority patch in without 
him ever looking at it
15:36  There's precedent for this now, we can do stuff ourselves
15:36  In fact he explicitly said we'll have to because he has a kid on 
the way
15:36  So the lesson is
15:37  Don't wait for Martin to review things: Review things
15:37  Sho_: Ok, but on some reviews he is also really needed.
15:37  Sho_: sure you'll look like a male catwalk model :p
15:37  notmart: With the price of this suit, I better ...
15:37  (maybe I should but a corset)
15:37  *buy
15:38  Sho_: so how did your fitting go?
15:38  Ok, then we agree that we don't always wait on Martin to review 
and push. Only if we are sure it needs review by Martin write a mail to the 
mailing list for example.
15:39  kbroulik: nono, it's tomorrow
15:39  Of course this could sometimes mean that we push something 
which is wrong and would have been spottet by Martin who knows most about 
KWin/KWayland. But we need to risk this then.
15:39  romangg: we need to, because the only way to build up the skills 
we need to be less dependent on Martin is to do work and learn by doing
15:40  Martin's review skills don't come out of a 

minutes meeting week 20

[Bhushan Shah]

Hello,

Attached are notes from meeting week 20:

* kbroulik and bshah were sick and execused from meeting

Present:

bshah, kbroulik, Sho_, notmart, romangg, Riddell

Sho_:

 * [PBI] Finished David's browser integration extension installation reminder 
for him, since went on vacation
 * [SysSe] Finished Language KCM port (w/ DND coming in 5.14)
 * [SysSe] Spent Sunday working with my GSoC student on our keyboard/input KCM 
rewrite, very productive day
 ** He's getting set up with a git account and a blog, first blog report soonish
 * [FV] Always set applet title even when the label is disabled in settings, so 
FV always gets a nice tab title in the grouping apple
 * [Kicker] Fixed recent regression (by dfaure! :) breaking submenu updating 
when switching between categories of the same size
 * [Kicker] Looking into bug 394202
 * [Plasma] Spent some time butting heads with the org.kde.plasma:force-create 
stuff and wrote bug 394034 about it
 * [Other] Thursday was a holiday


notmart:

 * fixed a bug in the base qml kcm classes that broke the language kcm rewrite
 * Continued working primarly on the virtual desktop wayland protocol, it's on 
Phab D12820, now will be review period in which will change a lot
 * Diff 12820 "Add KWayland virtual desktop protocol" [Needs Review] 
https://phabricator.kde.org/D12820
 ** this week added the plasmawindow part, windows can enter and exit desktops
 ** an attempt to make the manager to keep internally coherence in the desktop 
grid. It will probably have to be reworked further. 
 * Kirigami: fixing a bug in the DelegateRecycler, which involved a minimal 
refactoring
 * Kirigami: working on a component to reorder ListViews by drag and drop, will 
be used in the language kcm (post-5.13) 

romangg:

 * pushed D12739, fix for kdesrc-build
 * Diff 12739 "Ignore system standard path when prepending environment 
variables" [Closed] https://phabricator.kde.org/D12739
 * reviewed patches for Martin and notmart
 * Still blocked otherwise on my patches for KWin/KWayland through missing 
reviews. There seems to be a problem in general at the moment. Should we 
discuss this now or later?

Riddell:

 * Plasma 5.13 beta on Thursday! announcement being written today! Get your 
features in pronto!
 * although I will be looking out for bug 394134


Also some notes about blocked reviews:

- Roman brought up this topic
- Mostly reason we believe for long review queue is because of Kai, David being 
off in last week, Marco focusing on virtual desktop work last week
- We also agreed upon learning more about kwin/kwayland to reduce bus factor

(See logs for more discussion)

Thanks

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D

D12102: Port Language KCM to Qt Quick

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6055cfb94e1e: Port Language KCM to Qt Quick (authored by 
hein).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12102?vs=34121=34123

REVISION DETAIL
  https://phabricator.kde.org/D12102

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/translations/CMakeLists.txt
  kcms/translations/Messages.sh
  kcms/translations/kcm_translations.desktop
  kcms/translations/kcmtranslations.cpp
  kcms/translations/kcmtranslations.h
  kcms/translations/kcmtranslationswidget.ui
  kcms/translations/package/contents/ui/main.qml
  kcms/translations/package/metadata.desktop
  kcms/translations/translations.cpp
  kcms/translations/translations.desktop
  kcms/translations/translations.h
  kcms/translations/translationsmodel.cpp
  kcms/translations/translationsmodel.h

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein updated this revision to Diff 34121.
hein added a comment.


  Move removal into the C++ model code to avoid another model reset
  and speed up the UX.
  
  Please re-review now for 5.13 inclusion.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12102?vs=34120=34121

BRANCH
  arcpatch-D12102_1

REVISION DETAIL
  https://phabricator.kde.org/D12102

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/translations/CMakeLists.txt
  kcms/translations/Messages.sh
  kcms/translations/kcm_translations.desktop
  kcms/translations/kcmtranslations.cpp
  kcms/translations/kcmtranslations.h
  kcms/translations/kcmtranslationswidget.ui
  kcms/translations/package/contents/ui/main.qml
  kcms/translations/package/metadata.desktop
  kcms/translations/translations.cpp
  kcms/translations/translations.desktop
  kcms/translations/translations.h
  kcms/translations/translationsmodel.cpp
  kcms/translations/translationsmodel.h

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12102: Port Language KCM to Qt Quick

[Eike Hein]

hein updated this revision to Diff 34120.
hein added a comment.


  Add back Move up/down actions.
  
  DND won't be ready in Kirigami for 5.13, but as this port fixes
  critical bugs vs. the old version - such as not actually saving
  settings ... - we still want this in 5.13.
  
  To prepare for DND, the model now has a method to do the moves.
  Previously these were implemented by manipulating the list in
  JS and setting it as a whole in the prop, which caused a
  costly model reset. This is much smoother in the view.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12102?vs=34053=34120

BRANCH
  arcpatch-D12102_1

REVISION DETAIL
  https://phabricator.kde.org/D12102

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/translations/CMakeLists.txt
  kcms/translations/Messages.sh
  kcms/translations/kcm_translations.desktop
  kcms/translations/kcmtranslations.cpp
  kcms/translations/kcmtranslations.h
  kcms/translations/kcmtranslationswidget.ui
  kcms/translations/package/contents/ui/main.qml
  kcms/translations/package/metadata.desktop
  kcms/translations/translations.cpp
  kcms/translations/translations.desktop
  kcms/translations/translations.h
  kcms/translations/translationsmodel.cpp
  kcms/translations/translationsmodel.h

To: hein, #kirigami, mart
Cc: rkflx, aspotashev, davidedmundson, safaalfulaij, abetts, ngraham, 
plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart, hein

D12855: Move search field to its own row so it doesn't get compressed

[Scott Harvey]

sharvey added inline comments.

INLINE COMMENTS

> ngraham wrote in WidgetExplorer.qml:157
> ? Not sure The extra comment adds anything. Instead we should just remove the 
> commented-out code in a new patch IMHO.

I'm always unclear what to do when I find blocks of other people's comments. 
Some reviewers absolutely loathe comments being left in; others don't seem to 
object as much. I've asked for a comment policy to be put together as part of 
the new-onboarding initiative. I was taught to comment my code for clarity, but 
not to leave blocks of work-in-progress code like this behind. I hesitated to 
take it out in case someone was planning on returning to it, but I probably 
shouldn't have added the graffiti. I'll remove my unnecessary side comment.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12855

To: sharvey, ngraham, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12849: Improve layout of fonts kcm

[Henrik Fehlauer]

rkflx added a comment.


  The checkboxes wildly floating around on the left look a bit weird to me. How 
about this (I guess your original intention was to avoid having checkboxes 
under the wrong text label?):
  
Anti-Aliasing: Enabled
   [ ] Exclude range from 8pt to 15pt
(…)
Fonts DPI: [ ] Force to 96 dpi
  
  
  
  ---
  
  A more general comment: Compared to the state before the redesign, the dialog 
now looks like two separate KCMs slapped together, as can be seen by the need 
to include two title headers and the separating line. Also, the settings on the 
top are easily understandable by any word processor user, while the terminology 
on the bottom requires more expert knowledge.
  
  It might be worth thinking about a different way to group both sections. I'm 
not suggesting going back to the modal dialog, but maybe group boxes, two tabs, 
or a `KCollapsibleGroupBox` would be better?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fonts_kcm_layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12849

To: progwolff, mart, abetts, ngraham
Cc: rkflx, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12822: Added null check in OverlayDrawer

[Marco Martin]

mart added a comment.


  ok this can be abandoned then

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12822

To: Dax
Cc: mart, apol, plasma-devel, davidedmundson, hein

D12823: Workaround for binding loop in Material Theme

[Marco Martin]

mart added a comment.


  this would break the binding loop, and things should be able to dynamically 
change color, so the proper cause should be found

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12823

To: Dax
Cc: mart, apol, plasma-devel, davidedmundson, hein

D12849: Improve layout of fonts kcm

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  for me, good to go

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fonts_kcm_layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D12849

To: progwolff, mart, abetts, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12849: Improve layout of fonts kcm

[Marco Martin]

mart added a comment.


  In D12849#262026 , @progwolff 
wrote:
  
  > In D12849#261837 , @ngraham 
wrote:
  >
  > > We might want to take the opportunity to also center-align the titles, 
which it better-looking for these centered formlayout style UIs.
  >
  >
  > Section titles in form layouts are left-aligned. This would have to be 
changed in Kirigami. @mart, am I right?
  
  
  yep. personally i think left aligned is a bit better (as the fields are not 
exactly center aligned, butas left as the labels allow, as per HIG)
  
  > In D12849#261837 , @ngraham 
wrote:
  > 
  >> And maybe use a bit of extra vertical padding instead of that 
horizontalline separator?
  > 
  > 
  > F5847526: Screenshot_fonts_layout_noseperator.png 

  > 
  > To me it looks cleaner with the seperator.
  
  i agree, i prefer the separator as well

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12849

To: progwolff, mart, abetts, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12849: Improve layout of fonts kcm

[Marco Martin]

mart added a comment.


  In D12849#261837 , @ngraham wrote:
  
  > Alignment looks great to me! We might want to take the opportunity to also 
center-align the titles, which it better-looking for these centered formlayout 
style UIs. And maybe use a bit of extra vertical padding instead of that 
horizontalline separator?
  
  
  this is kirigami specific, can't be done here

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12849

To: progwolff, mart, abetts, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12698: Show SNI to install browser-side extension

[Eike Hein]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:2723ef0c80a6: WIP: Show SNI to install browser-side 
extension (authored by davidedmundson, committed by hein).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12698?vs=34112=34113

REVISION DETAIL
  https://phabricator.kde.org/D12698

AFFECTED FILES
  CMakeLists.txt
  reminder/CMakeLists.txt
  reminder/browserintegrationreminder.cpp
  reminder/browserintegrationreminder.desktop
  reminder/browserintegrationreminder.h

To: hein, davidedmundson, apol, mart, #plasma, broulik
Cc: broulik, alexeymin, zzag, hein, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12698: Show SNI to install browser-side extension

[Eike Hein]

hein updated this revision to Diff 34112.
hein added a comment.


  Switch icon

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12698?vs=33976=34112

BRANCH
  arcpatch-D12698

REVISION DETAIL
  https://phabricator.kde.org/D12698

AFFECTED FILES
  CMakeLists.txt
  reminder/CMakeLists.txt
  reminder/browserintegrationreminder.cpp
  reminder/browserintegrationreminder.desktop
  reminder/browserintegrationreminder.h

To: hein, davidedmundson, apol, mart, #plasma, broulik
Cc: broulik, alexeymin, zzag, hein, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D7087: Add "Copy Info" button to the About System KCM

[gregormi]

gregormi updated this revision to Diff 34111.
gregormi added a comment.


  - Apply comments by reviewers:
- move declaration near to usage
- Reuse label texts
  
  - Rename label to more speaking name

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D7087?vs=26765=34111

BRANCH
  arcpatch-D7087_1

REVISION DETAIL
  https://phabricator.kde.org/D7087

AFFECTED FILES
  Modules/about-distro/src/Module.cpp
  Modules/about-distro/src/Module.h
  Modules/about-distro/src/Module.ui

To: gregormi, ngraham, dhaumann
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, 
mart

D12698: Show SNI to install browser-side extension

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.


  Thanks a lot!

INLINE COMMENTS

> browserintegrationreminder.cpp:133
> +m_sni->setTitle(i18n("Get Plasma Browser Integration"));
> +m_sni->setIconByName("internet-web-browser");
> +m_sni->setStandardActionsEnabled(false);

There's a `plasma-browser-integration` icon in breeze-icons now

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  arcpatch-D12698

REVISION DETAIL
  https://phabricator.kde.org/D12698

To: hein, davidedmundson, apol, mart, #plasma, broulik
Cc: broulik, alexeymin, zzag, hein, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12849: Improve layout of fonts kcm

[Julian Wolff]

progwolff added a comment.


  In D12849#261837 , @ngraham wrote:
  
  > We might want to take the opportunity to also center-align the titles, 
which it better-looking for these centered formlayout style UIs.
  
  
  Section titles in form layouts are left-aligned. This would have to be 
changed in Kirigami. @mart, am I right?
  
  In D12849#261837 , @ngraham wrote:
  
  > And maybe use a bit of extra vertical padding instead of that 
horizontalline separator?
  
  
  F5847526: Screenshot_fonts_layout_noseperator.png 

  
  To me it looks cleaner with the seperator.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12849

To: progwolff, mart, abetts, ngraham
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12775: Always set applet title, even when label is disabled

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> FolderViewLayer.qml:85
> +property: "title"
> +value: labelGenerator.displayLabel
> +}

> Except when we're a containment.

Isn't a `when: !isContainment` nicer, then? (Just asking, no need to change it)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12775

To: hein, #plasma, mart
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12777: Fixed access to current slideshow image using correct field in action_open

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.


  Works fine. Thanks!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12777

To: odeda, #plasma_workspaces, ngraham, broulik
Cc: broulik, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12859: [QuickShare] Respect units.iconSizeHints.panel for panel icon

[Kai Uwe Broulik]

broulik added a comment.


  +1

INLINE COMMENTS

> main.qml:65
>  
> -function urlsMimetype(urls)
> -{
> +function urlsMimetype(urls) {
>  return mimeDb.mimeTypeForUrl(urls[0]);

Unrelated change

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12859

To: Zren
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart