[Breeze] [Bug 394459] New: "Invalid escape sequences in line" error in system log

2018-05-19 Thread ๆž—ๅšไป 
https://bugs.kde.org/show_bug.cgi?id=394459

Bug ID: 394459
   Summary: "Invalid escape sequences in line" error in system log
   Product: Breeze
   Version: 5.12.5
  Platform: Neon Packages
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: Plymouth
  Assignee: plasma-devel@kde.org
  Reporter: buo.ren@gmail.com
CC: sit...@kde.org
  Target Milestone: ---

I found the following error generated in the system log:

```
systemd[1]: [/lib/systemd/system/casper-stop-breeze-plymouth.service:16]
Invalid escape sequences in line, correcting: "-/bin/sh -c "find
/etc/fonts/conf.d/*-neon-* -exec cat {} \; > /dev/null""
```

That's all.

-- 
You are receiving this mail because:
You are the assignee for the bug.

D12974: Workspace KCM Code Improvement

2018-05-19 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> workspaceoptions.cpp:51
>  
> -/*ConfigModule functions*/
> +// ***ConfigModule functions
>  void KCMWorkspaceOptions::load()

Why all the asterisks?

> workspaceoptions.h:58
>  // QML variables
> -bool m_ostateToolTip;   // Original state
> -bool m_stateToolTip;// Current state
> +bool m_toolTipOriginalState;   // Original state
> +bool m_toolTipCurrentState;// Current state

The inline comments are no longer needed now that the variable name is 
self-documenting.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12974

To: furkantokac, ngraham, romangg, #plasma
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12973: Workspace KCM Redesign Using Kirigami

2018-05-19 Thread Furkan Tokac 
furkantokac updated this revision to Diff 34500.
furkantokac added a comment.


  Comment correction.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12973?vs=34459=34500

BRANCH
  kcmworkspace-Redesign

REVISION DETAIL
  https://phabricator.kde.org/D12973

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12974: Workspace KCM Code Improvement

2018-05-19 Thread Furkan Tokac 
furkantokac marked 3 inline comments as done.
furkantokac added inline comments.

INLINE COMMENTS

> zzag wrote in workspaceoptions.cpp:37
> I think you could do something like this in the header file
> 
>   class ...  {
>   ...
>   m_stateToolTip = true;
>   m_stateVisualFeedback = true;
>   m_stateSingleClick = true;
>   ...
>   };

This one is more clear imho because they are not optional initializations, they 
are must so we emphasize that.

> zzag wrote in workspaceoptions.cpp:180
> I would remove it. It doesn't add any useful information. I don't see any 
> word about commets in the kdelibs coding style(I assume Plasma follows it) 
> but as a rule of thumb: comment things that are not obvious.
> 
> For example, see 
> https://google.github.io/styleguide/cppguide.html#Implementation_Comments

Actually this is optional. Not a big issue. Makes it easier to follow. 
Specifically for this patch, it's okay imho.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12974

To: furkantokac, ngraham, romangg, #plasma
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12974: Workspace KCM Code Improvement

2018-05-19 Thread Furkan Tokac 
furkantokac updated this revision to Diff 34499.
furkantokac added a comment.


  State variable names are changed. Some formatting improvements.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12974?vs=34458=34499

BRANCH
  kcmworkspace-CodeFormatting

REVISION DETAIL
  https://phabricator.kde.org/D12974

AFFECTED FILES
  kcms/workspaceoptions/workspaceoptions.cpp
  kcms/workspaceoptions/workspaceoptions.h

To: furkantokac, ngraham, romangg, #plasma
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12974: Workspace KCM Code Improvement

2018-05-19 Thread Nathaniel Graham 
ngraham added a comment.


  In D12974#264991 , @furkantokac 
wrote:
  
  > In D12974#264920 , @ngraham 
wrote:
  >
  > > While we're doing some formatting and style cleanup work, how about 
renaming some variables? For example `m_ostateToolTip` and 
`m_ostateVisualFeedback` aren't very descriptive IMHO. Maybe instead, they 
could be `m_currentToolTipState` and `m_currentVisualFeedbackState`.
  >
  >
  > So they'll be changed as
  >  m_toolTipCurrentState m_toolTipOriginalState etc.
  
  
  Yep, sounds good!

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12974

To: furkantokac, ngraham, romangg, #plasma
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12982: Make the new KCMs with QtQuick translatable

2018-05-19 Thread Luigi Toscano 
ltoscano added a comment.


  I expect the plasma developer to be able to help with fixing this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12982

To: yurchor, #plasma, kde-i18n-doc, ltoscano
Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12982: Make the new KCMs with QtQuick translatable

2018-05-19 Thread Yuri Chornoivan 
yurchor added a comment.


  In D12982#265059 , @ltoscano wrote:
  
  > I don't want to go back from kcm5_workspace to kcm_workspace. Any solution 
should allow to define a specific name for the KCMs.
  
  
  This will probably need some refactoring inside and renaming several .json 
files outside. I have no competence to do it right without testing and have no 
testing capabilities until the next week. Is it necessary?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12982

To: yurchor, #plasma, kde-i18n-doc, ltoscano
Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12982: Make the new KCMs with QtQuick translatable

2018-05-19 Thread Luigi Toscano 
ltoscano requested changes to this revision.
ltoscano added a comment.
This revision now requires changes to proceed.


  I don't want to go back from kcm5_workspace to kcm_workspace. Any solution 
should allow to define a specific name for the KCMs.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12982

To: yurchor, #plasma, kde-i18n-doc, ltoscano
Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12982: Make the new KCMs with QtQuick translatable

2018-05-19 Thread Yuri Chornoivan 
yurchor created this revision.
yurchor added reviewers: Plasma, kde-i18n-doc.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
yurchor requested review of this revision.

REVISION SUMMARY
  According to this comment:
  
  https://marc.info/?l=kde-i18n-doc=152672268226040=2
  
  TRANSLATION_DOMAIN in CMakeLists.tx is not enough to make QML code 
translatable.
  
  This can be easily tested using Neon:
  
  https://files.kde.org/neon/images/neon-devedition-gitunstable/current/
  
  This revision is trying to mitigate this issue with minimal changes in the 
code.

TEST PLAN
  1. Run Neon with some ~100% translation package (sv or uk).
  
  2. Rename translation catalogs as follows:
  
  kcmlaunchfeedback -> kcm_launchfeedback
  kcmtranslations -> kcm_translations
  kcm5_workspace -> kcm_workspace
  
  3. Test if icons, launchfeedback, translations, and workspaceoptions modules 
are translated.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12982

AFFECTED FILES
  kcms/icons/main.cpp
  kcms/launch/CMakeLists.txt
  kcms/launch/Messages.sh
  kcms/translations/CMakeLists.txt
  kcms/translations/Messages.sh
  kcms/workspaceoptions/CMakeLists.txt
  kcms/workspaceoptions/Messages.sh

To: yurchor, #plasma, kde-i18n-doc
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12960: Drag handle to reorder items in a ListView

2018-05-19 Thread Alessandro Longo 
alex-l added a comment.


  Possible interactions on hover (I used the third one and the fourth one when 
dragging):
  
  F5858223: immagine.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12960

To: mart, #kirigami, #vdg, hein
Cc: alex-l, abetts, rkflx, ngraham, zzag, plasma-devel, apol, davidedmundson, 
mart, hein

D12960: Drag handle to reorder items in a ListView

2018-05-19 Thread Alessandro Longo 
alex-l added a comment.


  I tried with arrows too, but I think the fifth one looks better... my second 
choice is the third one.
  
  F5858203: immagine.png 

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12960

To: mart, #kirigami, #vdg, hein
Cc: alex-l, abetts, rkflx, ngraham, zzag, plasma-devel, apol, davidedmundson, 
mart, hein

D12974: Workspace KCM Code Improvement

2018-05-19 Thread Vlad Zagorodniy 
zzag added a comment.


  Also, about coding style. Why are you using `/*` for one line comments?

INLINE COMMENTS

> workspaceoptions.cpp:29
>  #include 
>  #include 
>  

https://community.kde.org/Policies/Kdelibs_Coding_Style#Qt_Includes

> workspaceoptions.cpp:37
>m_stateVisualFeedback(true),
>m_stateSingleClick(true)
>  {

I think you could do something like this in the header file

  class ...  {
  ...
  m_stateToolTip = true;
  m_stateVisualFeedback = true;
  m_stateSingleClick = true;
  ...
  };

> workspaceoptions.cpp:180
>  
>  /*SingleClick functions*/
>  bool KCMWorkspaceOptions::getSingleClick() const

I would remove it. It doesn't add any useful information. I don't see any word 
about commets in the kdelibs coding style(I assume Plasma follows it) but as a 
rule of thumb: comment things that are not obvious.

For example, see 
https://google.github.io/styleguide/cppguide.html#Implementation_Comments

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12974

To: furkantokac, ngraham, romangg, #plasma
Cc: zzag, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12974: Workspace KCM Code Improvement

2018-05-19 Thread Furkan Tokac 
furkantokac added a comment.


  In D12974#264920 , @ngraham wrote:
  
  > While we're doing some formatting and style cleanup work, how about 
renaming some variables? For example `m_ostateToolTip` and 
`m_ostateVisualFeedback` aren't very descriptive IMHO. Maybe instead, they 
could be `m_currentToolTipState` and `m_currentVisualFeedbackState`.
  
  
  So they'll be changed as
  m_toolTipCurrentState m_toolTipOriginalState etc.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12974

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12974: Workspace KCM Code Improvement

2018-05-19 Thread Vlad Zagorodniy 
zzag removed a reviewer: zzag.
zzag added a comment.


  Thanks, but I'm not a member of #Plasma 
. ;-)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12974

To: furkantokac, ngraham, romangg, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma kwin stable-kf5-qt5 SUSEQt5.10 - Build # 9 - Still unstable!

2018-05-19 Thread CI System 
BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20kwin%20stable-kf5-qt5%20SUSEQt5.10/9/
 Project:
Plasma kwin stable-kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 19 May 2018 07:02:13 +
 Build duration:
37 min and counting
   JUnit Tests
  Name: (root) Failed: 6 test(s), Passed: 118 test(s), Skipped: 0 test(s), Total: 124 test(s)Failed: TestSuite.kwin-testDontCrashAuroraeDestroyDecoFailed: TestSuite.kwin-testFadeFailed: TestSuite.kwin-testScriptedEffectLoaderFailed: TestSuite.kwin-testSlidingPopupsFailed: TestSuite.kwin-testTranslucencyFailed: TestSuite.kwin-testXClipboardSync
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report71%
(65/92)61%
(430/702)61%
(430/702)51%
(45762/88920)34%
(23626/68563)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault86%
(132/154)86%
(132/154)62%
(17898/28710)46%
(9647/21151)autotests97%
(33/34)97%
(33/34)94%
(4509/4786)51%
(2180/4304)autotests.drm100%
(2/2)100%
(2/2)96%
(103/107)57%
(34/60)autotests.integration98%
(54/55)98%
(54/55)98%
(10417/10667)45%
(6481/14305)autotests.integration.effects80%
(4/5)80%
(4/5)66%
(375/572)30%
(280/938)autotests.integration.helper0%
(0/3)0%
(0/3)0%
(0/42)0%
(0/2)autotests.integration.scripting100%
(1/1)100%
(1/1)100%
(162/162)48%
(95/198)autotests.libinput100%
(11/11)100%
(11/11)98%
(2345/2385)57%
(1016/1798)autotests.libkwineffects100%
(4/4)100%
(4/4)98%
(357/363)57%
(175/308)autotests.libxrenderutils100%
(1/1)100%
(1/1)100%
(13/13)100%
(0/0)autotests.tabbox100%
(9/9)100%
(9/9)88%
(342/388)54%
(138/256)colorcorrection100%
(6/6)100%
(6/6)81%
(434/536)59%
(201/342)data0%
(0/1)0%
(0/1)0%
(0/29)0%
(0/12)decorations100%
(11/11)100%
(11/11)76%
(395/517)62%
(143/232)effects100%
(3/3)100%
(3/3)98%
(164/168)82%
(23/28)effects.backgroundcontrast25%
(1/4)25%
(1/4)4%
(15/352)5%
(14/258)effects.blur20%
(1/5)20%

KDE CI: Plasma kwin stable-kf5-qt5 SUSEQt5.10 - Build # 8 - Failure!

2018-05-19 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwin%20stable-kf5-qt5%20SUSEQt5.10/8/
 Project:
Plasma kwin stable-kf5-qt5 SUSEQt5.10
 Date of build:
Sat, 19 May 2018 06:07:45 +
 Build duration:
31 min and counting
   CONSOLE OUTPUT
  [...truncated 917.11 KB...][ 61%] Automatic MOC for target KWinWaylandVirtualBackend[ 61%] Built target KWinWaylandVirtualBackend_autogenScanning dependencies of target KWinWaylandWaylandBackend_autogen[ 61%] Automatic MOC for target KWinWaylandWaylandBackend[ 61%] Built target KWinWaylandWaylandBackend_autogenScanning dependencies of target eglx11common_autogen[ 61%] Automatic MOC for target eglx11common[ 61%] Built target eglx11common_autogenScanning dependencies of target KWinSceneOpenGL_autogen[ 61%] Automatic MOC for target KWinSceneOpenGL[ 61%] Built target KWinSceneOpenGL_autogenScanning dependencies of target KWinSceneQPainter_autogen[ 61%] Automatic MOC for target KWinSceneQPainter[ 61%] Built target KWinSceneQPainter_autogenScanning dependencies of target KWinSceneXRender_autogen[ 61%] Automatic MOC for target KWinSceneXRender[ 61%] Built target KWinSceneXRender_autogenScanning dependencies of target testX11TimestampUpdate_autogen[ 61%] Automatic MOC for target testX11TimestampUpdate[ 61%] Built target testX11TimestampUpdate_autogenScanning dependencies of target KWinIntegrationTestFramework_autogen[ 61%] Automatic MOC for target KWinIntegrationTestFramework[ 61%] Built target KWinIntegrationTestFramework_autogenScanning dependencies of target KF5GlobalAccelPrivateKWin[ 61%] Building CXX object plugins/kglobalaccel/CMakeFiles/KF5GlobalAccelPrivateKWin.dir/kglobalaccel_plugin.cpp.o[ 61%] Building CXX object plugins/kglobalaccel/CMakeFiles/KF5GlobalAccelPrivateKWin.dir/KF5GlobalAccelPrivateKWin_autogen/mocs_compilation.cpp.o[ 61%] Linking CXX shared module ../../bin/org.kde.kglobalaccel5.platforms/KF5GlobalAccelPrivateKWin.so[ 61%] Built target KF5GlobalAccelPrivateKWinScanning dependencies of target KWinQpaPlugin[ 61%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/abstractplatformcontext.cpp.o[ 61%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/backingstore.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/integration.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/main.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/nativeinterface.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/platformcontextwayland.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/platformcursor.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/screen.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/sharingplatformcontext.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/window.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/logging.cpp.o[ 62%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/KWinQpaPlugin_autogen/mocs_compilation.cpp.o[ 62%] Linking CXX shared module ../../bin/KWinQpaPlugin.so[ 62%] Built target KWinQpaPluginScanning dependencies of target KF5IdleTimeKWinWaylandPrivatePlugin[ 62%] Building CXX object plugins/idletime/CMakeFiles/KF5IdleTimeKWinWaylandPrivatePlugin.dir/poller.cpp.o[ 62%] Building CXX object plugins/idletime/CMakeFiles/KF5IdleTimeKWinWaylandPrivatePlugin.dir/KF5IdleTimeKWinWaylandPrivatePlugin_autogen/mocs_compilation.cpp.o[ 62%] Linking CXX shared module ../../bin/KF5IdleTimeKWinWaylandPrivatePlugin.so[ 62%] Built target KF5IdleTimeKWinWaylandPrivatePluginScanning dependencies of target KWinWaylandDrmBackend[ 62%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_backend.cpp.o[ 62%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_object.cpp.o[ 62%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_object_connector.cpp.o[ 62%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_object_crtc.cpp.o[ 62%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_object_plane.cpp.o[ 62%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_output.cpp.o[ 63%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_buffer.cpp.o[ 63%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_inputeventfilter.cpp.o[ 63%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/logging.cpp.o[ 63%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/scene_qpainter_drm_backend.cpp.o[ 63%] Building CXX object plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/screens_drm.cpp.o[ 63%] Building CXX object