D11746: Assign notification area category

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D11746

To: wsdfhjxc, #plasma, broulik
Cc: Pitel, plasma-devel, ragreen, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12534: [timer applet] Fix internal function calls

[Albert Astals Cid]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:557a4d2de724: [timer applet] Fix internal function calls 
(authored by mmazur, committed by aacid).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12534?vs=33130=34553

REVISION DETAIL
  https://phabricator.kde.org/D12534

AFFECTED FILES
  applets/timer/package/contents/ui/TimerDigit.qml

To: mmazur, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12533: [timer applet] Unify QtQuick imports

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12533

To: mmazur, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12821: Added missing files in QMake's .pri

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D12821

To: Dax, mart
Cc: plasma-devel, apol, davidedmundson, mart, hein

D12853: Calendar widget: fix resize

[Albert Astals Cid]

aacid closed this revision.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D12853

To: miklosm, #plasma, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12969: [Kicker] Only show "Add to Panel (Widget)" When there's no Task Manager

[David Edmundson]

davidedmundson resigned from this revision.
davidedmundson added inline comments.

INLINE COMMENTS

> ngraham wrote in actionlist.cpp:156
> This patch worked just for me all by itself, so I wasn't aware this required 
> a plasma-framework change (I just moved the conditional around a bit, 
> basically). Did I miss something?

My bad.

Kicker had a class ContainmentInterface which was different from the 
containmentinterface is p-f. I knew the one in p-f didn't have the method, and 
got confused.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12969

To: ngraham, #plasma
Cc: davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D13006: Move the inline installer progress cancel button to the left side

[Andreas Kainz]

andreaska added a comment.


  Thanks +1

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D13006

To: ngraham, apol, #discover_software_store
Cc: andreaska, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13006: Move the inline installer progress cancel button to the left side

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: apol, Discover Software Store.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This prevents the progress view from jumping around, and keeps it 
right-aligned just like the button it replaces

REPOSITORY
  R134 Discover Software Store

BRANCH
  cancel-button-on-the-left (branched from Plasma/5.13)

REVISION DETAIL
  https://phabricator.kde.org/D13006

AFFECTED FILES
  discover/qml/InstallApplicationButton.qml

To: ngraham, apol, #discover_software_store
Cc: andreaska, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Plasma Vaults by Default

[Ivan Čukić]

Hi Jonathan,

One possibility is to hide the icon if the user does not use Vaults (if the
user has no vaults configured) similar to how the pager applet behaves.

Cheers,
Ivan


-- 
KDE, ivan.cu...@kde.org, http://cukic.co/
gpg key fingerprint: 292F 9B5C 5A1B 2A2F 9CF3  45DF C9C5 77AF 0A37 240A

D12996: Register players when tab becomes audible

[Fabian Vogt]

fvogt added a comment.


  Fixed: https://phabricator.kde.org/D13001

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D12996

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D13001: Handle children of added nodes as well

[Fabian Vogt]

fvogt created this revision.
fvogt added reviewers: Plasma, broulik, davidedmundson.
Restricted Application added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  Element trees can be added as well, but without this, only the root element 
was
  handled.

TEST PLAN
  Videos on twitter get registered now.

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  Plasma/5.13

REVISION DETAIL
  https://phabricator.kde.org/D13001

AFFECTED FILES
  extension/content-script.js

To: fvogt, #plasma, broulik, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12999: Fix always empty memory bar

[Antonio Rojas]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:f54bcde16302: Fix always empty memory bar (authored by 
arojas).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D12999?vs=34521=34529

REVISION DETAIL
  https://phabricator.kde.org/D12999

AFFECTED FILES
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml

To: arojas, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D7038: [server] Respect input region of sub-surfaces on pointer surface focus

[Martin Flöser]

graesslin added a comment.
Restricted Application added a subscriber: kde-frameworks-devel.


  any update on this?

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D7038

To: romangg, #frameworks, graesslin
Cc: kde-frameworks-devel, graesslin, plasma-devel, ragreen, Pitel, schernikov, 
michaelh, ZrenBot, ngraham, bruns, alexeymin, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

D12999: Fix always empty memory bar

[Antonio Rojas]

arojas created this revision.
arojas added a reviewer: davidedmundson.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  Add back the memoryUsageProportionsChanged() call that was removed in 
6e753e6653ace887daceea2d05cf35661a7d0422 


TEST PLAN
  Memory bar shows actual memory usage instead of being empty

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D12999

AFFECTED FILES
  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml

To: arojas, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12996: Register players when tab becomes audible

[Fabian Vogt]

fvogt added a comment.


  > I don't fully understand why neither createElement nor the mutation 
observer detect it, though.
  
  IMO that should be debugged a bit further before landing this, as it's AFACIT 
only a hack.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D12996

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12997: Add new api to support window tabs

[Martin Flöser]

graesslin created this revision.
graesslin added reviewers: KWin, Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
graesslin requested review of this revision.

REVISION SUMMARY
  The new API basically just provides a vector of DecoratedClient
  referring to the window tabs. This was the idea on how to implement
  window tabs I had back when starting the implementation of KDecoration2.
  There are a few more requests to close a specific tab and to activate a
  tab.
  
  On the private side a new subclass is added, which KWin can implement to
  provide window tab support.

TEST PLAN
  Early review and KWin doesn't use the new API yet, so completely
  untested. Will not merge prior to using the API in KWin.

REPOSITORY
  R129 Window Decoration Library

BRANCH
  window-tab-api

REVISION DETAIL
  https://phabricator.kde.org/D12997

AFFECTED FILES
  src/decoration.cpp
  src/decoration.h
  src/private/decoratedclientprivate.cpp
  src/private/decoratedclientprivate.h

To: graesslin, #kwin, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12990: update mouse kcm docbook to 5.13

[Luigi Toscano]

ltoscano added a comment.


  Maybe we need a basic document for the other KCM too; a small note here could 
be useful anyway.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12990

To: lueck, #plasma, #documentation
Cc: ltoscano, plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12990: update mouse kcm docbook to 5.13

[Burkhard Lück]

lueck added a comment.


  does it make sense to add a hint, that single-/double-click setting moved to 
workspaceoption kcm?
  workspaceoption kcm has no docbook, therefore you can not find where this 
setting is in plasma >5.12
  using search in khelpcenter or on docs.kde.org, but this search was 
successfull with plasma <= 5.12

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12990

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12996: Register players when tab becomes audible

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, davidedmundson, fvogt.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  When a tab becomes audible (ie. the playing sound icon shows up), register 
all players on the site.
  This ensures dynamically created players that weren't registred by our DOM 
mutation observer are also handled.

TEST PLAN
  Opened a twitter video, I clicked on it so it started playing with sound, now 
I can control it. Previously it would not detect it.
  
  Could also cause unintended side-effects if another tab starts playing sound 
suddenly?
  
  I don't fully understand why neither `createElement` nor the mutation 
observer detect it, though.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D12996

AFFECTED FILES
  extension/content-script.js
  extension/extension.js

To: broulik, #plasma, davidedmundson, fvogt
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12991: Ensure the salt file is indeed a regular file

[Fabian Vogt]

fvogt requested changes to this revision.
fvogt added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> pam_kwallet.c:732
> +syslog(LOG_ERR, "%s: Failed to ensure %s looks like a salt file", 
> logPrefix, path);
> +return 1;
> +}

Missing  `free(path);`

REPOSITORY
  R107 KWallet PAM Integration

REVISION DETAIL
  https://phabricator.kde.org/D12991

To: aacid, fvogt, mgerstner
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12991: Ensure the salt file is indeed a regular file

[Albert Astals Cid]

aacid created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
aacid requested review of this revision.

REVISION SUMMARY
  If it's not a regular file we try to re-create it
  if we can't for some reason, we bail out

REPOSITORY
  R107 KWallet PAM Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D12991

AFFECTED FILES
  pam_kwallet.c

To: aacid
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D12990: update mouse kcm docbook to 5.13

[Burkhard Lück]

lueck created this revision.
lueck added reviewers: Plasma, Documentation.
Restricted Application added projects: Plasma, Documentation.
Restricted Application added subscribers: kde-doc-english, plasma-devel.
lueck requested review of this revision.

REVISION SUMMARY
  bump date + releaseinfo
  add markup guilabel
  remove single-/double-click settings, move to workspace with 
https://phabricator.kde.org/D12946

TEST PLAN
  checkXML5 doc/kcontrol/mouse/index.docbook

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D12990

AFFECTED FILES
  doc/kcontrol/mouse/index.docbook

To: lueck, #plasma, #documentation
Cc: plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart