D13185: Make the string 'No touchpad found' translatable

yurchor created this revision. yurchor added reviewers: Plasma, Localization. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. yurchor requested review of this revision. REVISION SUMMARY If there are no touchpads installed, Touchpad KCM

D13141: Touchpad KCM Redesign Using Kirigami

ngraham added a comment. Here's another idea for the multi-tapping radio button to reduce the string length: Two-finger tap: (o) right-click (three-finger tap to middle-click) ( ) middle-click (three-finger tap to right-click) REPOSITORY R119 Plasma Desktop

D13183: Use Control.palette

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Every Control instance has a palette property. Make use of it if

D13141: Touchpad KCM Redesign Using Kirigami

ngraham added inline comments. INLINE COMMENTS > main.qml:439 > +id: naturalScroll > +text: i18n("Invert scroll direction") > + Idea: change this string to: > Invert scroll direction ("Natural scrolling") This might help improve discoverability for people who are

D13141: Touchpad KCM Redesign Using Kirigami

ngraham added a comment. Another idea: omit the always-disabled "Device" combobox when there's only a single device. It's not doing much good in that situation. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13141 To: furkantokac, ngraham, romangg, abetts

D13141: Touchpad KCM Redesign Using Kirigami

ngraham added inline comments. INLINE COMMENTS > main.qml:373 > +if (touchpad.tapFingerCount > 2) { > +model = [i18n("Two finger tap right-click, three finger > tap middle-click"), > + i18n("Two finger tap middle-click, three

D13141: Touchpad KCM Redesign Using Kirigami

ngraham added a comment. The middle click emulation issue is tricky because the behavior and available options are different depending on the hardware configuration, and, if using a buttonless touchpad, also the click method used. I wonder if we need to make the UI dynamically adapt to the

D13182: Use Mnemonics on the toolbar buttons

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Otherwise they are not reachable over there REPOSITORY R169

D13095: Scren brightness follow a quatratic progression

ngraham added a comment. Max brightness: 937 Individual brightness levels per key-press: 0 (lowest setting) 2 9 21 37 59 84 115 150 190 234 283 337 396 459 527 600 677 759 846 937 (highest setting)

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac added a comment. In D13141#269402 , @ngraham wrote: > Sadly, Libinput only allows one scrolling method to be active at once. See https://wayland.freedesktop.org/libinput/doc/latest/scrolling.html > > So until and unless we can

D13141: Touchpad KCM Redesign Using Kirigami

furkantokac updated this revision to Diff 35066. furkantokac added a comment. "NoScroll" setting is removed. Feedbacks are applied. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13141?vs=34950=35066 BRANCH kcmtouchpad-kirigamidesign REVISION

D13095: Scren brightness follow a quatratic progression

thsurrel added a comment. Could you provide the value of the system brightness after each key press (cat /sys/class/backlight/*/brightness) as well as the maximun brightness of your hardware (cat /sys/class/backlight/*/max_brightness) ? I know, I'm asking you to work with a black screen

D13095: Scren brightness follow a quatratic progression

zzag added inline comments. INLINE COMMENTS > powerdevilbrightnesslogic.cpp:135 > +return value * 100.0 / m_valueMax; > +} else { > +return valueToStep(value) * 100.0 / m_steps; Coding style nitpick: don't use "else" after a return statement. Same down below.

D13178: Compress calls to configuration slots upon new connections

jacopods created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. jacopods requested review of this revision. REVISION SUMMARY Some input devices register several copies of themselves upon connection (e.g. a mouse registers

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

ngraham added a comment. Functionally, that'll probably fix the bug, but I don't expect the user complaints to abate, just change to "Why can I uselessly drag my task manager entries?" I still think this deserves a larger discussion regarding whether dragging apps from task manager

D13148: Allow Kirigami build without KWin tablet mode dependency

murillobernardes updated this revision to Diff 35049. murillobernardes added a comment. Add option to disable dbus dependency (build time). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13148?vs=34970=35049 REVISION DETAIL

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

ngraham added a comment. So under that proposal, the visible drag would still happen, but not do anything if you drop on an app instead of a containment, right? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13162 To: Zren Cc: hein, ngraham, davidedmundson,

D13106: Add RTL support to some QtQuick ported KCMs

broulik added a comment. "without causing huge problems." > as that asserts on my machine :D REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13106 To: davidedmundson, #plasma Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D13106: Add RTL support to some QtQuick ported KCMs

broulik added a comment. I feel like this should be done at a lower level and not done in every KCM explicitly. Plasma does it for you in the containment for all applets as well as config dialogs without causing huge problems. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D13148: Allow Kirigami build without KWin tablet mode dependency

murillobernardes added a comment. In D13148#269556 , @mart wrote: > In D13148#269233 , @murillobernardes wrote: > > > I did not patch CMakeLists.txt because I can't test it. I could not get a

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

Zren abandoned this revision. Zren added a comment. No prob. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13162 To: Zren Cc: hein, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D13022: add workspaceoptions docbook

lueck added a comment. In D13022#269545 , @bshah wrote: > Is this supposed to be in 5.13 branch? Yes. Please let me handle this together with D12990 in coordination with the translators

D12990: update mouse kcm docbook to 5.13

lueck added a subscriber: lbeltrame. lueck added a comment. In D12990#269598 , @lbeltrame wrote: > @ltoscano The question was asked due to a bad merge in plasma-desktop, which needed a force push. This commit was originally in the branch, but

D12990: update mouse kcm docbook to 5.13

lbeltrame added a comment. @ltoscano The question was asked due to a bad merge in plasma-desktop, which needed a force push. This commit was originally in the branch, but no longer due to this. Hence, the question: should it be added back? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D12990: update mouse kcm docbook to 5.13

ltoscano added a comment. In D12990#269547 , @bshah wrote: > is this supposed to be in 5.13 branch? Which is frozen. If you want to improve the process in the future, please block patches which introduces features but do not update

D7087: Add "Copy Info" button to the About System KCM

ltoscano added inline comments. INLINE COMMENTS > rkflx wrote in Module.cpp:253 > > `i18nc("reverse order in rtl languages", ...)`. Does that make sense? > > It does, and it's probably easier for @gregormi to implement. Please don't write (just) "do this in this case", but explain what the

D13148: Allow Kirigami build without KWin tablet mode dependency

mart added a comment. In D13148#269233 , @murillobernardes wrote: > I did not patch CMakeLists.txt because I can't test it. I could not get a system with all the right versions of all build dependencies to build Kirigami. > > On

D13022: add workspaceoptions docbook

bshah added a comment. Is this supposed to be in 5.13 branch? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13022 To: lueck, #plasma, #documentation, yurchor Cc: bshah, plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, lesliezhai,

D12990: update mouse kcm docbook to 5.13

bshah added a comment. is this supposed to be in 5.13 branch? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D12990 To: lueck, #plasma, #documentation, mart Cc: bshah, ltoscano, plasma-devel, kde-doc-english, ragreen, Pitel, ZrenBot, skadinna, lesliezhai,

Re: Closing old Plasma 4 bugs

On Sun, May 27, 2018 at 9:05 PM, Elvis Angelaccio wrote: > On Fri, May 11, 2018 at 11:06 PM Christoph Feck wrote: > >> On 11.02.2018 20:52, Nate Graham wrote: >> > All right, so let's give it a shot. How about we make it so that normal >> > users have

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

hein added a comment. @Zren Would you be OK with abandoning this patch (which I btw got close to accepting before I read David's comment, so thanks for your persistence on this)? I would then have a go at implementing David's idea today / this week. REPOSITORY R119 Plasma Desktop

Minutes meeting week 22

Hello people, Below are notes and logs (attached) for this week's meeting Sho_: * [TM] More work on supporting apps run through Wine properly (icons, pinning, etc.) * [TM] Made libtm smarter about being able to tell apart concurrently installed Linux native and Windows/Wine versions of the

D13162: [TaskManager] Press and Hold for 800ms to trigger a drag

hein added a comment. I like David's idea. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D13162 To: Zren Cc: hein, ngraham, davidedmundson, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11848: [Kickoff] Reduce hover delay before switching tabs

hein added a comment. @ngraham You ok with abandoning this? Then I'll write an alternate patch this week that makes tab switching fast for moves from the panel button or horizontally and more strongly delayed for diagonal moves into the content area. REPOSITORY R119 Plasma Desktop BRANCH

D11848: [Kickoff] Reduce hover delay before switching tabs

rkflx added a comment. > If it's a problem, then we could hold off on this and I spend some minutes moving Kicker's triangle filter to Kickoff. I suggested exactly that in my original comment. As you seem to know that particular code, I'm sure Nate would appreciate any help. REPOSITORY

D11848: [Kickoff] Reduce hover delay before switching tabs

hein added a comment. If it's a problem, then we could hold off on this and I spend some minutes moving Kicker's triangle filter to Kickoff. I suspect David's code may be better and more general, but then he isn't busied up with something this small. REPOSITORY R119 Plasma Desktop BRANCH

D11848: [Kickoff] Reduce hover delay before switching tabs

rkflx added a comment. In D11848#269495 , @hein wrote: > Do you think tab to entry move is a problem in practice? Don't users just move vertically from the tab? In my experience (observing users working on tasks, and evaluating

D11848: [Kickoff] Reduce hover delay before switching tabs

hein added a comment. > Not sure I understand? My video is about moving from the tab bar to the entries inside the tab, not about moving between tabs. This explains our misunderstanding. The original reason Kickoff had the delay - as also noted in the earlier discussion - is for the

D11848: [Kickoff] Reduce hover delay before switching tabs

hein added a comment. For the record, here's the triangle filter in Kicker in action: https://youtu.be/d20RYgNEDcs You can see it both switch immediately on the horizontal move, and not switch as the cursor goes over 4-5 adjacent categories diagonally on the way to K3b. The

D11848: [Kickoff] Reduce hover delay before switching tabs

rkflx added a comment. That's why I mentioned "or am I wrong". At least when comparing Kicker and Kate, it's pretty clear that there's a difference in behaviour, leading to my conclusion. My comment was based on testing what users see, I'm sorry if you misunderstood that as critique on your

D11848: [Kickoff] Reduce hover delay before switching tabs

hein added a comment. As mentioned in this discussion, both Kicker and Dashboard have triangle filters. Please make sure you review discussions in full before commenting; it doesn't help if comments are made based on wrong assumptions or misinformation. Especially with such a panicky and

plasma-desktop bad merge fixed

Hello, On 25th following commit was pushed to plasma-desktop repo, commit 34106f5dbff824b0c9903cef3b20244e0971 Author: James D. Smith Date: Fri May 25 19:42:40 2018 -0600 And it was instead of cherry-picking into 5.12/5.13 branch or instead of pushing in 5.12 branch

Re: QtCreator with Kirigami for Subsurface

On Mon, May 28, 2018 at 10:52 AM Marco Martin wrote: Hi, unfortunately Qtcreator tends to be really picky with any 3rd party qml module... i think you need to have the file plugins.qmltypes somewhere where qtcreator understands it (i don't know if is possible for plugins that

Re: QtCreator with Kirigami for Subsurface

Hi, unfortunately Qtcreator tends to be really picky with any 3rd party qml module... i think you need to have the file plugins.qmltypes somewhere where qtcreator understands it (i don't know if is possible for plugins that are shipped internally in the project like subsurface does) perhaps yoy

QtCreator with Kirigami for Subsurface

Hi My name is Jan Iversen, I am working on the Subsurface project to make subsurface-mobile have more of the Features currently only available in our desktop version. This of course means using more kirigami and QtQuick.2 I would like to use Qt Creator to do big parts of the kirigami qml