D14050: Fwupd Backend For Review and Improvement

abhijeet2096 added a comment. I have Fixed some, I will fix rest and upload new diff as soon as possible. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D14050 To: abhijeet2096, apol, davidedmundson Cc: zzag, anthonyfieroni, plasma-devel, ragreen,

D13931: [KCM] Add speaker placement test

nicolasfella updated this revision to Diff 37602. nicolasfella added a comment. - Remove comment - Remove empty destructor - Add else if REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D13931?vs=37601=37602 BRANCH speakertest

D13931: [KCM] Add speaker placement test

nicolasfella updated this revision to Diff 37601. nicolasfella added a comment. Simplify model access Thanks for your help! Now, when I switch profiles I get error messages that pulseObject is null, however it seems to work fine. REPOSITORY R115 Plasma Audio Volume Applet

D14060: Clean up string casts

broulik added a comment. INLINE COMMENTS > testkwaylandbackend.cpp:88 > // and thus connect to our internal test server. > -setenv("WAYLAND_DISPLAY", s_socketName.toLocal8Bit(), 1); > +setenv("WAYLAND_DISPLAY", s_socketName.toLocal8Bit().constData(), true); >

D14060: Clean up string casts

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. cool, thanks. INLINE COMMENTS > waylandtestserver.cpp:39 > : QObject(parent) > -, m_configFile(TEST_DATA + QStringLiteral("default.json")) > +,

D14060: Clean up string casts

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY Compile without casting to/from ascii to avoid typical mistakes due to implicit conversions.

D14058: Give connect to lambda a context object

This revision was automatically updated to reflect the committed changes. Closed by commit R110:bd4fa7d318e8: Give connect to lambda a context object (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14058?vs=37596=37598 REVISION

D14058: Give connect to lambda a context object

gladhorn added a comment. Yes, this is partially to shut up clazy. REPOSITORY R110 KScreen Library REVISION DETAIL https://phabricator.kde.org/D14058 To: gladhorn, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14050: Fwupd Backend For Review and Improvement

apol requested changes to this revision. apol added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > SourcesPage.qml:113 > } > + > onObjectAdded: { Remove unrelated patch > CMakeLists.txt:47 >

D14059: Attempt at making less refreshes

apol created this revision. apol added a reviewer: sitter. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It messes with offline updates REPOSITORY R134 Discover Software Store

D14058: Give connect to lambda a context object

broulik added a comment. Though you're connecting this as sender already, and loop is on the stack so this wouldn't really make a difference REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL https://phabricator.kde.org/D14058 To: gladhorn, broulik Cc: plasma-devel,

D14058: Give connect to lambda a context object

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY This is cleaner since it will track the life-time. REPOSITORY R110 KScreen Library BRANCH

D14050: Fwupd Backend For Review and Improvement

zzag added inline comments. INLINE COMMENTS > FwupdBackend.cpp:272-289 > +FwupdDevice *device = (FwupdDevice *)g_ptr_array_index (devices, > i); > +FwupdResource* res; > + > + res = FwupdCreateDevice(device); //just to test code should be > deleted > +

D14025: Move scale and unify button to the top, next to primary combo

gladhorn closed this revision. gladhorn added a comment. Pushed, sadly without the phabricator tag, since I'm struggling to manage > 1 patch with phabricator. b01b567296b70b9b593eaa438d86dffe7b663afa REPOSITORY

D14024: Move KCM to UI file

This revision was automatically updated to reflect the committed changes. Closed by commit R104:ce68ee44e099: Move KCM to UI file (authored by gladhorn). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D14024?vs=37501=37594#toc REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D12278: WIP: [Colors KCM] Port to new design

nicolasfella added inline comments. INLINE COMMENTS > colors.cpp:313 > +QStringList colorItemList; > +colorItemList << "BackgroundNormal" > + << "BackgroundAlternate" Can you use an initializer_list here and elsewhere? Also QStringLiteral? See

D14050: Fwupd Backend For Review and Improvement

anthonyfieroni added inline comments. INLINE COMMENTS > CMakeLists.txt:16 > + > +#find_package(GIO) > +find_package(Soup) Why you comment it when you use it, see below. > FwupdBackend.cpp:68 > +if (!m_fetching) > + m_reviews->initialize(); > +

D14055: [Kickoff] Remove unused Footer.qml

This revision was automatically updated to reflect the committed changes. Closed by commit R119:ce8c022e0e3b: [Kickoff] Remove unused Footer.qml (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14055?vs=37585=37587 REVISION DETAIL

D14056: Remove FileItemActionPlugin in favor of Purpose plugin

nicolasfella created this revision. nicolasfella added reviewers: broulik, drosca. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Depends on D14052

D14055: [Kickoff] Remove unused Footer.qml

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It is not used and hasn't been touched since the original

D13988: Use subseq matching for service runner

ngraham added a comment. Nah, let's wait. We'll have to see what the dependency plans are for Plasma; I'm not sure whether or not we'll be depending on Frameworks 5.49 for Plasma 5.14. Might wanna ask one of the #plasma folks. REPOSITORY R120

D14050: Fwupd Backend For Review and Improvement

abhijeet2096 updated this revision to Diff 37580. abhijeet2096 added a comment. I rebased the patch REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14050?vs=37576=37580 REVISION DETAIL https://phabricator.kde.org/D14050 AFFECTED FILES

D14050: Fwupd Backend For Review and Improvement

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. This has a ton of unrelated changes. Please rebase your branch before sending the patch. REPOSITORY R134 Discover Software Store REVISION DETAIL

D14051: [Lock Screen] Fix avatar not showing in software rendering

This revision was automatically updated to reflect the committed changes. Closed by commit R120:665c9b1c431d: [Lock Screen] Fix avatar not showing in software rendering (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D14051: [Lock Screen] Fix avatar not showing in software rendering

broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The circular avatar is a custom `ShaderEffectItem` and as

D13931: [KCM] Add speaker placement test

nicolasfella added a comment. In D13931#290548 , @drosca wrote: > In D13931#290544 , @nicolasfella wrote: > > > I can get the PulseObject, that is not the problem, the problem is that I can't

D13931: [KCM] Add speaker placement test

drosca added a comment. In D13931#290544 , @nicolasfella wrote: > I can get the PulseObject, that is not the problem, the problem is that I can't access the model outside of a delegate. model[index] does not work because QAbstractItemModel

D13931: [KCM] Add speaker placement test

nicolasfella added inline comments. INLINE COMMENTS > drosca wrote in volumefeedback.cpp:36 > What if there is multiple VolumeFeedback instances? It will crash then. > You should either move canberra context to Context class (should probably be > fine) or implement the refcounting of

D13931: [KCM] Add speaker placement test

nicolasfella added a comment. In D13931#290535 , @drosca wrote: > And the whole ComboBox/SinkModel code needs to be changed. You should be able to get the PulseObject from the model just with QML code (see invokables in

D13931: [KCM] Add speaker placement test

drosca requested changes to this revision. drosca added a comment. This revision now requires changes to proceed. And the whole ComboBox/SinkModel code needs to be changed. You should be able to get the PulseObject from the model just with QML code (see invokables in

D14050: Fwupd Backend For Review and Improvement

abhijeet2096 created this revision. abhijeet2096 added reviewers: apol, davidedmundson. abhijeet2096 added a project: Discover Software Store. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. abhijeet2096 requested review of this revision.

D14024: Move KCM to UI file

zzag added inline comments. INLINE COMMENTS > widget.h:46-48 > +namespace Ui { > +class KScreenWidget; > +} Coding style nitpick: namespace Ui { class KScreenWidget; } > widget.h:96 >private: > +Ui::KScreenWidget *ui; > QMLScreen *mScreen = nullptr; Naming nitpick:

D10083: [Look and Feel] Reverse the button order

abetts added a comment. Not sure it is redundant but it should follow what the mockups in pholio are saying. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10083 To: safaalfulaij, #plasma, davidedmundson Cc: abetts, davidedmundson, plasma-devel, ragreen,

D13988: Use subseq matching for service runner

michaeleden added a comment. @ngraham this didn't make it into 5.48 but it did make it into the commit after that. Should I put 5.49 even though its not tagged yet? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D13988 To: michaeleden, rthomas,

D14049: Trim kwrited text

This revision was automatically updated to reflect the committed changes. Closed by commit R109:bc72a72e8e93: Trim kwrited text (authored by broulik). REPOSITORY R109 KWriteD CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14049?vs=37571=37572 REVISION DETAIL

D14049: Trim kwrited text

broulik created this revision. broulik added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Avoids having empty lines at the beginning leaving a gap between

D14000: qqc2-desktop-style: basic support for QGuiApplication-based apps (WIP/PoC)

rjvbb updated this revision to Diff 37568. rjvbb added a comment. build on Mac too CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14000?vs=37439=37568 REVISION DETAIL https://phabricator.kde.org/D14000 AFFECTED FILES plugin/kquickstyleitem.cpp plugin/kquickstyleitem_p.h To:

D14048: Fix fake parser copy and paste error

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY all other cases remove the key they were looking for, this seems to be a copy and paste error.

D10083: [Look and Feel] Reverse the button order

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Is this now redundant when this KCM was remodelled ? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D10083 To: safaalfulaij,

D14044: Simplify getting edid in xrandr backend

This revision was automatically updated to reflect the committed changes. Closed by commit R110:e4236e02b814: Simplify getting edid in xrandr backend (authored by gladhorn). REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14044?vs=37555=37557 REVISION

D14044: Simplify getting edid in xrandr backend

gladhorn added inline comments. INLINE COMMENTS > zzag wrote in xrandr.cpp:273 > reinterpret_cast(result) I agree, but there are more places with c-style casts, let's clean them all up in one go. This is just moving things. REPOSITORY R110 KScreen Library BRANCH master REVISION DETAIL

D14044: Simplify getting edid in xrandr backend

zzag added inline comments. INLINE COMMENTS > xrandr.cpp:273 > if (len % 128 == 0) { > -return result; > -} else { > -len = 0; > -delete[] result; > +edid = QByteArray((char *) result, len); > } reinterpret_cast(result)

D14041: Honor ghns KIOSK restriction in new KCMs

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4e2a515bb34f: Honor ghns KIOSK restriction in new KCMs (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14041?vs=37548=37556 REVISION

D14041: Honor ghns KIOSK restriction in new KCMs

broulik added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:147 > What does kcm.canInstall do? // Disable the install button if we can't install new themes to ~/.icons, // or Xcursor isn't set up to look for cursor themes there. if

D14044: Simplify getting edid in xrandr backend

gladhorn created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY XRandR::outputEdid is used in only one place, let it return a byte array directly. REPOSITORY

D14023: Make Primary Combo a regular QComboBox

This revision was automatically updated to reflect the committed changes. Closed by commit R104:77ee98211895: Make Primary Combo a regular QComboBox (authored by gladhorn). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14023?vs=37530=37554 REVISION DETAIL

D13881: oxygen-demo : add KMessage preview

hpereiradacosta added a comment. In D13881#286998 , @rjvbb wrote: > A couple of snapshot (with my current KMessageWidget facelift; styles and themes switched "on-the-fly"): > > Oxygen with the Oxygen theme: > F6014853: image.png

D14029: [Kicker] Use KFilePlaces::convertedUrl for ComputerModel

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3fe808ef8e97: [Kicker] Use KFilePlaces::convertedUrl for ComputerModel (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D14041: Honor ghns KIOSK restriction in new KCMs

davidedmundson added inline comments. INLINE COMMENTS > main.qml:147 > onClicked: kcm.getNewClicked(); > enabled: kcm.canInstall > +visible: KAuthorized.authorize("ghns") What does kcm.canInstall do? REPOSITORY R119 Plasma Desktop

D13999: [Kicker System Entry] Remove KDisplayManager global static

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1cdb7ae4dfea: [Kicker System Entry] Remove KDisplayManager global static (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D14030: [Kickoff] Use KFilePlacesModel groups

This revision was automatically updated to reflect the committed changes. Closed by commit R119:4f1091f1316b: [Kickoff] Use KFilePlacesModel groups (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14030?vs=37509=37550 REVISION

D14041: Honor ghns KIOSK restriction in new KCMs

broulik created this revision. broulik added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN 5.13 branch Put the following in `kdeglobals` [KDE Action

D13881: oxygen-demo : add KMessage preview

rjvbb marked 3 inline comments as done. rjvbb added a comment. Ping? REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D13881 To: rjvbb, hpereiradacosta Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,