D14830: Add "Display Configuration" context menu entry on the desktop

abetts added a comment. In D14830#309263 , @davidedmundson wrote: > > This could be good whenever we have situations where the desktop locks > > If the desktop locks then the one thing you can't do is right click on the desktop

D14830: Add "Display Configuration" context menu entry on the desktop

davidedmundson added a comment. > This could be good whenever we have situations where the desktop locks If the desktop locks then the one thing you can't do is right click on the desktop REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14830 To:

KDE CI: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 - Build # 168 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.10/168/ Project: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 Date of build: Wed, 15 Aug 2018 03:49:03 + Build duration: 10 min and counting CONSOLE OUTPUT

KDE CI: Plasma plasma-sdk kf5-qt5 SUSEQt5.10 - Build # 29 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-sdk%20kf5-qt5%20SUSEQt5.10/29/ Project: Plasma plasma-sdk kf5-qt5 SUSEQt5.10 Date of build: Wed, 15 Aug 2018 03:49:07 + Build duration: 9 min 4 sec and counting CONSOLE OUTPUT

KDE CI: Plasma kwin kf5-qt5 SUSEQt5.10 - Build # 155 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20SUSEQt5.10/155/ Project: Plasma kwin kf5-qt5 SUSEQt5.10 Date of build: Wed, 15 Aug 2018 03:48:50 + Build duration: 7 min 39 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma systemsettings kf5-qt5 SUSEQt5.10 - Build # 41 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20systemsettings%20kf5-qt5%20SUSEQt5.10/41/ Project: Plasma systemsettings kf5-qt5 SUSEQt5.10 Date of build: Wed, 15 Aug 2018 03:49:18 + Build duration: 6 min 55 sec and counting CONSOLE OUTPUT

KDE CI: Plasma plasma-framework kf5-qt5 SUSEQt5.10 - Build # 59 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20SUSEQt5.10/59/ Project: Plasma plasma-framework kf5-qt5 SUSEQt5.10 Date of build: Wed, 15 Aug 2018 03:45:42 + Build duration: 4 min 1 sec and counting CONSOLE

KDE CI: Plasma ksysguard kf5-qt5 SUSEQt5.10 - Build # 25 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20ksysguard%20kf5-qt5%20SUSEQt5.10/25/ Project: Plasma ksysguard kf5-qt5 SUSEQt5.10 Date of build: Wed, 15 Aug 2018 01:50:47 + Build duration: 5 min 43 sec and counting CONSOLE OUTPUT

KDE CI: Plasma plasma-sdk kf5-qt5 SUSEQt5.10 - Build # 28 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-sdk%20kf5-qt5%20SUSEQt5.10/28/ Project: Plasma plasma-sdk kf5-qt5 SUSEQt5.10 Date of build: Wed, 15 Aug 2018 01:51:36 + Build duration: 3 min 26 sec and counting CONSOLE OUTPUT

D14830: Add "Display Configuration" context menu entry on the desktop

abetts added a comment. In D14830#308870 , @davidedmundson wrote: > > about how having this option is stupid and doesn't fit in here and bla bla that always emerges when this entry is proposed or talked about. > > Being off by default does

D7087: Add "Copy Info" button to the About System KCM

ngraham added inline comments. INLINE COMMENTS > dhaumann wrote in Module.cpp:162 > Is "Distro" a proper English term? Should it meaybe read "Distribution"? "Distro" is slang, but very common. I'm not sure "Distribution" is much better if were considering average people. They would consider

D7087: Add "Copy Info" button to the About System KCM

dhaumann accepted this revision. dhaumann added a comment. This revision is now accepted and ready to land. Ok from my side, although it still *feels* a bit messy :-) - please consider using QVector before committing - possibly fix the "Distro" thing, if applicable INLINE COMMENTS >

D14836: Kicker: Reset re-used menu width to default one

ngraham added a reviewer: hein. ngraham added a comment. Works well for me, FWIW. But I seem to remember that that the original patch had some logic specifically to enable this behavior that we're now trying to turn off... can we now simplify all that? REPOSITORY R119 Plasma Desktop

Re: Upcoming reorganisation of the CI system

On Tue, 14 Aug 2018, 17:09 Christoph Feck, wrote: > On 14.08.2018 15:03, Ben Cooksley wrote: > > Currently CI jobs are all created within a flat namespace, meaning > > that it is quite difficult to view the overall status of an individual > > project. Additionally, it creates the issue that the

D14830: Add "Display Configuration" context menu entry on the desktop

davidedmundson added a comment. > about how having this option is stupid and doesn't fit in here and bla bla that always emerges when this entry is proposed or talked about. Being off by default does not replace code always needing a justification behind it. I've still to hear a valid

Re: Upcoming reorganisation of the CI system

On 14.08.2018 15:03, Ben Cooksley wrote: Currently CI jobs are all created within a flat namespace, meaning that it is quite difficult to view the overall status of an individual project. Additionally, it creates the issue that the main default view can take a significant amount of time to load.

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

volkov added inline comments. INLINE COMMENTS > broulik wrote in networkmodel.cpp:220 > Would it be better to only request the data when the statistics are open to > avoid wakeups and processing? Yes, good point. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

broulik added inline comments. INLINE COMMENTS > networkmodel.cpp:220 > +auto deviceStatistics = device->deviceStatistics(); > +deviceStatistics->setRefreshRateMs(2000); > +connect(deviceStatistics.data(), > ::DeviceStatistics::rxBytesChanged, this, [this, > device](qulonglong

D14836: Kicker: Reset re-used menu width to default one

aacid created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY BUGS: 397206 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D14836 AFFECTED FILES

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

volkov created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. volkov requested review of this revision. REVISION SUMMARY It's more correct to get information about devices from a single source, i.e. from NetworkManager. Besides it allows to show the

D14830: Add "Display Configuration" context menu entry on the desktop

ngraham added subscribers: fabianr, romangg, abetts. ngraham added a comment. In D14830#308703 , @broulik wrote: > In D14830#308693 , @ngraham wrote: > > > The text needs to start with a verb and

D14830: Add "Display Configuration" context menu entry on the desktop

broulik added a comment. In D14830#308693 , @ngraham wrote: > The text needs to start with a verb and end with an ellipsis, E.g. "Configure Display Settings..." or even "Configure Displays..." According to HIG: > Do not use an

D14830: Add "Display Configuration" context menu entry on the desktop

ngraham added a comment. The text needs to start with a verb and end with an ellipsis, E.g. "Configure Display Settings..." or even "Configure Displays..." ("Configure Desktop" should also have an ellipsis) FWIW, I would be in favor of having this on by default. The context menu is

D14830: Add "Display Configuration" context menu entry on the desktop

broulik created this revision. broulik added reviewers: Plasma, VDG, fischbach. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY One of LiMux client's requirements is for display configuration to be easily

Upcoming reorganisation of the CI system

Hi all, Currently CI jobs are all created within a flat namespace, meaning that it is quite difficult to view the overall status of an individual project. Additionally, it creates the issue that the main default view can take a significant amount of time to load. To resolve this we intend to

D14822: Use QJSValue as method parameter type for the scripting interface

fvogt added a comment. A different approach of fixing this is to do something like if(value.userType() == qMetaTypeId()) value = value.value().toVariant(); in every function for every QVariant parameter. Advantages are that it's more obvious and the function's interface

D14822: Use QJSValue as method parameter type for the scripting interface

fvogt added inline comments. INLINE COMMENTS > anthonyfieroni wrote in applet.cpp:139 > So writeEntry gets QJSValue& now why you call again toVariant(), here > everywhere else. KConfigGroup != ConfigGroup. d->configGroup is from kconfig and does not take QJSValue. That's the core of the

D14822: Use QJSValue as method parameter type for the scripting interface

anthonyfieroni added inline comments. INLINE COMMENTS > applet.cpp:139 > > -d->configGroup.writeEntry(key, value); > +d->configGroup.writeEntry(key, value.toVariant()); > d->configDirty = true; So writeEntry gets QJSValue& now why you call again toVariant(), here

D14822: Use QJSValue as method parameter type for the scripting interface

fvogt created this revision. fvogt added a reviewer: Plasma. Herald added a project: Plasma. fvogt requested review of this revision. REVISION SUMMARY If a slot or Q_INVOKABLE has a QVariant as parameter and gets called from a QJSEngine's script, it receives a QJSValue wrapped as QVariant.