D14830: Add "Display Configuration" context menu entry on the desktop

2018-08-14 Thread Andres Betts 
abetts added a comment.


  In D14830#309263 , @davidedmundson 
wrote:
  
  > >   This could be good whenever we have situations where the desktop locks
  >
  > If the desktop locks then the one thing you can't do is right click on the 
desktop
  
  
  Odd, I have had instances (not in a very long time) when my bars have locked 
up and then only option has been right click.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14830

To: broulik, #plasma, #vdg, fischbach
Cc: davidedmundson, abetts, romangg, fabianr, ngraham, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14830: Add "Display Configuration" context menu entry on the desktop

2018-08-14 Thread David Edmundson 
davidedmundson added a comment.


  >   This could be good whenever we have situations where the desktop locks
  
  If the desktop locks then the one thing you can't do is right click on the 
desktop

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14830

To: broulik, #plasma, #vdg, fischbach
Cc: davidedmundson, abetts, romangg, fabianr, ngraham, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

KDE CI: Plasma plasma-desktop kf5-qt5 SUSEQt5.10 - Build # 168 - Failure!

2018-08-14 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-desktop%20kf5-qt5%20SUSEQt5.10/168/
 Project:
Plasma plasma-desktop kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 15 Aug 2018 03:49:03 +
 Build duration:
10 min and counting
   CONSOLE OUTPUT
  [...truncated 252.71 KB...] * Qt5Core * KDED (required version >= 5.45.0) * X11_XCB * XCB, X protocol C-language Binding,  * PkgConfig * Qt5Test * ECM (required version >= 0.0.8) * Qt5Widgets * Qt5Qml * Qt5X11Extras * Qt5Quick * Qt5 * Gettext * KF5I18n * KF5Config * KF5CoreAddons * KF5GlobalAccel * KF5GuiAddons * KF5KIO * KF5Activities * KF5WindowSystem * X11, X11 libraries,Required for building the X11 based workspace * Phonon4Qt5-- The following features have been disabled: * XorgLibinput, Libinput driver headers needed for mouse KCM-- The following RUNTIME packages have not been found: * org.kde.plasma.core-QMLModule, QML module 'org.kde.plasma.core' is a runtime dependency.-- The following OPTIONAL packages have not been found: * XorgLibinput, Libinput driver headers needed for mouse KCM-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Plasma plasma-desktop kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project plasma-desktop --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target org.kde.plasma.desktop.appmenubar-layout-templates-metadata-jsonScanning dependencies of target doc-kcontrol-clock-index-cache-bz2Scanning dependencies of target org.kde.plasma.desktop-shells-metadata-jsonScanning dependencies of target org.kde.plasma.desktop.defaultPanel-layout-templates-metadata-jsonScanning dependencies of target org.kde.plasma.desktop.emptyPanel-layout-templates-metadata-json[  0%] Generating org.kde.plasma.desktop.emptyPanel-layout-templates-metadata.jsonScanning dependencies of target doc-kcontrol-colors-index-cache-bz2[  0%] Generating index.cache.bz2About to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/plasma-layouttemplate.desktop"Found property definition "X-Plasma-Shell" with type "QString"Found property definition "X-Plasma-ContainmentCategories" with type "QStringList"Generated  "/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 SUSEQt5.10/build/layout-templates/org.kde.plasma.desktop.emptyPanel-layout-templates-metadata.json" /bin/sh: /home/jenkins/workspace/Dependency Build Plasma kf5-qt5 SUSEQt5.10/kdoctools/build/bin/meinproc5: No such file or directorymake[2]: *** [doc/kcontrol/clock/CMakeFiles/doc-kcontrol-clock-index-cache-bz2.dir/build.make:62: doc/kcontrol/clock/index.cache.bz2] Error 127make[1]: *** [CMakeFiles/Makefile2:457: doc/kcontrol/clock/CMakeFiles/doc-kcontrol-clock-index-cache-bz2.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[  0%] Generating org.kde.plasma.desktop.defaultPanel-layout-templates-metadata.json[  0%] Generating org.kde.plasma.desktop-shells-metadata.json[  0%] Generating org.kde.plasma.desktop.appmenubar-layout-templates-metadata.json[  0%] Generating index.cache.bz2/bin/sh: /home/jenkins/workspace/Dependency Build Plasma kf5-qt5 SUSEQt5.10/kdoctools/build/bin/meinproc5: No such file or directorymake[2]: *** [doc/kcontrol/colors/CMakeFiles/doc-kcontrol-colors-index-cache-bz2.dir/build.make:62: doc/kcontrol/colors/index.cache.bz2] Error 127make[1]: *** [CMakeFiles/Makefile2:512: doc/kcontrol/colors/CMakeFiles/doc-kcontrol-colors-index-cache-bz2.dir/all] Error 2About to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/plasma-layouttemplate.desktop"Found property definition "X-Plasma-Shell" with type "QString"Found property definition "X-Plasma-ContainmentCategories" with type "QStringList"Generated  "/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 SUSEQt5.10/build/layout-templates/org.kde.plasma.desktop.defaultPanel-layout-templates-metadata.json" [  0%] Built target org.kde.plasma.desktop.emptyPanel-layout-templates-metadata-jsonAbout to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/plasma-layouttemplate.desktop"Found property definition "X-Plasma-Shell" with type "QString"Found property definition "X-Plasma-ContainmentCategories" with type "QStringList"Generated  "/home/jenkins/workspace/Plasma plasma-desktop kf5-qt5 SUSEQt5.10/build/layout-templates/org.kde.plasma.desktop.appmenubar-layout-templates-metadata.json" About to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/plasma-shell.desktop"Unknown property type for key "Keywords" -> falling back to stringUnknown property type for key "X-KDE-ParentApp" -> falling back to stringUnknown property type for key "X-Plasma-MainScript" -> falling back to stringGenerated

KDE CI: Plasma plasma-sdk kf5-qt5 SUSEQt5.10 - Build # 29 - Still Failing!

2018-08-14 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-sdk%20kf5-qt5%20SUSEQt5.10/29/
 Project:
Plasma plasma-sdk kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 15 Aug 2018 03:49:07 +
 Build duration:
9 min 4 sec and counting
   CONSOLE OUTPUT
  [...truncated 138.31 KB...] * KF5Config (required version >= 5.42.0) * KF5ConfigWidgets (required version >= 5.42.0) * KF5CoreAddons (required version >= 5.42.0) * KF5DBusAddons (required version >= 5.42.0) * KF5Declarative (required version >= 5.42.0) * Gettext * KF5I18n (required version >= 5.42.0) * KF5IconThemes (required version >= 5.42.0) * KF5KIO (required version >= 5.42.0) * ECM (required version >= 1.6.0) * Qt5Core * KF5Plasma (required version >= 5.42.0) * KF5PlasmaQuick (required version >= 5.42.0) * KF5Service (required version >= 5.42.0) * KF5TextEditor (required version >= 5.42.0) * KF5WidgetsAddons (required version >= 5.42.0) * KF5DocTools (required version >= 5.42.0) * KF5 (required version >= 5.42.0) * Qt5Test, Required for building tests   Required for tests * Qt5 (required version >= 5.9.0)-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Plasma plasma-sdk kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Plasma plasma-sdk kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project plasma-sdk --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target org.kde.plasma.cuttlefish-packages-metadata-json[  2%] Generating org.kde.plasma.cuttlefish-packages-metadata.jsonUnknown property type for key "GenericName" -> falling back to stringUnknown property type for key "GenericName[ca]" -> falling back to stringUnknown property type for key "GenericName[ca@valencia]" -> falling back to stringUnknown property type for key "GenericName[cs]" -> falling back to stringUnknown property type for key "GenericName[da]" -> falling back to stringUnknown property type for key "GenericName[de]" -> falling back to stringUnknown property type for key "GenericName[el]" -> falling back to stringUnknown property type for key "GenericName[en_GB]" -> falling back to stringUnknown property type for key "GenericName[es]" -> falling back to stringUnknown property type for key "GenericName[et]" -> falling back to stringUnknown property type for key "GenericName[eu]" -> falling back to stringUnknown property type for key "GenericName[fi]" -> falling back to stringUnknown property type for key "GenericName[fr]" -> falling back to stringUnknown property type for key "GenericName[gl]" -> falling back to stringUnknown property type for key "GenericName[hu]" -> falling back to stringUnknown property type for key "GenericName[it]" -> falling back to stringUnknown property type for key "GenericName[ko]" -> falling back to stringUnknown property type for key "GenericName[nl]" -> falling back to stringUnknown property type for key "GenericName[nn]" -> falling back to stringUnknown property type for key "GenericName[pl]" -> falling back to stringUnknown property type for key "GenericName[pt]" -> falling back to stringUnknown property type for key "GenericName[pt_BR]" -> falling back to stringUnknown property type for key "GenericName[ru]" -> falling back to stringUnknown property type for key "GenericName[sk]" -> falling back to stringUnknown property type for key "GenericName[sl]" -> falling back to stringUnknown property type for key "GenericName[sr]" -> falling back to stringUnknown property type for key "GenericName[sr@ijekavian]" -> falling back to stringUnknown property type for key "GenericName[sr@ijekavianlatin]" -> falling back to stringUnknown property type for key "GenericName[sr@latin]" -> falling back to stringUnknown property type for key "GenericName[sv]" -> falling back to stringUnknown property type for key "GenericName[tr]" -> falling back to stringUnknown property type for key "GenericName[uk]" -> falling back to stringUnknown property type for key "GenericName[x-test]" -> falling back to stringUnknown property type for key "GenericName[zh_CN]" -> falling back to stringUnknown property type for key "GenericName[zh_TW]" -> falling back to stringUnknown property type for key "X-Plasma-MainScript" -> falling back to stringGenerated  "/home/jenkins/workspace/Plasma plasma-sdk kf5-qt5 SUSEQt5.10/build/cuttlefish/org.kde.plasma.cuttlefish-packages-metadata.json" [  2%] Built target org.kde.plasma.cuttlefish-packages-metadata-jsonScanning dependencies of target cuttlefish_autogen[  4%] Automatic MOC for target cuttlefish[  4%] Built target cuttlefish_autogenScanning dependencies of target cuttlefishplugin_autogen[  6%] Generating cuttlefishplugin.jsonAbout to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/ktexteditorplugin.desktop"Generated  "/home/jenkins/workspace/Plasma

KDE CI: Plasma kwin kf5-qt5 SUSEQt5.10 - Build # 155 - Failure!

2018-08-14 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20SUSEQt5.10/155/
 Project:
Plasma kwin kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 15 Aug 2018 03:48:50 +
 Build duration:
7 min 39 sec and counting
   CONSOLE OUTPUT
  [...truncated 400.13 KB...]Scanning dependencies of target copy_autogen[  2%] Built target testOnScreenNotification_autogen[  2%] Built target kwinglplatformtest_autogen[  2%] Built target testScreens_autogen[  2%] Automatic MOC for target copyScanning dependencies of target fakedecoshadows_autogenScanning dependencies of target kill_autogenScanning dependencies of target testInputEvents_autogen[  2%] Automatic MOC for target fakedecoshadows[  2%] Automatic MOC for target testInputEvents[  2%] Automatic MOC for target kill[  2%] Built target testScreenEdges_autogenScanning dependencies of target testLibinputContext_autogen[  2%] Built target kill_autogen[  2%] Automatic MOC for target testLibinputContextScanning dependencies of target testLibinputKeyEvent_autogen[  2%] Built target fakedecoshadows_autogen[  2%] Automatic MOC for target testLibinputKeyEventScanning dependencies of target testLibinputDevice_autogen[  2%] Automatic MOC for target testLibinputDevice[  2%] Built target testInputEvents_autogen[  2%] Built target testLibinputContext_autogenScanning dependencies of target testLibinputTouchEvent_autogen[  2%] Built target copy_autogen[  2%] Built target paste_autogenScanning dependencies of target testLibinputPointerEvent_autogen[  2%] Automatic MOC for target testLibinputTouchEventScanning dependencies of target testLibinputGestureEvent_autogenScanning dependencies of target testLibinputSwitchEvent_autogen[  2%] Automatic MOC for target testLibinputPointerEvent[  2%] Automatic MOC for target testLibinputGestureEvent[  2%] Automatic MOC for target testLibinputSwitchEvent[  2%] Built target testLibinputSwitchEvent_autogenScanning dependencies of target mockDrm_autogen[  2%] Automatic MOC for target mockDrm[  2%] Built target testLibinputKeyEvent_autogen[  2%] Built target testLibinputPointerEvent_autogen[  2%] Built target testLibinputTouchEvent_autogen[  2%] Built target testLibinputGestureEvent_autogen[  2%] Built target testLibinputDevice_autogenScanning dependencies of target testDesktopChain_autogenScanning dependencies of target testTabBoxClientModel_autogenScanning dependencies of target testTabBoxConfig_autogenScanning dependencies of target testTabBoxHandler_autogenScanning dependencies of target cursorhotspottest_autogen[  2%] Automatic MOC for target testTabBoxConfig[  2%] Automatic MOC for target testDesktopChain[  2%] Automatic MOC for target testTabBoxClientModel[  2%] Automatic MOC for target testTabBoxHandler[  2%] Automatic MOC for target cursorhotspottest[  2%] Built target mockDrm_autogenScanning dependencies of target pointergestures_autogen[  2%] Automatic MOC for target pointergestures[  2%] Built target testDesktopChain_autogenScanning dependencies of target screenedgeshowtest_autogen[  2%] Built target cursorhotspottest_autogen[  2%] Automatic MOC for target screenedgeshowtestScanning dependencies of target orientationtest_autogen[  2%] Built target testTabBoxConfig_autogen[  2%] Built target testTabBoxClientModel_autogen[  2%] Automatic MOC for target orientationtestScanning dependencies of target x11shadowreader_autogenScanning dependencies of target normalhintsbasesizetest_autogen[  2%] Built target pointergestures_autogen[  2%] Built target testTabBoxHandler_autogen[  2%] Automatic MOC for target normalhintsbasesizetest[  3%] Automatic MOC for target x11shadowreaderScanning dependencies of target libinputtest_autogenScanning dependencies of target waylandclienttest_autogen[  3%] Built target orientationtest_autogen[  3%] Automatic MOC for target libinputtest[  3%] Built target normalhintsbasesizetest_autogen[  3%] Automatic MOC for target waylandclienttestScanning dependencies of target pointerconstraints_autogen[  3%] Built target x11shadowreader_autogenScanning dependencies of target doc-desktop-index-cache-bz2[  3%] Automatic MOC for target pointerconstraintsScanning dependencies of target doc-kwindecoration-index-cache-bz2[  3%] Generating index.cache.bz2/bin/sh: /home/jenkins/workspace/Dependency Build Plasma kf5-qt5 SUSEQt5.10/kdoctools/build/bin/meinproc5: No such file or directorymake[2]: *** [doc/desktop/CMakeFiles/doc-desktop-index-cache-bz2.dir/build.make:62: doc/desktop/index.cache.bz2] Error 127make[1]: *** [CMakeFiles/Makefile2:18434: doc/desktop/CMakeFiles/doc-desktop-index-cache-bz2.dir/all] Error 2make[1]: *** Waiting for unfinished jobs[  3%] Generating index.cache.bz2/bin/sh: /home/jenkins/workspace/Dependency Build Plasma kf5-qt5 SUSEQt5.10/kdoctools/build/bin/meinproc5: No such file or directorymake[2]: *** [doc/kwindecoration/CMakeFiles/doc-kwindecoration-index-cache-bz2.dir/build.make:62: doc/kwindecoration/index.cache.bz2] Error 127make[1]: ***

KDE CI: Plasma systemsettings kf5-qt5 SUSEQt5.10 - Build # 41 - Failure!

2018-08-14 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20systemsettings%20kf5-qt5%20SUSEQt5.10/41/
 Project:
Plasma systemsettings kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 15 Aug 2018 03:49:18 +
 Build duration:
6 min 55 sec and counting
   CONSOLE OUTPUT
  [...truncated 114.40 KB...]-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Crash: /home/jenkins/install-prefix/lib64/cmake/KF5Crash/KF5CrashConfig.cmake (found version "5.50.0") -- Found KF5ItemViews: /home/jenkins/install-prefix/lib64/cmake/KF5ItemViews/KF5ItemViewsConfig.cmake (found version "5.50.0") -- Found KF5KCMUtils: /home/jenkins/install-prefix/lib64/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (found version "5.50.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.50.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.50.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.50.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.50.0") -- Found KF5WidgetsAddons: /home/jenkins/install-prefix/lib64/cmake/KF5WidgetsAddons/KF5WidgetsAddonsConfig.cmake (found version "5.50.0") -- Found KF5WindowSystem: /home/jenkins/install-prefix/lib64/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.50.0") -- Found KF5XmlGui: /home/jenkins/install-prefix/lib64/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.50.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.50.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.50.0") -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.50.0") -- Found KF5Package: /home/jenkins/install-prefix/lib64/cmake/KF5Package/KF5PackageConfig.cmake (found version "5.50.0") -- Found KF5Declarative: /home/jenkins/install-prefix/lib64/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.50.0") -- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.50.0") -- Found KF5ActivitiesStats: /home/jenkins/install-prefix/lib64/cmake/KF5ActivitiesStats/KF5ActivitiesStatsConfig.cmake (found version "5.50.0") -- Found KF5KHtml: /home/jenkins/install-prefix/lib64/cmake/KF5KHtml/KF5KHtmlConfig.cmake (found version "5.50.0") -- qmlplugindump failed for org.kde.kcm.-- Could NOT find org.kde.kcm-QMLModule (missing: org.kde.kcm-QMLModule_FOUND) -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following OPTIONAL packages have been found: * KF5KHtml (required version >= 5.42) * Qt5Core-- The following REQUIRED packages have been found: * Qt5Gui (required version >= 5.10.1) * Qt5Widgets * Qt5Network (required version >= 5.10.1) * Qt5Quick * Qt5Qml * Qt5QuickWidgets * Qt5 (required version >= 5.9.0) * KF5Crash (required version >= 5.42) * KF5ItemViews (required version >= 5.42) * KF5KCMUtils (required version >= 5.42) * Gettext * KF5I18n (required version >= 5.42) * KF5KIO (required version >= 5.42) * KF5Service (required version >= 5.42) * KF5IconThemes (required version >= 5.42) * KF5WidgetsAddons (required version >= 5.42) * KF5WindowSystem (required version >= 5.42) * KF5XmlGui (required version >= 5.42) * KF5DBusAddons (required version >= 5.42) * KF5Config (required version >= 5.42) * KF5DocTools (required version >= 5.42) * ECM (required version >= 1.6.0) * KF5Package (required version >= 5.42) * KF5Declarative (required version >= 5.42) * KF5Activities (required version >= 5.42) * KF5ActivitiesStats (required version >= 5.42) * KF5 (required version >= 5.42) * KF5Kirigami2 (required version >= 2.1) * LibKWorkspace (required version >= 5.13.80)-- The following RUNTIME packages have not been found: * org.kde.kcm-QMLModule, QML module 'org.kde.kcm' is a runtime dependency.-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Plasma systemsettings kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Plasma systemsettings kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project systemsettings --branchGroup kf5-qt5

KDE CI: Plasma plasma-framework kf5-qt5 SUSEQt5.10 - Build # 59 - Failure!

2018-08-14 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20SUSEQt5.10/59/
 Project:
Plasma plasma-framework kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 15 Aug 2018 03:45:42 +
 Build duration:
4 min 1 sec and counting
   CONSOLE OUTPUT
  [...truncated 121.33 KB...]  cmake_policy command to set the policy and suppress this warning.  FindOpenGL found both a legacy GL library:OPENGL_gl_LIBRARY: /usr/lib64/libGL.so  and GLVND libraries for OpenGL and GLX:OPENGL_opengl_LIBRARY: /usr/lib64/libOpenGL.soOPENGL_glx_LIBRARY: /usr/lib64/libGLX.so  OpenGL_GL_PREFERENCE has not been set to "GLVND" or "LEGACY", so for  compatibility with CMake 3.10 and below the legacy GL library will be used.Call Stack (most recent call first):  CMakeLists.txt:103 (find_package)This warning is for project developers.  Use -Wno-dev to suppress it.-- Found OpenGL: /usr/lib64/libOpenGL.so   -- Found EGL: /usr/lib64/libEGL.so (found version "1.5") -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY-- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success-- Performing Test COMPILER_HAS_DEPRECATED_ATTR-- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success-- The following OPTIONAL packages have been found: * KF5Wayland (required version >= 5.49.0), Integration with the Wayland compositor * KF5DocTools (required version >= 5.49.0), Tools to generate documentation * X11, X11 libraries,  * XCB, X protocol C-language Binding,  * OpenGL, The OpenGL libraries,  * PkgConfig * EGL, A platform-agnostic mechanism for creating rendering surfaces for use with other graphics libraries, such as OpenGL|ES and OpenVG.,Support for Window Thumbnail on EGL platform-- The following REQUIRED packages have been found: * Qt5Network (required version >= 5.10.1) * Qt5Quick * Qt5Gui * Qt5Sql * Qt5Qml * Qt5Svg * Qt5QuickControls2 * KF5Activities (required version >= 5.49.0) * KF5Archive (required version >= 5.49.0) * KF5Config (required version >= 5.49.0) * KF5ConfigWidgets (required version >= 5.49.0) * KF5DBusAddons (required version >= 5.49.0) * KF5Declarative (required version >= 5.49.0) * KF5GlobalAccel (required version >= 5.49.0) * KF5GuiAddons (required version >= 5.49.0) * Gettext * KF5I18n (required version >= 5.49.0) * KF5IconThemes (required version >= 5.49.0) * KF5KIO (required version >= 5.49.0) * KF5Service (required version >= 5.49.0) * KF5WindowSystem (required version >= 5.49.0) * KF5Notifications (required version >= 5.49.0) * KF5Package (required version >= 5.49.0) * KF5Kirigami2 (required version >= 5.49.0) * KF5 (required version >= 5.49.0) * Qt5X11Extras * Qt5 * ECM (required version >= 1.6.0), Extra CMake Modules.,  * Qt5Test (required version >= 5.8.0)   Required for tests * KF5CoreAddons * KF5XmlGui * Qt5Widgets-- The following features have been disabled: * QCH, API documentation in QCH format (for e.g. Qt Assistant, Qt Creator & KDevelop)-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Plasma plasma-framework kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Plasma plasma-framework kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project plasma-framework --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target docs-plasmapkg2-plasmapkg2-1[  0%] Generating plasmapkg2.1/bin/sh: /home/jenkins/workspace/Dependency Build Plasma kf5-qt5 SUSEQt5.10/kdoctools/build/bin/meinproc5: No such file or directorymake[2]: *** [docs/plasmapkg2/CMakeFiles/docs-plasmapkg2-plasmapkg2-1.dir/build.make:62: docs/plasmapkg2/plasmapkg2.1] Error 127make[1]: *** [CMakeFiles/Makefile2:173: docs/plasmapkg2/CMakeFiles/docs-plasmapkg2-plasmapkg2-1.dir/all] Error 2make: *** [Makefile:141: all] Error 2[Pipeline] }[Pipeline] // stage[Pipeline] }ERROR: script returned exit code 1[Pipeline] // catchError[Pipeline] emailextrecipients[Pipeline] emailext

KDE CI: Plasma ksysguard kf5-qt5 SUSEQt5.10 - Build # 25 - Failure!

2018-08-14 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20ksysguard%20kf5-qt5%20SUSEQt5.10/25/
 Project:
Plasma ksysguard kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 15 Aug 2018 01:50:47 +
 Build duration:
5 min 43 sec and counting
   CONSOLE OUTPUT
  [...truncated 103.76 KB...]== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma ksysguard kf5-qt5 SUSEQt5.10"-- The C compiler identification is GNU 8.1.1-- The CXX compiler identification is GNU 8.1.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - Success-- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.50.0") -- Found KF5CoreAddons: /home/jenkins/install-prefix/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.50.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.50.0") -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.50.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.50.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.50.0") -- Found KF5Init: /home/jenkins/install-prefix/lib64/cmake/KF5Init/KF5InitConfig.cmake (found version "5.50.0") -- Found KF5ItemViews: /home/jenkins/install-prefix/lib64/cmake/KF5ItemViews/KF5ItemViewsConfig.cmake (found version "5.50.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.50.0") -- Found KF5NewStuff: /home/jenkins/install-prefix/lib64/cmake/KF5NewStuff/KF5NewStuffConfig.cmake (found version "5.50.0") -- Found KF5Notifications: /home/jenkins/install-prefix/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.50.0") -- Found KF5WindowSystem: /home/jenkins/install-prefix/lib64/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.50.0") -- Found KF5: success (found suitable version "5.50.0", minimum required is "5.42.0") found components:  Config CoreAddons DBusAddons DocTools I18n IconThemes Init ItemViews KIO NewStuff Notifications WindowSystem -- Found KF5SysGuard: /home/jenkins/install-prefix/lib64/cmake/KF5SysGuard/KF5SysGuardConfig.cmake (found version "5.13.80") -- Found KF5: success (found version "5.13.80") found components:  SysGuard -- Found Sensors: /usr/include  -- Looking for include file sys/inotify.h-- Looking for include file sys/inotify.h - found-- The following OPTIONAL packages have been found: * Sensors   Allows to show sensor information-- The following REQUIRED packages have been found: * ECM (required version >= 5.42.0) * Qt5Core * Qt5Gui (required version >= 5.10.1) * Qt5Widgets * Qt5 (required version >= 5.9.0) * KF5Config (required version >= 5.42.0) * KF5CoreAddons (required version >= 5.42.0) * KF5DBusAddons (required version >= 5.42.0) * KF5DocTools (required version >= 5.42.0) * Gettext * KF5I18n (required version >= 5.42.0) * KF5IconThemes (required version >= 5.42.0) * KF5Init (required version >= 5.42.0) * KF5ItemViews (required version >= 5.42.0) * KF5KIO (required version >= 5.42.0) * KF5NewStuff (required version >= 5.42.0) * KF5Notifications (required version >= 5.42.0) * KF5WindowSystem (required version >= 5.42.0) * KF5SysGuard * KF5-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Plasma ksysguard kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Plasma ksysguard kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project ksysguard --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target doc-index-cache-bz2Scanning dependencies of target kdeinit_ksysguard_autogenScanning dependencies of target libksysguardd_autogen[  1%] Generating index.cache.bz2[  3%] Automatic MOC for target kdeinit_ksysguard[  4%] Automatic MOC for

KDE CI: Plasma plasma-sdk kf5-qt5 SUSEQt5.10 - Build # 28 - Failure!

2018-08-14 Thread CI System 
BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-sdk%20kf5-qt5%20SUSEQt5.10/28/
 Project:
Plasma plasma-sdk kf5-qt5 SUSEQt5.10
 Date of build:
Wed, 15 Aug 2018 01:51:36 +
 Build duration:
3 min 26 sec and counting
   CONSOLE OUTPUT
  [...truncated 138.67 KB...] * KF5ConfigWidgets (required version >= 5.42.0) * KF5CoreAddons (required version >= 5.42.0) * KF5DBusAddons (required version >= 5.42.0) * KF5Declarative (required version >= 5.42.0) * Gettext * KF5I18n (required version >= 5.42.0) * KF5IconThemes (required version >= 5.42.0) * KF5KIO (required version >= 5.42.0) * ECM (required version >= 1.6.0) * Qt5Core * KF5Plasma (required version >= 5.42.0) * KF5PlasmaQuick (required version >= 5.42.0) * KF5Service (required version >= 5.42.0) * KF5TextEditor (required version >= 5.42.0) * KF5WidgetsAddons (required version >= 5.42.0) * KF5DocTools (required version >= 5.42.0) * KF5 (required version >= 5.42.0) * Qt5Test, Required for building tests   Required for tests * Qt5 (required version >= 5.9.0)-- Configuring done-- Generating done-- Build files have been written to: /home/jenkins/workspace/Plasma plasma-sdk kf5-qt5 SUSEQt5.10/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[Plasma plasma-sdk kf5-qt5 SUSEQt5.10] Running shell script+ python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project plasma-sdk --branchGroup kf5-qt5 --platform SUSEQt5.10 --usingInstall /home/jenkins//install-prefix/Scanning dependencies of target org.kde.plasma.cuttlefish-packages-metadata-jsonScanning dependencies of target cuttlefish_autogen[  4%] Automatic MOC for target cuttlefish[  4%] Generating org.kde.plasma.cuttlefish-packages-metadata.jsonUnknown property type for key "GenericName" -> falling back to stringUnknown property type for key "GenericName[ca]" -> falling back to stringUnknown property type for key "GenericName[ca@valencia]" -> falling back to stringUnknown property type for key "GenericName[cs]" -> falling back to stringUnknown property type for key "GenericName[da]" -> falling back to stringUnknown property type for key "GenericName[de]" -> falling back to stringUnknown property type for key "GenericName[el]" -> falling back to stringUnknown property type for key "GenericName[en_GB]" -> falling back to stringUnknown property type for key "GenericName[es]" -> falling back to stringUnknown property type for key "GenericName[et]" -> falling back to stringUnknown property type for key "GenericName[eu]" -> falling back to stringUnknown property type for key "GenericName[fi]" -> falling back to stringUnknown property type for key "GenericName[fr]" -> falling back to stringUnknown property type for key "GenericName[gl]" -> falling back to stringUnknown property type for key "GenericName[hu]" -> falling back to stringUnknown property type for key "GenericName[it]" -> falling back to stringUnknown property type for key "GenericName[ko]" -> falling back to stringUnknown property type for key "GenericName[nl]" -> falling back to stringUnknown property type for key "GenericName[nn]" -> falling back to stringUnknown property type for key "GenericName[pl]" -> falling back to stringUnknown property type for key "GenericName[pt]" -> falling back to stringUnknown property type for key "GenericName[pt_BR]" -> falling back to stringUnknown property type for key "GenericName[ru]" -> falling back to stringUnknown property type for key "GenericName[sk]" -> falling back to stringUnknown property type for key "GenericName[sl]" -> falling back to stringUnknown property type for key "GenericName[sr]" -> falling back to stringUnknown property type for key "GenericName[sr@ijekavian]" -> falling back to stringUnknown property type for key "GenericName[sr@ijekavianlatin]" -> falling back to stringUnknown property type for key "GenericName[sr@latin]" -> falling back to stringUnknown property type for key "GenericName[sv]" -> falling back to stringUnknown property type for key "GenericName[tr]" -> falling back to stringUnknown property type for key "GenericName[uk]" -> falling back to stringUnknown property type for key "GenericName[x-test]" -> falling back to stringUnknown property type for key "GenericName[zh_CN]" -> falling back to stringUnknown property type for key "GenericName[zh_TW]" -> falling back to stringUnknown property type for key "X-Plasma-MainScript" -> falling back to stringGenerated  "/home/jenkins/workspace/Plasma plasma-sdk kf5-qt5 SUSEQt5.10/build/cuttlefish/org.kde.plasma.cuttlefish-packages-metadata.json" [  4%] Built target org.kde.plasma.cuttlefish-packages-metadata-jsonScanning dependencies of target cuttlefishplugin_autogen[  6%] Generating cuttlefishplugin.jsonAbout to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/ktexteditorplugin.desktop"Generated  "/home/jenkins/workspace/Plasma plasma-sdk kf5-qt5

D14830: Add "Display Configuration" context menu entry on the desktop

2018-08-14 Thread Andres Betts 
abetts added a comment.


  In D14830#308870 , @davidedmundson 
wrote:
  
  > > about how having this option is stupid and doesn't fit in here and bla 
bla that always emerges when this entry is proposed or talked about.
  >
  > Being off by default does not replace code always needing a justification 
behind it. I've still to hear a valid one.
  >
  > Note also that feedback comes from before the osd and the upcoming applet 
that you've written.
  
  
  This could be good whenever we have situations where the desktop locks and 
your remaining options to work on your screen are to launch it using right 
click. Interestingly enough, this category is also something that the other 
major OSs also provide. I see the value.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14830

To: broulik, #plasma, #vdg, fischbach
Cc: davidedmundson, abetts, romangg, fabianr, ngraham, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D7087: Add "Copy Info" button to the About System KCM

2018-08-14 Thread Nathaniel Graham 
ngraham added inline comments.

INLINE COMMENTS

> dhaumann wrote in Module.cpp:162
> Is "Distro" a proper English term? Should it meaybe read "Distribution"?

"Distro" is slang, but very common. I'm not sure "Distribution" is much better 
if were considering average people. They would consider the software on their 
computer to be an "Operating System."

For that matter, distros themselves might appreciate being referred to as 
operating systems here. Perhaps we should use that term instead.

REPOSITORY
  R102 KInfoCenter

BRANCH
  arcpatch-D7087_1

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann, rkflx
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, 
mart

D7087: Add "Copy Info" button to the About System KCM

2018-08-14 Thread Dominik Haumann 
dhaumann accepted this revision.
dhaumann added a comment.
This revision is now accepted and ready to land.


  Ok from my side, although it still *feels* a bit messy :-)
  
  - please consider using QVector before committing
  - possibly fix the "Distro" thing, if applicable

INLINE COMMENTS

> Module.cpp:162
>  
> +const auto dummyDistroDescriptionLabel = new QLabel(i18nc("@title:row", 
> "Distro:"), this);
> +dummyDistroDescriptionLabel->hide();

Is "Distro" a proper English term? Should it meaybe read "Distribution"?

> Module.h:73
> +
> +QList > labelsForClipboard;
> +

For future: Please pretty much always prefer QVector over QList.

REPOSITORY
  R102 KInfoCenter

BRANCH
  arcpatch-D7087_1

REVISION DETAIL
  https://phabricator.kde.org/D7087

To: gregormi, ngraham, dhaumann, rkflx
Cc: rkflx, dhaumann, ltoscano, sebas, elvisangelaccio, cfeck, plasma-devel, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, 
mart

D14836: Kicker: Reset re-used menu width to default one

2018-08-14 Thread Nathaniel Graham 
ngraham added a reviewer: hein.
ngraham added a comment.


  Works well for me, FWIW. But I seem to remember that that the original patch 
had some logic specifically to enable this behavior that we're now trying to 
turn off... can we now simplify all that?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14836

To: aacid, hein
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Re: Upcoming reorganisation of the CI system

2018-08-14 Thread Ben Cooksley 
On Tue, 14 Aug 2018, 17:09 Christoph Feck,  wrote:

> On 14.08.2018 15:03, Ben Cooksley wrote:
> > Currently CI jobs are all created within a flat namespace, meaning
> > that it is quite difficult to view the overall status of an individual
> > project. Additionally, it creates the issue that the main default view
> > can take a significant amount of time to load.
> >
> > To resolve this we intend to shift everything within Folders in
> > Jenkins. These folders will be structured in the form of Product /
> > Project / 
>
> Will we still be able to see the status of all Applications (or all
> Frameworks) without clicking hundreds of subfolders? This is useful to
> get an overview before doing releases.
>

Yes, with a recursive view this will still be possible - it just won't be
the default landing page.


> Christoph Feck
>

Cheers,
Ben

>

D14830: Add "Display Configuration" context menu entry on the desktop

2018-08-14 Thread David Edmundson 
davidedmundson added a comment.


  > about how having this option is stupid and doesn't fit in here and bla bla 
that always emerges when this entry is proposed or talked about.
  
  Being off by default does not replace code always needing a justification 
behind it. I've still to hear a valid one.
  
  Note also that feedback comes from before the osd and the upcoming applet 
that you've written.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14830

To: broulik, #plasma, #vdg, fischbach
Cc: davidedmundson, abetts, romangg, fabianr, ngraham, plasma-devel, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

Re: Upcoming reorganisation of the CI system

2018-08-14 Thread Christoph Feck 

On 14.08.2018 15:03, Ben Cooksley wrote:

Currently CI jobs are all created within a flat namespace, meaning
that it is quite difficult to view the overall status of an individual
project. Additionally, it creates the issue that the main default view
can take a significant amount of time to load.

To resolve this we intend to shift everything within Folders in
Jenkins. These folders will be structured in the form of Product /
Project / 


Will we still be able to see the status of all Applications (or all 
Frameworks) without clicking hundreds of subfolders? This is useful to 
get an overview before doing releases.


Christoph Feck

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

2018-08-14 Thread Alexander Volkov 
volkov added inline comments.

INLINE COMMENTS

> broulik wrote in networkmodel.cpp:220
> Would it be better to only request the data when the statistics are open to 
> avoid wakeups and processing?

Yes, good point.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D14835

To: volkov, #plasma, jgrulich
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

2018-08-14 Thread Kai Uwe Broulik 
broulik added inline comments.

INLINE COMMENTS

> networkmodel.cpp:220
> +auto deviceStatistics = device->deviceStatistics();
> +deviceStatistics->setRefreshRateMs(2000);
> +connect(deviceStatistics.data(), 
> ::DeviceStatistics::rxBytesChanged, this, [this, 
> device](qulonglong rxBytes) {

Would it be better to only request the data when the statistics are open to 
avoid wakeups and processing?

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D14835

To: volkov, #plasma, jgrulich
Cc: broulik, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14836: Kicker: Reset re-used menu width to default one

2018-08-14 Thread Albert Astals Cid 
aacid created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
aacid requested review of this revision.

REVISION SUMMARY
  BUGS: 397206

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14836

AFFECTED FILES
  applets/kicker/package/contents/ui/ItemListView.qml

To: aacid
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14835: Use NetworkManager::DeviceStatistics instead of Plasma data engine

2018-08-14 Thread Alexander Volkov 
volkov created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
volkov requested review of this revision.

REVISION SUMMARY
  It's more correct to get information about devices from a single
  source, i.e. from NetworkManager. Besides it allows to show the
  total number of received/transmitted bytes instead of the current
  speed, which is more useful for the user. The current speed can
  still be seen on the graph.
  
  This change requires NetworkManagerQt 5.50, because of the fixed
  DevicesStatistics::setRefreshRateMs().

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14835

AFFECTED FILES
  CMakeLists.txt
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/TrafficMonitor.qml
  libs/models/networkmodel.cpp
  libs/models/networkmodel.h
  libs/models/networkmodelitem.cpp
  libs/models/networkmodelitem.h

To: volkov
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14830: Add "Display Configuration" context menu entry on the desktop

2018-08-14 Thread Nathaniel Graham 
ngraham added subscribers: fabianr, romangg, abetts.
ngraham added a comment.


  In D14830#308703 , @broulik wrote:
  
  > In D14830#308693 , @ngraham 
wrote:
  >
  > > The text needs to start with a verb and end with an ellipsis, E.g. 
"Configure Display Settings..." or even "Configure Displays..."
  >
  >
  > According to HIG:
  >
  > > Do not use an ellipsis for selections which […] do not require user input 
(such as configuration dialogs).
  > >  […]
  > >  Do not use an ellipsis for the following menu items and buttons:
  > >  […]
  > > Preferences
  
  
  In that case, we're seemingly violating this literally everywhere. :p I'll 
talk to @romangg and @fabianr and @abetts about this guideline, considering 
that it's totally ignored.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14830

To: broulik, #plasma, #vdg, fischbach
Cc: abetts, romangg, fabianr, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D14830: Add "Display Configuration" context menu entry on the desktop

2018-08-14 Thread Kai Uwe Broulik 
broulik added a comment.


  In D14830#308693 , @ngraham wrote:
  
  > The text needs to start with a verb and end with an ellipsis, E.g. 
"Configure Display Settings..." or even "Configure Displays..."
  
  
  According to HIG:
  
  > Do not use an ellipsis for selections which […] do not require user input 
(such as configuration dialogs).
  >  […]
  >  Do not use an ellipsis for the following menu items and buttons:
  >  […]
  > Preferences
  
  
  
  > I would be in favor of having this on by default.
  
  I don't really care either, I just want to avoid a stupid exhausting 
pointless discussion about how having this option is stupid and doesn't fit in 
here and bla bla that always emerges when this entry is proposed or talked 
about.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14830

To: broulik, #plasma, #vdg, fischbach
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14830: Add "Display Configuration" context menu entry on the desktop

2018-08-14 Thread Nathaniel Graham 
ngraham added a comment.


  The text needs to start with a verb and end with an ellipsis, E.g. "Configure 
Display Settings..." or even "Configure Displays..."
  
  ("Configure Desktop" should also have an ellipsis)
  
  FWIW, I would be in favor of having this on by default. The context menu is 
an accelerator for experts, and I don't see the harm in putting this in there.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14830

To: broulik, #plasma, #vdg, fischbach
Cc: ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14830: Add "Display Configuration" context menu entry on the desktop

2018-08-14 Thread Kai Uwe Broulik 
broulik created this revision.
broulik added reviewers: Plasma, VDG, fischbach.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  One of LiMux client's requirements is for display configuration to be easily 
accessible.
  Adding a "Display Configuration" context menu entry which is widely known by 
being present on another operating system aids in users finding those settings.
  It also gets asked for occasionally by users on the internet.
  Since this has been quite a controversial topic coming up every couple of 
years, the entry is off by default but can be enabled by the user if so desired 
or by system administrators using desktop scripting.

TEST PLAN
  - Only shows up if kscreen is installed
  - Doesn't show up if restricted by KIOSK
  - Enabling and disabling works
  - Clicking it opens the screen settings
  
  Context Menu
  F6192834: Screenshot_20180814_150003.png 

  Menu Settings (Configure Desktop → Mouse Actions → Standard Menu → [Settings 
button])
  F6192836: Screenshot_20180814_150041.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14830

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h

To: broulik, #plasma, #vdg, fischbach
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

Upcoming reorganisation of the CI system

2018-08-14 Thread Ben Cooksley 
Hi all,

Currently CI jobs are all created within a flat namespace, meaning
that it is quite difficult to view the overall status of an individual
project. Additionally, it creates the issue that the main default view
can take a significant amount of time to load.

To resolve this we intend to shift everything within Folders in
Jenkins. These folders will be structured in the form of Product /
Project / 

If this creates issues for anyone, or if anyone has any questions
regarding this, please let me know.

At this stage it is intended that we will keep all build history for
jobs on the system (although downtime will be needed in order to allow
for the changeover).

Thanks,
Ben Cooksley
KDE Sysadmin

D14822: Use QJSValue as method parameter type for the scripting interface

2018-08-14 Thread Fabian Vogt 
fvogt added a comment.


  A different approach of fixing this is to do something like
  
if(value.userType() == qMetaTypeId())
value = value.value().toVariant();
  
  in every function for every QVariant parameter. Advantages are that it's more 
obvious and the function's interface does not change.
  Disadvantages are that it has more overhead and more lines of code.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14822

To: fvogt, #plasma
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14822: Use QJSValue as method parameter type for the scripting interface

2018-08-14 Thread Fabian Vogt 
fvogt added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in applet.cpp:139
> So writeEntry gets QJSValue& now why you call again toVariant(), here 
> everywhere else.

KConfigGroup != ConfigGroup. d->configGroup is from kconfig and does not take 
QJSValue. That's the core of the bugfix.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14822

To: fvogt, #plasma
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14822: Use QJSValue as method parameter type for the scripting interface

2018-08-14 Thread Anthony Fieroni 
anthonyfieroni added inline comments.

INLINE COMMENTS

> applet.cpp:139
>  
> -d->configGroup.writeEntry(key, value);
> +d->configGroup.writeEntry(key, value.toVariant());
>  d->configDirty = true;

So writeEntry gets QJSValue& now why you call again toVariant(), here 
everywhere else.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D14822

To: fvogt, #plasma
Cc: anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D14822: Use QJSValue as method parameter type for the scripting interface

2018-08-14 Thread Fabian Vogt 
fvogt created this revision.
fvogt added a reviewer: Plasma.
Herald added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  If a slot or Q_INVOKABLE has a QVariant as parameter and gets called
  from a QJSEngine's script, it receives a QJSValue wrapped as QVariant.
  To get a QVariant with the actual value wrapped, calling QJSValue::toVariant
  is necessary.
  
  I'm not entirely sure whether this is intentional behaviour of QJSEngine, but
  even if it's a bug we'll have to workaround it.
  
  BUG: 397338

TEST PLAN
  I have favorites in kickoff again.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D14822

AFFECTED FILES
  shell/scripting/applet.cpp
  shell/scripting/applet.h
  shell/scripting/configgroup.cpp
  shell/scripting/configgroup.h
  shell/scripting/scriptengine_v1.cpp

To: fvogt, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart