D16651: honor flat property for buttons

2018-11-03 Thread Alexander Stippich
astippich created this revision. astippich added reviewers: ngraham, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. astippich requested review of this revision. REVISION SUMMARY The flat property of buttons is currently not taken into account for the desktop

D16638: Handle focus in the window switcher

2018-11-03 Thread Kai Uwe Broulik
broulik added inline comments. INLINE COMMENTS > WindowSwitcher.qml:48 > focus: true > +Component.onCompleted: forceActiveFocus() > Doesn't the `focus: true` imply that already? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D16638

D16638: Handle focus in the window switcher

2018-11-03 Thread Frederik Gladhorn
gladhorn created this revision. gladhorn added reviewers: davidedmundson, kwin, chempfling. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gladhorn requested review of this revision. REVISION SUMMARY KWin does not actually give proper window focus to the tabbox. But

D14830: Add "Configure Displays" context menu entry on the desktop

2018-11-03 Thread gregormi
gregormi added a comment. In D14830#345210 , @broulik wrote: > Note that Microsoft removed that option in Vista in favor of a "Personalize" option but brought a dedicated Screen configuration entry back in Windows 7 which has remained to this

D16635: Add declarative plugin

2018-11-03 Thread Nicolas Fella
nicolasfella created this revision. nicolasfella added reviewers: drosca, broulik, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Make it usable from QML TEST PLAN Use SinkModel from QML

D16277: [ksmserver] Split xsession logout and shutdown into separate classes

2018-11-03 Thread David Edmundson
davidedmundson added a comment. https://phabricator.kde.org/T9779 Everything related to x is in logout. shutdown contains everything else and the new public interface. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D16277 To:

D16622: [Plasmoid] Clean up layout

2018-11-03 Thread Nathaniel Graham
ngraham added a comment. In D16622#353191 , @Codezela wrote: > Can we make the search box and the font on it bigger > Like Mac os spotlight We are just using the standard text box for this, so to make it bigger, we have only

D16277: [ksmserver] Split xsession logout and shutdown into separate classes

2018-11-03 Thread Roman Gilg
romangg added a comment. The functional split is kind of confusing. Some functions in logout.cpp still do shutdown related tasks when looking at their names, other in shutdown.cpp do logout things. To me this whole distinction between shutdown and logout seems kind of artificial. In

D16622: [Plasmoid] Clean up layout

2018-11-03 Thread Hazem Salem
Codezela added a comment. Can we make the search box and the font on it bigger Like Mac os spotlight REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D16622 To: ngraham, #plasma, broulik, #vdg Cc: Codezela, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai,

D16628: [ksmserver] Remove blocking call introspecting KDED

2018-11-03 Thread David Edmundson
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY We don't need to introspect at runtime as KDED installs the interface XML