D16530: Drop X11 core fonts code from startkde/startplasma

[Stefan Brüns]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:5374513266ee: Drop X11 core fonts code from 
startkde/startplasma (authored by bruns).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16530?vs=44499&id=45152

REVISION DETAIL
  https://phabricator.kde.org/D16530

AFFECTED FILES
  startkde/startkde.cmake
  startkde/startplasma.cmake

To: bruns, #plasma, fvogt, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[Nathaniel Graham]

ngraham added a comment.


  OK, will do!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: romangg, davidedmundson, rizzitello, abetts, pstefan, broulik, rikmills, 
filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D16031: [SDDM theme] remove blur and increase UI contrast so that it's not required

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Why are there hardcoded colours?  If the font is black then surely the 
outline needs to be white?
  
  There's two parts to this patch:
  
  - Improving readability on any background, blurred or not, on 
login/lock/logout.
  
  - Changing the login visually
  
  The first part is non-controversial. They're iterative design changes. If you 
split it, I'll happily ship the 1st part (with hardcoded colours fixed)

INLINE COMMENTS

> Main.qml:322
> +}
> +height: units.gridUnit * 2
> +

This is now choosing an arbitrary size and hoping the contents happen to be 
smaller.

Generally (if possible) you want views to fit contents, not squish contents to 
view.

i.e

height: theInnerLayout.implicitHeight

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16031

To: ngraham, #vdg, #plasma, rizzitello, davidedmundson
Cc: romangg, davidedmundson, rizzitello, abetts, pstefan, broulik, rikmills, 
filipf, rooty, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D16771: Fix warning

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Now if appIcon isn't defined, it will set the property as undefined.
  
file:///home/apol/devel/kde5/share/plasma/plasmoids/org.kde.plasma.notifications/contents/ui/NotificationDelegate.qml:114:
 ReferenceError: appIcon is not defined

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16771

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationDelegate.qml

To: apol, #plasma
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16530: Drop X11 core fonts code from startkde/startplasma

[David Edmundson]

davidedmundson added a comment.


  It's always tricky when you remove old stuff; we don't want to risk any 
changes that could affect a usecase no matter how obscure.
  It's not something to rush or do lightly.
  
  However, your rationale makes sense. There's an additional pieces of 
information that I think helps me reach a decision.
  
  kfontinst (the font install kcm) does call mkfontscale/mkfontdir
  
  If they don't use kfontinst to install fonts that's their problem. No reason 
for us to do it on load
  
  Ship it!
  
  (FWIW, here is when it was added: 
https://websvn.kde.org/?view=revision&revision=37745)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16530

To: bruns, #plasma, fvogt, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16715: make global menu minimize state aware

[Michail Vourlakos]

mvourlakos updated this revision to Diff 45141.
mvourlakos added a comment.


  - mage global menu screen aware

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16715?vs=44998&id=45141

BRANCH
  appMenuScreen

REVISION DETAIL
  https://phabricator.kde.org/D16715

AFFECTED FILES
  applets/appmenu/package/contents/ui/main.qml
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: mvourlakos, #plasma, broulik
Cc: trmdi, apol, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D16768: mage global menu screen aware

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added reviewers: Plasma, broulik.
mvourlakos added a project: Plasma.
mvourlakos requested review of this revision.

REVISION SUMMARY
  --a new screenGeometry property is added in the
  AppMenuModel in order to be used for filtering
  windows based on their geometry.
  
  BUG: 384895
  Depends on D16715 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  appMenuScreen

REVISION DETAIL
  https://phabricator.kde.org/D16768

AFFECTED FILES
  applets/appmenu/package/contents/ui/main.qml
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: mvourlakos, #plasma, broulik
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16715: make global menu minimize state aware

[Michail Vourlakos]

mvourlakos updated this revision to Diff 45142.
mvourlakos added a comment.


  fix

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16715?vs=45141&id=45142

BRANCH
  appMenuMinimize

REVISION DETAIL
  https://phabricator.kde.org/D16715

AFFECTED FILES
  applets/appmenu/package/contents/ui/main.qml
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: mvourlakos, #plasma, broulik
Cc: trmdi, apol, anthonyfieroni, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D16404: [Bookmarks Runner] Cleanup tests CMakeList

[Stefan Brüns]

bruns added a comment.


  Anyone?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16404

To: bruns, #frameworks
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16530: Drop X11 core fonts code from startkde/startplasma

[Stefan Brüns]

bruns added a comment.


  In D16530#355078 , @fvogt wrote:
  
  > Looks good to me, but I don't know enough about old X11 stuff like this to 
accept it.
  
  
  @fvogt - maybe you can poke a coworker?
  
  Someone else?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16530

To: bruns, #plasma, fvogt, davidedmundson
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16170: [Device Notifier] Restore busy indicator

[Thomas Surrel]

thsurrel added a comment.


  It is awaiting a review.
  As I said in an older comment, I don't know if there are some drawbacks to 
not do polling, but i have been using this patch for a while and it works well.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16170

To: thsurrel, #plasma, #vdg, broulik, bruns
Cc: cfeck, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16170: [Device Notifier] Restore busy indicator

[Christoph Feck]

cfeck added a comment.


  What is the status of this patch?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16170

To: thsurrel, #plasma, #vdg, broulik, bruns
Cc: cfeck, ngraham, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16750: Various grammar and capitalization fixes for UI consistency

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> appmenu.desktop:3
>  Type=Service
> -Name=Application menus daemon
> +Name=Application Menu Daemon
>  Name[ar]=عفريت قوائم التطبيقات

While we're touching this, I wonder if it even makes sense to include "daemon" 
in the string.

> appmenu.desktop:12
>  Name[el]=Δαίμων για τα μενού των εφαρμογών
> -Name[en_GB]=Application menus daemon
> +Name[en_GB]=Application Menu Daemon
>  Name[es]=Demonio de menús de aplicación

Revert this change; it happens automatically.

> appmenu.desktop:49
>  Name[uk]=Фонова служба меню програм
> -Name[x-test]=xxApplication menus daemonxx
> +Name[x-test]=xxApplication Menu Daemonxx
>  Name[zh_CN]=应用程序菜单守护程序

Revert this change; it happens automatically.

> appmenu.desktop:61
>  Comment[el]=Μεταφέρει το μενού της εφαρμογής στην επιφάνεια εργασίας
> -Comment[en_GB]=Transfers application's menu to the desktop
> +Comment[en_GB]=Transfers an application's menu to the desktop
>  Comment[es]=Transfiere el menú de aplicaciones al escritorio

Revert this change; it happens automatically.

> appmenu.desktop:98
>  Comment[uk]=Передає меню програм на стільницю
> -Comment[x-test]=xxTransfers application's menu to the desktopxx
> +Comment[x-test]=xxTransfers an application's menu to the desktopxx
>  Comment[zh_CN]=将应用程序的菜单转移到桌面上

Revert this change; it happens automatically.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16750

To: snoordhuis, #vdg, #localization, ngraham
Cc: ngraham, ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16750: Various grammar and capitalization fixes for UI consistency

[Luigi Toscano]

ltoscano added a comment.


  I can't check the change against the guidelines right now, but please change 
only the original strings. Any translation (including en_GB and x-test) is 
handled elsewhere and it will be overwritten.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16750

To: snoordhuis, #vdg, #localization
Cc: ltoscano, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16628: [ksmserver] Remove blocking call introspecting KDED

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c8ed48fc1a2a: [ksmserver] Remove blocking call 
introspecting KDED (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16628?vs=44752&id=45119

REVISION DETAIL
  https://phabricator.kde.org/D16628

AFFECTED FILES
  CMakeLists.txt
  ksmserver/CMakeLists.txt
  ksmserver/startup.cpp

To: davidedmundson, #plasma, romangg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16657: [kioslave/desktop] Remove more QDBusInterface

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c29d2528c184: [kioslave/desktop] Remove more 
QDBusInterface (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16657?vs=44820&id=45120

REVISION DETAIL
  https://phabricator.kde.org/D16657

AFFECTED FILES
  kioslave/desktop/CMakeLists.txt
  kioslave/desktop/kio_desktop.cpp

To: davidedmundson, #plasma, apol
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D16277: [ksmserver] Split xsession logout and shutdown into separate classes

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:008d58cfc60d: [ksmserver] Split xsession logout and 
shutdown into separate classes (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D16277?vs=44559&id=45118

REVISION DETAIL
  https://phabricator.kde.org/D16277

AFFECTED FILES
  ksmserver/CMakeLists.txt
  ksmserver/logout.cpp
  ksmserver/main.cpp
  ksmserver/org.kde.Shutdown.xml
  ksmserver/server.cpp
  ksmserver/server.h
  ksmserver/shutdown.cpp
  ksmserver/shutdown.h

To: davidedmundson, #plasma, apol, romangg
Cc: romangg, apol, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D16082: Notify headphone being plugged in on some hardware

[David Rosca]

drosca added a comment.


  In D16082#356111 , @thsurrel wrote:
  
  > So now the question is whether it is acceptable to show a headphone on the 
OSD when we could have been plugging something else in the jack.
  
  
  It will already show in device list as "headphones" regardless of what is 
actually plugged in, so it is fine by me.
  VDG should give the final ack though.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D16082

To: thsurrel, #plasma, #vdg, drosca
Cc: ngraham, broulik, nicolasfella, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16082: Notify headphone being plugged in on some hardware

[Thomas Surrel]

thsurrel added a comment.


  In D16082#356109 , @drosca wrote:
  
  > What do you mean with "sink change"? Do you mean that plugging in something 
in jack will trigger adding new sink (device) to Pulseaudio? That will only be 
the case for USB headphones, but for jacks it will always just switch port.
  
  
  Ok, thanks for the explanation, I did not know that. I assumed that depending 
on the hardware you could either receive a sink change or a port change.
  
  So now the question is whether it is acceptable to show a headphone on the 
OSD when we could have been plugging something else in the jack.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D16082

To: thsurrel, #plasma, #vdg, drosca
Cc: ngraham, broulik, nicolasfella, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16082: Notify headphone being plugged in on some hardware

[David Rosca]

drosca added a comment.


  In D16082#356099 , @thsurrel wrote:
  
  > So, it seems that pulseaudio can not tell the difference what we are 
plugging in the jack connector on a laptop, but I guess it must be the same 
behavior with computers that get a sink change when switching from internal 
speaker to external ?
  
  
  What do you mean with "sink change"? Do you mean that plugging in something 
in jack will trigger adding new sink (device) to Pulseaudio? That will only be 
the case for USB headphones, but for jacks it will always just switch port.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D16082

To: thsurrel, #plasma, #vdg, drosca
Cc: ngraham, broulik, nicolasfella, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16082: Notify headphone being plugged in on some hardware

[Thomas Surrel]

thsurrel added a comment.


  So, it seems that pulseaudio can not tell the difference what we are plugging 
in the jack connector on a laptop, but I guess it must be the same behavior 
with computers that get a sink change when switching from internal speaker to 
external ?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D16082

To: thsurrel, #plasma, #vdg, drosca
Cc: ngraham, broulik, nicolasfella, plasma-devel, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D16750: Various grammar and capitalization fixes for UI consistency

[Samuel Noordhuis]

snoordhuis created this revision.
snoordhuis added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
snoordhuis requested review of this revision.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D16750

AFFECTED FILES
  appmenu/appmenu.desktop
  krunner/view.cpp

To: snoordhuis, #vdg
Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart