D18646: [Colors KCM] Add search and filter

[Eike Hein]

hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.


  LGTM aside from the minor naming nitpick.

INLINE COMMENTS

> filterproxymodel.cpp:31
> +
> +void FilterProxyModel::setSourceModelProxy(QAbstractItemModel *sourceModel)
> +{

Why did you call this `setSourceModelProxy`? `QSortFilterModel::setSourceModel` 
is virtual, you could do the emit in a reimpl?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D18646

To: broulik, #plasma, #vdg, hein
Cc: hein, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 104 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/104/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Tue, 19 Feb 2019 05:41:25 +
 Build duration:
1 min 29 sec and counting
   CONSOLE OUTPUT
  [...truncated 419 lines...][2019-02-19T05:42:53.516Z]   CMakeLists.txt:26 (find_package)[2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z] -- Could NOT find KF5KCMUtils , checked the following files:[2019-02-19T05:42:53.516Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (version 5.55.0)[2019-02-19T05:42:53.516Z] /home/jenkins/install-prefix/lib/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (version 5.55.0)[2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-19T05:42:53.516Z]   Could not find a configuration file for package "KF5TextWidgets" that is[2019-02-19T05:42:53.516Z]   compatible with requested version "5.56.0".[2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z]   The following configuration files were considered but not accepted:[2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5TextWidgets/KF5TextWidgetsConfig.cmake, version: 5.55.0[2019-02-19T05:42:53.516Z] /home/jenkins/install-prefix/lib/cmake/KF5TextWidgets/KF5TextWidgetsConfig.cmake, version: 5.55.0[2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z] Call Stack (most recent call first):[2019-02-19T05:42:53.516Z]   CMakeLists.txt:26 (find_package)[2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z] -- Could NOT find KF5TextWidgets , checked the following files:[2019-02-19T05:42:53.516Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5TextWidgets/KF5TextWidgetsConfig.cmake (version 5.55.0)[2019-02-19T05:42:53.516Z] /home/jenkins/install-prefix/lib/cmake/KF5TextWidgets/KF5TextWidgetsConfig.cmake (version 5.55.0)[2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-19T05:42:53.516Z]   Could not find a configuration file for package "KF5KDELibs4Support" that[2019-02-19T05:42:53.516Z]   is compatible with requested version "5.56.0".[2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z]   The following configuration files were considered but not accepted:[2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5KDELibs4Support/KF5KDELibs4SupportConfig.cmake, version: 5.55.0[2019-02-19T05:42:53.516Z] /home/jenkins/install-prefix/lib/cmake/KF5KDELibs4Support/KF5KDELibs4SupportConfig.cmake, version: 5.55.0[2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z] Call Stack (most recent call first):[2019-02-19T05:42:53.516Z]   CMakeLists.txt:26 (find_package)[2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z] -- Could NOT find KF5KDELibs4Support , checked the following files:[2019-02-19T05:42:53.516Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5KDELibs4Support/KF5KDELibs4SupportConfig.cmake (version 5.55.0)[2019-02-19T05:42:53.516Z] /home/jenkins/install-prefix/lib/cmake/KF5KDELibs4Support/KF5KDELibs4SupportConfig.cmake (version 5.55.0)[2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-19T05:42:53.516Z]   Could not find a configuration file for package "KF5Crash" that is[2019-02-19T05:42:53.516Z]   compatible with requested version "5.56.0".[2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z]   The following configuration files were considered but not accepted:[2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Crash/KF5CrashConfig.cmake, version: 5.55.0[2019-02-19T05:42:53.516Z] /home/jenkins/install-prefix/lib/cmake/KF5Crash/KF5CrashConfig.cmake, version: 5.55.0[2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z] Call Stack (most recent call first):[2019-02-19T05:42:53.516Z]   CMakeLists.txt:26 (find_package)[2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z] -- Could NOT find KF5Crash , checked the following files:[2019-02-19T05:42:53.516Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Crash/KF5CrashConfig.cmake (version 5.55.0)[2019-02-19T05:42:53.516Z] /home/jenkins/install-prefix/lib/cmake/KF5Crash/KF5CrashConfig.cmake (version 5.55.0)[2019-02-19T05:42:53.516Z] [2019-02-19T05:42:53.516Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-19T05:42:53.516Z]   Could not find a configuration file for package "KF5GlobalAccel" that is[2019-02-19T05:42:53.516Z]   compatible with requested version 

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

[Noah Davis]

ndavis added a comment.


  In D19148#415123 , @rooty wrote:
  
  > I like this idea, more variety
  >  Especially considering that the default setting doesn't really change, 
just gets renamed essentially?
  
  
  Not quite. Very Small is about the same size as the current Small (git 
master), but I did adjust the opacity to make it more visible. Small is now the 
same size as the current Medium, but with different opacity values. Medium is a 
new size that is between the current size and Large. Large is the same size 
with different opacity. Very Large is a bit smaller with different opacity. 
Smaller sizes start with more opacity than larger sizes to keep smaller sizes 
visible and to keep large sizes from being visually overpowering.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19148

To: ndavis, #vdg, #breeze
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

[Krešimir Čohar]

rooty added a comment.


  I like this idea, more variety
  Especially considering that the default setting doesn't really change, just 
gets renamed essentially?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19148

To: ndavis, #vdg, #breeze
Cc: rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Before, shadow size doubled with each new size until Very Large and the 
smaller shadows were more transparent than the larger shadows. Now shadow size 
increases linearly and smaller shadows start with more opacity so that they 
don't become nearly invisible. The Very Small size was added to allow users to 
continue using big shadows and preserve the original size of Small.

REPOSITORY
  R31 Breeze

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19148

AFFECTED FILES
  kdecoration/breezedecoration.cpp
  kdecoration/breezesettingsdata.kcfg
  kdecoration/config/ui/breezeconfigurationui.ui

To: ndavis, #vdg, #breeze
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19148: Add ShadowVerySmall, linear shadow sizes and set Medium as default size

[Noah Davis]

ndavis updated this revision to Diff 52036.
ndavis added a comment.


  Change default shadow size to medium

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19148?vs=52035=52036

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19148

AFFECTED FILES
  kdecoration/breezedecoration.cpp
  kdecoration/breezesettingsdata.kcfg
  kdecoration/config/ui/breezeconfigurationui.ui

To: ndavis, #vdg, #breeze
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19135: DelegateRecycler: Fix translation using the wrong domain

[Albert Astals Cid]

aacid created this revision.
aacid added a reviewer: mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
aacid requested review of this revision.

REVISION SUMMARY
  Use first KLocalizedContext as contextObject instead of the root one
  
  This way when there's a stack of contexts with KLocalizedContext we get the 
right one

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19135

AFFECTED FILES
  src/delegaterecycler.cpp

To: aacid, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D19134: Multiply radius by 0.5 in calculateBlurStdDev()

[Vlad Zagorodniy]

zzag added a comment.


  Please revert this change.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19134

To: ndavis, #breeze, ngraham
Cc: zzag, davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
mart

D19134: Multiply radius by 0.5 in calculateBlurStdDev()

[David Edmundson]

davidedmundson added a comment.


  > so in order to not break existing shadow
  
  So won't this break existing shadow parameters?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19134

To: ndavis, #breeze, ngraham
Cc: davidedmundson, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19126: block screen filtering for global menu applet

[David Edmundson]

davidedmundson added a comment.


  > For example if the user has set different scale factors between its screens 
is it going to work?
  
  It will not, but there is no UI option for that.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19126

To: mvourlakos, #plasma, davidedmundson, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19134: Multiply radius by 0.5 in calculateBlurStdDev()

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:cd04f42432a6: Multiply radius by 0.5 in 
calculateBlurStdDev() (authored by ndavis).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19134?vs=52016=52020

REVISION DETAIL
  https://phabricator.kde.org/D19134

AFFECTED FILES
  libbreezecommon/breezeboxshadowrenderer.cpp

To: ndavis, #breeze, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19134: Multiply radius by 0.5 in calculateBlurStdDev()

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Makes sense to do this while we're tweaking the appearance of the shadows for 
5.16 anyway.

REPOSITORY
  R31 Breeze

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19134

To: ndavis, #breeze, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19044: [InlineMessage] Do not draw shadows around the message

[Noah Davis]

ndavis added a comment.


  TBH, I like the shadow. Breeze as a widget theme tends to be a bit too flat. 
Here's how it looks with Breeze Dark.F6622189: Screenshot_20190218_172518.png 


REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19044

To: filipf, #vdg, #kirigami, ngraham, mart
Cc: ndavis, mart, abetts, plasma-devel, dkardarakos, apol, davidedmundson, hein

D19077: WIP: Fix long labels not being wrapped

[Filip Fila]

filipf updated this revision to Diff 52018.
filipf added a comment.


  go back to Rectangle as root

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19077?vs=51932=52018

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19077

AFFECTED FILES
  src/qml/main.qml

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19134: Multiply radius by 0.5 in calculateBlurStdDev

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Fix TODO to follow w3.org standard for shadow-blur

REPOSITORY
  R31 Breeze

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19134

AFFECTED FILES
  libbreezecommon/breezeboxshadowrenderer.cpp

To: ndavis, #breeze
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19126: block screen filtering for global menu applet

[Michail Vourlakos]

mvourlakos added a comment.


  In D19126#414920 , @davidedmundson 
wrote:
  
  > If we're going to put in code, lets do:
  >
  >   QPoint windowCentre = info.geometry().center();
  >   if (KWindowSystem::isPlatformX11()) {
  > windowCenter /= qApp->scale();
  >   }
  >
  >
  > I closed the bug because I was quite angry at the user randomly setting 
variables and then not even mentioning it, but we may as well make use of the 
fact that the testing found something.
  
  
  personally I have no opinion whatever you want...
  
  David for the proposed code does it catch all the cases under X11 ?
  For example if the user has set different scale factors between its screens 
is it going to work?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19126

To: mvourlakos, #plasma, davidedmundson, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19126: block screen filtering for global menu applet

[David Edmundson]

davidedmundson added a comment.


  If we're going to put in code, lets do:
  
QPoint windowCentre = info.geometry().center();
if (KWindowSystem::isPlatformX11()) {
  windowCenter /= qApp->scale();
}
  
  I closed the bug because I was quite angry at the user randomly setting 
variables and then not even mentioning it, but we may as well make use of the 
fact that the testing found something.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19126

To: mvourlakos, #plasma, davidedmundson, broulik
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 FreeBSDQt5.12 - Build # 103 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20FreeBSDQt5.12/103/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 18 Feb 2019 20:50:15 +
 Build duration:
43 sec and counting
   CONSOLE OUTPUT
  [...truncated 417 lines...][2019-02-18T20:50:58.183Z]   CMakeLists.txt:26 (find_package)[2019-02-18T20:50:58.183Z] [2019-02-18T20:50:58.183Z] [2019-02-18T20:50:58.183Z] -- Could NOT find KF5KCMUtils , checked the following files:[2019-02-18T20:50:58.183Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (version 5.55.0)[2019-02-18T20:50:58.183Z] /home/jenkins/install-prefix/lib/cmake/KF5KCMUtils/KF5KCMUtilsConfig.cmake (version 5.55.0)[2019-02-18T20:50:58.183Z] [2019-02-18T20:50:58.183Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-18T20:50:58.183Z]   Could not find a configuration file for package "KF5TextWidgets" that is[2019-02-18T20:50:58.183Z]   compatible with requested version "5.56.0".[2019-02-18T20:50:58.183Z] [2019-02-18T20:50:58.183Z]   The following configuration files were considered but not accepted:[2019-02-18T20:50:58.183Z] [2019-02-18T20:50:58.183Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5TextWidgets/KF5TextWidgetsConfig.cmake, version: 5.55.0[2019-02-18T20:50:58.183Z] /home/jenkins/install-prefix/lib/cmake/KF5TextWidgets/KF5TextWidgetsConfig.cmake, version: 5.55.0[2019-02-18T20:50:58.184Z] [2019-02-18T20:50:58.184Z] Call Stack (most recent call first):[2019-02-18T20:50:58.184Z]   CMakeLists.txt:26 (find_package)[2019-02-18T20:50:58.184Z] [2019-02-18T20:50:58.184Z] [2019-02-18T20:50:58.184Z] -- Could NOT find KF5TextWidgets , checked the following files:[2019-02-18T20:50:58.184Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5TextWidgets/KF5TextWidgetsConfig.cmake (version 5.55.0)[2019-02-18T20:50:58.184Z] /home/jenkins/install-prefix/lib/cmake/KF5TextWidgets/KF5TextWidgetsConfig.cmake (version 5.55.0)[2019-02-18T20:50:58.184Z] [2019-02-18T20:50:58.184Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-18T20:50:58.184Z]   Could not find a configuration file for package "KF5KDELibs4Support" that[2019-02-18T20:50:58.184Z]   is compatible with requested version "5.56.0".[2019-02-18T20:50:58.184Z] [2019-02-18T20:50:58.184Z]   The following configuration files were considered but not accepted:[2019-02-18T20:50:58.184Z] [2019-02-18T20:50:58.184Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5KDELibs4Support/KF5KDELibs4SupportConfig.cmake, version: 5.55.0[2019-02-18T20:50:58.184Z] /home/jenkins/install-prefix/lib/cmake/KF5KDELibs4Support/KF5KDELibs4SupportConfig.cmake, version: 5.55.0[2019-02-18T20:50:58.184Z] [2019-02-18T20:50:58.184Z] Call Stack (most recent call first):[2019-02-18T20:50:58.184Z]   CMakeLists.txt:26 (find_package)[2019-02-18T20:50:58.184Z] [2019-02-18T20:50:58.184Z] [2019-02-18T20:50:58.184Z] -- Could NOT find KF5KDELibs4Support , checked the following files:[2019-02-18T20:50:58.184Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5KDELibs4Support/KF5KDELibs4SupportConfig.cmake (version 5.55.0)[2019-02-18T20:50:58.184Z] /home/jenkins/install-prefix/lib/cmake/KF5KDELibs4Support/KF5KDELibs4SupportConfig.cmake (version 5.55.0)[2019-02-18T20:50:58.184Z] [2019-02-18T20:50:58.184Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-18T20:50:58.184Z]   Could not find a configuration file for package "KF5Crash" that is[2019-02-18T20:50:58.184Z]   compatible with requested version "5.56.0".[2019-02-18T20:50:58.184Z] [2019-02-18T20:50:58.184Z]   The following configuration files were considered but not accepted:[2019-02-18T20:50:58.184Z] [2019-02-18T20:50:58.184Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Crash/KF5CrashConfig.cmake, version: 5.55.0[2019-02-18T20:50:58.184Z] /home/jenkins/install-prefix/lib/cmake/KF5Crash/KF5CrashConfig.cmake, version: 5.55.0[2019-02-18T20:50:58.184Z] [2019-02-18T20:50:58.184Z] Call Stack (most recent call first):[2019-02-18T20:50:58.184Z]   CMakeLists.txt:26 (find_package)[2019-02-18T20:50:58.184Z] [2019-02-18T20:50:58.184Z] [2019-02-18T20:50:58.184Z] -- Could NOT find KF5Crash , checked the following files:[2019-02-18T20:50:58.184Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Crash/KF5CrashConfig.cmake (version 5.55.0)[2019-02-18T20:50:58.184Z] /home/jenkins/install-prefix/lib/cmake/KF5Crash/KF5CrashConfig.cmake (version 5.55.0)[2019-02-18T20:50:58.184Z] [2019-02-18T20:50:58.184Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-18T20:50:58.184Z]   Could not find a configuration file for package "KF5GlobalAccel" that is[2019-02-18T20:50:58.184Z]   compatible with requested version "5.56.0".[2019-02-18T20:50:58.184Z] 

D19129: [sddm-theme] Apply new username prompt and user list icons

[Krešimir Čohar]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:8ee8ca17290e: [sddm-theme] Apply new username prompt and 
user list icons (authored by rooty).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19129?vs=52004=52011

REVISION DETAIL
  https://phabricator.kde.org/D19129

AFFECTED FILES
  sddm-theme/Main.qml

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18939: KMenuEdit: add search/filter bar

[Christoph Feck]

cfeck added inline comments.

INLINE COMMENTS

> kmenuedit.h:60
>  QSplitter *m_splitter = nullptr;
> +KTreeWidgetSearchLine* m_searchLine = nullptr;
>  

Surrounding code uses `Type *var`.

> treeview.cpp:1924
> +// expand all categories if we typed more than a few characters, 
> otherwise collapse and un-select everything
> +if (searchString.length() > 2) {
> +expandAll();

Maybe use KStringHandler::logicalLength() for CJK users.

REPOSITORY
  R103 KMenu Editor

BRANCH
  search-bar

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: ognarb, mlaurent, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19129: [sddm-theme] Apply new username prompt and user list icons

[Filip Fila]

filipf accepted this revision.
filipf added a comment.
This revision is now accepted and ready to land.


  +1

REPOSITORY
  R120 Plasma Workspace

BRANCH
  apply-new-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19129

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19129: [sddm-theme] Apply new username prompt and user list icons

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch applies the icons added in D19020 
 to the Breeze SDDM theme.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  apply-new-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19129

AFFECTED FILES
  sddm-theme/Main.qml

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19126: block screen filtering for global menu applet

[Michail Vourlakos]

mvourlakos created this revision.
mvourlakos added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mvourlakos requested review of this revision.

REVISION SUMMARY
  --when the user has enabled PLASMA_USE_QT_SCALING
  under X11 environment the screen and window geometries
  can not be trusted for comparison. In such case
  the global menu should be always visible
  
  BUG: 404500

TEST PLAN
  check that global menu still works properly

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bug404500

REVISION DETAIL
  https://phabricator.kde.org/D19126

AFFECTED FILES
  applets/appmenu/plugin/appmenumodel.cpp

To: mvourlakos, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19125: Change shadow color to 0,0,0 for KStyle

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:3e78fa28585e: Change shadow color to 0,0,0 for KStyle 
(authored by ndavis).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19125?vs=51995=51998

REVISION DETAIL
  https://phabricator.kde.org/D19125

AFFECTED FILES
  kstyle/breeze.kcfg

To: ndavis, #vdg, #breeze, ngraham, zzag
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19125: Change shadow color to 0,0,0 for KStyle

[Noah Davis]

ndavis added a comment.


  In D19125#414786 , @zzag wrote:
  
  > Should we adjust opacity as well?
  
  
  That's the strength value, right? I don't think so.

REPOSITORY
  R31 Breeze

BRANCH
  black-shadow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19125

To: ndavis, #vdg, #breeze, ngraham, zzag
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19125: Change shadow color to 0,0,0 for KStyle

[Noah Davis]

ndavis added a comment.


  In D19125#414788 , @ngraham wrote:
  
  > Nah, I think that would begin to re-introduce the bug we're trying to solve 
(shadows not being visible in Breeze Dark).
  
  
  Also, worse color banding on cheap displays

REPOSITORY
  R31 Breeze

BRANCH
  black-shadow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19125

To: ndavis, #vdg, #breeze, ngraham, zzag
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19125: Change shadow color to 0,0,0 for KStyle

[Nathaniel Graham]

ngraham added a comment.


  Nah, I think that would begin to re-introduce the bug we're trying to solve 
(shadows not being visible in Breeze Dark).

REPOSITORY
  R31 Breeze

BRANCH
  black-shadow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19125

To: ndavis, #vdg, #breeze, ngraham, zzag
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19125: Change shadow color to 0,0,0 for KStyle

[Vlad Zagorodniy]

zzag added a comment.


  Should we adjust opacity as well?

REPOSITORY
  R31 Breeze

BRANCH
  black-shadow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19125

To: ndavis, #vdg, #breeze, ngraham, zzag
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19125: Change shadow color to 0,0,0 for KStyle

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  Continuation of D19124 

REPOSITORY
  R31 Breeze

BRANCH
  black-shadow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19125

AFFECTED FILES
  kstyle/breeze.kcfg

To: ndavis, #vdg, #breeze
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19124: Change shadow color to 0,0,0

[Noah Davis]

ndavis added a comment.


  alright

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19124

To: ndavis, #vdg, ngraham, filipf
Cc: zzag, filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19124: Change shadow color to 0,0,0

[Nathaniel Graham]

ngraham added a comment.


  Ah yes, gotta make the same change in `kstyle/breeze.kcfg` too. @ndavis can 
you do that?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19124

To: ndavis, #vdg, ngraham, filipf
Cc: zzag, filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19124: Change shadow color to 0,0,0

[Vlad Zagorodniy]

zzag added a comment.


  What about kstyle?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D19124

To: ndavis, #vdg, ngraham, filipf
Cc: zzag, filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19124: Change shadow color to 0,0,0

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:dce32ce1e0ed: Change shadow color to 0,0,0 (authored by 
ndavis).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19124?vs=51989=51991

REVISION DETAIL
  https://phabricator.kde.org/D19124

AFFECTED FILES
  kdecoration/breezesettingsdata.kcfg

To: ndavis, #vdg, ngraham, filipf
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19124: Change shadow color to 0,0,0

[Filip Fila]

filipf accepted this revision.
filipf added a comment.


  Another big +1 for all the reasons already mentioned.

REPOSITORY
  R31 Breeze

BRANCH
  black-shadow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19124

To: ndavis, #vdg, ngraham, filipf
Cc: filipf, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19124: Change shadow color to 0,0,0

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I changed this from black to Shade Black as a compromise to get 
https://cgit.kde.org/breeze.git/commit/?id=9fb5d3abb18cde0ef63102cb06f1a936152ccaef
 done and I think we have to consider the experiment a failure. It results in 
various visual regressions and black is a better default.
  
  +1

REPOSITORY
  R31 Breeze

BRANCH
  black-shadow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19124

To: ndavis, #vdg, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19124: Change shadow color to 0,0,0

[Noah Davis]

ndavis created this revision.
ndavis added a reviewer: VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REVISION SUMMARY
  The current shadow color is Shade Black, which is also used as the 
ViewBackground color in Breeze dark. This makes the shadow invisible when 2 
windows without borders overlap with touching View areas. It also makes color 
banding worse on cheap displays. Changing the color to black makes the shadow 
visible on most backgrounds and slightly improves the look of the shadow on 
cheap displays.

REPOSITORY
  R31 Breeze

BRANCH
  black-shadow (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19124

AFFECTED FILES
  kdecoration/breezesettingsdata.kcfg

To: ndavis, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19096: Increase the label's area to display 2 lines of text when needed

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Very nice! This fixes the bug and the code change looks sane. @hein are you 
good with this?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19096

To: trmdi, ngraham, hein, #plasma, #vdg
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 107 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/107/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 18 Feb 2019 17:12:49 +
 Build duration:
53 sec and counting
   CONSOLE OUTPUT
  [...truncated 438 lines...][2019-02-18T17:13:42.043Z] Call Stack (most recent call first):[2019-02-18T17:13:42.043Z]   CMakeLists.txt:35 (find_package)[2019-02-18T17:13:42.043Z] [2019-02-18T17:13:42.043Z] [2019-02-18T17:13:42.043Z] -- Could NOT find KF5GlobalAccel , checked the following files:[2019-02-18T17:13:42.043Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (version 5.55.0)[2019-02-18T17:13:42.043Z] /home/jenkins/install-prefix/lib/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (version 5.55.0)[2019-02-18T17:13:42.043Z] [2019-02-18T17:13:42.043Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-18T17:13:42.043Z]   Could not find a configuration file for package "KF5Declarative" that is[2019-02-18T17:13:42.043Z]   compatible with requested version "5.56.0".[2019-02-18T17:13:42.043Z] [2019-02-18T17:13:42.043Z]   The following configuration files were considered but not accepted:[2019-02-18T17:13:42.043Z] [2019-02-18T17:13:42.043Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake, version: 5.55.0[2019-02-18T17:13:42.043Z] /home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake, version: 5.55.0[2019-02-18T17:13:42.043Z] [2019-02-18T17:13:42.043Z] Call Stack (most recent call first):[2019-02-18T17:13:42.043Z]   CMakeLists.txt:35 (find_package)[2019-02-18T17:13:42.043Z] [2019-02-18T17:13:42.043Z] [2019-02-18T17:13:42.043Z] -- Could NOT find KF5Declarative , checked the following files:[2019-02-18T17:13:42.043Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (version 5.55.0)[2019-02-18T17:13:42.043Z] /home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (version 5.55.0)[2019-02-18T17:13:42.043Z] [2019-02-18T17:13:42.043Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-18T17:13:42.043Z]   Could not find a configuration file for package "KF5People" that is[2019-02-18T17:13:42.043Z]   compatible with requested version "5.56.0".[2019-02-18T17:13:42.043Z] [2019-02-18T17:13:42.043Z]   The following configuration files were considered but not accepted:[2019-02-18T17:13:42.043Z] [2019-02-18T17:13:42.043Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5People/KF5PeopleConfig.cmake, version: 5.55.0[2019-02-18T17:13:42.043Z] /home/jenkins/install-prefix/lib/cmake/KF5People/KF5PeopleConfig.cmake, version: 5.55.0[2019-02-18T17:13:42.043Z] [2019-02-18T17:13:42.043Z] Call Stack (most recent call first):[2019-02-18T17:13:42.043Z]   CMakeLists.txt:35 (find_package)[2019-02-18T17:13:42.043Z] [2019-02-18T17:13:42.043Z] [2019-02-18T17:13:42.043Z] -- Could NOT find KF5People , checked the following files:[2019-02-18T17:13:42.043Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5People/KF5PeopleConfig.cmake (version 5.55.0)[2019-02-18T17:13:42.043Z] /home/jenkins/install-prefix/lib/cmake/KF5People/KF5PeopleConfig.cmake (version 5.55.0)[2019-02-18T17:13:42.043Z] [2019-02-18T17:13:42.043Z] -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.56.0") [2019-02-18T17:13:42.043Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-18T17:13:42.043Z]   Could not find a configuration file for package "KF5Activities" that is[2019-02-18T17:13:42.044Z]   compatible with requested version "5.56.0".[2019-02-18T17:13:42.044Z] [2019-02-18T17:13:42.044Z]   The following configuration files were considered but not accepted:[2019-02-18T17:13:42.044Z] [2019-02-18T17:13:42.044Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake, version: 5.55.0[2019-02-18T17:13:42.044Z] /home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake, version: 5.55.0[2019-02-18T17:13:42.044Z] [2019-02-18T17:13:42.044Z] Call Stack (most recent call first):[2019-02-18T17:13:42.044Z]   CMakeLists.txt:35 (find_package)[2019-02-18T17:13:42.044Z] [2019-02-18T17:13:42.044Z] [2019-02-18T17:13:42.044Z] -- Could NOT find KF5Activities , checked the following files:[2019-02-18T17:13:42.044Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (version 5.55.0)[2019-02-18T17:13:42.044Z] /home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (version 5.55.0)[2019-02-18T17:13:42.044Z] [2019-02-18T17:13:42.044Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.12 - Build # 106 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.12/106/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 18 Feb 2019 17:10:09 +
 Build duration:
1 min 23 sec and counting
   CONSOLE OUTPUT
  [...truncated 438 lines...][2019-02-18T17:11:32.519Z] Call Stack (most recent call first):[2019-02-18T17:11:32.519Z]   CMakeLists.txt:35 (find_package)[2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z] -- Could NOT find KF5GlobalAccel , checked the following files:[2019-02-18T17:11:32.519Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (version 5.55.0)[2019-02-18T17:11:32.519Z] /home/jenkins/install-prefix/lib/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (version 5.55.0)[2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-18T17:11:32.519Z]   Could not find a configuration file for package "KF5Declarative" that is[2019-02-18T17:11:32.519Z]   compatible with requested version "5.56.0".[2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z]   The following configuration files were considered but not accepted:[2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake, version: 5.55.0[2019-02-18T17:11:32.519Z] /home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake, version: 5.55.0[2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z] Call Stack (most recent call first):[2019-02-18T17:11:32.519Z]   CMakeLists.txt:35 (find_package)[2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z] -- Could NOT find KF5Declarative , checked the following files:[2019-02-18T17:11:32.519Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (version 5.55.0)[2019-02-18T17:11:32.519Z] /home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (version 5.55.0)[2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-18T17:11:32.519Z]   Could not find a configuration file for package "KF5People" that is[2019-02-18T17:11:32.519Z]   compatible with requested version "5.56.0".[2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z]   The following configuration files were considered but not accepted:[2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5People/KF5PeopleConfig.cmake, version: 5.55.0[2019-02-18T17:11:32.519Z] /home/jenkins/install-prefix/lib/cmake/KF5People/KF5PeopleConfig.cmake, version: 5.55.0[2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z] Call Stack (most recent call first):[2019-02-18T17:11:32.519Z]   CMakeLists.txt:35 (find_package)[2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z] -- Could NOT find KF5People , checked the following files:[2019-02-18T17:11:32.519Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5People/KF5PeopleConfig.cmake (version 5.55.0)[2019-02-18T17:11:32.519Z] /home/jenkins/install-prefix/lib/cmake/KF5People/KF5PeopleConfig.cmake (version 5.55.0)[2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z] -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.56.0") [2019-02-18T17:11:32.519Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-18T17:11:32.519Z]   Could not find a configuration file for package "KF5Activities" that is[2019-02-18T17:11:32.519Z]   compatible with requested version "5.56.0".[2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z]   The following configuration files were considered but not accepted:[2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake, version: 5.55.0[2019-02-18T17:11:32.519Z] /home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake, version: 5.55.0[2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z] Call Stack (most recent call first):[2019-02-18T17:11:32.519Z]   CMakeLists.txt:35 (find_package)[2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z] -- Could NOT find KF5Activities , checked the following files:[2019-02-18T17:11:32.519Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (version 5.55.0)[2019-02-18T17:11:32.519Z] /home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (version 5.55.0)[2019-02-18T17:11:32.519Z] [2019-02-18T17:11:32.519Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 

D19093: Improve the look of the Emoticons KCM UI

[Björn Feber]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8b413729da44: Improve the look of the Emoticons KCM UI 
(authored by GB_2).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19093?vs=51978=51979

REVISION DETAIL
  https://phabricator.kde.org/D19093

AFFECTED FILES
  kcms/emoticons/emoticonslist.cpp
  kcms/emoticons/emoticonslist.ui

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19093: Improve the look of the Emoticons KCM UI

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  +1 shipit!

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improve-look-of-emoticons-kcm-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19093

To: GB_2, #plasma, #vdg, ngraham
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19093: Improve the look of the Emoticons KCM UI

[Björn Feber]

GB_2 updated this revision to Diff 51978.
GB_2 added a comment.


  Address comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19093?vs=51905=51978

BRANCH
  improve-look-of-emoticons-kcm-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19093

AFFECTED FILES
  kcms/emoticons/emoticonslist.cpp
  kcms/emoticons/emoticonslist.ui

To: GB_2, #plasma, #vdg
Cc: ngraham, #vdg, plasma-devel, #plasma, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.12 - Build # 40 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.12/40/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 18 Feb 2019 16:39:04 +
 Build duration:
1 min 47 sec and counting
   CONSOLE OUTPUT
  [...truncated 255 lines...][2019-02-18T16:40:50.351Z] [2019-02-18T16:40:50.351Z] Call Stack (most recent call first):[2019-02-18T16:40:50.351Z]   CMakeLists.txt:26 (find_package)[2019-02-18T16:40:50.351Z] [2019-02-18T16:40:50.351Z] [2019-02-18T16:40:50.351Z] -- Could NOT find KF5Crash , checked the following files:[2019-02-18T16:40:50.351Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Crash/KF5CrashConfig.cmake (version 5.55.0)[2019-02-18T16:40:50.351Z] /home/jenkins/install-prefix/lib/cmake/KF5Crash/KF5CrashConfig.cmake (version 5.55.0)[2019-02-18T16:40:50.351Z] [2019-02-18T16:40:50.351Z] -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.56.0") [2019-02-18T16:40:50.351Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-18T16:40:50.351Z]   Could not find a configuration file for package "KF5I18n" that is[2019-02-18T16:40:50.351Z]   compatible with requested version "5.56.0".[2019-02-18T16:40:50.351Z] [2019-02-18T16:40:50.351Z]   The following configuration files were considered but not accepted:[2019-02-18T16:40:50.351Z] [2019-02-18T16:40:50.351Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake, version: 5.55.0[2019-02-18T16:40:50.351Z] /home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake, version: 5.55.0[2019-02-18T16:40:50.351Z] [2019-02-18T16:40:50.351Z] Call Stack (most recent call first):[2019-02-18T16:40:50.351Z]   CMakeLists.txt:26 (find_package)[2019-02-18T16:40:50.351Z] [2019-02-18T16:40:50.351Z] [2019-02-18T16:40:50.351Z] -- Could NOT find KF5I18n , checked the following files:[2019-02-18T16:40:50.351Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (version 5.55.0)[2019-02-18T16:40:50.351Z] /home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (version 5.55.0)[2019-02-18T16:40:50.351Z] [2019-02-18T16:40:50.351Z] -- Found KF5Archive: /usr/home/jenkins/install-prefix/lib/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.56.0") [2019-02-18T16:40:50.351Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-18T16:40:50.351Z]   Could not find a configuration file for package "KF5XmlGui" that is[2019-02-18T16:40:50.351Z]   compatible with requested version "5.56.0".[2019-02-18T16:40:50.351Z] [2019-02-18T16:40:50.351Z]   The following configuration files were considered but not accepted:[2019-02-18T16:40:50.351Z] [2019-02-18T16:40:50.351Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake, version: 5.55.0[2019-02-18T16:40:50.351Z] /home/jenkins/install-prefix/lib/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake, version: 5.55.0[2019-02-18T16:40:50.351Z] [2019-02-18T16:40:50.351Z] Call Stack (most recent call first):[2019-02-18T16:40:50.351Z]   CMakeLists.txt:26 (find_package)[2019-02-18T16:40:50.351Z] [2019-02-18T16:40:50.351Z] [2019-02-18T16:40:50.352Z] -- Could NOT find KF5XmlGui , checked the following files:[2019-02-18T16:40:50.352Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (version 5.55.0)[2019-02-18T16:40:50.352Z] /home/jenkins/install-prefix/lib/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (version 5.55.0)[2019-02-18T16:40:50.352Z] [2019-02-18T16:40:50.352Z] -- Found KF5ItemModels: /usr/home/jenkins/install-prefix/lib/cmake/KF5ItemModels/KF5ItemModelsConfig.cmake (found version "5.56.0") [2019-02-18T16:40:50.352Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-18T16:40:50.352Z]   Could not find a configuration file for package "KF5KIO" that is compatible[2019-02-18T16:40:50.352Z]   with requested version "5.56.0".[2019-02-18T16:40:50.352Z] [2019-02-18T16:40:50.352Z]   The following configuration files were considered but not accepted:[2019-02-18T16:40:50.352Z] [2019-02-18T16:40:50.352Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake, version: 5.55.0[2019-02-18T16:40:50.352Z] /home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake, version: 5.55.0[2019-02-18T16:40:50.352Z] [2019-02-18T16:40:50.352Z] Call Stack (most recent call first):[2019-02-18T16:40:50.352Z]   CMakeLists.txt:26 (find_package)[2019-02-18T16:40:50.352Z] [2019-02-18T16:40:50.352Z] [2019-02-18T16:40:50.352Z] -- Could NOT find KF5KIO , checked the following files:[2019-02-18T16:40:50.352Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (version 5.55.0)[2019-02-18T16:40:50.352Z] /home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (version 

D19077: WIP: Fix long labels not being wrapped

[Filip Fila]

filipf added a comment.


  In D19077#414283 , @abetts wrote:
  
  > Just added some visual adjustments (mockup)
  >
  > F6620598: Screen Shot 2019-02-17 at 4.56.46 PM.png 

  
  
  Thanks! I like all the adjustments. Just to clarify, you also suggest we add 
a subtle shadow behind the preview image? Because I was actually thinking about 
that.
  
  In D19077#414608 , @ngraham wrote:
  
  > Very much against adding a scrollbar into the preview area. I think we can 
come up with a better solution.
  
  
  It's not a stroke of genius solution that's for sure, I just can't think of 
any other way to take care of the problem when the fonts are big or scaling is 
used :(
  
  I'm open to any suggestion though.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19077: WIP: Fix long labels not being wrapped

[Nathaniel Graham]

ngraham added a comment.


  Very much against adding a scrollbar into the preview area. I think we can 
come up with a better solution.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: abetts, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19119: ApplicationPage: include the available version when selecting the source

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This change would make the version number show up first in the string, 
assigning it primary visual importance. This would make the name of the 
dropdown menu ("Sources") incorrect.
  
  I recommend the following format:
  
Flatpak (version 4.1)
Kubuntu (version 3.9.8)
etc.
  
  Also, what if there is no version number available? We should handle that 
case too.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19119

To: apol, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19119: ApplicationPage: include the available version when selecting the source

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  A source will often have different versions of the same software.

REPOSITORY
  R134 Discover Software Store

BRANCH
  Plasma/5.15

REVISION DETAIL
  https://phabricator.kde.org/D19119

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: apol, #discover_software_store
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » discover » kf5-qt5 FreeBSDQt5.12 - Build # 39 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/discover/job/kf5-qt5%20FreeBSDQt5.12/39/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 18 Feb 2019 15:25:40 +
 Build duration:
1 min 50 sec and counting
   CONSOLE OUTPUT
  [...truncated 253 lines...][2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z] Call Stack (most recent call first):[2019-02-18T15:27:30.801Z]   CMakeLists.txt:26 (find_package)[2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z] -- Could NOT find KF5Crash , checked the following files:[2019-02-18T15:27:30.801Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Crash/KF5CrashConfig.cmake (version 5.55.0)[2019-02-18T15:27:30.801Z] /home/jenkins/install-prefix/lib/cmake/KF5Crash/KF5CrashConfig.cmake (version 5.55.0)[2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z] -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.56.0") [2019-02-18T15:27:30.801Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-18T15:27:30.801Z]   Could not find a configuration file for package "KF5I18n" that is[2019-02-18T15:27:30.801Z]   compatible with requested version "5.56.0".[2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z]   The following configuration files were considered but not accepted:[2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake, version: 5.55.0[2019-02-18T15:27:30.801Z] /home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake, version: 5.55.0[2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z] Call Stack (most recent call first):[2019-02-18T15:27:30.801Z]   CMakeLists.txt:26 (find_package)[2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z] -- Could NOT find KF5I18n , checked the following files:[2019-02-18T15:27:30.801Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (version 5.55.0)[2019-02-18T15:27:30.801Z] /home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (version 5.55.0)[2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z] -- Found KF5Archive: /usr/home/jenkins/install-prefix/lib/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.56.0") [2019-02-18T15:27:30.801Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-18T15:27:30.801Z]   Could not find a configuration file for package "KF5XmlGui" that is[2019-02-18T15:27:30.801Z]   compatible with requested version "5.56.0".[2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z]   The following configuration files were considered but not accepted:[2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake, version: 5.55.0[2019-02-18T15:27:30.801Z] /home/jenkins/install-prefix/lib/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake, version: 5.55.0[2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z] Call Stack (most recent call first):[2019-02-18T15:27:30.801Z]   CMakeLists.txt:26 (find_package)[2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z] -- Could NOT find KF5XmlGui , checked the following files:[2019-02-18T15:27:30.801Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (version 5.55.0)[2019-02-18T15:27:30.801Z] /home/jenkins/install-prefix/lib/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (version 5.55.0)[2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z] -- Found KF5ItemModels: /usr/home/jenkins/install-prefix/lib/cmake/KF5ItemModels/KF5ItemModelsConfig.cmake (found version "5.56.0") [2019-02-18T15:27:30.801Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-18T15:27:30.801Z]   Could not find a configuration file for package "KF5KIO" that is compatible[2019-02-18T15:27:30.801Z]   with requested version "5.56.0".[2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z]   The following configuration files were considered but not accepted:[2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake, version: 5.55.0[2019-02-18T15:27:30.801Z] /home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake, version: 5.55.0[2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z] Call Stack (most recent call first):[2019-02-18T15:27:30.801Z]   CMakeLists.txt:26 (find_package)[2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z] [2019-02-18T15:27:30.801Z] -- Could NOT find KF5KIO , checked the following files:[2019-02-18T15:27:30.801Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (version 5.55.0)[2019-02-18T15:27:30.801Z] /home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (version 

D16886: [windowswitcher] Implement keyboard navigation

[Nathaniel Graham]

ngraham added a comment.


  Yes, that one already works in Plasma 5.15. All of them should now work with 
keyboard navigation, in fact.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D16886

To: ngraham, #plasma, graesslin
Cc: abetts, szafar, davidedmundson, Zren, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.12 - Build # 117 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.12/117/
 Project:
kf5-qt5 FreeBSDQt5.12
 Date of build:
Mon, 18 Feb 2019 14:29:40 +
 Build duration:
4 min 18 sec and counting
   CONSOLE OUTPUT
  [...truncated 311 lines...][2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z] -- Could NOT find KF5I18n , checked the following files:[2019-02-18T14:33:58.235Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (version 5.55.0)[2019-02-18T14:33:58.235Z] /home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (version 5.55.0)[2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-18T14:33:58.235Z]   Could not find a configuration file for package "KF5Init" that is[2019-02-18T14:33:58.235Z]   compatible with requested version "5.56.0".[2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z]   The following configuration files were considered but not accepted:[2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Init/KF5InitConfig.cmake, version: 5.55.0[2019-02-18T14:33:58.235Z] /home/jenkins/install-prefix/lib/cmake/KF5Init/KF5InitConfig.cmake, version: 5.55.0[2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z] Call Stack (most recent call first):[2019-02-18T14:33:58.235Z]   CMakeLists.txt:72 (find_package)[2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z] -- Could NOT find KF5Init , checked the following files:[2019-02-18T14:33:58.235Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Init/KF5InitConfig.cmake (version 5.55.0)[2019-02-18T14:33:58.235Z] /home/jenkins/install-prefix/lib/cmake/KF5Init/KF5InitConfig.cmake (version 5.55.0)[2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-18T14:33:58.235Z]   Could not find a configuration file for package "KF5Notifications" that is[2019-02-18T14:33:58.235Z]   compatible with requested version "5.56.0".[2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z]   The following configuration files were considered but not accepted:[2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Notifications/KF5NotificationsConfig.cmake, version: 5.55.0[2019-02-18T14:33:58.235Z] /home/jenkins/install-prefix/lib/cmake/KF5Notifications/KF5NotificationsConfig.cmake, version: 5.55.0[2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z] Call Stack (most recent call first):[2019-02-18T14:33:58.235Z]   CMakeLists.txt:72 (find_package)[2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z] -- Could NOT find KF5Notifications , checked the following files:[2019-02-18T14:33:58.235Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Notifications/KF5NotificationsConfig.cmake (version 5.55.0)[2019-02-18T14:33:58.235Z] /home/jenkins/install-prefix/lib/cmake/KF5Notifications/KF5NotificationsConfig.cmake (version 5.55.0)[2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z] CMake Warning at /usr/home/jenkins/install-prefix/share/ECM/find-modules/FindKF5.cmake:74 (find_package):[2019-02-18T14:33:58.235Z]   Could not find a configuration file for package "KF5Package" that is[2019-02-18T14:33:58.235Z]   compatible with requested version "5.56.0".[2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z]   The following configuration files were considered but not accepted:[2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageConfig.cmake, version: 5.55.0[2019-02-18T14:33:58.235Z] /home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageConfig.cmake, version: 5.55.0[2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z] Call Stack (most recent call first):[2019-02-18T14:33:58.235Z]   CMakeLists.txt:72 (find_package)[2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z] -- Could NOT find KF5Package , checked the following files:[2019-02-18T14:33:58.235Z] /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageConfig.cmake (version 5.55.0)[2019-02-18T14:33:58.235Z] /home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageConfig.cmake (version 5.55.0)[2019-02-18T14:33:58.235Z] [2019-02-18T14:33:58.235Z] -- Found KF5Plasma: /usr/home/jenkins/install-prefix/lib/cmake/KF5Plasma/KF5PlasmaConfig.cmake (found version "5.56.0") [2019-02-18T14:33:58.235Z] -- Found KF5WidgetsAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5WidgetsAddons/KF5WidgetsAddonsConfig.cmake (found version "5.56.0") [2019-02-18T14:33:58.235Z] -- Found KF5WindowSystem: /usr/home/jenkins/install-prefix/lib/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.56.0") 

D19044: [InlineMessage] Do not draw shadows around the message

[Nathaniel Graham]

ngraham added a comment.


  In D19044#414479 , @mart wrote:
  
  > -1
  >  this has to be done at most for the desktop style and the desktop style 
only
  
  
  Can you explain a bit more? I don't understand the technical reason for why 
you think we should do this in the QQC2 style only. If anything, wouldn't it 
make sense to not have the shadow here and only add it in the QQC2 style if we 
did want it there (which we don't)?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19044

To: filipf, #vdg, #kirigami, ngraham, mart
Cc: mart, abetts, plasma-devel, dkardarakos, apol, davidedmundson, hein

D19042: Fix warning when using QQuickAction

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:c503e0df3cfc: Fix warning when using QQuickAction 
(authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19042?vs=51769=51962

REVISION DETAIL
  https://phabricator.kde.org/D19042

AFFECTED FILES
  src/controls/Action.qml

To: apol, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D19040: Remove some unnecessary QString constructions

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:fc04142750c5: Remove some unnecessary QString 
constructions (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19040?vs=51767=51961

REVISION DETAIL
  https://phabricator.kde.org/D19040

AFFECTED FILES
  src/settings.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D19043: Fix warning

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:9951b7913f3b: Fix warning (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19043?vs=51770=51960

REVISION DETAIL
  https://phabricator.kde.org/D19043

AFFECTED FILES
  src/controls/private/ActionButton.qml

To: apol, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18189: Fix ComboBox

[Aleix Pol Gonzalez]

apol closed this revision.
apol added a comment.


  This was fixed subsequently.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D18189

To: apol, #kirigami, mart
Cc: broulik, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19110: Don't show the tooltip when the drop-down menu is shown

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:368ed3bf3df8: Dont show the tooltip when the 
drop-down menu is shown (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19110?vs=51937=51959

REVISION DETAIL
  https://phabricator.kde.org/D19110

AFFECTED FILES
  src/controls/private/PrivateActionToolButton.qml

To: apol, #kirigami, #frameworks, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18938: Show assigned shortcut in drawer action delegates

[Marco Martin]

mart requested changes to this revision.
mart added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> GlobalDrawerActionItem.qml:102
> +Layout.alignment: Qt.AlignVCenter | Qt.AlignRight
> +visible: modelData.__shortcut.enabled && !Settings.tabletMode
> +color: Theme.disabledTextColor

adding also && root.modal should fix the discover and other 
always-showing-sidebar apps use case.

Pretty sure the label will break on collapsed mode.
did you try on kirigami gallery to set the sidebar to collapsible with this 
patch on?

should probably be

visible: modelData.__shortcut.enabled && !Settings.tabletMode && root.modal && 
!root.collapsible

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18938

To: hein, mart, apol
Cc: ngraham, plasma-devel, #plasma, dkardarakos, apol, davidedmundson, mart, 
hein

D19044: [InlineMessage] Do not draw shadows around the message

[Marco Martin]

mart requested changes to this revision.
mart added a comment.
This revision now requires changes to proceed.


  -1
  this has to be done at most for the desktop style and the desktop style only

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19044

To: filipf, #vdg, #kirigami, ngraham, mart
Cc: mart, abetts, plasma-devel, dkardarakos, apol, davidedmundson, hein

D19118: Add (and use) a LinkLabel component

[Dan Leinir Turthra Jensen]

leinir created this revision.
leinir added reviewers: apol, ngraham, Discover Software Store.
leinir added a project: Discover Software Store.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
leinir requested review of this revision.

REVISION SUMMARY
  The component, which is deliberately very simple. just adds the functionality 
to Label of ensuring we have a hand cursor when hovering over a link in the 
Label component. This is required due to missing functionality in both Text and 
QCC2's Label components, which have no mouse cursor changing abilities. There 
is a Qt bug regarding the issue, mentioned in this new component's code, but so 
far it looks unlikely to get a "real" fix anytime soon, so, for less 
headachiness, this component (which simply takes code we already had in one 
place and applies it slightly more widely and generically)...
  
  BUG:404309

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D19118

AFFECTED FILES
  discover/qml/ApplicationPage.qml
  discover/qml/LinkLabel.qml
  discover/qml/ReviewDelegate.qml
  discover/qml/UpdatesPage.qml
  discover/resources.qrc

To: leinir, apol, ngraham, #discover_software_store
Cc: plasma-devel, jraleigh, bam, GB_2, ragreen, ixoos, Pitel, ZrenBot, James, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19033: [about-distro] run absolute paths through qicon intead of qpixmap

[Harald Sitter]

sitter added a comment.


  If I understand it correctly, the bug would only show its ugly head with 
`QIcon::fromTheme("foo.svg")` but not `QIcon::fromTheme("foo")`. So, if that 
seems a concern we can just add a comment in the README. Distribution devs 
would set LogoPath's value manually, so we can just tell them to use a valid 
value :) Does that seem agreeable @broulik?
  
  @ngraham On a side-note: `foo.svg` is not supported by the specs, so Qt not 
working with it properly is not even a defect TBH - it'd be an additional 
convenience feature in Qt. Specifically the desktop entry spec defines `Icon=` 
as either absolute or it will be run through the lookup described in the icon 
theme spec, and the icon theme spec sets forth a lookup which explicitly 
assumes `filename = directory/$(themename)/subdir/iconname.extension` which by 
extension means a string handed to the theme lookup may only ever be a basename 
of the icon. It may not be absolute, nor relative, nor contain extensions. So, 
while it'd be nice if Qt handled sanitation of relative strings, our software 
is in fact wrong if it allows users to set a (relative) icon with file 
extension and then runs that through QIcon::fromTheme without adjusting it. The 
input must either be absolute or properly sanitized to meet the requirements of 
the icon theme spec.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D19033

To: sitter, #plasma
Cc: ngraham, broulik, cfeck, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Breeze Dark theme question ?

[Marco Martin]

On lunedì 18 febbraio 2019 08:57:55 CET Kai Uwe Broulik wrote:
> Hi,
> 
> I assume you're refering to the blue line when expanding an applet. That
> one is only shown if it comes from the current theme to avoid issues
> when using older Plasma 4 themes that don't expect this item to be used
> in said context. It seems Breeze Dark just inherits the SVG from Breeze
> and as such it is not "fromCurrentTheme" and not displayed.

right, so since breeze dark/light is just a color scheme, fromCurrentTheme 
will always be false.. maybe they should have a copy of that image


-- 
Marco Martin

Notes for 18/2/2019 monday meeting

[Marco Martin]

David:
* working on replacing libkworkspace
* There's a branch davidedmundson/kworkspace2 which I'll update in a bit, 
everything is sooo much tidier. 
* documented my plans on phabricator under that ksmserver splitting task 
https://phabricator.kde.org/T9779
* fixed a regression in ksmserver

Kai Uwe:
* Diff 18646 "[Colors KCM] Add search and filter" [Needs Review] https://
phabricator.kde.org/D18646

Marco:
Kirigami:
* support for alternating stripey listitem backgrounds, useful for multi 
column lists
* continue to work on the pagerow partial c++ rewrite
* experimenting with some new heuristics to determine which icons are 
monochrome since is a big sore point atm especially when the desktop style is 
not used (eg Android), I fear it will be necessary to iterate over pixel 
colors in software
* fixed some qml warnings on stderr

qqc2-desktop-style
* ScrollBar now behaves like qwidgets on mouse click: left button click does 
pgup/pgdown, middle button does absolute positioning

KWin:
* experiments to modify D18818 approach to how martin said, seems super tricky
-- 
Marco Martin