cfeck added inline comments.

INLINE COMMENTS

> kmenuedit.h:60
>      QSplitter *m_splitter = nullptr;
> +    KTreeWidgetSearchLine* m_searchLine = nullptr;
>  

Surrounding code uses `Type *var`.

> treeview.cpp:1924
> +    // expand all categories if we typed more than a few characters, 
> otherwise collapse and un-select everything
> +    if (searchString.length() > 2) {
> +        expandAll();

Maybe use KStringHandler::logicalLength() for CJK users.

REPOSITORY
  R103 KMenu Editor

BRANCH
  search-bar

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: ognarb, mlaurent, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to