D19148: Make shadow sizes linear

[Noah Davis]

ndavis added a comment.


  In D19148#416749 , @zzag wrote:
  
  > In D19148#416006 , @ndavis wrote:
  >
  > > kstyle uses entirely different shadows, even more so compared to the 
original values for kdecoration. Should it not be that way?
  >
  >
  > Well, my concern was that now decoration shadows are way too black in 
comparison to kstyle shadows.
  >
  > Also, I have a question about shadow that comes from directional light, why 
opacity decreases as size increases? Shouldn't it be vice versa?
  
  
  I'm not an expert on this kind of thing, so I'm open to doing more 
modifications. I still don't really get how the ambient shadow works vs the 
directional one.
  However, if an object casting a shadow is closer to the object in the shadow, 
the shadow will be darker than if the object casting the shadow is farther away.
  Try it right now with two pieces of paper under a ceiling light.

REPOSITORY
  R31 Breeze

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19148

To: ndavis, #vdg, #breeze, ngraham
Cc: filipf, ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19096: Improvements for long label items in Application Dashboard

[Tranter Madi]

trmdi added a comment.


  On some small screens e.g <= 1024x768, `units.iconSizes.large` is a bit too 
big, it may look better with `units.iconSizes.medium`
  
  > property int iconSize: smallScreen ? units.iconSizes.large : 
units.iconSizes.huge
  
  Should I change it in this patch or create another one? Do we need to support 
<= 1024x768 screens nowadays ?
  
  Before:
  F6628578: Screenshot_20190221_225334.png 

  
  After:
  F6628581: Screenshot_20190222_014900.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19096

To: trmdi, ngraham, hein, #plasma, #vdg
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19210: [Updates page] Try our best to not elide version strings

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:d2d33a20b0e0: [Updates page] Try our best to not elide 
version strings (authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19210?vs=52251=52265

REVISION DETAIL
  https://phabricator.kde.org/D19210

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: ngraham, #discover_software_store, colomar, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19214: [sddm-theme] WIP, Replace login button label with icon

[Krešimir Čohar]

rooty marked 2 inline comments as done.
rooty added a comment.


  Oh I tried that - the problem is that when I use "iconSource" and then adjust 
the height by subtracting 1/2 units.smallSpacing (line 106), the icon isn't 
vertically centered:
  F6629088: image.png 
  
  So to manipulate its size from within the button I put it into an item in the 
button whose anchors I could tie to the button itself:
  F6629095: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19214

To: rooty, #vdg, #plasma
Cc: ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19011: Thunderbolt KCM and KDED module

[Nathaniel Graham]

ngraham added a comment.


  Thanks, much better! Just a few more UI nitpicks. And one more thing: What 
does "Stored" mean in this context? As a non-Thunderbolt expert, I don't know 
what this means, and I suspect most users wouln't, either.

INLINE COMMENTS

> DeviceList.qml:41
> +id: enableBox
> +text: i18n("Allow Thunderbolt devices")
> +

"Enable" might be a better word than "Allow" in this string.

> DeviceView.qml:50
> +RowLayout {
> +ToolButton {
> +icon.name: "draw-arrow-back"

Can we give this a label or make it a `Button` instead? Many users have 
difficulty recognizing label-less toolbuttons floating inside the page as 
clickable buttons.

> DeviceView.qml:150
> +}
> +Button {
> +id: forgetBtn

I'd recommend that we center this horizontally on the page.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19011

To: dvratil, #vdg, #plasma
Cc: bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham, 
broulik, ognarb, yurchor, asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19214: [sddm-theme] WIP, Replace login button label with icon

[Nathaniel Graham]

ngraham added a comment.


  In D19214#417185 , @rooty wrote:
  
  > Issues unresolved so far:
  >  (1) Should this be done at all?
  
  
  I think so!
  
  > (2) Should the password field + login button be centered, or should just 
the password field be centered and the login button lie to its right? 
Especially considering the impact it would have on the user prompt screen
  
  I like the current approach where the field+button are centered. Looks great 
to me.
  
  > (3) Should the opacity of the login button (and/or the password field) 
remain at 100%? Especially considering the fact that (a) the theme doesn't 
really have a white background for any other element and (b) users can't choose 
color schemes for the SDDM theme, and users that prefer Breeze Dark might not 
take too kindly to such a white username field, password field and login button.
  
  I understand that there are login screens out there that have blurry 
translucent text fields and buttons, and that the overall effect looks good. 
I'd potentially be up for something like that here, but it would probably have 
to be extensively designed and built. I'm not sure if just turning down the 
opacity on the existing UI elements would cut it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19214

To: rooty, #vdg, #plasma
Cc: ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19214: [sddm-theme] WIP, Replace login button label with icon

[Nathaniel Graham]

ngraham added a comment.


  +1 for this design as well. It's much better-looking overall.
  
  If click targets are a potential problem for touch, my preference would be to 
make all of the textual elements larger, which would have the effect of scaling 
everything up--and also making the text more readable all over the place. 
Probably material for another patch though.

INLINE COMMENTS

> MainBlock.qml:100
>  
> -text: i18nd("plasma_lookandfeel_org.kde.lookandfeel", "Unlock")
> -onClicked: startLogin()
> +PlasmaCore.IconItem {
> +anchors.fill: parent

You don't need to add a separate `iconItem`; just give the button `iconSource: 
"configure"`

> Login.qml:109
> +
> +PlasmaCore.IconItem {
> +anchors.fill: parent

Ditto

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19214

To: rooty, #vdg, #plasma
Cc: ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19214: [sddm-theme] WIP, Replace login button label with icon

[Krešimir Čohar]

rooty added a comment.


  Issues unresolved so far:
  (1) Should this be done at all?
  (2) Should the password field + login button be centered, or should just the 
password field be centered and the login button lie to its right? Especially 
considering the impact it would have on the user prompt screen
  (3) Should the opacity of the login button (and/or the password field) remain 
at 100%? Especially considering the fact that (a) the theme doesn't really have 
a white background for any other element and (b) users can't choose color 
schemes for the SDDM theme, and users that prefer Breeze Dark might not take 
too kindly to such a white username field, password field and login button.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19214

To: rooty, #vdg, #plasma
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19214: [sddm-theme] WIP, Replace login button label with icon

[Krešimir Čohar]

rooty updated this revision to Diff 52264.
rooty added a comment.


  Apply changes to lock screen as well

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19214?vs=52263=52264

BRANCH
  loginbutton-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19214

AFFECTED FILES
  lookandfeel/contents/lockscreen/MainBlock.qml
  sddm-theme/Login.qml

To: rooty, #vdg, #plasma
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19214: [sddm-theme] WIP, Replace login button label with icon

[Krešimir Čohar]

rooty added a comment.


  There's also the problem that even though they're technically the same 
height, when it's highlighted, the password field just seems taller (the 
highlight adds a pixel above and below it).
  F6629062: image.png 
  
  And yet if I make the login button taller, then it looks too tall when the 
field is unfocused (or defocused, I should say - hence the problem).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19214

To: rooty, #vdg, #plasma
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19214: [sddm-theme] WIP, Replace login button label with icon

[Krešimir Čohar]

rooty added a comment.


  In D19214#417178 , @filipf wrote:
  
  > Design-wise I've been advocating this as well so it's obviously a +1 from 
me.
  >
  > Usability-wise I'd like use to increase the height of the input field and 
consequently the login button size because you have to keep touchscreen users 
in mind. Bigger button = easier to hit.
  >
  > Consistency-wise the lock screen will probably get mentioned in the 
discussion.
  
  
  Oh yeah that's right I have to do the lock screen too
  
  One of the changes I've got planned for the password input field is 
increasing the font size so... we probably won't have to make the password 
field taller?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19214

To: rooty, #vdg, #plasma
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19214: [sddm-theme] WIP, Replace login button label with icon

[Filip Fila]

filipf added a comment.


  Design-wise I've been advocating this as well so it's obviously a +1 from me.
  
  Usability-wise I'd like use to increase the height of the input field and 
consequently the login button size because you have to keep touchscreen users 
in mind. Bigger button = easier to hit.
  
  Consistency-wise the lock screen will probably get mentioned in the 
discussion.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19214

To: rooty, #vdg, #plasma
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19214: [sddm-theme] WIP, Replace login button label with icon

[Krešimir Čohar]

rooty added a comment.


  By the way, I've been testing this with Breeze Dark only - I don't know why 
the icon looks a lot dimmer with the Breeze color scheme, hence WIP
  Also, I don't think that we have consensus yet whether we want this change or 
not - but in case we decide to go for it, here's the diff :D

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19214

To: rooty, #vdg, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19214: [sddm-theme] Replace login button label with icon

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch replaces the login button label "Log In" with an icon, places it 
to the right of the password field, and centers the combination of the password 
field and the login button. It also adjusts for the button's right border, 
which has a tendency to extend to the right and beyond the username input field 
by one pixel.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  loginbutton-icon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19214

AFFECTED FILES
  sddm-theme/Login.qml

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15907: Compare float values in DecorationButton contains check

[Roman Gilg]

romangg added a comment.


  In D15907#417151 , @zzag wrote:
  
  > Tests are not less important than the rest of the project. It's not good 
that we don't care about their readability.
  
  
  Oh I do care about readability. Did you notice the huge diagram so auto test 
//readers// have a picture of what the test is doing?
  
  > I'm not convinced by "current autotest fails without the change on current 
master and works with the patch". Please make the test simpler. I don't think 
that it will take too much time to reorganize the test table.
  
  What's not to be convinced here? It's a fact, not an argument. No, I won't 
rewrite the test. If you want the autotest differently, do it yourself.

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D15907

To: romangg, #kwin, zzag, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15907: Compare float values in DecorationButton contains check

[Vlad Zagorodniy]

zzag added a comment.


  Tests are not less important than the rest of the project. It's not good that 
we don't care about their readability.
  
  I'm not convinced by "current autotest fails without the change on current 
master and works with the patch". Please make the test simpler. I don't think 
that it will take too much time to reorganize the test table.

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D15907

To: romangg, #kwin, zzag, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15907: Compare float values in DecorationButton contains check

[Roman Gilg]

romangg added a comment.


  In D15907#415347 , @zzag wrote:
  
  > Looks good to me.
  >
  > I think the test is too much complicated. Would it be simpler to have 
something like
  >
  >   QTest::addColumn("geometry");
  >   QTest::addColumn("pos");
  >   QTest::addColumn("contains");
  >
  >
  > ?
  
  
  Don't know. I've just checked again and the current autotest fails without 
the change on current master and works with the patch. I don't want to invest 
too much time in optimizing an autotest. If you think it can be done better, 
feel free to rewrite it.

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D15907

To: romangg, #kwin, zzag, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19077: Redesign the theme preview window

[Filip Fila]

filipf added a comment.


  In D19077#417105 , @ngraham wrote:
  
  > This introduces a new warning:
  >  WARNING: viewBackgroundColor is deprecated, use backgroundColor with 
colorSet: Theme.View instead
  
  
  I would use the new value, but it doesn't provide the same color as the old 
one. So that means it breaks the magical hack and I can't hit the sweet spot 
anymore by fiddling with opacity.
  
  > +1 on removing the italic styling. I also think bolding the title is 
unnecessary too while it's using its maximum size (level 1). Bolding it only 
seems necessary when it's closer to the size of the text below it.
  
  Both of these points make sense to me, +1
  
  > I still don't like how the ColumnLayout of information causes the 
bottom-most items to get cut off with the default System Settings window 
height. I think we could consolidate some of the information, like moving the 
license onto one of the other lines.
  
  It still gets cut off? Darn. Hmm OK, will have a better think about it myself 
as well.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D15907: Compare float values in DecorationButton contains check

[Roman Gilg]

romangg updated this revision to Diff 52257.
romangg marked an inline comment as done.
romangg added a comment.


  - Long variable names

REPOSITORY
  R129 Window Decoration Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D15907?vs=42753=52257

BRANCH
  decorationContainsFix

REVISION DETAIL
  https://phabricator.kde.org/D15907

AFFECTED FILES
  autotests/decorationbuttontest.cpp
  src/decorationbutton.cpp

To: romangg, #kwin, zzag, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

[Krešimir Čohar]

rooty updated this revision to Diff 52256.
rooty added a comment.


  Remove "Customize theme" heading

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19209?vs=52235=52256

BRANCH
  bckgr-label-padding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19209

AFFECTED FILES
  src/ui/themeconfig.ui

To: rooty, #vdg, #plasma, filipf, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19077: Redesign the theme preview window

[Nathaniel Graham]

ngraham added a comment.


  This introduces a new warning:
  
WARNING: viewBackgroundColor is deprecated, use backgroundColor with 
colorSet: Theme.View instead
  
  +1 on removing the italic styling. I also think bolding the title is 
unnecessary too while it's using its maximum size (level 1). Bolding it only 
seems necessary when it's closer to the size of the text below it.
  
  I still don't like how the ColumnLayout of information causes the bottom-most 
items to get cut off with the default System Settings window height. I think we 
could consolidate some of the information, like moving the license onto one of 
the other lines.
  
  Here's basically how it would look:
  F6628909: Screenshot_20190221_160448.png 


REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19011: Thunderbolt KCM and KDED module

[Daniel Vrátil]

dvratil updated this revision to Diff 52255.
dvratil added a comment.


  - fix look of the device list

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19011?vs=51737=52255

BRANCH
  arcpatch-D19011

REVISION DETAIL
  https://phabricator.kde.org/D19011

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/bolt/CMakeLists.txt
  autotests/bolt/data/default.json
  autotests/bolt/fakeserver/CMakeLists.txt
  autotests/bolt/fakeserver/fakedevice.cpp
  autotests/bolt/fakeserver/fakedevice.h
  autotests/bolt/fakeserver/fakemanager.cpp
  autotests/bolt/fakeserver/fakemanager.h
  autotests/bolt/fakeserver/fakeserver.cpp
  autotests/bolt/fakeserver/fakeserver.h
  autotests/bolt/fakeserver/main.cpp
  autotests/bolt/kded/CMakeLists.txt
  autotests/bolt/kded/kdedtest.cpp
  autotests/bolt/lib/CMakeLists.txt
  autotests/bolt/lib/devicetest.cpp
  autotests/bolt/lib/managertest.cpp
  cmake/modules/FindBolt.cmake
  kcms/CMakeLists.txt
  kcms/bolt/CMakeLists.txt
  kcms/bolt/Messages.sh
  kcms/bolt/kcm_bolt.cpp
  kcms/bolt/kcm_bolt.desktop
  kcms/bolt/kcm_bolt.h
  kcms/bolt/package/contents/ui/DeviceList.qml
  kcms/bolt/package/contents/ui/DeviceView.qml
  kcms/bolt/package/contents/ui/main.qml
  kcms/bolt/package/contents/ui/utils.js
  kcms/bolt/package/metadata.desktop
  kded/CMakeLists.txt
  kded/bolt/CMakeLists.txt
  kded/bolt/kded_bolt.cpp
  kded/bolt/kded_bolt.desktop
  kded/bolt/kded_bolt.h
  kded/bolt/kded_bolt.notifyrc
  kded/bolt/main.cpp
  libs/CMakeLists.txt
  libs/bolt/CMakeLists.txt
  libs/bolt/dbushelper.cpp
  libs/bolt/dbushelper.h
  libs/bolt/device.cpp
  libs/bolt/device.h
  libs/bolt/devicemodel.cpp
  libs/bolt/devicemodel.h
  libs/bolt/enum.cpp
  libs/bolt/enum.h
  libs/bolt/interfaces/org.freedesktop.bolt1.device.xml
  libs/bolt/interfaces/org.freedesktop.bolt1.manager.xml
  libs/bolt/manager.cpp
  libs/bolt/manager.h

To: dvratil, #vdg, #plasma
Cc: bernieinnocenti, andreask, ndavis, trickyricky26, abetts, fabianr, ngraham, 
broulik, ognarb, yurchor, asturmlechner, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19077: Redesign the theme preview window

[Björn Feber]

GB_2 added a comment.


  In D19077#417065 , @filipf wrote:
  
  > OK so down to only one hack now. If possible I'd really like to keep it 
because it works in 100% of the cases I tested it with and results in better 
visuals; don't know how to fix on the C++ side of things.
  >
  > Couple of things that might be worthy of being discussed:
  >
  > 1. changes to the layout of the text - @ngraham already had some 
suggestions, @abetts do you have some other ideas?
  > 2. add a dummy rectangle that would show up when there is no previewImage 
and that would say "Image preview not available"?
  
  
  It could show a Kirigami Icon "view-preview" when there's no image. 
  Can you also change the description to not be italic?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: GB_2, mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19210: [Updates page] Try our best to not elide version strings

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Discover Software Store, colomar.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  With this patch, Discover will try its back to never elide version strings on 
the
  Updates page. It will first fall back to a shorter squeezed string that only 
shows the
  available version, then elide from the left so that the most important part 
doesn't get
  cut off.
  
  All of this is mostly only a problem on KDE Neon when using widescreen or 
mobile view,
  but it's nice to fix anyway.

TEST PLAN
  F6628861: Squeezey.png 

REPOSITORY
  R134 Discover Software Store

BRANCH
  make-version-text-more-visible-in-limited-spaces (branched from Plasma/5.15)

REVISION DETAIL
  https://phabricator.kde.org/D19210

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: ngraham, #discover_software_store, colomar
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19077: Redesign the theme preview window

[Filip Fila]

filipf added a comment.


  OK so down to only one hack now. If possible I'd really like to keep it 
because it works in 100% of the cases I tested it with and results in better 
visuals; don't know how to fix on the C++ side of things.
  
  Couple of things that might be worthy of being discussed:
  
  1. changes to the layout of the text - @ngraham already had some suggestions, 
@abetts do you have some other ideas?
  2. add a dummy rectangle that would show up when there is no previewImage and 
that would say "Image preview not available"?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19077: Redesign the theme preview window

[Filip Fila]

filipf updated this revision to Diff 52249.
filipf added a comment.


  clean up whitespace, remove MouseArea hacks, remove the double Rectangle hack 
by defining height 
  with Units.gridUnit, add spacing below the last label, better samples value 
for the DropShadow

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19077?vs=52181=52249

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19077

AFFECTED FILES
  src/qml/main.qml

To: filipf, #plasma, #vdg, ngraham
Cc: mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19157: Don't show entries with NoDisplay=true with the applauncher containmentaction

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:8192bd3aec27: Dont show entries with NoDisplay=true 
with the applauncher containmentaction (authored by fvogt).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19157?vs=52068=52243

REVISION DETAIL
  https://phabricator.kde.org/D19157

AFFECTED FILES
  containmentactions/applauncher/launch.cpp

To: fvogt, #plasma, hein
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

[Nathaniel Graham]

ngraham updated this revision to Diff 52242.
ngraham marked an inline comment as done.
ngraham added a comment.


  Correct awkward string

REPOSITORY
  R122 Powerdevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19186?vs=52156=52242

BRANCH
  use-the-word-sleep (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19186

AFFECTED FILES
  daemon/actions/bundled/handlebuttoneventsconfig.cpp
  daemon/actions/bundled/suspendsessionconfig.cpp
  doc/kcm/index.docbook
  kcmodule/activities/activityWidget.ui
  kcmodule/activities/activitywidget.cpp
  kcmodule/global/GeneralPage.cpp

To: ngraham, #vdg, #plasma, broulik
Cc: ltoscano, abetts, aacid, plasma-devel, kde-doc-english, jraleigh, gennad, 
GB_2, ragreen, Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

[Luigi Toscano]

ltoscano added inline comments.

INLINE COMMENTS

> index.docbook:152
>  
> -If this option is chosen, a special behavior for activity can be chosen. If 
> this is a presentation activity, you can check the Never shutdown 
> the screen and Never suspend or shutdown the 
> computer boxes. It is also possible to define the time interval 
> for the computer to switch to a suspension mode for the power saving 
> activities.
> +If this option is chosen, a special behavior for activity can be chosen. If 
> this is a presentation activity, you can check the Never shutdown 
> the screen and Never sleep or shutdown the 
> computer boxes. It is also possible to define the time interval 
> for the computer to switch to a suspension mode for the power saving 
> activities.
>  

I'm not a native speaker, but this transitive construction of sleep ("never 
sleep the computer"?) sounds a bit strange.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19186

To: ngraham, #vdg, #plasma, broulik
Cc: ltoscano, abetts, aacid, plasma-devel, kde-doc-english, jraleigh, gennad, 
GB_2, ragreen, Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

[Nathaniel Graham]

ngraham added a comment.


  In D19186#416850 , @aacid wrote:
  
  > -0.2 from my side, the thing is called suspend not sleep, if you look for 
"linux sleep" in a search engine you get references to the sleep (3) and sleep 
(1) man pages, which would only confuse the users.
  
  
  Why would a person do a web search for "Linux sleep"? If they're a 
non-technical user, they already know what "Sleep" means because it's the same 
term that Windows and macOS use, so that don't have to do a web search to 
figure out what it means.
  
  And if they're a technical user, they won't be confused by the distinction 
between the "Sleep" power management action and the `sleep` shell command.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19186

To: ngraham, #vdg, #plasma, broulik
Cc: abetts, aacid, plasma-devel, kde-doc-english, jraleigh, gennad, GB_2, 
ragreen, Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19186

To: ngraham, #vdg, #plasma, broulik
Cc: abetts, aacid, plasma-devel, kde-doc-english, jraleigh, gennad, GB_2, 
ragreen, Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, 
sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19209

To: rooty, #vdg, #plasma, filipf, ngraham
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

[Filip Fila]

filipf added a comment.


  In D19209#416946 , @rooty wrote:
  
  > Also, should we ditch the heading "Customize theme"? It doesn't seem 
necessary seeing as there's nothing to customize... aside from the wallpaper
  
  
  I'm also in favor of this, it's a bit misleading. Good job aligning things!

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19209

To: rooty, #vdg, #plasma, filipf, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

[Nathaniel Graham]

ngraham added a comment.


  In D19209#416946 , @rooty wrote:
  
  > Also, should we ditch the heading "Customize theme"? It doesn't seem 
necessary seeing as there's nothing to customize... aside from the wallpaper
  
  
  Yes please!

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19209

To: rooty, #vdg, #plasma, filipf, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19192: [Updates page] Improve selected/unselected explanation view

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:5d254de6fa4f: [Updates page] Improve selected/unselected 
explanation view (authored by ngraham).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19192?vs=52176=52238

REVISION DETAIL
  https://phabricator.kde.org/D19192

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: ngraham, #vdg, #discover_software_store, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D19192: [Updates page] Improve selected/unselected explanation view

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Otherwise it should go in.

INLINE COMMENTS

> UpdatesPage.qml:110
>  Layout.fillWidth: true
> +text: (page.unselected === 0 ? i18n("All updates selected") 
> : i18np("%1/%2 update selected", "%1/%2 updates selected", 
> updateModel.toUpdateCount, updateModel.totalUpdatesCount)) + " (" + 
> updateModel.updateSize + ")"
> +elide: Text.ElideRight

instead of appending the `(123)` bit in the end, can you include it in the 
i18np call?

REPOSITORY
  R134 Discover Software Store

BRANCH
  improve-selected-updated-view (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19192

To: ngraham, #vdg, #discover_software_store, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D19077: Redesign the theme preview window

[Filip Fila]

filipf added a comment.


  In D19077#416726 , @mmustac wrote:
  
  > To be honest this kcm looks out of place when I compare it to the newer 
refurbished ones. The new look is quite an improvement compared to the current 
state but when I look at the color, window decoration kcm we have at first a 
big grid view and can then customize those themes by pressing the floating edit 
buttons which appear while hovering over them. Personally I would suggest to 
transfer those behavior to this kcm too to keep the uniefed design and workflow.
  
  
  I fully agree, but porting the whole KCM is outside the scope of my skills at 
this moment unfortunately.
  
  P.S Pozdrav ako si naš sunarodnjak

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19160: [about-distro] update osrelease parser for latest values in spec

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Makes sense, also thanks for adding a test!
  In Discover we're also parsing os-release files (in 2 places), it could make 
sense to share this code somehow.

REPOSITORY
  R102 KInfoCenter

BRANCH
  os-relesae

REVISION DETAIL
  https://phabricator.kde.org/D19160

To: sitter, apol
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D19181: [about-distro] run logo lookup via osrelease

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> Module.cpp:153
> +
> +QString logoPath = cg.readEntry("LogoPath", QString());
> +if (logoPath.isEmpty()) {

Put os.logo as the fallback?

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D19181

To: sitter
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D19187: unbreak help button activation by not double-resetting the view

[Aleix Pol Gonzalez]

apol added a comment.


  +1

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D19187

To: sitter, #plasma
Cc: apol, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, mart

D19077: Redesign the theme preview window

[Krešimir Čohar]

rooty added a comment.


  In D19077#416726 , @mmustac wrote:
  
  > To be honest this kcm looks out of place when I compare it to the newer 
refurbished ones. The new look is quite an improvement compared to the current 
state but when I look at the color, window decoration kcm we have at first a 
big grid view and can then customize those themes by pressing the floating edit 
buttons which appear while hovering over them. Personally I would suggest to 
transfer those behavior to this kcm too to keep the uniefed design and workflow.
  
  
  I agree. But in the meantime this doesn't seem like a bad fix either. You 
should check out D19209  as well

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19162: Add KAboutData

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> powerdevilapp.cpp:69
> + i18nc("@info:credit", "(c) 2015-2019 Kai Uwe 
> Broulik"));
> +aboutData.addAuthor(i18nc("@info:credit", "Kai Uwe Broulik"),
> +i18nc("@info:credit", "Maintainer"),

PRobably doesn't make sense to translate names, no?

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19162

To: broulik, #plasma, sitter
Cc: apol, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart

D19209: [sddm-kcm] Adjust Background label and button

[Krešimir Čohar]

rooty added a comment.


  Also, should we ditch the heading "Customize theme"? It doesn't seem 
necessary seeing as there's nothing to customize... aside from the wallpaper

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19209

To: rooty, #vdg, #plasma, filipf, ngraham
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19209: [sddm-kcm] Adjust Background label and button

[Krešimir Čohar]

rooty created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
rooty requested review of this revision.

REVISION SUMMARY
  This patch adjusts the "Background:" label (adds padding and changes its 
alignment) and button to align with the changes implemented in D19077 
. It also moves the background preview 
button to below its corresponding label.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  bckgr-label-padding (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19209

AFFECTED FILES
  src/ui/themeconfig.ui

To: rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19206: [Colors KCM] Fix color scheme editor context

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5c879b258391: [Colors KCM] Fix color scheme editor 
context (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19206?vs=52225=52230

REVISION DETAIL
  https://phabricator.kde.org/D19206

AFFECTED FILES
  kcms/colors/package/contents/ui/main.qml

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19186: [KCM & UI] Use the word "Sleep" instead of "Suspend"

[Albert Astals Cid]

aacid added a comment.


  -0.2 from my side, the thing is called suspend not sleep, if you look for 
"linux sleep" in a search engine you get references to the sleep (3) and sleep 
(1) man pages, which would only confuse the users.

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D19186

To: ngraham, #vdg, #plasma, broulik
Cc: aacid, plasma-devel, kde-doc-english, jraleigh, gennad, GB_2, ragreen, 
Pitel, ZrenBot, skadinna, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D19206: [Colors KCM] Fix color scheme editor context

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  `Kirigami.Action` has no `parent`

TEST PLAN
  Classic case of "how could this have ever worked"
  
  - edited scheme, is now modal to the kcm again in both syse and kcmshell

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19206

AFFECTED FILES
  kcms/colors/package/contents/ui/main.qml

To: broulik, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18644: GlobalDrawerActionItem: properly reference icon by using group property.

[Paweł Wegner]

pwegner updated this revision to Diff 52223.
pwegner added a comment.


  rebased with master

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18644?vs=50647=52223

BRANCH
  arcpatch-D18644_1

REVISION DETAIL
  https://phabricator.kde.org/D18644

AFFECTED FILES
  src/controls/private/GlobalDrawerActionItem.qml

To: pwegner, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18939: KMenuEdit: add search/filter bar

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  LGTM. @cfeck, are you happy now?

REPOSITORY
  R103 KMenu Editor

BRANCH
  search-bar

REVISION DETAIL
  https://phabricator.kde.org/D18939

To: tuxxi, ngraham, #plasma, cfeck
Cc: ognarb, mlaurent, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19023: [Kickoff] Don't respond to window resizing/tiling shortcuts

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7a33e1130612: [Kickoff] Dont respond to window 
resizing/tiling shortcuts (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19023?vs=51719=52219

REVISION DETAIL
  https://phabricator.kde.org/D19023

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: ngraham, #plasma, hein
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19154: [Kickoff] remove hint state

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1312ab1cb4fe: [Kickoff] remove hint state (authored by 
matthieugras, committed by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19154?vs=52064=52217

REVISION DETAIL
  https://phabricator.kde.org/D19154

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: matthieugras, #plasma, hein, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19096: Improvements for long label items in Application Dashboard

[Nathaniel Graham]

ngraham added a comment.


  Works great on my 1920x1080 screen BTW.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19096

To: trmdi, ngraham, hein, #plasma, #vdg
Cc: abetts, ndavis, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18716: Add an ActionTextField component

[Carl Schwan]

ognarb updated this revision to Diff 52214.
ognarb marked 2 inline comments as done.
ognarb added a comment.


  - Revert unrelated change
  - Use icon.name instead of iconName

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18716?vs=52204=52214

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18716

AFFECTED FILES
  examples/simpleexamples/Sidebar.qml
  kirigami.qrc
  kirigami.qrc.in
  src/controls/ActionTextField.qml
  src/kirigamiplugin.cpp
  src/qmldir

To: ognarb, apol, #kirigami, ngraham, mart
Cc: broulik, mart, apol, ngraham, plasma-devel, dkardarakos, davidedmundson, 
hein

D19148: Make shadow sizes linear

[Vlad Zagorodniy]

zzag added a comment.


  In D19148#416006 , @ndavis wrote:
  
  > kstyle uses entirely different shadows, even more so compared to the 
original values for kdecoration. Should it not be that way?
  
  
  Well, my concern was that now decoration shadows are way too black in 
comparison to kstyle shadows.
  
  Also, I have a question about shadow that comes from directional light, why 
opacity decreases as size increases? Shouldn't it be vice versa?

REPOSITORY
  R31 Breeze

BRANCH
  shadow-sizes (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19148

To: ndavis, #vdg, #breeze, ngraham
Cc: filipf, ngraham, zzag, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18644: GlobalDrawerActionItem: properly reference icon by using group property.

[Marco Martin]

mart added a comment.


  ping?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18644

To: pwegner, #kirigami, mart
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D18716: Add an ActionTextField component

[Marco Martin]

mart added a comment.


  it''s lmost perfect,
  just a little point on the icon loading, then is good to go

INLINE COMMENTS

> MultipleColumnsGallery.qml:61
>  Controls.Label {
> -anchors.horizontalCenter: parent.horizontalCenter
> +Layout.alignment: Qt.AlignHCenter
>  text: "Page implicitWidth: " + page.implicitWidth

unrelated change, separate commit?

> ActionTextField.qml:103
> +width: this.implicitHeight - 2 * Kirigami.Units.smallSpacing
> +source: modelData.iconName
> +visible: modelData.visible

icon.name, so will work also with qqc2 actions

or better:
source: modelData.icon.name.length > 0 ? modelData.icon.name : 
modelData.icon.source

> ActionTextField.qml:124
> +width: this.implicitHeight - 2 * Kirigami.Units.smallSpacing
> +source: modelData.iconName
> +visible: modelData.visible

icon.name

or better:
source: modelData.icon.name.length > 0 ? modelData.icon.name : 
modelData.icon.source

> ognarb wrote in kirigamiplugin.cpp:181
> @mart Should I use 2.6 or 2.7? I didn't find any information about that 
> version I should use.

2.7

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D18716

To: ognarb, apol, #kirigami, ngraham, mart
Cc: broulik, mart, apol, ngraham, plasma-devel, dkardarakos, davidedmundson, 
hein

D19077: Redesign the theme preview window

[Marijo Mustac]

mmustac added a comment.


  To be honest this kcm looks out of place when I compare it to the newer 
refurbished ones. The new look is quite an improvement compared to the current 
state but when I look at the color, window decoration kcm we have at first a 
big grid view and can then customize those themes by pressing the floating edit 
buttons which appear while hovering over them. Personally I would suggest to 
transfer those behavior to this kcm too to keep the uniefed design and workflow.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: mmustac, davidedmundson, abetts, rooty, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19203: ColumnView and partial C++ refactor of PageRow

[Marco Martin]

mart created this revision.
mart added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  ColumnView is a container component which encapsulates most of the logic from 
PageRow
  (minus the instantiation of components from paths which stays in PageRow)
  with that, new features are possible, such as having expanded pages which 
aren't the last one 
  or inserting/removing arbitrary pages, to make it behave not like a stack.
  This solves also some glitches as ListView is quite buggy.

TEST PLAN
  tested with Kirigmai Gallery and some other apps such as the new PureMaps 
which needs some of 
  the new features.
  By normal usage, no visual change should occur.

REPOSITORY
  R169 Kirigami

BRANCH
  mart/columnsView

REVISION DETAIL
  https://phabricator.kde.org/D19203

AFFECTED FILES
  src/CMakeLists.txt
  src/columnview.cpp
  src/columnview.h
  src/columnview_p.h
  src/controls/Page.qml
  src/controls/PageRow.qml
  src/controls/private/ActionButton.qml
  src/kirigamiplugin.cpp

To: mart, #kirigami
Cc: plasma-devel, dkardarakos, apol, davidedmundson, mart, hein

D19077: Redesign the theme preview window

[Krešimir Čohar]

rooty added a comment.


  This color "hack" actually makes the rectangle's color match some kind of 
weird in-between color that's not in the color scheme:
  F6628246: 75f5ca80-946e-4324-8f24-977fc96bc09b.jpeg 

  It takes on a color like the Applications tab in this picture - a color that 
can't be found in the color scheme as far as I can tell.
  The same thing happens in the SDDM KCM, so naturally none of the Kirigami 
theme colors fit.
  
  Is this a bug, by the way? Or a feature?
  Because it seems to, in a sense, override color scheme settings?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D19077

To: filipf, #plasma, #vdg, ngraham
Cc: davidedmundson, abetts, rooty, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19194: Adjust date string height to match time string with vertical panel

[Nathaniel Graham]

ngraham added subscribers: Zren, davidedmundson, ngraham.
ngraham added reviewers: Plasma, davidedmundson, Zren.
ngraham added a comment.


  Thank you for the patch! You did great, and on the first try, too!
  
  I can confirm that this change fixes the issue for me and I do not notice any 
visual regressions when using a horizontal or vertical panel, either with the 
default height, or a taller/wider height. The code change looks sane on the 
surface (more than sane even, since it's removing the use of a magic number), 
however I'm not super familiar with this code so I'd like @zren and/or 
@davidedmundson to sign off on this first.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19194

To: antnyzilla, #vdg, #plasma, davidedmundson, Zren
Cc: ngraham, davidedmundson, Zren, abetts, anthonyfieroni, plasma-devel, 
jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D19194: Adjust date string height to match time string with vertical panel

[Andres Betts]

abetts added a comment.


  I would probably add just a bit of left and right padding to the time as 
well. LGTM

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19194

To: antnyzilla, #vdg
Cc: abetts, anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D18716: Add an ActionTextField component

[Carl Schwan]

ognarb updated this revision to Diff 52204.
ognarb added a comment.


  - Use Kirigami.Icon instead of Controls.ToolBouton
  - Fix doc

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D18716?vs=52141=52204

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D18716

AFFECTED FILES
  examples/simpleexamples/MultipleColumnsGallery.qml
  examples/simpleexamples/Sidebar.qml
  kirigami.qrc
  kirigami.qrc.in
  src/controls/ActionTextField.qml
  src/kirigamiplugin.cpp
  src/qmldir

To: ognarb, apol, #kirigami, ngraham, mart
Cc: broulik, mart, apol, ngraham, plasma-devel, dkardarakos, davidedmundson, 
hein

D19179: Use PointingHand when hovering links in Label

[Dan Leinir Turthra Jensen]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:632c9cce4a3b: Use PointingHand when hovering links in 
Label (authored by leinir).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19179?vs=52136=52197#toc

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19179?vs=52136=52197

REVISION DETAIL
  https://phabricator.kde.org/D19179

AFFECTED FILES
  org.kde.desktop/Label.qml

To: leinir, ngraham, apol, mart, #kirigami
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, dkardarakos, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, 
mart, hein

D19044: [InlineMessage] Do not draw shadows around the message

[Marco Martin]

mart added a comment.


  - whole InlineMessage should be moved into templates
  - background: item should be deleted such that it doesn't have any background 
at all (lines from 123 to 173)
  - in controls, an InlineMessage.qml is still present, and will be
  
  import "templates" as T
  T.InlineMessage {
  
background: the original background item
  
  }
  
  that one won't have a shadow, in styles/Material another similar one, but 
with the original shadow

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19044

To: filipf, #vdg, #kirigami, ngraham, mart
Cc: rooty, ndavis, mart, abetts, plasma-devel, dkardarakos, apol, 
davidedmundson, hein

D19179: Use PointingHand when hovering links in Label

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  actually the hoverhandler seems not to be adapt for the job, so go for it

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D19179

To: leinir, ngraham, apol, mart, #kirigami
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, dkardarakos, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, davidedmundson, 
mart, hein

D19180: map powerdevil daemon to product

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:3a77c89068f7: map powerdevil daemon to product (authored 
by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19180?vs=52142=52196

REVISION DETAIL
  https://phabricator.kde.org/D19180

AFFECTED FILES
  src/data/mappings

To: sitter, broulik, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D15907: Compare float values in DecorationButton contains check

[Vlad Zagorodniy]

zzag requested changes to this revision.
zzag added a comment.
This revision now requires changes to proceed.


  See my comment above.

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D15907

To: romangg, #kwin, zzag, davidedmundson
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19194: Adjust date string height to match time string with vertical panel

[Antny Zilla]

antnyzilla added a comment.


  Is the panel orientation checked on lines 101, 183, and 256? I haven't 
noticed any changes or problems with the horizontal panel with this change on 
my system.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19194

To: antnyzilla, #vdg
Cc: anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19194: Adjust date string height to match time string with vertical panel

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> DigitalClock.qml:305
>  // this can be marginal bigger than contentHeight because of 
> the horizontal fit
> -height: Math.max(0.8 * timeLabel.height, minimumPixelSize)
> +height: sizehelper.contentHeight
>  width: main.width

You should check if panel orientation, now it's broken horizontal view?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19194

To: antnyzilla, #vdg
Cc: anthonyfieroni, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart