D19214: [sddm-theme] Replace login button label with icon

rooty added a comment. In D19214#424462 , @abetts wrote: > In D19214#424110 , @rooty wrote: > > > In D19214#424106 , @ngraham wrote: > > > > > Hmm, the

Re: Plasma Sprint 2019 in València

I checked dates again, it should be fine On Mon, Mar 4, 2019, 14:20 Aleix Pol wrote: > Does that mean you can't on those days? How does this change the > prospect sprint? > > Aleix > > On Mon, Mar 4, 2019 at 11:08 AM Marco Martin wrote: > > > > On giovedì 28 febbraio 2019 08:47:18 CET Kai Uwe B

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

rooty added a comment. In D19468#424857 , @filipf wrote: > In D19468#423984 , @rooty wrote: > > > Considering that there's an outline around the clock and the username now as a fallback option, shoul

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

rooty added a comment. P.S. I've been using this for a couple of days now, and I really like it. Another idea (for another diff) - we could also ditch the "Plasma made by KDE" label and logo in the bottom right corner seeing as we already have the Plasma logo above the spinning circle? It ma

Re: Plasma Sprint 2019 in València

I don't have it at hand, but does that really matter? Aleix On Mon, Mar 4, 2019 at 6:54 PM Noah Davis wrote: > > What is the address of the place we will meet? > > On 3/4/19, Aleix Pol wrote: > > Does that mean you can't on those days? How does this change the > > prospect sprint? > > > > Aleix

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

filipf added a comment. In D19468#423984 , @rooty wrote: > Considering that there's an outline around the clock and the username now as a fallback option, should we add one to the action buttons too? I think we only need an outline around

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

filipf added a comment. In D19479#424236 , @davidedmundson wrote: > > Could we use QtRendering to work around the issue until the patch lands? > > Go for it. Add a comment why we're doing it Thanks! Done in D19510

D19467: [colors-kcm] Fix blurry previews

filipf added a comment. In D19467#424552 , @davidedmundson wrote: > @filipf It's time for to learn the magic of gammaray ! > > gammaray kcmshell5 colors > > and go to the quick scenes tabs. It might tell you something useful. Gam

D19496: [kcm/componentchooser] Remove unused ktimerdialog.{h,cpp}

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:14d6402abc34: [kcm/componentchooser] Remove unused ktimerdialog.{h,cpp} (authored by volkov). REPOSITORY R119 Plasma

D19518: Make Ctrl+A work regardless of focus and visualize active selection in search heading

hein added inline comments. INLINE COMMENTS > broulik wrote in DashboardRepresentation.qml:287 > This change will change to `QtRendering` (which could be sensible on that > large font size, though, but just so you're aware) I was debating this. If I use `QQC2.TextField`, I have to do stuff to r

D19465: Port to ECM's component/imported target based FindXCB

This revision was automatically updated to reflect the committed changes. Closed by commit R119:8c28ac839ad5: Port to ECM's component/imported target based FindXCB (authored by vkrause). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19465?vs=52948&id=5

D19463: Use FindGLIB2 from ECM

This revision was automatically updated to reflect the committed changes. Closed by commit R115:0b1559c47c3a: Use FindGLIB2 from ECM (authored by vkrause). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19463?vs=52944&id=53157 REVISION DETA

D19518: Make Ctrl+A work regardless of focus and visualize active selection in search heading

broulik added inline comments. INLINE COMMENTS > DashboardRepresentation.qml:287 > > -PlasmaExtras.Heading { > +TextEdit { > id: searchHeading This change will change to `QtRendering` (which could be sensible on that large font size, though, but just so you're awa

D19502: Add a SearchField and PasswordField component

ognarb added inline comments. INLINE COMMENTS > broulik wrote in SearchField.qml:44 > I think this is fine but may need a translation domain > `i18nd("whatever_domain_kirigami_uses", "Search...")` Are you sure? It would mean that Kirigami should then depends on ki18n. And them Kirigami wouldn'

Re: Plasma Sprint 2019 in València

What is the address of the place we will meet? On 3/4/19, Aleix Pol wrote: > Does that mean you can't on those days? How does this change the > prospect sprint? > > Aleix > > On Mon, Mar 4, 2019 at 11:08 AM Marco Martin wrote: >> >> On giovedì 28 febbraio 2019 08:47:18 CET Kai Uwe Broulik wrote:

D19309: Improve Unity Indicator

This revision was automatically updated to reflect the committed changes. Closed by commit R878:cf0182e827c6: Improve Unity Indicator (authored by trmdi, committed by mvourlakos). REPOSITORY R878 Latte Dock CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19309?vs=52545&id=53143 REVIS

D19284: Close the window selected in the task group tooltip on middle click

mvourlakos added a comment. I can commit this for you, but I need an email address REPOSITORY R878 Latte Dock REVISION DETAIL https://phabricator.kde.org/D19284 To: nickguletskii, #latte_dock, mvourlakos Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai,

D19419: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string to suit latest changes on the webpage

tagorechandanreddy added a comment. This patch is meant to be a more complete solution to handle the random HTML changes on the webpage. Without this patch, the plugin fails on odd occasions as the webpage gets updated daily. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabric

D19392: shannon entropy to guess monochrome icon

davidedmundson added a comment. > so, for gtk4/qt6, the base qiconengine included in qt should support whatever coloring is used, in which case i wouldn't need to do anything on my part.. tough that's for Qt6. It won't magically happen on it's own. I've emailed the XDG mailing l

D19475: Only match service text strings once

This revision was automatically updated to reflect the committed changes. Closed by commit R120:68a2807654c6: Only match service text strings once (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19475?vs=52984&id=53140 RE

D19423: Fix QLatin1String usage

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b0e84dbe2cb6: Fix QLatin1String usage (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19423?vs=52834&id=53139 REVISION DETAIL

D19467: [colors-kcm] Fix blurry previews

davidedmundson added a comment. @filipf It's time for to learn the magic of gammaray ! gammaray kcmshell5 colors and go to the quick scenes tabs. It might tell you something useful. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19467 To: filipf, b

D19467: [colors-kcm] Fix blurry previews

ngraham added a comment. Make its flickable have `pixelAligned: true`, maybe? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19467 To: filipf, broulik, #vdg, rooty, davidedmundson Cc: ngraham, abetts, davidedmundson, rooty, plasma-devel, jraleigh, GB_2, ragr

D19467: [colors-kcm] Fix blurry previews

filipf added a comment. Actually now that I take a closer look all of our previews are blurry. It's because there's text in the colors KCM that it becomes obvious. Compare the desktop theme KCM preview in its original state: F6656755: Screenshot_20190304_173527.png

D19518: Make Ctrl+A work regardless of focus and visualize active selection in search heading

hein created this revision. hein added a reviewer: Plasma. Herald added a project: Plasma. hein requested review of this revision. REVISION SUMMARY BUG:405076 REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D19518 AFFECTED FILES applets/kicker

D19419: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string to suit latest changes on the webpage

ngraham added a comment. In D19419#424176 , @tagorechandanreddy wrote: > The HTML of the webpage is updated with random whitespace characters and newline characters. But does that make it actually not work at the moment? REPOSITORY R1

D19467: [colors-kcm] Fix blurry previews

davidedmundson added a comment. Why does this make a difference to things being blurry? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19467 To: filipf, broulik, #vdg, rooty, davidedmundson Cc: abetts, davidedmundson, rooty, plasma-devel, jraleigh, GB_2, ragr

D19467: [colors-kcm] Fix blurry previews

abetts added a comment. +1 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19467 To: filipf, broulik, #vdg, rooty, davidedmundson Cc: abetts, davidedmundson, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg

D19315: Use ActionTextField to implement the searchField in system settings

abetts added a comment. +1 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D19315 To: ognarb, #plasma, ngraham Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

abetts added a comment. +1 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19478 To: filipf, ngraham, #vdg, #plasma, rooty Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, ap

D19214: [sddm-theme] Replace login button label with icon

abetts added a comment. In D19214#424110 , @rooty wrote: > In D19214#424106 , @ngraham wrote: > > > Hmm, the Kirigami text field doesn't look like that in an app. Must be some weird SDDM environment

D19259: [Task Manager] Fix sorting of tasks on last desktop in sort-by-desktop mode

hein updated this revision to Diff 53131. hein added a comment. Fix sorting and fallthrough for tasks on all desktops. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19259?vs=52695&id=53131 BRANCH master REVISION DETAIL https://phabricator.kd

Re: New maintainers wanted: KDE Telepathy, KAccounts, Plasma Notifications and others

On Mon, Mar 4, 2019 at 9:32 AM Alexander Akulich wrote: > Hi Martin and everyone. > > I would like to take over the KDE Telepathy maintainership. > > I understand that Telepathy is a huge and complex project that needs a > lot of manpower to actually come back, but there is no other project > wit

D19510: [Logout screen] Fix label opacity failing

rooty added a comment. This is a neat workaround as discussed in D19479 REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19510 To: filipf, #plasma, ngraham, rooty Cc: plasma-devel, jraleigh, GB_2, ragreen

Re: New maintainers wanted: KDE Telepathy, KAccounts, Plasma Notifications and others

Hi Martin and everyone. I would like to take over the KDE Telepathy maintainership. I understand that Telepathy is a huge and complex project that needs a lot of manpower to actually come back, but there is no other project with the same goals and capabilities. For me, Telepathy is not the exact

D19510: [Logout screen] Fix label opacity failing

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Due to Qt bug: https://bugreports.qt.io/browse/QTBUG-70138 (KDE bug: https://bugs.kde.org/show_bug.cgi?id=401644) we have label opac

Re: Plasma Sprint 2019 in València

Does that mean you can't on those days? How does this change the prospect sprint? Aleix On Mon, Mar 4, 2019 at 11:08 AM Marco Martin wrote: > > On giovedì 28 febbraio 2019 08:47:18 CET Kai Uwe Broulik wrote: > > Hi, > > > > > Sounds like we have some critical mass, Alejandro tells me that > > >

D19119: ApplicationPage: include the available version when selecting the source

This revision was automatically updated to reflect the committed changes. Closed by commit R134:f6ec0a29c42a: ApplicationPage: include the available version when selecting the source (authored by apol). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde

D19306: send a signal over dbus when the wrong password is provided

This revision was automatically updated to reflect the committed changes. Closed by commit R116:63a541c4425f: send a signal over dbus when the wrong password is provided (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D19306?vs=52541&id=53118#toc REPOSITORY R116 Plasm

Upgrading Widgets from plasma-workspace

Good day. Need your help.  I am Upgrading Widgets from plasma-workspace and faced a number of problems.  I will show the modernization goals using the example of the diskactivity widget, designed to visualize hard drive activity:  1) At the moment when the widget is first loaded after installa

D19315: Use ActionTextField to implement the searchField in system settings

This revision was automatically updated to reflect the committed changes. Closed by commit R124:e80cbf128f77: Use ActionTextField to implement the searchField in system settings (authored by ognarb). REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19315

Notes for 4/3/2019 monday meeting

Eike: * Not much from my end however * I'd like a review for https://phabricator.kde.org/D19257, it's been sitting for 2-3 weeks * I'm also finishing https://phabricator.kde.org/D19259 after the meeting, you could combine reviewing that in a few hours, too Kai Uwe: Work done: - Found (well, fvog

D19389: [WIP] Rewrite kworkspace logout, shutdown and suspend API

davidedmundson updated this revision to Diff 53111. davidedmundson added a comment. add hybrid suspend REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19389?vs=52736&id=53111 REVISION DETAIL https://phabricator.kde.org/D19389 AFFECTED FILES li

D18438: [Task Manager] When closing apps, resize only when mouse is out.

hein added a comment. Sorry for the late reply, too. The role is `WinIdList`. REPOSITORY R119 Plasma Desktop BRANCH arc_taskmanagerclose (branched from master) REVISION DETAIL https://phabricator.kde.org/D18438 To: thsurrel, #plasma, #vdg, hein Cc: hein, plasma-devel, jraleigh, G

D19502: Add a SearchField and PasswordField component

ognarb updated this revision to Diff 53106. ognarb marked 8 inline comments as done. ognarb edited the summary of this revision. ognarb added a comment. - Fix typos in doc - Remove edi-clear button in password field REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.

Re: Plasma Sprint 2019 in València

On giovedì 28 febbraio 2019 08:47:18 CET Kai Uwe Broulik wrote: > Hi, > > > Sounds like we have some critical mass, Alejandro tells me that > > there's space so let's settle for the 23rd June week. > > Is Wednesday, 19 Arrival day and Sunday, 23 Departure day, or actual > sprint days? oh, i toug

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

davidedmundson added a comment. > Could we use QtRendering to work around the issue until the patch lands? Go for it. Add a comment why we're doing it REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19479 To: filipf, rooty, ngraham, #vd

D19434: Change entry of Endpoint UI

jgrulich added a comment. In D19434#423613 , @andersonbruce wrote: > In D19434#423458 , @jgrulich wrote: > > > Shouldn't we maybe use QSpinBox for the port? With the spinbox you can also set min an

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

rooty added a comment. If I use PropertyAnimation instead of OpacityAnimator, the opacity problem seems to go away. Can anyone confirm? REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D19479 To: filipf, rooty, ngraham, #vdg, #plasma Cc: davi

D19500: [KDirModel] Fix job urls change signal connection

broulik added a comment. > Just out of curiosity, Did you notice the problem because something was missing in execution? I was toying around with the transfer jobs visible feature in `KDirModel` and got a warning when I enabled it. It isn't used by Dolphin anymore and not supported by P

D19500: [KDirModel] Fix job urls change signal connection

jtamate added a comment. +1. Just out of curiosity, Did you notice the problem because something was missing in execution? Unfortunately, neither the compiler nor I didn't noticed it. :-( REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D19500 To: broulik,

D19502: Add a SearchField and PasswordField component

broulik added inline comments. INLINE COMMENTS > PasswordField.qml:27 > + * > + * Example usage for the search field component: > + * @code password field > PasswordField.qml:33 > + * id: passwordField > + * onAccepted: console.log("Password text is " + passwordField.text) > + * } Bett