D19214: [sddm-theme] Replace login button label with icon

[Krešimir Čohar]

rooty added a comment.


  In D19214#424462 , @abetts wrote:
  
  > In D19214#424110 , @rooty wrote:
  >
  > > In D19214#424106 , @ngraham 
wrote:
  > >
  > > > Hmm, the Kirigami text field doesn't look like that in an app. Must be 
some weird SDDM environment thing?
  > > >
  > > > Either way, let's fix the height issue *somehow*. :)
  > >
  > >
  > > It's sorta ugly but what's tripping me up is... why doesn't it get 
smaller if i set pointSize to 1 (and gets bigger if I set it to, say, 32)
  >
  >
  > Would putting the > button "inside" the password field make it look better?
  
  
  I don't know, but I think it's an idea worth exploring
  I also think it would still suffer from the same height issues regardless of 
the button

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19214

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: abetts, ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

Re: Plasma Sprint 2019 in València

[Marco Martin]

I checked dates again, it should be fine

On Mon, Mar 4, 2019, 14:20 Aleix Pol  wrote:

> Does that mean you can't on those days? How does this change the
> prospect sprint?
>
> Aleix
>
> On Mon, Mar 4, 2019 at 11:08 AM Marco Martin  wrote:
> >
> > On giovedì 28 febbraio 2019 08:47:18 CET Kai Uwe Broulik wrote:
> > > Hi,
> > >
> > > > Sounds like we have some critical mass, Alejandro tells me that
> > > > there's space so let's settle for the 23rd June week.
> > >
> > > Is Wednesday, 19 Arrival day and Sunday, 23 Departure day, or actual
> > > sprint days?
> >
> > oh, i tought that option was 23rd arrival :/
> >
> >
> > --
> > Marco Martin
> >
> >
>

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

[Krešimir Čohar]

rooty added a comment.


  In D19468#424857 , @filipf wrote:
  
  > In D19468#423984 , @rooty wrote:
  >
  > > Considering that there's an outline around the clock and the username now 
as a fallback option, should we add one to the action buttons too?
  >
  >
  > I think we only need an outline around the clock since the rest only shows 
up with blur?
  >
  > But if blur fails with software rendering, then I think we need outlines 
for all the labels.
  
  
  Yes, sorry for not mentioning that - I didn't see any blur with software 
rendering and the labels didn't have outlines.
  I've been using QT_QUICK_BACKEND=software.
  
  It looks pretty bad, even with outlines:
  F6658248: image.png 
  
  Maybe we should implement some kind of crude substitute for the 
wallpaperfader blur effect and add more contrast to the buttons (icons and 
labels) while we're at it, so that the software rendering version looks good 
too.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19468

To: rooty, #vdg, ngraham
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19373: [RFC] [Splash Screen] Use current "Next" wallpaper as the background

[Krešimir Čohar]

rooty added a comment.


  P.S. I've been using this for a couple of days now, and I really like it. 
Another idea (for another diff) - we could also ditch the "Plasma made by KDE" 
label and logo in the bottom right corner seeing as we already have the Plasma 
logo above the spinning circle? It makes it really subtle (and you know how I 
like subtlety haha)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  splash-screen-uses-next-wallpaper (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D19373

To: ngraham, #vdg, #plasma, rooty
Cc: filipf, rooty, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Plasma Sprint 2019 in València

[Aleix Pol]

I don't have it at hand, but does that really matter?

Aleix

On Mon, Mar 4, 2019 at 6:54 PM Noah Davis  wrote:
>
> What is the address of the place we will meet?
>
> On 3/4/19, Aleix Pol  wrote:
> > Does that mean you can't on those days? How does this change the
> > prospect sprint?
> >
> > Aleix
> >
> > On Mon, Mar 4, 2019 at 11:08 AM Marco Martin  wrote:
> >>
> >> On giovedì 28 febbraio 2019 08:47:18 CET Kai Uwe Broulik wrote:
> >> > Hi,
> >> >
> >> > > Sounds like we have some critical mass, Alejandro tells me that
> >> > > there's space so let's settle for the 23rd June week.
> >> >
> >> > Is Wednesday, 19 Arrival day and Sunday, 23 Departure day, or actual
> >> > sprint days?
> >>
> >> oh, i tought that option was 23rd arrival :/
> >>
> >>
> >> --
> >> Marco Martin
> >>
> >>
> >

D19468: [sddm-theme/lock screen] Remove username shadow and show clock shadow only when unfocused

[Filip Fila]

filipf added a comment.


  In D19468#423984 , @rooty wrote:
  
  > Considering that there's an outline around the clock and the username now 
as a fallback option, should we add one to the action buttons too?
  
  
  I think we only need an outline around the clock since the rest only shows up 
with blur?
  
  But if blur fails with software rendering, then I think we need outlines for 
all the labels.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19468

To: rooty, #vdg, ngraham
Cc: filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

[Filip Fila]

filipf added a comment.


  In D19479#424236 , @davidedmundson 
wrote:
  
  > > Could we use QtRendering to work around the issue until the patch lands?
  >
  > Go for it. Add a comment why we're doing it
  
  
  Thanks! Done in D19510 
  
  As for this diff I now also find myself favoring circles appearing only on 
hover in the login and lock screens. While there is merit to consistency, I 
don't think the buttons there are of that great of an importance as in the 
logout screen. We also don't need to be solving any legibility issue.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19467: [colors-kcm] Fix blurry previews

[Filip Fila]

filipf added a comment.


  In D19467#424552 , @davidedmundson 
wrote:
  
  > @filipf  It's time for to learn the magic of gammaray !
  >
  > gammaray kcmshell5 colors
  >
  > and go to the quick scenes tabs. It might tell you something useful.
  
  
  Gammaray in Manjaro crashes any time Quick Scenes is opened for whichever 
KCM, KDE Neon Dev Unstable's Gammaray doesn't even have Quick Scenes :/
  
  As for possible solutions, I've tried adding Math.round just about anywhere 
possible in GridView and GridViewKCM but to no avail. Also tried `pixelAligned` 
but that didn't seem to work either.
  
  It would probably be best to continue search for the cause and solution on a 
bug report. I've found this one: https://bugs.kde.org/show_bug.cgi?id=393995

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19467

To: filipf, broulik, #vdg, rooty, davidedmundson
Cc: ngraham, abetts, davidedmundson, rooty, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19496: [kcm/componentchooser] Remove unused ktimerdialog.{h,cpp}

[Alexander Volkov]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R119:14d6402abc34: [kcm/componentchooser] Remove unused 
ktimerdialog.{h,cpp} (authored by volkov).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19496?vs=53079=53159

REVISION DETAIL
  https://phabricator.kde.org/D19496

AFFECTED FILES
  kcms/componentchooser/CMakeLists.txt
  kcms/componentchooser/ktimerdialog.cpp
  kcms/componentchooser/ktimerdialog.h

To: volkov, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19518: Make Ctrl+A work regardless of focus and visualize active selection in search heading

[Eike Hein]

hein added inline comments.

INLINE COMMENTS

> broulik wrote in DashboardRepresentation.qml:287
> This change will change to `QtRendering` (which could be sensible on that 
> large font size, though, but just so you're aware)

I was debating this. If I use `QQC2.TextField`, I have to do stuff to remove 
the default background and for proper sizing. If I use 
`PlasmaComponents.TextArea` it's similar. If I set `renderType`, it won't 
benefit from what PlasmaComponents and qqc2-desktop-style do wrt/ switching to 
`QtRendering` on non-integer scale factors.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19518

To: hein, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19465: Port to ECM's component/imported target based FindXCB

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:8c28ac839ad5: Port to ECMs component/imported 
target based FindXCB (authored by vkrause).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19465?vs=52948=53158

REVISION DETAIL
  https://phabricator.kde.org/D19465

AFFECTED FILES
  kcms/touchpad/cmake/modules/COPYING-CMAKE-SCRIPTS
  kcms/touchpad/cmake/modules/FindXCB.cmake
  kcms/touchpad/src/backends/x11.cmake

To: vkrause, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19463: Use FindGLIB2 from ECM

[Volker Krause]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:0b1559c47c3a: Use FindGLIB2 from ECM (authored by 
vkrause).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19463?vs=52944=53157

REVISION DETAIL
  https://phabricator.kde.org/D19463

AFFECTED FILES
  cmake/FindGLIB2.cmake

To: vkrause, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19518: Make Ctrl+A work regardless of focus and visualize active selection in search heading

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> DashboardRepresentation.qml:287
>  
> -PlasmaExtras.Heading {
> +TextEdit {
>  id: searchHeading

This change will change to `QtRendering` (which could be sensible on that large 
font size, though, but just so you're aware)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19518

To: hein, #plasma
Cc: broulik, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19502: Add a SearchField and PasswordField component

[Carl Schwan]

ognarb added inline comments.

INLINE COMMENTS

> broulik wrote in SearchField.qml:44
> I think this is fine but may need a translation domain 
> `i18nd("whatever_domain_kirigami_uses", "Search...")`

Are you sure? It would mean that Kirigami should then depends on ki18n. And 
them Kirigami wouldn't be a Tier 1 KDE framework anymore.

@mart should I move this in the example code or it is fine with a translation 
domain?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19502

To: ognarb, #kirigami, ngraham, mart
Cc: broulik, apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

Re: Plasma Sprint 2019 in València

[Noah Davis]

What is the address of the place we will meet?

On 3/4/19, Aleix Pol  wrote:
> Does that mean you can't on those days? How does this change the
> prospect sprint?
>
> Aleix
>
> On Mon, Mar 4, 2019 at 11:08 AM Marco Martin  wrote:
>>
>> On giovedì 28 febbraio 2019 08:47:18 CET Kai Uwe Broulik wrote:
>> > Hi,
>> >
>> > > Sounds like we have some critical mass, Alejandro tells me that
>> > > there's space so let's settle for the 23rd June week.
>> >
>> > Is Wednesday, 19 Arrival day and Sunday, 23 Departure day, or actual
>> > sprint days?
>>
>> oh, i tought that option was 23rd arrival :/
>>
>>
>> --
>> Marco Martin
>>
>>
>

D19309: Improve Unity Indicator

[Michail Vourlakos]

This revision was automatically updated to reflect the committed changes.
Closed by commit R878:cf0182e827c6: Improve Unity Indicator (authored by trmdi, 
committed by mvourlakos).

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19309?vs=52545=53143

REVISION DETAIL
  https://phabricator.kde.org/D19309

AFFECTED FILES
  liblatte2/qml/indicators/UnityIndicator.qml

To: trmdi, #latte_dock, mvourlakos
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19284: Close the window selected in the task group tooltip on middle click

[Michail Vourlakos]

mvourlakos added a comment.


  I can commit this for you, but I need an email address

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D19284

To: nickguletskii, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19419: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string to suit latest changes on the webpage

[Tagore Chandan Reddy]

tagorechandanreddy added a comment.


  This patch is meant to be a more complete solution to handle the random HTML 
changes on the webpage. Without this patch, the plugin fails on odd occasions 
as the webpage gets updated daily.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19419

To: tagorechandanreddy, ngraham, davidedmundson
Cc: plasma-devel, ngraham, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19392: shannon entropy to guess monochrome icon

[David Edmundson]

davidedmundson added a comment.


  
  
  > so, for gtk4/qt6, the base qiconengine included in qt should support 
whatever coloring is used, in which case i wouldn't need to do anything on my 
part.. tough that's for Qt6.
  
  It won't magically happen on it's own. 
  I've emailed the XDG mailing list.

INLINE COMMENTS

> desktopicon.cpp:322
>  case QVariant::Icon:
>  img = m_source.value().pixmap(size, iconMode(), 
> QIcon::On).toImage();
>  break;

DesktopIcon::setSource takes a QVariant.  The path with the colouring is only 
executed if this variant is a string.

If it's already an icon we go to here directly.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19392

To: mart, #kirigami
Cc: ngraham, GB_2, ndavis, #vdg, cfeck, davidedmundson, plasma-devel, domson, 
dkardarakos, apol, mart, hein

D19475: Only match service text strings once

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:68a2807654c6: Only match service text strings once 
(authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19475?vs=52984=53140

REVISION DETAIL
  https://phabricator.kde.org/D19475

AFFECTED FILES
  runners/services/servicerunner.cpp

To: davidedmundson, #plasma, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19423: Fix QLatin1String usage

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:b0e84dbe2cb6: Fix QLatin1String usage (authored by 
davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19423?vs=52834=53139

REVISION DETAIL
  https://phabricator.kde.org/D19423

AFFECTED FILES
  applets/kicker/plugin/systementry.cpp

To: davidedmundson, #plasma, apol
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19467: [colors-kcm] Fix blurry previews

[David Edmundson]

davidedmundson added a comment.


  @filipf  It's time for to learn the magic of gammaray !
  
  gammaray kcmshell5 colors
  
  and go to the quick scenes tabs. It might tell you something useful.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19467

To: filipf, broulik, #vdg, rooty, davidedmundson
Cc: ngraham, abetts, davidedmundson, rooty, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19467: [colors-kcm] Fix blurry previews

[Nathaniel Graham]

ngraham added a comment.


  Make its flickable have `pixelAligned: true`, maybe?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19467

To: filipf, broulik, #vdg, rooty, davidedmundson
Cc: ngraham, abetts, davidedmundson, rooty, plasma-devel, jraleigh, GB_2, 
ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, 
mart

D19467: [colors-kcm] Fix blurry previews

[Filip Fila]

filipf added a comment.


  Actually now that I take a closer look all of our previews are blurry. It's 
because there's text in the colors KCM that it becomes obvious.
  
  Compare the desktop theme KCM preview in its original state:
  F6656755: Screenshot_20190304_173527.png 

  
  And then with cell width set the same way as in this diff:
  F6656757: Screenshot_20190304_173348.png 

  
  Clearly this needs to be handled in the GridView files. So far I haven't been 
successfully in fixing it there so if anyone else has an idea let's fix it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19467

To: filipf, broulik, #vdg, rooty, davidedmundson
Cc: abetts, davidedmundson, rooty, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19518: Make Ctrl+A work regardless of focus and visualize active selection in search heading

[Eike Hein]

hein created this revision.
hein added a reviewer: Plasma.
Herald added a project: Plasma.
hein requested review of this revision.

REVISION SUMMARY
  BUG:405076

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19518

AFFECTED FILES
  applets/kicker/package/contents/ui/DashboardRepresentation.qml
  applets/kicker/plugin/dashboardwindow.cpp

To: hein, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19419: [KdePlasma-Addons/POTD/NOAA] Fixed RegEx string to suit latest changes on the webpage

[Nathaniel Graham]

ngraham added a comment.


  In D19419#424176 , 
@tagorechandanreddy wrote:
  
  > The HTML of the webpage is updated with random whitespace characters and 
newline characters.
  
  
  But does that make it actually not work at the moment?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D19419

To: tagorechandanreddy, ngraham, davidedmundson
Cc: plasma-devel, ngraham, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19467: [colors-kcm] Fix blurry previews

[David Edmundson]

davidedmundson added a comment.


  Why does this make a difference to things being blurry?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19467

To: filipf, broulik, #vdg, rooty, davidedmundson
Cc: abetts, davidedmundson, rooty, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19467: [colors-kcm] Fix blurry previews

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19467

To: filipf, broulik, #vdg, rooty, davidedmundson
Cc: abetts, davidedmundson, rooty, plasma-devel, jraleigh, GB_2, ragreen, 
Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19315: Use ActionTextField to implement the searchField in system settings

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D19315

To: ognarb, #plasma, ngraham
Cc: abetts, ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19478: [Login, Lock, and Logout Screen] Make the avatar background circle more subtle

[Andres Betts]

abetts added a comment.


  +1

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19478

To: filipf, ngraham, #vdg, #plasma, rooty
Cc: abetts, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, mart

D19214: [sddm-theme] Replace login button label with icon

[Andres Betts]

abetts added a comment.


  In D19214#424110 , @rooty wrote:
  
  > In D19214#424106 , @ngraham 
wrote:
  >
  > > Hmm, the Kirigami text field doesn't look like that in an app. Must be 
some weird SDDM environment thing?
  > >
  > > Either way, let's fix the height issue *somehow*. :)
  >
  >
  > It's sorta ugly but what's tripping me up is... why doesn't it get smaller 
if i set pointSize to 1 (and gets bigger if I set it to, say, 32)
  
  
  Would putting the > button "inside" the password field make it look better?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19214

To: rooty, #vdg, #plasma, ngraham, filipf
Cc: abetts, ngraham, filipf, plasma-devel, jraleigh, GB_2, ragreen, Pitel, 
ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D19259: [Task Manager] Fix sorting of tasks on last desktop in sort-by-desktop mode

[Eike Hein]

hein updated this revision to Diff 53131.
hein added a comment.


  Fix sorting and fallthrough for tasks on all desktops.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19259?vs=52695=53131

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19259

AFFECTED FILES
  libtaskmanager/tasksmodel.cpp

To: hein, #plasma, mart
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: New maintainers wanted: KDE Telepathy, KAccounts, Plasma Notifications and others

[Martin Klapetek]

On Mon, Mar 4, 2019 at 9:32 AM Alexander Akulich 
wrote:

> Hi Martin and everyone.
>
> I would like to take over the KDE Telepathy maintainership.
>
> I understand that Telepathy is a huge and complex project that needs a
> lot of manpower to actually come back, but there is no other project
> with the same goals and capabilities. For me, Telepathy is not the
> exact specification, but an idea of IM system with replaceable
> components that give you a freedom to combine whatever you want across
> operation systems, desktop environments, and programming languages
> with the best rate of shared code and system integration.
>
> I can spend two hours and write a long list of reasons why Telepathy
> is the right thing to do, but please let me spend this time on the
> development to prove my arguments by deed and not by words.
> On the other hand, I don't want to fail someone's expectations, so
> please continue to not expect much. :)
>
> I think that in the current era of proprietary IM services, such
> integrated and yet distributed solution has a chance to prove itself
> with open protocols such as Matrix, Telegram (MTProto), XMPP, Tox,
> Slack, IRC, SIP (reSIProcate), Gitter, Rocket.Chat, Signal, Discord
> and so on. For sure the list can meet the demands of some users.
>
> I have interest, ideas, experience, and prototypes. Now I have some
> time to start checking out features one by one. I'm already a
> maintainer of TelepathyQt (I released the last three versions), but
> the library and services mean nothing without a client. I have some
> pending reviews for 10 months [1] and if nobody reviews them then
> maybe it will be right to become a maintainer and start to land them.
>
> As a maintainer, I'll also take responsibility for bug fixing (as a
> start I committed three bug fixes at the last three days).
>
> P.S.: If you're going to support Matrix then please, please! develop a
> good library. I don't want to offend anyone, but QMatrixClient needs a
> lot of improvements and maybe you can help. With a good library (such
> as QXmpp) a Telepathy service implementation would consist of about 2k
> lines of code.
>
> [1] https://phabricator.kde.org/D12751


Yes please! You've already proven yourself throughout the years
with all your contributions, so you have my blessing :)

Thanks for stepping up!

Cheers
--
Martin Klapetek

D19510: [Logout screen] Fix label opacity failing

[Krešimir Čohar]

rooty added a comment.


  This is a neat workaround as discussed in D19479 


REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19510

To: filipf, #plasma, ngraham, rooty
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: New maintainers wanted: KDE Telepathy, KAccounts, Plasma Notifications and others

[Alexander Akulich]

Hi Martin and everyone.

I would like to take over the KDE Telepathy maintainership.

I understand that Telepathy is a huge and complex project that needs a
lot of manpower to actually come back, but there is no other project
with the same goals and capabilities. For me, Telepathy is not the
exact specification, but an idea of IM system with replaceable
components that give you a freedom to combine whatever you want across
operation systems, desktop environments, and programming languages
with the best rate of shared code and system integration.

I can spend two hours and write a long list of reasons why Telepathy
is the right thing to do, but please let me spend this time on the
development to prove my arguments by deed and not by words.
On the other hand, I don't want to fail someone's expectations, so
please continue to not expect much. :)

I think that in the current era of proprietary IM services, such
integrated and yet distributed solution has a chance to prove itself
with open protocols such as Matrix, Telegram (MTProto), XMPP, Tox,
Slack, IRC, SIP (reSIProcate), Gitter, Rocket.Chat, Signal, Discord
and so on. For sure the list can meet the demands of some users.

I have interest, ideas, experience, and prototypes. Now I have some
time to start checking out features one by one. I'm already a
maintainer of TelepathyQt (I released the last three versions), but
the library and services mean nothing without a client. I have some
pending reviews for 10 months [1] and if nobody reviews them then
maybe it will be right to become a maintainer and start to land them.

As a maintainer, I'll also take responsibility for bug fixing (as a
start I committed three bug fixes at the last three days).

P.S.: If you're going to support Matrix then please, please! develop a
good library. I don't want to offend anyone, but QMatrixClient needs a
lot of improvements and maybe you can help. With a good library (such
as QXmpp) a Telepathy service implementation would consist of about 2k
lines of code.

[1] https://phabricator.kde.org/D12751


On Sat, Jun 18, 2016 at 10:08 PM Martin Klapetek
 wrote:
>
> Hi,
>
> as I got a new job unrelated to KDE couple months ago, I'm finding myself 
> having less and less time and motivation to keep up with my maintainer's 
> duties. Therefore I think it's time to pass on some of the KDE things that 
> have my name in the "maintainer" field.
>
> First off, there's the whole notifications stack, which includes 
> KNotifications framework, the fdo notifications server and finally Plasma's 
> popup notifications. The whole stack is relatively simple and does not 
> require much attention, but it could use some forward pushing to not be stuck 
> in 2009 anymore.
>
> Staying in the Plasma land, I'd really like to hand the whole clock + 
> calendar stack to a dedicated maintainer. This is the bottom-right part of 
> the default Plasma panel - the clock applet, the calendar applet, the backend 
> for these applets, calendar events, proper timezones support and all the 
> pieces around. These things can get quite complex to grasp and improve, yet 
> are a crucial part of the desktop experience and deserve much more attention 
> than they get now.
>
> KAccounts, the system to set up your online accounts, could use some much 
> needed improvements and expansions as well as integrating with the new 
> Akonadi/Sink/Kube-thing. If the last part will not happen, and it certainly 
> doesn't look like it will, I'm afraid that KAccounts in Plasma would no 
> longer serve its purpose and would become a burden rather than a useful 
> system component.
>
> The last one and the biggest one - the 12 repos of KDE Telepathy. Now this 
> project is effectively dead. It hasn't seen any real development for more 
> than a year and basically is just on life support ever since the core team 
> had to leave the project because of job and life constraints. The other 
> factor is also the wide spread of mobile phones and mobile IM clients; 
> chatting on the desktop in not entirely modern interfaces with limited 
> protocol support is not as popular these days. But it would still be nice to 
> have someone at least oversee the couple of incoming patches every now and 
> then.
>
> I think that at least the first two stacks are totally vital for Plasma 
> desktop and really need some attention. If you'd like to put your name on any 
> of the things above, please let me know. I'll make sure to do a proper 
> hand-off with explaining everything :)
>
> Cheers
> --
> Martin Klapetek
> ___
> KDE-Telepathy mailing list
> kde-telepa...@kde.org
> https://mail.kde.org/mailman/listinfo/kde-telepathy

D19510: [Logout screen] Fix label opacity failing

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Due to Qt bug: https://bugreports.qt.io/browse/QTBUG-70138 (KDE bug:
  https://bugs.kde.org/show_bug.cgi?id=401644) we have label opacity utterly 
failing
  when the logout screen is superimposed over a bright background. Even though
  QtRendering is the inferior renderer, this patch uses it as a workaround for 
the
  aforemention bug since ugly (if it ever would be) text is better than 
(almost) no
  text.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19510

AFFECTED FILES
  lookandfeel/contents/components/ActionButton.qml
  lookandfeel/contents/logout/LogoutButton.qml

To: filipf
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Plasma Sprint 2019 in València

[Aleix Pol]

Does that mean you can't on those days? How does this change the
prospect sprint?

Aleix

On Mon, Mar 4, 2019 at 11:08 AM Marco Martin  wrote:
>
> On giovedì 28 febbraio 2019 08:47:18 CET Kai Uwe Broulik wrote:
> > Hi,
> >
> > > Sounds like we have some critical mass, Alejandro tells me that
> > > there's space so let's settle for the 23rd June week.
> >
> > Is Wednesday, 19 Arrival day and Sunday, 23 Departure day, or actual
> > sprint days?
>
> oh, i tought that option was 23rd arrival :/
>
>
> --
> Marco Martin
>
>

D19119: ApplicationPage: include the available version when selecting the source

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:f6ec0a29c42a: ApplicationPage: include the available 
version when selecting the source (authored by apol).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19119?vs=53094=53119

REVISION DETAIL
  https://phabricator.kde.org/D19119

AFFECTED FILES
  discover/qml/ApplicationPage.qml

To: apol, #discover_software_store, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19306: send a signal over dbus when the wrong password is provided

[Marco Martin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:63a541c4425f: send a signal over dbus when the wrong 
password is provided (authored by mart).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D19306?vs=52541=53118#toc

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19306?vs=52541=53118

REVISION DETAIL
  https://phabricator.kde.org/D19306

AFFECTED FILES
  kded/secretagent.cpp
  kded/secretagent.h
  kded/service.cpp
  kded/service.h
  libs/handler.cpp
  libs/handler.h
  mobile/wifi/package/contents/ui/NetworkListView.qml

To: mart, #plasma, jgrulich, bshah
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Upgrading Widgets from plasma-workspace

[Pavel]

Good day. Need your help.
 I am Upgrading Widgets from plasma-workspace and faced a number of 
problems.
 I will show the modernization goals using the example of the 
diskactivity widget, designed to visualize hard drive activity:


 1) At the moment when the widget is first loaded after installation, 
all the checkboxes are selected in the settings (checked = true).
  - It is necessary to make the widget display only real disk devices 
(not virtual, not loop or ram) by default.


 2) When the user tries to disable all checkboxes in the widget 
settings, this does not work. After the last checkbox is turned off, all 
checkboxes are turned on again (the default mode). I can’t disable all 
checkboxes at the same time.
  - I need to make sure that after disabling all settings the widget is 
empty.


  I decided to do this using the widget's initialization flag 
(widget_initialized). By default, widget_initialized = false.
When you first start the widget, when it has loaded all its settings, 
the value of the flag widget_initialized = true is set to 
Component.onCompleted.
And if the widget_initialized flag is set to true, then all subsequent 
changes are considered to be made by the user.
The widget_initialized flag allows to distinguish the first launch of 
the widget from the case when the user cleared all settings.


 Is there any other way to do this? Suppose using the API? Is there any 
specialized API that allows you to achieve a similar result? Preferably 
available from QML. Or maybe this API can be added somewhere?


 Thank you!


--
With best regards, Pavel Moseev

m...@basealt.ru
m...@altlinux.org

D19315: Use ActionTextField to implement the searchField in system settings

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:e80cbf128f77: Use ActionTextField to implement the 
searchField in system settings (authored by ognarb).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19315?vs=52553=53115

REVISION DETAIL
  https://phabricator.kde.org/D19315

AFFECTED FILES
  CMakeLists.txt
  sidebar/package/contents/ui/CategoriesPage.qml

To: ognarb, #plasma, ngraham
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Notes for 4/3/2019 monday meeting

[Marco Martin]

Eike:
* Not much from my end however
* I'd like a review for https://phabricator.kde.org/D19257, it's been sitting 
for 2-3 weeks
* I'm also finishing https://phabricator.kde.org/D19259 after the meeting, you 
could combine reviewing that in a few hours, too

Kai Uwe:
Work done:
- Found (well, fvogt did through openQA but I found what was going on :D) 
severe breakage in KArchive breaking icon loading other bits all over the 
place
-- Reverted for now until a proper solution is found
- IconItem blocks animation based on window visibility now, too
- File chooser portal confirms overwrite now
Work todo:
- Catching up with bugs and reports and reviews
- Some icon applet work
- Investigate what libjumplistaction needs to be able to do
-- Check all places the use jumplistactions and how they do it
--- e.g. C++-only QMenu, QVariantList with actions passed to QML which then 
builds the menu etc)
-- and then figure out a suitable API
- Fix currentIndex woes in Color KCM with filter proxy model ontop

David:
* Merged my Kwin XdgShell changes. No breakages \o/
* Cleaning up libkworskpace2 part 1 is on review. It's soo much tidier.
* Part 2 will kill the horrible kdisplaymanager and port SessionsModel to use 
it.
* I've also got a branch splitting autostart out of ksmserver.  Needs a tiny 
bit of tidying and one thing hooking up. Other than that, seems to work. 
*  Benchmarking seems to show it'll be worth it
* that's in a branch davidedmundson/ksession
* Made 2 Qt patches this week:
*  * putting icons on some remaining buttons in QButtonBox.
*  * A QApplication attribute to skip the session manager. Saves copying the 
weird 5 lines everywhere and will be faster too
* I'd like a review of the public headers in D19389 even if we don't review 
the actual code
 Diff 19389 "[WIP] Rewrite kworkspace logout, shutdown and suspend 
API" [Needs Review] https://phabricator.kde.org/D19389

GB_2
* I'd appreciate if someone could finally help here: https://
phabricator.kde.org/D17410
 Diff 17410 "Add alternatives button to applet configuration in panel edit 
mode" [Needs Review] https://phabricator.kde.org/D17410

Roman:
I mostly worked on other projects last week. There are some patches up since 
week before awaiting review: D18465 D19199 D19207 D19208 D19262. that's all. 
thanks.
 Diff 18465 "[platforms/wayland] Multi output support" [Needs Review] https://
phabricator.kde.org/D18465
 Diff 19199 "[platforms/fbdev] Port to AbstractOutput" [Needs Review] https://
phabricator.kde.org/D19199
 Diff 19207 "[platforms/x11/windowed] Port to AbstractOutput" [Needs Review] 
https://phabricator.kde.org/D19207
 Diff 19208 "[platforms/x11/standalone] Port to AbstractOutput" [Needs Review] 
https://phabricator.kde.org/D19208
 Diff 19262 "Delayed focus updates for Toplevels without surface" [Needs 
Review] https://phabricator.kde.org/D19262

Marco:
Kirigami:
* done the shannon entropy based detector for monochrome icons (relevant only 
for platforms without kiconloader such android and gnome in minimal dependency 
mode, but throws away heuristics in many other places making it simpler and 
slightly more reliable D19392 and i don't think there is any other way, at 
least for Qt5
* finished the giant pagerow c++ rewrite, landed
* fixed some issues in pages scrolling and flicking especially in mobile mode

Plasma-NetworkManager:
* a way for the QML mobile kcm to receive the message that the password is 
wrong, to bypass the qwidget dialog completely D19306

KWin:
* Please review D18818
 Diff 18818 "virtualkeyboard: resize the focused window to make room for the 
keyboard" [Needs Review] https://phabricator.kde.org/D18818

-- 
Marco Martin

D19389: [WIP] Rewrite kworkspace logout, shutdown and suspend API

[David Edmundson]

davidedmundson updated this revision to Diff 53111.
davidedmundson added a comment.


  add hybrid suspend

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19389?vs=52736=53111

REVISION DETAIL
  https://phabricator.kde.org/D19389

AFFECTED FILES
  libkworkspace/CMakeLists.txt
  libkworkspace/kworkspace.cpp
  libkworkspace/kworkspace_p.h
  libkworkspace/login1_manager_interface.cpp
  libkworkspace/loginddbustypes.h
  libkworkspace/org.freedesktop.ConsoleKit.Manager.xml
  libkworkspace/org.freedesktop.UPower.xml
  libkworkspace/org.freedesktop.login1.Manager.xml
  libkworkspace/org.freedesktop.login1.Seat.xml
  libkworkspace/org.freedesktop.login1.Session.xml
  libkworkspace/org.freedesktop.login1.User.xml
  libkworkspace/sessionmanagement.cpp
  libkworkspace/sessionmanagement.h
  libkworkspace/sessionmanagementbackend.cpp
  libkworkspace/sessionmanagementbackend.h
  libkworkspace/tests/CMakeLists.txt
  libkworkspace/tests/sessiontest.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D18438: [Task Manager] When closing apps, resize only when mouse is out.

[Eike Hein]

hein added a comment.


  Sorry for the late reply, too.
  
  The role is `WinIdList`.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arc_taskmanagerclose (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D18438

To: thsurrel, #plasma, #vdg, hein
Cc: hein, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19502: Add a SearchField and PasswordField component

[Carl Schwan]

ognarb updated this revision to Diff 53106.
ognarb marked 8 inline comments as done.
ognarb edited the summary of this revision.
ognarb added a comment.


  - Fix typos in doc
  - Remove edi-clear button in password field

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19502?vs=53093=53106

BRANCH
  dev

REVISION DETAIL
  https://phabricator.kde.org/D19502

AFFECTED FILES
  examples/simpleexamples/MultipleColumnsGallery.qml
  kirigami.qrc
  kirigami.qrc.in
  src/controls/ActionTextField.qml
  src/controls/PasswordField.qml
  src/controls/SearchField.qml
  src/kirigamiplugin.cpp
  src/qmldir

To: ognarb, #kirigami, ngraham, mart
Cc: broulik, apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein

Re: Plasma Sprint 2019 in València

[Marco Martin]

On giovedì 28 febbraio 2019 08:47:18 CET Kai Uwe Broulik wrote:
> Hi,
> 
> > Sounds like we have some critical mass, Alejandro tells me that
> > there's space so let's settle for the 23rd June week.
> 
> Is Wednesday, 19 Arrival day and Sunday, 23 Departure day, or actual
> sprint days?

oh, i tought that option was 23rd arrival :/


-- 
Marco Martin

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

[David Edmundson]

davidedmundson added a comment.


  > Could we use QtRendering to work around the issue until the patch lands?
  
  Go for it. Add a comment why we're doing it

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19434: Change entry of Endpoint UI

[Jan Grulich]

jgrulich added a comment.


  In D19434#423613 , @andersonbruce 
wrote:
  
  > In D19434#423458 , @jgrulich 
wrote:
  >
  > > Shouldn't we maybe use QSpinBox for the port? With the spinbox you can 
also set min and max values so you don't need to validate it.
  >
  >
  > My preference is to only use a spinbox for entries with less than 100 
possible values.  I believe that the up/down arrows give the impression that 
clicking on them is the "proper" method of selecting a value and while some 
people know that you can type in a value into a spinbox, I believe that there 
are others who do not and I really don't want users to be metaphorically 
cursing my name when they are trying to click their way up to a port number of 
say, 23517. Also, using a simple LineEdit with color coding for indicating an 
unacceptable input is consistent with the rest of the interface.
  
  
  In that case you can use https://doc.qt.io/qt-5/qlineedit.html#inputMask-prop 
to limit what users can type there. You can also assign validators to other 
lineedits so users will be able to type only correct values.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D19434

To: andersonbruce, jgrulich
Cc: ngraham, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19479: [Lock, Login, and Logout screen] Adjust visual feedback of action buttons

[Krešimir Čohar]

rooty added a comment.


  If I use PropertyAnimation instead of OpacityAnimator, the opacity problem 
seems to go away. Can anyone confirm?

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D19479

To: filipf, rooty, ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19500: [KDirModel] Fix job urls change signal connection

[Kai Uwe Broulik]

broulik added a comment.


  > Just out of curiosity, Did you notice the problem because something was 
missing in execution?
  
  I was toying around with the transfer jobs visible feature in `KDirModel` and 
got a warning when I enabled it. It isn't used by Dolphin anymore and not 
supported by Plasma, so I don't think it was that big of an issue.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19500

To: broulik, #frameworks, dfaure, jtamate
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19500: [KDirModel] Fix job urls change signal connection

[Jaime Torres Amate]

jtamate added a comment.


  +1. 
  Just out of curiosity, Did you notice the problem because something was 
missing in execution? Unfortunately, neither the compiler nor I didn't noticed 
it. :-(

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D19500

To: broulik, #frameworks, dfaure, jtamate
Cc: plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D19502: Add a SearchField and PasswordField component

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> PasswordField.qml:27
> + *
> + * Example usage for the search field component:
> + * @code

password field

> PasswordField.qml:33
> + * id: passwordField
> + * onAccepted: console.log("Password text is " + passwordField.text)
> + * }

Better not print a password in an example code :)

> PasswordField.qml:51
> +},
> +Kirigami.Action {
> +iconName: "edit-clear"

We don't use clear buttons on password fields

> SearchField.qml:44
> +
> +placeholderText: i18n("Search...")
> +focusSequence: "Ctrl+F"

I think this is fine but may need a translation domain 
`i18nd("whatever_domain_kirigami_uses", "Search...")`

> SearchField.qml:48
> +Kirigami.Action {
> +iconName: "edit-clear"
> +visible: root.text != ""

This doesn't mirror with right-to-left languages, run the app with `-reverse` 
argument to try

> SearchField.qml:49
> +iconName: "edit-clear"
> +visible: root.text != ""
> +onTriggered: {

Prefer connecting to `length > 0` if available, avoids a string conversion and 
passing around between C++ and JavaScript

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D19502

To: ognarb, #kirigami, ngraham, mart
Cc: broulik, apol, plasma-devel, domson, dkardarakos, davidedmundson, mart, hein