D21234: Use a more conventional sidebar header apparance in desktop view

This revision was automatically updated to reflect the committed changes. Closed by commit R134:75e24b05e768: Use a more conventional sidebar header apparance in desktop view (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D21234: Use a more conventional sidebar header apparance in desktop view

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. I think this is much better. I like the inclusion of a home button as well. REPOSITORY R134 Discover Software Store BRANCH more-conventional-sidebar-header-appearance REVISION DETAIL

D20972: [sidebar] Make search field not glued to the separator

abetts added a comment. +1 REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D20972 To: filipf, #vdg, ngraham, davidedmundson Cc: abetts, davidedmundson, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, sebas,

D21228: [Touchpad KCM] Load previous setting on reboot

romangg added inline comments. INLINE COMMENTS > libinputtouchpad.cpp:56 > +QStringLiteral("clickMethodClickfinger") > +}; > + In best case these should be in some way shared with libinputProperties array to minimize code duplication. But as long as these names are the same as in

D21228: [Touchpad KCM] Load previous setting on reboot

romangg added inline comments. INLINE COMMENTS > libinputtouchpad.cpp:216 > } > +KSharedConfigPtr configPtr = > KSharedConfig::openConfig(QStringLiteral("XlibinputConfigrc")); > +m_config = configPtr.data(); The name of the config file should be something similar to the other one

Re: Review Request: plasma-thunderbolt

El dimecres, 15 de maig de 2019, a les 15:27:07 CEST, Daniel Vrátil va escriure: > Hi all, > > plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt KCM > for Plasma. I initially submitted the code as a patch against plasma-desktop > [0], where it got reviewed, but it was

D20972: [sidebar] Make search field not glued to the separator

ngraham added a comment. In D20972#460812 , @filipf wrote: > While the proposed `Layout.rightMargin` is not an ideal solution, in these circumstances I think it's a legitimate way to compensate for the separator eating into the width.

D21234: Use a more conventional sidebar header apparance in desktop view

filipf added a comment. +1 from a visual POV In D21234#465818 , @ndavis wrote: > I noticed that there is a difference between the padding around the search bar in SySe and Discover. Do you know why this is? See:

D21234: Use a more conventional sidebar header apparance in desktop view

ngraham added a comment. In D21234#465818 , @ndavis wrote: > I noticed that there is a difference between the padding around the search bar in SySe and Discover. Do you know why this is? Fixed in Discover. Any remaining divergence is now

D21234: Use a more conventional sidebar header apparance in desktop view

ngraham updated this revision to Diff 58150. ngraham added a comment. Fix margins REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21234?vs=58143=58150 BRANCH more-conventional-sidebar-header-appearance REVISION DETAIL

D21234: Use a more conventional sidebar header apparance in desktop view

ndavis added a comment. I noticed that there is a difference between the padding around the search bar in SySe and Discover. Do you know why this is? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D21234 To: ngraham, #vdg, #discover_software_store,

D21228: [Touchpad KCM] Load previous setting on reboot

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > libinputtouchpad.cpp:217 > +KSharedConfigPtr configPtr = > KSharedConfig::openConfig(QStringLiteral("XlibinputConfigrc")); > +

D21234: Use a more conventional sidebar header apparance in desktop view

ngraham created this revision. ngraham added reviewers: VDG, Discover Software Store. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Discover uses the `Kirigami.GlobalDrawer` for its navigation sidebar. This

D21228: [Touchpad KCM] Load previous setting on reboot

nicolasfella added inline comments. INLINE COMMENTS > libinputtouchpad.cpp:415 > + > +if (replyValue!=savedValue) { > +replyValue = savedValue; Coding style: Space around != REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21228 To: atulbi, ngraham,

Re: Review Request: plasma-thunderbolt

In data mercoledì 15 maggio 2019 15:27:07 CEST, Daniel Vrátil ha scritto: > Thus I'd kindly ask you to take one more look at the codebase [1] and let me > know if there are any more issues to fix, or if we can proceed to include > this in the next Plasma release. The repository at this point is

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

fvogt added a comment. In D20186#465586 , @ngraham wrote: > Also keep in mind that it's possible to have global config files in `/etc/X11/xorg.conf.d/` I have one such file there myself that I made to work around the lack of this feature being

D19745: Fix system tray UI/UX & refactor

ratijastk added a comment. Double checked on my system. Nothing bad happened so far. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19745 To: ratijastk, #vdg, #plasma, broulik, mart, hein Cc: davidre, davidedmundson, ngraham, ndavis, anthonyfieroni,

D21229: Use view background color for sidebar to match other sidebars

ngraham added a comment. :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D21229 To: ngraham, #vdg, #discover_software_store, apol Cc: filipf, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg,

D21075: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R858:6d0289d7b284: [QQC2 Slider Style] Fix wrong handle positioning when initial value is 1 (authored by filipf).

D21027: [Notes] Fix icons being almost invisible with light backgrounds

filipf added a comment. In D21027#464443 , @broulik wrote: > > I tried to set icon.width and icon.height but it doesn't do anything. > > In desktop style that should work since D20418 Tried it in

D21229: Use view background color for sidebar to match other sidebars

filipf added a comment. You were too quick for me but just wanted to say: nice! I also saw that we needed to fix the color errors in the System Settings sidebar and you solved that as well :) REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D21229

D21229: Use view background color for sidebar to match other sidebars

This revision was automatically updated to reflect the committed changes. Closed by commit R134:1658a360040c: Use view background color for sidebar to match other sidebars (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D21229: Use view background color for sidebar to match other sidebars

ngraham updated this revision to Diff 58135. ngraham added a comment. Only for desktop view REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21229?vs=58134=58135 BRANCH view-bg-color-for-sidebars (branched from master) REVISION DETAIL

D21229: Use view background color for sidebar to match other sidebars

mart added a comment. +1 REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D21229 To: ngraham, #vdg, #discover_software_store, apol Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas,

D21226: search for a default wallpaper in lookandfeel

mart added a comment. In D21226#465681 , @kossebau wrote: > Has this been considered already? Only noticed recently, but did not want to create a new theme work can for me :) That's what the code in that function i left untouched does

D21229: Use view background color for sidebar to match other sidebars

ngraham created this revision. ngraham added reviewers: VDG, Discover Software Store, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Generally, left sidebars in Kirigami-style apps (e.g. System Settings)

D21097: Handle apps which set the desktopFileName property with filename suffix

This revision was automatically updated to reflect the committed changes. Closed by commit R135:0e50f23c4c43: Handle apps which set the desktopFileName property with filename suffix (authored by kossebau). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

D21226: search for a default wallpaper in lookandfeel

kossebau added a comment. BTW, there is also still code in place to support Plasma Themes defining a default wallpaper (or even deploy some more). Though the default & the further are not listed in the Image wallpaper config, also is the config not offering any hint about the default or to

D21228: [Touchpad KCM] Load previous setting on reboot

atulbi created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. atulbi requested review of this revision. REVISION SUMMARY Earlier Previous setting were not loaded on reboot instead default settings were loaded. So, added config file for saving the

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. In D20186#465586 , @ngraham wrote: > Also keep in mind that it's possible to have global config files in `/etc/X11/xorg.conf.d/` I have one such file there myself that I made to work around the lack of this feature being

D21226: search for a default wallpaper in lookandfeel

mart updated this revision to Diff 58130. mart added a comment. - use proper path of the package REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21226?vs=58127=58130 BRANCH mart/wallpaperFromLnf REVISION DETAIL

D14147: Port from GConf to GSettings

nicolasfella closed this revision. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D14147 To: nicolasfella, drosca, davidedmundson Cc: fvogt, kossebau, ngraham, pino, lbeltrame, evpokp, rikmills, broulik, asturmlechner, plasma-devel, jraleigh, GB_2,

D21226: search for a default wallpaper in lookandfeel

mart added a comment. In D21226#465633 , @davidedmundson wrote: > Didn't we move contents/layout.js to be part of the lookandfeel and that was the previous way to set a default wallpaper? layout.js is mostly to create a whole layout

D21225: set the wallpaper when applying look and feel

mart updated this revision to Diff 58128. mart added a comment. - add property for applyWallpaper REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21225?vs=58126=58128 BRANCH mart/wallpaperLoolAndFeel REVISION DETAIL

D21226: search for a default wallpaper in lookandfeel

davidedmundson added a comment. Didn't we move contents/layout.js to be part of the lookandfeel and that was the previous way to set a default wallpaper? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D21226 To: mart, #plasma Cc: davidedmundson,

D21226: search for a default wallpaper in lookandfeel

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY now look and feel packages can specify a default image wallpaper. when a new containment is created at

D21225: set the wallpaper when applying look and feel

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY A LNF package can optionally define a wallpaper which can be either a wallpaper package name or a file

Re: Review Request: plasma-thunderbolt

Am Mittwoch, 15. Mai 2019, 15:27:07 CEST schrieb Daniel Vrátil: > Thus I'd kindly ask you to take one more look at the codebase [1] and let me > know if there are any more issues to fix, or if we can proceed to include > this in the next Plasma release. Pushed some small fixes to toplevel

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 199 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/199/ Project: kf5-qt5 SUSEQt5.12 Date of build: Thu, 09 May 2019 09:59:33 + Build duration: 5 min 34 sec and counting JUnit Tests Name: (root)

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 205 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/205/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 15 May 2019 00:01:18 + Build duration: 5 min 50 sec and counting JUnit Tests Name: (root)

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 146 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/146/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 10 May 2019 20:45:32 + Build duration: 57 min and counting JUnit Tests Name: (root) Failed: 0

Review Request: plasma-thunderbolt

Hi all, plasma-thunderbolt is a new repo containing, you guessed it, Thunderbolt KCM for Plasma. I initially submitted the code as a patch against plasma-desktop [0], where it got reviewed, but it was ultimately decided to better put it into a separate repository, since it's not just a KCM but

D21221: [Notes] Port to QQC2 and use GridView KCM components for the color chooser

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > davidedmundson wrote in configAppearance.qml:79 > this looks like it's a bad merge Fixed in 61ab2de7bf19a496e11085245b2fa65a48bd6408

D19745: Fix system tray UI/UX & refactor

ratijastk updated this revision to Diff 58123. ratijastk added a comment. Rebase on most recent master REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19745?vs=53851=58123 BRANCH fix-system-tray REVISION DETAIL

D21221: [Notes] Port to QQC2 and use GridView KCM components for the color chooser

davidedmundson added inline comments. INLINE COMMENTS > configAppearance.qml:79 > +color: { > +if (modelData == "black" || modelData == > "translucent-light") { > +return "#dfdfdf" this looks like it's a bad merge REPOSITORY R114

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

ngraham added a comment. Also keep in mind that it's possible to have global config files in `/etc/X11/xorg.conf.d/` I have one such file there myself that I made to work around the lack of this feature being implemented yet: $ cat /etc/X11/xorg.conf.d/99-libinput.conf Section

D21221: [Notes] Port to QQC2 and use GridView KCM components for the color chooser

This revision was automatically updated to reflect the committed changes. Closed by commit R114:4f163efbc4c4: [Notes] Port to QQC2 and use GridView KCM components for the color chooser (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D21221: [Notes] Port to QQC2 and use GridView KCM components for the color chooser

ngraham updated this revision to Diff 58121. ngraham added a comment. Bring back old text switch method (it was less buggy) REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21221?vs=58113=58121 BRANCH modernize-notes-settings-window (branched from

D21221: [Notes] Port to QQC2 and use GridView KCM components for the color chooser

mart accepted this revision. mart added a comment. I'm not 100% sure about using kcm components outside actual kcms, but i guess to fix that properly it would need those components in a more abstract manner somewhere else like in kirigami and then the kcm import only specializing it. So

D19745: Fix system tray UI/UX & refactor

ratijastk added a comment. ~~Even with extra-cmake-modules 5.58, kcoreaddons needs to be updated as well... work in progress... please, be patient: i have autism^W slow hardware.~~ 5.58.0 releases just rolled out, upgrading... REPOSITORY R120 Plasma Workspace REVISION DETAIL

D19745: Fix system tray UI/UX & refactor

davidre added a comment. In D19745#465569 , @ratijastk wrote: > So, I've merged done git rebase on master — just one conflicting line, rewritten after me in a better way. But now I have no way to test it, because CMake Error `Could not find a

D19745: Fix system tray UI/UX & refactor

ratijastk added inline comments. INLINE COMMENTS > davidedmundson wrote in main.qml:66 > Not really. > Using objectNames is a bit of an anti pattern, especially when QML has so the > built-in component scope hierachy. > > We use it in the system tray already, and it's arguably no worse than

D19745: Fix system tray UI/UX & refactor

ratijastk added a comment. So, I've merged done git rebase on master — just one conflicting line, rewritten after me in a better way. But now I have no way to test it, because CMake Error `Could not find a configuration file for package "ECM" that is compatible with requested version

D19745: Fix system tray UI/UX & refactor

anthonyfieroni added inline comments. INLINE COMMENTS > davidedmundson wrote in PlasmoidItem.qml:45 > Huh? how did this work before? Applets do it by itself, when it not do, it does not work like Weather Widget embed in systray. REPOSITORY R120 Plasma Workspace REVISION DETAIL

D19745: Fix system tray UI/UX & refactor

davidedmundson added a comment. I love use of layouts for everything, so in general ++ INLINE COMMENTS > CompactApplet.qml:34 > subText: plasmoid.toolTipSubText > -location: if (plasmoid.parent && plasmoid.parent.parent.objectName === > "hiddenTasksColumn" && plasmoid.location !==

D21220: [Touchpad KCM] Fix libinput-less build and warnings

zzag added inline comments. INLINE COMMENTS > libinputcommon.h:28 > template > -T valueLoaderPart(QVariant const ) { Q_UNUSED(reply); return T(); } > +inline T valueLoaderPart(QVariant const ) { Q_UNUSED(reply); return > T(); } > Just a note for the future: you don't have to define this

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

atulbi added a comment. > In D20186#465395 , @romangg wrote: > >> I found a grave issue now when testing though: Saved values are not restored on Reboot. Are they saved at all to a config file? >> >> EDIT: No, they are not. In X11 + evdev

D20186: [libinput-touchpad-kcm] Use wayland specific touchpad KCM UI when libinput is used on X11

romangg added a comment. In D20186#465502 , @atulbi wrote: > In D20186#465361 , @ngraham wrote: > > > @atulbi This has caused a failure in the CI: > > [...] > > > > Looks like we need to make