astippich added a comment.
+1, also fixes the warnings in Elisa
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
REVISION DETAIL
https://phabricator.kde.org/D21514
To: dfaure, mart, apol, broulik
Cc: astippich, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen,
Pitel,
zzag added a comment.
> Update protocol xml to wayland-protocols master
OT: there's a package called wayland-protocols. We could use it in order to
avoid copying protocol specs.
name=FindWaylandProtocols.cmake
#.rst:
# FindWaylandProtocols
# ---
#
# Try to
meven accepted this revision.
meven added a comment.
Except that I couldn't test it, the code looks in great shape to me.
REPOSITORY
R122 Powerdevil
BRANCH
arcpatch-D16425_1
REVISION DETAIL
https://phabricator.kde.org/D16425
To: avaldes, broulik, ngraham, meven
Cc: ericadams,
davidre updated this revision to Diff 60826.
davidre added a comment.
- add my copyright
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22121?vs=60825=60826
BRANCH
slideshow (branched from master)
REVISION DETAIL
davidre updated this revision to Diff 60825.
davidre marked 4 inline comments as done.
davidre added a comment.
- String changes and remove debug statement
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22121?vs=60823=60825
BRANCH
slideshow
This revision was automatically updated to reflect the committed changes.
Closed by commit R858:721c348d1a1e: Show shortcut in menu item when specified
(authored by astippich).
REPOSITORY
R858 Qt Quick Controls 2: Desktop Style
CHANGES SINCE LAST UPDATE
davidre updated this revision to Diff 60823.
davidre added a comment.
Sort only if a sortmode has been specified
Otherwise it could have been initialized to an invalid value which caused us
to
reach Q_UNREACHABLE and crash.
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE