davidre added inline comments.
INLINE COMMENTS
> image.cpp:600
> +m_slideshowModel->addBackground(path);
> +m_currentSlide = m_slideFilterModel->indexOf(path) - 1;
> nextSlide();
Currently the slideshow would restart. I guess we could check here if the index
is -1. Or
bruns added a comment.
After having looked into the callchain again, I am not sure what the best
action here is:
The old code did a DBus call of org.freedesktop.PowerManagement.Inhibit,
which is implemented by powerdevil. Powerdevil only "schedules" the inhibition,
but delays it for 5
apol added a comment.
Solid::InhibitionJob isn't installed by default, is it?
Is the plan to make it the public API now?
Not disagreeing with the change, just would need changes in Solid first.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D22296
bruns created this revision.
bruns added reviewers: Plasma, broulik, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bruns requested review of this revision.
REVISION SUMMARY
As KDELibs4Support pulled in a number of Frameworks, we have to
explicitly
This revision was automatically updated to reflect the committed changes.
Closed by commit R135:d2a1d1ca9e9e: [KDEPlatformSystemTrayIcon] Set
KStatusNotifierItem to Active (authored by cfeck).
REPOSITORY
R135 Integration for Qt applications in Plasma
CHANGES SINCE LAST UPDATE
This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b414ac1c7a09: [Lock screen] Follow KDE title
subtitle style (authored by filipf).
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D22231?vs=61060=61245
