KDE CI: Plasma » plasma-thunderbolt » stable-kf5-qt5 FreeBSDQt5.13 - Build # 1 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-thunderbolt/job/stable-kf5-qt5%20FreeBSDQt5.13/1/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Sun, 07 Jul 2019 15:38:02 + Build duration: 10 hr and counting CONSOLE OUTPUT

D22316: Avoid garbling the sound if the volume slider is moved fast

kezik added a comment. I don't know why it is not showing the context of the patch 路‍♂️ I selected the plasma-pa project REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D22316 To: kezik, #vdg Cc: plasma-devel, kezik, LeGast00n, jraleigh,

D22316: Avoid garbling the sound if the volume slider is moved fast

kezik created this revision. kezik added a reviewer: VDG. kezik added a project: Plasma. Herald added a subscriber: plasma-devel. kezik requested review of this revision. REVISION SUMMARY I think that the audio should not be garbled if you move fast the audio slider (it distorts because it

D19745: Fix system tray UI/UX & refactor

ngraham added a comment. @ratijastk please feel free to submit another patch that does the same thing, but addresses @broulik's concerns. Thanks! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19745 To: ratijastk, #vdg, #plasma, broulik, mart, hein,

D22312: [DeviceNotifications] Keep last message for each device

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bf811e448c76: [DeviceNotifications] Keep last message for each device (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D19745: Fix system tray UI/UX & refactor

broulik added a comment. Fyi I reverted this change now https://cgit.kde.org/plasma-workspace.git/commit/?id=2594eb1b33b56ec7e0e8eb6c37acb1c7f2a5a1ff REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D19745 To: ratijastk, #vdg, #plasma, broulik, mart, hein,

D22306: Do not skip code launching application in application dashboard

ngraham added a reviewer: Plasma. ngraham accepted this revision. ngraham added a subscriber: hein. ngraham added a comment. This revision is now accepted and ready to land. I tested this with both mouse and touch. Though I could not reproduce the original issue, this patch does not introduce

D22312: [DeviceNotifications] Keep last message for each device

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. I just noticed this a few days ago and it was annoying me. I tested with three flash drives and an external hard drive. Three correctly removed the notice after the disk was actually

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

msdobrescu added a comment. Is it more efficient from the performance point of view to have a QSortFilterProxyModel class per sorting method? I have a 6000 images case, would that be consuming compared to setting the sort class once according to the sorting method? REPOSITORY R120 Plasma

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

msdobrescu added a comment. In D22256#491942 , @davidedmundson wrote: > The fundamental problem with this approach is you only sort through the dirs correctly, but not the total across multiple paths. > > i.e > If I have two paths dirA

D22256: [Image Wallpaper Slideshow] Allow setting of different sorting orders POC

davidedmundson added a comment. The fundamental problem with this approach is you only sort through the dirs correctly, but not the total across multiple paths. i.e If I have two paths dirA and dirB and want things sorted by date this patch will have all the images in dirA sorted by

D22312: [DeviceNotifications] Keep last message for each device

bruns created this revision. bruns added reviewers: Plasma, broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bruns requested review of this revision. REVISION SUMMARY Ejecting e.g. a USB stick removes it from the bus (bus power is removed), but the

D22302: fix kstart5 crash on wayland

ngraham added a comment. No worries! When landing a patch that was originally branched from master onto a different branch, I find that the following works well for me: https://community.kde.org/Infrastructure/Phabricator#Landing_on_the_.22Stable_branch.22 REPOSITORY R126 KDE CLI

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

msdobrescu added a comment. IMHO, for lines like these, 'm_currentSlide = m_slideFilterModel->indexOf(path) - 1;', checks must be added because it is transparent to the QML code and let room for failure. Besides that, did you know that if there are no wallpapers, could be added one or

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidre added a comment. In D22121#491833 , @davidedmundson wrote: > Nate's crash is due to data not code. > > for (int i = 0; i < m_packages.size(); i++) { > QString package = m_packages[i].path(); > if

D22302: fix kstart5 crash on wayland

aacid added a comment. In D22302#491786 , @ngraham wrote: > Oh, this was already landed, but Phab didn't notice because its commit message was altered to no longer include the `Differential Revision: https://phabricator.kde.org/D22302` text.

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

msdobrescu added a comment. Indeed, at should crash, but when is that string empty? I can't crash mine, although inherits the same code. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22121 To: davidre, #plasma, davidedmundson Cc: davidedmundson,

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. Nate's crash is due to data not code. for (int i = 0; i < m_packages.size(); i++) { QString package = m_packages[i].path(); if

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

msdobrescu added a comment. Ha Ha Ha! I know! I have asked you about, remember? Sometimes the actual build goes bananas and needs a reset. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22121 To: davidre, #plasma Cc: davidedmundson, msdobrescu, ngraham,

D22306: Do not skip code launching application in application dashboard

luc4 created this revision. luc4 added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. luc4 requested review of this revision. REVISION SUMMARY Since Plasma 5.16, clicks over the icons are frequently ignored. See

D22302: fix kstart5 crash on wayland

garrison added a comment. anyway I confirm email address is correct - and will use git next time REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22302 To: garrison, davidedmundson Cc: aacid, ngraham, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,

D22302: fix kstart5 crash on wayland

ngraham closed this revision. ngraham added a subscriber: aacid. ngraham added a comment. Oh, this was already landed, but Phab didn't notice because its commit message was altered to no longer include the `Differential Revision: https://phabricator.kde.org/D22302` text. Closing manually.

D22302: fix kstart5 crash on wayland

ngraham added a comment. @garrison, can you provide your email address so we can land this patch with correct authorship information? Thanks! REPOSITORY R126 KDE CLI Utilities REVISION DETAIL https://phabricator.kde.org/D22302 To: garrison, davidedmundson Cc: ngraham, plasma-devel,

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

ngraham added a comment. In D22121#491723 , @msdobrescu wrote: > In D22121#491369 , @ngraham wrote: > > > Huh, in a VM everything works for me too. I wonder if there's some subtle issue with the

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

msdobrescu added a comment. In D22121#491369 , @ngraham wrote: > Huh, in a VM everything works for me too. I wonder if there's some subtle issue with the fact that I'm running a custom-compiled Plasma at a different path on bare metal.

D22302: fix kstart5 crash on wayland

garrison created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. garrison requested review of this revision. REVISION SUMMARY Make kstart query NETRootInfo only if it is running o QX11Info::isPlatformX11 following porting guidelines. Verified by