D22344: Expose some more settings in an Advanced dialog

jgrulich added a comment. Don't you miss loading/saving of those properties in loadConfig() and setting() methods? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D22344 To: apol, #plasma, jgrulich Cc: broulik, ngraham, plasma-devel,

D22363: Remove cursor theme option

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Continuation of D22191 and is built on top of it. Instead of having a niche option for a cursor

D22191: Implement syncing of theme preferences between SDDM and Plasma

filipf updated this revision to Diff 61480. filipf added a comment. . REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22191?vs=61479=61480 BRANCH sddm-theme-syncing (branched from master) REVISION DETAIL

D22191: Implement syncing of theme preferences between SDDM and Plasma

filipf updated this revision to Diff 61479. filipf added a comment. better solution for fontconfig copy operations check REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22191?vs=61411=61479 BRANCH sddm-theme-syncing (branched from

D22296: [ksmserver] Remove obsolete KDELibs4Support dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7fa46fa74987: [ksmserver] Remove obsolete KDELibs4Support dependency (authored by bruns). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22296: [ksmserver] Remove obsolete KDELibs4Support dependency

bruns updated this revision to Diff 61475. bruns marked an inline comment as done. bruns retitled this revision from "Port KSMServer to Solid::Power, drop KDELibs4Support requirement" to "[ksmserver] Remove obsolete KDELibs4Support dependency". bruns edited the summary of this revision. bruns

D22344: Expose some more settings in an Advanced dialog

apol updated this revision to Diff 61474. apol added a comment. Addressed comments REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22344?vs=61426=61474 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22344 AFFECTED

D22344: Expose some more settings in an Advanced dialog

apol marked 4 inline comments as done. apol added inline comments. INLINE COMMENTS > broulik wrote in ipv4widget.cpp:455 > Doesn't seem to work? Or did you disable the dimming effect or is that a > quirk in conjunction with `QQuickWidget` in systemsettings? Worked for me, I've seen issues with

D21995: Split ksmserver into a small application that handles startup and ksmserver

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. Let's do this! REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D21995 To: davidedmundson, #plasma, apol Cc: apol, bshah, plasma-devel,

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

ndavis created this revision. ndavis added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ndavis requested review of this revision. REVISION SUMMARY This reverts the following commits: fff556af1939d17453540f4388b27650359258dd

D18245: Create QApplication in a scope to work around possible deadlock

croick abandoned this revision. croick added a comment. I can no longer reproduce the deadlock, so I'll abandon this. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18245 To: croick, sitter, #kdevelop Cc: dfaure, thiago, ossi, plasma-devel, LeGast00n, jraleigh,

D18890: Add button to reset index database and repair Baloo crashing

ngraham added a comment. I'd like to revisit this. Can we get back to it and fix the outstanding issues? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18890 To: guoyunhe, #plasma, #baloo Cc: mart, davidedmundson, bruns, ngraham, plasma-devel, LeGast00n,

D11234: [DrKonqi] Show debug button when KDevelop session is running

croick added a comment. Thanks for your review. It was the last in a series of patches and I'll try to advertise the whole "Debug your KDE application with KDevelop"-feature somewhere. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D11234 To: croick,

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 58 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/58/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 09 Jul 2019 20:40:24 + Build duration: 1 min 38 sec and counting CONSOLE OUTPUT

D11234: [DrKonqi] Show debug button when KDevelop session is running

This revision was automatically updated to reflect the committed changes. Closed by commit R871:95b6b8b613c2: Show debug button when KDevelop session is running (authored by croick). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D11234?vs=61377=61456

D22344: Expose some more settings in an Advanced dialog

broulik added inline comments. INLINE COMMENTS > ipv4widget.cpp:424 > +{ > +QPointer dlg = new QDialog(this); > + What's that `QPointer` for? You might want to `dlg->setAttribute(Qt::WA_DeleteOnClose);` > ipv4widget.cpp:427 > +auto layout = new QFormLayout(dlg); > +

D20867: Add Property to disable drawing of menu arrow indicators

ngraham added a comment. Sorry for the delayed response! Let me block out some time to give it a whirl. I am left wondering if there's any simpler way we can do it though. KWidgetsAddons, Breeze, and Dolphin each have different release cycles, so making sure everything gets in at the right

D22344: Expose some more settings in an Advanced dialog

ngraham added inline comments. INLINE COMMENTS > ipv4widget.cpp:431 > +sendHostname->setChecked(m_tmpIpv4Setting.dhcpSendHostname()); > +layout->addRow(i18n("Send Hostname"), sendHostname); > + Add a colon and don't use Title Case: "Send hostname:" > ipv4widget.cpp:435 > +

Plasma 5.16.3

Plasma 5.16.3 is now released https://www.kde.org/announcements/plasma-5.16.3.php

D22344: Expose some more settings in an Advanced dialog

apol added a comment. F6997365: Screenshot_20190709_183955.png REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D22344 To: apol, #plasma, jgrulich Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas,

D22344: Expose some more settings in an Advanced dialog

apol created this revision. apol added reviewers: Plasma, jgrulich. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added 1 blocking reviewer(s): jgrulich. apol requested review of this revision. REVISION SUMMARY Was requested by some users who needed these

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 28 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/28/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 09 Jul 2019 15:01:42 + Build duration: 4 min 40 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 2 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/2/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 09 Jul 2019 14:50:52 + Build duration: 4 min 36 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 28 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/28/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 09 Jul 2019 14:50:53 + Build duration: 53 sec and counting CONSOLE OUTPUT

D22191: Implement syncing of theme preferences between SDDM and Plasma

filipf updated this revision to Diff 61411. filipf added a comment. - Merge branch 'master' into sddm-theme-syncing REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22191?vs=61109=61411 BRANCH sddm-theme-syncing (branched from

D22341: [mobile/wifi] Port to SimpleKCM

mart accepted this revision. mart added a comment. LGTM, still needs approval by Jan REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D22341 To: nicolasfella, #plasma, mart, jgrulich Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,

D22341: [mobile/wifi] Port to SimpleKCM

nicolasfella created this revision. nicolasfella added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. Herald added a reviewer: jgrulich. nicolasfella requested review of this revision. REVISION SUMMARY The plasma-settings app assumes all KCMs

D22191: Implement syncing of theme preferences between SDDM and Plasma

davidedmundson added inline comments. INLINE COMMENTS > sddmauthhelper.cpp:93 > +// copy kdeglobals (color scheme) > +if (!args[QStringLiteral("kdeglobals")].isNull()) { > +QDir kdeglobalsSource(args[QStringLiteral("kdeglobals")].toString()); what would happen if: - there is no

D22333: Move Solid::Device::listFromQuery calls to a separate thread

apol updated this revision to Diff 61407. apol added a comment. Don't move Solid::Device instances between threads REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22333?vs=61379=61407 BRANCH master REVISION DETAIL

D22122: use pwquality_strerror to get error strings

sitter added a comment. In D22122#487601 , @davidedmundson wrote: > Concept makes sense. > +1 > > @ltoscano can you confirm you're ok from an i18n side. ping @ltoscano REPOSITORY R128 User Manager REVISION DETAIL

D22322: Store crash report automatically if shutting down

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. some style annoyances. fix it then ship it  INLINE COMMENTS > drkonqi.cpp:254 > + > +QObject::connect(btGenerator, ::done, > ); > +QObject::connect(btGenerator, ::someError, >

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 57 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/57/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 09 Jul 2019 10:05:40 + Build duration: 9 min 51 sec and counting CONSOLE OUTPUT

D11234: [DrKonqi] Show debug button when KDevelop session is running

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Heh. Fair enough, I too ran down the wrong rabbit hole with the size issue until I noticed the policy was wrong. Diff looks good now. Works very well too.  REPOSITORY R871 DrKonqi

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.11 - Build # 16 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.11/16/ Project: stable-kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 09 Jul 2019 10:05:40 + Build duration: 12 sec and counting CONSOLE OUTPUT

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

msdobrescu added a comment. Could it be some threading issue? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22121 To: davidre, #plasma, davidedmundson Cc: davidedmundson, msdobrescu, ngraham, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,

D22121: [Image Wallpaper Slideshow] Allow setting of different sorting orders

davidre added a comment. So I'm crashing when I hit apply and then ok because `addURL` is called from qml with an empty string and I don't understand why. In main.qml I have onConfiguredImageChanged: { if (modelImage != configuredImage) { console.log("configured

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 56 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/56/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 09 Jul 2019 09:13:19 + Build duration: 1 min 45 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.11 - Build # 55 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.11/55/ Project: kf5-qt5 WindowsMSVCQt5.11 Date of build: Tue, 09 Jul 2019 06:52:59 + Build duration: 1 min 34 sec and counting CONSOLE OUTPUT