D22832: Fix build with pango 1.44

arojas added a comment. In D22832#504428 , @sitter wrote: > Shouldn't this somehow be handled via pkg-config? IIRC .pc files can indicate dependencies, so I would assume one could get the requirements somehow and resolve those using generic

D22539: Fix broken guard that prevents styling sliders with negative values

This revision was automatically updated to reflect the committed changes. Closed by commit R858:ef066d9d28ac: Fix broken guard that prevents styling sliders with negative values (authored by davidedmundson). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D22843: [libcolorcorrect] Port old style connects

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7aef897a3a6c: [libcolorcorrect] Port old style connects (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22843?vs=62818=62828

D22842: [shell/panelshadows] Port away from old style connect

This revision was automatically updated to reflect the committed changes. Closed by commit R120:214077668667: [shell/panelshadows] Port away from old style connect (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22847: [runners/kill] Port old style connects

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D22845: [GTK3] Convert all colors to use GTK color definitions

cblack updated this revision to Diff 62825. cblack added a comment. Good job at picking up that change, arc. See previous change. REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22845?vs=62824=62825 BRANCH colordefs (branched from master) REVISION

D22845: [GTK3] Convert all colors to use GTK color definitions

cblack updated this revision to Diff 62824. cblack added a comment. Forgot about changing the build_theme.sh to export to my home directory under the name Breeze-Dev, reversed that REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22845?vs=62822=62824

D22846: Port KeyboardLayout component to use generated DBus interface

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY QDBusInterface is useful for runtime introspection but little else. As

D22845: [GTK3] Convert all colors to use GTK color definitions

cblack created this revision. cblack added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY All of the colors pulled from a colorscheme in Breeze GTK now use GTK's color definitons,

D22841: [dataengines/hotplug] Port code to new connect syntax

This revision was automatically updated to reflect the committed changes. Closed by commit R120:20c353d4f4ee: [dataengines/hotplug] Port code to new connect syntax (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22840: [interactiveconsole] Port KIO code to new connect syntax

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7ee035acf838: [interactiveconsole] Port KIO code to new connect syntax (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY This exports the active colorscheme to ~/.config/gtk-3.0/colors.css and sets up

D22843: [libcolorcorrect] Port old style connects

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL

D22842: [shell/panelshadows] Port away from old style connect

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. TEST PLAN Compiles REPOSITORY R120 Plasma Workspace REVISION DETAIL

D22832: Fix build with pango 1.44

apol added a comment. In D22832#504428 , @sitter wrote: > Shouldn't this somehow be handled via pkg-config? IIRC .pc files can indicate dependencies, so I would assume one could get the requirements somehow and resolve those using generic code

D22832: Fix build with pango 1.44

sitter added a comment. Shouldn't this somehow be handled via pkg-config? IIRC .pc files can indicate dependencies, so I would assume one could get the requirements somehow and resolve those using generic code instead of essentially replicating the dependency information in cmake.

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 6 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/6/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 30 Jul 2019 22:16:09 + Build duration: 1 min 54 sec and counting JUnit Tests

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 32 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/32/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 30 Jul 2019 22:16:05 + Build duration: 2 min 22 sec and counting JUnit Tests

D22841: [dataengines/hotplug] Port code to new connect syntax

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It wasn't ported before due to the slot being overloaded. Code became

D22840: [interactiveconsole] Port KIO code to new connect syntax

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY It was previously using the old style due to getting downcast too early

D22817: Port KRunner to Plasma Components 3

apol updated this revision to Diff 62811. apol marked an inline comment as done. apol added a comment. cleanups REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22817?vs=62809=62811 BRANCH arcpatch-D22817 REVISION DETAIL

D22817: Port KRunner to Plasma Components 3

apol added inline comments. INLINE COMMENTS > broulik wrote in RunCommand.qml:56 > Why? The button's height is by default really big and krunner then looks rather comical. Here we're making sure it all stays as big as the text field after all. > broulik wrote in RunCommand.qml:226 > Why

D22817: Port KRunner to Plasma Components 3

apol updated this revision to Diff 62809. apol added a comment. Have tooltips actually shown REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22817?vs=62772=62809 BRANCH arcpatch-D22817 REVISION DETAIL https://phabricator.kde.org/D22817

D22623: Bind SQL parameters in firefox bookmarksrunner support

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7fdc614f4226: Bind SQL parameters in firefox bookmarksrunner support (authored by fvogt). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22623?vs=62220=62803#toc REPOSITORY R120 Plasma

D22623: Bind SQL parameters in firefox bookmarksrunner support

zzag accepted this revision. zzag added a comment. This revision is now accepted and ready to land. KRunners isn't my thing, but I had been working as a backend web developer for quite a while. INLINE COMMENTS > firefox.cpp:98 > } > -QList results = m_fetchsqlite->query(query, QMap

D22623: Bind SQL parameters in firefox bookmarksrunner support

fvogt added a comment. I'll land in 24h if no objections. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22623 To: fvogt, #plasma Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D22832: Fix build with pango 1.44

arojas created this revision. arojas added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. arojas requested review of this revision. REVISION SUMMARY pango>=1.44 headers depend on herfbuzz ones, make sure cmake can find them and pass the right

D19947: systray: show a small animation on the icons when activated

apol updated this revision to Diff 62799. apol added a subscriber: broulik. apol added a comment. Make the animation shrink instead of expand as suggested by @broulik REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19947?vs=54903=62799 BRANCH

D22540: Port ResultDelegate to use PlasmaComponents 3.0

apol updated this revision to Diff 62796. apol added a comment. Address kai's comments REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22540?vs=62753=62796 BRANCH pc3 (branched from master) REVISION DETAIL https://phabricator.kde.org/D22540 AFFECTED

D22540: Port ResultDelegate to use PlasmaComponents 3.0

apol marked 2 inline comments as done. apol added a comment. > The highlight isn't using Plasma theme anymore Of course it's using the theme, unless PlasmaComponents.ItemDelegate.highlighted doesn't use the theme, which then is a bug in plasma framework. > The layout explodes for

D22762: Take in consideration flat() for the All Applications menu

tcanabrava added a comment. @hein I'll try to follow your approach. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22762 To: tcanabrava, davidedmundson, hein Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

Plasma 5.16.4

Plasma 5.16.4 is now released https://www.kde.org/announcements/plasma-5.16.4.php

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

ndavis added a comment. In D22359#504108 , @davidedmundson wrote: > Can you give a bit more rationale? Some users complained about the buttons being smaller or the size not being configurable when it previously was. REPOSITORY R119

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/5/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 30 Jul 2019 09:47:47 + Build duration: 1 hr 0 min and counting CONSOLE OUTPUT

D20902: Add SDDM theme login load feedback

filipf added a comment. In D20902#458128 , @ngraham wrote: > There's no chance that this could glitch out and leave you in a state where it's not logging in but all the controls are disabled, right? Just have this happening right now.

D22818: Avoid crash if kicker plugin is used outside plasma context

apol added a comment. It could make sense to have a helper function to do this. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22818 To: davidedmundson, #plasma, apol Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 31 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/31/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 30 Jul 2019 09:47:47 + Build duration: 4 min 32 sec and counting CONSOLE OUTPUT

D22823: Restore Mouse Keyboard navigation accessibility feature

broulik created this revision. broulik added reviewers: Plasma, schweingruber, rikmills. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It got lost in the transition to the libinput mouse backend KCM. Since

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

davidedmundson added a comment. Can you give a bit more rationale? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D22359 To: ndavis, #vdg, #plasma Cc: davidedmundson, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D22817: Port KRunner to Plasma Components 3

ognarb added a comment. To add the clear button, maybe you can use Kirigami.SearchField instead? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22817 To: apol, #plasma, broulik Cc: ognarb, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,

D14063: KRunner Dictionary can't find anything

broulik added a comment. Oh, I totally missed that, sorry. This is basically committed now as D22814 REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D14063 To: McPain, broulik Cc: ngraham, mart, plasma-devel, LeGast00n,

D22814: Remove colon (:) prefix when looking up dictionary word

This revision was automatically updated to reflect the committed changes. Closed by commit R114:cda996dfb011: Remove colon (:) prefix when looking up dictionary word (authored by broulik). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D22540: Port ResultDelegate to use PlasmaComponents 3.0

broulik requested changes to this revision. broulik added a comment. This revision now requires changes to proceed. The highlight isn't using Plasma theme anymore F7118110: Screenshot_20190730_084841.png The layout explodes for long category names,

D22817: Port KRunner to Plasma Components 3

broulik added a comment. The padding on the left of the `TextField` looks off and what's up with that clear button? F7118082: Screenshot_20190730_084115.png No tooltip shows up for the configure and close buttons. INLINE COMMENTS >