D22832: Fix build with pango 1.44

[Antonio Rojas]

arojas added a comment.


  In D22832#504428 , @sitter wrote:
  
  > Shouldn't this somehow be handled via pkg-config? IIRC .pc files can 
indicate dependencies, so I would assume one could get the requirements somehow 
and resolve those using generic code instead of essentially replicating the 
dependency information in cmake.
  
  
  'pkgconf --cflags gtk+-3.0' and 'pkgconf --libs gtk+-3.0' will recursively 
return all required cflags and ldflags. But it doesn't look like this is 
exposed in cmake's pkg_check_modules - this just returns the first-level 
dependencies.
  
  Anyhow, this is just a hotfix to make the current FindGTK3 work with the 
latest release of pango. Any further changes towards simplifying it should go 
in a different commit IMO.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D22832

To: arojas, #plasma
Cc: apol, sitter, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D22539: Fix broken guard that prevents styling sliders with negative values

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:ef066d9d28ac: Fix broken guard that prevents styling 
sliders with negative values (authored by davidedmundson).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22539?vs=62003=62829

REVISION DETAIL
  https://phabricator.kde.org/D22539

AFFECTED FILES
  plugin/kquickstyleitem.cpp

To: davidedmundson, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22843: [libcolorcorrect] Port old style connects

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7aef897a3a6c: [libcolorcorrect] Port old style connects 
(authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22843?vs=62818=62828

REVISION DETAIL
  https://phabricator.kde.org/D22843

AFFECTED FILES
  libcolorcorrect/autotests/nightcolortest.cpp

To: davidedmundson, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22842: [shell/panelshadows] Port away from old style connect

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:214077668667: [shell/panelshadows] Port away from old 
style connect (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22842?vs=62817=62827

REVISION DETAIL
  https://phabricator.kde.org/D22842

AFFECTED FILES
  shell/panelshadows.cpp
  shell/panelshadows_p.h

To: davidedmundson, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22847: [runners/kill] Port old style connects

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Compiles

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22847

AFFECTED FILES
  runners/kill/killrunner_config.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22845: [GTK3] Convert all colors to use GTK color definitions

[Carson Black]

cblack updated this revision to Diff 62825.
cblack added a comment.


  Good job at picking up that change, arc. See previous change.

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22845?vs=62824=62825

BRANCH
  colordefs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22845

AFFECTED FILES
  src/_colors.scss
  src/_functions.scss
  src/build_theme.sh
  src/gtk-dark-3.18.css
  src/gtk-dark-3.20.css
  src/gtk-dark.css
  src/gtk3/gtk.scss
  src/gtk3/widgets/_app_notifications.scss
  src/gtk3/widgets/_base.scss
  src/gtk3/widgets/_button.scss
  src/gtk3/widgets/_calendar.scss
  src/gtk3/widgets/_checkboxes.scss
  src/gtk3/widgets/_color_chooser.scss
  src/gtk3/widgets/_dialogs.scss
  src/gtk3/widgets/_entry.scss
  src/gtk3/widgets/_headerbar.scss
  src/gtk3/widgets/_infobar.scss
  src/gtk3/widgets/_link.scss
  src/gtk3/widgets/_lists.scss
  src/gtk3/widgets/_menus.scss
  src/gtk3/widgets/_misc.scss
  src/gtk3/widgets/_notebook.scss
  src/gtk3/widgets/_overshoot.scss
  src/gtk3/widgets/_pathbar.scss
  src/gtk3/widgets/_progressbar.scss
  src/gtk3/widgets/_scale.scss
  src/gtk3/widgets/_scrollbar.scss
  src/gtk3/widgets/_sidebar.scss
  src/gtk3/widgets/_spinbutton.scss
  src/gtk3/widgets/_switch.scss
  src/gtk3/widgets/_toolbar.scss
  src/gtk3/widgets/_tooltips.scss
  src/gtk3/widgets/_treeview.scss
  src/gtk3/widgets/_window_decorations.scss
  src/gtk318/gtk.scss
  src/gtk318/widgets/_app_notifications.scss
  src/gtk318/widgets/_base.scss
  src/gtk318/widgets/_button.scss
  src/gtk318/widgets/_calendar.scss
  src/gtk318/widgets/_checkboxes.scss
  src/gtk318/widgets/_color_chooser.scss
  src/gtk318/widgets/_dialogs.scss
  src/gtk318/widgets/_entry.scss
  src/gtk318/widgets/_headerbar.scss
  src/gtk318/widgets/_infobar.scss
  src/gtk318/widgets/_link.scss
  src/gtk318/widgets/_lists.scss
  src/gtk318/widgets/_menus.scss
  src/gtk318/widgets/_misc.scss
  src/gtk318/widgets/_notebook.scss
  src/gtk318/widgets/_overshoot.scss
  src/gtk318/widgets/_pathbar.scss
  src/gtk318/widgets/_progressbar.scss
  src/gtk318/widgets/_scale.scss
  src/gtk318/widgets/_scrollbar.scss
  src/gtk318/widgets/_sidebar.scss
  src/gtk318/widgets/_spinbutton.scss
  src/gtk318/widgets/_switch.scss
  src/gtk318/widgets/_toolbar.scss
  src/gtk318/widgets/_tooltips.scss
  src/gtk318/widgets/_treeview.scss
  src/gtk318/widgets/_window_decorations.scss
  src/gtk320/gtk.scss
  src/gtk320/widgets/_app_notifications.scss
  src/gtk320/widgets/_base.scss
  src/gtk320/widgets/_button.scss
  src/gtk320/widgets/_calendar.scss
  src/gtk320/widgets/_checkboxes.scss
  src/gtk320/widgets/_color_chooser.scss
  src/gtk320/widgets/_dialogs.scss
  src/gtk320/widgets/_entry.scss
  src/gtk320/widgets/_headerbar.scss
  src/gtk320/widgets/_infobar.scss
  src/gtk320/widgets/_link.scss
  src/gtk320/widgets/_lists.scss
  src/gtk320/widgets/_menus.scss
  src/gtk320/widgets/_misc.scss
  src/gtk320/widgets/_notebook.scss
  src/gtk320/widgets/_overshoot.scss
  src/gtk320/widgets/_pathbar.scss
  src/gtk320/widgets/_progressbar.scss
  src/gtk320/widgets/_scale.scss
  src/gtk320/widgets/_scrollbar.scss
  src/gtk320/widgets/_sidebar.scss
  src/gtk320/widgets/_spinbutton.scss
  src/gtk320/widgets/_switch.scss
  src/gtk320/widgets/_toolbar.scss
  src/gtk320/widgets/_tooltips.scss
  src/gtk320/widgets/_treeview.scss
  src/gtk320/widgets/_window_decorations.scss

To: cblack, #vdg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22845: [GTK3] Convert all colors to use GTK color definitions

[Carson Black]

cblack updated this revision to Diff 62824.
cblack added a comment.


  Forgot about changing the build_theme.sh to export to my home directory under 
the name Breeze-Dev, reversed that

REPOSITORY
  R98 Breeze for Gtk

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22845?vs=62822=62824

BRANCH
  colordefs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22845

AFFECTED FILES
  src/_colors.scss
  src/_functions.scss
  src/build_theme.sh
  src/gtk-dark-3.18.css
  src/gtk-dark-3.20.css
  src/gtk-dark.css
  src/gtk3/gtk.scss
  src/gtk3/widgets/_app_notifications.scss
  src/gtk3/widgets/_base.scss
  src/gtk3/widgets/_button.scss
  src/gtk3/widgets/_calendar.scss
  src/gtk3/widgets/_checkboxes.scss
  src/gtk3/widgets/_color_chooser.scss
  src/gtk3/widgets/_dialogs.scss
  src/gtk3/widgets/_entry.scss
  src/gtk3/widgets/_headerbar.scss
  src/gtk3/widgets/_infobar.scss
  src/gtk3/widgets/_link.scss
  src/gtk3/widgets/_lists.scss
  src/gtk3/widgets/_menus.scss
  src/gtk3/widgets/_misc.scss
  src/gtk3/widgets/_notebook.scss
  src/gtk3/widgets/_overshoot.scss
  src/gtk3/widgets/_pathbar.scss
  src/gtk3/widgets/_progressbar.scss
  src/gtk3/widgets/_scale.scss
  src/gtk3/widgets/_scrollbar.scss
  src/gtk3/widgets/_sidebar.scss
  src/gtk3/widgets/_spinbutton.scss
  src/gtk3/widgets/_switch.scss
  src/gtk3/widgets/_toolbar.scss
  src/gtk3/widgets/_tooltips.scss
  src/gtk3/widgets/_treeview.scss
  src/gtk3/widgets/_window_decorations.scss
  src/gtk318/gtk.scss
  src/gtk318/widgets/_app_notifications.scss
  src/gtk318/widgets/_base.scss
  src/gtk318/widgets/_button.scss
  src/gtk318/widgets/_calendar.scss
  src/gtk318/widgets/_checkboxes.scss
  src/gtk318/widgets/_color_chooser.scss
  src/gtk318/widgets/_dialogs.scss
  src/gtk318/widgets/_entry.scss
  src/gtk318/widgets/_headerbar.scss
  src/gtk318/widgets/_infobar.scss
  src/gtk318/widgets/_link.scss
  src/gtk318/widgets/_lists.scss
  src/gtk318/widgets/_menus.scss
  src/gtk318/widgets/_misc.scss
  src/gtk318/widgets/_notebook.scss
  src/gtk318/widgets/_overshoot.scss
  src/gtk318/widgets/_pathbar.scss
  src/gtk318/widgets/_progressbar.scss
  src/gtk318/widgets/_scale.scss
  src/gtk318/widgets/_scrollbar.scss
  src/gtk318/widgets/_sidebar.scss
  src/gtk318/widgets/_spinbutton.scss
  src/gtk318/widgets/_switch.scss
  src/gtk318/widgets/_toolbar.scss
  src/gtk318/widgets/_tooltips.scss
  src/gtk318/widgets/_treeview.scss
  src/gtk318/widgets/_window_decorations.scss
  src/gtk320/gtk.scss
  src/gtk320/widgets/_app_notifications.scss
  src/gtk320/widgets/_base.scss
  src/gtk320/widgets/_button.scss
  src/gtk320/widgets/_calendar.scss
  src/gtk320/widgets/_checkboxes.scss
  src/gtk320/widgets/_color_chooser.scss
  src/gtk320/widgets/_dialogs.scss
  src/gtk320/widgets/_entry.scss
  src/gtk320/widgets/_headerbar.scss
  src/gtk320/widgets/_infobar.scss
  src/gtk320/widgets/_link.scss
  src/gtk320/widgets/_lists.scss
  src/gtk320/widgets/_menus.scss
  src/gtk320/widgets/_misc.scss
  src/gtk320/widgets/_notebook.scss
  src/gtk320/widgets/_overshoot.scss
  src/gtk320/widgets/_pathbar.scss
  src/gtk320/widgets/_progressbar.scss
  src/gtk320/widgets/_scale.scss
  src/gtk320/widgets/_scrollbar.scss
  src/gtk320/widgets/_sidebar.scss
  src/gtk320/widgets/_spinbutton.scss
  src/gtk320/widgets/_switch.scss
  src/gtk320/widgets/_toolbar.scss
  src/gtk320/widgets/_tooltips.scss
  src/gtk320/widgets/_treeview.scss
  src/gtk320/widgets/_window_decorations.scss

To: cblack, #vdg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22846: Port KeyboardLayout component to use generated DBus interface

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  QDBusInterface is useful for runtime introspection but little else.
  
  As we know the interface in advance we can generate the keyboard layouts
  interface and have non blocking, easier to read, easier to maintain
  code.

TEST PLAN
  Opened lock screen, it had the whole list, cycled between them

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22846

AFFECTED FILES
  components/keyboardlayout/CMakeLists.txt
  components/keyboardlayout/keyboardlayout.cpp
  components/keyboardlayout/keyboardlayout.h
  components/keyboardlayout/org.kde.KeyboardLayouts.xml

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22845: [GTK3] Convert all colors to use GTK color definitions

[Carson Black]

cblack created this revision.
cblack added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  All of the colors pulled from a colorscheme in Breeze GTK now use GTK's color 
definitons, allowing them to be changed without recompiling the theme.
  GTK18 and GTK20 have been merged as well, lessening work required to make 
changes & maintain.
  There are some other minor changes (radio buttons/checkboxes now sink in when 
clicking as their Qt counterparts do.)
  The varaible $new-highlight has been added to gtk.scss. Toggling it to true 
will cause the highlights to resemble ndavis/highlight @ Breeze. Added that 
because I had already made the changes to the theme when I did the colordefs, 
and I don't want to wait on the new highlight style to be set in stone before 
this can be merged.

TEST PLAN
  See that the theme works as intended with GTK color definitions.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  colordefs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22845

AFFECTED FILES
  src/_colors.scss
  src/_functions.scss
  src/build_theme.sh
  src/gtk-dark-3.18.css
  src/gtk-dark-3.20.css
  src/gtk-dark.css
  src/gtk3/gtk.scss
  src/gtk3/widgets/_app_notifications.scss
  src/gtk3/widgets/_base.scss
  src/gtk3/widgets/_button.scss
  src/gtk3/widgets/_calendar.scss
  src/gtk3/widgets/_checkboxes.scss
  src/gtk3/widgets/_color_chooser.scss
  src/gtk3/widgets/_dialogs.scss
  src/gtk3/widgets/_entry.scss
  src/gtk3/widgets/_headerbar.scss
  src/gtk3/widgets/_infobar.scss
  src/gtk3/widgets/_link.scss
  src/gtk3/widgets/_lists.scss
  src/gtk3/widgets/_menus.scss
  src/gtk3/widgets/_misc.scss
  src/gtk3/widgets/_notebook.scss
  src/gtk3/widgets/_overshoot.scss
  src/gtk3/widgets/_pathbar.scss
  src/gtk3/widgets/_progressbar.scss
  src/gtk3/widgets/_scale.scss
  src/gtk3/widgets/_scrollbar.scss
  src/gtk3/widgets/_sidebar.scss
  src/gtk3/widgets/_spinbutton.scss
  src/gtk3/widgets/_switch.scss
  src/gtk3/widgets/_toolbar.scss
  src/gtk3/widgets/_tooltips.scss
  src/gtk3/widgets/_treeview.scss
  src/gtk3/widgets/_window_decorations.scss
  src/gtk318/gtk.scss
  src/gtk318/widgets/_app_notifications.scss
  src/gtk318/widgets/_base.scss
  src/gtk318/widgets/_button.scss
  src/gtk318/widgets/_calendar.scss
  src/gtk318/widgets/_checkboxes.scss
  src/gtk318/widgets/_color_chooser.scss
  src/gtk318/widgets/_dialogs.scss
  src/gtk318/widgets/_entry.scss
  src/gtk318/widgets/_headerbar.scss
  src/gtk318/widgets/_infobar.scss
  src/gtk318/widgets/_link.scss
  src/gtk318/widgets/_lists.scss
  src/gtk318/widgets/_menus.scss
  src/gtk318/widgets/_misc.scss
  src/gtk318/widgets/_notebook.scss
  src/gtk318/widgets/_overshoot.scss
  src/gtk318/widgets/_pathbar.scss
  src/gtk318/widgets/_progressbar.scss
  src/gtk318/widgets/_scale.scss
  src/gtk318/widgets/_scrollbar.scss
  src/gtk318/widgets/_sidebar.scss
  src/gtk318/widgets/_spinbutton.scss
  src/gtk318/widgets/_switch.scss
  src/gtk318/widgets/_toolbar.scss
  src/gtk318/widgets/_tooltips.scss
  src/gtk318/widgets/_treeview.scss
  src/gtk318/widgets/_window_decorations.scss
  src/gtk320/gtk.scss
  src/gtk320/widgets/_app_notifications.scss
  src/gtk320/widgets/_base.scss
  src/gtk320/widgets/_button.scss
  src/gtk320/widgets/_calendar.scss
  src/gtk320/widgets/_checkboxes.scss
  src/gtk320/widgets/_color_chooser.scss
  src/gtk320/widgets/_dialogs.scss
  src/gtk320/widgets/_entry.scss
  src/gtk320/widgets/_headerbar.scss
  src/gtk320/widgets/_infobar.scss
  src/gtk320/widgets/_link.scss
  src/gtk320/widgets/_lists.scss
  src/gtk320/widgets/_menus.scss
  src/gtk320/widgets/_misc.scss
  src/gtk320/widgets/_notebook.scss
  src/gtk320/widgets/_overshoot.scss
  src/gtk320/widgets/_pathbar.scss
  src/gtk320/widgets/_progressbar.scss
  src/gtk320/widgets/_scale.scss
  src/gtk320/widgets/_scrollbar.scss
  src/gtk320/widgets/_sidebar.scss
  src/gtk320/widgets/_spinbutton.scss
  src/gtk320/widgets/_switch.scss
  src/gtk320/widgets/_toolbar.scss
  src/gtk320/widgets/_tooltips.scss
  src/gtk320/widgets/_treeview.scss
  src/gtk320/widgets/_window_decorations.scss

To: cblack, #vdg, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22841: [dataengines/hotplug] Port code to new connect syntax

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:20c353d4f4ee: [dataengines/hotplug] Port code to new 
connect syntax (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22841?vs=62816=62820

REVISION DETAIL
  https://phabricator.kde.org/D22841

AFFECTED FILES
  dataengines/hotplug/hotplugengine.cpp
  dataengines/hotplug/hotplugengine.h

To: davidedmundson, #plasma, sitter
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22840: [interactiveconsole] Port KIO code to new connect syntax

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7ee035acf838: [interactiveconsole] Port KIO code to new 
connect syntax (authored by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22840?vs=62815=62821

REVISION DETAIL
  https://phabricator.kde.org/D22840

AFFECTED FILES
  components/shellprivate/interactiveconsole/interactiveconsole.cpp

To: davidedmundson, #plasma, sitter
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22844: [WIP/RFC] [kcm-colors] Export colorscheme to GTK color definitions

[Carson Black]

cblack created this revision.
cblack added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  This exports the active colorscheme to ~/.config/gtk-3.0/colors.css and sets 
up ~/.config/gtk-3.0/gtk.css to read from it.
  This will do nothing visibly without changes to Breeze GTK [Todo: send diff 
for Breeze GTK and link here]
  This is not complete and only exports about 20ish out of 80ish colors as of 
this time.

TEST PLAN
  See that ~/.config/gtk-3.0/colors.css is created, colorscheme is dumped 
correctly, and that gtk.css links to it.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm-colors-gtk (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22844

AFFECTED FILES
  kcms/colors/colors.cpp

To: cblack, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22843: [libcolorcorrect] Port old style connects

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Compiles

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D22843

AFFECTED FILES
  libcolorcorrect/autotests/nightcolortest.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22842: [shell/panelshadows] Port away from old style connect

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Compiles

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22842

AFFECTED FILES
  shell/panelshadows.cpp
  shell/panelshadows_p.h

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22832: Fix build with pango 1.44

[Aleix Pol Gonzalez]

apol added a comment.


  In D22832#504428 , @sitter wrote:
  
  > Shouldn't this somehow be handled via pkg-config? IIRC .pc files can 
indicate dependencies, so I would assume one could get the requirements somehow 
and resolve those using generic code instead of essentially replicating the 
dependency information in cmake.
  
  
  Quite possibly, still I'm happy to let this in. FindGTK3.cmake shouldn't be 
needed altogether and it's a local change to kde-gtk-config.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D22832

To: arojas, #plasma
Cc: apol, sitter, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D22832: Fix build with pango 1.44

[Harald Sitter]

sitter added a comment.


  Shouldn't this somehow be handled via pkg-config? IIRC .pc files can indicate 
dependencies, so I would assume one could get the requirements somehow and 
resolve those using generic code instead of essentially replicating the 
dependency information in cmake.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D22832

To: arojas, #plasma
Cc: sitter, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 6 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/6/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 30 Jul 2019 22:16:09 +
 Build duration:
1 min 54 sec and counting
   JUnit Tests
  Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 32 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/32/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 30 Jul 2019 22:16:05 +
 Build duration:
2 min 22 sec and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.keditfiletype Failed: 1 test(s), Passed: 0 test(s), Skipped: 0 test(s), Total: 1 test(s)Failed: projectroot.keditfiletype.tests.filetypestest
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report20%
(2/10)15%
(4/26)15%
(4/26)19%
(493/2582)14%
(212/1503)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalskbroadcastnotification0%
(0/1)0%
(0/1)0%
(0/49)0%
(0/22)kcmshell0%
(0/2)0%
(0/2)0%
(0/164)0%
(0/86)kdesu0%
(0/2)0%
(0/2)0%
(0/275)0%
(0/192)keditfiletype23%
(3/13)23%
(3/13)23%
(285/1248)20%
(136/664)keditfiletype.tests100%
(1/1)100%
(1/1)81%
(208/257)41%
(76/186)kioclient0%
(0/2)0%
(0/2)0%
(0/258)0%
(0/136)kmimetypefinder0%
(0/1)0%
(0/1)0%
(0/33)0%
(0/10)kstart0%
(0/2)0%
(0/2)0%
(0/219)0%
(0/168)ksvgtopng0%
(0/1)0%
(0/1)0%
(0/16)0%
(0/4)ktraderclient0%
(0/1)0%
(0/1)0%
(0/63)0%
(0/35)

D22841: [dataengines/hotplug] Port code to new connect syntax

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  It wasn't ported before due to the slot being overloaded.
  
  Code became cleaner if we renamed one of the private slots.

TEST PLAN
  Compiles

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22841

AFFECTED FILES
  dataengines/hotplug/hotplugengine.cpp
  dataengines/hotplug/hotplugengine.h

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22840: [interactiveconsole] Port KIO code to new connect syntax

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  It was previously using the old style due to getting downcast too early

TEST PLAN
  Compiles

REPOSITORY
  R120 Plasma Workspace

BRANCH
  origin-master (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22840

AFFECTED FILES
  components/shellprivate/interactiveconsole/interactiveconsole.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22817: Port KRunner to Plasma Components 3

[Aleix Pol Gonzalez]

apol updated this revision to Diff 62811.
apol marked an inline comment as done.
apol added a comment.


  cleanups

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22817?vs=62809=62811

BRANCH
  arcpatch-D22817

REVISION DETAIL
  https://phabricator.kde.org/D22817

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

To: apol, #plasma, broulik
Cc: ognarb, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22817: Port KRunner to Plasma Components 3

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> broulik wrote in RunCommand.qml:56
> Why?

The button's height is by default really big and krunner then looks rather 
comical.
Here we're making sure it all stays as big as the text field after all.

> broulik wrote in RunCommand.qml:226
> Why remove this? It breaks highlighting of history items.

PC3 has no moving hightlight delegate, it's the delegate that highlights itself.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22817

To: apol, #plasma, broulik
Cc: ognarb, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22817: Port KRunner to Plasma Components 3

[Aleix Pol Gonzalez]

apol updated this revision to Diff 62809.
apol added a comment.


  Have tooltips actually shown

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22817?vs=62772=62809

BRANCH
  arcpatch-D22817

REVISION DETAIL
  https://phabricator.kde.org/D22817

AFFECTED FILES
  lookandfeel/contents/runcommand/RunCommand.qml

To: apol, #plasma, broulik
Cc: ognarb, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22623: Bind SQL parameters in firefox bookmarksrunner support

[Fabian Vogt]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7fdc614f4226: Bind SQL parameters in firefox 
bookmarksrunner support (authored by fvogt).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D22623?vs=62220=62803#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22623?vs=62220=62803

REVISION DETAIL
  https://phabricator.kde.org/D22623

AFFECTED FILES
  runners/bookmarks/browsers/firefox.cpp

To: fvogt, #plasma, zzag
Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22623: Bind SQL parameters in firefox bookmarksrunner support

[Vlad Zagorodniy]

zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  KRunners isn't my thing, but I had been working as a backend web developer 
for quite a while.

INLINE COMMENTS

> firefox.cpp:98
>  }
> -QList results = m_fetchsqlite->query(query, QMap QVariant>());
> +QMap bindVariables
> +{{QStringLiteral(":term"), QStringLiteral("%%%1%%").arg(term)}};

Missing const + whitespace between comma and QVariant, i.e.

  const QMap bindVariables {
  { QStringLiteral(":term"), QStringLiteral("%%%1%%").arg(term) },
  };

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D22623

To: fvogt, #plasma, zzag
Cc: zzag, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D22623: Bind SQL parameters in firefox bookmarksrunner support

[Fabian Vogt]

fvogt added a comment.


  I'll land in 24h if no objections.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22623

To: fvogt, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22832: Fix build with pango 1.44

[Antonio Rojas]

arojas created this revision.
arojas added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
arojas requested review of this revision.

REVISION SUMMARY
  pango>=1.44 headers depend on herfbuzz ones, make sure cmake can find them 
and pass the right include dir to the compiler

TEST PLAN
  Builds

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D22832

AFFECTED FILES
  cmake/modules/FindGTK3.cmake

To: arojas, #plasma
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D19947: systray: show a small animation on the icons when activated

[Aleix Pol Gonzalez]

apol updated this revision to Diff 62799.
apol added a subscriber: broulik.
apol added a comment.


  Make the animation shrink instead of expand as suggested by @broulik

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D19947?vs=54903=62799

BRANCH
  arcpatch-D19947_1

REVISION DETAIL
  https://phabricator.kde.org/D19947

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml

To: apol, #plasma
Cc: broulik, anthonyfieroni, davidedmundson, ngraham, plasma-devel, LeGast00n, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D22540: Port ResultDelegate to use PlasmaComponents 3.0

[Aleix Pol Gonzalez]

apol updated this revision to Diff 62796.
apol added a comment.


  Address kai's comments

REPOSITORY
  R112 Milou

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22540?vs=62753=62796

BRANCH
  pc3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22540

AFFECTED FILES
  lib/qml/ResultDelegate.qml
  lib/qml/ResultsView.qml

To: apol, #plasma, broulik
Cc: davidedmundson, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22540: Port ResultDelegate to use PlasmaComponents 3.0

[Aleix Pol Gonzalez]

apol marked 2 inline comments as done.
apol added a comment.


  > The highlight isn't using Plasma theme anymore
  
  Of course it's using the theme, unless 
PlasmaComponents.ItemDelegate.highlighted doesn't use the theme, which then is 
a bug in plasma framework.
  
  > The layout explodes for long category names, they should be elided.
  
  Fixed
  
  > The tooltips look quite bad and crammed because as I said they're not 
separate windows anymore.
  
  F7120119: photo_2019-07-30_16-37-31.jpg 
  
  > Also, they show up immediately instead of after a delay.
  
  Fixed, we could probably find a more generic fix.
  
  > Clicking results doesn't do anything now.
  
  Fixed
  
  > and there can now be both a highlight following the mouse and a selection 
following the keyboard.
  
  Would you prefer to change the current on hover? It's certainly doable but 
I'm not sure we want that.

INLINE COMMENTS

> broulik wrote in ResultDelegate.qml:233
> QQC2 tooltip doesn't seem to handle mnemonics, leading to text like "Run in 
> "

Can't see that, see screenshot.
Also if that's the case, then we should fix it like we did for desktop 
components.

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D22540

To: apol, #plasma, broulik
Cc: davidedmundson, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22762: Take in consideration flat() for the All Applications menu

[Tomaz Canabrava]

tcanabrava added a comment.


  @hein I'll try to follow your approach.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22762

To: tcanabrava, davidedmundson, hein
Cc: hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Plasma 5.16.4

[Jonathan Riddell]

Plasma 5.16.4 is now released
https://www.kde.org/announcements/plasma-5.16.4.php

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

[Noah Davis]

ndavis added a comment.


  In D22359#504108 , @davidedmundson 
wrote:
  
  > Can you give a bit more rationale?
  
  
  Some users complained about the buttons being smaller or the size not being 
configurable when it previously was.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22359

To: ndavis, #vdg, #plasma
Cc: davidedmundson, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 5 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/5/
 Project:
stable-kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 30 Jul 2019 09:47:47 +
 Build duration:
1 hr 0 min and counting
   CONSOLE OUTPUT
  [...truncated 190 lines...][2019-07-30T10:48:14.631Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/display/redirect'[2019-07-30T10:48:14.631Z] MAIL  = '/var/mail/jenkins'[2019-07-30T10:48:14.631Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/5/display/redirect?page=changes'[2019-07-30T10:48:14.631Z] JENKINS_URL   = 'https://build.kde.org/'[2019-07-30T10:48:14.631Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2019-07-30T10:48:14.631Z] JOB_BASE_NAME = 'stable-kf5-qt5 FreeBSDQt5.13'[2019-07-30T10:48:14.631Z] HUDSON_HOME   = '/home/production/data'[2019-07-30T10:48:14.632Z] BUILD_ID  = '5'[2019-07-30T10:48:14.632Z] OLDPWD= '/usr/home/jenkins'[2019-07-30T10:48:14.632Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13'[2019-07-30T10:48:14.632Z] _ = '/usr/local/bin/java'[2019-07-30T10:48:14.632Z] TERM  = 'su'[2019-07-30T10:48:14.632Z] NODE_LABELS   = 'FreeBSD Builder 2 FreeBSDQt5.13'[2019-07-30T10:48:14.632Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 FreeBSDQt5.13-5'[2019-07-30T10:48:14.632Z] BUILD_DISPLAY_NAME= '#5'[2019-07-30T10:48:14.632Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/5/display/redirect'[2019-07-30T10:48:14.632Z] USER  = 'jenkins'[2019-07-30T10:48:14.632Z] HOME  = '/home/jenkins'[2019-07-30T10:48:14.632Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/5/'[2019-07-30T10:48:14.632Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/'[2019-07-30T10:48:14.632Z] HUDSON_URL= 'https://build.kde.org/'[2019-07-30T10:48:14.632Z] SHELL = '/usr/local/bin/bash'[2019-07-30T10:48:14.632Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13'[2019-07-30T10:48:14.632Z] MM_CHARSET= 'UTF-8'[2019-07-30T10:48:14.632Z] STAGE_NAME= 'Configuring Build'[2019-07-30T10:48:14.632Z] NODE_NAME = 'FreeBSD Builder 2'[2019-07-30T10:48:14.632Z] BLOCKSIZE = 'K'[2019-07-30T10:48:14.632Z] EXECUTOR_NUMBER   = '0'[2019-07-30T10:48:14.632Z] SHLVL = '0'[2019-07-30T10:48:14.632Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-07-30T10:48:14.632Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib'[2019-07-30T10:48:14.632Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2019-07-30T10:48:14.632Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2019-07-30T10:48:14.632Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2019-07-30T10:48:14.632Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2019-07-30T10:48:14.632Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2019-07-30T10:48:14.632Z] QT_SELECT = 'qt5'[2019-07-30T10:48:14.632Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-07-30T10:48:14.632Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2019-07-30T10:48:14.632Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2019-07-30T10:48:14.632Z] [2019-07-30T10:48:14.632Z] [2019-07-30T10:48:14.632Z] == Commencing Configuration:[2019-07-30T10:48:14.632Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins/install-prefix/"  "/usr/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 FreeBSDQt5.13"[2019-07-30T10:48:14.889Z] -- The C compiler identification is Clang 6.0.1[2019-07-30T10:48:14.889Z] -- The CXX compiler identification is Clang 6.0.1[2019-07-30T10:48:14.889Z] -- Check for working C compiler: /usr/bin/cc[2019-07-30T10:48:14.889Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-07-30T10:48:14.889Z] -- Detecting 

D20902: Add SDDM theme login load feedback

[Filip Fila]

filipf added a comment.


  In D20902#458128 , @ngraham wrote:
  
  > There's no chance that this could glitch out and leave you in a state where 
it's not logging in but all the controls are disabled, right?
  
  
  Just have this happening right now.
  
  I had a separate home partition, reinstalled the OS and pointed it to the old 
home partition. Plasma forgot which users were on the system. Added the users 
back via user-manager, went to SDDM to log in, hang-fest.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20902

To: GB_2, #plasma, #vdg, ngraham
Cc: filipf, abetts, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D22818: Avoid crash if kicker plugin is used outside plasma context

[Aleix Pol Gonzalez]

apol added a comment.


  It could make sense to have a helper function to do this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22818

To: davidedmundson, #plasma, apol
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 31 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/31/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 30 Jul 2019 09:47:47 +
 Build duration:
4 min 32 sec and counting
   CONSOLE OUTPUT
  [...truncated 254 lines...][2019-07-30T09:52:14.115Z] OSTYPE= 'linux'[2019-07-30T09:52:14.115Z] JOB_NAME  = 'Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2019-07-30T09:52:14.115Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2019-07-30T09:52:14.115Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/31/display/redirect'[2019-07-30T09:52:14.115Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/display/redirect'[2019-07-30T09:52:14.115Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12'[2019-07-30T09:52:14.115Z] HUDSON_URL= 'https://build.kde.org/'[2019-07-30T09:52:14.115Z] LESSCLOSE = 'lessclose.sh %s %s'[2019-07-30T09:52:14.115Z] NODE_NAME = 'Docker Swarm-aa229f092710'[2019-07-30T09:52:14.115Z] HOST  = 'aa229f092710'[2019-07-30T09:52:14.115Z] LESSOPEN  = 'lessopen.sh %s'[2019-07-30T09:52:14.115Z] USER  = 'jenkins'[2019-07-30T09:52:14.115Z] MORE  = '-sl'[2019-07-30T09:52:14.115Z] CSHEDIT   = 'emacs'[2019-07-30T09:52:14.115Z] SHLVL = '2'[2019-07-30T09:52:14.115Z] BUILD_TAG = 'jenkins-Plasma-kde-cli-tools-stable-kf5-qt5 SUSEQt5.12-31'[2019-07-30T09:52:14.115Z] WINDOWMANAGER = 'xterm'[2019-07-30T09:52:14.115Z] PAGER = 'less'[2019-07-30T09:52:14.115Z] EXECUTOR_NUMBER   = '0'[2019-07-30T09:52:14.115Z] CVS_RSH   = 'ssh'[2019-07-30T09:52:14.115Z] LIBGL_DEBUG   = 'quiet'[2019-07-30T09:52:14.115Z] STAGE_NAME= 'Configuring Build'[2019-07-30T09:52:14.115Z] NODE_LABELS   = 'Docker Swarm-aa229f092710 SUSEQt5.12'[2019-07-30T09:52:14.115Z] XCURSOR_THEME = 'DMZ-Black'[2019-07-30T09:52:14.115Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2019-07-30T09:52:14.115Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2019-07-30T09:52:14.115Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2019-07-30T09:52:14.115Z] PROFILEREAD   = 'true'[2019-07-30T09:52:14.115Z] MAIL  = '/var/mail/jenkins'[2019-07-30T09:52:14.115Z] HOSTTYPE  = 'x86_64'[2019-07-30T09:52:14.115Z] BUILD_ID  = '31'[2019-07-30T09:52:14.115Z] LESSKEY   = '/etc/lesskey.bin'[2019-07-30T09:52:14.115Z] OLDPWD= '/home/jenkins'[2019-07-30T09:52:14.115Z] LC_CTYPE  = 'C.UTF-8'[2019-07-30T09:52:14.115Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2019-07-30T09:52:14.115Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2019-07-30T09:52:14.115Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2019-07-30T09:52:14.115Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2019-07-30T09:52:14.115Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2019-07-30T09:52:14.115Z] QT_SELECT = 'qt5'[2019-07-30T09:52:14.115Z] LANG  = 'en_US.UTF-8'[2019-07-30T09:52:14.115Z] XDG_CURRENT_DESKTOP   = 'KDE'[2019-07-30T09:52:14.115Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2019-07-30T09:52:14.115Z] [2019-07-30T09:52:14.115Z] [2019-07-30T09:52:14.115Z] == Commencing Configuration:[2019-07-30T09:52:14.115Z] cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma/kde-cli-tools/stable-kf5-qt5 SUSEQt5.12"[2019-07-30T09:52:14.115Z] -- The C compiler identification is GNU 9.1.1[2019-07-30T09:52:14.648Z] -- The CXX compiler identification is GNU 9.1.1[2019-07-30T09:52:14.648Z] -- Check for working C compiler: /usr/bin/cc[2019-07-30T09:52:14.648Z] -- Check for working C compiler: /usr/bin/cc -- works[2019-07-30T09:52:14.648Z] -- Detecting C compiler ABI info[2019-07-30T09:52:15.179Z] -- Detecting C compiler ABI info - done[2019-07-30T09:52:15.179Z] -- Detecting C compile features[2019-07-30T09:52:15.692Z] -- Detecting C compile features - done[2019-07-30T09:52:15.692Z] -- Check for working CXX compiler: 

D22823: Restore Mouse Keyboard navigation accessibility feature

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, schweingruber, rikmills.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It got lost in the transition to the libinput mouse backend KCM.
  Since it is an accessibility feature and handled by kaccess rather than 
libinput/evdev, move it over to the kaccess KCM.

TEST PLAN
  - Enabled the feautre, was able to move my mouse with the numpad
  
  Disregard the multiple `openConfig` and `sync()` calls, this is just 
consistent with the code around it, everything else is copied verbatim from the 
old KCM and ported to new connect syntax and that's it

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22823

AFFECTED FILES
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp

To: broulik, #plasma, schweingruber, rikmills
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

[David Edmundson]

davidedmundson added a comment.


  Can you give a bit more rationale?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D22359

To: ndavis, #vdg, #plasma
Cc: davidedmundson, filipf, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22817: Port KRunner to Plasma Components 3

[Carl Schwan]

ognarb added a comment.


  To add the clear button, maybe you can use Kirigami.SearchField instead?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22817

To: apol, #plasma, broulik
Cc: ognarb, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D14063: KRunner Dictionary can't find anything

[Kai Uwe Broulik]

broulik added a comment.


  Oh, I totally missed that, sorry. This is basically committed now as D22814 


REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D14063

To: McPain, broulik
Cc: ngraham, mart, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol

D22814: Remove colon (:) prefix when looking up dictionary word

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:cda996dfb011: Remove colon (:) prefix when looking up 
dictionary word (authored by broulik).

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22814?vs=62763=62775

REVISION DETAIL
  https://phabricator.kde.org/D22814

AFFECTED FILES
  runners/dictionary/dictionarymatchengine.cpp

To: broulik, #plasma, mart, kossebau, davidedmundson
Cc: plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, mart

D22540: Port ResultDelegate to use PlasmaComponents 3.0

[Kai Uwe Broulik]

broulik requested changes to this revision.
broulik added a comment.
This revision now requires changes to proceed.


  The highlight isn't using Plasma theme anymore
  F7118110: Screenshot_20190730_084841.png 

  The layout explodes for long category names, they should be elided.
  F7118127: Screenshot_20190730_085343.png 

  
  The tooltips look quite bad and crammed because as I said they're not 
separate windows anymore. Also, they show up immediately instead of after a 
delay.
  Clicking results doesn't do anything now, and there can now be both a 
highlight following the mouse and a selection following the keyboard.

INLINE COMMENTS

> ResultDelegate.qml:233
> +if (index === 0) { // Shift+Return will invoke first 
> action
> +text = i18ndc("milou", "placeholder is action e.g. 
> run in terminal, in parenthesis is shortcut", "%1 (Shift+Return)", text)
> +}

QQC2 tooltip doesn't seem to handle mnemonics, leading to text like "Run in 
"

> apol wrote in ResultDelegate.qml:142
> There's no separator svg. you suggest creating a new one?

Use whatever the `PlasmaComponents.ListItem` uses

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D22540

To: apol, #plasma, broulik
Cc: davidedmundson, broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22817: Port KRunner to Plasma Components 3

[Kai Uwe Broulik]

broulik added a comment.


  The padding on the left of the `TextField` looks off and what's up with that 
clear button?
  F7118082: Screenshot_20190730_084115.png 

  No tooltip shows up for the configure and close buttons.

INLINE COMMENTS

> RunCommand.qml:56
>  Layout.alignment: Qt.AlignTop
> +height: queryField.implicitHeight
> +

Why?

> RunCommand.qml:59
>  PlasmaComponents.ToolButton {
> -iconSource: "configure"
> +implicitHeight: queryField.implicitHeight
> +implicitWidth: queryField.implicitHeight

Why?

> RunCommand.qml:226
>  keyNavigationWraps: true
> -highlight: PlasmaComponents.Highlight {}
>  highlightMoveDuration: 0

Why remove this? It breaks highlighting of history items.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22817

To: apol, #plasma
Cc: broulik, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, 
Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart