D23296: Simplify rendering of raised toolbuttons with menu

ndavis added a comment. Hmm. I was thinking about doing something like this mockup: F7265921: Screenshot_20190820_203213.png REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D23296 To: hpereiradacosta, #breeze, ndavis Cc:

D23305: Add plugin showing nvidia GPU load stats

davidedmundson updated this revision to Diff 64180. davidedmundson added a comment. remove stray copy pasted line REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23305?vs=64160=64180 BRANCH plugins2 REVISION DETAIL

D23305: Add plugin showing nvidia GPU load stats

apol added a comment. Otherwise LGTM INLINE COMMENTS > CMakeLists.txt:2 > +add_library(ksysguard_plugin_nvidia MODULE nvidia.cpp) > +include_directories(${X11_XRes_INCLUDE_PATH}) > + copy-paste? I don't see why XRes is needed. REPOSITORY R111 KSysguard Library REVISION DETAIL

D23306: Add AppStream metadata file

kossebau added a comment. In D23306#515662 , @mak wrote: > In D23306#515616 , @kossebau wrote: > > > Thanks! Though reading it, leaves open questions with me: > > > > - what is meant by

D23306: Add AppStream metadata file

mak added a comment. In D23306#515616 , @kossebau wrote: > In D23306#515609 , @mak wrote: > > > @kossebau How to hide .desktop files from AppStream is now more visible in

D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown

ngraham updated this revision to Diff 64177. ngraham added a comment. Re-add other conditions REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23279?vs=64172=64177 BRANCH only-show-switch-user-button-when-more-than-one-session-is-active (branched

D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown

ngraham added a comment. No, you're right, those should still be there. REPOSITORY R120 Plasma Workspace BRANCH only-show-switch-user-button-when-more-than-one-session-is-active (branched from master) REVISION DETAIL https://phabricator.kde.org/D23279 To: ngraham, mart, #plasma,

D23279: [Lock screen] Always show "Switch User" button regardless of whether fake "switch user" item is shown

filipf accepted this revision. filipf added a comment. This revision is now accepted and ready to land. I don't know if there would be some use in keeping `sessionsModel.canStartNewSession && sessionsModel.canSwitchUser` around, but the button should always be visible (when technically

D23279: [Lock screen] Fix bug causing "Switch User" button to always be visible

ngraham updated this revision to Diff 64172. ngraham added a comment. Always show the button REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23279?vs=64080=64172 BRANCH only-show-switch-user-button-when-more-than-one-session-is-active (branched

D23306: Add AppStream metadata file

ngraham updated this revision to Diff 64171. ngraham added a comment. Add `project_group` and `compulsory_for_desktop` tags REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23306?vs=64169=64171 BRANCH add-appdata-file (branched from master)

D23306: Add AppStream metadata file

ngraham added a comment. @mak The link https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-compulsory_for_desktop seems broken. I found a reference to `compulsory_for_desktop` at https://www.freedesktop.org/software/appstream/docs/chap-CollectionData.html, but it

D23279: [Lock screen] Fix bug causing "Switch User" button to always be visible

filipf added a comment. In D23279#515614 , @ngraham wrote: > In D23279#515610 , @filipf wrote: > > > What if someone else is logged in, they locked their screen and I want to switch the session? >

D23306: Add AppStream metadata file

kossebau added a comment. In D23306#515609 , @mak wrote: > @kossebau How to hide .desktop files from AppStream is now more visible in https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html#spec-appdata-introduction

D23279: [Lock screen] Fix bug causing "Switch User" button to always be visible

ngraham added a comment. In D23279#515610 , @filipf wrote: > What if someone else is logged in, they locked their screen and I want to switch the session? Then there are multiple sessions because you're already logged-in, so the button

D23117: kcmlookandfeel - Correctly set the Splash Screen to what the Look & Feel intends for it to be set to

GB_2 added a comment. Ping. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23117 To: The-Feren-OS-Dev, #plasma Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed,

D23279: [Lock screen] Fix bug causing "Switch User" button to always be visible

filipf added a comment. What if someone else is logged in, they locked their screen and I want to switch the session? Might be something urgent, and if I don't have a button to leave their lock screen I might have to reboot and lose their work. > No more Switch User button on the

D23306: Add AppStream metadata file

mak added a comment. In D23306#515595 , @ngraham wrote: > In fact there are three possible relationships: > > - App is associated with desktop, but not required by it or limited to it (e.g. Dolphin, Gwenview, Nautilus, GNOME Music)

D23308: Add a warning message about needing globally installed theme files

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY Settings sync only works for theme files that are installed globally. We should add a warning message so users aren't confused

D23283: When asked to switch sessions, skip to session creation if there's nothing to switch to

gregormi added a comment. Looks great. Thanks, Nate. (Sidenote: I wonder if there is an obvious way to close the additional session. Currently, I use the keyboard: Ctrl+Shift+F8 and then Ctrl+Alt+Back,Back) REPOSITORY R120 Plasma Workspace REVISION DETAIL

D23306: Add AppStream metadata file

ngraham added a comment. In fact there are three possible relationships: - App is associated with desktop, but not required by it or limited to it (e.g. Dolphin, Gwenview, Nautilus, GNOME Music) - App requires desktop (e.g. KDE System Settings, GNOME System Settings, GNOME Tweaks) -

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #38 from Xwang --- After the plasma restart and a reboot the issue has resolved on my pc. I use sddm as login. -- You are receiving this mail because: You are the assignee for the bug.

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #37 from Marco Richetta --- (In reply to Xwang from comment #36) > And I can confirm that > a) the battery indicator works correctly in the login screen when you the > session is locked > b) restarting plasma with kquitapp5 plasmashell ;

D23306: Add AppStream metadata file

mak added a comment. In D23306#515592 , @ngraham wrote: > In D23306#515589 , @mak wrote: > > > In D23306#515577 , @ngraham wrote: > > > > > Adjust

D23306: Add AppStream metadata file

ngraham added a comment. In D23306#515589 , @mak wrote: > In D23306#515577 , @ngraham wrote: > > > Adjust according to review comments > > > This will work. I would change `System Settings` to

D23306: Add AppStream metadata file

mak added a comment. Adding a `project_group` may also be a nice idea: https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-project_group REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23306 To: ngraham, apol, mak, #plasma Cc:

D23306: Add AppStream metadata file

mak added a comment. In D23306#515585 , @kossebau wrote: > @mak: tnanks for the hint. will also see to use X-AppStream-Ignore for kdevelop then. any chance we can see this trick documented on

D23306: Add AppStream metadata file

mak added a comment. In D23306#515577 , @ngraham wrote: > Adjust according to review comments This will work. I would change `System Settings` to ` KDE System Settings` or `Plasma System Settings`, just like GNOME sets a name like

D23302: Stop installing two desktop files

bcooksley added a comment. The split with two different desktop files was imposed upon us by the GNOME packagers at Ubuntu so eliminating the extra file isn't an option I'm afraid. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23302 To: ngraham, apol,

D23306: Add AppStream metadata file

ngraham updated this revision to Diff 64169. ngraham added a comment. Add `` tag so searching for it from the old URLs still works REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23306?vs=64168=64169 BRANCH add-appdata-file (branched from master)

D23306: Add AppStream metadata file

kossebau added a comment. @mak: tnanks for the hint. will also see to use X-AppStream-Ignore for kdevelop then. any chance we can see this trick documented on https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html , please? :) REPOSITORY R124 System Settings

D23306: Add AppStream metadata file

ngraham added a comment. Thanks for the into @mak, that's very helpful. I've removed one of the launchable tags since only one .desktop file has the info that you would want to use to launch it as a KDE user. And I've added `X-AppStream-Ignore=true` to one of the .desktop files. Does

D23302: Stop installing two desktop files

mak added a comment. @kossebau You'll also want to annotate the .desktop files correctly to hide them. See https://phabricator.kde.org/D23306#515575 for details. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/D23302 To: ngraham, apol, #plasma Cc: mak,

D23306: Add AppStream metadata file

ngraham updated this revision to Diff 64168. ngraham added a comment. Adjust according to review comments REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23306?vs=64161=64168 BRANCH add-appdata-file (branched from master) REVISION DETAIL

D23306: Add AppStream metadata file

mak added a comment. There's also a FAQ entry for this, apparently I only documented this for Debian Developers back in the day ^^ > https://wiki.debian.org/AppStream/Guidelines#How_to_exclude_.desktop_files_from_the_metadata

D23306: Add AppStream metadata file

mak added a comment. @ngraham > Alternative to D23302 . According to the AppStream documentation (https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html), > adding an AppStream metadata file with multiple launchable tags

D23307: [weather] [envcan] Add additional current condition icon mappings

spstarr added a comment. Ideally, this list shouldn't be so long since the XML schema http://dd.weatheroffice.ec.gc.ca/citypage_weather/docs/current_conditions_icon_code_descriptions_e.csv lists them all, except thats not what the XML shows :/ I should ask EC why the discrepancy REPOSITORY

D23307: [weather] [envcan] Add additional current condition icon mappings

ngraham resigned from this revision. ngraham added a comment. Ah ok. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23307 To: spstarr, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D23307: [weather] [envcan] Add additional current condition icon mappings

spstarr added a comment. Thats the XML however, it is matching 'rainshowers' REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23307 To: spstarr, #plasma, ngraham Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen,

D23307: [weather] [envcan] Add additional current condition icon mappings

ngraham edited reviewers, added: Plasma; removed: Plasma: Workspaces. ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Change "rainshowers" to "rain showers" ("rainshower" isn't a word) REPOSITORY R120 Plasma Workspace

D23307: [weather] [envcan] Add additional current condition icon mappings

spstarr added a comment. Current XML shows (until the storm ends) Thunderstorm with heavy rainshowers REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23307 To: spstarr, #plasma_workspaces Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D23307: [weather] [envcan] Add additional current condition icon mappings

spstarr added a comment. Will merge once reviewed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23307 To: spstarr, #plasma_workspaces Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D23307: [weather] [envcan] Add additional current condition icon mappings

spstarr created this revision. spstarr added a reviewer: Plasma: Workspaces. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. spstarr requested review of this revision. REVISION SUMMARY [weather] [envcan] Add additional current condition icon mappings TEST PLAN Built

D23302: Stop installing two desktop files

ngraham added a subscriber: mak. ngraham added a comment. Abandoning in favor of D23306 , which adds an AppStream metadata file with multiple `launchable` tags. If I'm reading the docs right, this should allow the information from the referenced

D23306: Add AppStream metadata file

ngraham created this revision. ngraham added reviewers: apol, mak, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Alternative to D23302 . According to the AppStream

D23305: Add plugin showing nvidia GPU load stats

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY This plugin shows the process GPU load and GPU memory usage for users of

D23288: Move XResources out of the central model into a plugin

davidedmundson updated this revision to Diff 64157. davidedmundson added a comment. update REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23288?vs=64135=64157 REVISION DETAIL https://phabricator.kde.org/D23288 AFFECTED FILES CMakeLists.txt

D23287: Create a plugin framework for processes

davidedmundson updated this revision to Diff 64155. davidedmundson added a comment. update REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=64136=64155 REVISION DETAIL https://phabricator.kde.org/D23287 AFFECTED FILES

D23302: Stop installing two desktop files

ngraham added a comment. Those are excellent questions. Reading through https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html, it seems like .desktop files only get parsed if there's no appdata.xml file--which indeed, System Settings lacks. Maybe that's the

D23302: Stop installing two desktop files

kossebau added a comment. As KDevelop is affected similar, because we want two different entries to appear in the system application menu, can someone tell where appstream defines that there shall be only one menu desltop file per application? Why do those installers even look at the menu

D23302: Stop installing two desktop files

ngraham created this revision. ngraham added reviewers: apol, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY System Settings installs two desktop files, and uses one with "KDE" in the name when run

D23301: [Cuttlefish] Use only a single AppStream ID

This revision was automatically updated to reflect the committed changes. Closed by commit R118:06912303ea4b: [Cuttlefish] Use only a single AppStream ID (authored by ngraham). REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23301?vs=64149=64150 REVISION

D23298: Unify busy spinner appearance on update page

ngraham added a comment. If there's a way to show an actual progress indicator in a way that ensures its accuracy, that would be much better, yeah. I'll be happy to abandon this patch if you can do that (I don't know how, sorry). REPOSITORY R134 Discover Software Store REVISION DETAIL

D23301: [Cuttlefish] Use only a single AppStream ID

ngraham created this revision. ngraham added a reviewer: apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Right now Cuttlefish provides both `org.kde.plasma.cuttlefish` and `org.kde.cuttlefish.desktop`

D23298: Unify busy spinner appearance on update page

apol added a comment. As is, it looks unfinished to me. I prefer to give some kind of hint of what's happening, especially since this could take a while, yesterday I opened one laptop after a month (neon git unstable) or so and it took easily a minute to show anything there. In fact, we

D23271: [Battery Monitor] Call battery capacity "Capacity degradation" for better clarity

This revision was automatically updated to reflect the committed changes. Closed by commit R120:a1654867e784: [Battery Monitor] Call battery capacity Capacity degradation for better… (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D23270: [Energy] Put battery capacity info in battery section and call it "Capacity degradation"

This revision was automatically updated to reflect the committed changes. Closed by commit R102:c7984fa8548c: [Energy] Put battery capacity info in battery section and call it Capacity… (authored by ngraham). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D23271: [Battery Monitor] Call battery capacity "degradation" for better clarity

ngraham updated this revision to Diff 64142. ngraham added a comment. Use the superior agreed-upon string "Capacity degradation" REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23271?vs=64123=64142 BRANCH capacity-to-degradation (branched from

D23298: Unify busy spinner appearance on update page

ngraham added a comment. All it used to say was "Fetching updates..." which I think is adequately implied by it being a busy spinner on the Updates page. The spinner on the main page doesn't say, "Fetching applications" or whatever, so I was trying to be consistent with that. Your call

D23298: Unify busy spinner appearance on update page

apol added a comment. We don't want any text? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D23298 To: ngraham, #discover_software_store, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

ngraham updated this revision to Diff 64141. ngraham added a comment. Rename to "Capacity degradation" for extra clarity, and move to the end of the Battery section REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23270?vs=64062=64141 BRANCH

D23298: Unify busy spinner appearance on update page

ngraham created this revision. ngraham added reviewers: Discover Software Store, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The busy spinner on the main page is in the center of the view. Let's do

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

aspotashev added a comment. In D23270#515349 , @ngraham wrote: > "Capacity degradation" is perfectly clear IMO. You may be right, my opinion is biased. REPOSITORY R102 KInfoCenter BRANCH capacity-to-degradation (branched from

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

ngraham added a comment. In D23270#515348 , @aspotashev wrote: > I think you missed my point, the regular "what's this" tool is indeed poorly discoverable. Consider this type of "tooltip" for the KCM: > F7264910:

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

aspotashev added a comment. In D23270#515331 , @ngraham wrote: > Hmm, both suggestions seem to be designed to explain what "capacity" means rather than replacing it with something that doesn't need explanation at all. I don't really see the

D23292: Make update page labels consistent with topUpdateComp

ngraham added a comment. Figured it out from your email address. :) Do please update your `.gitconfig` file for future patches though! REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D23292 To: MrPepe, #discover_software_store, ngraham Cc: apol,

D23292: Make update page labels consistent with topUpdateComp

This revision was automatically updated to reflect the committed changes. Closed by commit R134:7a2dc6941478: Make update page labels consistent with topUpdateComp (authored by MrPepe, committed by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

ngraham added a comment. If keeping the word "capacity" is a sticking point, I'd like to go with @meven's suggestion of "Capacity degredation". Would that be acceptable? REPOSITORY R102 KInfoCenter BRANCH capacity-to-degradation (branched from master) REVISION DETAIL

D23287: Create a plugin framework for processes

davidedmundson updated this revision to Diff 64136. davidedmundson added a comment. update REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=64100=64136 BRANCH master REVISION DETAIL https://phabricator.kde.org/D23287 AFFECTED FILES

D23287: Create a plugin framework for processes

davidedmundson marked 7 inline comments as done. davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in extended_process_list.cpp:62 > Add `reserve` call I can't add a meaningful one. p->attributes() is itself another vector of size 0 to N. > broulik wrote in

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

ngraham added a comment. In D23270#515330 , @aspotashev wrote: > In D23270#515293 , @ngraham wrote: > > > At least, that's how it was for me. I did not understand what "Capacity:" was referring to

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

aspotashev added a comment. In D23270#515293 , @ngraham wrote: > At least, that's how it was for me. I did not understand what "Capacity:" was referring to until I started browsing the code. "Capacity" is an ambiguous and non-descriptive term

D23288: Move XResources out of the central model into a plugin

davidedmundson updated this revision to Diff 64135. davidedmundson marked an inline comment as done. davidedmundson added a comment. update REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23288?vs=64125=64135 BRANCH plugins REVISION DETAIL

D23288: Move XResources out of the central model into a plugin

davidedmundson marked 4 inline comments as done. davidedmundson added inline comments. INLINE COMMENTS > apol wrote in xres.h:1 > Copyright? > > First time I see `#pragma once` in KDE software. I've used #pragma once all over the place already, hasn't seemed to cause an issue. REPOSITORY

D23152: [energy kcm] Display Vendor and model

ngraham added a comment. If the serial number is a property of the battery, then yes, it belongs in the Battery section IMO. REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D23152 To: meven, broulik, ngraham Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev,

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

ngraham added a comment. In D23270#515102 , @aspotashev wrote: > I don't like this change because it introduces a Plasma-specific formula and makes the user guess how to match "degradation: 21%" against let's say "capacity: 85%" s/he saw when

D23292: Make update page labels consistent with topUpdateComp

ngraham added a comment. @MrPepe I cannot land this patch because our commit hookscript requires a last name in addition to a first name. Can you tell me your last name and adjust your `.gitconfig` file to include that in future patches? Thanks! REPOSITORY R134 Discover Software

D23288: Move XResources out of the central model into a plugin

apol added inline comments. INLINE COMMENTS > xres.cpp:1 > +#include "xres.h" > + What's the copyright? > xres.cpp:6 > +#include > +#include > + Scope shouldn't be necessary > xres.h:1 > +#pragma once > + Copyright? First time I see `#pragma once` in KDE software. > ProcessModel.h:157 >

D23292: Make update page labels consistent with topUpdateComp

apol added a comment. Thanks. The problem with the knsbackendtest is most likely unrelated. You can ignore it here. Do you have permissions to land the patch? REPOSITORY R134 Discover Software Store BRANCH consistentLabels REVISION DETAIL https://phabricator.kde.org/D23292 To:

D23296: Simplify rendering of raised toolbuttons with menu

hpereiradacosta created this revision. hpereiradacosta added reviewers: Breeze, ndavis. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. hpereiradacosta requested review of this revision. REVISION SUMMARY Following on https://phabricator.kde.org/D23169, it turns out one

D23294: [Notifications] Bring back dismissed progress in case of crash

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY When the application crashes, we would mark the job as failed but not undismiss it. TEST PLAN

D23293: [Notifications] Implement JobViewV2

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This implements a new `JobViewV2` which uses extensible variant maps rather than individual

D22087: Build without foreach

nicolasfella updated this revision to Diff 64127. nicolasfella added a comment. - Comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22087?vs=60630=64127 BRANCH arcpatch-D22087 REVISION DETAIL https://phabricator.kde.org/D22087

D22087: Build without foreach

nicolasfella marked 5 inline comments as done. nicolasfella added inline comments. INLINE COMMENTS > apol wrote in dbusmenushortcut_p.cpp:60 > const &, also this should possibly be transformed into a splitRef. Doesn't work trivially because of the token.replace() below > apol wrote in

D23271: [Battery Monitor] Call battery capacity "degradation" for better clarity

aspotashev added a comment. I disagree with this change, see https://phabricator.kde.org/D23270#515102 REPOSITORY R120 Plasma Workspace BRANCH capacity-to-degradation (branched from master) REVISION DETAIL https://phabricator.kde.org/D23271 To: ngraham, #vdg, broulik, #plasma, filipf

D23288: Move XResources out of the central model into a plugin

davidedmundson updated this revision to Diff 64125. davidedmundson added a comment. Rebase diff REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23288?vs=64098=64125 REVISION DETAIL https://phabricator.kde.org/D23288 AFFECTED FILES

D23292: Make update page labels consistent with topUpdateComp

MrPepe added a comment. This was my first contribution so I was following the wiki guide. Running ctest showed that knsbackendtest fails. Is that a setup problem on my side or something that actually does not work? REPOSITORY R134 Discover Software Store BRANCH consistentLabels

D23287: Create a plugin framework for processes

broulik added inline comments. INLINE COMMENTS > extended_process_list.cpp:62 > +{ > +QVector rc; > +for (auto p: qAsConst(d->m_providers)) { Add `reserve` call > extended_process_list.cpp:76 > +if (!factory) { > +return; > +} Shouldn't this be a

D23292: Make update page labels consistent with topUpdateComp

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. How serindipitous; I was just about to do this myself! Needless to say, LGTM. REPOSITORY R134 Discover Software Store BRANCH consistentLabels REVISION DETAIL

D23292: Make update page labels consistent with topUpdateComp

MrPepe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. MrPepe requested review of this revision. REVISION SUMMARY Made the labels on the update page consistent with the ones shown in the topUpdateComp of the main window TEST PLAN Check for

D23126: Add browser action for status reporting

ognarb added a reviewer: ognarb. ognarb added a comment. I will provide more feedback tomorrow, when I have more time. INLINE COMMENTS > action_popup.css:32 > + > +main { > + Why it is empty? > action_popup.css:45 > +} > +.message.error { > + same REPOSITORY R856 Plasma Browser

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

ngraham added a comment. In D23270#514911 , @meven wrote: > > To further reduce the confusion, the battery's degradation lavel is relocated to the Battery section. > > I don't think that is necessary. > What is confusing in a degradation

D23271: [Battery Monitor] Call battery capacity "degradation" for better clarity

ngraham updated this revision to Diff 64123. ngraham marked an inline comment as done. ngraham added a comment. Add context REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23271?vs=64063=64123 BRANCH capacity-to-degradation (branched from

D23283: When asked to switch sessions, skip to session creation if there's nothing to switch to

ngraham added a comment. In D23283#514927 , @broulik wrote: > Screenshots please Done; added screenshots and videos to the Test Plan section. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D23283 To:

D23284: Add keyboard control for ProceedDialog buttons

This revision was automatically updated to reflect the committed changes. Closed by commit R134:44c8b0fe8d7a: Add keyboard control for ProceedDialog buttons (authored by ngraham). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D23270: [Energy] Put battery capacity info in battery section and call it "degradation"

aspotashev added a comment. I don't like this change because it introduces a Plasma-specific formula and makes the user guess how to match "degradation: 21%" against let's say "capacity: 85%" s/he saw when using a different OS or desktop environment. For example: 1. User looks at

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 --- Comment #36 from Xwang --- (In reply to Xwang from comment #35) > Today I got th same iisue upgrading plasma from 5.60.0-1 to 5.61.0-1 as > described here > https://bbs.archlinux.org/viewtopic.php?id=248579 And I can confirm that a) the battery

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

https://bugs.kde.org/show_bug.cgi?id=350365 Xwang changed: What|Removed |Added CC||xwaang1...@gmail.com --- Comment #35 from Xwang ---

D23287: Create a plugin framework for processes

davidedmundson updated this revision to Diff 64100. davidedmundson added a comment. Update REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23287?vs=64097=64100 REVISION DETAIL https://phabricator.kde.org/D23287 AFFECTED FILES

D23285: Prevent dragging QQC2 ComboBox contents outside menu

This revision was automatically updated to reflect the committed changes. Closed by commit R858:ec1b5c60c19f: Prevent dragging QQC2 ComboBox contents outside menu (authored by GB_2). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D23288: Move XResources out of the central model into a plugin

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY XRes works in an odd way, the evaluation is inside the processui model,

  1   2   >