D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon

[Nathaniel Graham]

ngraham updated this revision to Diff 64382.
ngraham added a comment.


  Don't use width: and height: on items in a Layout

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23368?vs=64380=64382

BRANCH
  port-away-from-WorkspaceComponents.BatteryIcon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23368

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: ngraham, #plasma, broulik, meven
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23368: [Energy KCM] Port away from WorkspaceComponents.BatteryIcon

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, broulik, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Using this Plasma component in an app causes the icons to disappear when 
using a dark
  Plasma theme and a light color scheme, or vice versa. This patch fixes that 
by porting
  away from the Plasma component and instead using a Kirigami icon to show the 
icons.
  
  BUG: 411051
  FIXED-IN: 5.17.0

TEST PLAN
  Can't test, don't have any battery devices that show up. Please test if you 
do!

REPOSITORY
  R102 KInfoCenter

BRANCH
  port-away-from-WorkspaceComponents.BatteryIcon (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23368

AFFECTED FILES
  Modules/energy/package/contents/ui/main.qml

To: ngraham, #plasma, broulik, meven
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 332 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/332/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 13 Aug 2019 14:54:07 +
 Build duration:
31 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/LibColorCorrect-5.16.80.xmlacc/LibKWorkspace-5.16.80.xmlacc/LibNotificationManager-5.16.80.xmlacc/LibTaskManager-5.16.80.xmlcompat_reports/LibColorCorrect_compat_report.htmlcompat_reports/LibKWorkspace_compat_report.htmlcompat_reports/LibNotificationManager_compat_report.htmlcompat_reports/LibTaskManager_compat_report.htmllogs/LibColorCorrect/5.16.80/log.txtlogs/LibKWorkspace/5.16.80/log.txtlogs/LibNotificationManager/5.16.80/log.txtlogs/LibTaskManager/5.16.80/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kioslave.desktop Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report16%
(20/122)12%
(51/420)12%
(51/420)7%
(2565/37736)5%
(1264/25902)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.appmenu.lib0%
(0/2)0%
(0/2)0%
(0/128)0%
(0/84)applets.appmenu.plugin0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/150)applets.calendar0%
(0/1)0%
(0/1)0%
(0/6)100%
(0/0)applets.digital-clock.plugin0%
(0/5)0%
(0/5)0%
(0/948)0%
(0/92)applets.icon0%
(0/1)0%
(0/1)0%
(0/279)0%
(0/186)applets.notifications0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/78)applets.systemtray0%
(0/1)0%
(0/1)0%
(0/278)0%
(0/223)applets.systemtray.container0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/52)applets.systemtray.tests.statusnotifier0%
(0/3)0%
(0/3)0%
(0/182)0%
(0/40)appmenu0%
(0/7)0%
(0/7)0%
(0/170)0%
(0/66)components.containmentlayoutmanager0%
(0/10)0%
(0/10)0%
(0/1363)0%
(0/910)components.keyboardlayout0%
(0/2)0%
(0/2)0%
(0/75)0%

Re: Unified git commit message guideline

[Marc Deop i Argemí]

On Sunday, 11 August 2019 23:52:55 CEST Roman Gilg wrote:
> After looking around a bit what I found to be very interesting was the
> Conventional Commits specification[1]. It is based on the AngularJS
> commit message policy, which is imo a very well formulated policy.

Please make sure to consider Git Karma [1]

[1] http://karma-runner.github.io/4.0/dev/git-commit-msg.html

-- 
Marc Deop i Argemí
System Engineer

signature.asc
Description: This is a digitally signed message part.

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 285 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/285/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 13 Aug 2019 11:24:47 +
 Build duration:
1 hr 7 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)Name: projectroot.autotests Failed: 16 test(s), Passed: 94 test(s), Skipped: 0 test(s), Total: 110 test(s)Failed: projectroot.autotests.integration.kwin_testDebugConsoleFailed: projectroot.autotests.integration.kwin_testDecorationInputFailed: projectroot.autotests.integration.kwin_testDontCrashCursorPhysicalSizeEmptyFailed: projectroot.autotests.integration.kwin_testDontCrashUseractionsMenuFailed: projectroot.autotests.integration.kwin_testDontCrashUseractionsMenu_waylandonlyFailed: projectroot.autotests.integration.kwin_testGlobalShortcutsFailed: projectroot.autotests.integration.kwin_testInputStackingOrderFailed: projectroot.autotests.integration.kwin_testInternalWindowFailed: projectroot.autotests.integration.kwin_testMoveResizeFailed: projectroot.autotests.integration.kwin_testPlacementFailed: projectroot.autotests.integration.kwin_testPlasmaWindowFailed: projectroot.autotests.integration.kwin_testShellClientRulesFailed: projectroot.autotests.integration.kwin_testShellClientRules_waylandonlyFailed: projectroot.autotests.integration.kwin_testStrutsFailed: projectroot.autotests.integration.kwin_testTouchInputFailed: projectroot.autotests.integration.kwin_testTransientPlacementName: projectroot.autotests.integration Failed: 1 test(s), Passed: 17 test(s), Skipped: 0 test(s), Total: 18 test(s)Failed: projectroot.autotests.integration.effects.kwin_testPopupOpenCloseAnimation
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report70%
(59/84)57%
(321/563)57%
(321/563)41%
(30109/74153)30%
(13708/45268)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault86%
(132/154)86%
(132/154)61%
(18364/30043)46%
(9415/20425)colorcorrection100%
(4/4)100%
(4/4)80%
(455/568)59%
(201/343)data0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/8)decorations100%
(10/10)100%
(10/10)81%
(451/555)66%
(141/214)effects100%
(2/2)100%
(2/2)99%
(156/158)86%
(24/28)effects.backgroundcontrast25%
(1/4)25%
(1/4)4%
(14/379)4%
(12/292)effects.blur20%
(1/5)20%
(1/5)2%
(14/693)3%
(13/405)effects.colorpicker100%
(2/2)100%
(2/2)19%
(12/62)8%
(2/24)effects.coverswitch33%
(1/3)33%
(1/3)0%
(2/657)1%
(4/530)effects.cube25%
(1/4)25%
(1/4)0%
(2/1291)0%
(0/1015)effects.cubeslide67%
(2/3)67%
(2/3)33%
(158/480)19%
(72/374)effects.desktopgrid67%
(2/3)67%
(2/3)8%
   

KDE CI: Plasma » plasma-workspace » kf5-qt5 SUSEQt5.12 - Build # 344 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace/job/kf5-qt5%20SUSEQt5.12/344/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 20 Aug 2019 17:46:29 +
 Build duration:
14 min and counting
   BUILD ARTIFACTS
  abi-compatibility-results.yamlacc/LibColorCorrect-5.16.80.xmlacc/LibKWorkspace-5.16.80.xmlacc/LibNotificationManager-5.16.80.xmlacc/LibTaskManager-5.16.80.xmlcompat_reports/LibColorCorrect_compat_report.htmlcompat_reports/LibKWorkspace_compat_report.htmlcompat_reports/LibNotificationManager_compat_report.htmlcompat_reports/LibTaskManager_compat_report.htmllogs/LibColorCorrect/5.16.80/log.txtlogs/LibKWorkspace/5.16.80/log.txtlogs/LibNotificationManager/5.16.80/log.txtlogs/LibTaskManager/5.16.80/log.txt
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.kioslave.desktop Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.klipper Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.libcolorcorrect Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libkworkspace Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.libtaskmanager Failed: 0 test(s), Passed: 2 test(s), Skipped: 0 test(s), Total: 2 test(s)Name: projectroot.runners.bookmarks Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.runners.services Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot.shell Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report16%
(20/122)12%
(51/420)12%
(51/420)7%
(2565/37735)5%
(1266/25902)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapplets.appmenu.lib0%
(0/2)0%
(0/2)0%
(0/128)0%
(0/84)applets.appmenu.plugin0%
(0/3)0%
(0/3)0%
(0/188)0%
(0/150)applets.calendar0%
(0/1)0%
(0/1)0%
(0/6)100%
(0/0)applets.digital-clock.plugin0%
(0/5)0%
(0/5)0%
(0/948)0%
(0/92)applets.icon0%
(0/1)0%
(0/1)0%
(0/279)0%
(0/186)applets.notifications0%
(0/6)0%
(0/6)0%
(0/182)0%
(0/78)applets.systemtray0%
(0/1)0%
(0/1)0%
(0/278)0%
(0/223)applets.systemtray.container0%
(0/1)0%
(0/1)0%
(0/60)0%
(0/52)applets.systemtray.tests.statusnotifier0%
(0/3)0%
(0/3)0%
(0/182)0%
(0/40)appmenu0%
(0/7)0%
(0/7)0%
(0/170)0%
(0/66)components.containmentlayoutmanager0%
(0/10)0%
(0/10)0%
(0/1363)0%
(0/910)components.keyboardlayout0%
(0/2)0%
(0/2)0%
(0/75)0%

D23298: Unify busy spinner appearance on update page

[Nathaniel Graham]

ngraham abandoned this revision.
ngraham added a comment.


  Abandoning in favor of the vastly superior D23357 
.

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D23298

To: ngraham, #discover_software_store, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23357: Show update issues on a popup instead of as passive messages

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:3c605c3f9c5d: Show update issues on a popup instead of as 
passive messages (authored by apol).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D23357?vs=64336=64363#toc

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23357?vs=64336=64363

REVISION DETAIL
  https://phabricator.kde.org/D23357

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: apol, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23228: Port away from deprecated KWindowSystem API

[David Faure]

dfaure added a comment.


  Thanks for the testing!

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D23228

To: dfaure, zzag, graesslin, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23228: Port away from deprecated KWindowSystem API

[David Faure]

dfaure closed this revision.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D23228

To: dfaure, zzag, graesslin, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23228: Port away from deprecated KWindowSystem API

[Vlad Zagorodniy]

zzag added a comment.


  Thank you for doing God's work. ;-)

REPOSITORY
  R133 KScreenLocker

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D23228

To: dfaure, zzag, graesslin, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23228: Port away from deprecated KWindowSystem API

[Vlad Zagorodniy]

zzag accepted this revision.
zzag added a comment.
This revision is now accepted and ready to land.


  > Builds, didn't test yet.
  
  Whitelisted shortcuts still work.

REPOSITORY
  R133 KScreenLocker

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D23228

To: dfaure, zzag, graesslin, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D21860: Set a font for gtk applications in the fonts kcm

[Mikhail Zolotukhin]

gikari added a comment.


  Since awesome @nicolasfella committed his changes to Gtk Daemon, I have 
modified the interface according to it. No more wacky xml stuff, because the 
daemon became a kded module with the adequate dbus signatures. 

  
  Now I'm interested where to put already written daemon: to //plasma-desktop// 
or make it part of //kde-gtk-config// (aka Gtk KCM). If the first, should I 
create a separate patch or make it as a part of this one?
  
  P.S. I'm terribly inconsiderate at merge conflicts. Sorry for that wall of 
changes from above.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D21860

To: gikari, #plasma, apol, davidedmundson
Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21860: Set a font for gtk applications in the fonts kcm

[Mikhail Zolotukhin]

gikari updated this revision to Diff 64342.
gikari added a comment.


  - Remove QStandardPaths as redundant include

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21860?vs=64339=64342

BRANCH
  set-gtk-font-in-fonts-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21860

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

To: gikari, #plasma, apol, davidedmundson
Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21860: Set a font for gtk applications in the fonts kcm

[Mikhail Zolotukhin]

gikari updated this revision to Diff 64339.
gikari marked 2 inline comments as done.
gikari added a comment.


  - Remove redundant includes

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21860?vs=64331=64339

BRANCH
  set-gtk-font-in-fonts-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21860

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

To: gikari, #plasma, apol, davidedmundson
Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D23357: Show update issues on a popup instead of as passive messages

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  So much better!

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23357

To: apol, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23357: Show update issues on a popup instead of as passive messages

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Otherwise they may disappear.
  
  BUG: 411182

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23357

AFFECTED FILES
  discover/qml/UpdatesPage.qml

To: apol, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22514: Show if KRunner is still searching for more things

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> apol wrote in RunCommand.qml:86
> Since it's using QQC2.TextField, won't it be using a completely different 
> colour scheme?

There was some code to make that magically work.

(maybe it was that URLInterceptor we removed?)

If it doesn't work, then just ignore me.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22514

To: apol
Cc: davidedmundson, ngraham, aspotashev, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D21860: Set a font for gtk applications in the fonts kcm

[Mikhail Zolotukhin]

gikari updated this revision to Diff 64331.
gikari added a comment.


  - Remove redundant saveFontToGtkSettings method declaration

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21860?vs=64330=64331

BRANCH
  set-gtk-font-in-fonts-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21860

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

To: gikari, #plasma, apol, davidedmundson
Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21860: Set a font for gtk applications in the fonts kcm

[Mikhail Zolotukhin]

gikari updated this revision to Diff 64330.
gikari marked an inline comment as done.
gikari added a comment.


  - Remove redundant xml stuff

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21860?vs=64329=64330

BRANCH
  set-gtk-font-in-fonts-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21860

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

To: gikari, #plasma, apol, davidedmundson
Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D21860: Set a font for gtk applications in the fonts kcm

[Mikhail Zolotukhin]

gikari updated this revision to Diff 64329.
gikari added a comment.


  - Delegate gtk fonts configuration to Gtk Daemon

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21860?vs=64002=64329

BRANCH
  set-gtk-font-in-fonts-kcm (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D21860

AFFECTED FILES
  kcms/fonts/CMakeLists.txt
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

To: gikari, #plasma, apol, davidedmundson
Cc: davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D23356: Add ksysguard plugin for taskmanager integration

[Eike Hein]

hein added a comment.


  Do you really need a TasksModel, or is a WindowTasksModel enough?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D23356

To: davidedmundson, #plasma
Cc: hein, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23356: Add ksysguard plugin for taskmanager integration

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> taskmanager.cpp:23
> +
> +#include 
> +#include 

Unused

> taskmanager.cpp:58
> +const QModelIndex index = m_model->index(i, 0, QModelIndex());
> +if 
> (!index.data(TaskManager::AbstractTasksModel::IsWindow).toBool()) {
> +continue;

`attachPidToTMIndex` already checks for `IsWindow` unless you want to save a 
pointless `AppPid` call

> taskmanager.cpp:72
> +if (m_model->rowCount() > 0) {
> +updateRows(0, m_model->rowCount());
> +}

`rowCount() - 1` because you go `i <= last`

> taskmanager.cpp:77
> +connect(m_model, ::dataChanged, this, 
> [updateRows](const QModelIndex , const QModelIndex , 
> const QVector  ) {
> +if (roles.contains(Qt::DisplayRole)) {
> +updateRows(topLeft.row(), bottomRight.row());

Roles can potentially be empty indicating all roles are dirty?
Also, what about `DecorationRole`, in case it's window pixmap.

> taskmanager.cpp:83
> +if (m_model->rowCount() > 0) {
> +updateRows(0, m_model->rowCount());
> +}

`rowCount() - 1`

> taskmanager.cpp:99
> +m_titleAttribute->setData(process, index.data(Qt::DisplayRole));
> +m_iconNameAttribute->setData(process, index.data(Qt::DecorationRole));
> +}

This role is a `QIcon`, potentially created from the window pixmap in case 
window mapping failed.
Or is that what the "tiny mods in ProcessModel" is about?

> taskmanager.h:24
> +#include 
> +#include 
> +

Unused, forward-declare

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D23356

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23356: Add ksysguard plugin for taskmanager integration

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Currently this is all hardcoded in ProcessModel. By moving it into a
  plugin we can make that model half the size.
  
  Code is ported to use libTM instead of KWindowSystem for a few reasons:
  
- It works on wayland (assuming we have the extra permissions set)
- We get to make use of the more complex advanced mapping in libTM
  - It has fixed code to get the right PID for a window so apps in a PID
  
  namespace have the icon in the right place (currently broken in
  ksysguard)
  
  Requires some tiny mods in ProcessModel to map the decoration role.
  
  Introduces a p-w dependency in ksysguard, but not the lib so there's no
  lib.

TEST PLAN
  Opened ksysguard, data matched the old ksysguard, except for my flatpak
  app which now had the icon on the correct process not some random kernel 
  process

REPOSITORY
  R106 KSysguard

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23356

AFFECTED FILES
  plugins/CMakeLists.txt
  plugins/process/taskmanager/CMakeLists.txt
  plugins/process/taskmanager/taskmanager.cpp
  plugins/process/taskmanager/taskmanager.h
  plugins/process/taskmanager/taskmanager.json

To: davidedmundson, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23350: Chaning default iconSize in systemtray

[Nathaniel Graham]

ngraham added a comment.


  In D23350#516835 , @anthonyfieroni 
wrote:
  
  > In D23350#516765 , @ngraham 
wrote:
  >
  > > So this is a complaint that comes up a lot. I do see what you mean, and 
in my opinion, what we need is a dual-mode size control UI that lets you switch 
between "scale icons to fit in panel", "static icon size", and "n columns".
  >
  >
  > That was i think dated, also i'm pretty sure it has a review that doing it, 
but it makes things complicated and was reviled.
  
  
  If you can find the patch, maybe we should take another look. This problem 
isn't going away on its own.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23350

To: xshram, ngraham
Cc: anthonyfieroni, alexeymin, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23151: Implement Web Share API through Purpose

[Kai Uwe Broulik]

broulik planned changes to this revision.
broulik added a comment.


  It should only add the `navigator.share` stuff if the host side is supported 
and loaded, in case you run old host with new extension.
  The setting will be correctly hidden but since it is enabled by default it 
will still add the then defunct JS bits.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23151

To: broulik, #plasma, fvogt, davidedmundson, nicolasfella, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma » plasma-nm » kf5-qt5 SUSEQt5.12 - Build # 104 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-nm/job/kf5-qt5%20SUSEQt5.12/104/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 22 Aug 2019 16:29:32 +
 Build duration:
4 min 26 sec and counting
   CONSOLE OUTPUT
  [...truncated 652 lines...][2019-08-22T16:33:20.870Z] [ 56%] Generating ui_pinwidget.h[2019-08-22T16:33:20.870Z] [ 57%] Generating ui_kcm.h[2019-08-22T16:33:20.870Z] [ 58%] Generating ui_fortisslvpnauth.h[2019-08-22T16:33:20.870Z] [ 59%] Generating ui_fortisslvpn.h[2019-08-22T16:33:20.870Z] [ 59%] Generating ui_fortisslvpnadvanced.h[2019-08-22T16:33:20.870Z] Scanning dependencies of target plasmanm_qmlplugins[2019-08-22T16:33:20.870Z] [ 59%] Built target plasmanetworkmanagement_strongswanui_autogen[2019-08-22T16:33:20.870Z] [ 59%] Generating ui_iodineauth.h[2019-08-22T16:33:20.870Z] Scanning dependencies of target kcm_networkmanagement[2019-08-22T16:33:21.368Z] [ 59%] Building CXX object libs/declarative/CMakeFiles/plasmanm_qmlplugins.dir/plasmanm_qmlplugins_autogen/mocs_compilation.cpp.o[2019-08-22T16:33:21.368Z] [ 59%] Building CXX object kcm/CMakeFiles/kcm_networkmanagement.dir/kcm_networkmanagement_autogen/mocs_compilation.cpp.o[2019-08-22T16:33:21.368Z] [ 59%] Generating ui_iodine.h[2019-08-22T16:33:21.368Z] Scanning dependencies of target kded_networkmanagement[2019-08-22T16:33:21.368Z] Scanning dependencies of target plasmanetworkmanagement_fortisslvpnui[2019-08-22T16:33:21.368Z] [ 59%] Building CXX object kded/CMakeFiles/kded_networkmanagement.dir/kded_networkmanagement_autogen/mocs_compilation.cpp.o[2019-08-22T16:33:21.368Z] [ 59%] Building CXX object vpn/fortisslvpn/CMakeFiles/plasmanetworkmanagement_fortisslvpnui.dir/plasmanetworkmanagement_fortisslvpnui_autogen/mocs_compilation.cpp.o[2019-08-22T16:33:21.368Z] Scanning dependencies of target plasmanetworkmanagement_iodineui[2019-08-22T16:33:21.368Z] [ 60%] Building CXX object vpn/iodine/CMakeFiles/plasmanetworkmanagement_iodineui.dir/plasmanetworkmanagement_iodineui_autogen/mocs_compilation.cpp.o[2019-08-22T16:33:21.868Z] [ 60%] Built target plasmanetworkmanagement_vpncui_autogen[2019-08-22T16:33:21.868Z] [ 61%] Building CXX object kded/CMakeFiles/kded_networkmanagement.dir/__/libs/debug.cpp.o[2019-08-22T16:33:24.212Z] [ 61%] Generating ui_l2t.h[2019-08-22T16:33:24.212Z] [ 62%] Generating ui_l2tp.h[2019-08-22T16:33:24.212Z] [ 62%] Generating ui_l2tpadvanced.h[2019-08-22T16:33:24.212Z] [ 63%] Generating ui_l2tpauth.h[2019-08-22T16:33:24.212Z] [ 63%] Building CXX object vpn/fortisslvpn/CMakeFiles/plasmanetworkmanagement_fortisslvpnui.dir/fortisslvpn.cpp.o[2019-08-22T16:33:24.212Z] Scanning dependencies of target plasmanetworkmanagement_l2tpui[2019-08-22T16:33:24.212Z] [ 63%] Building CXX object vpn/l2tp/CMakeFiles/plasmanetworkmanagement_l2tpui.dir/plasmanetworkmanagement_l2tpui_autogen/mocs_compilation.cpp.o[2019-08-22T16:33:24.711Z] [ 63%] Building CXX object vpn/iodine/CMakeFiles/plasmanetworkmanagement_iodineui.dir/iodine.cpp.o[2019-08-22T16:33:26.374Z] [ 64%] Building CXX object vpn/l2tp/CMakeFiles/plasmanetworkmanagement_l2tpui.dir/l2tp.cpp.o[2019-08-22T16:33:26.374Z] [ 65%] Building CXX object libs/declarative/CMakeFiles/plasmanm_qmlplugins.dir/availabledevices.cpp.o[2019-08-22T16:33:27.428Z] [ 66%] Building CXX object vpn/fortisslvpn/CMakeFiles/plasmanetworkmanagement_fortisslvpnui.dir/fortisslvpnwidget.cpp.o[2019-08-22T16:33:27.428Z] [ 66%] Building CXX object kded/CMakeFiles/kded_networkmanagement.dir/bluetoothmonitor.cpp.o[2019-08-22T16:33:27.428Z] [ 67%] Building CXX object kcm/CMakeFiles/kcm_networkmanagement.dir/__/libs/debug.cpp.o[2019-08-22T16:33:27.929Z] [ 68%] Building CXX object vpn/iodine/CMakeFiles/plasmanetworkmanagement_iodineui.dir/iodinewidget.cpp.o[2019-08-22T16:33:28.979Z] [ 68%] Building CXX object vpn/l2tp/CMakeFiles/plasmanetworkmanagement_l2tpui.dir/l2tpwidget.cpp.o[2019-08-22T16:33:28.979Z] [ 68%] Building CXX object kcm/CMakeFiles/kcm_networkmanagement.dir/kcm.cpp.o[2019-08-22T16:33:28.979Z] [ 68%] Building CXX object libs/declarative/CMakeFiles/plasmanm_qmlplugins.dir/connectionicon.cpp.o[2019-08-22T16:33:31.325Z] [ 68%] Building CXX object vpn/iodine/CMakeFiles/plasmanetworkmanagement_iodineui.dir/iodineauth.cpp.o[2019-08-22T16:33:31.325Z] [ 68%] Building CXX object vpn/fortisslvpn/CMakeFiles/plasmanetworkmanagement_fortisslvpnui.dir/fortisslvpnauth.cpp.o[2019-08-22T16:33:32.986Z] [ 69%] Building CXX object vpn/l2tp/CMakeFiles/plasmanetworkmanagement_l2tpui.dir/l2tpauth.cpp.o[2019-08-22T16:33:34.646Z] [ 69%] Building CXX object kded/CMakeFiles/kded_networkmanagement.dir/notification.cpp.o[2019-08-22T16:33:35.146Z] [ 69%] Linking CXX shared library ../../bin/libplasmanetworkmanagement_iodineui.so[2019-08-22T16:33:35.146Z] [ 70%] Linking CXX shared library ../../bin/libplasmanetworkmanagement_fortisslvpnui.so[2019-08-22T16:33:35.651Z] [ 70%] Built target plasmanetworkmanagement_iodineui[2019-08-22T16:33:35.651Z] [ 70%] Generating 

D23350: Chaning default iconSize in systemtray

[Anthony Fieroni]

anthonyfieroni added a comment.


  In D23350#516765 , @ngraham wrote:
  
  > So this is a complaint that comes up a lot. I do see what you mean, and in 
my opinion, what we need is a dual-mode size control UI that lets you switch 
between "scale icons to fit in panel", "static icon size", and "n columns".
  
  
  That was i think dated, also i'm pretty sure it has a review that doing it, 
but it makes things complicated and was reviled.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23350

To: xshram, ngraham
Cc: anthonyfieroni, alexeymin, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma » plasma-nm » stable-kf5-qt5 SUSEQt5.12 - Build # 51 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-nm/job/stable-kf5-qt5%20SUSEQt5.12/51/
 Project:
stable-kf5-qt5 SUSEQt5.12
 Date of build:
Thu, 22 Aug 2019 16:28:47 +
 Build duration:
1 min 0 sec and counting
   CONSOLE OUTPUT
  [...truncated 370 lines...][2019-08-22T16:29:41.040Z]Required for autotests[2019-08-22T16:29:41.040Z]  * Qt5[2019-08-22T16:29:41.040Z] [2019-08-22T16:29:41.040Z] -- The following OPTIONAL packages have not been found:[2019-08-22T16:29:41.040Z] [2019-08-22T16:29:41.040Z]  * MobileBroadbandProviderInfo, Database of mobile broadband service providers, [2019-08-22T16:29:41.040Z]  * OpenConnect (required version >= 3.99)[2019-08-22T16:29:41.040Z] [2019-08-22T16:29:41.040Z] -- Configuring done[2019-08-22T16:29:41.040Z] -- Generating done[2019-08-22T16:29:41.040Z] -- Build files have been written to: /home/jenkins/workspace/Plasma/plasma-nm/stable-kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-08-22T16:29:42.505Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project plasma-nm --branchGroup stable-kf5-qt5 --platform SUSEQt5.12 --usingInstall /home/jenkins//install-prefix/[2019-08-22T16:29:42.505Z] Scanning dependencies of target org.kde.plasma.networkmanagement-plasmoids-metadata-json[2019-08-22T16:29:42.505Z] Scanning dependencies of target plasmanm_editor_autogen[2019-08-22T16:29:42.505Z] [  1%] Generating org.kde.plasma.networkmanagement-plasmoids-metadata.json[2019-08-22T16:29:42.505Z] [  1%] Automatic MOC for target plasmanm_editor[2019-08-22T16:29:42.505Z] About to parse service type file "/home/jenkins/install-prefix/share/kservicetypes5/plasma-applet.desktop"[2019-08-22T16:29:42.505Z] Found property definition "X-Plasma-API" with type "QString"[2019-08-22T16:29:42.505Z] Found property definition "X-Plasma-RootPath" with type "QString"[2019-08-22T16:29:42.505Z] Found property definition "X-Plasma-MainScript" with type "QString"[2019-08-22T16:29:42.505Z] Found property definition "X-Plasma-ContainmentType" with type "QString"[2019-08-22T16:29:42.505Z] Found property definition "X-Plasma-DropMimeTypes" with type "QStringList"[2019-08-22T16:29:42.505Z] Found property definition "X-Plasma-DropUrlPatterns" with type "QStringList"[2019-08-22T16:29:42.505Z] Found property definition "X-Plasma-NotificationArea" with type "QString"[2019-08-22T16:29:42.505Z] Found property definition "X-Plasma-NotificationAreaCategory" with type "QString"[2019-08-22T16:29:42.505Z] Found property definition "X-Plasma-DBusActivationService" with type "QString"[2019-08-22T16:29:42.505Z] Found property definition "X-KDE-ParentApp" with type "QString"[2019-08-22T16:29:42.505Z] Found property definition "X-Plasma-Provides" with type "QStringList"[2019-08-22T16:29:42.505Z] Found property definition "X-Plasma-PreloadWeight" with type "int"[2019-08-22T16:29:42.505Z] Found property definition "X-Plasma-ConfigPlugins" with type "QStringList"[2019-08-22T16:29:42.505Z] Found property definition "X-Plasma-StandAloneApp" with type "bool"[2019-08-22T16:29:42.505Z] Found property definition "X-Plasma-RequiredExtensions" with type "QStringList"[2019-08-22T16:29:42.505Z] Found property definition "NoDisplay" with type "bool"[2019-08-22T16:29:42.505Z] Generated  "/home/jenkins/workspace/Plasma/plasma-nm/stable-kf5-qt5 SUSEQt5.12/build/applet/org.kde.plasma.networkmanagement-plasmoids-metadata.json" [2019-08-22T16:29:42.505Z] [2019-08-22T16:29:42.505Z] [  1%] Built target org.kde.plasma.networkmanagement-plasmoids-metadata-json[2019-08-22T16:29:42.505Z] Scanning dependencies of target org.kde.plasma.networkmanagement-plasmoids-qrc[2019-08-22T16:29:42.505Z] [  1%] Built target org.kde.plasma.networkmanagement-plasmoids-qrc[2019-08-22T16:29:42.505Z] Scanning dependencies of target org.kde.plasma.networkmanagement-plasmoids-contents-rcc[2019-08-22T16:29:42.505Z] [  1%] Generating org.kde.plasma.networkmanagement-contents.rcc[2019-08-22T16:29:42.505Z] [  1%] Built target org.kde.plasma.networkmanagement-plasmoids-contents-rcc[2019-08-22T16:29:43.875Z] AutoMoc: /home/jenkins/workspace/Plasma/plasma-nm/stable-kf5-qt5 SUSEQt5.12/libs/editor/widgets/passwordfield.h:32: Warning: Property declaration passwordModeEnabled has no READ accessor function or associated MEMBER variable. The property will be invalid.[2019-08-22T16:29:43.875Z] [  1%] Built target plasmanm_editor_autogen[2019-08-22T16:29:43.875Z] [  1%] Generating ui_802-1x.h[2019-08-22T16:29:43.875Z] [  2%] Generating ui_bt.h[2019-08-22T16:29:43.875Z] [  2%] Generating ui_connectioneditortabwidget.h[2019-08-22T16:29:43.875Z] [  3%] Generating ui_bond.h[2019-08-22T16:29:43.875Z] [  3%] Generating ui_bridge.h[2019-08-22T16:29:43.875Z] [  3%] Generating ui_cdma.h[2019-08-22T16:29:43.875Z] [  3%] Generating ui_connectionwidget.h[2019-08-22T16:29:43.875Z] [  3%] Generating ui_infiniband.h[2019-08-22T16:29:43.875Z] [  4%] 

D23248: Make "Network Disconnected" notification low priority

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:b8e7d4c03b39: Make Network Disconnected 
notification low priority (authored by ngraham).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23248?vs=64003=64323

REVISION DETAIL
  https://phabricator.kde.org/D23248

AFFECTED FILES
  kded/networkmanagement.notifyrc

To: ngraham, jgrulich, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23125: fix bridge master:slave mapping by-name

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:9fccc9a8d599: fix bridge master:slave mapping by-name 
(authored by sitter).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23125?vs=64036=64320

REVISION DETAIL
  https://phabricator.kde.org/D23125

AFFECTED FILES
  libs/editor/connectioneditorbase.cpp
  libs/editor/settings/bondwidget.cpp
  libs/editor/settings/bondwidget.h
  libs/editor/settings/bridgewidget.cpp
  libs/editor/settings/bridgewidget.h
  libs/editor/settings/teamwidget.cpp
  libs/editor/settings/teamwidget.h

To: sitter, jgrulich
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23350: Chaning default iconSize in systemtray

[Alexey Min]

alexeymin added a comment.


  I can confirm the issue that tray icons are to small on 4k display

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23350

To: xshram, ngraham
Cc: alexeymin, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23152: [energy kcm] Display Vendor and model

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  That looks fantastic to me!

REPOSITORY
  R102 KInfoCenter

BRANCH
  dev2

REVISION DETAIL
  https://phabricator.kde.org/D23152

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23350: Chaning default iconSize in systemtray

[Nathaniel Graham]

ngraham added a comment.


  So this is a complaint that comes up a lot. I do see what you mean, and in my 
opinion, what we need is a dual-mode size control UI that lets you switch 
between "scale icons to fit in panel", "static icon size", and "n columns". 
However we don't have a UI that implements this. I would be happy to entertain 
a patch that added that though.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23350

To: xshram, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23350: Chaning default iconSize in systemtray

[Vladislav Vekyu]

xshram added a comment.


  In D23350#516753 , @ngraham wrote:
  
  > Looks to me that scaling is working just fine for system tray items in your 
screenshot. It's deliberate that they have that much padding on the top and 
bottom (at least with the default size settings).
  
  
  Really? There is a picture, how it looks with value = 2.
  F7270520: image.png 
  What is the point of giving an opportunity to stretch a panel and non giving 
a opportunity of having icons the same size? But i know my place and if it must 
be as it is, so be it.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23350

To: xshram, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

[Nathaniel Graham]

ngraham added a subscriber: nicolasfella.
ngraham added a comment.


  The text "change password" is not accurate when you're setting up a new user. 
For that case, it should say "set password". But the new user creation process 
is really weird and needs to be redone anyway, so maybe that's the better 
approach.
  
  Speaking of which, IIRC @nicolasfella was redoing this KCM from scratch with 
QML. How's that going, Nico?

REPOSITORY
  R128 User Manager

BRANCH
  arcpatch-D23337

REVISION DETAIL
  https://phabricator.kde.org/D23337

To: meven, #plasma, ngraham, davidedmundson, sitter, #vdg, GB_2
Cc: nicolasfella, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, 
konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, fbampaloukas, 
squeakypancakes, alexde, IohannesPetros, trickyricky26, ragreen, mglb, Pitel, 
crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D23350: Chaning default iconSize in systemtray

[Nathaniel Graham]

ngraham added a comment.


  Looks to me that scaling is working just fine for system tray items in your 
screenshot. It's deliberate that they have that much padding on the top and 
bottom (at least with the default size settings).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23350

To: xshram, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23350: Chaning default iconSize in systemtray

[Vladislav Vekyu]

xshram added a comment.


  In D23350#516738 , @ngraham wrote:
  
  > The label says:
  >
  > > On high DPI systems those values would be scaled up, depending on the DPI
  >
  > So I gather that's not working? If not, we should fix that, not work around 
it by changing the default. FWIW going from 1 to 2 causes the following visual 
change if you happen to use a double-thickness panel:
  >  F7270455: Screenshot_20190822_084957.png 

  >
  > This may in fact be desirable, but it's clearly not an intended effect of 
the patch, and it would need to be done deliberately.
  
  
  Yes, it doesn't work, attached photo how it looks with default value(1).
  F7270494: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23350

To: xshram, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23350: Chaning default iconSize in systemtray

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  The label says:
  
  > On high DPI systems those values would be scaled up, depending on the DPI
  
  So I gather that's not working? If not, we should fix that, not work around 
it by changing the default. FWIW going from 1 to 2 causes the following visual 
change if you happen to use a double-thickness panel:
  F7270455: Screenshot_20190822_084957.png 

  
  This may in fact be desirable, but it's clearly not an intended effect of the 
patch, and it would need to be done deliberately.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23350

To: xshram, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23350: Chaning default iconSize in systemtray

[Vladislav Vekyu]

xshram created this revision.
xshram created this object with edit policy "Administrators".
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
xshram requested review of this revision.

REVISION SUMMARY
  A patch for small icons on 4k displays and it doesn't break icons on FullHD 
display.

TEST PLAN
  Look at icons on KDE on 4k display before patch and after. Restart plasma 
after patch ofc.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D23350

AFFECTED FILES
  applets/systemtray/package/contents/config/main.xml

To: xshram
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23342: Add a per-process network information plugin

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 64310.
ahiemstra added a comment.


  - Use libexec dir for the helper install location
  - Don't use nonexistant variables

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23342?vs=64295=64310

BRANCH
  network_plugin

REVISION DETAIL
  https://phabricator.kde.org/D23342

AFFECTED FILES
  CMakeLists.txt
  cmake/FindLibcap.cmake
  cmake/Findlibpcap.cmake
  plugins/CMakeLists.txt
  plugins/process/network/CMakeLists.txt
  plugins/process/network/README.md
  plugins/process/network/helper/Accumulator.cpp
  plugins/process/network/helper/Accumulator.h
  plugins/process/network/helper/CMakeLists.txt
  plugins/process/network/helper/Capture.cpp
  plugins/process/network/helper/Capture.h
  plugins/process/network/helper/ConnectionMapping.cpp
  plugins/process/network/helper/ConnectionMapping.h
  plugins/process/network/helper/Packet.cpp
  plugins/process/network/helper/Packet.h
  plugins/process/network/helper/TimeStamps.h
  plugins/process/network/helper/main.cpp
  plugins/process/network/network.cpp
  plugins/process/network/network.h
  plugins/process/network/networkconstants.h.in
  plugins/process/network/networkplugin.json

To: ahiemstra, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23324: Show progress for PackageKit update fetching

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:27550f8a6d7f: Show progress for PackageKit update 
fetching (authored by apol).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23324?vs=64288=64308

REVISION DETAIL
  https://phabricator.kde.org/D23324

AFFECTED FILES
  discover/qml/UpdatesPage.qml
  libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp
  libdiscover/backends/PackageKitBackend/PackageKitBackend.h
  libdiscover/backends/PackageKitBackend/PackageKitUpdater.cpp
  libdiscover/backends/PackageKitBackend/PackageKitUpdater.h
  libdiscover/resources/AbstractResourcesBackend.cpp
  libdiscover/resources/AbstractResourcesBackend.h
  libdiscover/resources/ResourcesModel.cpp
  libdiscover/resources/ResourcesModel.h
  libdiscover/resources/ResourcesUpdatesModel.h

To: apol, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D22514: Show if KRunner is still searching for more things

[Aleix Pol Gonzalez]

apol added inline comments.

INLINE COMMENTS

> davidedmundson wrote in RunCommand.qml:86
> Does using Kirigami.ActionTextField help with positioning?

Since it's using QQC2.TextField, won't it be using a completely different 
colour scheme?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22514

To: apol
Cc: davidedmundson, ngraham, aspotashev, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23324: Show progress for PackageKit update fetching

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Thanks, this looks so much nicer now!

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23324

To: apol, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23342: Add a per-process network information plugin

[Arjen Hiemstra]

ahiemstra added inline comments.

INLINE COMMENTS

> davidedmundson wrote in CMakeLists.txt:26
> There's nothing at runtime, but we know KDE_INSTALL_LIBEXECDIR_FULL at 
> configure time, so we can pass that to the plugin.

Oh, that's a good idea, I totally did not think about that.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D23342

To: ahiemstra, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D22514: Show if KRunner is still searching for more things

[David Edmundson]

davidedmundson added a comment.


  Seems to work. There's some comments from Kai above.

INLINE COMMENTS

> RunCommand.qml:86
> +margins: units.smallSpacing
> +rightMargin: height
> +}

Does using Kirigami.ActionTextField help with positioning?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22514

To: apol
Cc: davidedmundson, ngraham, aspotashev, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23342: Add a per-process network information plugin

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> ahiemstra wrote in CMakeLists.txt:26
> We can, if there is a decent way to find executables in libexec, because I 
> couldn't find anything in QStandardPaths.

There's nothing at runtime, but we know KDE_INSTALL_LIBEXECDIR_FULL at 
configure time, so we can pass that to the plugin.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D23342

To: ahiemstra, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23342: Add a per-process network information plugin

[Arjen Hiemstra]

ahiemstra marked an inline comment as done.
ahiemstra added inline comments.

INLINE COMMENTS

> davidedmundson wrote in CMakeLists.txt:26
> Can we use KDE_INSTALL_LIBEXECDIR?

We can, if there is a decent way to find executables in libexec, because I 
couldn't find anything in QStandardPaths.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D23342

To: ahiemstra, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23334: Remove slideWindow(QWidget*) overload with recent KWindowSystem

[David Faure]

dfaure closed this revision.

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D23334

To: dfaure, zzag
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23345: Fix mpris plugin in Firefox when Content-Security-Policy is enabled

[Carl Schwan]

ognarb created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  Credit to kbroulik, he did all the work.

TEST PLAN
  Tested in firefox, chromium with Nextclould Music and Youtube

REPOSITORY
  R856 Plasma Browser Integration

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23345

AFFECTED FILES
  extension/content-script.js

To: ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23342: Add a per-process network information plugin

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> CMakeLists.txt:21
> +
> +if (HAVE_LIBCAP)
> +install(

This isn't set.

libcap_FOUND is

> CMakeLists.txt:26
> +CAP_NET_RAW=+ep
> +\$ENV{DESTDIR}${CMAKE_INSTALL_FULL_BINDIR}/ksgrd_network_helper)"
> +)

Can we use KDE_INSTALL_LIBEXECDIR?

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D23342

To: ahiemstra, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23342: Add a per-process network information plugin

[Arjen Hiemstra]

ahiemstra marked 2 inline comments as done.
ahiemstra added inline comments.

INLINE COMMENTS

> davidedmundson wrote in network.cpp:74
> why 2? We call parts.at(6)
> 
> Also code style {}

Good point. I cannot recall why I used 2 so changed it to 7 now.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D23342

To: ahiemstra, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23342: Add a per-process network information plugin

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 64295.
ahiemstra added a comment.


  - Reject lines <7 elements instead of <2

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23342?vs=64293=64295

BRANCH
  network_plugin

REVISION DETAIL
  https://phabricator.kde.org/D23342

AFFECTED FILES
  CMakeLists.txt
  cmake/FindLibcap.cmake
  cmake/Findlibpcap.cmake
  plugins/CMakeLists.txt
  plugins/process/network/CMakeLists.txt
  plugins/process/network/README.md
  plugins/process/network/helper/Accumulator.cpp
  plugins/process/network/helper/Accumulator.h
  plugins/process/network/helper/CMakeLists.txt
  plugins/process/network/helper/Capture.cpp
  plugins/process/network/helper/Capture.h
  plugins/process/network/helper/ConnectionMapping.cpp
  plugins/process/network/helper/ConnectionMapping.h
  plugins/process/network/helper/Packet.cpp
  plugins/process/network/helper/Packet.h
  plugins/process/network/helper/TimeStamps.h
  plugins/process/network/helper/main.cpp
  plugins/process/network/network.cpp
  plugins/process/network/network.h
  plugins/process/network/networkplugin.json

To: ahiemstra, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23342: Add a per-process network information plugin

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 64293.
ahiemstra added a comment.


  - Add missing header and remove unneeded forward declares
  - Code style fixes

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23342?vs=64289=64293

BRANCH
  network_plugin

REVISION DETAIL
  https://phabricator.kde.org/D23342

AFFECTED FILES
  CMakeLists.txt
  cmake/FindLibcap.cmake
  cmake/Findlibpcap.cmake
  plugins/CMakeLists.txt
  plugins/process/network/CMakeLists.txt
  plugins/process/network/README.md
  plugins/process/network/helper/Accumulator.cpp
  plugins/process/network/helper/Accumulator.h
  plugins/process/network/helper/CMakeLists.txt
  plugins/process/network/helper/Capture.cpp
  plugins/process/network/helper/Capture.h
  plugins/process/network/helper/ConnectionMapping.cpp
  plugins/process/network/helper/ConnectionMapping.h
  plugins/process/network/helper/Packet.cpp
  plugins/process/network/helper/Packet.h
  plugins/process/network/helper/TimeStamps.h
  plugins/process/network/helper/main.cpp
  plugins/process/network/network.cpp
  plugins/process/network/network.h
  plugins/process/network/networkplugin.json

To: ahiemstra, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23342: Add a per-process network information plugin

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> network.cpp:74
> +const auto parts = line.splitRef(QLatin1Char('|'), 
> QString::SkipEmptyParts);
> +if (parts.size() < 2)
> +continue;

why 2? We call parts.at(6)

Also code style {}

> network.h:28-29
> +
> +class NetworkSensor;
> +class ApplicationNetworkSensor;
> +

These can go go now

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D23342

To: ahiemstra, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D23287: Create a plugin framework for processes

[David Edmundson]

davidedmundson updated this revision to Diff 64291.
davidedmundson added a comment.


  Split ProcessAttribute into a new file
  Install headers correctly

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23287?vs=64189=64291

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23287

AFFECTED FILES
  processcore/CMakeLists.txt
  processcore/extended_process_list.cpp
  processcore/extended_process_list.h
  processcore/formatter.cpp
  processcore/formatter.h
  processcore/process_attribute.cpp
  processcore/process_attribute.h
  processcore/process_data_provider.cpp
  processcore/process_data_provider.h
  processcore/processes.cpp
  processcore/processes.h
  processcore/unit.cpp
  processcore/unit.h
  processui/ProcessModel.cpp
  processui/ProcessModel_p.h

To: davidedmundson, #plasma, ahiemstra
Cc: ahiemstra, alexde, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23342: Add a per-process network information plugin

[Arjen Hiemstra]

ahiemstra created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This adds a ksysguard process plugin that provides information about
  how much data is being used by a certain process. Since there is no
  unpriviledged API available (yet?) for this information, a small
  helper application is used that uses libpcap to capture packet sizes,
  which is then mapped to individual processes by comparing sockets to
  entries in /proc.
  
  The helper application is intentionally kept small and should not
  require anything else than `cap_net_raw`.
  
  Depends on D23287 

TEST PLAN
  Ensure ksgrd_network_helper has cap_net_raw set, by running 
  `setcap cap_net_raw+ep ksgrd_network_helper`. After that, start
  ksysguard. The "upload" and "download" columns should be
  automatically enabled and display network traffic for a certain
  process.

REPOSITORY
  R106 KSysguard

BRANCH
  network_plugin

REVISION DETAIL
  https://phabricator.kde.org/D23342

AFFECTED FILES
  CMakeLists.txt
  cmake/FindLibcap.cmake
  cmake/Findlibpcap.cmake
  plugins/CMakeLists.txt
  plugins/process/network/CMakeLists.txt
  plugins/process/network/README.md
  plugins/process/network/helper/Accumulator.cpp
  plugins/process/network/helper/Accumulator.h
  plugins/process/network/helper/CMakeLists.txt
  plugins/process/network/helper/Capture.cpp
  plugins/process/network/helper/Capture.h
  plugins/process/network/helper/ConnectionMapping.cpp
  plugins/process/network/helper/ConnectionMapping.h
  plugins/process/network/helper/Packet.cpp
  plugins/process/network/helper/Packet.h
  plugins/process/network/helper/TimeStamps.h
  plugins/process/network/helper/main.cpp
  plugins/process/network/network.cpp
  plugins/process/network/network.h
  plugins/process/network/networkplugin.json

To: ahiemstra
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23324: Show progress for PackageKit update fetching

[Aleix Pol Gonzalez]

apol updated this revision to Diff 64288.
apol added a comment.


  Center in the updates page

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23324?vs=64238=64288

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23324

AFFECTED FILES
  discover/qml/UpdatesPage.qml
  libdiscover/backends/PackageKitBackend/PackageKitBackend.cpp
  libdiscover/backends/PackageKitBackend/PackageKitBackend.h
  libdiscover/backends/PackageKitBackend/PackageKitUpdater.cpp
  libdiscover/backends/PackageKitBackend/PackageKitUpdater.h
  libdiscover/resources/AbstractResourcesBackend.cpp
  libdiscover/resources/AbstractResourcesBackend.h
  libdiscover/resources/ResourcesModel.cpp
  libdiscover/resources/ResourcesModel.h
  libdiscover/resources/ResourcesUpdatesModel.h

To: apol, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23198: Skip mime type check only for files on network mounts

[Méven Car]

meven added a comment.


  My last change is more a Proof of Concept : using Solid to avoid mime check.
  I would be in favor of adding a static function to Solid encompassing this 
use case.
  For instance :
  bool Solid::isMountedOnNetworkShare(const QString ) static;
  
  But the good part is that this solution actually works, we get back icons for 
local files and don't block plasma with a stale mount.
  
  I am open for suggestion.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23198

To: meven, #plasma, dfaure
Cc: davidedmundson, ngraham, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23198: Skip mime type check only for files on network mounts

[Méven Car]

meven updated this revision to Diff 64283.
meven added a comment.


  Use solid to find network shares

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23198?vs=63859=64283

BRANCH
  arcpatch-D23198

REVISION DETAIL
  https://phabricator.kde.org/D23198

AFFECTED FILES
  applets/kicker/plugin/recentusagemodel.cpp

To: meven, #plasma, dfaure
Cc: davidedmundson, ngraham, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23198: Skip mime type check only for files on network mounts

[Méven Car]

meven added a comment.


  In D23198#514335 , @davidedmundson 
wrote:
  
  > > True, but then that implies that KFileItem::isSlow() which has the same 
code is flawed in the same way.
  >
  > It is. We have ironic lockups there.
  
  
  Indeed after testing a staled nfs mount will block statvfs until network is 
back up.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D23198

To: meven, #plasma, dfaure
Cc: davidedmundson, ngraham, broulik, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

[Méven Car]

meven updated this revision to Diff 64279.
meven added a comment.


  Fix tab order

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23337?vs=64278=64279

BRANCH
  arcpatch-D23337

REVISION DETAIL
  https://phabricator.kde.org/D23337

AFFECTED FILES
  src/CMakeLists.txt
  src/account.ui
  src/accountinfo.cpp
  src/accountinfo.h
  src/avatargallery.cpp
  src/lib/accountmodel.cpp
  src/lib/usersessions.cpp
  src/passwordedit.cpp
  src/passwordedit.h

To: meven, #plasma, ngraham, davidedmundson, sitter, #vdg, GB_2
Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, 
jguidon, hannahk, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

[Méven Car]

meven updated this revision to Diff 64278.
meven added a comment.


  Replace Q_FOREACH by for

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23337?vs=64276=64278

BRANCH
  arcpatch-D23337

REVISION DETAIL
  https://phabricator.kde.org/D23337

AFFECTED FILES
  src/CMakeLists.txt
  src/account.ui
  src/accountinfo.cpp
  src/accountinfo.h
  src/avatargallery.cpp
  src/lib/accountmodel.cpp
  src/lib/usersessions.cpp
  src/passwordedit.cpp
  src/passwordedit.h

To: meven, #plasma, ngraham, davidedmundson, sitter, #vdg, GB_2
Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, 
jguidon, hannahk, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

[Méven Car]

meven updated this revision to Diff 64276.
meven added a comment.


  Add a const before a for

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23337?vs=64275=64276

BRANCH
  arcpatch-D23337

REVISION DETAIL
  https://phabricator.kde.org/D23337

AFFECTED FILES
  src/CMakeLists.txt
  src/account.ui
  src/accountinfo.cpp
  src/accountinfo.h
  src/avatargallery.cpp
  src/passwordedit.cpp
  src/passwordedit.h

To: meven, #plasma, ngraham, davidedmundson, sitter, #vdg, GB_2
Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, 
jguidon, hannahk, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D23152: [energy kcm] Display Vendor and model

[Méven Car]

meven added a comment.


  @ngraham
  
  How about ?
  F7269705: Screenshot_20190822_113559.png 

  
  This is rebased on master and with D23130 
 applied and with the "Current charge" 
field added as I felt it was missing.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23152

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

[Méven Car]

meven updated this revision to Diff 64275.
meven added a comment.


  Add icon document-edit

REPOSITORY
  R128 User Manager

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23337?vs=64274=64275

BRANCH
  arcpatch-D23337

REVISION DETAIL
  https://phabricator.kde.org/D23337

AFFECTED FILES
  src/CMakeLists.txt
  src/account.ui
  src/accountinfo.cpp
  src/accountinfo.h
  src/avatargallery.cpp
  src/passwordedit.cpp
  src/passwordedit.h

To: meven, #plasma, ngraham, davidedmundson, sitter, #vdg
Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, 
jguidon, hannahk, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

[Björn Feber]

GB_2 added inline comments.

INLINE COMMENTS

> account.ui:227
>
> -   
> -
> - 
> -  0
> -  0
> - 
> -
> +   
>  

Add the icon `document-edit`

REPOSITORY
  R128 User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23337

To: meven, #plasma, ngraham, davidedmundson, sitter, #vdg
Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, 
jguidon, hannahk, Ghost6, jraleigh, fbampaloukas, squeakypancakes, alexde, 
IohannesPetros, trickyricky26, ragreen, mglb, Pitel, crozbo, ndavis, ZrenBot, 
firef, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
aaronhoneycutt, abetts, sebas, apol, mbohlender, mart

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

[Méven Car]

meven added a comment.


  This is not yet "great" but makes things more usable.

REPOSITORY
  R128 User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23337

To: meven, #plasma, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

[Méven Car]

meven added a comment.


  The issue was highlighted in https://youtu.be/Fl7TWroe2Zw?t=709

REPOSITORY
  R128 User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23337

To: meven, #plasma, ngraham, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23174: Improve the look of the Activities KCM UI

[Björn Feber]

GB_2 added a comment.


  Ping.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  improved-activities-kcm-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23174

To: GB_2, #plasma, #vdg, ivan, ngraham, #kactivities
Cc: #kactivities, ivan, ngraham, #vdg, plasma-devel, #plasma, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D23337: Replace the PasswordEdit field by a changePassword QPushButton, remove foreach uses

[Méven Car]

meven created this revision.
meven added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  The current behavior to change password is quite unfriendly to say the least.
  Clicking in a line field to open a dialog is not logical.
  Replace this with a much simpler button leading to the dialog.

TEST PLAN
  Compile
  kcmshell5 user_manager
  Tried changing your password
  Tried adding a user

REPOSITORY
  R128 User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D23337

AFFECTED FILES
  src/CMakeLists.txt
  src/account.ui
  src/accountinfo.cpp
  src/accountinfo.h
  src/avatargallery.cpp
  src/passwordedit.cpp
  src/passwordedit.h

To: meven, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23334: Remove slideWindow(QWidget*) overload with recent KWindowSystem

[David Faure]

dfaure created this revision.
dfaure added a reviewer: zzag.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dfaure requested review of this revision.

TEST PLAN
  Fixes the build after https://phabricator.kde.org/D23213

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  Plasma/5.16

REVISION DETAIL
  https://phabricator.kde.org/D23334

AFFECTED FILES
  src/windowsystem/windoweffects.cpp
  src/windowsystem/windoweffects.h

To: dfaure, zzag
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23152: [energy kcm] Display Vendor and model

[Méven Car]

meven added a comment.


  In the end it would mean we would have only two categories "Battery" and 
"Energy" (since I am about to remove the system one).
  Just to make sure, that's what you suggest @ngraham

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D23152

To: meven, broulik, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, Pitel, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart