KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.12 - Build # 404 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.12/404/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Wed, 25 Sep 2019 03:31:38 +
 Build duration:
24 min and counting
   CONSOLE OUTPUT
  [...truncated 170 lines...][2019-09-25T03:54:21.718Z] Retrieving: Plasma-kross-kf5-qt5[2019-09-25T03:54:22.220Z] Retrieving: Plasma-threadweaver-kf5-qt5[2019-09-25T03:54:22.719Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2019-09-25T03:54:23.772Z] Retrieving: Plasma-kwayland-kf5-qt5[2019-09-25T03:54:24.275Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2019-09-25T03:54:24.275Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2019-09-25T03:54:27.386Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2019-09-25T03:54:27.386Z] Retrieving: Plasma-kpty-kf5-qt5[2019-09-25T03:54:27.386Z] Retrieving: Plasma-kinit-kf5-qt5[2019-09-25T03:54:27.386Z] Retrieving: Plasma-kded-kf5-qt5[2019-09-25T03:54:27.386Z] Retrieving: Plasma-kemoticons-kf5-qt5[2019-09-25T03:54:27.887Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2019-09-25T03:54:27.887Z] Retrieving: Plasma-knewstuff-kf5-qt5[2019-09-25T03:54:27.887Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2019-09-25T03:54:27.887Z] Retrieving: Plasma-baloo-kf5-qt5[2019-09-25T03:54:29.546Z] Retrieving: Plasma-bluez-qt-kf5-qt5[2019-09-25T03:54:30.611Z] Retrieving: Plasma-frameworkintegration-kf5-qt5[2019-09-25T03:54:30.611Z] Retrieving: Plasma-kactivities-stats-kf5-qt5[2019-09-25T03:54:31.116Z] Retrieving: Plasma-kcmutils-kf5-qt5[2019-09-25T03:54:31.116Z] Retrieving: Plasma-kdelibs4support-kf5-qt5[2019-09-25T03:54:33.461Z] Retrieving: Plasma-kdesu-kf5-qt5[2019-09-25T03:54:33.970Z] Retrieving: Plasma-kholidays-kf5-qt5[2019-09-25T03:54:33.971Z] Retrieving: Plasma-kimageformats-kf5-qt5[2019-09-25T03:54:33.971Z] Retrieving: Plasma-knotifyconfig-kf5-qt5[2019-09-25T03:54:33.971Z] Retrieving: Plasma-kpeople-kf5-qt5[2019-09-25T03:54:33.971Z] Retrieving: Plasma-kplotting-kf5-qt5[2019-09-25T03:54:33.971Z] Retrieving: Plasma-krunner-kf5-qt5[2019-09-25T03:54:33.971Z] Retrieving: Plasma-kxmlrpcclient-kf5-qt5[2019-09-25T03:54:33.971Z] Retrieving: Plasma-networkmanager-qt-kf5-qt5[2019-09-25T03:54:35.032Z] Retrieving: Plasma-prison-kf5-qt5[2019-09-25T03:54:35.032Z] Retrieving: Plasma-purpose-kf5-qt5[2019-09-25T03:54:35.032Z] Retrieving: Plasma-qqc2-desktop-style-kf5-qt5[2019-09-25T03:54:35.032Z] Retrieving: Plasma-syndication-kf5-qt5[2019-09-25T03:54:35.542Z] Retrieving: Plasma-kjs-kf5-qt5[2019-09-25T03:54:36.603Z] Retrieving: Plasma-kdecoration-kf5-qt5[2019-09-25T03:54:37.103Z] Retrieving: Plasma-kscreenlocker-kf5-qt5[2019-09-25T03:54:41.110Z] Retrieving: Plasma-breeze-kf5-qt5[2019-09-25T03:54:42.775Z] Retrieving: Plasma-khtml-kf5-qt5[2019-09-25T03:54:48.318Z] Retrieving: Plasma-khelpcenter-kf5-qt5[2019-09-25T03:54:48.827Z] Retrieving: Plasma-kio-extras-kf5-qt5[2019-09-25T03:54:52.900Z] Retrieving: Plasma-libksysguard-kf5-qt5[2019-09-25T03:54:52.900Z] Retrieving: Plasma-kwin-kf5-qt5[2019-09-25T03:55:23.693Z] Retrieving: Plasma-milou-kf5-qt5[2019-09-25T03:55:23.693Z] Retrieving: Plasma-libkscreen-kf5-qt5[2019-09-25T03:55:24.193Z] Retrieving: Plasma-kactivitymanagerd-kf5-qt5[2019-09-25T03:55:27.319Z] Retrieving: Plasma-kjsembed-kf5-qt5[2019-09-25T03:55:47.654Z] Cannot contact Docker Swarm-ed3cdbaa3a8b: java.lang.InterruptedException[2019-09-25T03:56:07.738Z] Retrieving: Plasma-plasma-workspace-kf5-qt5[2019-09-25T03:56:07.738Z] Retrieving: Plasma-systemsettings-kf5-qt5[2019-09-25T03:56:07.738Z] Traceback (most recent call last):[2019-09-25T03:56:07.738Z]   File "/usr/lib64/python3.7/urllib/request.py", line 1317, in do_open[2019-09-25T03:56:07.738Z] encode_chunked=req.has_header('Transfer-encoding'))[2019-09-25T03:56:07.738Z]   File "/usr/lib64/python3.7/http/client.py", line 1241, in request[2019-09-25T03:56:07.738Z] self._send_request(method, url, body, headers, encode_chunked)[2019-09-25T03:56:07.738Z]   File "/usr/lib64/python3.7/http/client.py", line 1287, in _send_request[2019-09-25T03:56:07.738Z] self.endheaders(body, encode_chunked=encode_chunked)[2019-09-25T03:56:07.738Z]   File "/usr/lib64/python3.7/http/client.py", line 1236, in endheaders[2019-09-25T03:56:07.738Z] self._send_output(message_body, encode_chunked=encode_chunked)[2019-09-25T03:56:07.738Z]   File "/usr/lib64/python3.7/http/client.py", line 1025, in _send_output[2019-09-25T03:56:07.738Z] self.send(msg)[2019-09-25T03:56:07.738Z]   File "/usr/lib64/python3.7/http/client.py", line 965, in send[2019-09-25T03:56:07.738Z] self.connect()[2019-09-25T03:56:07.738Z]   File "/usr/lib64/python3.7/http/client.py", line 1396, in connect[2019-09-25T03:56:07.738Z] super().connect()[2019-09-25T03:56:07.738Z]   File "/usr/lib64/python3.7/http/client.py", line 937, in connect[2019-09-25T03:56:07.738Z] (self.host,self.port), self.timeout, self.source_address)[2019-09-25T03:56:07.738Z]   File "/usr/lib64/python3.7/socket.py", line 707, in 

D24011: Provide a telemetrics kcm module for Plasma

[David Edmundson]

davidedmundson added a comment.


  Code for plasmashell part is fine. Ship it on that part.
  Might be nicer as an extra file outside ShellCorona which is already way too 
big. Especially when we add in more metrics.

INLINE COMMENTS

> shellcorona.cpp:94
>  
> +class PanelCountSource : public KUserFeedback::AbstractDataSource
> +{

That's a nice idea, I like that.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24011

To: apol, #plasma, vkrause, ngraham
Cc: aspotashev, ngraham, bcooksley, davidedmundson, ognarb, broulik, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24208: [Notifications] Dodge Plasma dialogs

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The notification popup typically gets in the way of the system tray popup.
  In case it would cover a Plasma dialog, hide the notification popup.
  It doesn't specifically check for System Tray but then it will also get out 
of the way of your calendar and other widgets you might have placed in the 
respective corner.

TEST PLAN
  Both genius and evil.
  Still surprised by how little code it is, especially that on QML side a 
simple binding is enough.
  The change from `var` to `let` is for sane scoping, so that the `dialog` we 
refer to is correct one, with `var` scoping it would always be the one from the 
last iteration of the loop
  
  F7426329: ba96db11-fd22-4bb0-b1ef-f042fa3557b3.mp4 

  Moving the systray popup with Alt+left click is just to demonstrate the 
dodging capabilities of the popup ;)
  
  - Opened calendar, popup hid
  - Also hides when an Alternatives dialog covers it
  - does not hide for panel controller
  
  - Closing notification and interacting with them, especially context menu (as 
it opens a new window) still works fine

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24208

AFFECTED FILES
  applets/notifications/CMakeLists.txt
  applets/notifications/notificationapplet.cpp
  applets/notifications/notificationapplet.h
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24205: [GTK3] Make selection-mode headerbars closer to Adwaita

[Ilya Bizyaev]

IlyaBizyaev added a comment.


  Could you show how this change affects the default color scheme?

REPOSITORY
  R98 Breeze for Gtk

REVISION DETAIL
  https://phabricator.kde.org/D24205

To: cblack, #breeze
Cc: IlyaBizyaev, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24205: [GTK3] Make selection-mode headerbars closer to Adwaita

[Carson Black]

cblack created this revision.
cblack added a reviewer: Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  Headerbars in selection mode are now colored in a similar manner as in 
Adwaita.

REPOSITORY
  R98 Breeze for Gtk

BRANCH
  selection-mode-headerbars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24205

AFFECTED FILES
  src/gtk3/widgets/_headerbar.scss

To: cblack, #breeze
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24204: Move save failure message above options

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt, ognarb.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  With the number of options in there, it can be easily missed.

TEST PLAN
  F7426029: Screenshot_20190924_214433.png 


REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24204

AFFECTED FILES
  extension/options.html
  extension/options.js

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24203: Add settings change listener

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt, ognarb.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  I found it's on `chrome.storage` and not `chrome.storage.sync`. This also 
works with Firefox now.
  Also removes the need to have the options page explicitly send a signal that 
settings changed.

TEST PLAN
  - Changed some settings, had them sent to the host just fine. Both on Firefox 
69 and Chrome 77

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24203

AFFECTED FILES
  extension/extension.js
  extension/options.js
  extension/utils.js

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24161: Make KCM look more like applet

[Sefa Eyeoglu]

sefaeyeoglu updated this revision to Diff 66783.
sefaeyeoglu added a comment.


  Import QtQuick.Controls as QQC2 and fix ToolTip delay

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24161?vs=9=66783

BRANCH
  feat-applet-ux

REVISION DETAIL
  https://phabricator.kde.org/D24161

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  src/kcm/package/contents/code/icon.js
  src/kcm/package/contents/ui/Applications.qml
  src/kcm/package/contents/ui/DeviceListItem.qml
  src/kcm/package/contents/ui/Devices.qml
  src/kcm/package/contents/ui/MuteButton.qml
  src/kcm/package/contents/ui/StreamListItem.qml
  src/kcm/package/contents/ui/VolumeSlider.qml
  src/kcm/package/contents/ui/main.qml

To: sefaeyeoglu, #plasma, #vdg
Cc: ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D24161: Make KCM look more like applet

[Sefa Eyeoglu]

sefaeyeoglu added inline comments.

INLINE COMMENTS

> ngraham wrote in Applications.qml:49
> I don't think the addition of the word "Streams" adds useful information here.

The applet already says Streams here.

> ngraham wrote in MuteButton.qml:32
> Using the attached `ToolTip` property is just fine here for QQC2 items.

I feel like QQC2 tooltips look out of place. They don't have the same shadow as 
//normal// tooltips and do not fade in

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D24161

To: sefaeyeoglu, #plasma, #vdg
Cc: ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D24187: WIP: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 66782.
tcanabrava added a comment.


  - Initial Working Gestures

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24187?vs=66781=66782

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24187

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24187: WIP: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 66781.
tcanabrava added a comment.


  - Rename kcm_access to kcmaccess
  - Fix typos
  - Qml Loads. Now, fix beaury
  - Fix imports and labels
  - Fix most layouts
  - Fix layout for the mouse navigation

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24187?vs=66758=66781

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24187

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

[Nathaniel Graham]

ngraham added a comment.


  Yep, I figured you could figure that part out. :)

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23274

To: GB_2, #plasma, #vdg
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

[Björn Feber]

GB_2 added a comment.


  In D23274#537221 , @ngraham wrote:
  
  > Try this patch to your patch: P471 Addendum to D23274 

  
  
  Thanks! The only issue that's left now is that the subcategory doesn't get 
reset (when going into for example Application Style and then pressing the 
button).

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23274

To: GB_2, #plasma, #vdg
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

[Björn Feber]

GB_2 updated this revision to Diff 66780.
GB_2 added a comment.


  Use Nate's fix and enable button when clicking a most used item

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D23274?vs=64682=66780

BRANCH
  add-show-intro-page-button-to-system-settings-sidebar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23274

AFFECTED FILES
  sidebar/SidebarMode.cpp
  sidebar/SidebarMode.h
  sidebar/package/contents/ui/CategoriesPage.qml

To: GB_2, #plasma, #vdg
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D24194: Add per-domain media controls blacklist

[Kai Uwe Broulik]

broulik updated this revision to Diff 66776.
broulik edited the test plan for this revision.
broulik added a comment.


  - Add dummy icon when there's no controls

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24194?vs=66760=66776

REVISION DETAIL
  https://phabricator.kde.org/D24194

AFFECTED FILES
  extension/action_popup.css
  extension/action_popup.html
  extension/action_popup.js
  extension/constants.js
  extension/content-script.js
  extension/extension.js

To: broulik, #plasma, #vdg, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

[Nathaniel Graham]

ngraham added a comment.


  Try this patch to your patch: P471 Addendum to D23274 


REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D23274

To: GB_2, #plasma, #vdg
Cc: ngraham, mart, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Nathaniel Graham]

ngraham added a comment.


  In D24181#536786 , @broulik wrote:
  
  > In D24181#536785 , @ltoscano 
wrote:
  >
  > > Out of curiosity: doesn't usually the default Paste action (ctrl-V) paste 
with formatting? Shouldn't the shortcut be changed instead?
  >
  >
  > Yeah, normally Ctrl+Shift+V pastes without formatting.
  
  
  That's true, but we decided to make the default paste action strip formatting 
for this applet because that was a better default action. It's not necessarily 
a bad default for other apps so we didn't change it universally. Thus I think 
this patch makes sense, but if you disagree we can keep discussing it.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: broulik, yurchor, ltoscano, aacid, #localization, yerilov, ngraham, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D23378: Check if sddm user exists

[Filip Fila]

filipf added a comment.


  @davidedmundson is this okay now?

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

BRANCH
  sddm-user-check (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D23378

To: filipf, #plasma, davidedmundson, ngraham, #vdg, fvogt
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D24161: Make KCM look more like applet

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> Applications.qml:49
>  enabled: eventStreamView.count || sinkInputView.count
> -text: i18nd("kcm_pulseaudio", "Playback")
> +text: i18nd("kcm_pulseaudio", "Playback Streams")
>  disabledText: i18ndc("kcm_pulseaudio", "@label", "No 
> Applications Playing Audio")

I don't think the addition of the word "Streams" adds useful information here.

> Applications.qml:90
>  enabled: sourceOutputView.count > 0
> -text: i18nd("kcm_pulseaudio", "Recording")
> +text: i18nd("kcm_pulseaudio", "Recording Streams")
>  disabledText: i18ndc("kcm_pulseaudio", "@label", "No 
> Applications Recording Audio")

ditto

> MuteButton.qml:23
>  import QtQuick 2.0
> -import QtQuick.Controls 1.0
> +import QtQuick.Controls 2.0
> +import "../code/icon.js" as Icon

If you're going to change this (and +1 for it), make it say `import 
QtQuick.Controls 2.5 as QQC2` and then add the `QQC2.` namespace

> sefaeyeoglu wrote in MuteButton.qml:32
> I actually think this is the wrong way of doing tooltips here. The applet 
> does it with PlasmaComponents. How can I create a tooltip with QCC?

Using the attached `ToolTip` property is just fine here for QQC2 items.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D24161

To: sefaeyeoglu, #plasma, #vdg
Cc: ngraham, davidedmundson, GB_2, #plasma, plasma-devel, #vdg, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, trickyricky26, 
ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
mbohlender, mart

D24110: Enable removing multiple devices at once

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:e586f2794b74: Enable removing multiple devices at once 
(authored by umanovskis, committed by ngraham).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24110?vs=66735=66765

REVISION DETAIL
  https://phabricator.kde.org/D24110

AFFECTED FILES
  src/kcmodule/devices/devices.cpp
  src/kcmodule/devices/devices.h

To: umanovskis, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24147: fix compatibility with Qt5.11

[Matthieu Gallien]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:d2570246a555: fix compatibility with Qt5.11 (authored by 
mgallien).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24147?vs=6=66764

REVISION DETAIL
  https://phabricator.kde.org/D24147

AFFECTED FILES
  src/controls/Action.qml
  src/controls/ActionToolBar.qml
  src/controls/ListSectionHeader.qml

To: mgallien, #kirigami, mart
Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12).

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  In D24193#537123 , @ouwerkerk 
wrote:
  
  > If Kirigami is supposed to depend on Qt 5.11, then *why* were these old 
imports there in the first place? They cannot work with Qt 5.11, because then 
the max QQC version is 2.4
  >
  > Maybe I am misunderstanding something here? Are you saying the old Kirigami 
code effectively broke its own policy on depending on (newer) Qt versions?
  
  
  Yes, D22974  broke this policy. The 
correct fix is D24147 .

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24193

To: ouwerkerk, mart, #plasma, ngraham
Cc: ngraham, anthonyfieroni, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, davidedmundson, mart, hein

D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12).

[Johan Ouwerkerk]

ouwerkerk added a comment.


  And if so, sure I can 'fix' this by downgrading to QQC 2.4 instead but in 
that case: is this 'safe'? I.e. does this introduce bugs/regressions?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24193

To: ouwerkerk, mart, #plasma
Cc: anthonyfieroni, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
apol, davidedmundson, mart, hein

D24192: WIP: Active page follow the focus

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> PageRow.qml:162
> +
> +while (item_parent && !(item_parent instanceof Page)) {
> +item_parent = item_parent.parent;

Does this work in Qt 5.11? I recall `typeof` for QML types only being 
implemented in Qt 5.12

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24192

To: ognarb, #kirigami, #plasma_accessibility
Cc: broulik, mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, hein

D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12).

[Johan Ouwerkerk]

ouwerkerk added a comment.


  If Kirigami is supposed to depend on Qt 5.11, then *why* were these old 
imports there in the first place? They cannot work with Qt 5.11, because then 
the max QQC version is 2.4
  
  Maybe I am misunderstanding something here? Are you saying the old Kirigami 
code effectively broke its own policy on depending on (newer) Qt versions?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24193

To: ouwerkerk, mart, #plasma
Cc: anthonyfieroni, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
apol, davidedmundson, mart, hein

D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12).

[Marco Martin]

mart added a comment.


  we have to depend from 2 qt versions ago as per KDE frameworks policy, so max 
version that can be used is Qt 5.11

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24193

To: ouwerkerk, mart, #plasma
Cc: anthonyfieroni, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
apol, davidedmundson, mart, hein

D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12).

[Anthony Fieroni]

anthonyfieroni added reviewers: mart, Plasma.
anthonyfieroni added a comment.


  Kirigami itself depends on 5.11 
https://phabricator.kde.org/source/kirigami/browse/master/CMakeLists.txt$8 so 
update version to that one https://doc.qt.io/qt-5/qtquickcontrols-index.html

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24193

To: ouwerkerk, mart, #plasma
Cc: anthonyfieroni, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
apol, davidedmundson, mart, hein

D24194: Add per-domain media controls blacklist

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG, fvogt, ognarb.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Allows disabling them for a specific domain in case it causes trouble or 
unwanted media controls.
  
  BUG: 394126

TEST PLAN
  - Successfully enabled and disabled media controls on a domain
  - Popup shows all domains of the current page (in case it has iframes)
  - On chrome:// urls the popup is enabled but has no checkboxes as I cannot 
access those pages, maybe there should be a generic Plasma logo then instead
  
  There's a way for us to ship a blacklist by default that the user can then 
override
  
  Should there be wildcard support? Do we need a UI in settings to list all 
blacklists and edit them?
  
  F7424539: Screenshot_20190921_120206.png 


REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24194

AFFECTED FILES
  extension/action_popup.css
  extension/action_popup.html
  extension/action_popup.js
  extension/constants.js
  extension/content-script.js
  extension/extension.js

To: broulik, #plasma, #vdg, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24193: Bump QtQuick.Controls dependency to 2.12 (from Qt 5.12).

[Johan Ouwerkerk]

ouwerkerk created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ouwerkerk requested review of this revision.

REVISION SUMMARY
  It is a bad idea to depend on non-existent versions: we should more clearly 
mark our intended QQC dependency version (ie. Qt 5.12 at a minimum) by refering 
to an actual release.
  While technically correct, non-existent dependency versions such as 2.5 and 
2.7 are confusing and causing people to mistakenly propose downstream patches 
to fix imagined 'typos', cf.: 
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=940966

REPOSITORY
  R169 Kirigami

BRANCH
  bump-qcc2-to-qt-5.12

REVISION DETAIL
  https://phabricator.kde.org/D24193

AFFECTED FILES
  src/controls/AbstractApplicationHeader.qml
  src/controls/Action.qml
  src/controls/ActionToolBar.qml
  src/controls/ListSectionHeader.qml
  src/controls/templates/SwipeListItem.qml

To: ouwerkerk
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D24187: WIP: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 66758.
tcanabrava added a comment.


  - Remove the ui file

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24187?vs=66746=66758

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24187

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.h
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24192: WIP: Active page follow the focus

[Carl Schwan]

ognarb added a subscriber: mart.
ognarb added inline comments.

INLINE COMMENTS

> PageRow.qml:172
> +print("focus not current item");
> +root.removePage(columnView.currentItem);
> +print("pop");

@mart removePage doesn't work well, how can I change the current page?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24192

To: ognarb, #kirigami, #plasma_accessibility
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, hein

D24192: WIP: Active page follow the focus

[Carl Schwan]

ognarb created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.

REVISION SUMMARY
  This doesn't work well yet.
  
  - Need a long time (2-4 seconde) before the page is updated
  - Loss focus after changing page

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D24192

AFFECTED FILES
  src/controls/PageRow.qml

To: ognarb
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
davidedmundson, mart, hein

D24191: Let plugin add additional status information

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:309ded7b3ba6: Let plugin add additional status 
information (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24191?vs=66752=66755

REVISION DETAIL
  https://phabricator.kde.org/D24191

AFFECTED FILES
  host/abstractbrowserplugin.cpp
  host/abstractbrowserplugin.h
  host/settings.cpp

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24191: Let plugin add additional status information

[Fabian Vogt]

fvogt added inline comments.

INLINE COMMENTS

> broulik wrote in abstractbrowserplugin.h:47
> Not too happy about making it public, but it is used by `Settings`. Other 
> alternative would be to make a getter in `PluginManager` which then calls 
> this... or also making `Settings` a `friend class`

I actually expect a method like this to be public

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24191

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24191: Let plugin add additional status information

[Fabian Vogt]

fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  Seems a bit weird to merge it at the top-level instead of adding a new key, 
but it's unlikely to result in abuse.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24191

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24191: Let plugin add additional status information

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> abstractbrowserplugin.h:47
> + */
> +virtual QJsonObject status() const;
> +

Not too happy about making it public, but it is used by `Settings`. Other 
alternative would be to make a getter in `PluginManager` which then calls 
this... or also making `Settings` a `friend class`

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24191

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24190: Let options page scroll

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:fb4cfa20bfb0: Let options page scroll (authored by 
broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24190?vs=66751=66753

REVISION DETAIL
  https://phabricator.kde.org/D24190

AFFECTED FILES
  extension/options.css

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24191: Let plugin add additional status information

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt, ognarb.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  This can be used to communicate further status information, e.g. whether an 
external dependency or binary was found.

TEST PLAN
  Will be used in the future for checking whether the itinerary extractor is 
installed. The plugin might be supported in the host just fine but the 
extractor might not be installed.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24191

AFFECTED FILES
  host/abstractbrowserplugin.cpp
  host/abstractbrowserplugin.h
  host/settings.cpp

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24190: Let options page scroll

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt, ognarb.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  There'll be more options in the future

TEST PLAN
  - Scrolls vertically now
  - The minimum width caused a resize dance in Chrome, so I changed it to be a 
fixed width instead

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24190

AFFECTED FILES
  extension/options.css

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24165: Add SettingsUtil utility class

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:64d6bab15fe6: Add SettingsUtils utility class (authored 
by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24165?vs=66690=66750

REVISION DETAIL
  https://phabricator.kde.org/D24165

AFFECTED FILES
  extension/content-script.js
  extension/extension-utils.js
  extension/extension.js
  extension/manifest.json
  extension/options.html
  extension/options.js
  extension/utils.js

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24110: Enable removing multiple devices at once

[Nathaniel Graham]

ngraham added a comment.


  Yep, will do in a little while.

REPOSITORY
  R97 Bluedevil

BRANCH
  dev-multiselect

REVISION DETAIL
  https://phabricator.kde.org/D24110

To: umanovskis, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24165: Add SettingsUtil utility class

[Fabian Vogt]

fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  Appears to work on ESR

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D24165

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24110: Enable removing multiple devices at once

[Daniels Umanovskis]

umanovskis added a comment.


  Thanks! Would you land this for me?

REPOSITORY
  R97 Bluedevil

BRANCH
  dev-multiselect

REVISION DETAIL
  https://phabricator.kde.org/D24110

To: umanovskis, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24110: Enable removing multiple devices at once

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Lovely work. 

REPOSITORY
  R97 Bluedevil

BRANCH
  dev-multiselect

REVISION DETAIL
  https://phabricator.kde.org/D24110

To: umanovskis, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24187: WIP: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
tcanabrava requested review of this revision.

REVISION SUMMARY
  please don't review it yet
  
  Remove uneeded Item
  
  Beginning of the Modifier Keys
  
  KeyboardFilters start
  
  Activation Gestures wip
  
  Wip of the MouseNavigation
  
  Small fixes and screen reader wip.
  
  Compiles - still doesn't link
  
  compile and link

REPOSITORY
  R119 Plasma Desktop

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D24187

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.h
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop
  kcms/colors/CMakeLists.txt

To: tcanabrava
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24178: Add ability to cycle through sources in mediacontroller applet

[Dylan McDougall]

dylanmcdougall added inline comments.

INLINE COMMENTS

> ngraham wrote in ExpandedRepresentation.qml:121
> Why [W]? W for Walk? Seems kind of arbitrary; "walk" isn't really a word I 
> would associate with this. In any event this seems like the kind of thing 
> that would benefit from being a global shortcut rather than something that 
> only works when the applet is open and has focus.

I agree with your judgement on this. I will look into how I can change this.

> ngraham wrote in main.qml:252
> Why wouldn't you want to be able to do this when there are two sources?

mpris2Source.sources always has at least one value, that value being 
"@multiplex". Because of this it will have a length of 3 when there are two 
audio sources, a length of 4 when there are three, etc. Perhaps I should 
include a comment to clarify and avoid this confusion.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24178

To: dylanmcdougall, broulik, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D14796: Port Keyboard input modules and Expand scope to cover input method configuration

[Vladimir Yerilov]

yerilov added a comment.


  This fails to build now.
  
  > The longer we wait, the harder it will be to integrate
  
  So true.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D14796

To: gpark, hein
Cc: davideichelsdoerfer, yerilov, kucharczyk, lavender, ngraham, apol, 
plasma-devel, hein, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D24110: Enable removing multiple devices at once

[Daniels Umanovskis]

umanovskis marked an inline comment as done.
umanovskis added inline comments.

INLINE COMMENTS

> ngraham wrote in devices.cpp:209
> You could rename this function to `removeSelectedDevices()` and handle both 
> single and multi-selection behaviors in it.

Done, looks cleaner now - there's still an if-statement for different dialog 
messages but less duplication overall.

REPOSITORY
  R97 Bluedevil

BRANCH
  dev-multiselect

REVISION DETAIL
  https://phabricator.kde.org/D24110

To: umanovskis, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24110: Enable removing multiple devices at once

[Daniels Umanovskis]

umanovskis updated this revision to Diff 66735.
umanovskis added a comment.


  - Handle all device deletion in one function, reducing duplication

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24110?vs=66653=66735

BRANCH
  dev-multiselect

REVISION DETAIL
  https://phabricator.kde.org/D24110

AFFECTED FILES
  src/kcmodule/devices/devices.cpp
  src/kcmodule/devices/devices.h

To: umanovskis, #vdg, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Luigi Toscano]

ltoscano added a comment.


  What changes is the patch needed. If we agree that Paste means "paste with 
formatting", then the string don't need to be changed, just the shortcut.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: broulik, yurchor, ltoscano, aacid, #localization, yerilov, ngraham, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Vladimir Yerilov]

yerilov added a comment.


  I have no objections regarding default action, be it paste with or w/o 
formatting, it's rather a common sense fix: name what we use for Ctrl+V as 
"Paste", but and another action should get more detailed description. It also 
looks good in menu:
  
_
|   |
| Paste  Ctrl+V |
|   |
| Paste With Formatting |
|   |
-

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: broulik, yurchor, ltoscano, aacid, #localization, yerilov, ngraham, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D24181: Changing "Paste Without Formatting" in Notes applet to "Paste"

[Kai Uwe Broulik]

broulik added a comment.


  In D24181#536785 , @ltoscano wrote:
  
  > Out of curiosity: doesn't usually the default Paste action (ctrl-V) paste 
with formatting? Shouldn't the shortcut be changed instead?
  
  
  Yeah, normally Ctrl+Shift+V pastes without formatting.

REPOSITORY
  R114 Plasma Addons

BRANCH
  notes-applet-tuning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D24181

To: yerilov, ngraham
Cc: broulik, yurchor, ltoscano, aacid, #localization, yerilov, ngraham, 
plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart