D24580: Fix minor EBN issues

yurchor created this revision. yurchor added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. yurchor requested review of this revision. REVISION SUMMARY Include duplication, no newline at the end of file and missing argument to the i18n() call TEST

Re: Plasma 5.17 tars available

I've updated 5.17 tars for ksysguard and plasma-desktop ksysguard;Plasma/5.17;ad65ea5b68649a4a5d9c1fbf0b792098631aed71;ksysguard-5.17.0.tar.xz;4181535cc74f73c0a75fcf7a377595bd0381125a6f5537b116327b94402013d5 - adds some security fixes from opensuse plasma-desktop;Plasma/5.17;b4a04affd150e6f898810

D24567: WIP: Implement sidebar mode for system tray plasmoid popups

ngraham added inline comments. INLINE COMMENTS > ExpandedRepresentation.qml:69 > > PlasmaExtras.Heading { > id: heading Now that you added a RowLayout, this could go inside it rather than being positioned with anchors REPOSITORY R120 Plasma Workspace REVISION DETAIL https:

D24567: WIP: Implement sidebar mode for system tray plasmoid popups

filipf updated this revision to Diff 67745. filipf added a comment. Remember if sidebar mode was on when restarting plasmashell REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24567?vs=67738&id=67745 BRANCH systray-sidebar-mode (branched from ma

D24283: Add clang format file

cullmann added a comment. This is just a base file for discussion. Stuff like the mentioned case indentation can be adjusted to be frameworks conform. For the alignment of comments, I am not sure, it makes the stuff a lot more readable in many cases and after the initial re-format you don

D24283: Add clang format file

zzag added inline comments. INLINE COMMENTS > zzag wrote in .clang-format:83 > The Frameworks coding says not to indent case lables. s/coding/coding style/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24283 To: davidedmundson Cc: zzag, cullmann, plasma-dev

D24283: Add clang format file

zzag added inline comments. INLINE COMMENTS > .clang-format:55-56 > + > +# align trailing comments > +AlignTrailingComments: true > + I'd object to aligning trailing comments because a single line change may affect many other unrelated lines. However, if this .clang-format file serves just as

D24567: WIP: Implement sidebar mode for system tray plasmoid popups

ngraham added a comment. Interesting, this sorta-kinda implements what's requested in 412483. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24567 To: filipf, #vdg, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_

D24283: Add clang format file

cullmann added a comment. See D24568 for the draft of an ECM module that applies the Kate/KTextEditor/Artikulate style. Is the same file as here, with sorting of includes, but with column limit. REPOSITORY R120 Plasma Workspace REVISION DETAIL https

D24567: WIP: Implement sidebar mode for system tray plasmoid popups

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY System tray popups are currently resizeable through means of an obscure method (ALT + right click + drag) and the resized values are

D24454: Include an emoji picker

apol updated this revision to Diff 67730. apol added a comment. Fix on wayland (and x11?) Don't ever close the process, leave it on background REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67726&id=67730 BRANCH arcpatch-D24454_1 RE

D24454: Include an emoji picker

ngraham added a comment. The new button in the toolbar should hide the search field if it's visible (i.e. it should be a toggle action), and the search field should be inside its own background or toolbar with appropriate padding, not just floating there in space. But is there no way to

D24564: Fix warning when we're not hovering a Control

apol created this revision. apol added reviewers: Kirigami, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Also remove hardcoded value that has a setting TEST PLAN Manual test REPOSITORY R858 Qt Qui

D24454: Include an emoji picker

apol updated this revision to Diff 67726. apol added a comment. Don't always show the search field REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67725&id=67726 BRANCH arcpatch-D24454_1 REVISION DETAIL https://phabricator.kde.org/D2445

D24454: Include an emoji picker

apol updated this revision to Diff 67725. apol added a comment. Move search field REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67724&id=67725 BRANCH arcpatch-D24454_1 REVISION DETAIL https://phabricator.kde.org/D24454 AFFECTED FILES

D24454: Include an emoji picker

ngraham added a comment. Heh the sidebar ampersand fix appears to have had a side effect: F7573595: Screenshot_20191011_104855.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24454 To: apol, #plasma, #vdg Cc: #vdg, G

D24454: Include an emoji picker

apol updated this revision to Diff 67724. apol added a comment. Make the main function more similar to discover's REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67717&id=67724 BRANCH arcpatch-D24454_1 REVISION DETAIL https://phabricato

D24454: Include an emoji picker

ngraham added a comment. Oh one final thing I just thought of: it would be great if the search field could be in the main toolbar rather than in the sidebar, because this makes it inaccessible when the sidebar is collapsed, as it is by default. People might mistakenly assume that there's no

D24223: [RFC] Add global themes that mimic other platforms' workflows

niccolove added a comment. In D24223#537927 , @fabianr wrote: > > It doesn't auto-hide by default in macOS. I decided to make it span the full width of the screen because not doing this is IMO one of the dumbest parts of that macOS dock, because

D24265: support global edit mode

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. LGTM now! REPOSITORY R119 Plasma Desktop BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2, plasma-devel, LeGast

D24454: Include an emoji picker

apol added a comment. In D24454#545454 , @ngraham wrote: > A few more: > > - List the categories in a more common order rather than alphabetical (i.e. first smilies, then nature, then food & drink, etc. Basically copy the mobile emoji picker

D24265: support global edit mode

mart added a comment. proper look now REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali

D24265: support global edit mode

mart updated this revision to Diff 67719. mart added a comment. - proper plasmoid background REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24265?vs=67189&id=67719 BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D24265 AFFECTE

D24454: Include an emoji picker

ngraham added a comment. Great, that's fixed the ampersand. I still see this: > Every time I move the cursor over an emoji, `file:///usr/lib/qt/qml/QtQuick/Controls.2/org.kde.desktop/ToolTip.qml:48:5: Unable to assign [undefined] to bool` is printed to the console ...and all th

D24483: [Weather data engine] Handle windy conditions in NOAA backend

spstarr added a comment. Awesome! REPOSITORY R120 Plasma Workspace BRANCH windy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24483 To: ngraham, kossebau, #plasma, spstarr Cc: spstarr, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2

D24483: [Weather data engine] Handle windy conditions in NOAA backend

spstarr added a comment. I note for Environment Canada they have these Night Blowing snow: https://weather.gc.ca/weathericons/40.gif Day Blowing snow: https://weather.gc.ca/weathericons/25.gif Day and night(?) windy: https://weather.gc.ca/weathericons/43.gif Blowing smoke (day and n

D24483: [Weather data engine] Handle windy conditions in NOAA backend

ngraham added a comment. Yeah there are windy and rainy conditions too. I expect we can handle those as well once we get appropriate icons. REPOSITORY R120 Plasma Workspace BRANCH windy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24483 To: ngraham, kossebau, #

D24265: support global edit mode

mart added a comment. hold on, there is some clipping going on actually REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, al

D24483: [Weather data engine] Handle windy conditions in NOAA backend

spstarr added a comment. Now I'm wondering if I can get a blowing snow icon ;) REPOSITORY R120 Plasma Workspace BRANCH windy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24483 To: ngraham, kossebau, #plasma, spstarr Cc: spstarr, plasma-devel, #vdg, LeGast00n, Th

D24454: Include an emoji picker

apol updated this revision to Diff 67717. apol added a comment. Fix & REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67716&id=67717 BRANCH arcpatch-D24454_1 REVISION DETAIL https://phabricator.kde.org/D24454 AFFECTED FILES applets/k

D24483: [Weather data engine] Handle windy conditions in NOAA backend

ngraham added a comment. Thanks! I'll wait for the icon patch to land before landing this. REPOSITORY R120 Plasma Workspace BRANCH windy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24483 To: ngraham, kossebau, #plasma, spstarr Cc: spstarr, plasma-devel, #vdg, L

D24483: [Weather data engine] Handle windy conditions in NOAA backend

spstarr added a comment. Still looks good to me REPOSITORY R120 Plasma Workspace BRANCH windy (branched from master) REVISION DETAIL https://phabricator.kde.org/D24483 To: ngraham, kossebau, #plasma, spstarr Cc: spstarr, plasma-devel, #vdg, LeGast00n, The-Feren-OS-Dev, jraleigh, fbam

D24543: Set an icon theme for gtk applications in the icons kcm

ngraham added a comment. All right, sure. REPOSITORY R119 Plasma Desktop BRANCH gtk-config-icon-theme REVISION DETAIL https://phabricator.kde.org/D24543 To: gikari, ngraham, meven Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ng

D24454: Include an emoji picker

ngraham added a comment. Oh and one more: ampersands aren't appearing in the category text in the sidebar: F7573352: Screenshot_20191011_095451.png REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24454 To: apol, #plasma

D24454: Include an emoji picker

apol updated this revision to Diff 67716. apol added a comment. Address Nate and GB comments REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67711&id=67716 BRANCH arcpatch-D24454_1 REVISION DETAIL https://phabricator.kde.org/D24454 AFF

D24454: Include an emoji picker

ngraham added a comment. A few more: - List the categories in a more common order rather than alphabetical (i.e. first smilies, then nature, then food & drink, etc. Basically copy the mobile emoji pickers) - The window needs a proper icon, not the generic X11 icon - This might be in

D24543: Set an icon theme for gtk applications in the icons kcm

gikari added a comment. In D24543#545333 , @ngraham wrote: > Nice. We'll also need a patch to remove icon theme configuration from the GTK KCM that depends on this patch so we can land that as soon as this lands. Do you mind if I make rem

D24454: Include an emoji picker

ngraham added a comment. 1. For the first-run use case, show the All category instead of Recent, or any other time when "Recent" is empty 2. How does it work? When I click on an emoji, the window disappears but nothing appears to happen. Its not in the clipboard either? 3. Every time I mo

D24562: [FontAASettings] Use KSharedConfig

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b4a04affd150: [FontAASettings] Use KSharedConfig (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24562?vs=67714&id=67715 REVISION DETA

D24562: [FontAASettings] Use KSharedConfig

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This way we write to the same shared config instance as e.g. krdb and when we `sync()` it then al

D24454: Include an emoji picker

GB_2 added a comment. For "All" I think we should use an icon like `view-list-icons`, otherwise +1. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24454 To: apol, #plasma Cc: GB_2, mart, ngraham, davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS

D24265: support global edit mode

mart added a comment. In D24265#545400 , @GB_2 wrote: > It would be nice if the desktop toolbox had a shadow and had the standard background. it has, as it has the standard background of plasmoids (is not a window, so it can't technicall

D24454: Include an emoji picker

apol added a comment. In D24454#545324 , @ngraham wrote: > How can I test this out? Do I need to have IBus set up? You just need to make sure it's installed, here we're only using it as a library. Then run the `ibus-ui-emojier-plasma` exe

D24454: Include an emoji picker

apol updated this revision to Diff 67711. apol added a comment. Address marco's comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24454?vs=67511&id=67711 BRANCH arcpatch-D24454_1 REVISION DETAIL https://phabricator.kde.org/D24454 AFFECTED

D24265: support global edit mode

ngraham added a comment. In D24265#545400 , @GB_2 wrote: > It would be nice if the desktop toolbox had a shadow and had the standard background. Yeah. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265

D24265: support global edit mode

GB_2 added a comment. It would be nice if the desktop toolbox had a shadow and had the standard background. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh

D24265: support global edit mode

mart added a comment. does that on current version of D24264 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24265 To: mart, #plasma, ngraham Cc: ngraham, GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampalo

D21860: Set a font for gtk applications in the fonts kcm

gikari added a comment. So, do I need to replace `find_package(GTK3 REQUIRED)` to `find_package(GTK3)` and others or not? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #plasma, apol, davidedmundson, cfeck Cc: cfeck, davidedmundson, nicolas

D24561: [krdb] Reparse configuration before syncing krdb configuration

broulik updated this revision to Diff 67710. broulik added a comment. :D REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24561?vs=67709&id=67710 REVISION DETAIL https://phabricator.kde.org/D24561 AFFECTED FILES kcms/krdb/krdb.cpp To: broulik, #

D24561: [krdb] Reparse configuration before syncing krdb configuration

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Plasma-Integration opens `kdeglobals`, so when a KCM then uses `KConfig()` directly and syncs it,

D24264: edit mode action and dbus

mart updated this revision to Diff 67707. mart added a comment. - only close with proper touch events REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24264?vs=67564&id=67707 BRANCH mart/editMode REVISION DETAIL https://phabricator.kde.org/D242

D24557: [kcminit] Additionally look in kcms/ folder for KCM plugins

This revision was automatically updated to reflect the committed changes. Closed by commit R120:5e7e87ca95e7: [kcminit] Additionally look in kcms/ folder for KCM plugins (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24557?vs=67

D24557: [kcminit] Additionally look in kcms/ folder for KCM plugins

ngraham added a comment. Ah OK REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24557 To: broulik, #plasma Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed,

D24557: [kcminit] Additionally look in kcms/ folder for KCM plugins

broulik added a comment. > What's the harm in looking in kcms/ first, and then if nothing is found, looking ine level below that? As effectively all kcminit KCMs are in the root folder. Once that changes, we can flip it around. REPOSITORY R120 Plasma Workspace REVISION DETAIL https

D24557: [kcminit] Additionally look in kcms/ folder for KCM plugins

ngraham added a comment. We don't have any KCMs that are duplicated in both locations though, right? What's the harm in looking in `kcms/` first, and then if nothing is found, looking ine level below that? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D245

D24557: [kcminit] Additionally look in kcms/ folder for KCM plugins

broulik added a comment. There's more than 80 kcm plugins in the root folder and roughly 30 in the kcms/ folder. I don't think that is feasible at this time, eventually, as we port them, perhaps, but not all at once right now. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://pha

D24557: [kcminit] Additionally look in kcms/ folder for KCM plugins

ngraham added a comment. Nice. Can you make this the preferred path for KCMs, in fact? That would improve life when testing a patch that moves a KCM to the `kcms/` sub-folder. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24557 To: broulik, #plasma Cc: ng

D24543: Set an icon theme for gtk applications in the icons kcm

ngraham added a comment. Nice. We'll also need a patch to remove icon theme configuration from the GTK KCM that depends on this patch so we can land that as soon as this lands. REPOSITORY R119 Plasma Desktop BRANCH gtk-config-icon-theme REVISION DETAIL https://phabricator.kde.org/D245

D24224: Start of the accessibility KCM

tcanabrava added inline comments. INLINE COMMENTS > bport wrote in kcmaccess.h:32-67 > Using KConfigXT will remove lots of boilerplate code (tons of property > declaration + associated methods and easiest, load, save and defaults method). > And with the work done by @ervin on KConfigXT and KQui

D24265: support global edit mode

ngraham added a comment. In D24265#545274 , @mart wrote: > tough i think then it should be there also for pure touch events as well (as opposed to clicks) > > As any change i'll do in plasma is primarly be in the direction of making touch a

D21860: Set a font for gtk applications in the fonts kcm

ngraham added a comment. The idea is to move all the functionality in kde-gtk-config here, then delete it. See the parent Phab task for details. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #plasma, apol, davidedmundson, cfeck Cc: cfeck,

D24454: Include an emoji picker

mart added a comment. In D24454#543079 , @ngraham wrote: > Cool beans. > > Can you make the drawer/sidebar more narrow like we do in Discover? The width is hardcoded in Kirigami to something that's just way too high for this application IMO.

D24454: Include an emoji picker

ngraham added a comment. In D24454#545325 , @mart wrote: > I think entries should have icons and the sidebar be collapsible with just icons Yes that would be nice too. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricat

D24454: Include an emoji picker

ngraham added a comment. How can I test this out? Do I need to have IBus set up? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24454 To: apol, #plasma Cc: ngraham, davidedmundson, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, G

D24224: Start of the accessibility KCM

tcanabrava added a comment. In D24224#545013 , @broulik wrote: > Can you please follow KDE Frameworks coding style Sorry, it was by mistake. I'll fix the style. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.o

D23718: WIP: Beginning of the Baloo/Search KCM Rewrite

This revision was automatically updated to reflect the committed changes. Closed by commit R119:d66bd8f3e9af: WIP: Beginning of the Baloo/Search KCM Rewrite (authored by tcanabrava). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23718?vs=67572&id=67701

D24557: [kcminit] Additionally look in kcms/ folder for KCM plugins

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY All the new QML KCMs have their library in kcms/ subfolder Also improve error reporting a bit by

D24361: [Style KCM] Port to new design

broulik updated this revision to Diff 67699. broulik added a comment. - Remove unrelated change REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24361?vs=67698&id=67699 REVISION DETAIL https://phabricator.kde.org/D24361 AFFECTED FILES kcms/style/

D24361: [Style KCM] Port to new design

broulik updated this revision to Diff 67698. broulik edited the test plan for this revision. broulik added a comment. - Add workaround for QtCurve REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24361?vs=67427&id=67698 REVISION DETAIL https://phabr

D21860: Set a font for gtk applications in the fonts kcm

cfeck added a comment. Please make any GTK stuff optional, not required. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #plasma, apol, davidedmundson Cc: cfeck, davidedmundson, nicolasfella, broulik, GB_2, abetts, ngraham, plasma-devel, LeG

D21860: Set a font for gtk applications in the fonts kcm

broulik added a comment. It wouldn't need to be optional if it was in kde-gtk-config, not plasma-desktop REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D21860 To: gikari, #plasma, apol, davidedmundson, cfeck Cc: cfeck, davidedmundson, nicolasfella, broulik, G

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.12 - Build # 52 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.12/52/ Project: kf5-qt5 SUSEQt5.12 Date of build: Fri, 11 Oct 2019 11:11:27 + Build duration: 8 min 42 sec and counting JUnit Tests Name: (root) Failed:

D24265: support global edit mode

mart added a comment. In D24265#544658 , @ngraham wrote: > In D24265#544549 , @mart wrote: > > > I actually like that a lot, to me is really the click anywhere to dismiss pattern all over the place i

D21860: Set a font for gtk applications in the fonts kcm

gikari updated this revision to Diff 67693. gikari added a comment. - Remove unnecessary include REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21860?vs=67679&id=67693 BRANCH arcpatch-D21860 REVISION DETAIL https://phabricator.kde.org/D21860 A

[Breeze] [Bug 412842] PLYMOUTH Boot splash screen broken after NVIDIA driver install - grey bg 3 green dots

https://bugs.kde.org/show_bug.cgi?id=412842 Harald Sitter changed: What|Removed |Added Status|REPORTED|RESOLVED Resolution|---

D24543: Set an icon theme for gtk applications in the icons kcm

gikari updated this revision to Diff 67689. gikari added a comment. Remove unnesasary comment REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24543?vs=67688&id=67689 BRANCH gtk-config-icon-theme REVISION DETAIL https://phabricator.kde.org/D24543

[Breeze] [Bug 412842] New: PLYMOUTH Boot splash screen broken after NVIDIA driver install - grey bg 3 green dots

https://bugs.kde.org/show_bug.cgi?id=412842 Bug ID: 412842 Summary: PLYMOUTH Boot splash screen broken after NVIDIA driver install - grey bg 3 green dots Product: Breeze Version: 5.16.90 Platform: Other OS:

D24543: Set an icon theme for gtk applications in the icons kcm

gikari updated this revision to Diff 67688. gikari added a comment. Remove empty lines REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24543?vs=67685&id=67688 BRANCH gtk-config-icon-theme REVISION DETAIL https://phabricator.kde.org/D24543 AFFEC

D24523: Disable dragging global drawer when in menu mode

This revision was automatically updated to reflect the committed changes. Closed by commit R169:41de5a4496ae: Disable dragging global drawer when in menu mode (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24523?vs=67575&id=67686

D24543: Set an icon theme for gtk applications in the icons kcm

gikari updated this revision to Diff 67685. gikari added a comment. Add QStiringLiteral around const strings REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24543?vs=67664&id=67685 BRANCH gtk-config-icon-theme REVISION DETAIL https://phabricator

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. @broulik Any other changes needed? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, broulik, ndavis Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ra

D21860: Set a font for gtk applications in the fonts kcm

gikari updated this revision to Diff 67679. gikari added a comment. Remove debug messages and add QStringLiteral around const strings REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D21860?vs=67657&id=67679 BRANCH arcpatch-D21860 REVISION DETAIL

D24543: Set an icon theme for gtk applications in the icons kcm

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Apart from the small nitpick seems good to me. INLINE COMMENTS > configeditor.cpp:51 > using qsp = QStandardPaths; > + > QString > configLocation(qsp::writableLocation(qsp::Generic