D25100: Mark all wallpaper plugins as addons

apol added a comment. > But the distro-provided version (openSUSE Tumbleweed) does not: Yes, this happens because distros don't take plasma-workspace as a dependency, but in your computer you do have plasma-workspace installed. REPOSITORY R114 Plasma Addons REVISION DETAIL

D25100: Mark all wallpaper plugins as addons

ngraham added a comment. In D25100#557494 , @apol wrote: > One thing we could do is update this patch to have `X-KDE-ParentApp=org.kde.plasmashell` instead of the .plasma (which I'm pretty sure it doesn't make a difference, you can check by

D25100: Mark all wallpaper plugins as addons

apol added a comment. I just looked into it, the problem is that `plasma_packagestructure_wallpaper.so` is installed by plasma-workspace, which isn't a dependency of kdeplasma-addons. One thing we could do is update this patch to have `X-KDE-ParentApp=org.kde.plasmashell` instead of

D22967: Let KDBusService deal with the replace option

apol updated this revision to Diff 69146. apol added a comment. rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22967?vs=63186=69146 BRANCH arcpatch-D22967 REVISION DETAIL https://phabricator.kde.org/D22967 AFFECTED FILES

D25100: Mark all wallpaper plugins as addons

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. Yes, it's the wrong fix. For reference, it's not about discover, it's about generating the appstream file properly. Will try to provide a patch next week. REPOSITORY R114

D25100: Mark all wallpaper plugins as addons

davidre added a comment. I don't know how Discover works but to me looks the wrong fix. Does every third party wallpaper then also need to have a name with plasma in it? In my opinion ServiceType Plasma/Wallpaper should be enough for a Service as add-on and not having plasma in it's name.

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 197 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/197/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 31 Oct 2019 22:50:04 + Build duration: 2 min 7 sec and counting CONSOLE OUTPUT

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

This revision was automatically updated to reflect the committed changes. Closed by commit R119:da268696a6af: [Task Manager] Toggle mute when the audio indicator is clicked (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25100: Mark all wallpaper plugins as addons

ngraham added a comment. Hmm so if this is the correct solution to the indicated problem, I guess we would need a kconf update script to change the IDs in `plasma-org.kde.plasma.desktop-appletsrc`? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25100 To:

D25100: Mark all wallpaper plugins as addons

davidedmundson added a comment. What happens if a user has their setup to use potd or hunyango and we change this ID? REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25100 To: ngraham, apol, mak, #plasma Cc: davidedmundson, plasma-devel, LeGast00n,

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

broulik planned changes to this revision. broulik added a comment. Alright, will disable those REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25097 To: broulik, #plasma, #vdg Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas,

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

ngraham added a comment. If there are any settings that have no effect while something else is handling notifications or there's no widget, I think it makes sense to disable those. Other settings that are more universal can stay enabled for sure. REPOSITORY R119 Plasma Desktop REVISION

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

broulik added a comment. > Would it makes sense to also disable all the controls in the KCM when either of these messages are open? I was wondering that, too, but not sure I want to artificially block those settings. Perhaps for the upper check boxes. Progress reporting is unaffected

D25100: Mark all wallpaper plugins as addons

ngraham created this revision. ngraham added reviewers: apol, mak, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Heanau, Hunyango, and POTD wallpaper plugins still show up in Discover as apps because

D24743: Update GTK settings according to Plasma settings

gikari updated this revision to Diff 69141. gikari added a comment. - Transform ConfigEditor to namespace - Make `KSharedConfigPtr`s of kdeglobals and input configs the `ConfigValueProvider` members REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D25082: [applets/weather] Reduce label minimum width to accommodate narrow vertical panels

kossebau resigned from this revision. kossebau added a comment. Sorry, currently no time for Plasma available: see also https://mail.kde.org/pipermail/plasma-devel/2019-October/105088.html REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D25082 To: ngraham,

D25019: Ensure that GlobalDrawer topContent always stays on top

This revision was automatically updated to reflect the committed changes. Closed by commit R169:cae9d9cdbd71: Ensure that GlobalDrawer topContent always stays on top (authored by ngraham). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25019?vs=69116=69139

D25019: Ensure that GlobalDrawer topContent always stays on top

ngraham added a comment. Got confirmation from @notmart in chat that this is good to go. Landing it! REPOSITORY R169 Kirigami BRANCH topContent-always-on-top (branched from master) REVISION DETAIL https://phabricator.kde.org/D25019 To: ngraham, #kirigami, mart, apol, ahiemstra Cc:

D24743: Update GTK settings according to Plasma settings

gikari updated this revision to Diff 69133. gikari marked 8 inline comments as done. gikari edited the summary of this revision. gikari added a comment. - Replace `()` initialization with `=` one - Embrace QStringLiteral madness even more - Rename some variables and method names

D24743: Update GTK settings according to Plasma settings

ngraham added inline comments. INLINE COMMENTS > gikari wrote in configeditor.cpp:49 > Where generally should I use equals sign (`=`), where parenthesis (`()`) and > where braces (`{}`) for initialization? I didn't find any note about that in > coding style

D24743: Update GTK settings according to Plasma settings

gikari added inline comments. INLINE COMMENTS > ervin wrote in configeditor.cpp:49 > Better wrap the const char* in a QStringLiteral. > > Also, but more of a nitpick this time: style wise I'd favor using = for those > initialization (and others in the file) than parenthesis. It gets too close

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

ngraham added a comment. +1 conceptually. Would it makes sense to also disable all the controls in the KCM when either of these messages are open? INLINE COMMENTS > main.qml:56 > +type: Kirigami.MessageType.Error > +text: i18n("Could not find a 'Notifications'

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

GB_2 updated this revision to Diff 69128. GB_2 added a comment. Remove unneeded properties REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19822?vs=69127=69128 BRANCH arcpatch-D19822 REVISION DETAIL https://phabricator.kde.org/D19822 AFFECTED

D19822: [Task Manager] Toggle mute when the audio indicator is clicked

GB_2 updated this revision to Diff 69127. GB_2 added a comment. Move into AudioStream REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D19822?vs=65691=69127 BRANCH arcpatch-D19822 REVISION DETAIL https://phabricator.kde.org/D19822 AFFECTED FILES

D25096: [Digital Clock] Disable custom format input when date option is unchecked

This revision was automatically updated to reflect the committed changes. Closed by commit R120:e477d80bbbc7: [Digital Clock] Disable custom format input when date option is unchecked (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25097: [Notifications KCM] Show hint if notifications aren't available or provided by someone else

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY I've seen people complaining about ugly notification popups when they were in fact running

D25096: [Digital Clock] Disable custom format input when date option is unchecked

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The `ComboBox` was disabled in this case but not the other options. TEST PLAN F7703371:

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

mart added a comment. In D22359#536077 , @ndavis wrote: > In D22359#536055 , @ngraham wrote: > > > Is there any way we can preserve the original goal of using a monochrome icon here for small

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 196 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/196/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 31 Oct 2019 15:38:53 + Build duration: 2 min 15 sec and counting CONSOLE OUTPUT

D25094: Fix reset to defaults in the fonts KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:7b0149c79ea4: Fix reset to defaults in the fonts KCM (authored by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25094?vs=69118=69119 REVISION

D25094: Fix reset to defaults in the fonts KCM

ervin created this revision. ervin added reviewers: Plasma, bport, davidedmundson, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY Turns out one of the properties was utterly broken emitting the wrong

D25091: [Digital Clock] Add preview for date format

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6671c13d4cb6: [Digital Clock] Add preview for date format (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25091?vs=69104=69117

D25019: Ensure that GlobalDrawer topContent always stays on top

ngraham marked an inline comment as done. ngraham added inline comments. INLINE COMMENTS > ahiemstra wrote in GlobalDrawer.qml:370 > We **really** should fix scrollview's scrollbars... See https://phabricator.kde.org/T9126. I *really* dislike overlay scrollbars, both in terms of utility and

D25019: Ensure that GlobalDrawer topContent always stays on top

ngraham updated this revision to Diff 69116. ngraham marked 3 inline comments as done. ngraham added a comment. Address review comments REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25019?vs=68920=69116 BRANCH topContent-always-on-top (branched from

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 195 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/195/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 31 Oct 2019 15:02:42 + Build duration: 2 min 6 sec and counting CONSOLE OUTPUT

D25055: [containments/desktop] Delete the "Tweaks" page and its options

This revision was automatically updated to reflect the committed changes. Closed by commit R119:69d649e5aab4: [containments/desktop] Delete the Tweaks page and its options (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25055: [containments/desktop] Delete the "Tweaks" page and its options

ngraham added a comment. Thanks for your flexibility, @mart. :) REPOSITORY R119 Plasma Desktop BRANCH delete-tweaks-page (branched from master) REVISION DETAIL https://phabricator.kde.org/D25055 To: ngraham, mart, GB_2, #plasma, hein Cc: fabianr, broulik, plasma-devel, LeGast00n,

D25093: ksmserver: remove unused explicit dependency to Phonon

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ae130775e865: ksmserver: remove unused explicit dependency to Phonon (authored by apol). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D24945: [ksmserver] Signal session management state to kwin directly

broulik added inline comments. INLINE COMMENTS > logout.cpp:194 > + > +auto reply = m_kwinInterface->setState(KWinSessionState::Saving); > +// we don't need to block as we wait for kwin to handle it's session 1 `reply` isn't actually used, remove? REPOSITORY R120 Plasma Workspace

D24945: [ksmserver] Signal session management state to kwin directly

davidedmundson updated this revision to Diff 69112. davidedmundson added a comment. Update to enum REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24945?vs=69111=69112 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24945 AFFECTED

D24945: [ksmserver] Signal session management state to kwin directly

davidedmundson updated this revision to Diff 69111. davidedmundson added a comment. update to enum REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24945?vs=68751=69111 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24945 AFFECTED

D25093: ksmserver: remove unused explicit dependency to Phonon

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. thanks REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D25093 To: apol, #plasma, davidedmundson Cc: davidedmundson,

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 194 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/194/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 31 Oct 2019 14:18:24 + Build duration: 2 min 59 sec and counting CONSOLE OUTPUT

D24701: Notify about change after cursor config is saved

This revision was automatically updated to reflect the committed changes. Closed by commit R119:cf7254a70f01: Notify about change after cursor config is saved (authored by gikari, committed by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25055: [containments/desktop] Delete the "Tweaks" page and its options

fabianr added a comment. I would In D25055#557216 , @hein wrote: > If we want to keep the handles-on-hover outside of Edit Mode, is there a reason it can't be always on and needs to be gated behind a checkbox? > > I have to admit though

D25055: [containments/desktop] Delete the "Tweaks" page and its options

ngraham added a comment. In D25055#557216 , @hein wrote: > I have to admit though I have a hard time seeing users like/rely on this behavior. Hovering and just waiting, even once you've learned it's possible, is always going to be an

D25093: ksmserver: remove unused explicit dependency to Phonon

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY It may be used through KNotifications TEST PLAN Builds REPOSITORY R120 Plasma Workspace BRANCH

D25055: [containments/desktop] Delete the "Tweaks" page and its options

hein added a comment. If we want to keep the handles-on-hover outside of Edit Mode, is there a reason it can't be always on and needs to be gated behind a checkbox? I have to admit though I have a hard time seeing users like/rely on this behavior. Hovering and just waiting, even once

D25086: [WIP] Port to KGlobalAccel

davidre added inline comments. INLINE COMMENTS > globalaccel.cpp:50 > + > +QKeySequence GlobalAccel::getMenuEntryShortcut(const QString ) > +{ I think the list that is returned can have up to 2 entries. The shortcut and the alternate shortcut. However the currently Gui shows/configures only

D25055: [containments/desktop] Delete the "Tweaks" page and its options

ngraham added a comment. Ahh, I wasn't hovering for long enough. I see it now. After finally understanding and using this feature, I really think we should discard it. Actually explaining it in the UI in a way that would make it comprehensible would require an incredibly wordy checkbox

D25086: [WIP] Port to KGlobalAccel

apol added inline comments. INLINE COMMENTS > globalaccel.cpp:50 > + > +QKeySequence GlobalAccel::getMenuEntryShortcut(const QString ) > +{ Why just return one if it can be a list? > globalaccel.h:27 > +public: > +static QKeySequence getMenuEntryShortcut(const QString ); > +static void

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 193 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/193/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 31 Oct 2019 13:16:16 + Build duration: 3 min 38 sec and counting CONSOLE OUTPUT

D25019: Ensure that GlobalDrawer topContent always stays on top

ahiemstra added inline comments. INLINE COMMENTS > GlobalDrawer.qml:241 > > -rightPadding: !Settings.isMobile && mainFlickable.contentHeight > > mainFlickable.height ? Units.gridUnit : Units.smallSpacing > +leftPadding: 0 > +rightPadding: 0 +1 for getting rid of these paddings.

D25045: kimpanel: don't crash when ibus is already loaded

This revision was automatically updated to reflect the committed changes. Closed by commit R119:299f298d168f: kimpanel: dont crash when ibus is already loaded (authored by apol). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25045?vs=68980=69108

D25086: [WIP] Port to KGlobalAccel

davidre updated this revision to Diff 69107. davidre marked 4 inline comments as done. davidre added a comment. - comments REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25086?vs=69105=69107 BRANCH globalaccel (branched from master) REVISION

D25086: [WIP] Port to KGlobalAccel

mlaurent added inline comments. INLINE COMMENTS > globalaccel.cpp:55 > +const QList shortcut = > KGlobalAccel::self()->globalShortcut(desktopFile, QStringLiteral("_launch")); > +if (shortcut.size() > 0) { > +return shortcut[0]; if (!shortcut.isEmpty()) { > menuinfo.cpp:180 >

D25086: [WIP] Port to KGlobalAccel

davidre marked an inline comment as done. davidre added inline comments. INLINE COMMENTS > mlaurent wrote in CMakeLists.txt:39 > Why removing it ? Accidentally REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D25086 To: davidre, #plasma, davidedmundson, mlaurent

D25086: [WIP] Port to KGlobalAccel

davidre updated this revision to Diff 69105. davidre added a comment. - Don't delete disabled - Remove guards REPOSITORY R103 KMenu Editor CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25086?vs=69095=69105 BRANCH globalaccel (branched from master) REVISION DETAIL

D25091: [Digital Clock] Add preview for date format

broulik created this revision. broulik added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Especially for the custom one it's useful to have a live preview rather than trial and error

D25090: kcm/fonts: Do not load image preview before loading settings

bshah created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY The way image preview works is it tries to actually "set" and then "reset" the original value to render the text. However if we

D25089: Use X-KDE-NoGlobalShortcut to read that an app has shorcuts disable

meven added a comment. In D25089#557130 , @davidedmundson wrote: > Can you tell me which .desktops files are going to be using this flag, I don't think I follow so far. The ones installed in `${DATA_INSTALL_DIR}/kglobalaccel` for the

D25086: [WIP] Port to KGlobalAccel

mlaurent added inline comments. INLINE COMMENTS > CMakeLists.txt:39 > -find_package(KHotKeysDBusInterface QUIET) > -if (EXISTS "${CMAKE_SOURCE_DIR}/.git") > - add_definitions(-DQT_DISABLE_DEPRECATED_BEFORE=0x06) Why removing it ? REPOSITORY R103 KMenu Editor REVISION DETAIL

D25089: Use X-KDE-NoGlobalShortcut to read that an app has shorcuts disable

davidedmundson added a comment. Can you tell me which .desktops files are going to be using this flag, I don't think I follow so far. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25089 To: meven, #plasma, apol, broulik Cc: davidedmundson, plasma-devel,

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 192 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/192/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 31 Oct 2019 11:52:42 + Build duration: 1 min 49 sec and counting CONSOLE OUTPUT

D25081: [kcms/krdb] Fix krdb executable

This revision was automatically updated to reflect the committed changes. Closed by commit R119:3a6dc8c07617: [kcms/krdb] Fix krdb executable (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25081?vs=69068=69100 REVISION

D25089: Use X-KDE-NoGlobalShortcut to read that an app has shorcuts disable

meven created this revision. meven added reviewers: Plasma, apol, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY A Drawback with the current patch is that it will loose previous set preferences.

D25048: Expose libkworkspace SessionManagement class to QML

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fb5f9bd1012c: Expose libkworkspace SessionManagement class to QML (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D25086: [WIP] Port to KGlobalAccel

davidedmundson added a comment. Concept We don't need WITH_GLOBALACCEL guards. It's a dep of kxmlgui which we link against anyway. REPOSITORY R103 KMenu Editor REVISION DETAIL https://phabricator.kde.org/D25086 To: davidre, #plasma, davidedmundson Cc: plasma-devel, LeGast00n,

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 191 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/191/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 31 Oct 2019 10:44:56 + Build duration: 3 min 44 sec and counting CONSOLE OUTPUT

D25086: [WIP] Port to KGlobalAccel

davidre created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY Replace KHotkeys with KGlobalAccel WIP because of missing migration REPOSITORY R103 KMenu Editor BRANCH globalaccel

D24848: fix kcm fonts "typo" on connect

This revision was automatically updated to reflect the committed changes. Closed by commit R119:08a8914d7169: fix kcm fonts typo on connect (authored by bport, committed by ervin). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24848?vs=68500=69094

D25000: Do not assign combobox currentIndex as it breaks binding.

This revision was automatically updated to reflect the committed changes. Closed by commit R858:35fae4b55fc8: Do not assign combobox currentIndex as it breaks binding. (authored by crossi). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE

D25055: [containments/desktop] Delete the "Tweaks" page and its options

mart added a comment. In D25055#556797 , @ngraham wrote: > In D25055#556755 , @mart wrote: > > > In D25055#556752 , @ngraham wrote: > > > > > In

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 190 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/190/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 31 Oct 2019 10:02:26 + Build duration: 3 min 30 sec and counting CONSOLE OUTPUT

D24917: KCM Style port to KConfigXT

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fbed4b3efcdb: KCM Style port to KConfigXT (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24917?vs=68978=69089 REVISION DETAIL

D24925: KCM KSplash port to ManagedConfigModule

This revision was automatically updated to reflect the committed changes. Closed by commit R119:332226003b04: KCM KSplash port to ManagedConfigModule (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24925?vs=68734=69090 REVISION

D24916: KCM style : fix combobox that weren't updated after user made change

crossi abandoned this revision. crossi added a comment. Fix by D25000 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D24916 To: crossi, #plasma, ervin, mart, bport Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D24918: Fix issue when there is no WidgetStyle value in kdeglobals

This revision was automatically updated to reflect the committed changes. Closed by commit R135:9313c877f55f: Fix issue when there is no WidgetStyle value in kdeglobals (authored by crossi). REPOSITORY R135 Integration for Qt applications in Plasma CHANGES SINCE LAST UPDATE

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 55 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/55/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 31 Oct 2019 09:17:01 + Build duration: 7 min 26 sec and counting JUnit Tests

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.13 - Build # 189 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.13/189/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 31 Oct 2019 09:17:01 + Build duration: 3 min 10 sec and counting CONSOLE OUTPUT

D25047: [Night Color KCM] Reset seconds and milliseconds in provided timings

This revision was automatically updated to reflect the committed changes. Closed by commit R119:59e3003943da: [Night Color KCM] Reset seconds and milliseconds in provided timings (authored by zzag). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D25000: Do not assign combobox currentIndex as it breaks binding.

crossi added inline comments. INLINE COMMENTS > davidedmundson wrote in kpropertywriter_p.h:26 > Throwing out another option > > class KPropertyWriter : public QObject, public QQmlPropertyValueSource > { > Q_INVOKABLE bool writeProperty(QVariant value); > } > >

KDE CI: Plasma » plasma-workspace-wallpapers » kf5-qt5 FreeBSDQt5.13 - Build # 14 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-workspace-wallpapers/job/kf5-qt5%20FreeBSDQt5.13/14/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Thu, 31 Oct 2019 04:35:48 + Build duration: 2 hr 32 min and counting CONSOLE OUTPUT