D25147: Remove gtkrc-2.0 legacy settings

[Kevin Ottens]

ervin added a comment.


  FWIW, LGTM as well, agree with Nate that it likely requires some more 
extensive testing though.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  remove-legacy-gtkrc-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25147

To: gikari, cblack, #plasma, apol
Cc: ervin, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> kglobalshortcutseditor.cpp:436
> +// Do we have an application with that name?
> +KService::List apps = 
> KServiceTypeTrader::self()->query(QStringLiteral("Application"),
> +QStringLiteral("Name == '%1' or Name == 
> '%2'").arg(id,  friendlyName));

const KService::List

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25144

To: davidre, #plasma, mlaurent
Cc: mlaurent, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24068: docs: add contributing guide

[Roman Gilg]

romangg added a comment.


  In D24068#558466 , @davidedmundson 
wrote:
  
  > README is really good.
  >
  > Did you email kde-devel about this commit policy? I thought you did, but I 
can't find it. 
  >  As someone who regularly commits across many many repos if every 
maintainer enforced their own thing I would really struggle.
  
  
  Thanks, I have emailed 
 
about the general policy this one is based on. Since there is no other one at 
the moment I don't see the need to ask again. It would be a rather theoretical 
discussion. Should a second one come around we can align them then.

INLINE COMMENTS

> davidedmundson wrote in CONTRIBUTING.md:68
> What's a BREAKING CHANGE in relation to a UI?
> 
> configs breaking and being unusable or just a button having new text?

I understand it only for API or config breaks, not behavioral changes if there 
is a clean migration path and the user just have to learn a new workflow.

Since I felt it to be somewhat vague or maybe not applicable to all our apps I 
made it less formal here and only recommend it as prose in the commit body.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24068

To: romangg, #plasma
Cc: davidedmundson, yurchor, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 254 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/254/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 05 Nov 2019 04:34:47 +
 Build duration:
4 min 14 sec and counting
   CONSOLE OUTPUT
  [...truncated 486 lines...][2019-11-05T04:39:00.200Z] Call Stack (most recent call first):[2019-11-05T04:39:00.200Z]   effects/CMakeLists.txt:140 (kpackage_install_package)[2019-11-05T04:39:00.200Z]   effects/CMakeLists.txt:154 (install_scripted_effect)[2019-11-05T04:39:00.200Z] [2019-11-05T04:39:00.200Z] [2019-11-05T04:39:00.200Z] CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:74 (message):[2019-11-05T04:39:00.200Z]   KPackage components should be specified in reverse domain notation.[2019-11-05T04:39:00.200Z]   Appstream information won't be generated for kwin4_effect_morphingpopups.[2019-11-05T04:39:00.200Z] Call Stack (most recent call first):[2019-11-05T04:39:00.200Z]   effects/CMakeLists.txt:140 (kpackage_install_package)[2019-11-05T04:39:00.200Z]   effects/CMakeLists.txt:155 (install_scripted_effect)[2019-11-05T04:39:00.200Z] [2019-11-05T04:39:00.200Z] [2019-11-05T04:39:00.200Z] CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:74 (message):[2019-11-05T04:39:00.200Z]   KPackage components should be specified in reverse domain notation.[2019-11-05T04:39:00.200Z]   Appstream information won't be generated for kwin4_effect_scale.[2019-11-05T04:39:00.200Z] Call Stack (most recent call first):[2019-11-05T04:39:00.200Z]   effects/CMakeLists.txt:140 (kpackage_install_package)[2019-11-05T04:39:00.200Z]   effects/CMakeLists.txt:156 (install_scripted_effect)[2019-11-05T04:39:00.200Z] [2019-11-05T04:39:00.200Z] [2019-11-05T04:39:00.200Z] CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:74 (message):[2019-11-05T04:39:00.200Z]   KPackage components should be specified in reverse domain notation.[2019-11-05T04:39:00.200Z]   Appstream information won't be generated for kwin4_effect_squash.[2019-11-05T04:39:00.200Z] Call Stack (most recent call first):[2019-11-05T04:39:00.200Z]   effects/CMakeLists.txt:140 (kpackage_install_package)[2019-11-05T04:39:00.200Z]   effects/CMakeLists.txt:157 (install_scripted_effect)[2019-11-05T04:39:00.200Z] [2019-11-05T04:39:00.200Z] [2019-11-05T04:39:00.200Z] CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:74 (message):[2019-11-05T04:39:00.200Z]   KPackage components should be specified in reverse domain notation.[2019-11-05T04:39:00.200Z]   Appstream information won't be generated for kwin4_effect_translucency.[2019-11-05T04:39:00.200Z] Call Stack (most recent call first):[2019-11-05T04:39:00.200Z]   effects/CMakeLists.txt:140 (kpackage_install_package)[2019-11-05T04:39:00.200Z]   effects/CMakeLists.txt:158 (install_scripted_effect)[2019-11-05T04:39:00.200Z] [2019-11-05T04:39:00.200Z] [2019-11-05T04:39:00.200Z] CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:74 (message):[2019-11-05T04:39:00.200Z]   KPackage components should be specified in reverse domain notation.[2019-11-05T04:39:00.200Z]   Appstream information won't be generated for kwin4_effect_windowaperture.[2019-11-05T04:39:00.200Z] Call Stack (most recent call first):[2019-11-05T04:39:00.200Z]   effects/CMakeLists.txt:140 (kpackage_install_package)[2019-11-05T04:39:00.200Z]   effects/CMakeLists.txt:159 (install_scripted_effect)[2019-11-05T04:39:00.200Z] [2019-11-05T04:39:00.200Z] [2019-11-05T04:39:00.200Z] CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:74 (message):[2019-11-05T04:39:00.200Z]   KPackage components should be specified in reverse domain notation.[2019-11-05T04:39:00.200Z]   Appstream information won't be generated for kwin4_effect_sessionquit.[2019-11-05T04:39:00.200Z] Call Stack (most recent call first):[2019-11-05T04:39:00.200Z]   effects/CMakeLists.txt:140 (kpackage_install_package)[2019-11-05T04:39:00.200Z]   effects/CMakeLists.txt:160 (install_scripted_effect)[2019-11-05T04:39:00.200Z] [2019-11-05T04:39:00.200Z] [2019-11-05T04:39:00.457Z] CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:74 (message):[2019-11-05T04:39:00.457Z]   KPackage components should be specified in reverse domain notation.[2019-11-05T04:39:00.457Z]   Appstream information won't be generated for videowall.[2019-11-05T04:39:00.457Z] Call Stack (most recent call first):[2019-11-05T04:39:00.457Z]   scripts/CMakeLists.txt:2 (kpackage_install_package)[2019-11-05T04:39:00.457Z]   scripts/CMakeLists.txt:9 (add_kwin_script)[2019-11-05T04:39:00.457Z] [2019-11-05T04:39:00.457Z] [2019-11-05T04:39:00.457Z] CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:74 (message):[2019-11-05T04:39:00.457Z]   KPackage compo

D25150: [Icon View] Don't use dialog-warning emblem on icon when KCM requires authentication

[Filip Fila]

filipf added a comment.


  In D25150#558758 , @ngraham wrote:
  
  > I think so. This is a bugfix.
  
  
  OK, I'll land this there then (once the repo gets unbroken).

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25150

To: filipf, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 112 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/112/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 05 Nov 2019 00:02:10 +
 Build duration:
58 sec and counting
   CONSOLE OUTPUT
  [...truncated 340 lines...][2019-11-05T00:03:02.437Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/systemsettings/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for systemsettings.[2019-11-05T00:03:02.437Z] -- Found KF5Declarative: /home/jenkins/install-prefix/lib64/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.64.0") [2019-11-05T00:03:02.437Z] -- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.64.0") [2019-11-05T00:03:02.437Z] -- Found KF5ActivitiesStats: /home/jenkins/install-prefix/lib64/cmake/KF5ActivitiesStats/KF5ActivitiesStatsConfig.cmake (found version "5.64.0") [2019-11-05T00:03:02.997Z] -- qmlplugindump failed for org.kde.kcm.[2019-11-05T00:03:02.997Z] -- Could NOT find org.kde.kcm-QMLModule (missing: org.kde.kcm-QMLModule_FOUND) [2019-11-05T00:03:02.997Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2019-11-05T00:03:03.273Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2019-11-05T00:03:03.273Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2019-11-05T00:03:03.530Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2019-11-05T00:03:03.530Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-11-05T00:03:03.530Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2019-11-05T00:03:03.785Z] -- The following OPTIONAL packages have been found:[2019-11-05T00:03:03.785Z] [2019-11-05T00:03:03.785Z]  * KF5Completion (required version >= 5.63.0)[2019-11-05T00:03:03.785Z]  * KF5JobWidgets (required version >= 5.63.0)[2019-11-05T00:03:03.785Z]  * KF5Solid (required version >= 5.63.0)[2019-11-05T00:03:03.785Z]  * KF5Auth (required version >= 5.63.0)[2019-11-05T00:03:03.785Z]  * KF5Codecs (required version >= 5.63.0)[2019-11-05T00:03:03.785Z]  * KF5ConfigWidgets (required version >= 5.63.0)[2019-11-05T00:03:03.785Z]  * KF5CoreAddons (required version >= 5.63.0)[2019-11-05T00:03:03.785Z] [2019-11-05T00:03:03.785Z] -- The following REQUIRED packages have been found:[2019-11-05T00:03:03.785Z] [2019-11-05T00:03:03.785Z]  * Qt5Gui (required version >= 5.12.5)[2019-11-05T00:03:03.785Z]  * Qt5Qml[2019-11-05T00:03:03.785Z]  * Qt5QuickWidgets[2019-11-05T00:03:03.785Z]  * Qt5 (required version >= 5.11.0)[2019-11-05T00:03:03.785Z]  * KF5Crash (required version >= 5.62.0)[2019-11-05T00:03:03.785Z]  * KF5KCMUtils (required version >= 5.62.0)[2019-11-05T00:03:03.785Z]  * Gettext[2019-11-05T00:03:03.785Z]  * KF5I18n (required version >= 5.62.0)[2019-11-05T00:03:03.785Z]  * KF5ItemViews (required version >= 5.63.0)[2019-11-05T00:03:03.785Z]  * Qt5Network (required version >= 5.11.0)[2019-11-05T00:03:03.785Z]  * KF5KIO (required version >= 5.62.0)[2019-11-05T00:03:03.785Z]  * KF5Service (required version >= 5.62.0)[2019-11-05T00:03:03.785Z]  * KF5IconThemes (required version >= 5.62.0)[2019-11-05T00:03:03.785Z]  * KF5WindowSystem (required version >= 5.62.0)[2019-11-05T00:03:03.785Z]  * Qt5Widgets (required version >= 5.11.0)[2019-11-05T00:03:03.785Z]  * KF5WidgetsAddons (required version >= 5.63.0)[2019-11-05T00:03:03.785Z]  * KF5XmlGui (required version >= 5.62.0)[2019-11-05T00:03:03.785Z]  * KF5DBusAddons (required version >= 5.62.0)[2019-11-05T00:03:03.785Z]  * KF5DocTools (required version >= 5.62.0)[2019-11-05T00:03:03.785Z]  * Qt5Quick (required version >= 5.11.0)[2019-11-05T00:03:03.785Z]  * ECM (required version >= 1.6.0)[2019-11-05T00:03:03.785Z]  * KF5Package (required version >= 5.63.0)[2019-11-05T00:03:03.785Z]  * KF5Declarative (required version >= 5.62.0)[2019-11-05T00:03:03.785Z]  * KF5Activities (required version >= 5.62.0)[2019-11-05T00:03:03.785Z]  * KF5ActivitiesStats (required version >= 5.62.0)[2019-11-05T00:03:03.785Z]  * KF5 (required version >= 5.62.0)[2019-11-05T00:03:03.785Z]  * KF5Kirigami2 (required version >= 2.1)[2019-11-05T00:03:03.785Z]  * Qt5Core (required version >= 5.12.0)[2019-11-05T00:03:03.785Z]  * LibKWorkspace (required version >= 5.17.80)[2019-11-05T00:03:03.785Z] [2019-11-05T00:03:03.785Z] -- The following RUNTIME packages have not been found:[2019-11-05T00:03:03.785Z] [2019-11-05T00:03:03.785Z]  * org.kde.kcm-QMLModule, QML module 'org.kde.kcm' is a runtime dependency.[2019-11-05T00:03:03.785Z] [2019-11-05T00:03:03.785Z] -- Configuring done[2019-11-05T00:03:03.785Z] -- Generating done[2019-11-05T00:03:03.785Z] -- Build files have been written to: /home/jenkins/workspace/Plasma/systemsettings/kf5-qt5 SUSEQt5.12/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2019-11-05T00:03:05.362Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project systemsettings --bra

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.13/75/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 05 Nov 2019 00:02:09 +
 Build duration:
50 sec and counting
   CONSOLE OUTPUT
  [...truncated 268 lines...][2019-11-05T00:02:51.506Z] -- Found KF5IconThemes: /usr/home/jenkins/install-prefix/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.64.0") [2019-11-05T00:02:51.506Z] -- Found KF5WidgetsAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5WidgetsAddons/KF5WidgetsAddonsConfig.cmake (found version "5.64.0") [2019-11-05T00:02:51.506Z] -- Found KF5WindowSystem: /usr/home/jenkins/install-prefix/lib/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.64.0") [2019-11-05T00:02:51.506Z] -- Found KF5XmlGui: /usr/home/jenkins/install-prefix/lib/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.64.0") [2019-11-05T00:02:51.506Z] -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.64.0") [2019-11-05T00:02:51.506Z] -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.64.0") [2019-11-05T00:02:51.506Z] -- Found KF5DocTools: /usr/home/jenkins/install-prefix/lib/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.64.0") [2019-11-05T00:02:51.506Z] Installing in /home/jenkins/install-prefix. Run /usr/home/jenkins/workspace/Plasma/systemsettings/kf5-qt5 FreeBSDQt5.13/build/prefix.sh to set the environment for systemsettings.[2019-11-05T00:02:51.506Z] -- Found KF5Package: /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageConfig.cmake (found version "5.64.0") [2019-11-05T00:02:51.506Z] -- Found KF5Declarative: /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.64.0") [2019-11-05T00:02:51.506Z] -- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.64.0") [2019-11-05T00:02:51.506Z] -- Found KF5ActivitiesStats: /usr/home/jenkins/install-prefix/lib/cmake/KF5ActivitiesStats/KF5ActivitiesStatsConfig.cmake (found version "5.64.0") [2019-11-05T00:02:52.881Z] -- qmlplugindump failed for org.kde.kcm.[2019-11-05T00:02:52.881Z] -- Could NOT find org.kde.kcm-QMLModule (missing: org.kde.kcm-QMLModule_FOUND) [2019-11-05T00:02:52.881Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2019-11-05T00:02:52.881Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2019-11-05T00:02:52.881Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2019-11-05T00:02:53.136Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2019-11-05T00:02:53.136Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-11-05T00:02:53.136Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2019-11-05T00:02:53.391Z] -- The following OPTIONAL packages have been found:[2019-11-05T00:02:53.391Z] [2019-11-05T00:02:53.391Z]  * Qt5Core[2019-11-05T00:02:53.391Z] [2019-11-05T00:02:53.391Z] -- The following REQUIRED packages have been found:[2019-11-05T00:02:53.391Z] [2019-11-05T00:02:53.391Z]  * Qt5Gui (required version >= 5.13.0)[2019-11-05T00:02:53.391Z]  * Qt5Widgets[2019-11-05T00:02:53.391Z]  * Qt5Network (required version >= 5.13.0)[2019-11-05T00:02:53.391Z]  * Qt5Quick[2019-11-05T00:02:53.391Z]  * Qt5Qml[2019-11-05T00:02:53.391Z]  * Qt5QuickWidgets[2019-11-05T00:02:53.391Z]  * Qt5 (required version >= 5.11.0)[2019-11-05T00:02:53.391Z]  * KF5Crash (required version >= 5.62.0)[2019-11-05T00:02:53.391Z]  * KF5ItemViews (required version >= 5.62.0)[2019-11-05T00:02:53.391Z]  * KF5KCMUtils (required version >= 5.62.0)[2019-11-05T00:02:53.391Z]  * Gettext[2019-11-05T00:02:53.391Z]  * KF5I18n (required version >= 5.62.0)[2019-11-05T00:02:53.391Z]  * KF5KIO (required version >= 5.62.0)[2019-11-05T00:02:53.391Z]  * KF5Service (required version >= 5.62.0)[2019-11-05T00:02:53.391Z]  * KF5IconThemes (required version >= 5.62.0)[2019-11-05T00:02:53.391Z]  * KF5WidgetsAddons (required version >= 5.62.0)[2019-11-05T00:02:53.391Z]  * KF5WindowSystem (required version >= 5.62.0)[2019-11-05T00:02:53.391Z]  * KF5XmlGui (required version >= 5.62.0)[2019-11-05T00:02:53.391Z]  * KF5DBusAddons (required version >= 5.62.0)[2019-11-05T00:02:53.391Z]  * KF5Config (required version >= 5.62.0)[2019-11-05T00:02:53.392Z]  * KF5DocTools (required version >= 5.62.0)[2019-11-05T00:02:53.392Z]  * ECM (required version >= 1.6.0)[2019-11-05T00:02:53.392Z]  * KF5Package (required version >= 5.62.0)[2019-11-05T00:02:53.392Z]  * KF5Declarative (required version >= 5.62.0)[2019-11-05T00:02:53.392Z]  * KF5Activities (required version >= 5.62.0)[2019-11-05T00:02:53.392Z]  * KF5ActivitiesStats (required version >= 5.62.0)[2019-11-05T00:02:53.392Z]  * KF5 (required version >= 5.62.0)[2019-11-05T00:02:53.392Z]  * KF5Kirigami2 (required version >= 2.1)[2019-11-05T00

D25150: [Icon View] Don't use dialog-warning emblem on icon when KCM requires authentication

[Nathaniel Graham]

ngraham added a comment.


  I think so. This is a bugfix.

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25150

To: filipf, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 253 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/253/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 04 Nov 2019 23:45:08 +
 Build duration:
54 sec and counting
   CONSOLE OUTPUT
  [...truncated 484 lines...][2019-11-04T23:46:01.932Z] Call Stack (most recent call first):[2019-11-04T23:46:01.932Z]   effects/CMakeLists.txt:140 (kpackage_install_package)[2019-11-04T23:46:01.932Z]   effects/CMakeLists.txt:154 (install_scripted_effect)[2019-11-04T23:46:01.932Z] [2019-11-04T23:46:01.932Z] [2019-11-04T23:46:01.932Z] CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:74 (message):[2019-11-04T23:46:01.932Z]   KPackage components should be specified in reverse domain notation.[2019-11-04T23:46:01.932Z]   Appstream information won't be generated for kwin4_effect_morphingpopups.[2019-11-04T23:46:01.932Z] Call Stack (most recent call first):[2019-11-04T23:46:01.932Z]   effects/CMakeLists.txt:140 (kpackage_install_package)[2019-11-04T23:46:01.932Z]   effects/CMakeLists.txt:155 (install_scripted_effect)[2019-11-04T23:46:01.932Z] [2019-11-04T23:46:01.932Z] [2019-11-04T23:46:01.932Z] CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:74 (message):[2019-11-04T23:46:01.932Z]   KPackage components should be specified in reverse domain notation.[2019-11-04T23:46:01.932Z]   Appstream information won't be generated for kwin4_effect_scale.[2019-11-04T23:46:01.932Z] Call Stack (most recent call first):[2019-11-04T23:46:01.932Z]   effects/CMakeLists.txt:140 (kpackage_install_package)[2019-11-04T23:46:01.932Z]   effects/CMakeLists.txt:156 (install_scripted_effect)[2019-11-04T23:46:01.932Z] [2019-11-04T23:46:01.932Z] [2019-11-04T23:46:01.932Z] CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:74 (message):[2019-11-04T23:46:01.932Z]   KPackage components should be specified in reverse domain notation.[2019-11-04T23:46:01.932Z]   Appstream information won't be generated for kwin4_effect_squash.[2019-11-04T23:46:01.932Z] Call Stack (most recent call first):[2019-11-04T23:46:01.932Z]   effects/CMakeLists.txt:140 (kpackage_install_package)[2019-11-04T23:46:01.932Z]   effects/CMakeLists.txt:157 (install_scripted_effect)[2019-11-04T23:46:01.932Z] [2019-11-04T23:46:01.932Z] [2019-11-04T23:46:01.932Z] CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:74 (message):[2019-11-04T23:46:01.932Z]   KPackage components should be specified in reverse domain notation.[2019-11-04T23:46:01.932Z]   Appstream information won't be generated for kwin4_effect_translucency.[2019-11-04T23:46:01.932Z] Call Stack (most recent call first):[2019-11-04T23:46:01.932Z]   effects/CMakeLists.txt:140 (kpackage_install_package)[2019-11-04T23:46:01.932Z]   effects/CMakeLists.txt:158 (install_scripted_effect)[2019-11-04T23:46:01.932Z] [2019-11-04T23:46:01.932Z] [2019-11-04T23:46:01.932Z] CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:74 (message):[2019-11-04T23:46:01.932Z]   KPackage components should be specified in reverse domain notation.[2019-11-04T23:46:01.932Z]   Appstream information won't be generated for kwin4_effect_windowaperture.[2019-11-04T23:46:01.932Z] Call Stack (most recent call first):[2019-11-04T23:46:01.932Z]   effects/CMakeLists.txt:140 (kpackage_install_package)[2019-11-04T23:46:01.932Z]   effects/CMakeLists.txt:159 (install_scripted_effect)[2019-11-04T23:46:01.932Z] [2019-11-04T23:46:01.932Z] [2019-11-04T23:46:01.932Z] CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:74 (message):[2019-11-04T23:46:01.932Z]   KPackage components should be specified in reverse domain notation.[2019-11-04T23:46:01.932Z]   Appstream information won't be generated for kwin4_effect_sessionquit.[2019-11-04T23:46:01.932Z] Call Stack (most recent call first):[2019-11-04T23:46:01.932Z]   effects/CMakeLists.txt:140 (kpackage_install_package)[2019-11-04T23:46:01.932Z]   effects/CMakeLists.txt:160 (install_scripted_effect)[2019-11-04T23:46:01.932Z] [2019-11-04T23:46:01.932Z] [2019-11-04T23:46:01.932Z] CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:74 (message):[2019-11-04T23:46:01.932Z]   KPackage components should be specified in reverse domain notation.[2019-11-04T23:46:01.932Z]   Appstream information won't be generated for videowall.[2019-11-04T23:46:01.932Z] Call Stack (most recent call first):[2019-11-04T23:46:01.932Z]   scripts/CMakeLists.txt:2 (kpackage_install_package)[2019-11-04T23:46:01.932Z]   scripts/CMakeLists.txt:9 (add_kwin_script)[2019-11-04T23:46:01.932Z] [2019-11-04T23:46:01.932Z] [2019-11-04T23:46:01.932Z] CMake Warning at /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageMacros.cmake:74 (message):[2019-11-04T23:46:01.932Z]   KPackage components 

D25150: [Icon View] Don't use dialog-warning emblem on icon when KCM requires authentication

[Filip Fila]

filipf added a comment.


  Would this be an acceptable change for the 5.17 branch?

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25150

To: filipf, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25150: [Icon View] Don't use dialog-warning emblem on icon when KCM requires authentication

[Filip Fila]

filipf added a comment.


  Might also be worth mentioning this now makes it consistent with sidebar 
view, which doesn't use this emblem.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D25150

To: filipf, #vdg, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25150: [Icon View] Don't use dialog-warning emblem on icon when KCM requires authentication

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Icon view currently sets a dialog-warning emblem on the sidebar icons for 
KCMs that require root authentication (SDDM, KDE Wallet).
  
  This overlay is both confusing and unecessary given that we already spell it 
out in big letters in the KCM header that we'll be asking for authentication.
  
  This patch removes the icon overlay.

REPOSITORY
  R124 System Settings

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25150

AFFECTED FILES
  core/ModuleView.cpp

To: filipf
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25147: Remove gtkrc-2.0 legacy settings

[Nathaniel Graham]

ngraham added a comment.


  Presumably 5.17 bugfix material assuming we can test it well enough. @apol, 
does this look sane to you as well?

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  remove-legacy-gtkrc-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25147

To: gikari, cblack, #plasma, apol
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

[Nathaniel Graham]

ngraham added a comment.


  Oh I see lol. Well I guess my only complaint is with the name chosen for the 
Plasma category.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25144

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25147: Remove gtkrc-2.0 legacy settings

[Carson Black]

cblack accepted this revision.
cblack added a comment.
This revision is now accepted and ready to land.


  This LGTM. Would probably check a variety of configs with a variety of 
applications just to be on the safe side and make sure there's no visual 
oddities, but it should be fine.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  remove-legacy-gtkrc-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25147

To: gikari, cblack, #plasma, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

[David Redondo]

davidre added a comment.


  In D25144#558670 , @ngraham wrote:
  
  > Hmm, I think that would be confusing. "Session" isn't the name of any 
user-facing applications. That stuff is really a part of Plasma, both 
technically speaking, and also in terms of the user expectation. Is there any 
way we could force it to live in the Plasma/System Services section?
  
  
  Hmm it seems I failed to make myself clear. The *current* kcm just reads 
whether a component's unique name end with ".desktop" and categorizes on that 
while this patch uses `KService::isApplication`. In fact David's patch inspired 
inspired me to this since I noticed this problem when thinking about it.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25144

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » plasma-workspace-wallpapers » kf5-qt5 FreeBSDQt5.13 - Build # 15 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/plasma-workspace-wallpapers/job/kf5-qt5%20FreeBSDQt5.13/15/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 04 Nov 2019 18:24:32 +
 Build duration:
2 hr 12 min and counting

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

[Nathaniel Graham]

ngraham added a comment.


  Hmm, I think that would be confusing. "Session" isn't the name of any 
user-facing applications. That stuff is really a part of Plasma, both 
technically speaking, and also in terms of the user expectation. Is there any 
way we could force it to live in the Plasma/System Services section?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25144

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

[David Redondo]

davidre added a comment.


  In D25144#558665 , @ngraham wrote:
  
  > In D25144#558663 , @davidre 
wrote:
  >
  > > In D25144#558630 , @ngraham 
wrote:
  > >
  > > > However I see a problem with changing "Application Launchers" to 
"Applications": It implies that the items in that category will give you access 
to change all the shortcuts for those applications, which it does not do. If we 
want to make this change, I think we'd need to actually put all of each app's 
shortcuts into its item in that list, assuming that's possible.
  > >
  > >
  > > I don't think that's implied when the Settings page is titled "Global 
Shortcuts". The category is about about global shortcuts that relate to 
Application.
  >
  >
  > All right, I suppose that makes sense.
  >
  > > Also note that it will be an improvement when eventually more shortcuts 
are moved to desktop files. For example the "Lock Session" shortcut would end 
up in "Application Launchers" with D24877 .
  >
  > Under which entry? That seems odd.
  
  
  The user facing name which would be Session. As I wrote the current code only 
looks if the component name ends with .desktop so you would have "Session" 
inside "Application Launchers".

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25144

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

[Nathaniel Graham]

ngraham added a comment.


  In D25144#558663 , @davidre wrote:
  
  > In D25144#558630 , @ngraham 
wrote:
  >
  > > However I see a problem with changing "Application Launchers" to 
"Applications": It implies that the items in that category will give you access 
to change all the shortcuts for those applications, which it does not do. If we 
want to make this change, I think we'd need to actually put all of each app's 
shortcuts into its item in that list, assuming that's possible.
  >
  >
  > I don't think that's implied when the Settings page is titled "Global 
Shortcuts". The category is about about global shortcuts that relate to 
Application.
  
  
  All right, I suppose that makes sense.
  
  > Also note that it will be an improvement when eventually more shortcuts are 
moved to desktop files. For example the "Lock Session" shortcut would end up in 
"Application Launchers" with D24877 .
  
  Under which entry? That seems odd.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25144

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

[David Redondo]

davidre added a comment.


  In D25144#558630 , @ngraham wrote:
  
  > However I see a problem with changing "Application Launchers" to 
"Applications": It implies that the items in that category will give you access 
to change all the shortcuts for those applications, which it does not do. If we 
want to make this change, I think we'd need to actually put all of each app's 
shortcuts into its item in that list, assuming that's possible.
  
  
  I don't think that's implied when the Settings page is titled "Global 
Shortcuts". The category is about about global shortcuts that relate to 
Application.
  Also note that it will be an improvement when eventually more shortcuts are 
moved to desktop files. For example the "Lock Session" shortcut would end up in 
"Application Launchers" with D24877 .

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25144

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25147: Remove gtkrc-2.0 legacy settings

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Previously GTK KCM wrote to gtkrc redundant settings lines:
  
  1. `include "path to chosen gtk2 theme"`
  2.
  
style "user-font"
{
font-name="whatever font was chosen"
}
widget_style "*" style "user-font"
  
  Now GTK KCM does not write those lines to configuration file,
  but ones that was kept from previous versions of KCM
  are causing various glitches, when applying gtk2
  configuration, for theme and font configs respectively.
  
  This patch fixes these issues removing these lines from gtkrc
  by force, after applying any configuration from GTK KCM.
  
  BUG: 413678
  
  BUG: 413107

TEST PLAN
  Open ~/gtkrc-2.0 and add those lines (theme and font name are arbitrary):
  =
  
include "/usr/share/themes/Adwaita-dark/gtk-2.0/gtkrc"
style "user-font"
{
font_name="Noto Sans Regular"
}
widget_class "*" style "user-font"
  
  1. Open GTK KCM and apply any configuration
  2. Reopen ~/gtkrc-2.0 file and check, that those lines were removed

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  remove-legacy-gtkrc-settings (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25147

AFFECTED FILES
  src/appearancegtk2.cpp
  src/appearancegtk2.h

To: gikari
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

[Nathaniel Graham]

ngraham added a comment.


  Instead of "Plasma", how about "System Services"? That would match the 
categories in the Notifications KCM's similar list.
  
  However I see a problem with changing "Application Launchers" to 
"Applications": It implies that the items in that category will give you access 
to change all the shortcuts for those applications, which it does not do. If we 
want to make this change, I think we'd need to actually put all of each app's 
shortcuts into its item in that list, assuming that's possible.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25144

To: davidre, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25145: Focus search field by default

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, cfeck.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  In general, apps that have Search Fields always visible put the focus there 
by default.
  For example: System Settings and Discover. However KMenuEdit does not follow 
this pattern.
  
  This patch fixes that.
  
  BUG: 413563
  FIXED-IN: 5.18.0

TEST PLAN
  Open kmenuedit and start typing because the search field is now focused by 
default

REPOSITORY
  R103 KMenu Editor

BRANCH
  focus-search-field-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25145

AFFECTED FILES
  kmenuedit.cpp

To: ngraham, #vdg, #plasma, cfeck
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25144: [RFC][Global Shortcuts KCM] Categorize into Plasma and Applications

[David Redondo]

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Currently the shortcuts are divided into two lists. "Application Launchers" 
for
  shortcuts added via .desktop files (actually components with names that end in
  ".desktop") and "Other Shortcuts" for everything else. This not only exposes 
an
  implementation detail but also is not helpful to the average user who doesn't
  know what is meant with "Application Launcher" is. It can't be about 
Applications
  since Konversation is found under "Other Shortcuts" but it is also not about
  launching since other shortcuts can also be found there (for example see
  Spectacle). Furthermore if one adds an shortcut to launch an application in
  kmenuedit the shortcut is not found in "Application Launchers" but in
  "Other Shortcuts" under KDE Daemon (addressed in D25086 
).
  This patch tries to categorize the components into Applications and Plasma by
  trying harder to get a corresponding `KService` and then deciding upon
  `isApplication` if a Component falls into the applications category. Because
  components are free to set their uniquea and friendly names themselves it is
  also checked if there is  a service with Name. With this it is possible to 
get a
  KService for konversation for example.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  categorize (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25144

AFFECTED FILES
  kcms/keys/kglobalshortcutseditor.cpp

To: davidre
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Clang Format Update

[David Edmundson]

By the end of tonight there will be a patch in every plasma repo
adding a build target called "clang-format" using the new ECM macros.

Running "make clang-format" or "ninja clang-format" will tidy up all
code in all repos.

I have shipped this target now so that all devs can test the upcoming
changes and provide any feedback or merge any blacklist markers we may
find we want in specific places [1].

THE IMPORTANT BIT

DO NOT merge the resultant tidied files just yet. We shall do so with
a fake author in a week or two.

[1]
int formatted_code;
// clang-format off
voidunformatted_code  ;
// clang-format on
int formatted_code2;

D25134: Add KDEClangFormat cmake support

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:401d326ba14a: Add KDEClangFormat cmake support (authored 
by davidedmundson).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25134?vs=69240&id=69283

REVISION DETAIL
  https://phabricator.kde.org/D25134

AFFECTED FILES
  CMakeLists.txt

To: davidedmundson, #plasma, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25018: Move ACPI battery information from /proc/acpi to /sys

[José JORGE]

jjorge added a comment.


  In D25018#558503 , @ahiemstra 
wrote:
  
  > Hmm, I would like to see some smarter sys file handling for this. Right 
now, multiple calls to getSysFileValue result in the same file being read from 
disk over and over. While the original implementation may not have been ideal 
either, the update function at least made sure the ACPI stuff got only read 
once per update. If you need some inspiration, Memory.c has a fairly decent 
implementation.
  
  
  Are you sure this is a good idea? While previous update function readed only 
one file in /proc, like memory.c does, we read different files in /sys : one 
for each information. So this is not the same file readed over and over (and it 
is not read from disk as it is a virtual fs exposed by the kernel). Thanks.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D25018

To: jjorge, davidedmundson, #plasma, ahiemstra
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25018: Move ACPI battery information from /proc/acpi to /sys

[José JORGE]

jjorge requested review of this revision.
jjorge added a comment.


  So asking again for feedback, if I understand well how phabricator works ...

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D25018

To: jjorge, davidedmundson, #plasma, ahiemstra
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24843: [KDEPlatformSystemTrayIcon] Recreate deleted menu

[Konrad Materka]

kmaterka added a comment.


  Any chance to get this reviewed? :)

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D24843

To: kmaterka, apol, davidedmundson, #plasma, #frameworks, broulik, nicolasfella
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » systemsettings » kf5-qt5 FreeBSDQt5.13 - Build # 74 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20FreeBSDQt5.13/74/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Mon, 04 Nov 2019 14:34:47 +
 Build duration:
2 hr 6 min and counting
   CONSOLE OUTPUT
  [...truncated 105 lines...][2019-11-04T14:35:16.968Z] Retrieving: Plasma-kiconthemes-kf5-qt5[2019-11-04T14:35:16.968Z] Retrieving: Plasma-kwindowsystem-kf5-qt5[2019-11-04T14:35:16.968Z] Retrieving: Plasma-kcrash-kf5-qt5[2019-11-04T14:35:16.968Z] Retrieving: Plasma-kdbusaddons-kf5-qt5[2019-11-04T14:35:16.968Z] Retrieving: Plasma-phonon-kf5-qt5[2019-11-04T14:35:16.968Z] Retrieving: Plasma-knotifications-kf5-qt5[2019-11-04T14:35:16.968Z] Retrieving: Plasma-kservice-kf5-qt5[2019-11-04T14:35:17.223Z] Retrieving: Plasma-kcompletion-kf5-qt5[2019-11-04T14:35:17.223Z] Retrieving: Plasma-sonnet-kf5-qt5[2019-11-04T14:35:17.223Z] Retrieving: Plasma-attica-kf5-qt5[2019-11-04T14:35:17.223Z] Retrieving: Plasma-kglobalaccel-kf5-qt5[2019-11-04T14:35:17.223Z] Retrieving: Plasma-ktextwidgets-kf5-qt5[2019-11-04T14:35:17.223Z] Retrieving: Plasma-breeze-icons-kf5-qt5[2019-11-04T14:35:20.485Z] Retrieving: Plasma-kxmlgui-kf5-qt5[2019-11-04T14:35:20.485Z] Retrieving: Plasma-solid-kf5-qt5[2019-11-04T14:35:20.485Z] Retrieving: Plasma-kjobwidgets-kf5-qt5[2019-11-04T14:35:20.485Z] Retrieving: Plasma-kbookmarks-kf5-qt5[2019-11-04T14:35:20.485Z] Retrieving: Plasma-kwallet-kf5-qt5[2019-11-04T14:35:20.485Z] Retrieving: Plasma-kio-kf5-qt5[2019-11-04T14:35:20.741Z] Retrieving: Plasma-kparts-kf5-qt5[2019-11-04T14:35:20.741Z] Retrieving: Plasma-syntax-highlighting-kf5-qt5[2019-11-04T14:35:20.741Z] Retrieving: Plasma-kpackage-kf5-qt5[2019-11-04T14:35:20.741Z] Retrieving: Plasma-kactivities-kf5-qt5[2019-11-04T14:35:20.741Z] Retrieving: Plasma-kdnssd-kf5-qt5[2019-11-04T14:35:20.741Z] Retrieving: Plasma-kdeclarative-kf5-qt5[2019-11-04T14:35:20.996Z] Retrieving: Plasma-kidletime-kf5-qt5[2019-11-04T14:35:20.996Z] Retrieving: Plasma-kitemmodels-kf5-qt5[2019-11-04T14:35:20.996Z] Retrieving: Plasma-kross-kf5-qt5[2019-11-04T14:35:20.996Z] Retrieving: Plasma-threadweaver-kf5-qt5[2019-11-04T14:35:20.996Z] Retrieving: Plasma-kunitconversion-kf5-qt5[2019-11-04T14:35:20.996Z] Retrieving: Plasma-kwayland-kf5-qt5[2019-11-04T14:35:21.251Z] Retrieving: Plasma-ktexteditor-kf5-qt5[2019-11-04T14:35:21.251Z] Retrieving: Plasma-oxygen-icons5-kf5-qt5[2019-11-04T14:35:24.110Z] Retrieving: Plasma-plasma-framework-kf5-qt5[2019-11-04T14:35:24.110Z] Retrieving: Plasma-kpty-kf5-qt5[2019-11-04T14:35:24.110Z] Retrieving: Plasma-kinit-kf5-qt5[2019-11-04T14:35:24.110Z] Retrieving: Plasma-kded-kf5-qt5[2019-11-04T14:35:24.110Z] Retrieving: Plasma-kemoticons-kf5-qt5[2019-11-04T14:35:24.670Z] Retrieving: Plasma-kdesignerplugin-kf5-qt5[2019-11-04T14:35:24.670Z] Retrieving: Plasma-knewstuff-kf5-qt5[2019-11-04T14:35:24.670Z] Retrieving: Plasma-kfilemetadata-kf5-qt5[2019-11-04T14:35:24.926Z] Retrieving: Plasma-baloo-kf5-qt5[2019-11-04T14:35:24.926Z] Retrieving: Plasma-bluez-qt-kf5-qt5[2019-11-04T14:35:24.926Z] Retrieving: Plasma-frameworkintegration-kf5-qt5[2019-11-04T14:35:24.926Z] Retrieving: Plasma-kactivities-stats-kf5-qt5[2019-11-04T14:35:24.926Z] Retrieving: Plasma-kcmutils-kf5-qt5[2019-11-04T14:35:25.181Z] Retrieving: Plasma-kdelibs4support-kf5-qt5[2019-11-04T14:35:26.247Z] Retrieving: Plasma-kdesu-kf5-qt5[2019-11-04T14:35:26.502Z] Retrieving: Plasma-kholidays-kf5-qt5[2019-11-04T14:35:26.502Z] Retrieving: Plasma-kimageformats-kf5-qt5[2019-11-04T14:35:26.502Z] Retrieving: Plasma-knotifyconfig-kf5-qt5[2019-11-04T14:35:26.502Z] Retrieving: Plasma-kpeople-kf5-qt5[2019-11-04T14:35:26.502Z] Retrieving: Plasma-kplotting-kf5-qt5[2019-11-04T14:35:26.502Z] Retrieving: Plasma-krunner-kf5-qt5[2019-11-04T14:35:26.502Z] Retrieving: Plasma-kxmlrpcclient-kf5-qt5[2019-11-04T14:35:26.502Z] Retrieving: Plasma-prison-kf5-qt5[2019-11-04T14:35:26.760Z] Retrieving: Plasma-purpose-kf5-qt5[2019-11-04T14:35:26.760Z] Retrieving: Plasma-qqc2-desktop-style-kf5-qt5[2019-11-04T14:35:26.760Z] Retrieving: Plasma-syndication-kf5-qt5[2019-11-04T14:35:27.018Z] Retrieving: Plasma-kjs-kf5-qt5[2019-11-04T14:35:27.018Z] Retrieving: Plasma-kdecoration-kf5-qt5[2019-11-04T14:35:27.018Z] Retrieving: Plasma-kscreenlocker-kf5-qt5[2019-11-04T14:35:27.361Z] Retrieving: Plasma-kwayland-integration-kf5-qt5[2019-11-04T14:35:27.361Z] Retrieving: Plasma-breeze-kf5-qt5[2019-11-04T14:35:27.618Z] Retrieving: Plasma-khtml-kf5-qt5[2019-11-04T14:35:27.874Z] Retrieving: Plasma-khelpcenter-kf5-qt5[2019-11-04T14:35:28.129Z] Retrieving: Plasma-libksysguard-kf5-qt5[2019-11-04T14:35:28.129Z] Retrieving: Plasma-kwin-kf5-qt5[2019-11-04T14:35:34.467Z] Retrieving: Plasma-milou-kf5-qt5[2019-11-04T14:35:34.467Z] Retrieving: Plasma-libkscreen-kf5-qt5[2019-11-04T14:35:35.243Z] Retrieving: Plasma-kactivitymanagerd-kf5-qt5[2019-11-04T14:35:36.621Z] Retrieving: Plasma-kjsembed-kf5-qt5[2019-11-04T14:35:38.788Z] Retrieving: Plasma-kuserfeedback-kf5-qt5[2019-11-04T14:35:

D25141: Use a RowLayout for laying out ToolBarPageHeader

[Dan Leinir Turthra Jensen]

leinir accepted this revision.
leinir added a comment.
This revision is now accepted and ready to land.


  These changes make the KNSQuick components all happy :)
  
  F7735334: image.png 
  and
  F7735337: image.png 
  now both looks as intended :)

REPOSITORY
  R169 Kirigami

BRANCH
  headerLayout

REVISION DETAIL
  https://phabricator.kde.org/D25141

To: ahiemstra, #kirigami, leinir
Cc: leinir, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart, hein

D25141: Use a RowLayout for laying out ToolBarPageHeader

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 69282.
ahiemstra added a comment.


  - Correctly hide everything if no page actions are set

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25141?vs=69280&id=69282

BRANCH
  headerLayout

REVISION DETAIL
  https://phabricator.kde.org/D25141

AFFECTED FILES
  src/controls/ActionToolBar.qml
  src/controls/Page.qml
  src/controls/private/globaltoolbar/ToolBarPageHeader.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25140: kcm/fonts: set initial settings correctly

[Fabian Vogt]

fvogt accepted this revision.
fvogt added a comment.
This revision is now accepted and ready to land.


  LGTM. This now ignores the return value of the `xft.get*` calls, but that 
seems to be useless anyway:
  
bool KXftConfig::getSubPixelType(SubPixel::Type &type)
{
type = m_subPixel.type;
return SubPixel::None != m_subPixel.type;
}

REPOSITORY
  R119 Plasma Desktop

BRANCH
  bshah/fonts

REVISION DETAIL
  https://phabricator.kde.org/D25140

To: bshah, #plasma, fvogt, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24866: Wired setting: improve handling of link negotiation

[Dmitry Valter]

dvalter added a comment.


  Looks like a complete fix to #413211 
. I've tested it on Arch Linux 
with different modes. For me Ignore, Auto and 10/100/1000 Mbps modes worked as 
intended as well as duplex setup for 10 and 100.
  
  The only questionable thing is an ability to set Half duplex for 1Gbps and 10 
Gbps. The first one is virtually never used IRL (and does not work for some (I 
guess many) NIC's, and the second one is absent in the standard and therefore 
unlikely to be found anywhere. NetworkManager saves these values and silently 
ignores it's unabilty to apply them to the hardware.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D24866

To: jgrulich, #plasma
Cc: dvalter, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25141: Use a RowLayout for laying out ToolBarPageHeader

[Arjen Hiemstra]

ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  This uses RowLayout to perform the layout of ToolBarPageHeader. It uses
  the titleDelegate's Layout properties to control the layout of the Title
  delegate.

TEST PLAN
  Run Kirigami Gallery. 
  All pages behave correctly regarding titles:
  
  - Default view shows title + as many actions as fit into the window
  - Resizing the window shows the actions disappearing until only the context 
action is left, after which the title starts eliding.
  - Resizing back to a large size first un-elides the title, then immediately 
the actions start to appear again.

REPOSITORY
  R169 Kirigami

BRANCH
  headerLayout

REVISION DETAIL
  https://phabricator.kde.org/D25141

AFFECTED FILES
  src/controls/ActionToolBar.qml
  src/controls/Page.qml
  src/controls/private/globaltoolbar/ToolBarPageHeader.qml

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D25086: [WIP] Port to KGlobalAccel

[David Redondo]

davidre updated this revision to Diff 69279.
davidre marked an inline comment as done.
davidre added a comment.


  Thanks for spotting!

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25086?vs=69107&id=69279

BRANCH
  globalaccel (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25086

AFFECTED FILES
  CMakeLists.txt
  basictab.cpp
  globalaccel.cpp
  globalaccel.h
  khotkeys.cpp
  khotkeys.h
  main.cpp
  menuinfo.cpp

To: davidre, #plasma, davidedmundson, mlaurent
Cc: apol, mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

Re: KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 111 - Failure!

[David Edmundson]

Issue is just CI being slow on the relevant frameworks changes.
It's a false positive, we don't need to act.

David

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.12 - Build # 111 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.12/111/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Mon, 04 Nov 2019 14:34:48 +
 Build duration:
3 min 25 sec and counting
   CONSOLE OUTPUT
  [...truncated 338 lines...][2019-11-04T14:37:55.140Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/systemsettings/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for systemsettings.[2019-11-04T14:37:55.140Z] -- Found KF5Package: /home/jenkins/install-prefix/lib64/cmake/KF5Package/KF5PackageConfig.cmake (found version "5.64.0") [2019-11-04T14:37:55.140Z] Installing in /home/jenkins/install-prefix. Run /home/jenkins/workspace/Plasma/systemsettings/kf5-qt5 SUSEQt5.12/build/prefix.sh to set the environment for systemsettings.[2019-11-04T14:37:55.140Z] -- Found KF5Declarative: /home/jenkins/install-prefix/lib64/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.64.0") [2019-11-04T14:37:55.140Z] -- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.64.0") [2019-11-04T14:37:55.140Z] -- Found KF5ActivitiesStats: /home/jenkins/install-prefix/lib64/cmake/KF5ActivitiesStats/KF5ActivitiesStatsConfig.cmake (found version "5.64.0") [2019-11-04T14:37:56.790Z] -- qmlplugindump failed for org.kde.kcm.[2019-11-04T14:37:56.791Z] -- Could NOT find org.kde.kcm-QMLModule (missing: org.kde.kcm-QMLModule_FOUND) [2019-11-04T14:37:56.791Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY[2019-11-04T14:37:57.289Z] -- Performing Test COMPILER_HAS_HIDDEN_VISIBILITY - Success[2019-11-04T14:37:57.289Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY[2019-11-04T14:37:57.289Z] -- Performing Test COMPILER_HAS_HIDDEN_INLINE_VISIBILITY - Success[2019-11-04T14:37:57.289Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR[2019-11-04T14:37:57.289Z] -- Performing Test COMPILER_HAS_DEPRECATED_ATTR - Success[2019-11-04T14:37:57.786Z] -- The following OPTIONAL packages have been found:[2019-11-04T14:37:57.786Z] [2019-11-04T14:37:57.786Z]  * KF5Completion (required version >= 5.63.0)[2019-11-04T14:37:57.786Z]  * KF5JobWidgets (required version >= 5.63.0)[2019-11-04T14:37:57.786Z]  * KF5Solid (required version >= 5.63.0)[2019-11-04T14:37:57.786Z]  * KF5Auth (required version >= 5.63.0)[2019-11-04T14:37:57.786Z]  * KF5Codecs (required version >= 5.63.0)[2019-11-04T14:37:57.786Z]  * KF5ConfigWidgets (required version >= 5.63.0)[2019-11-04T14:37:57.786Z]  * KF5CoreAddons (required version >= 5.63.0)[2019-11-04T14:37:57.786Z] [2019-11-04T14:37:57.786Z] -- The following REQUIRED packages have been found:[2019-11-04T14:37:57.786Z] [2019-11-04T14:37:57.786Z]  * Qt5Gui (required version >= 5.12.5)[2019-11-04T14:37:57.786Z]  * Qt5Qml[2019-11-04T14:37:57.786Z]  * Qt5QuickWidgets[2019-11-04T14:37:57.786Z]  * Qt5 (required version >= 5.11.0)[2019-11-04T14:37:57.786Z]  * KF5Crash (required version >= 5.62.0)[2019-11-04T14:37:57.786Z]  * KF5KCMUtils (required version >= 5.62.0)[2019-11-04T14:37:57.786Z]  * Gettext[2019-11-04T14:37:57.786Z]  * KF5I18n (required version >= 5.62.0)[2019-11-04T14:37:57.786Z]  * KF5ItemViews (required version >= 5.63.0)[2019-11-04T14:37:57.786Z]  * Qt5Network (required version >= 5.11.0)[2019-11-04T14:37:57.786Z]  * KF5KIO (required version >= 5.62.0)[2019-11-04T14:37:57.786Z]  * KF5Service (required version >= 5.62.0)[2019-11-04T14:37:57.786Z]  * KF5IconThemes (required version >= 5.62.0)[2019-11-04T14:37:57.786Z]  * KF5WindowSystem (required version >= 5.62.0)[2019-11-04T14:37:57.786Z]  * Qt5Widgets (required version >= 5.11.0)[2019-11-04T14:37:57.786Z]  * KF5WidgetsAddons (required version >= 5.63.0)[2019-11-04T14:37:57.786Z]  * KF5XmlGui (required version >= 5.62.0)[2019-11-04T14:37:57.786Z]  * KF5DBusAddons (required version >= 5.62.0)[2019-11-04T14:37:57.786Z]  * KF5DocTools (required version >= 5.62.0)[2019-11-04T14:37:57.786Z]  * Qt5Quick (required version >= 5.11.0)[2019-11-04T14:37:57.786Z]  * ECM (required version >= 1.6.0)[2019-11-04T14:37:57.786Z]  * KF5Package (required version >= 5.63.0)[2019-11-04T14:37:57.786Z]  * KF5Declarative (required version >= 5.62.0)[2019-11-04T14:37:57.786Z]  * KF5Activities (required version >= 5.62.0)[2019-11-04T14:37:57.786Z]  * KF5ActivitiesStats (required version >= 5.62.0)[2019-11-04T14:37:57.786Z]  * KF5 (required version >= 5.62.0)[2019-11-04T14:37:57.786Z]  * KF5Kirigami2 (required version >= 2.1)[2019-11-04T14:37:57.786Z]  * Qt5Core (required version >= 5.12.0)[2019-11-04T14:37:57.786Z]  * LibKWorkspace (required version >= 5.17.80)[2019-11-04T14:37:57.786Z] [2019-11-04T14:37:57.786Z] -- The following RUNTIME packages have not been found:[2019-11-04T14:37:57.786Z] [2019-11-04T14:37:57.786Z]  * org.kde.kcm-QMLModule, QML module 'org.kde.kcm' is a runtime dependency.[2019-11-04T14:37:57.786Z] [2019-11-04T14:37:57.786Z] -- Configuring done[2019-11-04T14:37:57.786Z] -- Gene

D25074: Disable the restore defaults button if the KCModule says so

[Kevin Ottens]

This revision was automatically updated to reflect the committed changes.
Closed by commit R124:fe180972acbb: Disable the restore defaults button if the 
KCModule says so (authored by ervin).

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25074?vs=69275&id=69277

REVISION DETAIL
  https://phabricator.kde.org/D25074

AFFECTED FILES
  core/ModuleView.cpp
  core/ModuleView.h

To: ervin, #plasma, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25074: Disable the restore defaults button if the KCModule says so

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in ModuleView.cpp:427
> Not saying this is wrong, but can you explain this change?
> 
> In https://phabricator.kde.org/D25072
> 
> we do setEnabled((buttons & Default) && !defaulted) rather than changing 
> visibility, presumably it's there to make sure buttons don't move as you 
> navigate between modules.

It feels kind of wrong indeed. Better align that behavior with the one from 
kcmshell. I'll make a reworked patch in that direction.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D25074

To: ervin, #plasma, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25074: Disable the restore defaults button if the KCModule says so

[Kevin Ottens]

ervin updated this revision to Diff 69275.
ervin added a comment.


  Deal with David's comment and realign ModuleView with KCMultiDialog regarding 
button state management.

REPOSITORY
  R124 System Settings

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25074?vs=69044&id=69275

REVISION DETAIL
  https://phabricator.kde.org/D25074

AFFECTED FILES
  core/ModuleView.cpp
  core/ModuleView.h

To: ervin, #plasma, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24893: [Lock Screen] Add option to hide clock when idle

[Nathaniel Graham]

ngraham added a comment.


  In D24893#558451 , @mart wrote:
  
  > clock "always show" is fine too tough
  
  
  Given that the setting will be off by default, its opposite state is clear 
enough I'd say. It's not the best string ever, but maybe we should start with 
this and massage it later or else this will probably be stuck in limbo 
forever...

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24893

To: broulik, #plasma, #vdg, ngraham
Cc: mart, davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25018: Move ACPI battery information from /proc/acpi to /sys

[Arjen Hiemstra]

ahiemstra requested changes to this revision.
ahiemstra added a comment.
This revision now requires changes to proceed.


  Hmm, I would like to see some smarter sys file handling for this. Right now, 
multiple calls to getSysFileValue result in the same file being read from disk 
over and over. While the original implementation may not have been ideal 
either, the update function at least made sure the ACPI stuff got only read 
once per update. If you need some inspiration, Memory.c has a fairly decent 
implementation.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D25018

To: jjorge, davidedmundson, #plasma, ahiemstra
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25074: Disable the restore defaults button if the KCModule says so

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> ModuleView.cpp:427
>  d->mHelp->setEnabled(buttons & KCModule::Help );
> -d->mDefault->setEnabled(buttons & KCModule::Default );
>  }

Not saying this is wrong, but can you explain this change?

In https://phabricator.kde.org/D25072

we do setEnabled((buttons & Default) && !defaulted) rather than changing 
visibility, presumably it's there to make sure buttons don't move as you 
navigate between modules.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D25074

To: ervin, #plasma, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24068: docs: add contributing guide

[David Edmundson]

davidedmundson added a comment.


  README is really good.
  
  Did you email kde-devel about this commit policy? I thought you did, but I 
can't find it. 
  As someone who regularly commits across many many repos if every maintainer 
enforced their own thing I would really struggle.

INLINE COMMENTS

> CONTRIBUTING.md:68
> +[angular-revert]: 
> https://github.com/angular/angular/blob/3cf2005a936bec2058610b0786dd0671dae3d358/CONTRIBUTING.md#revert
> +[angular-subject]: 
> https://github.com/angular/angular/blob/3cf2005a936bec2058610b0786dd0671dae3d358/CONTRIBUTING.md#subject
> +[bugzilla]: https://bugs.kde.org/describecomponents.cgi?product=KScreen

What's a BREAKING CHANGE in relation to a UI?

configs breaking and being unusable or just a button having new text?

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D24068

To: romangg, #plasma
Cc: davidedmundson, yurchor, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25042: Rename cmake project to KActivityManagerd, remove unused option

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R161:fbcd08aacb5f: Rename cmake project to KActivityManagerd, 
remove unused option (authored by meven).

REPOSITORY
  R161 KActivity Manager Service

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25042?vs=68961&id=69260

REVISION DETAIL
  https://phabricator.kde.org/D25042

AFFECTED FILES
  CMakeLists.txt

To: meven, ivan
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

monday meeting notes sent for 4/11/2019

[Marco Martin]

Kai Uwe
KWin:
* Fixed startupfeedback with "resolution independent" cursor size
(basically reverting it for this case...)
Plasma:
* Digital clock date format setting now has live preview
* Made Milou use theme.disabledColor to improve readability on dark backgrounds
* Turned out to be a bit controversial, but opacity change for
text often makes it barely readable
* Added option to hide clock on lock screen when idle for
"screensaver" experience, please help find a good naming for the
option D24893

David
* Quick update on the crucial QtSVG bug - more customers are
complaining it breaks stuff, no fix is merged yet
https://bugreports.qt.io/browse/QTBUG-78200
* I've uploaded the cmake changes to p-w to easily do the clang
formatting in a single command
* so now people have no excuse for not testing the clang-format stuff
 Diff 25134 "Add KDEClangFormat cmake support" [Needs Review]
https://phabricator.kde.org/D25134

Jonathan
* I released 5.17.2 last week, I'll release 5.17.3 next week

Roman
* Fixed Wayland nested session: D25127 D25128 D25129 (apol[m])
Diff 25127 "[platforms/wayland] Do an initial xdg-surface commit"
[Closed] https://phabricator.kde.org/D25127
Diff 25128 "[platforms/wayland] Always ack configure" [Closed]
https://phabricator.kde.org/D25128
Diff 25129 "[platforms/wayland] Use xdg-shell stable protocol"
[Closed] https://phabricator.kde.org/D25129
* Have some patches for KScreen: D25020 D25021 D25026 D25027 D25062,
last one is most important since it fixes some issue often reported.
I'm thinking of disabling the related function overall because there
were several issues with. But on the other side I can make use of the
user testing before 5.18 LTS. In beta phase no bugs related to that
function were filed.
Diff 25020 "fix: create control files only when needed" [Needs
Review] https://phabricator.kde.org/D25020
Diff 25021 "fix: use output hashMd5 for control files" [Needs
Review] https://phabricator.kde.org/D25021
* I will push the contributing guides D24068 D25064 to
KScreen/libkscreen this week.They include a commit message guideline.
We can use this as a test case and see how it works out and if it
works out well adapt in other repos as well.
* I am with Kai and Nico at QtWS next few days, so not always online.
Diff 25026 "feat(kcm): always use 0.25 slider scale steps"
[Accepted] https://phabricator.kde.org/D25026
Diff 25027 "feat(kcm): zoom preview automatically" [Needs Review]
https://phabricator.kde.org/D25027
Diff 25062 "fix(kded): read rotated output size" [Needs Review]
https://phabricator.kde.org/D25062
Diff 24068 "docs: add contributing guide" [Needs Review]
https://phabricator.kde.org/D24068
Diff 25064 "docs: add contributing guide" [Needs Review]
https://phabricator.kde.org/D25064
* D25062 should have priority

Bhushan
* wrote part 5 of PlaMo weekly blog post :
https://www.plasma-mobile.org/2019/11/01/Plasma-Mobile-Weekly-update-5.html
* worked on fixing fonts kcm (again!)
* https://phabricator.kde.org/D25090
Diff 25090 "kcm/fonts: Do not load image preview before loading
settings" [Closed] https://phabricator.kde.org/D25090
got merged already
* https://phabricator.kde.org/D25140
Diff 25140 "kcm/fonts: set initial settings correctly" [Needs
Review] https://phabricator.kde.org/D25140

Marco
# Plasma
* fixed notification plasmoid bug where clicking on close button
triggered action
* Added disabled text colo on plasma theme for the milou thing
# Kirigami
* Made a Qt patch for the tab navigation issue in Kirigami
https://codereview.qt-project.org/c/qt/qtquickcontrols2/+/279311
* fixed bug 404396
* fixed bug 410673
* more work on the SwipeListItem rewrite

D25064: docs: add contributing guide

[David Edmundson]

davidedmundson added a comment.


  Let's do all review on D24068 .
  
  If that has a ship it, consider this a ship it.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D25064

To: romangg, #plasma
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24893: [Lock Screen] Add option to hide clock when idle

[Marco Martin]

mart added a comment.


  clock "always show" is fine too tough

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24893

To: broulik, #plasma, #vdg, ngraham
Cc: mart, davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D24743: Update GTK settings according to Plasma settings

[Mikhail Zolotukhin]

gikari updated this revision to Diff 69259.
gikari marked an inline comment as done.
gikari added a comment.


  Fix the typo

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24743?vs=69141&id=69259

BRANCH
  gtk-settings-in-respective-kcms

REVISION DETAIL
  https://phabricator.kde.org/D24743

AFFECTED FILES
  CMakeLists.txt
  kded-module/CMakeLists.txt
  kded-module/configeditor.cpp
  kded-module/configeditor.h
  kded-module/configvalueprovider.cpp
  kded-module/configvalueprovider.h
  kded-module/gtkconfig.cpp
  kded-module/gtkconfig.h
  kded-module/gtkconfig.json

To: gikari, #plasma, #vdg
Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, ahiemstra, mbohlender, mart

D24743: Update GTK settings according to Plasma settings

[Kevin Ottens]

ervin added a comment.


  Just a minor thing, otherwise LGTM, I'll let Kai give the last stamp of 
approval.

INLINE COMMENTS

> gtkconfig.cpp:113
> +setFont();
> +setFont();
> +setIconTheme(KIconLoader::Group::Desktop);

Are you sure you want to call setFont() twice here? That looks surprising.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D24743

To: gikari, #plasma, #vdg
Cc: ervin, ngraham, broulik, nicolasfella, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, 
MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, 
skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, 
abetts, sebas, apol, ahiemstra, mbohlender, mart

D25140: kcm/fonts: set initial settings correctly

[Bhushan Shah]

bshah updated this revision to Diff 69258.
bshah added a comment.


  update based on fvogt comment

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25140?vs=69255&id=69258

BRANCH
  bshah/fonts

REVISION DETAIL
  https://phabricator.kde.org/D25140

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: bshah, #plasma, fvogt, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24879: [ComboBox] Follow focusPolicy

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:b1452c37b49c: [ComboBox] Follow focusPolicy (authored by 
broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D24879?vs=68586&id=69256#toc

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24879?vs=68586&id=69256

REVISION DETAIL
  https://phabricator.kde.org/D24879

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: broulik, #plasma, mart
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D24883: [ComboBox] Don't indicate focus when popup is open

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:5dc1c74cad6f: [ComboBox] Don't indicate focus when 
popup is open (authored by broulik).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24883?vs=68593&id=69257

REVISION DETAIL
  https://phabricator.kde.org/D24883

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: broulik, #plasma, mart
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25140: kcm/fonts: set initial settings correctly

[Bhushan Shah]

bshah added a comment.


  OH wait! nvm, I see what you mean..

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25140

To: bshah, #plasma, fvogt, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25140: kcm/fonts: set initial settings correctly

[Bhushan Shah]

bshah added a comment.


  > That seems like just the order of assignments is wrong and more logic isn't 
actually needed. What about something like this:
  
  Important thing to note is, setSubPixelType doesn't actually write config. It 
just sets the internal configuration. Actual setting of value is done in 
FontAASettings::save.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25140

To: bshah, #plasma, fvogt, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24879: [ComboBox] Follow focusPolicy

[Marco Martin]

mart added a comment.


  one thing that may be tried is to use input handlers instead of the mousearea 
to manage the wheel (tough i am not sure we can already use them in frameworks 
due to qt version requirements)

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D24879

To: broulik, #plasma, mart
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D25140: kcm/fonts: set initial settings correctly

[Fabian Vogt]

fvogt added a comment.


  That seems like just the order of assignments is wrong and more logic isn't 
actually needed. What about something like this:
  
KXftConfig::SubPixel::Type spType = KXftConfig::SubPixel::NotSet;
// we get subpixel type from config
xft.getSubPixelType(spType);
m_originalState.subPixel = spType;
if(spType == KXftConfig::SubPixel::NotSet) {
spType = KXftConfig::SubPixel::Rgb;
}

setSubPixel(spType);

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25140

To: bshah, #plasma, fvogt, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25140: kcm/fonts: set initial settings correctly

[Bhushan Shah]

bshah created this revision.
bshah added reviewers: Plasma, fvogt, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bshah requested review of this revision.

REVISION SUMMARY
  During initial load we check if certain settings are set or not, and if
  they are not set, we set it to rgb/slight (recommended settings by
  Plasma team).
  
  however state management of this is broken, previous flow was,
  
  - try to get configuration
  - if configuration is not available, set state to desired settings
  - set original state to current state value(!)
  - write configuration to the file once complete state is written (all other 
settings)
  
  This is fine, when setting is changing from something other then none or
  not-set. But if it is not-set, both original state and current state
  ended up being desired settings, which write function would happily
  ignore since it thinks config never changed.
  
  So, if we encounter not-set configuration, preserve that as a original
  setting to get configs written correctly.
  
  This patch on it's own have no visible effect, kcm is still broken due
  to lack of kcminit which writes correct configuration at startup, but
  this is one of obvious bugfix for follow-up patch series.

TEST PLAN
  with upcoming patch to add kcminit, it correctly applies rgb/slight

REPOSITORY
  R119 Plasma Desktop

BRANCH
  bshah/fonts

REVISION DETAIL
  https://phabricator.kde.org/D25140

AFFECTED FILES
  kcms/fonts/fonts.cpp

To: bshah, #plasma, fvogt, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart