D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before

jgrulich added a comment. You are right, I didn't properly read what you do. I still think we should modify the already existing function to additionaly save the previous state, because most of the code is same. The only difference is "Set" vs "Get" method on DBus. REPOSITORY R116 Plasma

D22176: Rework system tray settings

ngraham added a comment. Ping. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22176 To: nicolasfella, #plasma, #vdg Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D24070: Don't use toolTipMainText to show info, rather use the second line

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Hmm F7761926: Screenshot_20191113_151950.png Looks like the condition where `remainingTime` is 0 or undefined needs better

D24798: Migrate QQC1 to QQC2

guoyunhe updated this revision to Diff 69705. guoyunhe added a comment. Prefix QQC2 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24798?vs=69703=69705 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24798 AFFECTED FILES

D24798: Migrate QQC1 to QQC2

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Thanks. Still needs fixes for the timezone list: - No frame around list - Scrolling using touchpad or mouse wheel does not work - Scrollview bounds are too large -

D24743: Update GTK settings according to Plasma settings

gikari updated this revision to Diff 69704. gikari marked 5 inline comments as done. gikari added a comment. Remove unnecessary GTK lib usages REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24743?vs=69702=69704 BRANCH

D24798: Migrate QQC1 to QQC2

guoyunhe updated this revision to Diff 69703. guoyunhe added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24798?vs=69701=69703 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24798 AFFECTED FILES

D24743: Update GTK settings according to Plasma settings

cblack added inline comments. INLINE COMMENTS > gikari wrote in configeditor.cpp:51 > You mean remove `gtk_init`? Yes, my bad. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24743 To: gikari, #plasma, #vdg, broulik, cblack Cc: ervin, ngraham,

D24743: Update GTK settings according to Plasma settings

gikari added inline comments. INLINE COMMENTS > cblack wrote in configeditor.cpp:51 > You should probably remove this call here, as you aren't using any GTK > functions. You mean remove `gtk_init`? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D24798: Migrate QQC1 to QQC2

ngraham added a comment. Needs a rebase, and Kai's comment still needs to be addressed. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24798 To: guoyunhe, #plasma, #plasma_workspaces, ngraham Cc: broulik, kmaterka, ngraham, plasma-devel, LeGast00n,

D24743: Update GTK settings according to Plasma settings

cblack added inline comments. INLINE COMMENTS > CMakeLists.txt:29 > +${GLIB2_LIBRARY} > +${GTK3_LIBRARY} > +${GOBJECT2_LIBRARY} See below comments about GTK. > configeditor.cpp:35 > +#include > +#include > + You shouldn't need to import/use gtk for configuration, only gio which

D24743: Update GTK settings according to Plasma settings

gikari updated this revision to Diff 69702. gikari added a comment. Add DBusAddons component REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24743?vs=69691=69702 BRANCH gtk-settings-in-respective-kcms REVISION DETAIL

D24798: Migrate QQC1 to QQC2

guoyunhe updated this revision to Diff 69701. guoyunhe added a comment. Add QQC2 namespace REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24798?vs=68733=69701 BRANCH master REVISION DETAIL https://phabricator.kde.org/D24798 AFFECTED FILES

D25294: [applets/kicker] Set icon for all applications group

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Most group have icons, this one did not. A new icon just got created for

D25284: Make QmlComponentsPool one instance per engine

davidedmundson updated this revision to Diff 69697. davidedmundson added a comment. reduce lookup REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25284?vs=69671=69697 BRANCH master REVISION DETAIL https://phabricator.kde.org/D25284 AFFECTED FILES

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw updated this revision to Diff 69693. mthw added a comment. I think I made all the changes you wanted. Hopefully I didn't break anything. It works correctly on first glance. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24070?vs=66959=69693

D24743: Update GTK settings according to Plasma settings

gikari updated this revision to Diff 69691. gikari added a comment. Remember to save all files before blindly commiting REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24743?vs=69690=69691 BRANCH gtk-settings-in-respective-kcms

D24743: Update GTK settings according to Plasma settings

gikari updated this revision to Diff 69690. gikari added a comment. Remove the empty line in CMakeLists.txt REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24743?vs=69689=69690 BRANCH gtk-settings-in-respective-kcms REVISION DETAIL

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 27 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/27/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Wed, 13 Nov 2019 17:09:22 + Build duration: 8 min 56 sec and counting JUnit Tests Name:

D24743: Update GTK settings according to Plasma settings

gikari updated this revision to Diff 69689. gikari marked 6 inline comments as done. gikari edited the summary of this revision. gikari added a comment. Fix the mistakes REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24743?vs=69259=69689

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.13 - Build # 11 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.13/11/ Project: stable-kf5-qt5 WindowsMSVCQt5.13 Date of build: Wed, 13 Nov 2019 17:09:23 + Build duration: 4 min 43 sec and counting JUnit Tests

D24743: Update GTK settings according to Plasma settings

nicolasfella added a comment. Works really well, good job! Some minor nitpicks INLINE COMMENTS > CMakeLists.txt:69 > add_subdirectory(tests) > +add_subdirectory(kded-module) > Nitpick, feel free to ignore since it was probably done by me: usually we call the folder just 'kded' >

D25282: Ensure comments fetch for KNS starts on the right page

This revision was automatically updated to reflect the committed changes. Closed by commit R134:11bfabfcbee9: Ensure comments fetch for KNS starts on the right page (authored by leinir). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE

D24122: [GTK3] Generate Breeze Light assets

ngraham added a comment. I see. REPOSITORY R98 Breeze for Gtk REVISION DETAIL https://phabricator.kde.org/D24122 To: cblack, #breeze Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed,

D25290: KCM launchfeedback : port to KConfig XT

ngraham added a comment. So much red! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25290 To: crossi, #plasma, ervin, bport, mart, davidedmundson Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot,

D25290: KCM launchfeedback : port to KConfig XT

crossi created this revision. crossi added reviewers: Plasma, ervin, bport, mart, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. crossi requested review of this revision. REVISION SUMMARY Simple KCM, all settings' states are automatically handled thanks

D22684: [Klipper] Fix clipboard history management

ngraham added a comment. @pdabrowski can you rebase this? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22684 To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D22684: [Klipper] Fix clipboard history management

ngraham added a comment. @davidedmundson are you still good with this? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22684 To: pdabrowski, #plasma, #plasma_workspaces, ngraham, davidedmundson Cc: davidre, plasma-devel, LeGast00n, The-Feren-OS-Dev,

Re: KDE CI: Plasma » kscreenlocker » kf5-qt5 SUSEQt5.12 - Build # 58 - Failure!

Just a framework sync issue, should be a non issue that will fix itself.

D24070: Don't use toolTipMainText to show info, rather use the second line

broulik added a comment. There's also a lot of code duplication making the diff hard to read. Please group if statements together where it makes sense, e.g. avpod things like if (foo) { return plasmoid.title; } else if (foo) { return plasmoid.title; or

D25287: Integrate the lnf and wallpaper settings with the KCM logic

ervin created this revision. ervin added reviewers: Plasma, mart, davidedmundson, bport, crossi. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ervin requested review of this revision. REVISION SUMMARY This was currently very much disconnected and broken in quite a few

D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before

ngraham added a comment. In D25279#561853 , @jgrulich wrote: > There is already a method to enable/disable BT, why don't you reuse it? Nothing checks the previous BT status, so by the time we get to the function to enable BT, it can't

D25281: [GTK3] Improve legibility of Firefox CSD colours

ngraham added a comment. In D25281#561861 , @broulik wrote: > > However Once we implement the Breeze color scheme changes > > How is that related? If i keep using a dark title bar I will still have that issue. Merely changing the

D25273: Enable selecting all installed color schemes in Cuttlefish

ngraham added a comment. In D25273#561852 , @davidre wrote: > Since this directly uses KColorSchemeManager, do you also see duplicated entries in Kate's color scheme menu? Yep. In D25273#561875

D25212: Move the shortcut management in the settings object

This revision was automatically updated to reflect the committed changes. Closed by commit R133:68bdeb8cd7d9: Move the shortcut management in the settings object (authored by ervin). REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25212?vs=69435=69675

KDE CI: Plasma » kscreenlocker » kf5-qt5 FreeBSDQt5.13 - Build # 38 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kscreenlocker/job/kf5-qt5%20FreeBSDQt5.13/38/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Wed, 13 Nov 2019 14:36:51 + Build duration: 1 min 16 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kscreenlocker » kf5-qt5 SUSEQt5.12 - Build # 58 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kscreenlocker/job/kf5-qt5%20SUSEQt5.12/58/ Project: kf5-qt5 SUSEQt5.12 Date of build: Wed, 13 Nov 2019 14:36:51 + Build duration: 1 min 30 sec and counting CONSOLE OUTPUT [...truncated

D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before

davidedmundson added inline comments. INLINE COMMENTS > handler.cpp:366-369 > +Handler::updatePreviousBluetoothStatus(); > m_tmpWirelessEnabled = NetworkManager::isWirelessEnabled(); > m_tmpWwanEnabled = NetworkManager::isWwanEnabled(); >

D25284: Make QmlComponentsPool one instance per engine

broulik added inline comments. INLINE COMMENTS > columnview.cpp:51 > +Q_ASSERT(engine); > +if(privateQmlComponentsPoolSelf->m_instances.contains(engine)) { > +return privateQmlComponentsPoolSelf->m_instances[engine]; Avoid double lookup: auto *componentPool =

D25284: Make QmlComponentsPool one instance per engine

davidedmundson created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY If we create 2 engines in an application the singleton is initialised to the first engine. If that first engine

D25273: Enable selecting all installed color schemes in Cuttlefish

davidre added a comment. In D25273#561847 , @ngraham wrote: > Also, the combobox's model appears to have duplicates for Breeze, Breeze Dark, and Breeze Light, which (correctly) don't show up in the colors KCM for me: F7760168:

D25282: Ensure comments fetch for KNS starts on the right page

leinir created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. leinir requested review of this revision. REVISION SUMMARY For a while, we've not had reviews/comments showing up for KNS content, and ensures we initiate fetching from the correct page. It

D25280: [Baloo KCM] Purge index when disabling indexing

davidedmundson resigned from this revision. davidedmundson added a comment. In theory it's all just a cache of data elsewhere. The downside of this patch is that if a user temporarily disables the indexer, when it's re-enabled we're triggering an entire first scan reset of everything.

D25281: [GTK3] Improve legibility of Firefox CSD colours

broulik added a comment. > However Once we implement the Breeze color scheme changes How is that related? If i keep using a dark title bar I will still have that issue. Merely changing the colorscheme doesn't fix the underlying bug? REPOSITORY R98 Breeze for Gtk REVISION DETAIL

D25198: KCM Colors : port color scheme state management to KConfigXT

This revision was automatically updated to reflect the committed changes. Closed by commit R119:199bbe20d72c: KCM Colors : port color scheme state management to KConfigXT (authored by crossi). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D24070: Don't use toolTipMainText to show info, rather use the second line

mthw added a comment. @ndavis Unless this needs a rebase, all I need is review/approval. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24070 To: mthw, ngraham, #vdg, #plasma, broulik, ndavis Cc: ndavis, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev,

D25273: Enable selecting all installed color schemes in Cuttlefish

davidre updated this revision to Diff 69667. davidre added a comment. Load initial color scheme name from the respective .colors file REPOSITORY R118 Plasma SDK CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25273?vs=69639=69667 BRANCH colorschemes (branched from master)

D25279: [Applet] Only re-enable BT after disabling airplane mode if it was on before

jgrulich added a comment. There is already a method to enable/disable BT, why don't you reuse it? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D25279 To: ngraham, #plasma, jgrulich Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D25273: Enable selecting all installed color schemes in Cuttlefish

davidre added a comment. In D25273#561845 , @ngraham wrote: > Nice, it's good to get rid of so much boilerplate. > > However when I change the system's own color scheme from Breeze to anything else and start Cuttlefish, the app itself uses

Translate software

Hello there, I was wondering if Plasma Mobile has an official site for translators to translate their ROM to our respective languages? If so, what is it call? Thank you for answering my question, David Rebolo Magariños