D25709: Make it compile against qt5.14 without deprecated method

[Laurent Montel]

mlaurent created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mlaurent requested review of this revision.

REVISION SUMMARY
  Compile against 5.14 without deprecated method

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

BRANCH
  fix_compile_qt5.14 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25709

AFFECTED FILES
  plugin/kquickstyleitem.cpp

To: mlaurent
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D14581: support for multilevel kcms

[Filip Fila]

filipf added a comment.


  Hi, this patch triggered a bug in icon view: 
https://bugs.kde.org/show_bug.cgi?id=400876
  
  I've confirmed the bug can't be reproduced when these lines are removed.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D14581

To: mart, #plasma, #vdg, davidedmundson
Cc: filipf, davidedmundson, abetts, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D25428: Improved support for desktop "Folder View"

[Nathaniel Graham]

ngraham added a comment.


  I'm afraid it's still not consistently fixed for me when using double-click. 
Most of the time, a tap will still select and then immediately de-select the 
item. Only about 1/4 of my taps actually open the item. With single-click, 
about 3/4 open the item, but the rest do the same thing and the item ends up 
highlighted rather than opened.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25428

To: steffenh, #plasma, hein, ngraham
Cc: ngraham, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25703: Sync scrollbar behavior with GTK applications

[Nathaniel Graham]

ngraham added a comment.


  Nice, works great. Wanna remove the option in the KCM in this patch too?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25703

To: gikari, cblack, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25694: Port away from DesktopIcon

[Aleix Pol Gonzalez]

apol added a comment.


  The change looks good to me, can you provide a screenshot of before/after?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25694

To: nicolasfella, #plasma
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D25692: Rename Look and Feel Explorer to Plasma Global Theme Explorer

[Carl Schwan]

This revision was automatically updated to reflect the committed changes.
Closed by commit R118:49a2d8a4988a: Rename Look and Feel Explorer to Plasma 
Global Theme Explorer (authored by ognarb).

REPOSITORY
  R118 Plasma SDK

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25692?vs=70774=70797

REVISION DETAIL
  https://phabricator.kde.org/D25692

AFFECTED FILES
  lookandfeelexplorer/package/metadata.desktop

To: ognarb, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25703: Sync scrollbar behavior with GTK applications

[Mikhail Zolotukhin]

gikari created this revision.
gikari added a reviewer: cblack.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  Previously GTK applications respected their own setting on what should happen 
when an user clicks below or above scrollbar slider. Now it is in sync with 
Plasma and Qt applications settings.
  
  Problems:
  
  1. I'm failed to found DConf GTK setting, that is responsible for scrollbar 
behavior. Maybe someone could help.
  2. Setting apply on the go do not work with GTK2 apps, therefore they need to 
be reloaded to respect the new setting.

TEST PLAN
  1. Update `plasma-desktop` and `frameworkintegration`
  2. Launch workspace behavior KCM and change scrollbar setting `Clicking on 
scrollbar track`
  3. GTK3 apps should now respect the setting

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25703

AFFECTED FILES
  kded/configeditor.cpp
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, cblack
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25701: Use setIconProvider instead of setPixmapProvider for KHistoryComboBox

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, Frameworks.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  setPixmapProvider will be deprecated with D25700 


TEST PLAN
  Open open folder dialog, history combobox still has icons

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  prov

REVISION DETAIL
  https://phabricator.kde.org/D25701

AFFECTED FILES
  src/platformtheme/kdirselectdialog.cpp

To: nicolasfella, #plasma, #frameworks
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25691: [KDecoration] Use QIcon::paint

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R113:4afa55e27433: [KDecoration] Use QIcon::paint (authored by 
broulik).

REPOSITORY
  R113 Oxygen Theme

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25691?vs=70772=70786

REVISION DETAIL
  https://phabricator.kde.org/D25691

AFFECTED FILES
  kdecoration/oxygenbutton.cpp

To: broulik, #plasma, hpereiradacosta
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25670: Synchronize decorations buttons order in GTK headerbars

[Mikhail Zolotukhin]

gikari updated this revision to Diff 70782.
gikari added a comment.


  - Change appmenu to icon

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25670?vs=70778=70782

BRANCH
  gtk-decoration-order-sync (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25670

AFFECTED FILES
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, #vdg, cblack
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25670: Synchronize decorations buttons order in GTK headerbars

[Mikhail Zolotukhin]

gikari updated this revision to Diff 70778.
gikari edited the test plan for this revision.
gikari added a comment.


  - Use KConfigWatcher instead of KWin dbus signal

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25670?vs=70705=70778

BRANCH
  gtk-decoration-order-sync (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25670

AFFECTED FILES
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, #vdg, cblack
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25694: Port away from DesktopIcon

[Nicolas Fella]

nicolasfella created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fo

REVISION DETAIL
  https://phabricator.kde.org/D25694

AFFECTED FILES
  kcms/kfontinst/kcmfontinst/FontList.cpp

To: nicolasfella
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25692: Rename Look and Feel Explorer to Plasma Global Theme Explorer

[Carl Schwan]

ognarb created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ognarb requested review of this revision.

TEST PLAN
  not tested

REPOSITORY
  R118 Plasma SDK

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D25692

AFFECTED FILES
  lookandfeelexplorer/package/metadata.desktop

To: ognarb
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25691: [KDecoration] Use QIcon::paint

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Thanks !

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D25691

To: broulik, #plasma, hpereiradacosta
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25691: [KDecoration] Use QIcon::paint

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, hpereiradacosta.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Properly takes into account device pixel ratio. It's what Breeze decoration 
code is doing.

TEST PLAN
  5.17?
  Fixes broken icon positioning in the KCM with high dpi.
  F7796584: Screenshot_20191202_194011.png 

  There's still something funky with the shadows but this patch at least fixes 
the most obvious blunder:
  F7796582: Screenshot_20191202_193955.png 

  Decoration in KWin still looks the same.

REPOSITORY
  R113 Oxygen Theme

REVISION DETAIL
  https://phabricator.kde.org/D25691

AFFECTED FILES
  kdecoration/oxygenbutton.cpp

To: broulik, #plasma, hpereiradacosta
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25361: [Workspace KCM] Expose setting to choose what left-clicking in the scrollbar track does

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:759cec4645e0: [Workspace KCM] Expose setting to choose 
what left-clicking in the scrollbar… (authored by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25361?vs=70580=70770

REVISION DETAIL
  https://phabricator.kde.org/D25361

AFFECTED FILES
  kcms/workspaceoptions/package/contents/ui/main.qml
  kcms/workspaceoptions/workspaceoptions_kdeglobalssettings.kcfg

To: ngraham, #plasma, #vdg, ndavis
Cc: GB_2, davidedmundson, ndavis, gikari, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D25690: [Style KCM] Forward geometryChanged to parent class

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Required so properties `width` and `height` are correct.

TEST PLAN
  Tried to `anchors.fill: parent` an item inside and it didn't show up, noticed 
`width` and `height` were reported as zero.
  This patch fixes that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25690

AFFECTED FILES
  kcms/style/previewitem.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25688: [Style KCM] Set implicit size after show

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Most of the widgets used in the preview initialize only on show, making the 
size hint invalid before it shows.
  It isn't used but just for completeness' sake.

TEST PLAN
  - Size hint is saner now

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25688

AFFECTED FILES
  kcms/style/previewitem.cpp

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25375: Start of the accessibility KCM

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  All the left labels in the formLayouts need to end with a colon, e.g.:
  
Delay: [ 0]
  
  Don't use `onCheckStateChanged` or `onCheckedChanged` for checkboxes when you 
want to handle user interaction;i t causes binding loops. Use `onToggled` 
instead.
  
  Put whitespace between logical sections in the formlayout. For example 
between the audible bell and visual bell sections. You can do this like so:
  
Item {
Kirigami.FormData.isSection: true
}
  
  Change `QtQuick.Controls 2.12` to `QtQuick.Controls 2.11` everywhere; we 
don't formally depends on Qt 5.12 yet.

INLINE COMMENTS

> ActivationGestures.qml:29
> +QQC2.CheckBox {
> +Kirigami.FormData.label: i18n("Activation Gestures")
> +text: i18n("Use gestures for activating sticky keys and slow keys")

This section can be expressed more clearly and compactly as follows:

  Sticky and slow keys: [ ] Use gestures to activate
[ ] Disable after: [99 seconds ^v]

In fact, this section maybe should be moved to the Modifier Keys page, and then 
we can remove the Activation Gestures page entirely.

> ActivationGestures.qml:30
> +Kirigami.FormData.label: i18n("Activation Gestures")
> +text: i18n("Use gestures for activating sticky keys and slow keys")
> +checked: kcm.keyboardSettings.stickyKeys

Can be shortened to "Use gestures for activating sticky and slow keys"

> ActivationGestures.qml:50
> +QQC2.CheckBox {
> +Kirigami.FormData.label: i18n("Notification")
> +text: i18n("Use the system bell whenever a gesture is used to toggle 
> an accessibility feature")

This section doesn't have anything to do with activation gestures. Its 
checkboxes might be better placed on other pages more relevant to their content.

> ActivationGestures.qml:69
> +QQC2.Button {
> +text: i18n("Configure Notifications")
> +onClicked: kcm.configureKNotify();

add ellipsis and an icon (`preferences-desktop-notification`)

> ModifierKeys.qml:38
> +enabled: !kcm.keyboardSettings.isImmutable("StickyKeysLatch") && 
> kcm.keyboardSettings.stickyKeys
> +text: i18n("Lock sticky keys")
> +checked: kcm.keyboardSettings.stickyKeysLatch

Can be shortened to just "Lock"

> ModifierKeys.qml:45
> +enabled: !kcm.keyboardSettings.isImmutable("StickyKeysAutoOff") && 
> kcm.keyboardSettings.stickyKeys
> +text: i18n("Turn off sticky keys when two keys are pressed 
> continuously")
> +checked: kcm.keyboardSettings.stickyKeysAutoOff

Can be shortened to "Disable when two keys are held down"

> ModifierKeys.qml:51
> +enabled: !kcm.keyboardSettings.isImmutable("StickyKeysBeep") && 
> kcm.keyboardSettings.stickyKeys
> +text: i18n("Use system bell whenever a modifier gets latched, locked 
> or unlocked")
> +checked: kcm.keyboardSettings.stickyKeysBeep

Can be shortened to "Use system bell when modifier keys are used" (I *think* 
this is what the string is trying to  communicate; correct me if I'm wrong)

> ModifierKeys.qml:58
> +Kirigami.FormData.label: i18n("Locking Keys")
> +text: i18n("Use system bell whenever a locking key gets toggled")
> +checked: kcm.keyboardSettings.toggleKeysBeep

Can be slightly shortened to "Use system bell when locking keys are toggled"

> ModifierKeys.qml:64
> +QQC2.CheckBox {
> +text: i18n("Show a notification for modifier or locking key state 
> changes")
> +checked: kcm.keyboardSettings.kNotifyModifiers

Can be shortened to "Show notification when modifier or locking keys are used"

> MouseNavigation.qml:31
> +Kirigami.FormData.label:  i18n("Activation Gestures")
> +text: i18n("Move pointer with keyboard (using the num pad)")
> +checked: kcm.mouseSettings.mouseKeys

Change to "Enable using keyboard number pad to move cursor"

> MouseNavigation.qml:35
> +enabled: !kcm.mouseSettings.isImmutable("MouseKeys")
> +}
> +QQC2.SpinBox {

Add spacing after this

> ScreenReader.qml:30
> +Kirigami.FormData.label:  i18n("Screen Reader")
> +text: i18n("enabled")
> +checked: kcm.screenReaderSettings.enabled

In this case, just put the whole text in the checkbox:

  [ ] Enable screen reader
  [ Launch Orca Configuration...]

> ScreenReader.qml:36
> +QQC2.Button {
> +text: i18n("Launch Orca Configuration")
> +onClicked: kcm.screenReaderSettings.launchOrcaConfiguration()

What's Orca? Isn't that a kind of whale? :p Make change the text to be 
"Configure Orca Screen Reader..."

> ScreenReader.qml:37
> +text: i18n("Launch Orca Configuration")
> +onClicked: kcm.screenReaderSettings.launchOrcaConfiguration()
> +enabled: !kcm.screenReaderSettings.isImmutable("Enabled")

If Orca isn't installed, clicking on this button does nothing. In this 

D25614: [System Tray] Clean up popup code

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:beac5919274c: [System Tray] Clean up popup code (authored 
by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25614?vs=70748=70762

REVISION DETAIL
  https://phabricator.kde.org/D25614

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: filipf, #plasma, broulik, ngraham
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava added a comment.


  Missing apply button being enabled seems something related to 
ManagedConfigModule. I don't know what to do there yet.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 70754.
tcanabrava marked 6 inline comments as done.
tcanabrava added a comment.


  - Add missing setButtons
  - Fix Typo

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=70751=70754

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 70751.
tcanabrava marked an inline comment as done.
tcanabrava added a comment.


  - Fix factory name

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=70749=70751

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25375: Start of the accessibility KCM

[Tomaz Canabrava]

tcanabrava updated this revision to Diff 70749.
tcanabrava added a comment.


  - Fixes
  - Fixes texts and UI
  - Simplify Algorithm
  - Fix Enable / Disable status

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25375?vs=70103=70749

BRANCH
  kcm_acess

REVISION DETAIL
  https://phabricator.kde.org/D25375

AFFECTED FILES
  kcms/access/CMakeLists.txt
  kcms/access/accessibility.ui
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop
  kcms/access/kcmaccess.h
  kcms/access/kcmaccessibilitybell.kcfg
  kcms/access/kcmaccessibilitybell.kcfgc
  kcms/access/kcmaccessibilitykeyboard.kcfg
  kcms/access/kcmaccessibilitykeyboard.kcfgc
  kcms/access/kcmaccessibilitymouse.kcfg
  kcms/access/kcmaccessibilitymouse.kcfgc
  kcms/access/kcmaccessibilityscreenreader.kcfg
  kcms/access/kcmaccessibilityscreenreader.kcfgc
  kcms/access/package/contents/ui/ActivationGestures.qml
  kcms/access/package/contents/ui/Bell.qml
  kcms/access/package/contents/ui/KeyboardFilters.qml
  kcms/access/package/contents/ui/ModifierKeys.qml
  kcms/access/package/contents/ui/MouseNavigation.qml
  kcms/access/package/contents/ui/ScreenReader.qml
  kcms/access/package/contents/ui/main.qml
  kcms/access/package/metadata.desktop

To: tcanabrava, ngraham
Cc: ognarb, mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D25614: [System Tray] Clean up popup code

[Filip Fila]

filipf updated this revision to Diff 70748.
filipf added a comment.


  onToggled instead of onClicked

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25614?vs=70577=70748

BRANCH
  code-cleanup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25614

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml

To: filipf, #plasma, broulik
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25681: Get icon size from QStyle

[David Redondo]

This revision was automatically updated to reflect the committed changes.
Closed by commit R103:3e01b440e53a: Get icon size from QStyle (authored by 
davidre).

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25681?vs=70740=70741

REVISION DETAIL
  https://phabricator.kde.org/D25681

AFFECTED FILES
  treeview.cpp

To: davidre, #plasma, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, davidre, fbampaloukas, 
GB_2, ragreen, ahmadsamir, ZrenBot, ngraham, alexeymin, kpiwowarski, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, asturmlechner, cfeck, abetts, 
cullmann, vkrause, sebas, cordlandwehr, apol, ahiemstra, mart, knauss, dfaure

D25681: Get icon size from QStyle

[David Redondo]

davidre updated this revision to Diff 70740.
davidre added a comment.


  const

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25681?vs=70739=70740

BRANCH
  iconsize (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25681

AFFECTED FILES
  treeview.cpp

To: davidre, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, davidre, fbampaloukas, 
GB_2, ragreen, ahmadsamir, ZrenBot, ngraham, alexeymin, kpiwowarski, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, asturmlechner, cfeck, abetts, 
cullmann, vkrause, sebas, cordlandwehr, apol, ahiemstra, mart, knauss, dfaure

D25681: Get icon size from QStyle

[David Redondo]

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  The KIconLoader method will go away

REPOSITORY
  R103 KMenu Editor

BRANCH
  iconsize (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25681

AFFECTED FILES
  treeview.cpp

To: davidre
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Monday meeting notes for 2/11/2019

[Marco Martin]

Kai Uwe
plasma-browser-integration:
* Made a new release \o/
https://blog.broulik.de/2019/11/plasma-browser-integration-1-7/
* Figured out how to fix Spotify Web player for Firefox: D25569
Diff 25569 "Also overwrite document.createElement using
exportFunction" [Accepted] https://phabricator.kde.org/D25569
* Removal of Position change signal, will address comments when I come
to it: D25403
Diff 25403 "Drop Position change signal and support Seeked signal"
[Needs Review] https://phabricator.kde.org/D25403
* Made a captive portal workflow improvement, which might be too
convoluted :) D25466
Diff 25466 "Add Captive Portal auto-refresh handling" [Needs Revision]
https://phabricator.kde.org/D25466
Notifications:
* Notification popups now move out of the way of System Tray rather
than just hiding
* Ensures you won't miss notifications that are a result of System
Tray action,
* e.g. pairing confirmation on Bluetooth or captive portal login
after Wifi connect
Other:
* Fixed Style KCM colors being dull
* There's no way to fake QWidget::isActiveWindow() so I blunlt
override the Inactive palette with the Active one
* Also please review D25461
Diff 25461 "[KCM GridDelegate] Use non-attached ToolTip" [Needs
Review] https://phabricator.kde.org/D25461
* Ported Breeze KDecoration from QPropertyAnimation to QVariantAnimation
* My GTK mouse cursors are incorrect after gtk-kded settings sync introduction
* Tried to fix but D25540 didn't help
Diff 25540 "Add default value for cursor theme" [Closed]
https://phabricator.kde.org/D25540
* Anyone knowledgable in this stuff (gtk cursors) please have a look :/

Arjen
* I fixed the Kirigami InlineMessage that was always showing actions
in the overflow menu (https://phabricator.kde.org/D25570 for
reference, already merged)
 Diff 25570 "Fix InlineMessage actions always being placed in overflow
menu" [Closed] https://phabricator.kde.org/D25570
* I finally got around to merging the ACPI-to-sysfs patch for
ksysguard (https://phabricator.kde.org/D25018)
 Diff 25018 "Move ACPI battery information from /proc/acpi to /sys"
[Closed] https://phabricator.kde.org/D25018
* so now ksysguard can report on battery usage again :)


Leinir
* the things i would like a look on are
https://phabricator.kde.org/D25440 and
https://phabricator.kde.org/D25441 and
https://phabricator.kde.org/D25562  :)
* Diff 25440 "Set a proper agent string for Attica requests" [Needs
Review] https://phabricator.kde.org/D25440
* Diff 25441 "Send along the config name with requests" [Needs Review]
https://phabricator.kde.org/D25441
* Diff 25562 "Add some friendly "report bugs here" links" [Needs
Review] https://phabricator.kde.org/D25562

David Edmundson
* Firstly, that QtSVG bug is fixed (by some Qt guy) \o/
* 5.14 is set to be a drama free release
* assuming there's no last minute changes
* I fixed a super annoying QtWayland bug where all icons would animate
every frame...even if they only have one frame
* I've continued some Qt6 preparing in plasma. Trying to phase out
SmallIcon, some overloads etc.
* and I worked more on a massive kwin patch to replace all the Kwin
Effect Frames (the lables in effects) with a tiny QtQuick scene using
my EffectQuickView patch is +300 lines -1500 lines   so I'm quite
pleased with it
* I would like some help finishing D25326 to get Plasma's QSFPM into KItemModels
  Diff 25326 "Move Plasma's SortFilterProxyModel into KItemModel's QML
plugin" [Needs Review] https://phabricator.kde.org/D25326

Nico Fe
* Did some performance improvement for archive loading in Ark
* Diff 25565 "Optimize ArchiveModel::cleanFileName" [Needs Review]
https://phabricator.kde.org/D25565
* Besides that mostly misc Qt6/KF6 prep
* Most interesting Diff 25660 "Decouple KBookmarksMenu from
KActionCollection" [Needs Review] https://phabricator.kde.org/D25660
* Smaller cleanup in KBookmarks:
* Diff 25654 "Rename actions to be consistent" [Needs Review]
https://phabricator.kde.org/D25654
* Diff 25653 "[bookmarksmenu] Improve variable name" [Needs Review]
https://phabricator.kde.org/D25653
In other news:
* Diff 25630 "Port to json metadata" [Needs Review]
https://phabricator.kde.org/D25630
* Diff 25533 "Deprecate KFileWidget::toolBar" [Needs Review]
https://phabricator.kde.org/D25533
* Diff 25443 "[chmodjob] Port away from QLinkedList" [Needs Review]
https://phabricator.kde.org/D25443
* Diff 25378 "Get icon size from QStyle instead of KIconLoader" [Needs
Review] https://phabricator.kde.org/D25378

Aleix
* KWin
* I sent a first iteration of the stylus (tablet) input for
wayland https://phabricator.kde.org/D25663
* Will still need some work (which I have drafted locally) to
implement the right protocols
* plasma mobile
* Did some testing there, realised plasma-settings wasn't calling
::load on its modules like system settings do. Now they load properly.
* other than that, some kirigami/discover bug triaging session

Marco
# Plasma
* better support for file selectors in plasmoids and config dialogs
* 

D25672: Port to std::sort

[Kai Uwe Broulik]

broulik added a comment.


  Does this not need an `#include `?

REPOSITORY
  R122 Powerdevil

BRANCH
  qsort

REVISION DETAIL
  https://phabricator.kde.org/D25672

To: nicolasfella, #plasma, apol
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25671: Fix git builds against Qt 5.14

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R129:771ed0c4f8c2: Fix git builds against Qt 5.14 (authored by 
apol).

REPOSITORY
  R129 Window Decoration Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25671?vs=70706=70734

REVISION DETAIL
  https://phabricator.kde.org/D25671

AFFECTED FILES
  CMakeLists.txt

To: apol, #frameworks, vkrause
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25614: [System Tray] Clean up popup code

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> filipf wrote in ExpandedRepresentation.qml:103
> @broulik?

Both are fine I guess but `onToggled` is indeed more correct

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25614

To: filipf, #plasma, broulik
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25614: [System Tray] Clean up popup code

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> ngraham wrote in ExpandedRepresentation.qml:103
> `onToggled`?

@broulik?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D25614

To: filipf, #plasma, broulik
Cc: ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25637: Port away from kglobalsettings

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> apol wrote in componentchooserterminal.cpp:87
> No need to notify here?

I can't find someone else listening to this

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25637

To: davidedmundson, #plasma
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

D25668: Port away from deprecated KIconLoader::SmallIcon

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:121da761bef1: Port away from deprecated 
KIconLoader::SmallIcon (authored by davidedmundson).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25668?vs=70702=70729

REVISION DETAIL
  https://phabricator.kde.org/D25668

AFFECTED FILES
  Modules/base/os_base.h

To: davidedmundson, #plasma, nicolasfella
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25670: Synchronize decorations buttons order in GTK headerbars

[Kai Uwe Broulik]

broulik added a comment.


  > It would be sensible to use an individual signal. I would like to hear an 
advice about its naming.
  
  Alternatively you could have the KWin decoration KCM use `writeEntry` with 
`Notify` flag and then use a `KConfigWatcher` here instead of connecting to 
KWin's generic DBus signal.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D25670

To: gikari, #vdg, cblack
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart