D26238: Improve context menu

[Michail Vourlakos]

mvourlakos added a comment.


  In D26238#583413 , @trmdi wrote:
  
  > 1. It still works for other cases.
  
  
  Do you cycle in settings tabs with Meta+W, between Layouts and Preferences ?
  
  > 3. "Configure Application" sounds a bit unclearly.  And it can confuse 
users with "Configure Application Dashboard". "Configure Latte Global 
Settings..." is too long?
  
  it is too long... I can accept suggestions for [Verb+Noun] cases
  
  In D26238#583414 , @trmdi wrote:
  
  > 4. I want to separate between **View's items** (Add widget, Edit View) and 
**Latte's items** (Layouts, Configure Latte) because they are two different 
groups (one is the global setting, one is the view setting) (See the After 
screenshot)
  
  
  I wont object for now, but I will conclude if I will keep the second 
separator after using the program with the changes for some days. The order of 
the actions must be the one referenced though.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Tranter Madi]

trmdi added a comment.


  4. I want to separate between **View's items** (Add widget, Edit View) and 
**Latte's items** (Layouts, Configure Latte) because they are two different 
groups.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Tranter Madi]

trmdi added a comment.


  1. It still works for other cases.
  
  3. "Configure Application" sounds a bit unclearly.  And it can confuse users 
with "Configure Application Dashboard".
  
  "Configure Latte Global Settings..." is too long?

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Michail Vourlakos]

mvourlakos added a comment.


  the [Verb+Noun] sounds logical, updated names in my last comment

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Michail Vourlakos]

mvourlakos added a comment.


  This commit needs to be split in different commits.
  Based on the approach I wil describe the issues of the commit and in what 
changes I can approve or not.
  
  SPLITTED COMMITS
  
  1. The showLatteSettingsDialog() is used from more places and you have 
changed its behavior. The page that
  
  this function takes is used as the first page to show when the window is 
created, after that it toggles between
  tabs. This is used ALSO from [Meta+W] global shortcut and Latte trademark 
icon in Dock Settings in order to show
  the Latte Global Preferences. From my understanding you need to create a new 
function that is not a toggler but
  rather sets specific settings tab all the time
  
  2. The context menu changes MUST be the same in TWO different places, because 
otherwise showing context menu will be different between tasks and applets.
  
  
  
a. containmentactions/contextmenu/menu.cpp
b. plasmoid/package/contents/ui/ContextMenu.qml
  
  3. Renames
  
  
  
a. Layouts->Configure TO Layouts->Manage...
b. Dock Settings -> Edit Dock... 
c. Latte Global Settings... -> Application Settings
  
  4. Order:
  
  
  
a.  -separator-
b. Layouts->
c. Application Settings...
d. Add Widgets...
e. Edit Dock...
f.  -separator- [only for Tasks plasmoid]
g.  Close... [only for Tasks plasmoid]

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Tranter Madi]

trmdi updated this revision to Diff 72228.
trmdi added a comment.


  - Add a new separator and change addWidget's icon

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26238?vs=72227=72228

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

AFFECTED FILES
  app/layouts/manager.cpp
  app/settings/settingsdialog.cpp
  app/settings/settingsdialog.h
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h

To: trmdi, #latte_dock, #vdg, mvourlakos
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Noah Davis]

ndavis added a comment.


  In D26238#583390 , @trmdi wrote:
  
  > In D26238#583389 , @ndavis wrote:
  >
  > > In the plasma panel context menu, add widgets and edit panel are below 
the separator
  >
  >
  > Maybe I need to create a new separator at the line 126 instead of reusing 
it. Is it ok if there are 2 separators in a context menu?
  
  
  Sounds reasonable, although I'm not sure they're unrelated enough that they 
need a separator. I'll leave it up to your judgement.
  
  > What about the other changes?
  
  They look fine.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Tranter Madi]

trmdi added a comment.


  In D26238#583389 , @ndavis wrote:
  
  > In the plasma panel context menu, add widgets and edit panel are below the 
separator
  
  
  Maybe I need to create a new separator at the line 126 instead of reusing it.
  What about the other changes?

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Noah Davis]

ndavis added a comment.


  In the plasma panel context menu, add widgets and edit panel are below the 
separator

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Noah Davis]

ndavis added a comment.


  This seems inconsistent with the Plasma panel context menu: F7844566: 
Screenshot_20191227_000605.png 

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26238

To: trmdi, #latte_dock, #vdg
Cc: ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26238: Improve context menu

[Tranter Madi]

trmdi created this revision.
trmdi added reviewers: Latte Dock, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
trmdi requested review of this revision.

REVISION SUMMARY
  Merge branch 'master' of https://anongit.kde.org/latte-dock

REPOSITORY
  R878 Latte Dock

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26238

AFFECTED FILES
  app/layouts/manager.cpp
  app/settings/settingsdialog.cpp
  app/settings/settingsdialog.h
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h

To: trmdi, #latte_dock, #vdg
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26217: Add standard pen widths and replace hardcoded numbers

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  ...And after these patches land, let's do the doxygen-friendly comment 
formatting all at once in another patch.

REPOSITORY
  R31 Breeze

BRANCH
  replace-hardcoded (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26217

To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26217: Add standard pen widths and replace hardcoded numbers

[Noah Davis]

ndavis updated this revision to Diff 72223.
ndavis added a comment.


  Change comment formatting

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26217?vs=72157=72223

BRANCH
  replace-hardcoded (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26217

AFFECTED FILES
  kstyle/breeze.h
  kstyle/breezehelper.cpp
  kstyle/breezehelper.h

To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25624: Don't use qmlRegisterType with QT-5.14

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R258:92ffa670f0e5: Dont use qmlRegisterType with QT-5.14 
(authored by plevine, committed by ngraham).

REPOSITORY
  R258 Plymouth KCM

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25624?vs=70645=72221

REVISION DETAIL
  https://phabricator.kde.org/D25624

AFFECTED FILES
  src/kcm.cpp

To: plevine, jriddell, #plasma, davidedmundson
Cc: zzag, davidedmundson, asturmlechner, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26212: [Applet] Remember devices to raise maximum volume

[Nathaniel Graham]

ngraham added a comment.


  Nice work.

INLINE COMMENTS

> StreamListItem.qml:29
>  property bool onlyOne: false
> +readonly property string maxVolumeTarget: if (Client) {return 
> Client.name}
>  

Could be simplified and hardened to `Client ? Client.name : ""`

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26212

To: gvgeo, #plasma, drosca
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

[Nathaniel Graham]

ngraham added a comment.


  I think there is a deeper UI issue here in that there are two ways to raise 
the maximum volume that live in different places: one globally in the settings 
page, and another on a per-app/device basis accessed from the app/device's 
hamburger menu. Even if all the bugs with the individual modes are fixed 
(thanks for that), having two ways to do the same thing, with only differences 
in scope, seems like unnecessary specificity that is not likely to help most 
users. I wonder if we should instead unify on one or another, or at least only 
show the config UI for raising the maximum volume in one place rather than two.
  
  What do you think?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26234

To: gvgeo, #vdg, #plasma, drosca
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

[Nathaniel Graham]

ngraham added a comment.


  Actually I spaced for a moment and just remembered that we already have a 
mockup in T10470  that shows how we'd like 
this to work in the future:
  
  F7842082: audio tray.png 
  
  Basically the global "raise maximum volume" setting would be moved out of the 
settings window and into a footer on the main UI.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26234

To: gvgeo, #vdg, #plasma, drosca
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26217: Add standard pen widths and replace hardcoded numbers

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ndavis wrote in breeze.h:179
> It's a Doxygen style. If you do it, KDevelop shows the comments in the 
> tooltips for the commented functions, classes and variables.

Probably makes sense to do this universally all at once, rather than in little 
bits and pieces.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26217

To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26217: Add standard pen widths and replace hardcoded numbers

[Noah Davis]

ndavis added inline comments.

INLINE COMMENTS

> ngraham wrote in breeze.h:179
> Why three slashes for these comments?

It's a Doxygen style. If you do it, KDevelop shows the comments in the tooltips 
for the commented functions, classes and variables.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26217

To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D9875: Extend parsing ssh prompt

[Nathaniel Graham]

ngraham added a comment.


  In D9875#583139 , @fvogt wrote:
  
  > In D9875#583106 , @pali wrote:
  >
  > > Is there anything else or something which blocks merging this change into 
upstream git repository?
  >
  >
  > Do you have a contributor account? If not, I can push it.
  
  
  I Recently learned that you can find out this information for yourself by 
searching through https://websvn.kde.org/trunk/kde-common/accounts?view=markup
  
  It looks like @pali does indeed have a contributor account. So @pali, feel 
free to land the patch yourself using `arc land`. For more details, see 
https://community.kde.org/Infrastructure./Phabricator#Step_3:_Land_your_diff

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9875

To: pali, fvogt
Cc: ngraham, fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26217: Add standard pen widths and replace hardcoded numbers

[Nathaniel Graham]

ngraham added a comment.


  +1, seems sensible to me, but probably wait for @hpereiradacosta's go-ahead.

INLINE COMMENTS

> breeze.h:179
> + */
> +/// The standard pen stroke width for symbols.
> +static constexpr qreal Symbol = 1.01;

Why three slashes for these comments?

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26217

To: ndavis, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26121: Kicker/RecentDocument display file path as decoration

[Kevin Ottens]

ervin accepted this revision.
ervin added a comment.


  LGTM, might need an update if D26122  
lands though.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  arcpatch-D26121

REVISION DETAIL
  https://phabricator.kde.org/D26121

To: meven, #vdg, #plasma, ngraham, ervin, hein
Cc: davidre, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26235: fix latte-dock command not showing in README

[Maxim Zalata]

zlatin created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zlatin requested review of this revision.

REPOSITORY
  R878 Latte Dock

BRANCH
  fix-readme (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26235

AFFECTED FILES
  README.md

To: zlatin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26234: [Applet] Unify 'raise maximum volume' and 'maximum volume'

[George Vogiatzis]

gvgeo created this revision.
gvgeo added reviewers: VDG, Plasma, drosca.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Unify 'raise maximum volume' menu option and 'maximum volume' configuration 
setting.
  
  Make default 'maximum volume' 150.
  For volume control check 'raise maximum volume' option, to use 'maximum 
volume'.
  Volume slider use 'maximum volume', if 'raise maximum volume' is enabled.
  
  BUG: 385041
  FIXED-IN: 5.18.0
  Depends on D26212 

TEST PLAN
  Before:
  Volume control from shortcuts will use 'maximum volume' for all devices.
  Slider will set maximum range 150 for 'raise maximum volume' option.
  After:
  'Raise maximum volume' respects 'maximum volume' and,
  'maximum volume' does not work without 'Raise maximum volume'.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  max4

REVISION DETAIL
  https://phabricator.kde.org/D26234

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml

To: gvgeo, #vdg, #plasma, drosca
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26228: KCM Fonts ConfigModule to ManagedConfigModule

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> fonts.cpp:600
>  
> -void KFonts::updateNeedsSave()
> -{
> -setNeedsSave(m_settings->isSaveNeeded() || 
> m_fontAASettings->needsSave());
> +bool KFonts::isSaveNeeded() const {
> +return m_fontAASettings->needsSave();

{ should be on its own line

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26228

To: bport, #plasma, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D9875: Extend parsing ssh prompt

[Fabian Vogt]

fvogt added a comment.


  In D9875#583106 , @pali wrote:
  
  > Is there anything else or something which blocks merging this change into 
upstream git repository?
  
  
  Do you have a contributor account? If not, I can push it.

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9875

To: pali, fvogt
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D9875: Extend parsing ssh prompt

[Pali Rohár]

pali added a comment.


  Is there anything else or something which blocks merging this change into 
upstream git repository?

REPOSITORY
  R105 KDE SSH Password Dialog

REVISION DETAIL
  https://phabricator.kde.org/D9875

To: pali, fvogt
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26229: Add immutability to kcm fonts

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REVISION SUMMARY
  Add immutability to kcm fonts, apply all willa apply font for mutable font 
type only

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26229

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/package/contents/ui/main.qml

To: bport, #plasma, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26228: KCM Fonts ConfigModule to ManagedConfigModule

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26228

AFFECTED FILES
  kcms/fonts/fonts.cpp
  kcms/fonts/fonts.h

To: bport, #plasma, ervin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26052: KCM Cursor Theme : Use ManagedConfigModule

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:1e4271fb4cc3: KCM Cursor Theme : Use ManagedConfigModule 
(authored by bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26052?vs=71958=72191

REVISION DETAIL
  https://phabricator.kde.org/D26052

AFFECTED FILES
  kcms/cursortheme/cursorthemesettings.kcfgc
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h

To: bport, #plasma, ervin, crossi, ngraham
Cc: ngraham, meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26051: Fix GHNS bug when we add a cursor theme you can't delete it or choose cursor size

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:81747d91c1dd: Fix GHNS bug when we add a cursor theme you 
cant delete it or choose cursor… (authored by bport).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26051?vs=71688=72190

REVISION DETAIL
  https://phabricator.kde.org/D26051

AFFECTED FILES
  kcms/cursortheme/kcmcursortheme.cpp

To: bport, #plasma, ervin, meven, crossi
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D24847: KCM Icons fix theme selected when we hit delete theme

[Benjamin Port]

bport added a comment.


  In D24847#574269 , @ngraham wrote:
  
  > So what is this patch doing now? When I delete the selected icon theme, the 
selection rect moves to the first one in the grid, causing the theme to change 
when you click Apply. This seems non-ideal.
  >
  > Could it move selection over to the currently *in use* theme, maybe?
  
  
  Not sure why you had this behavior
  So currently behavior is :
  
  - if you delete a theme the current one stay selected
  - if you delete the current one, next one is selected

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24847

To: bport, mart, ervin, #plasma, crossi, ngraham, davidedmundson
Cc: bport, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24846: Port kcm icons to kconfigxt

[Benjamin Port]

bport updated this revision to Diff 72189.
bport added a comment.


  Update according to ervin feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D24846?vs=71956=72189

REVISION DETAIL
  https://phabricator.kde.org/D24846

AFFECTED FILES
  kcms/icons/CMakeLists.txt
  kcms/icons/changeicons.cpp
  kcms/icons/iconsizecategorymodel.cpp
  kcms/icons/iconsizecategorymodel.h
  kcms/icons/iconsmodel.cpp
  kcms/icons/iconsmodel.h
  kcms/icons/iconssettings.cpp
  kcms/icons/iconssettings.h
  kcms/icons/iconssettingsbase.kcfg
  kcms/icons/iconssettingsbase.kcfgc
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/IconSizePopup.qml
  kcms/icons/package/contents/ui/main.qml

To: bport, ervin, mart, #plasma, crossi
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart