D26646: [Applet Configuration] Work around bad kerning in sidebar labels

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  I added a test case to https://bugreports.qt.io/browse/QTBUG-49646, BTW. 
Maybe that will help the Qt folks find the source of the issue.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-applet-config-sidebar-label-kerning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26646

To: filipf, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

[Nathaniel Graham]

ngraham added subscribers: davidedmundson, mart.
ngraham added a comment.


  Yes you would need to add the margins by reducing the size of the minimum 
width.
  
  Since we found a reliable workaround, I wonder if we should just use that 
data to pinpoint the problem in Qt and fix it there... Maybe @mart or 
@davidedmundson could help with that.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26646

To: filipf, #plasma, ngraham
Cc: mart, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

[Filip Fila]

filipf updated this revision to Diff 73474.
filipf removed subscribers: mart, davidedmundson.
filipf added a comment.


  - make it work with multi line strings
  - restore side margins

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26646?vs=73473=73474

BRANCH
  fix-applet-config-sidebar-label-kerning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26646

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

To: filipf, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart, davidedmundson

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

[Filip Fila]

filipf added a comment.


  Oops, looks like it breaks those smallSpacing margins as well:
  
  F7881860: image.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26646

To: filipf, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  This workaround breaks with multi-line strings: F7881852: 
Screenshot_20200113_164236.png 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26646

To: filipf, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22176: Rework system tray settings

[Nathaniel Graham]

ngraham added a comment.


  Oops.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22176

To: nicolasfella, #plasma, #vdg
Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26646: [Applet Configuration] Work around bad kerning in sidebar labels

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  One way that https://bugreports.qt.io/browse/QTBUG-49646 manifests itself is 
when we have single line labels centered using "horizontalAlignment: 
Text.AlignHCenter".
  
  This patch works around the kerning bug using a different centering method: 
using the layout's alignment and setting the maximum width.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-applet-config-sidebar-label-kerning (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26646

AFFECTED FILES
  desktoppackage/contents/configuration/ConfigCategoryDelegate.qml

To: filipf
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22176: Rework system tray settings

[Konrad Materka]

kmaterka added a comment.


  @ngraham You commented in wrong revision, this was is abandoned :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22176

To: nicolasfella, #plasma, #vdg
Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26586: [SystemTray] Rework system tray settings

[Konrad Materka]

kmaterka updated this revision to Diff 73470.
kmaterka added a comment.


  Fixes for column size, it is calculated dynamically now

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26586?vs=73414=73470

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26586

AFFECTED FILES
  applets/systemtray/package/contents/config/config.qml
  applets/systemtray/package/contents/config/main.xml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/ConfigGeneral.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D26643: [windowsystem] Fix compilation with no-deprecated build of KWindowSystem

[Vlad Zahorodnii]

zzag added a comment.


  See D26633 

REPOSITORY
  R130 Frameworks integration plugin using KWayland

REVISION DETAIL
  https://phabricator.kde.org/D26643

To: zzag, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26643: [windowsystem] Fix compilation with no-deprecated build of KWindowSystem

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: KWin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  This change ensures that kwayland-integration can be built with a
  version of KWS that doesn't have any deprecated stuff. I assume that no
  distro ships such builds of KWS and it's only a developer thing.
  
  I didn't backport KWINDOWSYSTEM_BUILD_DEPRECATED_SINCE macro because
  the next release of Plasma (5.18) depends on KF 5.66.

REPOSITORY
  R130 Frameworks integration plugin using KWayland

BRANCH
  fix-no-deprecated-build

REVISION DETAIL
  https://phabricator.kde.org/D26643

AFFECTED FILES
  src/windowsystem/windoweffects.cpp
  src/windowsystem/windoweffects.h

To: zzag, #kwin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> colors.cpp:128
>  
> -const auto newEntries = m_newStuffDialog->installedEntries();
> -// If one new theme was installed, select the first color file 
> in it
> -if (newEntries.count() == 1) {
> -QStringList installedThemes;
> +#if KNEWSTUFFCORE_VERSION_MAJOR==5 && KNEWSTUFFCORE_VERSION_MINOR>=67
> +// If one new theme was installed, select the first color file in it

This wraps a lot of existing functionality into that conditional as well. Was 
all of that stuff broken and useless without D26543 
?

Everything seems to work anyway, but I'm curious to know if everything here 
needs to be wrapped up in this.

> kcmcursortheme.cpp:433
>  {
> -KNS3::DownloadDialog dialog("xcursor.knsrc", nullptr);
> -if (dialog.exec()) {
> -KNS3::Entry::List list = dialog.changedEntries();
> -if (!list.isEmpty()) {
> -for (const KNS3::Entry& entry : list) {
> -if (entry.status() == KNS3::Entry::Deleted) {
> -for (const QString& deleted : entry.uninstalledFiles()) {
> -QVector list = 
> deleted.splitRef(QLatin1Char('/'));
> -if (list.last() == QLatin1Char('*')) {
> -list.takeLast();
> -}
> -QModelIndex idx = 
> m_themeModel->findIndex(list.last().toString());
> -if (idx.isValid()) {
> -m_themeModel->removeTheme(idx);
> -}
> +#if KNEWSTUFFCORE_VERSION_MAJOR==5 && KNEWSTUFFCORE_VERSION_MINOR>=67
> +for (int i = 0; i < changedEntries.count(); ++i) {

ditto

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D22176: Rework system tray settings

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ConfigGeneral.qml:23
> +import QtQuick 2.5
> +import QtQuick.Controls 1.4 as QQC1
> +import QtQuick.Controls 2.5 as QQC2

there are no longer any QQC1 items here; you can remove this import entirely

> ConfigGeneral.qml:65
> +Layout.fillWidth: true
> +Layout.fillHeight: true
> +

These have no effect because the ListView isn't in a layout; you can just 
remove them

> ConfigGeneral.qml:86
>  
> -Item {
> -Kirigami.FormData.isSection: true
> -Kirigami.FormData.label: i18n("Categories")
> -}
> +QIconItem {
> +id: theIcon

Use a `Kirigami.Icon` instead as it has better scaling behavior

> ConfigGeneral.qml:101
> +enabled: !showAllCheckBox.checked
> +model: isPlasmoid ? [i18n("Auto"), i18n("Shown"), 
> i18n("Hidden"), i18n("Disabled")] : [i18n("Auto"), i18n("Shown"), 
> i18n("Hidden")]
> +

Might be cleaner to set up the combobox model like so: 
https://cgit.kde.org/kdeplasma-addons.git/tree/wallpapers/potd/contents/ui/config.qml#n82,
 and then you could simplify `currentIndex` and `onActivated` a lot

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22176

To: nicolasfella, #plasma, #vdg
Cc: kmaterka, filipf, broulik, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26586: [SystemTray] Rework system tray settings

[Konrad Materka]

kmaterka added a comment.


  In D26586#593549 , @ngraham wrote:
  
  > The alignment for items with shortcuts is a bit odd: F7881593: 
Screenshot_20200113_130125.png 
  
  
  Yes, I know. Shortcuts can be really long, you can have some crazy 
combinations like "Meta+Ctrl+Shift+Z" which is very wide. From the other side, 
it should not be that bad... I will work on this, let's see what can be 
achieved.
  
  > Maybe for the combobox item texts, try this:
  > 
  > - Shown when relevant
  > - Always shown
  > - Always hidden
  > - Disabled
  
  OK, I forgot about this, I will change that.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D26640: [applets/weather] Port weather station picker to QQC2+ListView

[Nathaniel Graham]

ngraham updated this revision to Diff 73464.
ngraham added a comment.


  Re-add busy indicator

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26640?vs=73459=73464

BRANCH
  port-to-listview-in-scrollview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26640

AFFECTED FILES
  applets/weather/package/contents/ui/config/WeatherStationPicker.qml

To: ngraham, #vdg, #plasma, broulik
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26636: [Widget Explorer] Work around bad kerning

[Filip Fila]

filipf updated this revision to Diff 73463.
filipf added a comment.


  don't repeat the same code twice

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26636?vs=73462=73463

BRANCH
  widget-explorer-kerning-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26636

AFFECTED FILES
  desktoppackage/contents/explorer/AppletDelegate.qml

To: filipf, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26636: [Widget Explorer] Work around bad kerning

[Filip Fila]

filipf updated this revision to Diff 73462.
filipf added a comment.


  remove added whitespace

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26636?vs=73447=73462

BRANCH
  widget-explorer-kerning-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26636

AFFECTED FILES
  desktoppackage/contents/explorer/AppletDelegate.qml

To: filipf, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26640: [applets/weather] Port weather station picker to QQC2+ListView

[Nathaniel Graham]

ngraham added a comment.


  For me it was instant after this patch. But I'll re-add it.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26640

To: ngraham, #vdg, #plasma, broulik
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26640: [applets/weather] Port weather station picker to QQC2+ListView

[Fabian Vogt]

fvogt added a comment.


  When I tested this, there was a very noticable delay (~10s) between starting 
the search and items appearing, so the busy indicator is IMO necessary.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D26640

To: ngraham, #vdg, #plasma, broulik
Cc: fvogt, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:3e9cd8d1e551: Make checkboxes/radiobuttons use Window 
Background in windows and View… (authored by ndavis).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26639?vs=73458=73460

REVISION DETAIL
  https://phabricator.kde.org/D26639

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26640: [applets/weather] Port weather station picker to QQC2+ListView

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This fixes the bug I introduced when I fixed 414442 in the wrong way, makes 
the UI more
  recular, removes a QQC1 dep, and makes the view fully keyboard-navigeable.
  
  BUG: 414442
  FIXED-IN: 5.18.0

TEST PLAN
  F7881687: Peek 2020-01-13 13-53.webm 

REPOSITORY
  R114 Plasma Addons

BRANCH
  port-to-listview-in-scrollview (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26640

AFFECTED FILES
  applets/weather/package/contents/ui/config/WeatherStationPicker.qml

To: ngraham, #vdg, #plasma, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  In D26639#593537 , @ndavis wrote:
  
  > In D26572#593511 , 
@hpereiradacosta wrote:
  >
  > > > Otherwise, it should be Window Background. Doing it that way would 
preserve the original look in most cases.
  > >
  > > This would lead to some regression (I think) for unchecked checkboxes in 
lists. (because of window background being used).
  >
  >
  > This doesn't seem to have any visual regressions like that.
  
  
  That works yes (since you test for parent item view). 
  Also yes, feel free to remove the now unused isItemSelected.
  Thanks for the patch !

REPOSITORY
  R31 Breeze

BRANCH
  checkbox-radiobutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26639

To: ndavis, #vdg, #breeze, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[Christoph Feck]

cfeck added a comment.


  The radio stream I use (via mpv) shows the interpret and title information 
for all titles it plays. Also, when mpv plays a local file, ttitle information 
about the file is added there. I don't use any other media streams, so I cannot 
comment on the general availability of this additional stream information.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: cfeck, ndavis, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

[Powerdevil] [Bug 350365] Battery monitor in tray randomly shows there is no battery

[Rolf Eike Beer]

https://bugs.kde.org/show_bug.cgi?id=350365

--- Comment #49 from Rolf Eike Beer  ---
My battery is "gone" from the panel, so I started plasmoidviewer. It just shows
a blank square, but when I click on it it shows the battery with 51%, which
sounds plausible. When I click on the "empty" (= "no battery") icon in my
taskbar it does not show this.

Warning: all files used by qml by the plasmoid should be in ui/. The file in
the path
"file:///usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/code/LayoutManager.js"
was expected at
QUrl("file:///usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/LayoutManager.js")
Warning: all files used by qml by the plasmoid should be in ui/. The file in
the path
"file:///usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/code/FolderTools.js"
was expected at
QUrl("file:///usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/FolderTools.js")
Toolbox not loading, toolbox package is either invalid or disabled.
qml: New Containment: ContainmentInterface(0x561ae2e7b720)
Warning: all files used by qml by the plasmoid should be in ui/. The file in
the path
"file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/code/logic.js"
was expected at
QUrl("file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/logic.js")
trying to show an empty dialog
Both point size and pixel size set. Using pixel size.
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:54:42:
Unable to assign [undefined] to bool
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:53:39:
Unable to assign [undefined] to int
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:67:
ReferenceError: batteryLabel is not defined
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:52:43:
Unable to assign [undefined] to bool
Both point size and pixel size set. Using pixel size.
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:54:42:
Unable to assign [undefined] to bool
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:53:39:
Unable to assign [undefined] to int
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:67:
ReferenceError: batteryLabel is not defined
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:52:43:
Unable to assign [undefined] to bool
Both point size and pixel size set. Using pixel size.
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:54:42:
Unable to assign [undefined] to bool
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:53:39:
Unable to assign [undefined] to int
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:67:
ReferenceError: batteryLabel is not defined
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:52:43:
Unable to assign [undefined] to bool
Both point size and pixel size set. Using pixel size.
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:54:42:
Unable to assign [undefined] to bool
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:53:39:
Unable to assign [undefined] to int
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:67:
ReferenceError: batteryLabel is not defined
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:52:43:
Unable to assign [undefined] to bool
Both point size and pixel size set. Using pixel size.
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:54:42:
Unable to assign [undefined] to bool
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:53:39:
Unable to assign [undefined] to int
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:67:
ReferenceError: batteryLabel is not defined
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:52:43:
Unable to assign [undefined] to bool
Both point size and pixel size set. Using pixel size.
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:54:42:
Unable to assign [undefined] to bool
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:53:39:
Unable to assign [undefined] to int
file:///usr/share/plasma/plasmoids/org.kde.plasma.battery/contents/ui/CompactRepresentation.qml:67:
ReferenceError: batteryLabel is not defined

D26627: Mark applications that play audio for small panels.

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM for short panels when using both an IOTM and a regular Task Manager. 
@broulik, you good with this now?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  audiosize (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26627

To: gvgeo, #vdg, #plasma, hein, ngraham, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26586: [SystemTray] Rework system tray settings

[Nathaniel Graham]

ngraham added a comment.


  Ah, I see it now.
  
  The alignment for items with shortcuts is a bit odd: F7881593: 
Screenshot_20200113_130125.png 
  
  Maybe for the combobox item texts, try this:
  
  - Shown when relevant
  - Always shown
  - Always hidden
  - Disabled

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

[Noah Davis]

ndavis updated this revision to Diff 73458.
ndavis added a comment.


  Fix formatting

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26639?vs=73457=73458

BRANCH
  checkbox-radiobutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26639

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

[Nathaniel Graham]

ngraham accepted this revision as: VDG.
ngraham added a comment.


  Visually +1, fixes the minor background color bug that came from the last 
commit.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26639

To: ndavis, #vdg, #breeze, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

[Noah Davis]

ndavis added a comment.


  After this patch, should I remove `isSelectedItem()`? It's currently unused.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26639

To: ndavis, #vdg, #breeze, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

[Noah Davis]

ndavis added a comment.


  In D26572#593511 , 
@hpereiradacosta wrote:
  
  > > Otherwise, it should be Window Background. Doing it that way would 
preserve the original look in most cases.
  >
  > This would lead to some regression (I think) for unchecked checkboxes in 
lists. (because of window background being used).
  
  
  This doesn't seem to have any visual regressions like that.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26639

To: ndavis, #vdg, #breeze, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26639: Make checkboxes/radiobuttons use Window Background in windows and View Backround in lists

[Noah Davis]

ndavis created this revision.
ndavis added reviewers: VDG, Breeze.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ndavis requested review of this revision.

REPOSITORY
  R31 Breeze

BRANCH
  checkbox-radiobutton (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26639

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26572: Always render checkbox/radiobutton background

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D26572#593496 , @ndavis wrote:
  
  > What I meant is that I did not change the color of the checkbox background 
in this patch. I only made it so that the background would always be rendered.
  
  
  Clear enough. Indeed you did not change the colors, and it led to an unwanted 
visual change. Sorry for not having caught that up during review. (in fact it 
now leads to an inconsistency between checkboxes in menus and checkboxes in 
windows).
  
  > It seems like it might be a good idea to detect whether or not the button 
is being rendered in a view area and then set it to View Background.
  
  yes
  
  > Otherwise, it should be Window Background. Doing it that way would preserve 
the original look in most cases.
  
  This would lead to some regression (I think) for unchecked checkboxes in 
lists. (because of window background being used).

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26572

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26572: Always render checkbox/radiobutton background

[Noah Davis]

ndavis added a comment.


  What I meant is that I did not change the color of the checkbox background in 
this patch. I only made it so that the background would always be rendered.
  
  It seems like it might be a good idea to detect whether or not the button is 
being rendered in a view area and then set it to View Background. Otherwise, it 
should be Window Background. Doing it that way would preserve the original look 
in most cases.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26572

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26636: [Widget Explorer] Work around bad kerning

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  One way that https://bugreports.qt.io/browse/QTBUG-49646 manifests itself is 
when we have single line labels centered using "horizontalAlignment: 
Text.AlignHCenter".
  
  This patch works around the kerning bug using a different centering method: 
using the layout's alignment and setting the maximum width.
  
  Since the workaround doesn't work when there is more than 1 line of text AND 
since kerning is OK when lineCount > 1, we revert back to the old method in 
that situation.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  widget-explorer-kerning-fix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26636

AFFECTED FILES
  desktoppackage/contents/explorer/AppletDelegate.qml

To: filipf
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26572: Always render checkbox/radiobutton background

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D26572#593442 , @ndavis wrote:
  
  > In D26572#593379 , 
@hpereiradacosta wrote:
  >
  > > in more detail: imagine a color scheme where window background is black, 
window text is white, view background is white view text is black. 
  > >  you will get a white square on a white background for unchecked checkbox 
... 
  > >  I would really revert this part of the change
  >
  >
  > To be clear, that change hasn't been made.
  
  
  I'm confused: it has happened, no ? If I apply the patch I now get a white 
background (with normal breeze color scheme), behind checkboxes and radio 
button, always, which was not there before.  This is , I think because of the 
change at line 3889.
  
  > You mean a white square on a black background?
  
  No: if view color is white this would be white square  (window text) on white 
background (view background).
  
  > That could look odd if buttons aren't also normally white in that 
colorscheme, which might indicate that Button Background would be more 
semantically correct. By the way, the checkboxes already used View Background 
when selected unless they were drawn on top of a menu.
  
  No: in general background was not rendered. the View background was used for 
a special case of selection that happens only in views (if I remember the code 
right). With the standard breeze color scheme, a checkbox/radio button rendered 
in a window or a menu would never have a white background (from the view) drawn 
behind. 
  Unlike when applying the current patch.
  
  > In that case, they used Window Background when selected

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26572

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26572: Always render checkbox/radiobutton background

[Noah Davis]

ndavis added a comment.


  In D26572#593379 , 
@hpereiradacosta wrote:
  
  > in more detail: imagine a color scheme where window background is black, 
window text is white, view background is white view text is black. 
  >  you will get a white square on a white background for unchecked checkbox 
... 
  >  I would really revert this part of the change
  
  
  To be clear, that change hasn't been made.
  
  You mean a white square on a black background? That could look odd if buttons 
aren't also normally white in that colorscheme, which might indicate that 
Button Background would be more semantically correct. By the way, the 
checkboxes already used View Background when selected unless they were drawn on 
top of a menu. In that case, they used Window Background when selected.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26572

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26531: [Wallpaper] Show author as subtitle in configuration

[Nathaniel Graham]

ngraham added a comment.


  Submitted a patch to fix it: D26634 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26531

To: broulik, #plasma, #vdg
Cc: mart, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26572: Always render checkbox/radiobutton background

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  in more detail: imagine a color scheme where window background is black, 
window text is white, view background is white view text is black. 
  you will get a white square on a white background for unchecked checkbox ...

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26572

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26572: Always render checkbox/radiobutton background

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  I would strongly object to that: 
  first that is a visual change unrelated to the issue this patch adress
  second this is semantically wrong, and this will break on some color theme. 
  Things should be kept consistent. If you change the background role, you must 
also change the foreground role, and then you might really get funny results.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26572

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26621: [kstyle] Drop Qt 4 style plugin

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  Seems we got the go-ahead from kde-distro-packagers ML so ++
  
  After 5.18 forks please

REPOSITORY
  R113 Oxygen Theme

BRANCH
  port-to-shadows-api

REVISION DETAIL
  https://phabricator.kde.org/D26621

To: zzag, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26392: Add option to easily configure and start a hotspot

[Jan Grulich]

jgrulich updated this revision to Diff 73437.
jgrulich marked an inline comment as done.
jgrulich added a comment.


  Address review comments:
  
  1. Add text to the toolbutton and make it checkable
  2. Allow to create hotspot only if WiFi is available or it's not used as 
primary connection

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26392?vs=72847=73437

BRANCH
  hotspot

REVISION DETAIL
  https://phabricator.kde.org/D26392

AFFECTED FILES
  applet/contents/ui/Toolbar.qml
  kcm/kcm.cpp
  kcm/qml/ConfigurationDialog.qml
  kcm/qml/main.qml
  kded/networkmanagement.notifyrc
  libs/configuration.cpp
  libs/configuration.h
  libs/declarative/enabledconnections.h
  libs/handler.cpp
  libs/handler.h
  libs/models/networkmodel.cpp

To: jgrulich, #plasma, ngraham, #vdg
Cc: meven, cblack, alexde, mthw, apol, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart

D26530: ScrollView: Do not overlay scrollbars over contents

[Marco Martin]

mart added a comment.


  ok for it, provided it still has overlay scrollbars on tablet mode

INLINE COMMENTS

> ScrollView.qml:47
> +
> +readonly property bool _backgroundVisible: background && 
> background.visible
> +readonly property real _verticalScrollBarWidth: 
> ScrollBar.vertical.visible ? ScrollBar.vertical.width : 0

those properties should be top level, (even starting with _ )
there is stuff inside data: already, it can be put inside there

> ScrollView.qml:48
> +readonly property bool _backgroundVisible: background && 
> background.visible
> +readonly property real _verticalScrollBarWidth: 
> ScrollBar.vertical.visible ? ScrollBar.vertical.width : 0
> +readonly property real _horizontalScrollBarWidth: 
> ScrollBar.horizontal.visible ? ScrollBar.horizontal.width : 0

it should also have the condition: !Kirigami.Settings.tabletMode

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D26530

To: ahiemstra, #plasma, #goal_consistency, mart
Cc: kmaterka, mart, ndavis, IlyaBizyaev, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra

D26392: Add option to easily configure and start a hotspot

[Aleix Pol Gonzalez]

apol added a comment.


  > What about allowing to create a hotspot if the WiFi is in use, but it's not 
used as primary connection (e.g. Ethernet or Mobile connections are used 
primarily). In that case the user wouldn't be without connection if we 
disconnect him.
  
  Surely. And if the laptop is capable of sharing a wifi connection through a 
hotspot (or through ethernet), that should be possible as well.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D26392

To: jgrulich, #plasma, ngraham, #vdg
Cc: meven, cblack, alexde, mthw, apol, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart

D26632: Fix warning on ScrollablePage

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:e2ebbe6f4ac9: Fix warning on ScrollablePage (authored by 
apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26632?vs=73431=73433

REVISION DETAIL
  https://phabricator.kde.org/D26632

AFFECTED FILES
  src/controls/ScrollablePage.qml

To: apol, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26632: Fix warning on ScrollablePage

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  At the moment we'll be going through all of the children objects and 
reassigning
  the overlay as the parent. This is problematic because some objects won't 
allow
  it, getting things like
  ScrollablePage.qml:189: Error: Cannot assign QObject* to Action_QMLTYPE_11*
  
  This patch changes it so only Items are reparented

TEST PLAN
  Don't get the warnings anymore

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26632

AFFECTED FILES
  src/controls/ScrollablePage.qml

To: apol, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26622: RFC: [Notifications] Raise application window if no default action is provided

[Nathaniel Graham]

ngraham added a comment.


  +1 conceptually. I think this is a nice default behavior for the apps that 
haven't implemented nicer behaviors themselves, or refuse to.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26622

To: broulik, #plasma, #vdg, hein, mart
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26631: [kstyle] Update blur region even if Breeze has no X11 support

[Vlad Zahorodnii]

zzag created this revision.
zzag added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
zzag requested review of this revision.

REVISION SUMMARY
  KWindowEffects provides a platform-independent API for enabling blur,
  which requires neither Xlib nor XCB.

TEST PLAN
  Compiles.

REPOSITORY
  R31 Breeze

BRANCH
  blurr

REVISION DETAIL
  https://phabricator.kde.org/D26631

AFFECTED FILES
  kstyle/breezeblurhelper.cpp
  kstyle/breezeblurhelper.h

To: zzag, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26583: [Application Style] Add GTK Application Style Page

[Mikhail Zolotukhin]

gikari updated this revision to Diff 73429.
gikari added a comment.


  Replace themeUpdate redundant signal with direct load call.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26583?vs=73425=73429

BRANCH
  gtk-style-page

REVISION DETAIL
  https://phabricator.kde.org/D26583

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/cgcgtk3.knsrc
  kcms/style/cgctheme.knsrc
  kcms/style/gtkpage.cpp
  kcms/style/gtkpage.h
  kcms/style/gtkthemesmodel.cpp
  kcms/style/gtkthemesmodel.h
  kcms/style/kcmstyle.cpp
  kcms/style/kcmstyle.h
  kcms/style/package/contents/ui/GtkStylePage.qml
  kcms/style/package/contents/ui/main.qml

To: gikari, #vdg, broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26530: ScrollView: Do not overlay scrollbars over contents

[Arjen Hiemstra]

ahiemstra added a comment.


  Also, just want to reiterate that I actually don't really care about how 
things look, what I care about is the amount of workarounds that are introduced 
by the scrollbar behaviour as it is. One current example is D26586 
 but I have ran into this myself when doing 
application development, as well as seen other people run into it. The 
workarounds introduced easily break, either with a different QtQuick Controls 
style or even with just a different widget style (Take a look at the System 
Settings sidebar with Oxygen for example).

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D26530

To: ahiemstra, #plasma, #goal_consistency, mart
Cc: kmaterka, mart, ndavis, IlyaBizyaev, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra

D26583: [Application Style] Add GTK Application Style Page

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Visually and behaviorally, this is great. Probably needs a #plasma 
 review too.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  gtk-style-page

REVISION DETAIL
  https://phabricator.kde.org/D26583

To: gikari, #vdg, broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26630: Fix warning

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:ec3b2d53d853: Fix warning (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26630?vs=73422=73427

REVISION DETAIL
  https://phabricator.kde.org/D26630

AFFECTED FILES
  src/columnview.cpp

To: apol, #kirigami, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26628: Specify where the code is coming from as the URL

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:dee14718ceb4: Specify where the code is coming from as 
the URL (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26628?vs=73424=73426

REVISION DETAIL
  https://phabricator.kde.org/D26628

AFFECTED FILES
  src/columnview.cpp
  src/delegaterecycler.cpp
  src/libkirigami/basictheme.cpp

To: apol, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, hein

D26628: Specify where the code is coming from as the URL

[Marco Martin]

mart accepted this revision.
mart added a comment.
This revision is now accepted and ready to land.


  <3

REPOSITORY
  R169 Kirigami

BRANCH
  arcpatch-D26628

REVISION DETAIL
  https://phabricator.kde.org/D26628

To: apol, #kirigami, mart
Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, hein

D26628: Specify where the code is coming from as the URL

[Aleix Pol Gonzalez]

apol updated this revision to Diff 73424.
apol added a comment.


  consistency

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26628?vs=73420=73424

BRANCH
  arcpatch-D26628

REVISION DETAIL
  https://phabricator.kde.org/D26628

AFFECTED FILES
  src/columnview.cpp
  src/delegaterecycler.cpp
  src/libkirigami/basictheme.cpp

To: apol, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26583: [Application Style] Add GTK Application Style Page

[Mikhail Zolotukhin]

gikari updated this revision to Diff 73425.
gikari added a comment.


  Undo previous hasty decision

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26583?vs=73390=73425

BRANCH
  gtk-style-page

REVISION DETAIL
  https://phabricator.kde.org/D26583

AFFECTED FILES
  kcms/style/CMakeLists.txt
  kcms/style/cgcgtk3.knsrc
  kcms/style/cgctheme.knsrc
  kcms/style/gtkpage.cpp
  kcms/style/gtkpage.h
  kcms/style/gtkthemesmodel.cpp
  kcms/style/gtkthemesmodel.h
  kcms/style/kcmstyle.cpp
  kcms/style/kcmstyle.h
  kcms/style/package/contents/ui/GtkStylePage.qml
  kcms/style/package/contents/ui/main.qml

To: gikari, #vdg, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26630: Fix warning

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  columnview.cpp:7: TypeError: Cannot read property 'contentX' of null

TEST PLAN
  Used to get it all the time in Discover

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26630

AFFECTED FILES
  src/columnview.cpp

To: apol, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26628: Specify where the code is coming from as the URL

[Aleix Pol Gonzalez]

apol created this revision.
apol added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  Makes it much simpler to see where warnings are coming from if we get to
  see a file name.

TEST PLAN
  Fixed a warning with it

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26628

AFFECTED FILES
  src/columnview.cpp
  src/delegaterecycler.cpp
  src/libkirigami/basictheme.cpp

To: apol, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26530: ScrollView: Do not overlay scrollbars over contents

[Arjen Hiemstra]

ahiemstra added a comment.


  > yes, i'm saying that the patch besides putting the separation in the frame, 
it also reintroduces the frame by default, which is unrelated (and i think it 
should be avoided)
  
  The patch as-is does not, what you see is the default scrollview background 
that I enabled in my tiny test. This patch actually just makes the space for 
the scrollbar, since the scrollbar itself was not changed whatever is 
underneath becomes visible. With the default scroll view background enabled 
that becomes the frame, but it can easily just be a view-colored rect.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D26530

To: ahiemstra, #plasma, #goal_consistency, mart
Cc: kmaterka, mart, ndavis, IlyaBizyaev, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra

D26423: [Notifications KCM] Move Plasma Workspace "service" to the top of its category

[Kai Uwe Broulik]

broulik updated this revision to Diff 73419.
broulik retitled this revision from "[Notifications KCM] Move Plasma Workspace 
"service" to the top" to "[Notifications KCM] Move Plasma Workspace "service" 
to the top of its category".
broulik edited the summary of this revision.
broulik edited the test plan for this revision.
broulik added a comment.


  - Sort it only to the top of services category

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26423?vs=72769=73419

REVISION DETAIL
  https://phabricator.kde.org/D26423

AFFECTED FILES
  kcms/notifications/sourcesmodel.cpp

To: broulik, #plasma, #vdg
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22382: Add global shortcuts for switching to the previous/next activity

[Christian Muehlhaeuser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:1d6b5376eaa7: Add global shortcuts for switching to the 
previous/next activity (authored by muesli).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22382?vs=73412=73418

REVISION DETAIL
  https://phabricator.kde.org/D22382

AFFECTED FILES
  shell/shellcorona.cpp

To: muesli, apol, davidedmundson, #vdg, #plasma, ngraham
Cc: ngraham, romangg, ivan, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26572: Always render checkbox/radiobutton background

[Noah Davis]

ndavis added a comment.


  Oh, I should have brought this up before landing, but any opinions about 
always using `QPalette::Base` (View Background) for the background color? I 
asked on the VDG channel and people seemed to be unanimously in favor of using 
View Background as the background color.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D26572

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26572: Always render checkbox/radiobutton background

[Noah Davis]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:98781f18df86: Always render checkbox/radiobutton 
background (authored by ndavis).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26572?vs=73234=73417

REVISION DETAIL
  https://phabricator.kde.org/D26572

AFFECTED FILES
  kstyle/breezestyle.cpp

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26572: Always render checkbox/radiobutton background

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.


  ship it. No strong feeling.

REPOSITORY
  R31 Breeze

BRANCH
  checkbox-radiobutton-background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26572

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26506: [KDED KCM] Rewrite as KDeclarative ScrollViewKCM

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Lovely.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26506

To: broulik, #plasma, #vdg, mart, ngraham
Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26582: Kicker/RecentUsageModel: Allow to open smb:/ sftp:/ resources

[Алексей Шилин]

aleksejshilin added a comment.


  In D26582#592469 , @meven wrote:
  
  > We may want to change KRun::runUrl when a native binary is to be run but 
with runExecutable is false, around line 400:
  >
  >   } else if (isNativeBinary) {
  >   // Show warning for executables that aren't scripts
  >   noRun = true;
  >   }
  >   
  
  
  KRun currently doesn't seem to consider that there may be a reason to open 
native binaries in an application - its execution confirmation dialog doesn't 
give such option even if some application is associated with the corresponding 
mime type. I believe, they thought that an average user is unlikely to ever 
need this - and they may be right. :)
  
  Given that such use case is probably orders of magnitude less likely than 
sftp: and especially smb:, I guess, it's OK to merge this, and address the 
issue with native binaries in KIO later. @broulik ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26582

To: meven, #plasma, broulik, aleksejshilin
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22382: Add global shortcuts for switching to the previous/next activity

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  I think so!

REPOSITORY
  R120 Plasma Workspace

BRANCH
  shortcut-prevnext-activity (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22382

To: muesli, apol, davidedmundson, #vdg, #plasma, ngraham
Cc: ngraham, romangg, ivan, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26586: [SystemTray] Rework system tray settings

[Konrad Materka]

kmaterka added a comment.


  @mart @ngraham  I see heated discussion in D26530 
. What should I do with scrollbars? I can 
change it to something like this:
  
  F7880950: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D26624: [Workspace Behavior KCM] Add "animation speed" keyword

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6f1de8e8f0d3: [Workspace Behavior KCM] Add 
animation speed keyword (authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26624?vs=73406=73415

REVISION DETAIL
  https://phabricator.kde.org/D26624

AFFECTED FILES
  kcms/workspaceoptions/kcm_workspace.desktop

To: broulik, #plasma, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26586: [SystemTray] Rework system tray settings

[Konrad Materka]

kmaterka updated this revision to Diff 73414.
kmaterka added a comment.


  Removed feature that allowed to hide whole category.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26586?vs=73395=73414

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26586

AFFECTED FILES
  applets/systemtray/package/contents/config/config.qml
  applets/systemtray/package/contents/config/main.xml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/ConfigGeneral.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D25925: Mark applications that play audio, for all task icon sizes

[George Vogiatzis]

gvgeo marked an inline comment as done.
gvgeo added a comment.


  D26627 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25925

To: gvgeo, #vdg, #plasma, ndavis, ngraham, hein
Cc: broulik, plasma-devel, hein, ngraham, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26586: [SystemTray] Rework system tray settings

[Konrad Materka]

kmaterka added a comment.


  In D26586#593154 , @ngraham wrote:
  
  > There are no sections and everything's disabled.
  
  
  Hmm, there is one small change in the C++ model (category added), maybe you 
need to restart/logout so that C++ library is reloaded?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D22382: Add global shortcuts for switching to the previous/next activity

[Christian Muehlhaeuser]

muesli added a comment.


  Alright, I think this looks sane again. @ngraham Mind if I land this in its 
current state?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D22382

To: muesli, apol, davidedmundson, #vdg, #plasma
Cc: ngraham, romangg, ivan, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26627: Mark applications that play audio for small panels.

[George Vogiatzis]

gvgeo added a comment.


  I was not so fond of limiting when small, but was trying to avoid this.
  F7880898: Screenshot_20200113_163105.png 

  Didn't notice that for classic panel is more visible at the same size.
  F7880901: Screenshot_20200113_163136.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26627

To: gvgeo, #vdg, #plasma, hein, ngraham, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26530: ScrollView: Do not overlay scrollbars over contents

[Nathaniel Graham]

ngraham added a comment.


  In D26530#593152 , @mart wrote:
  
  > yes, i'm saying that the patch besides putting the separation in the frame, 
it also reintroduces the frame by default, which is unrelated (and i think it 
should be avoided)
  
  
  Let's distinguish and lines. A frame is a four-cornered outline. What we see 
in the following image has no frames:
  
  F7880630: image.png 
  
  IMO using lines to separate distinct elements that touch the bounds of the 
window is 1000% better than putting everything in a frame floating on the view, 
separated by a few pixels of padding. You can add more lines (within reason) 
without the view becoming overwhelming and heavy and old-fashioned looking I 
love love love the Kirigami style that does this, and in fact our T10891: 
Breeze theme evolution  task proposes 
moving to this style for QWidgets apps too.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D26530

To: ahiemstra, #plasma, #goal_consistency, mart
Cc: kmaterka, mart, ndavis, IlyaBizyaev, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra

D26627: Mark applications that play audio for small panels.

[George Vogiatzis]

gvgeo created this revision.
gvgeo added reviewers: VDG, Plasma, hein, ngraham, broulik.
gvgeo added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  Don't limit audio playing indicator.
  Display icon even if tasks are too small.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  audiosize (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26627

AFFECTED FILES
  applets/taskmanager/package/contents/ui/AudioStream.qml

To: gvgeo, #vdg, #plasma, hein, ngraham, broulik
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26586: [SystemTray] Rework system tray settings

[Nathaniel Graham]

ngraham added a comment.


  When I try this out, here's what I see:
  
  F7880888: Screenshot_20200113_072934.png 

  
  There are no sections and everything's disabled.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D26530: ScrollView: Do not overlay scrollbars over contents

[Marco Martin]

mart added a comment.


  i'm giving a try to give breeze qstyle that look, then we can revisit this

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D26530

To: ahiemstra, #plasma, #goal_consistency, mart
Cc: kmaterka, mart, ndavis, IlyaBizyaev, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra

D26530: ScrollView: Do not overlay scrollbars over contents

[Marco Martin]

mart added a comment.


  In D26530#593123 , @ngraham wrote:
  
  > In D26530#592999 , @mart wrote:
  >
  > > It would already be much better if the track was actually very visible, 
visually delimiting the space
  > >  F7880630: image.png 
  >
  >
  > I think it looks fantastic, or at least it would if that vertical line 
touched the top and bottom of the view, and the bar were wider so it did a 
better job of taking up the space in the track. This is in fact how macOS looks 
when you disable overlay-style scrolling globally, and personally I would like 
this everywhere -- at least on the desktop. On mobile, then sure, the 
scrollbars cam be tiny and almost/entirely disappearing. But I just don't like 
this style on the desktop. I don't think it's a case of, "it's new, I hate it." 
I'm pertty open to change, and I lived with it on and off on macOS since 2011 
(see http://osxdaily.com/2011/08/03/show-scroll-bars-mac-os-x-lion) but never 
got used to it.
  
  
  I may take a look into changing the breeze style do do such line, tough i 
would like that:
  
  - breeze qwidget also supports disappearing scrollbar on touch (and hmm, 
configurable :p)
  - on mobile scrollbar behavior is always hiding, and overlay
  - even change on the fly when flicking a view with touch (and change back 
when the mouse is used):  this is fine to be qml only as flicking is not really 
going to work correctly with qwidgets.
  
  > I agree. However personally I think this impression comes from how 
typically each view is put within its own frame, rather than separating 
adjacent views with single-pixel lines like how Kirigami does it (which solves 
the problem). This leads to horrible frame overload like so: F7880807: 
Screenshot_20200113_065712.png 
  > 
  >   I don't think the size of the scrollbars has much to do with it.
  
  yes, i'm saying that the patch besides putting the separation in the frame, 
it also reintroduces the frame by default, which is unrelated (and i think it 
should be avoided)

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D26530

To: ahiemstra, #plasma, #goal_consistency, mart
Cc: kmaterka, mart, ndavis, IlyaBizyaev, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra

D22382: Add global shortcuts for switching to the previous/next activity

[Christian Muehlhaeuser]

muesli updated this revision to Diff 73412.
muesli added a comment.


  Hopefully fix phabricator getting out of sync with the changeset.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D22382?vs=73354=73412

BRANCH
  shortcut-prevnext-activity (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D22382

AFFECTED FILES
  shell/shellcorona.cpp

To: muesli, apol, davidedmundson, #vdg, #plasma
Cc: ngraham, romangg, ivan, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26565: KCM/Component Revamp email config

[Nathaniel Graham]

ngraham added a comment.


  In D26565#592891 , @meven wrote:
  
  > It means we will need to write .desktop file on the fly which 
KOpenWithDialog can do.
  >  Do we want the previously entered commands to appear in the list ?
  
  
  I think so. We don't want to break anyone who's currently using this feature.
  
  In D26565#592891 , @meven wrote:
  
  > > The combobox could have an entry entitled "Terminal Program" and 
selecting that option would make the text field allowing you to enter a command 
appear next to the combobox.
  >
  > Or open a KOpenWithDialog window.
  
  
  Yeah that might be better.
  
  In D26565#592891 , @meven wrote:
  
  > >> That would mean we could regroup everything in one tab also just like 
other DE do.
  > > 
  > > Exactly. Then we don't need tabs at all.
  >
  > I will probably do this incrementaly, refactor UIs in all tabs, then get 
rid of tabs, because this will move quite a bit of code.
  
  
  Sounds like a plan! Thanks a bunch for tackling this.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26565

To: meven, ngraham, ervin, #plasma, bport, crossi
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26392: Add option to easily configure and start a hotspot

[Nathaniel Graham]

ngraham added a comment.


  If we use an icons-only button/checkbox, then this can't go in without the 
icon, which means it's deferred to Plasma 5.19. There's still (barely) time to 
get it into 5.18 if we make sure that we use a UI that has both icons and text.

REPOSITORY
  R116 Plasma Network Management Applet

REVISION DETAIL
  https://phabricator.kde.org/D26392

To: jgrulich, #plasma, ngraham, #vdg
Cc: meven, cblack, alexde, mthw, apol, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, ahiemstra, mart

D26586: [SystemTray] Rework system tray settings

[Konrad Materka]

kmaterka added a comment.


  In D26586#593114 , @mart wrote:
  
  > fine for me too.
  
  
  OK, I will remove this feature.

INLINE COMMENTS

> mart wrote in ConfigEntries.qml:114
> this should never be necessary and will probably cause bugs.
> It looks like you're trying to workaround some problem? (which should be 
> rather fixed)

Yes, I don't like this neither. It is a workaround for a problem in 
Kirigami.AbstractListItem. It automatically calculates paddings when scrollbars 
are detected:
kirigami/src/controls/templates/AbstractListItem.qml$144-165 

It checks if view has scrollbars attached: 
`internal.view.T2.ScrollBar.vertical`.
I checked other projects (Discover), Kirigami.AbstractListItem is used inside 
ScrollablePage, which add scrollbars directly to the ListView (defined in 
custom templates/private/ScrollView.qml 
.

I use plain QQC2.ScrollView, which attaches scrollbars to itself, not ListView. 
As a result scrollbars are not detected and padding is not added.

I don't know how to fix that correctly without duplicating a code in 
ConfigEntries.qml. I can override leftPadding and rightPadding, but I prefer to 
use original logic (in case it changes in the future). Can you advice?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D26572: Always render checkbox/radiobutton background

[Nathaniel Graham]

ngraham accepted this revision as: VDG, ngraham.
ngraham added a comment.
This revision is now accepted and ready to land.


  Purely in terms of visuals, I think so. It clearly fixes a bug.

REPOSITORY
  R31 Breeze

BRANCH
  checkbox-radiobutton-background (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26572

To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26586: [SystemTray] Rework system tray settings

[Nathaniel Graham]

ngraham added a comment.


  In D26586#593114 , @mart wrote:
  
  > the reason for it in the beginning was t just be able to say "i don't want 
normal apps to be able to spam my systray" tough probably things aren't 
categorize well enough to be able to rely on that.
  >  if that "no normal apps such as mediaplayers" is deemed an useful 
feature(which i'm not sure it is) , should probably be a checkbox that says 
exactly that, rather than having the concept of enabling or disabling a whole 
category
  
  
  I think that makes sense, yeah.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D26531: [Wallpaper] Show author as subtitle in configuration

[Nathaniel Graham]

ngraham added a comment.


  I'll look into it, yeah.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26531

To: broulik, #plasma, #vdg
Cc: mart, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26530: ScrollView: Do not overlay scrollbars over contents

[Nathaniel Graham]

ngraham added a comment.


  In D26530#592999 , @mart wrote:
  
  > It would already be much better if the track was actually very visible, 
visually delimiting the space
  >  F7880630: image.png 
  
  
  I think it looks fantastic, or at least it would if that vertical line 
touched the top and bottom of the view, and the bar were wider so it did a 
better job of taking up the space in the track. This is in fact how macOS looks 
when you disable overlay-style scrolling globally, and personally I would like 
this everywhere -- at least on the desktop. On mobile, then sure, the 
scrollbars cam be tiny and almost/entirely disappearing. But I just don't like 
this style on the desktop. I don't think it's a case of, "it's new, I hate it." 
I'm pertty open to change, and I lived with it on and off on macOS since 2011 
(see http://osxdaily.com/2011/08/03/show-scroll-bars-mac-os-x-lion) but never 
got used to it.
  
  In D26530#592999 , @mart wrote:
  
  > I do see a problem with it. Qt apps (in general, also beyond the KDE 
bubble) *do* have a reputation for looking clunky, outdated, and windows95 
like, perception i would like to fight, not encourage.
  
  
  I agree. However personally I think this impression comes from how typically 
each view is put within its own frame, rather than separating adjacent views 
with single-pixel lines like how Kirigami does it (which solves the problem). 
This leads to horrible frame overload like so: F7880807: 
Screenshot_20200113_065712.png 
  
  I don't think the size of the scrollbars has much to do with it.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D26530

To: ahiemstra, #plasma, #goal_consistency, mart
Cc: kmaterka, mart, ndavis, IlyaBizyaev, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra

D26586: [SystemTray] Rework system tray settings

[Marco Martin]

mart added a comment.


  on the code side, i have mainly only one gripe

INLINE COMMENTS

> ConfigEntries.qml:114
> +Layout.fillHeight: true
> +QQC2.ScrollBar.vertical: scrollView.QQC2.ScrollBar.vertical // 
> For Kirigami.AbstractListItem
>  

this should never be necessary and will probably cause bugs.
It looks like you're trying to workaround some problem? (which should be rather 
fixed)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D26271: [Applet]Update layout based on T10470

[Noah Davis]

ndavis added a subscriber: cfeck.
ndavis added a comment.


  Since it's @cfeck's bug report, I'll add him to the subscribers.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: cfeck, ndavis, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[Noah Davis]

ndavis added a comment.


  In D26271#593013 , @gvgeo wrote:
  
  > Found this request to display the name of the stream 
https://bugs.kde.org/show_bug.cgi?id=409453 .
  >  Which was done, but remove here. Maybe should leave it too?
  >  With a quick check, not many applications have this information.
  >  F7880660: Screenshot_20200113_135516.png 

  
  
  I'm skeptical of the need for this feature. It seems like something very few 
people will need. Out of all of those stream names, only one of them has 
information that could be considered possibly useful to most people. If there's 
a good way to not show the information except when it contains something 
useful, then go for it. Otherwise, I'd say leave it out.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  layout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: ndavis, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26586: [SystemTray] Rework system tray settings

[Marco Martin]

mart added a comment.


  In D26586#593025 , @kmaterka wrote:
  
  > Final decision: should I remove feature which allows to hide whole category?
  
  
  fine for me too.
  the reason for it in the beginning was t just be able to say "i don't want 
normal apps to be able to spam my systray" tough probably things aren't 
categorize well enough to be able to rely on that.
  if that "no normal apps such as mediaplayers" is deemed an useful 
feature(which i'm not sure it is) , should probably be a checkbox that says 
exactly that, rather than having the concept of enabling or disabling a whole 
category

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: mart, meven, nicolasfella, plasma-devel, ngraham, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 73409.
leinir added a comment.


  As discussed above, we need to be able to build against an older version of
  Frameworks than 5.67. As such, wrap up the bits that aren't available before
  then in some compile-time checks.
  
  - Wrap the new requirements up in some handy checks, for older Frameworks

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26544?vs=73190=73409

BRANCH
  switch-kcms-to-knsquick (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26544

AFFECTED FILES
  kcms/colors/CMakeLists.txt
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/package/contents/ui/main.qml
  kcms/cursortheme/CMakeLists.txt
  kcms/cursortheme/kcmcursortheme.cpp
  kcms/cursortheme/kcmcursortheme.h
  kcms/cursortheme/package/contents/ui/main.qml
  kcms/desktoptheme/CMakeLists.txt
  kcms/desktoptheme/kcm.cpp
  kcms/desktoptheme/kcm.h
  kcms/desktoptheme/package/contents/ui/main.qml
  kcms/icons/CMakeLists.txt
  kcms/icons/main.cpp
  kcms/icons/main.h
  kcms/icons/package/contents/ui/main.qml
  kcms/ksplash/CMakeLists.txt
  kcms/ksplash/kcm.cpp
  kcms/ksplash/kcm.h
  kcms/ksplash/package/contents/ui/main.qml

To: leinir, mart
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26624: [Workspace Behavior KCM] Add "animation speed" keyword

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Since that's where the animation speed slider is now in

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26624

AFFECTED FILES
  kcms/workspaceoptions/kcm_workspace.desktop

To: broulik, #plasma
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25925: Mark applications that play audio, for all task icon sizes

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> AudioStream.qml:92
> +// Do not display the indicator if the icons are too small.
> +visible: opacity > 0 && Math.min(iconBox.width, iconBox.height) >= 
> units.iconSizes.small
>  

This breaks displaying the icon on small panels like mine.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25925

To: gvgeo, #vdg, #plasma, ndavis, ngraham, hein
Cc: broulik, plasma-devel, hein, ngraham, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D24192: WIP: Active page follow the focus

[Marco Martin]

mart added a comment.


  any update on it?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D24192

To: ognarb, #kirigami, #plasma_accessibility
Cc: broulik, mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, davidedmundson, hein

D26531: [Wallpaper] Show author as subtitle in configuration

[Marco Martin]

mart added a comment.


  In D26531#592814 , @broulik wrote:
  
  > > can you look into that?
  >
  > Perhaps @ngraham can. In any case, if this were fixed, it would not make it 
for 5.18.
  
  
  no biggie. let's put it in as soon as the new cycle starts

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26531

To: broulik, #plasma, #vdg
Cc: mart, filipf, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D26622: RFC: [Notifications] Raise application window if no default action is provided

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG, hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  BUG: 416107

TEST PLAN
  - Clicked Thunderbird notification, got Thunderbird window raised
  - Opened new composer window, brought Thunderbird into the front, activated 
another window, Thunderbird window got raised and not the composer matching the 
stacking order

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26622

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationPopup.qml
  applets/notifications/package/contents/ui/global/Globals.qml

To: broulik, #plasma, #vdg, hein
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

[Dan Leinir Turthra Jensen]

leinir added inline comments.

INLINE COMMENTS

> davidedmundson wrote in main.cpp:254
> FWIW, there is an alternative approach that we do in plasma-workspace 
> (shell/containmentconfigview.cpp) for reloading wallpapers types.
> 
> kpackage emits a DBus signal when it performs an action, models can listen 
> for this.
> 
> We had to do that there because the model was quite separated from the UI. 
> But it has the advantage that we pick up external changes (i.e through 
> discover or whatever)

That does sound like something that would be good to look at at a later point 
in time (it'd make this whole thing vastly more involved, and i'm trying to 
keep it a bit more simple for now)

> davidedmundson wrote in main.cpp:275
> Does this code still exist? I can't see an equivalent in knewstuff.
> 
> It's especially important on wayland

The new dialog is entirely QtQuick (clicking the NewStuff.Button essentially 
just calls open() on a QtQuick.Dialogs Dialog, so if doing show on a QtQuick 
Dialog does the trick, then yes. Otherwise i am... severely uncertain of how 
that might be solved (though it would be central at least, since the code would 
be in KNSQuick).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26544

To: leinir, mart
Cc: bcooksley, davidedmundson, ngraham, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26120: [Wizard] Show notification instead of finished page when pairing succeeds

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:5101d7902f9f: [Wizard] Show notification instead of 
finished page when pairing succeeds (authored by broulik).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26120?vs=71887=73396

REVISION DETAIL
  https://phabricator.kde.org/D26120

AFFECTED FILES
  src/bluedevil.notifyrc
  src/wizard/CMakeLists.txt
  src/wizard/bluewizard.cpp
  src/wizard/pages/success.cpp

To: broulik, #vdg, drosca, #plasma
Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25860: [plasmoid] Show device battery percentage

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:3686a5acf6cf: [plasmoid] Show device battery percentage 
(authored by broulik).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25860?vs=71216=73397

REVISION DETAIL
  https://phabricator.kde.org/D25860

AFFECTED FILES
  src/applet/package/contents/ui/DeviceItem.qml

To: broulik, #plasma, #vdg, drosca
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D26586: [SystemTray] Rework system tray settings

[Konrad Materka]

kmaterka added a comment.


  Final decision: should I remove feature which allows to hide whole category?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: meven, nicolasfella, plasma-devel, ngraham, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart