D26760: Update from Plasma for ToolTipInstance.qml

[Michail Vourlakos]

mvourlakos added a comment.


  I would prefer to be separate commits. Please commit this one and we can 
discuss in upcoming commit the highlight changes

REPOSITORY
  R878 Latte Dock

BRANCH
  update-ToolTipInstance-fromPlasma (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26760

To: trmdi, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26760: Update from Plasma for ToolTipInstance.qml

[Tranter Madi]

trmdi added a comment.


  Thanks, but I want to wait for this patch: https://phabricator.kde.org/D26739 
to be committed, then I will add it to this patch. It looks pretty nice. :)

REPOSITORY
  R878 Latte Dock

BRANCH
  update-ToolTipInstance-fromPlasma (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26760

To: trmdi, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26889: Change notification button text to "View Updates"

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Discover Software Store, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  This is more accurate; "Update" inaccurately implies that updates will be 
immediately
  installed, hereas "View updates" correctly indicates that you will be able to 
see what
  the updates are before deciding whether or not to install them.

REPOSITORY
  R134 Discover Software Store

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26889

AFFECTED FILES
  libdiscover/resources/ResourcesUpdatesModel.cpp
  notifier/DiscoverNotifier.cpp

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26836: [kcmshell] Drop kdeinit

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R126:15d375fe81b0: [kcmshell] Drop kdeinit (authored by 
davidedmundson).

REPOSITORY
  R126 KDE CLI Utilities

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26836?vs=74104=74290

REVISION DETAIL
  https://phabricator.kde.org/D26836

AFFECTED FILES
  CMakeLists.txt
  kcmshell/CMakeLists.txt
  kcmshell/main.cpp

To: davidedmundson, #plasma, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26838: Drop kdeinit

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R103:fcbae4cbadd5: Drop kdeinit (authored by davidedmundson).

REPOSITORY
  R103 KMenu Editor

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26838?vs=74106=74289

REVISION DETAIL
  https://phabricator.kde.org/D26838

AFFECTED FILES
  CMakeLists.txt
  main.cpp

To: davidedmundson, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26720: Cache single image wallpapers locally

[Tranter Madi]

trmdi added inline comments.

INLINE COMMENTS

> trmdi wrote in image.cpp:503
> `QDir::mkpath` is better: https://doc.qt.io/qt-5/qdir.html#mkpath

Sorry, I meant QDir::mkpath is needed for KIO::CopyJob, not here, otherwise 
CopyJob will fail when the destination directory does not exist.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26720

To: ngraham, #plasma, davidedmundson
Cc: trmdi, davidedmundson, broulik, filipf, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D21764: Port all plasma workspace to new libkworkspace API

[David Edmundson]

davidedmundson updated this revision to Diff 74288.
davidedmundson marked 4 inline comments as done.
davidedmundson added a comment.


  update

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D21764?vs=59642=74288

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D21764

AFFECTED FILES
  containmentactions/contextmenu/menu.cpp
  containmentactions/contextmenu/menu.h
  dataengines/powermanagement/powermanagementjob.cpp
  dataengines/powermanagement/powermanagementjob.h
  runners/sessions/sessionrunner.cpp
  runners/sessions/sessionrunner.h

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D25428: Improved support for desktop "Folder View"

[Eike Hein]

hein added a comment.


  Just a quick note I will review this tomorrow or next week when I'm on 
vacation, sorry for the long wait.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25428

To: steffenh, #plasma, hein, ngraham, mart
Cc: mart, ngraham, nicolasfella, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

[Filip Fila]

filipf added a comment.


  In D26880#600026 , @abetts wrote:
  
  > I would suggest a circular button instead of square.
  
  
  I also think this would look more attractive. I've already investigated the 
possibility and here's a few notes:
  
  - our hover/higlight effect is not made to be circular
  - we'd have to create a new CircularHighlight component or simply a new SVG 
for this
  - drawback: 3rd party themes wouldn't have this SVG for some time
  
  - I already tried bending the existing SVG to a circle with an opacity mask 
but that would only worked with filled-style highlights:
  
  F7927015: image.png 
  F7927017: image.png 
  
  - alternatively we could use a QML rectangle but I don't really like that 
approach, and not just because it's unthemable but because we won't be able to 
guarantee it will be legible with all themes

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26880

To: filipf, ngraham, #vdg, #plasma, hein, broulik
Cc: abetts, hein, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

[Andres Betts]

abetts added a comment.


  I would suggest a circular button instead of square.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26880

To: filipf, ngraham, #vdg, #plasma, hein, broulik
Cc: abetts, hein, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

D26885: Remove misleading comment about the setting, that does not exist anymore

[Mikhail Zolotukhin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:51e6e92468f9: Remove misleading comment about the 
setting, that does not exist anymore (authored by gikari).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26885?vs=74276=74277

REVISION DETAIL
  https://phabricator.kde.org/D26885

AFFECTED FILES
  kcms/krdb/krdb.cpp

To: gikari, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26885: Remove misleading comment about the setting, that does not exist anymore

[Mikhail Zolotukhin]

gikari created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
gikari requested review of this revision.

REVISION SUMMARY
  BUG: 416636
  FIXED-IN: 5.18.0

REPOSITORY
  R119 Plasma Desktop

BRANCH
  remove-colors-comment (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26885

AFFECTED FILES
  kcms/krdb/krdb.cpp

To: gikari
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:7127464c0d66: [Task Manager] Draw audio icon highlight 
effect behind the icon, not in front… (authored by filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26880?vs=74269=74275

REVISION DETAIL
  https://phabricator.kde.org/D26880

AFFECTED FILES
  applets/taskmanager/package/contents/ui/AudioStream.qml

To: filipf, ngraham, #vdg, #plasma, hein, broulik
Cc: hein, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26884: [Folder View] Fix text label color in pop-up

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, hein, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Currently there's a top-level ColorScope that is almost entirely unused 
except for
  introducing a bug whereby the label text in the pop-up is the wrong color. 
Removing the
  ColorScope fixes the bug and does not change the appearance of anything else 
anywhere else.
  
  BUG: 416658
  FIXED-IN: 5.18.0

TEST PLAN
  Hover over a folder and click on button to open a folder pop-up 
  See that the text color is correct now: F7925905: After.png 

  
  Use Folder view as a containment, as a widget, and in a panel
  See that text color is fine everywhere
  
  Use a bunch of different color schemes and repeat the above tests and see 
that everything
  still looks good

REPOSITORY
  R119 Plasma Desktop

BRANCH
  fix-folderview-popup-text-color (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26884

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderViewLayer.qml

To: ngraham, #vdg, #plasma, hein, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26850: [SystemTray] Refresh icon in settings on update

[Konrad Materka]

kmaterka marked an inline comment as done.
kmaterka added inline comments.

INLINE COMMENTS

> broulik wrote in systemtraymodel.cpp:269
> Avoid `keys()` which creates a temporary list, instead use iterators
> 
>   const auto roleNames = sourceModel->roleNames();
>   for (auto it = roleNames.begin(), end = roleNames.end(); it != end; ++it) {
>   if (!m_roleNames.contains(it.key()) {
>   m_roleNames.insert(it.key(), it.value());
>   }
>   }

Done. Does it matter if I use Java-style iterator or STL-style? Documentation 
says that STL-style is slightly faster, but I like Java -style more. I checked 
plasma-workspace and both are used.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26850

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26850: [SystemTray] Refresh icon in settings on update

[Konrad Materka]

kmaterka updated this revision to Diff 74272.
kmaterka added a comment.


  Iterator used

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26850?vs=74164=74272

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26850

AFFECTED FILES
  applets/systemtray/systemtraymodel.cpp

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[Nathaniel Graham]

ngraham added a comment.


  In D26861#599957 , @Fuchs wrote:
  
  > - Icon wise, given that it can still overlap with the app icon, I would 
prefer something that has a contrasting border, so e.g. a dark audio indicator 
is still visible on a dark app icon. But that can probably be addressed in a 
separate task, especially as it also affects other icons we have
  
  
  Yeah that's planned for 5.19.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[Nathaniel Graham]

ngraham added a comment.


  Thanks!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26806

To: gvgeo, #plasma, #vdg, davidedmundson
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[Nathaniel Graham]

ngraham added a reviewer: manueljlin.
ngraham added a comment.


  Looking pretty good to me, UI-wise.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26806

To: gvgeo, #plasma, #vdg, davidedmundson, manueljlin
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26882: [Applets/Folder] Re-arrange positioning of "Arrange in" and "Align" submenus

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: hein, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Move the "Arrange in" and "Align" submenus below "Sort by" and "Icon size", 
which are
  more useful and commonly-used.
  
  BUG: 360353
  FIXED-IN: 5.18.0

TEST PLAN
  F7924242: after.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  re-arrange-arrange (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D26882

AFFECTED FILES
  containments/desktop/plugins/folder/viewpropertiesmenu.cpp

To: ngraham, hein, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[Christian]

Fuchs added a comment.


  Looks good to me, thank you very much for the work :-)
  
  Sidesnotes that I mentioned in the group, just so they are documented here:
  
  - I think for a clickable action it can become too small, so it takes too 
much aiming. However, it doesn't get in the way, and people annoyed by it can 
just disable it completely, so that's probably fine
  
  - Icon wise, given that it can still overlap with the app icon, I would 
prefer something that has a contrasting border, so e.g. a dark audio indicator 
is still visible on a dark app icon. But that can probably be addressed in a 
separate task, especially as it also affects other icons we have

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[George Vogiatzis]

gvgeo planned changes to this revision.
gvgeo added a comment.


  In D26880#599939 , @filipf wrote:
  
  > I also just noticed a pre-existing bug - that the hover effect filling the 
mouse area doesn't work well when the icon is smaller:
  >
  > F7923931: Screenshot_20200123_190024.png 

  >
  > The icon overflows the hover effect. I'm going to have the effect fill the 
icon instead:
  >
  > F7923933: Screenshot_20200123_185958.png 

  
  
  I will rebase on this patch and make icon aware of the orientation.
  Otherwise highlight area will overlap with the blue-bar on top when 
horizontal.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26739: [applets/Task Manager] Refine tooltip highlight effect

[Tranter Madi]

trmdi added a comment.


  Pretty nice.
  But clicking on `playerControlsRow` (exclude buttons) does not behave the 
same way like clicking on the cover art, while the effect would make users 
think that they can click on the control row to open the window.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26739

To: ngraham, #plasma, #vdg, filipf
Cc: trmdi, filipf, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  LGTM but let's wait for a #plasma  
review too to make sure this is the most technically correct way (I think it is 
but I'm not 100% sure).

REPOSITORY
  R119 Plasma Desktop

BRANCH
  no-hover-overlay (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26880

To: filipf, ngraham, #vdg, #plasma, hein
Cc: hein, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

[Filip Fila]

filipf updated this revision to Diff 74269.
filipf added a comment.


  have the hover effect fill the icon instead of the mousearea so that the icon 
doesn't overflow the effect at small sizes

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26880?vs=74267=74269

BRANCH
  no-hover-overlay (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26880

AFFECTED FILES
  applets/taskmanager/package/contents/ui/AudioStream.qml

To: filipf, ngraham, #vdg, #plasma, hein
Cc: hein, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

[Filip Fila]

filipf added a comment.


  I also just noticed a pre-existing bug - that the hover effect filling the 
mouse area doesn't work well when the icon is smaller:
  
  F7923931: Screenshot_20200123_190024.png 

  
  The icon overflows the hover effect. I'm going to have the effect fill the 
icon instead:
  
  F7923933: Screenshot_20200123_185958.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26880

To: filipf, ngraham, #vdg, #plasma, hein
Cc: hein, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26881: [Applets/Folder View] Allow using a folder that ends with a space

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: hein, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  `QUrl::fromLocalFile` is otherwise appropriate but automatically strips a 
trailing space,
  which we don't want. This patch explicitly handles that case.
  
  CCBUG: 407671

TEST PLAN
  Configure Folder View applet
  Enter a valid path to a folder whose name ends with a space
  It works

REPOSITORY
  R119 Plasma Desktop

BRANCH
  allow-adding-folders-that-end-with-a-space (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26881

AFFECTED FILES
  containments/desktop/plugins/folder/foldermodel.cpp

To: ngraham, hein, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

[Filip Fila]

filipf added a subscriber: hein.
filipf added a comment.


  In D26880#599907 , @gvgeo wrote:
  
  > More sane value like z: 1 in the svg should be enough .
  >
  > But in this case can MouseArea move before svg? Makes more sense to me, 
having the code in the draw order .
  >  I'm not a developer, just asking.
  
  
  Now that you got me thinking, I wonder if the top item can just be switched 
from Item to MouseArea. Works for me so I updated the diff.
  
  @hein ?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26880

To: filipf, ngraham, #vdg
Cc: hein, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

[Filip Fila]

filipf updated this revision to Diff 74267.
filipf added a comment.


  don't use "z" hacks, just rearrange the order of items
  also port the top item to MouseArea to be more efficient

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26880?vs=74261=74267

BRANCH
  no-hover-overlay (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26880

AFFECTED FILES
  applets/taskmanager/package/contents/ui/AudioStream.qml

To: filipf, ngraham, #vdg
Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26514: Delay popup for containments

[Tranter Madi]

trmdi updated this revision to Diff 74264.
trmdi added a dependency: D26484: Add KIO::DropJobFlag to allow manually 
showing the menu.
trmdi added a comment.


  - Show drop menu manually when dropping things into the desktop

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26514?vs=73081=74264

BRANCH
  improve-dropJob (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26514

AFFECTED FILES
  containments/desktop/package/contents/ui/FolderView.qml
  containments/desktop/plugins/folder/foldermodel.cpp
  containments/desktop/plugins/folder/foldermodel.h

To: trmdi, #plasma, dfaure
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

[George Vogiatzis]

gvgeo added a comment.


  More sane value like z: 1 in the svg should be enough .
  
  But in this case can MouseArea move before svg? Makes more sense to me, 
having the code in the draw order .
  I'm not a developer, just asking.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26880

To: filipf, ngraham, #vdg
Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[George Vogiatzis]

gvgeo updated this revision to Diff 74262.
gvgeo added a comment.


  Fix inhibition icon size.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26806?vs=74228=74262

BRANCH
  b3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26806

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/BatteryItem.qml
  applets/batterymonitor/package/contents/ui/BrightnessItem.qml
  applets/batterymonitor/package/contents/ui/InhibitionHint.qml
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/batterymonitor/package/contents/ui/PowerManagementItem.qml
  applets/batterymonitor/package/contents/ui/batterymonitor.qml
  applets/batterymonitor/package/contents/ui/logic.js

To: gvgeo, #plasma, #vdg, davidedmundson
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26866: [Kickoff] Theme separators

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:33b138893bcd: [Kickoff] Theme separators (authored by 
filipf).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26866?vs=74221=74263

REVISION DETAIL
  https://phabricator.kde.org/D26866

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: filipf, #plasma, #vdg, davidedmundson, ngraham
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26880: [Task Manager] Draw audio icon highlight effect behind the icon, not in front of it

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Some Plasma themes used filled-style highlight effects which means that their 
audio icon gets completely covered by the highlight effect.
  
  This patch makes the effect be drawn behind the icon.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  no-hover-overlay (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26880

AFFECTED FILES
  applets/taskmanager/package/contents/ui/AudioStream.qml

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26797: KCM/Component Refactor UI to a single list of combobox

[Méven Car]

meven added a comment.


  In D26797#599747 , @filipf wrote:
  
  > A lot cleaner and straightforward now, good job. I was wondering though 
what it would look like if we made all the comoboboxes have equal width (if 
possible).
  
  
  I can make that happen, at some point they expanded to the right which wasn't 
ideal.

INLINE COMMENTS

> broulik wrote in componentchooser.cpp:93
> Check if `loadedConfigWidget` is null

I'd rather have a Q_ASSERT : this isn't supposed to happen

REPOSITORY
  R119 Plasma Desktop

BRANCH
  new-component-chooser

REVISION DETAIL
  https://phabricator.kde.org/D26797

To: meven, #plasma, #vdg, ngraham, ervin
Cc: filipf, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26760: Update from Plasma for ToolTipInstance.qml

[Tranter Madi]

trmdi added a comment.


  In D26760#599227 , @mvourlakos 
wrote:
  
  > @trmdi have you checked the previews still work OK after the patch?
  
  
  Yes, I tested it.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D26760

To: trmdi, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[Filip Fila]

filipf added a comment.


  I don't use IOTM, but this looks quite alright to me.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  audioshrink (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26875: Make it possible to stream only input

[Jan Grulich]

jgrulich added inline comments.

INLINE COMMENTS

> waylandintegration.cpp:257
>  m_streamingEnabled = true;
> +startStreamingInput();
>  bindOutput(output.waylandOutputName(), 
> output.waylandOutputVersion());

Maybe use m_streamInput = true for consistendy with stopStreaming() where you 
use m_streamInput = false.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26875

To: apol, #plasma, #kde_connect, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26760: Update from Plasma for ToolTipInstance.qml

[Tranter Madi]

trmdi updated this revision to Diff 74260.
trmdi added a comment.


  - Address comment

REPOSITORY
  R878 Latte Dock

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26760?vs=73935=74260

BRANCH
  update-ToolTipInstance-fromPlasma (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26760

AFFECTED FILES
  plasmoid/package/contents/ui/main.qml
  plasmoid/package/contents/ui/previews/ToolTipInstance.qml

To: trmdi, #latte_dock, mvourlakos
Cc: mvourlakos, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> PopupDialog.qml:76
> +visible: inhibitions.length > 0
> +iconSource: inhibitions.length > 0 ? inhibitions[0].Icon 
> || "" : ""
> +text: {

The icon is a bit small: F7923036: Screenshot_20200123_093232.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26806

To: gvgeo, #plasma, #vdg, davidedmundson
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26875: Make it possible to stream only input

[Aleix Pol Gonzalez]

apol created this revision.
apol added reviewers: Plasma, KDE Connect.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
apol requested review of this revision.

REVISION SUMMARY
  No need to share our screen contents to be able to move the mouse.

TEST PLAN
  Ported KDE Connect to it, works.
  https://invent.kde.org/kde/kdeconnect-kde/merge_requests/199

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26875

AFFECTED FILES
  src/remotedesktop.cpp
  src/waylandintegration.cpp
  src/waylandintegration.h
  src/waylandintegration_p.h

To: apol, #plasma, #kde_connect
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26850: [SystemTray] Refresh icon in settings on update

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> systemtraymodel.cpp:269
> +QHash roleNames = sourceModel->roleNames();
> +for (const int key : roleNames.keys()) {
> +if (!m_roleNames.contains(key)) {

Avoid `keys()` which creates a temporary list, instead use iterators

  const auto roleNames = sourceModel->roleNames();
  for (auto it = roleNames.begin(), end = roleNames.end(); it != end; ++it) {
  if (!m_roleNames.contains(it.key()) {
  m_roleNames.insert(it.key(), it.value());
  }
  }

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26850

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added subscribers: cblack, filipf, ndavis, Fuchs, broulik.
ngraham added a comment.
This revision is now accepted and ready to land.


  I was working on a patch to improve things here and it was almost identical 
to this one. I think this is a good fix. Tested on an IOTM as well as a regular 
task manager on all four screen edges with various panel thicknesses and I did 
not find any regressions, and it did seem better to me.
  
  Let's make sure we hear from some of the other people who I recall had voiced 
concerns about the indicator getting in the way: @fuchs, @broulik, @cblack, 
@filipf @ndavis

REPOSITORY
  R119 Plasma Desktop

BRANCH
  audioshrink (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: broulik, Fuchs, ndavis, filipf, cblack, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26709: add gpu entry to about system

[Harald Sitter]

sitter updated this revision to Diff 74250.
sitter added a comment.


  s/gpu/graphics processor/

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26709?vs=73710=74250

BRANCH
  gpu

REVISION DETAIL
  https://phabricator.kde.org/D26709

AFFECTED FILES
  Modules/about-distro/src/CMakeLists.txt
  Modules/about-distro/src/CPUEntry.cpp
  Modules/about-distro/src/FancyString.cpp
  Modules/about-distro/src/FancyString.h
  Modules/about-distro/src/GPUEntry.cpp
  Modules/about-distro/src/GPUEntry.h
  Modules/about-distro/src/Module.cpp

To: sitter, davidedmundson
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26709: add gpu entry to about system

[Harald Sitter]

sitter added a comment.


  Good point.

REPOSITORY
  R102 KInfoCenter

BRANCH
  gpu

REVISION DETAIL
  https://phabricator.kde.org/D26709

To: sitter, davidedmundson
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26866: [Kickoff] Theme separators

[Nathaniel Graham]

ngraham added a comment.


  No objection.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  themed-kickoff-separators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26866

To: filipf, #plasma, #vdg, davidedmundson, ngraham
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26709: add gpu entry to about system

[Nathaniel Graham]

ngraham added a comment.


  Maybe the label should say "Graphics:" or "Graphics Processor" instead of 
using an acronym. We say "Memory" instead of "RAM" after all.

REPOSITORY
  R102 KInfoCenter

BRANCH
  gpu

REVISION DETAIL
  https://phabricator.kde.org/D26709

To: sitter, davidedmundson
Cc: ngraham, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26866: [Kickoff] Theme separators

[Filip Fila]

filipf added a comment.


  Can I land it on the 5.18 branch as well?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  themed-kickoff-separators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26866

To: filipf, #plasma, #vdg, davidedmundson, ngraham
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26797: KCM/Component Refactor UI to a single list of combobox

[Filip Fila]

filipf added a comment.


  A lot cleaner and straightforward now, good job. I was wondering though what 
it would look like if we made all the comoboboxes have equal width (if 
possible).

REPOSITORY
  R119 Plasma Desktop

BRANCH
  new-component-chooser

REVISION DETAIL
  https://phabricator.kde.org/D26797

To: meven, #plasma, #vdg, ngraham, ervin
Cc: filipf, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D26797: KCM/Component Refactor UI to a single list of combobox

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> componentchooser.cpp:65
>  
> - if (loadedConfigWidget) {
> - configWidgetMap.insert(service, loadedConfigWidget);
> - configContainer->addWidget(loadedConfigWidget);
> - connect(loadedConfigWidget, SIGNAL(changed(bool)), this, 
> SLOT(emitChanged(bool)));
> - }
> -}
> +QLabel *label = new QLabel(i18nc("The label for the combobox : 
> browser, terminal emulator...)", "%1:", name), this);
> +label->setToolTip(cfg.group(QByteArray()).readEntry("Comment", 
> QString()));

Superfluous space before `:`

> componentchooser.cpp:70
>  
> - if (somethingChanged) {
> - if (KMessageBox::questionYesNo(this,i18n("You changed the 
> default component of your choice, do want to save that change now 
> ?"),QString(),KStandardGuiItem::save(),KStandardGuiItem::discard())==KMessageBox::Yes)
>  save();
> - }
> - const QString  = it->data(Qt::UserRole).toString();
> - KConfig cfg(service, KConfig::SimpleConfig);
> +connect(loadedConfigWidget, SIGNAL(changed(bool)), this, 
> SLOT(emitChanged()));
>  

Use new connect syntax

> componentchooser.cpp:93
> +}
> +loadedConfigWidget->setSizeAdjustPolicy(QComboBox::AdjustToContents);
>  

Check if `loadedConfigWidget` is null

> componentchooser.cpp:101
> +bool somethingChanged = false;
> +bool isDefault = true;
> +// check if another plugin has changed and default status

`isDefaults`

> componentchooser.cpp:103
> +// check if another plugin has changed and default status
> +for (auto it = configWidgetMap.constKeyValueBegin(); it != 
> configWidgetMap.constKeyValueEnd(); ++it) {
> +CfgPlugin *plugin = dynamic_cast((*it).second);

You don't actually use the `key`, so you can just use range-for.

> componentchooser.cpp:121
>  void ComponentChooser::load() {
> - if( configWidget )
> - {
> - CfgPlugin * plugin = dynamic_cast( configWidget );
> - if( plugin )
> - {
> - KConfig cfg(latestEditedService, KConfig::SimpleConfig);
> - plugin->load(  );
> - }
> +for (auto it = configWidgetMap.constKeyValueBegin(); it != 
> configWidgetMap.constKeyValueEnd(); ++it) {
> +

normal `constBegin()` and then `it.key()` and `it.value()` below

> componentchooser.cpp:141
> +CfgPlugin *plugin = dynamic_cast( widget );
> +if (plugin) {
> +KConfig cfg(service, KConfig::SimpleConfig);

In some places you check if your `dynamic_cast` worked and sometimes you don't. 
Since we only put `CfgPlugin` instanes in there, I don't think we need to 
check. See my note on the ominous plug-in architecture above.

> componentchooser.cpp:152
>  void ComponentChooser::restoreDefault() {
> -if (configWidget)
> -{
> +for (const auto  : configWidgetMap) {
>  dynamic_cast(configWidget)->defaults();

The hash contains pointers, so `auto *`

> componentchooser.cpp:161
> - {
> - loadedConfigWidget = new CfgComponent(configContainer);
> - 
> static_cast(loadedConfigWidget)->ChooserDocu->setText(i18n("Choose
>  from the list below which component should be used by default for the %1 
> service.", name));

It appears you dropped the generic component configuration? If that even was a 
thing... makes me wonder why this KCM uses desktop files when it effectively 
only operates on a fixed set of options.

> It will be parted of the plugin interface which I plan for KDE 3.2.

Well, so much for that I guess?

> componentchooserbrowser.cpp:104
>  }
>  if (service->storageId() == 
> QStringLiteral("org.kde.falkon.desktop")) {
> +m_falkonIndex = count() - 1;

As a future step I would like those default components not hardcoded in the code

> componentchooserbrowser.cpp:111
>  // we have a browser specified by the user
> -
> browserCombo->addItem(QIcon::fromTheme(QStringLiteral("application-x-shellscript")),
>  browser->name(), browser->storageId());
> -browserCombo->setCurrentIndex(browserCombo->count() - 1);
> -m_currentIndex = browserCombo->count() - 1;
> +
> addItem(QIcon::fromTheme(QStringLiteral("application-x-shellscript")), 
> browser->name(), browser->storageId());
> +setCurrentIndex(count() - 1);

Something funky is going on with this one:

I configured a custom `kdialog --sorry "%f"` command line. It only shows up as 
"kdialog" so I can't tell what the actual command was and not edit it later.

More importantly, though, I then changed my browser to be Kate. While it 
initially showed "Kate" with proper icon, when I re-open the KCM, it shows 
"kdialog" again as custom command, while still opening Kate when I open http 
URLs. 
Now it keeps showing "kdialog" no matter what default browser I use.

> componentchooserbrowser.cpp:117
>  // add a other option to add a new browser
> -
> 

D26866: [Kickoff] Theme separators

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  Makes sense now. Let's land this and then fix the separator in another patch.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  themed-kickoff-separators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26866

To: filipf, #plasma, #vdg, davidedmundson, ngraham
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26866: [Kickoff] Theme separators

[Filip Fila]

filipf added a subscriber: ndavis.
filipf added a comment.


  Might actually be a lot simpler. It seems our line SVG file adds 1px of 
padding on each side:
  
  F7922297: image.png 
  
  @ndavis do you think it's alright to remove this padding?

REPOSITORY
  R119 Plasma Desktop

BRANCH
  themed-kickoff-separators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26866

To: filipf, #plasma, #vdg, davidedmundson
Cc: ndavis, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26866: [Kickoff] Theme separators

[Filip Fila]

filipf added a comment.


  In D26866#599653 , @ngraham wrote:
  
  > When using the Breeze style, the blue selection line no longer touches the 
separator line:
  >
  > F796: Screenshot_20200123_073450.png 

  >
  > F7922231: Screenshot_20200123_073540.PNG 

  
  
  Unfortunately not, yeah. It happens with all themes and is due to the changes 
in the height/width. The thing is if I leave the old height/width values the 
lines get rendered more dimly than they should so they need to be using the 
SVG's element size.
  
  Now as for why this element size generates padding, I'm not sure. I could 
look into PlasmaCore.Svg and PlasmaCore.SvgItem source files.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  themed-kickoff-separators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26866

To: filipf, #plasma, #vdg, davidedmundson
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26870: [ksgrd] Drop a QWidget dependency

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The broadcaster just needs to receive a QEvent getting propogated
  upwards, it doesn't need to be a QWidget.
  
  This makes the client API considerably lighter.
  
  .so is bumped as it is technically an ABI break.

TEST PLAN
  Ksysguard still works
  lddtree shows everything being much lighter

REPOSITORY
  R111 KSysguard Library

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26870

AFFECTED FILES
  CMakeLists.txt
  ksgrd/CMakeLists.txt
  ksgrd/SensorManager.cpp
  ksgrd/SensorManager.h

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26871: [examples/simplechatapp] Always set isMenu to true

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: mart.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  It does the right thing on mobile automatically

REPOSITORY
  R169 Kirigami

BRANCH
  menu

REVISION DETAIL
  https://phabricator.kde.org/D26871

AFFECTED FILES
  examples/simpleexamples/simpleChatApp.qml

To: nicolasfella, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D26866: [Kickoff] Theme separators

[Nathaniel Graham]

ngraham added a comment.


  When using the Breeze style, the blue selection line no longer touches the 
separator line:
  
  F796: Screenshot_20200123_073450.png 

  
  F7922231: Screenshot_20200123_073540.PNG 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  themed-kickoff-separators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26866

To: filipf, #plasma, #vdg, davidedmundson
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26842: Fix fonts KCM button state

[Kevin Ottens]

ervin added inline comments.

INLINE COMMENTS

> broulik wrote in fonts.cpp:479
> Kinda defies the purpose of using kconfigxt if we end up hardcoding the state 
> in code again?

That part was never transitioned to KConfigXT though since it doesn't have a 
KConfig backend.

Clearly inheriting by hand from KCoreConfigSkeleton should be next on the 
options to be evaluated (not in that patch though).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26842

To: bport, #plasma, ervin, crossi, meven
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[George Vogiatzis]

gvgeo marked 3 inline comments as done.
gvgeo added a comment.


  I marked 3 comments as done that had forgotten, as I removed the old tooltip 
code.
  If there is something else, please be more specific. I can not see a better 
way to address any of your comments.

INLINE COMMENTS

> BatteryItem.qml:64
>  
> -states: [
> -State {
> -when: !!detailsLayout.parent.inListView // HACK
> -PropertyChanges {
> -target: detailsLabel
> -horizontalAlignment: modelData.value ? 
> Text.AlignRight : Text.AlignLeft
> -font.pointSize: theme.smallestFont.pointSize
> -width: parent ? parent.width / 2 : 0
> -elide: Text.ElideNone // eliding and height: 
> implicitHeight causes loops
> -}
> +onPaintedWidthChanged: { // horrible HACK to get a column 
> layout
> +if (modelData.label && paintedWidth > 
> detailsLayout.leftColumnWidth) {

No, it does not. Those two comments were in the same commit, to avoid the 
GridLayout crash.
https://phabricator.kde.org/R120:d12521b149fa7766fbbeb9957bde14b4a6278928

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26806

To: gvgeo, #plasma, #vdg, davidedmundson
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26797: KCM/Component Refactor UI to a single list of combobox

[Méven Car]

meven added a comment.


  In D26797#598189 , @ngraham wrote:
  
  > In D26797#598030 , @meven wrote:
  >
  > > @ngraham I think I should wait for some feedback/review from #VDG 
 or #Plasma 
 to iron out issues if any.
  >
  >
  > For sure.
  
  
  Would love to find a reviewer from #VDG 
 or #Plasma 


REPOSITORY
  R119 Plasma Desktop

BRANCH
  new-component-chooser

REVISION DETAIL
  https://phabricator.kde.org/D26797

To: meven, #plasma, #vdg, ngraham, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26842: Fix fonts KCM button state

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> fonts.cpp:479
> +defaultState.dpi = 0;
> +defaultState.subPixel = KXftConfig::SubPixel::Rgb;
> +defaultState.hinting = KXftConfig::Hint::Slight;

Kinda defies the purpose of using kconfigxt if we end up hardcoding the state 
in code again?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26842

To: bport, #plasma, ervin, crossi, meven
Cc: broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in BatteryItem.qml:64
> That's been in there ever since the initial release 2013.

Well that explains  "// GridLayout crashes with a Repeater in it somehow"

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26806

To: gvgeo, #plasma, #vdg, davidedmundson
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in BatteryItem.qml:64
> You can't do that.
> 
> That'll change the column size, which will change our text bounding box which 
> will change our paintedWidth. A loop.

That's been in there ever since the initial release 2013.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26806

To: gvgeo, #plasma, #vdg, davidedmundson
Cc: broulik, ngraham, manueljlin, davidedmundson, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  Few of my initial comments do not seem to be addressed yet.

INLINE COMMENTS

> BatteryItem.qml:64
>  
> -states: [
> -State {
> -when: !!detailsLayout.parent.inListView // HACK
> -PropertyChanges {
> -target: detailsLabel
> -horizontalAlignment: modelData.value ? 
> Text.AlignRight : Text.AlignLeft
> -font.pointSize: theme.smallestFont.pointSize
> -width: parent ? parent.width / 2 : 0
> -elide: Text.ElideNone // eliding and height: 
> implicitHeight causes loops
> -}
> +onPaintedWidthChanged: { // horrible HACK to get a column 
> layout
> +if (modelData.label && paintedWidth > 
> detailsLayout.leftColumnWidth) {

You can't do that.

That'll change the column size, which will change our text bounding box which 
will change our paintedWidth. A loop.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26806

To: gvgeo, #plasma, #vdg, davidedmundson
Cc: ngraham, manueljlin, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[George Vogiatzis]

gvgeo updated this revision to Diff 74228.
gvgeo added a comment.


  Remove detailsLoader visibility

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26806?vs=74222=74228

BRANCH
  b3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26806

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/BatteryItem.qml
  applets/batterymonitor/package/contents/ui/BrightnessItem.qml
  applets/batterymonitor/package/contents/ui/InhibitionHint.qml
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/batterymonitor/package/contents/ui/PowerManagementItem.qml
  applets/batterymonitor/package/contents/ui/batterymonitor.qml
  applets/batterymonitor/package/contents/ui/logic.js

To: gvgeo, #plasma, #vdg
Cc: ngraham, manueljlin, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26806: [Applets/Power Manager] Update layout based on T10470

[George Vogiatzis]

gvgeo updated this revision to Diff 74222.
gvgeo added a comment.


  Removed battery tooltip (had no extra info).
  Changed details view.
  
  Would be better without colon and without grid arrangement?

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26806?vs=74158=74222

BRANCH
  b3 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26806

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/BatteryItem.qml
  applets/batterymonitor/package/contents/ui/BrightnessItem.qml
  applets/batterymonitor/package/contents/ui/InhibitionHint.qml
  applets/batterymonitor/package/contents/ui/PopupDialog.qml
  applets/batterymonitor/package/contents/ui/PowerManagementItem.qml
  applets/batterymonitor/package/contents/ui/batterymonitor.qml
  applets/batterymonitor/package/contents/ui/logic.js

To: gvgeo, #plasma, #vdg
Cc: ngraham, manueljlin, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

Re: Guarding against use of Plasma with qt5ct

[Filip Fila]

I would say the latter in most cases - distros set it.

On Thu, Jan 23, 2020, 12:06 David Edmundson 
wrote:

> >Some ideas could be adding an inline message in the Application Style kcm
> when qt5ct is detected or just simply unsetting the qt5ct env variable on
> start.
>
> Can you explain how users get this env set. Is it them manually doing
> something or do some distros install some sort of hook that sets it?
>

D26866: [Kickoff] Theme separators

[Filip Fila]

filipf updated this revision to Diff 74221.
filipf added a comment.


  use the element's own dimensions for geometry instead of hardcoding

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26866?vs=74218=74221

BRANCH
  themed-kickoff-separators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26866

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: filipf, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26862: Remove unused includes

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:5a5f32ea02f8: Remove unused includes (authored by 
broulik).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26862?vs=74197=74219

REVISION DETAIL
  https://phabricator.kde.org/D26862

AFFECTED FILES
  Modules/base/info_linux.cpp
  Modules/info/info.cpp

To: broulik, #plasma, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26866: [Kickoff] Theme separators

[Filip Fila]

filipf added inline comments.

INLINE COMMENTS

> FullRepresentation.qml:127
>  }
> +height: Math.floor(units.devicePixelRatio)
> +width: root.width - 2 * units.gridUnit

maybe this doesn't need to be specified anymore? (and everywhere else in the 
diff)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26866

To: filipf, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26866: [Kickoff] Theme separators

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  Kickoff's separators were drawn as rectangles which doesn't allow them to be 
themed.
  
  We have the infrastructure to theme lines though so this patch makes use of 
it.
  
  The benefit is that themes can now gracefully incorporate separators into 
their design.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  themed-kickoff-separators (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26866

AFFECTED FILES
  applets/kickoff/package/contents/ui/FullRepresentation.qml

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Guarding against use of Plasma with qt5ct

[David Edmundson]

>Some ideas could be adding an inline message in the Application Style kcm when 
>qt5ct is detected or just simply unsetting the qt5ct env variable on start.

Can you explain how users get this env set. Is it them manually doing
something or do some distros install some sort of hook that sets it?

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

[Dan Leinir Turthra Jensen]

leinir updated this revision to Diff 74208.
leinir added a comment.


  - Actually make the service locator work (need to query for the right thing)

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25961?vs=73756=74208

BRANCH
  switch-attica-plugin-to-kaccounts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25961

AFFECTED FILES
  CMakeLists.txt
  attica-kde/kdeplugin/CMakeLists.txt
  attica-kde/kdeplugin/kdeplatformdependent.cpp
  attica-kde/kdeplugin/kdeplatformdependent.h
  attica-kde/kdeplugin/opendesktop-rating.service
  attica-kde/kdeplugin/opendesktop.provider

To: leinir
Cc: zachus, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26825: Bind gtk-enable-animations setting to global animation speed slider

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:66ab37df7aed: Bind gtk-enable-animations setting to global 
animation speed slider (authored by broulik).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26825?vs=74203=74207

REVISION DETAIL
  https://phabricator.kde.org/D26825

AFFECTED FILES
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: broulik, #plasma, gikari
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26825: Bind gtk-enable-animations setting to global animation speed slider

[Kai Uwe Broulik]

broulik updated this revision to Diff 74203.
broulik added a comment.


  - Fix typos

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26825?vs=74193=74203

REVISION DETAIL
  https://phabricator.kde.org/D26825

AFFECTED FILES
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: broulik, #plasma, gikari
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26825: Bind gtk-enable-animations setting to global animation speed slider

[Mikhail Zolotukhin]

gikari added a comment.


  Some typos, without them everything is OK.

INLINE COMMENTS

> configeditor.cpp:173
>  QStringLiteral("gtk-primary-button-warps-slider"),
> +QStringLiteral("enable-animations"),
>  };

You have a typo. The correct name of the parameter is 
"__gtk-__enable-animations"

> configeditor.cpp:199
>  QStringLiteral("Gtk/PrimaryButtonWarpsSlider"),
> +QStringLiteral("Gtk/EnableAnimation"),
>  };

You have a typo. EnableAnimation__s__.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26825

To: broulik, #plasma, gikari
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26862: Remove unused includes

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

TEST PLAN
  - Compiles

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D26862

AFFECTED FILES
  Modules/base/info_linux.cpp
  Modules/info/info.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[George Vogiatzis]

gvgeo added a comment.


  Could not pin point a specific size to disable mute function. If it is still 
a problem with this patch, maybe need to disable it for 5.18, and add a config 
option in the next release.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D26861

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26861: [Applet/Task Manager] Move audio indicator to the corner

[George Vogiatzis]

gvgeo created this revision.
gvgeo added reviewers: VDG, Plasma, hein, ngraham.
gvgeo added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REVISION SUMMARY
  When vertical or Icon-only task manager, shrink click area 10% and
  indicator 30%.
  This allows moving it closer to the corner, away from the center,
  to avoid accidental audio muting.
  
  BUG: 416553
  FIXED-IN: 5.18.1

REPOSITORY
  R119 Plasma Desktop

BRANCH
  audioshrink (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26861

AFFECTED FILES
  applets/taskmanager/package/contents/ui/AudioStream.qml
  applets/taskmanager/package/contents/ui/Task.qml

To: gvgeo, #vdg, #plasma, hein, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26825: Bind gtk-enable-animations setting to global animation speed slider

[Kai Uwe Broulik]

broulik updated this revision to Diff 74193.

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26825?vs=74115=74193

REVISION DETAIL
  https://phabricator.kde.org/D26825

AFFECTED FILES
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: broulik, #plasma, gikari
Cc: ngraham, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26256: [Applet] Make 'raise maximum volume' global

[George Vogiatzis]

gvgeo updated this revision to Diff 74192.
gvgeo added a comment.


  Fix volume icons

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26256?vs=74146=74192

BRANCH
  raise2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26256

AFFECTED FILES
  applet/contents/code/icon.js
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml

To: gvgeo, ngraham, #vdg, #plasma, drosca
Cc: drosca, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart