Re: Policy Changes: Bugzilla statuses

Am 21.02.20 um 00:18 schrieb Nate Graham: We don't have to make VHI-priority bugs release blockers per se, but rather treat them as "please fix this before the release or else users will complain a lot" type of bugs. There's no point in marking infamous and half a decade old bugs like the nvi

D27003: [kstyle] Port to QWindow::startSystemMove()

zzag added a comment. > WARNING: I have no idea whether KDE Plasma 5.19 is going to depend on Qt 5.15. KDE Plasma 5.19 will depend on Qt 5.14. :( REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27003 To: zzag, #kwin, #plasma, hpereiradacosta Cc: plasma-devel, Ora

D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

dvratil updated this revision to Diff 76080. dvratil added a comment. - Fix typo REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27536?vs=76079&id=76080 BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27536 AFFECTED FILES bac

D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

dvratil created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. dvratil requested review of this revision. REPOSITORY R110 KScreen Library BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27536 AFFECTED FILES backends/kwayland/wayla

D27517: Better handle authentication error

apol added a comment. Review without knowing very well the codebase. INLINE COMMENTS > accountmodel.cpp:181 > { > -if(!index.isValid()) { > -return false; > +qDebug() << "AccountModel::setDataWithResult"; > +if (!index.isValid()) { Remove? > accountmodel.h:64 > +

D27525: Support Qt 5.14 on Android

apol added a comment. > Assets (QML files and icons) are no longer extracted into the file system, > but now are available in the android_rcc_bundle QRC file. Meaning that we now need to change all applications to put the resources on the rcc file? The change upstream seems bonker

Re: Policy Changes: Bugzilla statuses

On 2/20/20 3:54 PM, David Edmundson wrote: Would be nice if we could treat the VHI-priority bugs as release blockers, and the HI-priority bugs as things to work on for the next release. There's no way we can fix those within 2 weeks. Clarification: I meant that we could focus on HI-priority b

Re: Policy Changes: Bugzilla statuses

On Thu, Feb 20, 2020 at 9:04 PM Nate Graham wrote: > > On 2/20/20 10:50 AM, David Edmundson wrote: > > From the meeting > > > > - We are going to try and make use of the priority field in bugzilla > > in addition to the commonly used severity. > > > > - Lets try to order our personal searches aro

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

chauvin added inline comments. INLINE COMMENTS > chauvin wrote in configvalueprovider.cpp:50 > I observed a different behavior with ~/.gtkrc-2.0 (libgtk version 2.62.1) > There is perhaps a difference betwen gtk2 and gtk3 Sorry I missread the version of libgtk2.0 it is 2.24.32 (not 2.62.1) It

D27532: [applets/notes] Rename to "Sticky Note"

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The current name "Notes" is ambiguous and grammatically incorrect in various places due to

D27261: [Folder view] Fix binding loop on width

gvgeo added a comment. I logged with my main account and I get lots of file:///code/kde/usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/FolderItemDelegate.qml:306:17: QML Label: Binding loop detected for property "width" REPOSITORY R119 Plasma Desktop REVISION DET

D27481: Panel spacer that can center things

ngraham added a comment. That looks nice! REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27481 To: mart, #plasma, #vdg Cc: davidedmundson, davidre, broulik, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D27522: Fix date-label size in vertical layout

ngraham added a comment. Well your patch doesn't regress anything for me, so if it fixes it for you, that's good. Still it might be good to have some clarity here so we understand what's going on! :p REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2752

D27522: Fix date-label size in vertical layout

carewolf added a comment. In my case the text was too small. I wonder how exactly Text.Fit works, if it just increases font-size for short format to fill width that could make it too big. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27522 To: carewo

Re: Policy Changes: Bugzilla statuses

On 2/20/20 10:50 AM, David Edmundson wrote: From the meeting - We are going to try and make use of the priority field in bugzilla in addition to the commonly used severity. - Lets try to order our personal searches around it, not just always searching by date. - VHI bugs will be discussed at

D27522: Fix date-label size in vertical layout

ngraham added a comment. Thanks for the patch! Looks like this doesn't fully fix the issue though. With "Short Date" I see the following: F8116070: Screenshot_20200220_140027.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.

D27522: Fix date-label size in vertical layout

ngraham added a comment. (The bug I'm thinking of is https://bugs.kde.org/show_bug.cgi?id=417728) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27522 To: carewolf, ndavis, ngraham, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

chauvin added inline comments. INLINE COMMENTS > gikari wrote in configvalueprovider.cpp:50 > Comma is important, if not the comma, the GTK would not be able to parse font > with spaces in name. Comma fixed that bug: > https://bugs.kde.org/show_bug.cgi?id=380980 I observed a different behavior

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

gikari added inline comments. INLINE COMMENTS > chauvin wrote in configvalueprovider.cpp:50 > I think > > QStringLiteral(", ") > > should be replaced by a space (see my comment > ) > > however I don't know what will happen in ambigious cases s

D27530: Use appropriate icon for unconfigured applets' "Configure..." buttons

ngraham created this revision. ngraham added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY CCBUG: 412114 TEST PLAN F8116018: Screenshot_20200220_125515.png

D27529: [applets/weather] Remove outdated extra configure button

ngraham added a comment. And see also D27530 REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27529 To: davidedmundson, #plasma, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D27529: [applets/weather] Remove outdated extra configure button

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Stable branch? REPOSITORY R114 Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D27529 To: davidedmundson, #plasma, ngraham Cc: ngraham, plasma-devel, Orage

D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

chauvin added inline comments. INLINE COMMENTS > configvalueprovider.cpp:50 > +const QString fontStyle = fontStyleHelper(font); > +return font.family() + QStringLiteral(", ") + fontStyle + ' ' + > QString::number(font.pointSize()); > } I think QStringLiteral(", ") should be replace

D27529: [applets/weather] Remove outdated extra configure button

davidedmundson updated this revision to Diff 76067. davidedmundson added a comment. include comics REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27529?vs=76066&id=76067 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27529 AFFECTED

D27529: [applets/weather] Remove outdated extra configure button

ngraham added a comment. Comic strip widget is also affected. If you fix both in this patch, it will resolve 412114. :) REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27529 To: davidedmundson, #plasma Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-

D27529: [applets/weather] Remove outdated extra configure button

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY The containment seems to care for it correctly now Also the old code was

D27189: Created a top area based on widgets/toparea.svg

mart added inline comments. INLINE COMMENTS > ExpandedRepresentation.qml:48 > +fill: parent > +leftMargin: -dialog.margins.left > +topMargin: -dialog.margins.top not in all places you will have access to a dialog. the magic correct values should c

Policy Changes: Bugzilla statuses

>From the meeting - We are going to try and make use of the priority field in bugzilla in addition to the commonly used severity. - Lets try to order our personal searches around it, not just always searching by date. - VHI bugs will be discussed at the Monday meeting. - Let's also make use of

Policy changes: Adjusting Freezes

Notes from the plasma meeting: Freeze proposal: - Feature freeze 2 weeks before beta tagging (just before the relevant frameworks tag). String freeze remains on beta day as before. Branching remains on beta day as before. - Effectively this is formalising the existing unwritten rule of not

D27525: Support Qt 5.14 on Android

vkrause created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. vkrause requested review of this revision. REVISION SUMMARY Assets (QML files and icons) are no longer extracted into the file system, but now are available in the android_rcc_bundle QRC f

D27522: Fix date-label size in vertical layout

carewolf added a comment. It only affects vertical panels, it is in the vertical panel configuration. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27522 To: carewolf, ndavis, ngraham, #vdg Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jral

D27522: Fix date-label size in vertical layout

ndavis added a comment. Does this work well with vertical panels? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27522 To: carewolf, ndavis, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen

D27522: Fix date-label size in vertical layout

carewolf updated this revision to Diff 76055. carewolf added a comment. Fix the logic to what was probably originally meant. Elided is still disabled as it triggers too aggresively on narrow fits. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/

D27522: Fix date-label size in vertical layout

carewolf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. carewolf requested review of this revision. REVISION SUMMARY The text was smaller than than minimum configuration, and also smaller than the width allowed for. REPOSITORY R120 Plasma Wor

D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

tcanabrava updated this revision to Diff 76053. tcanabrava added a comment. - Simplify function / remove desktopResized REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26986?vs=74565&id=76053 BRANCH wip_fix_screenlocker_detach_reattach REVISION DET

D27521: Various fixes to make autotests run and pass

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. *facepalm* REPOSITORY R169 Kirigami BRANCH autotest_fixes REVISION DETAIL https://phabricator.kde.org/D27521 To: ahiemstra, #kirigami, apol Cc: apol, plasma-devel, fbampaloukas, GB_2, d

D26992: [SystemTray] Use unified data model everywhere

kmaterka added a comment. In D26992#614426 , @ngraham wrote: > UI looks good except for one thing: the changes to show a highlight effect on hover in the popup are unrelated and should be done in a separate patch (preferably in coordination with

D27515: Icon: fix rendering of image: urls on High DPI

This revision was automatically updated to reflect the committed changes. Closed by commit R169:2c4cc4816c04: Icon: fix rendering of image: urls on High DPI (authored by apol). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27515?vs=76034&id=76052 REVISION D

D27515: Icon: fix rendering of image: urls on High DPI

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. I was wrong. QQuickImageBase is the part that has the SVG check. This is going directly one level lower REPOSITORY R169 Kirigami BRANCH master REVISION DETAIL

D27457: Move kcminit_startup and kded to plasma-session

apol added a comment. LGTM otherwise INLINE COMMENTS > startup.cpp:422 > +m_process->setArguments(args); > +auto env = QProcessEnvironment::systemEnvironment(); > +env.insert(additionalEnv); only do it `if (!additionalEnv.isEmpty())` > startup.cpp:450 > +m_process->setArgume

D27518: Only enable the "Help" button if khelpcenter is available

apol requested changes to this revision. apol added a comment. This revision now requires changes to proceed. If khelpcenter is not available, we do an openUrl that should show the documentation on your browser. REPOSITORY R124 System Settings REVISION DETAIL https://phabricator.kde.org/

D27513: Kill Runner: Remove duplicate function calls and refactor

apol added a comment. Seems to me like there's 2 very different changes here, can you split in 2 reviews? INLINE COMMENTS > CMakeLists.txt:20 > +set(krunner_kill_SRCS killrunner.cpp) > add_library(krunner_kill MODULE ${krunner_kill_SRCS}) > target_link_libraries(krunner_kill just pass it

D27521: Various fixes to make autotests run and pass

ahiemstra created this revision. ahiemstra added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY Apparently Kirigami's autotests have not run for a while. This patch fixes that and ma

D27495: Remove unnecessary code and function calls

alex added a comment. Thanks for the feedback. The actionsForMatch method gets actually called very often, I debugged this by adding `qWarning() << match.text();` as a debug statement in the method. But I guess that I can keep the changes. REPOSITORY R120 Plasma Workspace BRANCH

D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

leinir updated this revision to Diff 76049. leinir added a comment. Fair bit of work gone on here, but in short, given a patch which handles the OpenID ID token in the OAuth2 requests in signon-plugin-oauth2, we are now able to construct a bearer-authenticated request and whatnot. There is

D27518: Only enable the "Help" button if khelpcenter is available

ahmadsamir created this revision. ahmadsamir added a reviewer: Plasma. Herald added a project: Plasma. ahmadsamir requested review of this revision. REVISION SUMMARY Use a static const bool to check if khelpcenter is available on the system, so as not to check every time a module is opened.

D27457: Move kcminit_startup and kded to plasma-session

davidedmundson updated this revision to Diff 76045. davidedmundson added a comment. fixup diff REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27457?vs=76044&id=76045 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27457 AFFECTED F

D27457: Move kcminit_startup and kded to plasma-session

davidedmundson updated this revision to Diff 76044. davidedmundson added a comment. only pass in adjusted env REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27457?vs=75908&id=76044 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27

D27495: Remove unnecessary code and function calls

davidedmundson added a comment. Cleanup is good. > Futhermore the match icon and the list of actions can be reused. I don't think these changes really bring anything. Icon's are cached at the layer beneath (with a proper QCache with expunging) and actionsForMatch is called so rarel

D27505: Do not crash when icon's width or height is 0

This revision was automatically updated to reflect the committed changes. Closed by commit R169:fcae16b30b06: Do not crash when icon's width or height is 0 (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27505?vs=76002&id=76043 REVISI

D27481: Panel spacer that can center things

mart added a comment. In D27481#614250 , @davidre wrote: > In D27481#614167 , @davidre wrote: > > > I think the deisgn og the spacer could be better in edit mode to clearly mark it as a spacer but t

D27515: Icon: fix rendering of image: urls on High DPI

davidedmundson added a comment. > QQuickImageProvider wants the requestedSize to be accounting for the dpi scaling. For stupid reasons, that isn't the case if the path is an SVG. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D27515 To: apol, #plasma, #kirigam

D27481: Panel spacer that can center things

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in panelconfigview.cpp:115 > why is this a script? so, i need to add the second spacer at first position rather than the last. I don't think i can do this without a script, as i need to access the qquickitem to actually set a p

D27481: Panel spacer that can center things

davidedmundson added inline comments. INLINE COMMENTS > panelconfigview.cpp:115 > +// this to trigger the panel centering mode of the spacer in a slightly > more discoverable way > +c->evaluateScript(QStringLiteral("panel = panelById(") + > QString::number(m_containment->id()) > +

D27481: Panel spacer that can center things

mart added a comment. In D27481#614250 , @davidre wrote: > In D27481#614167 , @davidre wrote: > > > I think the deisgn og the spacer could be better in edit mode to clearly mark it as a spacer but t

D27517: Better handle authentication error

meven created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY BUG: 417882 Not tested yet ! REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D27517

D27480: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings

bport accepted this revision. bport added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > DeviceAutomounter.cpp:39 > DeviceAutomounter::DeviceAutomounter(QObject *parent, const QVariantList > &args) > -: KDEDModule(parent) > +: KDEDModule(parent), m_s

D27495: Remove unnecessary code and function calls

meven accepted this revision. meven added a comment. This revision is now accepted and ready to land. Seems good to me, please give time to other reviewers. REPOSITORY R120 Plasma Workspace BRANCH shellrunner_cleanup REVISION DETAIL https://phabricator.kde.org/D27495 To: alex, davided