Re: Policy Changes: Bugzilla statuses

2020-02-20 Thread Kai Uwe Broulik

Am 21.02.20 um 00:18 schrieb Nate Graham:
We don't have to make VHI-priority bugs release blockers per se, but 
rather treat them as "please fix this before the release or else users 
will complain a lot" type of bugs.


There's no point in marking infamous and half a decade old bugs like the 
nvidia panel repaint bug as VHI i.e. "release blocker" as nobody will 
care about the policy when it's clearly pointless.






D27003: [kstyle] Port to QWindow::startSystemMove()

2020-02-20 Thread Vlad Zahorodnii
zzag added a comment.


  > WARNING: I have no idea whether KDE Plasma 5.19 is going to depend on Qt 
5.15.
  
  KDE Plasma 5.19 will depend on Qt 5.14. :(

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27003

To: zzag, #kwin, #plasma, hpereiradacosta
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

2020-02-20 Thread Daniel Vrátil
dvratil updated this revision to Diff 76080.
dvratil added a comment.


  - Fix typo

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27536?vs=76079=76080

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27536

AFFECTED FILES
  backends/kwayland/waylandconfig.cpp

To: dvratil, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27536: fix(kwayland): remove code with side-effects from Q_ASSERT

2020-02-20 Thread Daniel Vrátil
dvratil created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
dvratil requested review of this revision.

REPOSITORY
  R110 KScreen Library

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27536

AFFECTED FILES
  backends/kwayland/waylandconfig.cpp

To: dvratil
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27517: Better handle authentication error

2020-02-20 Thread Aleix Pol Gonzalez
apol added a comment.


  Review without knowing very well the codebase.

INLINE COMMENTS

> accountmodel.cpp:181
>  {
> -if(!index.isValid()) {
> -return false;
> +qDebug() << "AccountModel::setDataWithResult";
> +if (!index.isValid()) {

Remove?

> accountmodel.h:64
> +AuthError
> +};
> +

Q_ENUM is useful for these, especially since you use them with qDebug.

> accountmodel.h:71
>  QVariant headerData(int section, Qt::Orientation orientation, int 
> role = Qt::DisplayRole) const override;
> -bool setData(const QModelIndex& index, const QVariant& value, int 
> role = Qt::EditRole) override;
> +AccountModel::Result setDataWithResult(const QModelIndex& index, 
> const QVariant& value, int role = Qt::EditRole);
>  bool removeRows(int row, int count, const QModelIndex& parent = 
> QModelIndex()) override;

I'm not very familiar with the code. Are you sure setData wasn't called 
elsewhere? The one you changed was an overriden virtual. In fact, if you're 
changing it, you can use more adequate API like you don't need to pass the 
Qt::EditRole.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D27517

To: meven, #plasma, davidedmundson, nicolasfella
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27525: Support Qt 5.14 on Android

2020-02-20 Thread Aleix Pol Gonzalez
apol added a comment.


  > Assets (QML files and icons) are no longer extracted into the file system,
  >  but now are available in the android_rcc_bundle QRC file.
  
  Meaning that we now need to change all applications to put the resources on 
the rcc file?
  
  The change upstream seems bonkers to me. Whatever, let's get this in. We'll 
possibly need to patch quite many apps for this... :(
  
  Also feels quite weird how the commit message is twice the same text but it 
never says why it's done.
  
  ¯\_(ツ)_/¯

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27525

To: vkrause
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein


Re: Policy Changes: Bugzilla statuses

2020-02-20 Thread Nate Graham

On 2/20/20 3:54 PM, David Edmundson wrote:

Would be nice if we could treat the VHI-priority bugs as release
blockers, and the HI-priority bugs as things to work on for the next
release.


There's no way we can fix those within 2 weeks.


Clarification: I meant that we could focus on HI-priority bugs for the 
next *major* release. Not the next bugfix release.


We don't have to make VHI-priority bugs release blockers per se, but 
rather treat them as "please fix this before the release or else users 
will complain a lot" type of bugs.


Nate


Re: Policy Changes: Bugzilla statuses

2020-02-20 Thread David Edmundson
On Thu, Feb 20, 2020 at 9:04 PM Nate Graham  wrote:
>
> On 2/20/20 10:50 AM, David Edmundson wrote:
> >  From the meeting
> >
> > - We are going to try and make use of the priority field in bugzilla
> > in addition to the commonly used severity.
> >
> > - Lets try to order our personal searches around it, not just always
> > searching by date.
> >
> > - VHI bugs will be discussed at the Monday meeting.
>
> I've created a saved search for VHI-priority Plasma bugs:
> https://bugs.kde.org/buglist.cgi?cmdtype=dorem_id=1718260=VHI-priority%20Plasma%20bugs=run_id=208174
>
Thanks

> And here's one for HI-priority Plasma bugs:
> https://bugs.kde.org/buglist.cgi?cmdtype=dorem_id=1718261=HI-priority%20Plasma%20bugs=run_id=208174
>
> Would be nice if we could treat the VHI-priority bugs as release
> blockers, and the HI-priority bugs as things to work on for the next
> release.

There's no way we can fix those within 2 weeks.

If we want them to have a release blocker policy as a goal of the tag,
we need to have group consensus from devs involved before marking it
as such.

David


D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

2020-02-20 Thread Lionel Chauvin
chauvin added inline comments.

INLINE COMMENTS

> chauvin wrote in configvalueprovider.cpp:50
> I observed a different behavior with ~/.gtkrc-2.0 (libgtk version 2.62.1)
> There is perhaps a difference betwen gtk2 and gtk3

Sorry I missread the version of libgtk2.0 it is 2.24.32  (not 2.62.1)

It works with the following line in  ~/.gtkrc-2.0:

  gtk-font-name="Ubuntu, Light 11"



  gtk-font-name="Ubuntu Light Regular 11"

but it doesn't work with:

  gtk-font-name="Ubuntu Light, Regular 11"

So I assume it is a bug in gtk2 parser and the comma is not the problem

I am not sure but I think the parsing is done in this function:
https://github.com/GNOME/pango/blob/mainline/pango/fonts.c#L1265 


REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27532: [applets/notes] Rename to "Sticky Note"

2020-02-20 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The current name "Notes" is ambiguous and grammatically incorrect in various 
places due
  to being a plural noun rather than a singular noun.
  
  For example the string "Notes settings" is grammatically incorrect, and 
"Remove notes"
  is ambiguous as to which notes exactly will be removed.
  
  Just changing it to "Note" would fix the grammatical issue but preserve the 
ambiguity
  in a different way though. So this patch changes the name to "Sticky Note" 
which should
  be clear and grammatically correct everywhere.

TEST PLAN
  Before: F8116212: Before.png 
  
  After: F8116211: After.png 

REPOSITORY
  R114 Plasma Addons

BRANCH
  rename-to-sticky-note (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27532

AFFECTED FILES
  applets/notes/package/metadata.desktop

To: ngraham, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27261: [Folder view] Fix binding loop on width

2020-02-20 Thread George Vogiatzis
gvgeo added a comment.


  I logged with my main account and I get lots of
  

file:///code/kde/usr/share/plasma/plasmoids/org.kde.desktopcontainment/contents/ui/FolderItemDelegate.qml:306:17:
 QML Label: Binding loop detected for property "width"

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27261

To: ngraham, #plasma, davidedmundson
Cc: davidedmundson, gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D27481: Panel spacer that can center things

2020-02-20 Thread Nathaniel Graham
ngraham added a comment.


  That looks nice!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27481

To: mart, #plasma, #vdg
Cc: davidedmundson, davidre, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27522: Fix date-label size in vertical layout

2020-02-20 Thread Nathaniel Graham
ngraham added a comment.


  Well your patch doesn't regress anything for me, so if it fixes it for you, 
that's good.
  
  Still it might be good to have some clarity here so we understand what's 
going on! :p

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27522

To: carewolf, ndavis, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27522: Fix date-label size in vertical layout

2020-02-20 Thread Allan Sandfeld Jensen
carewolf added a comment.


  In my case the text was too small.
  
  I wonder how exactly Text.Fit works, if it just increases font-size for short 
format to fill width that could make it too big.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27522

To: carewolf, ndavis, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


Re: Policy Changes: Bugzilla statuses

2020-02-20 Thread Nate Graham

On 2/20/20 10:50 AM, David Edmundson wrote:

 From the meeting

- We are going to try and make use of the priority field in bugzilla
in addition to the commonly used severity.

- Lets try to order our personal searches around it, not just always
searching by date.

- VHI bugs will be discussed at the Monday meeting.


I've created a saved search for VHI-priority Plasma bugs: 
https://bugs.kde.org/buglist.cgi?cmdtype=dorem_id=1718260=VHI-priority%20Plasma%20bugs=run_id=208174


And here's one for HI-priority Plasma bugs: 
https://bugs.kde.org/buglist.cgi?cmdtype=dorem_id=1718261=HI-priority%20Plasma%20bugs=run_id=208174


Would be nice if we could treat the VHI-priority bugs as release 
blockers, and the HI-priority bugs as things to work on for the next 
release.


Nate


D27522: Fix date-label size in vertical layout

2020-02-20 Thread Nathaniel Graham
ngraham added a comment.


  Thanks for the patch! Looks like this doesn't fully fix the issue though. 
With "Short Date" I see the following: F8116070: Screenshot_20200220_140027.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27522

To: carewolf, ndavis, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27522: Fix date-label size in vertical layout

2020-02-20 Thread Nathaniel Graham
ngraham added a comment.


  (The bug I'm thinking of is https://bugs.kde.org/show_bug.cgi?id=417728)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27522

To: carewolf, ndavis, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

2020-02-20 Thread Lionel Chauvin
chauvin added inline comments.

INLINE COMMENTS

> gikari wrote in configvalueprovider.cpp:50
> Comma is important, if not the comma, the GTK would not be able to parse font 
> with spaces in name. Comma fixed that bug: 
> https://bugs.kde.org/show_bug.cgi?id=380980

I observed a different behavior with ~/.gtkrc-2.0 (libgtk version 2.62.1)
There is perhaps a difference betwen gtk2 and gtk3

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

2020-02-20 Thread Mikhail Zolotukhin
gikari added inline comments.

INLINE COMMENTS

> chauvin wrote in configvalueprovider.cpp:50
> I think
> 
>   QStringLiteral(", ")
> 
> should be replaced by a space (see my comment 
> )
> 
> however I don't know what will happen in ambigious cases such like:
> "DejaVu Sans" + " " + "Condensed Bold" + " " +"11"
> and
> "DejaVu Sans Condensed" + " " + "Bold" + " " +"11"

Comma is important, if not the comma, the GTK would not be able to parse font 
with spaces in name. Comma fixed that bug: 
https://bugs.kde.org/show_bug.cgi?id=380980

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27530: Use appropriate icon for unconfigured applets' "Configure..." buttons

2020-02-20 Thread Nathaniel Graham
ngraham created this revision.
ngraham added reviewers: Plasma, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  CCBUG: 412114

TEST PLAN
  F8116018: Screenshot_20200220_125515.png 

  
  (The icon size is too large by default but that's not a bug in this patch)

REPOSITORY
  R120 Plasma Workspace

BRANCH
  configure-button-icon (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D27530

AFFECTED FILES
  components/containmentlayoutmanager/qml/BasicAppletContainer.qml

To: ngraham, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27529: [applets/weather] Remove outdated extra configure button

2020-02-20 Thread Nathaniel Graham
ngraham added a comment.


  And see also D27530 

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27529

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27529: [applets/weather] Remove outdated extra configure button

2020-02-20 Thread Nathaniel Graham
ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Stable branch?

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27529

To: davidedmundson, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27380: [GTK Config] Construct font style by hand instead of relying on Qt function

2020-02-20 Thread Lionel Chauvin
chauvin added inline comments.

INLINE COMMENTS

> configvalueprovider.cpp:50
> +const QString fontStyle = fontStyleHelper(font);
> +return font.family() + QStringLiteral(", ") + fontStyle + ' ' + 
> QString::number(font.pointSize());
>  }

I think

  QStringLiteral(", ")

should be replaced by a space (see my comment 
)

however I don't know what will happen in ambigious cases such like:
"DejaVu Sans" + " " + "Condensed Bold" + " " +"11"
and
"DejaVu Sans Condensed" + " " + "Bold" + " " +"11"

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D27380

To: gikari, #plasma, ervin, bport, meven, davidedmundson
Cc: chauvin, davidre, davidedmundson, cfeck, ngraham, IlyaBizyaev, 
plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27529: [applets/weather] Remove outdated extra configure button

2020-02-20 Thread David Edmundson
davidedmundson updated this revision to Diff 76067.
davidedmundson added a comment.


  include comics

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27529?vs=76066=76067

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27529

AFFECTED FILES
  applets/comic/package/contents/ui/main.qml
  applets/weather/package/contents/ui/FullRepresentation.qml

To: davidedmundson, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27529: [applets/weather] Remove outdated extra configure button

2020-02-20 Thread Nathaniel Graham
ngraham added a comment.


  Comic strip widget is also affected. If you fix both in this patch, it will 
resolve 412114. :)

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27529

To: davidedmundson, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27529: [applets/weather] Remove outdated extra configure button

2020-02-20 Thread David Edmundson
davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  The containment seems to care for it correctly now
  
  Also the old code was wrong and used anchors on an item inside a layout

TEST PLAN
  New applet with no configuration
  Saw a configure button in the middle still (instead of two)
  Clicking it worked

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27529

AFFECTED FILES
  applets/weather/package/contents/ui/FullRepresentation.qml

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27189: Created a top area based on widgets/toparea.svg

2020-02-20 Thread Marco Martin
mart added inline comments.

INLINE COMMENTS

> ExpandedRepresentation.qml:48
> +fill: parent
> +leftMargin: -dialog.margins.left
> +topMargin: -dialog.margins.top

not in all places you will have access to a dialog. the magic correct values 
should come from the toparea margins itself done to go well with the 
correspoding background svg.

in the end, i would like to have this in a control... i kinda hope a standard 
toolBar control (will need some special casing when that style is running in 
plasma or an app in plasma mobile

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27189

To: niccolove, #vdg, #plasma, ngraham
Cc: mart, ngraham, ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra


Policy Changes: Bugzilla statuses

2020-02-20 Thread David Edmundson
>From the meeting

- We are going to try and make use of the priority field in bugzilla
in addition to the commonly used severity.

- Lets try to order our personal searches around it, not just always
searching by date.

- VHI bugs will be discussed at the Monday meeting.

- Let's also make use of the ASSIGNED status role when we have a patch
basically done or on review

David


Policy changes: Adjusting Freezes

2020-02-20 Thread David Edmundson
Notes from the plasma meeting:

Freeze proposal:
- Feature freeze 2 weeks before beta tagging (just before the
relevant frameworks tag). String freeze remains on beta day as before.
Branching remains on beta day as before.
- Effectively this is formalising the existing unwritten rule of
not merging big changes at the last minute.

After 5.19 we will review this and potentially make adjustments.


D27525: Support Qt 5.14 on Android

2020-02-20 Thread Volker Krause
vkrause created this revision.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
vkrause requested review of this revision.

REVISION SUMMARY
  Assets (QML files and icons) are no longer extracted into the file system,
  but now are available in the android_rcc_bundle QRC file.
  
  This is based on Francis' work mentioned in D26749 
, but slightly adjusted
  to also fix icon loading as well.

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27525

AFFECTED FILES
  src/kirigamiplugin.cpp
  src/kirigamiplugin.h

To: vkrause
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein


D27522: Fix date-label size in vertical layout

2020-02-20 Thread Allan Sandfeld Jensen
carewolf added a comment.


  It only affects vertical panels, it is in the vertical panel configuration.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27522

To: carewolf, ndavis, ngraham, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27522: Fix date-label size in vertical layout

2020-02-20 Thread Noah Davis
ndavis added a comment.


  Does this work well with vertical panels?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27522

To: carewolf, ndavis, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27522: Fix date-label size in vertical layout

2020-02-20 Thread Allan Sandfeld Jensen
carewolf updated this revision to Diff 76055.
carewolf added a comment.


  Fix the logic to what was probably originally meant.
  
  Elided is still disabled as it triggers too aggresively on narrow fits.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27522?vs=76054=76055

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27522

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml

To: carewolf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27522: Fix date-label size in vertical layout

2020-02-20 Thread Allan Sandfeld Jensen
carewolf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
carewolf requested review of this revision.

REVISION SUMMARY
  The text was smaller than than minimum configuration, and
  also smaller than the width allowed for.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27522

AFFECTED FILES
  applets/digital-clock/package/contents/ui/DigitalClock.qml

To: carewolf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D26986: WIP-NotWorking: Try to fix flicker of screen while locked and detaching screens

2020-02-20 Thread Tomaz Canabrava
tcanabrava updated this revision to Diff 76053.
tcanabrava added a comment.


  - Simplify function / remove desktopResized

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26986?vs=74565=76053

BRANCH
  wip_fix_screenlocker_detach_reattach

REVISION DETAIL
  https://phabricator.kde.org/D26986

AFFECTED FILES
  greeter/greeterapp.cpp
  greeter/greeterapp.h
  greeter/main.cpp

To: tcanabrava, graesslin, davidedmundson
Cc: zzag, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart


D27521: Various fixes to make autotests run and pass

2020-02-20 Thread Aleix Pol Gonzalez
apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  *facepalm*

REPOSITORY
  R169 Kirigami

BRANCH
  autotest_fixes

REVISION DETAIL
  https://phabricator.kde.org/D27521

To: ahiemstra, #kirigami, apol
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein


D26992: [SystemTray] Use unified data model everywhere

2020-02-20 Thread Konrad Materka
kmaterka added a comment.


  In D26992#614426 , @ngraham wrote:
  
  > UI looks good except for one thing: the changes to show a highlight effect 
on hover in the popup are unrelated and should be done in a separate patch 
(preferably in coordination with #VDG  
folks since we're moving towards the idea of using this in other places too).
  
  
  This change should not introduce any visual change but one: add transition 
(main.qml, line 170).
  I guess you are referring to HiddenItemsView.qml, are you? I had to change 
Column to ListView to support model so almost everything changed or moved. 
CurrentItemHighLight and PlasmaComponents.HighLight was there from the very 
beginning.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26992

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27515: Icon: fix rendering of image: urls on High DPI

2020-02-20 Thread Aleix Pol Gonzalez
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:2c4cc4816c04: Icon: fix rendering of image: urls on High 
DPI (authored by apol).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27515?vs=76034=76052

REVISION DETAIL
  https://phabricator.kde.org/D27515

AFFECTED FILES
  src/icon.cpp

To: apol, #plasma, #kirigami, mart, davidedmundson
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart, hein


D27515: Icon: fix rendering of image: urls on High DPI

2020-02-20 Thread David Edmundson
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.


  I was wrong.
  
  QQuickImageBase is the part that has the SVG check.
  
  This is going directly one level lower

REPOSITORY
  R169 Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27515

To: apol, #plasma, #kirigami, mart, davidedmundson
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart, hein


D27457: Move kcminit_startup and kded to plasma-session

2020-02-20 Thread Aleix Pol Gonzalez
apol added a comment.


  LGTM otherwise

INLINE COMMENTS

> startup.cpp:422
> +m_process->setArguments(args);
> +auto env = QProcessEnvironment::systemEnvironment();
> +env.insert(additionalEnv);

only do it `if (!additionalEnv.isEmpty())`

> startup.cpp:450
> +m_process->setArguments(args);
> +auto env = QProcessEnvironment::systemEnvironment();
> +env.insert(additionalEnv);

only do it if (!additionalEnv.isEmpty())

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27457

To: apol, #plasma, davidedmundson, fvogt
Cc: fvogt, lbeltrame, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27518: Only enable the "Help" button if khelpcenter is available

2020-02-20 Thread Aleix Pol Gonzalez
apol requested changes to this revision.
apol added a comment.
This revision now requires changes to proceed.


  If khelpcenter is not available, we do an openUrl that should show the 
documentation on your browser.

REPOSITORY
  R124 System Settings

REVISION DETAIL
  https://phabricator.kde.org/D27518

To: ahmadsamir, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27513: Kill Runner: Remove duplicate function calls and refactor

2020-02-20 Thread Aleix Pol Gonzalez
apol added a comment.


  Seems to me like there's 2 very different changes here, can you split in 2 
reviews?

INLINE COMMENTS

> CMakeLists.txt:20
> +set(krunner_kill_SRCS killrunner.cpp)
>  add_library(krunner_kill MODULE ${krunner_kill_SRCS})
>  target_link_libraries(krunner_kill

just pass it to add_library

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27513

To: alex, davidedmundson, ngraham, broulik, meven
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart


D27521: Various fixes to make autotests run and pass

2020-02-20 Thread Arjen Hiemstra
ahiemstra created this revision.
ahiemstra added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
ahiemstra requested review of this revision.

REVISION SUMMARY
  Apparently Kirigami's autotests have not run for a while. This
  patch fixes that and makes some other changes so the tests pass
  again and in the future it should be easier to add tests.
  
  Changes:
  
  - Move add_subdirectory(autotests) to a location where BUILD_TESTING is 
defined so we actually can add the dir.
  - Add each test QML file as a separate test so reports are generated per test 
and tests can be run individually.
  - Add an autotest to test creation and rendering of Icon.
  - Fix most of the existing tests by making sure the window they rely on 
actually gets shown.
  - Fix PageRow test by changing it to matching current behaviour of PageRow.

TEST PLAN
  With this, "make test" should work and pass.

REPOSITORY
  R169 Kirigami

BRANCH
  autotest_fixes

REVISION DETAIL
  https://phabricator.kde.org/D27521

AFFECTED FILES
  CMakeLists.txt
  autotests/CMakeLists.txt
  autotests/tst_icon.qml
  autotests/tst_keynavigation.qml
  autotests/tst_listskeynavigation.qml
  autotests/tst_pagerow.qml
  src/CMakeLists.txt

To: ahiemstra, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein


D27495: Remove unnecessary code and function calls

2020-02-20 Thread Alexander Lohnau
alex added a comment.


  Thanks for the feedback.
  
  The actionsForMatch method gets actually called very often, I debugged this 
by adding `qWarning() << match.text();`  as a debug statement in the method.
  
  But I guess that I can keep the changes.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  shellrunner_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D27495

To: alex, davidedmundson, ngraham, broulik, meven, #plasma
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D25961: [WIP] Switch the Attica KDE plugin to use KAccounts

2020-02-20 Thread Dan Leinir Turthra Jensen
leinir updated this revision to Diff 76049.
leinir added a comment.


  Fair bit of work gone on here, but in short, given a patch which handles the
  OpenID ID token in the OAuth2 requests in signon-plugin-oauth2, we are now
  able to construct a bearer-authenticated request and whatnot. There is more
  work to be done, but it seems like things are happening now! Progress.
  
  The merge request for the signon-plugin-oauth2 patch can be found at:
  https://gitlab.com/accounts-sso/signon-plugin-oauth2/-/merge_requests/25
  
  - Add the provider and service files (these use temp client data for now)
  - Actually install the service and provider files
  - Add functionality to open the accounts kcm on saveCredentials calls
  - Actually make the service locator work (need to query for the right thing)
  - Add the SignOn OAuth plugin as a runtime dependency
  - Minor cleanup for attica_kde cmakelists
  - The opendesktop provider file is... not google
  - Fetch the access token (actually ID token) from AccountsManager via 
KAccounts

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D25961?vs=74208=76049

BRANCH
  switch-attica-plugin-to-kaccounts (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D25961

AFFECTED FILES
  CMakeLists.txt
  attica-kde/kdeplugin/CMakeLists.txt
  attica-kde/kdeplugin/kdeplatformdependent.cpp
  attica-kde/kdeplugin/kdeplatformdependent.h
  attica-kde/kdeplugin/opendesktop-rating.service
  attica-kde/kdeplugin/opendesktop.provider

To: leinir
Cc: zachus, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27518: Only enable the "Help" button if khelpcenter is available

2020-02-20 Thread Ahmad Samir
ahmadsamir created this revision.
ahmadsamir added a reviewer: Plasma.
Herald added a project: Plasma.
ahmadsamir requested review of this revision.

REVISION SUMMARY
  Use a static const bool to check if khelpcenter is available on the
  system, so as not to check every time a module is opened.
  
  BUG: 400602

TEST PLAN
  - make sure khelpcenter is not installed and open systemsettings
  - navigate to any module (one that has Help visible, e.g. Fonts), "Help" 
button is disabled
  - install khelpcenter and restart systemsettings, the "Help" button should be 
enabled

REPOSITORY
  R124 System Settings

BRANCH
  l-khelp (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27518

AFFECTED FILES
  core/ModuleView.cpp

To: ahmadsamir, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27457: Move kcminit_startup and kded to plasma-session

2020-02-20 Thread David Edmundson
davidedmundson updated this revision to Diff 76045.
davidedmundson added a comment.


  fixup diff

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27457?vs=76044=76045

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27457

AFFECTED FILES
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h
  startkde/startplasma-waylandsession.cpp
  startkde/startplasma-x11.cpp
  startkde/startplasma.cpp

To: apol, #plasma, davidedmundson, fvogt
Cc: fvogt, lbeltrame, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27457: Move kcminit_startup and kded to plasma-session

2020-02-20 Thread David Edmundson
davidedmundson updated this revision to Diff 76044.
davidedmundson added a comment.


  only pass in adjusted env

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27457?vs=75908=76044

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27457

AFFECTED FILES
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h

To: apol, #plasma, davidedmundson, fvogt
Cc: fvogt, lbeltrame, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart


D27495: Remove unnecessary code and function calls

2020-02-20 Thread David Edmundson
davidedmundson added a comment.


  Cleanup is good.
  
  > Futhermore the match icon and the list of actions can be reused.
  
  I don't think these changes really bring anything.
  Icon's are cached at the layer beneath (with a proper QCache with expunging) 
and actionsForMatch is called so rarely that doing:
  
return actions().values();
  
  Will be just as performant in practical terms.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  shellrunner_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D27495

To: alex, davidedmundson, ngraham, broulik, meven, #plasma
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27505: Do not crash when icon's width or height is 0

2020-02-20 Thread Arjen Hiemstra
This revision was automatically updated to reflect the committed changes.
Closed by commit R169:fcae16b30b06: Do not crash when icons width or 
height is 0 (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27505?vs=76002=76043

REVISION DETAIL
  https://phabricator.kde.org/D27505

AFFECTED FILES
  src/icon.cpp

To: ahiemstra, #kirigami, davidedmundson
Cc: ngraham, davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, 
dkardarakos, apol, ahiemstra, mart, hein


D27481: Panel spacer that can center things

2020-02-20 Thread Marco Martin
mart added a comment.


  In D27481#614250 , @davidre wrote:
  
  > In D27481#614167 , @davidre 
wrote:
  >
  > > I think the deisgn og the spacer could be better in edit mode to clearly 
mark it as a spacer but that can be done in the future if desired.
  >
  >
  > An idea could be to display something similiar to the icon on the "Add 
spacer" button on then or an arrow on each side
  
  
  yeah, something along the lines (either one of those different two)
  F8114744: image.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27481

To: mart, #plasma, #vdg
Cc: davidedmundson, davidre, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27515: Icon: fix rendering of image: urls on High DPI

2020-02-20 Thread David Edmundson
davidedmundson added a comment.


  > QQuickImageProvider wants the requestedSize to be accounting for the dpi 
scaling.
  
  For stupid reasons, that isn't the case if the path is an SVG.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27515

To: apol, #plasma, #kirigami, mart
Cc: davidedmundson, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ngraham, apol, ahiemstra, mart, hein


D27481: Panel spacer that can center things

2020-02-20 Thread Marco Martin
mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in panelconfigview.cpp:115
> why is this a script?

so, i need to add the second spacer at first position rather than the last.
I don't think i can do this without a script, as i need to access  the 
qquickitem to actually set a position (well, i could by accessing the graphics 
object property,directly, like the script implementation is doing, but it would 
be uglier

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27481

To: mart, #plasma, #vdg
Cc: davidedmundson, davidre, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27481: Panel spacer that can center things

2020-02-20 Thread David Edmundson
davidedmundson added inline comments.

INLINE COMMENTS

> panelconfigview.cpp:115
> +// this to trigger the panel centering mode of the spacer in a slightly 
> more discoverable way
> +c->evaluateScript(QStringLiteral("panel = panelById(") + 
> QString::number(m_containment->id()) 
> ++ QStringLiteral(");"

why is this a script?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27481

To: mart, #plasma, #vdg
Cc: davidedmundson, davidre, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27481: Panel spacer that can center things

2020-02-20 Thread Marco Martin
mart added a comment.


  In D27481#614250 , @davidre wrote:
  
  > In D27481#614167 , @davidre 
wrote:
  >
  > > I think the deisgn og the spacer could be better in edit mode to clearly 
mark it as a spacer but that can be done in the future if desired.
  >
  >
  > An idea could be to display something similiar to the icon on the "Add 
spacer" button on then or an arrow on each side
  
  
  yeah, i was planning on something quite simple, like H looking
  anyways, the spacer should probably become a Loader and have all the edit 
mode graphics loaded only then (otherwise, empty loader)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27481

To: mart, #plasma, #vdg
Cc: davidre, broulik, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart


D27517: Better handle authentication error

2020-02-20 Thread Méven Car
meven created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  BUG: 417882
  
  Not tested yet !

REPOSITORY
  R128 User Manager

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27517

AFFECTED FILES
  src/accountinfo.cpp
  src/lib/accountmodel.cpp
  src/lib/accountmodel.h

To: meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27480: Solid-device-automounter/kcm: Get rid of singleton for AutomounterSettings

2020-02-20 Thread Benjamin Port
bport accepted this revision.
bport added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> DeviceAutomounter.cpp:39
>  DeviceAutomounter::DeviceAutomounter(QObject *parent, const QVariantList 
> )
> -: KDEDModule(parent)
> +: KDEDModule(parent), m_settings(new AutomounterSettings(this))
>  {

m_settings need to go to the next line

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D27127

REVISION DETAIL
  https://phabricator.kde.org/D27480

To: meven, ervin, crossi, bport, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart


D27495: Remove unnecessary code and function calls

2020-02-20 Thread Méven Car
meven accepted this revision.
meven added a comment.
This revision is now accepted and ready to land.


  Seems good to me, please give time to other reviewers.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  shellrunner_cleanup

REVISION DETAIL
  https://phabricator.kde.org/D27495

To: alex, davidedmundson, ngraham, broulik, meven, #plasma
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart