D28211: [applets/systemtray] Make Pin button a bit larger

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Pin button in the System Tray expanded view is very small. This has always felt

D28167: packagekit: Fix checking of APT::Periodic::Update-Package-Lists

apol added a comment. Do you want me to land the change? REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D28167 To: eliac, #discover_software_store, apol, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, semareit, jraleigh,

D28066: Remove the STATIC_LIBRARY option to fix static builds

bartoc updated this revision to Diff 78262. bartoc added a comment. Made setting STATIC_LIBRARY a fatal error. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28066?vs=77694=78262 REVISION DETAIL https://phabricator.kde.org/D28066 AFFECTED FILES CMakeLists.txt

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

apol added a comment. If you ask me, this patch does many things: - fixes an issue - changes coding style - does some code bits a bit more differently. It's hard to review for me, I hope someone else more familiar with the codebase can. INLINE COMMENTS >

D28194: [WIP] Fix loading button icons from qrc

apol added a comment. Fixing QIcon would make sense but I'd say getting this in is not the worst thing either. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D28194 To: nicolasfella, #plasma, mart Cc: apol, plasma-devel, Orage, LeGast00n,

D28200: Enable wrapping of error messages which use KMessageWidget

ngraham added a comment. In D28200#632622 , @davidedmundson wrote: > > I wonder if it makes sense to set this on the widget itself, as a sensible default. > > No. > > Not because it's a better or worse default, but because making a

D28200: Enable wrapping of error messages which use KMessageWidget

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > I wonder if it makes sense to set this on the widget itself, as a sensible default. No. Not because it's a better or worse default, but because making a

D28208: Move sni icon handling logic from data engine to applet

kmaterka added inline comments. INLINE COMMENTS > StatusNotifierItem.qml:58 > } > +// IconItem.overlays only supports names so we need a second item for > the overlay, using the same > +// positioning that KIconLoader::drawOverlays uses that IconItem uses > internally Should

D28200: Enable wrapping of error messages which use KMessageWidget

ngraham added reviewers: Plasma, Frameworks. ngraham added a comment. Thanks for the patch! I wonder if it makes sense to set this on the widget itself, as a sensible default. You're probably going to want to word-wrap more often than you aren't. REPOSITORY R119 Plasma Desktop REVISION

D27783: Add new Account portal

ngraham added a comment. How can I test this? REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop REVISION DETAIL https://phabricator.kde.org/D27783 To: jgrulich, #plasma, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D28209: [applets/notes] Actually hide button row when it's not visible

ngraham created this revision. ngraham added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Currently the row's opacity is changed from 0% to 100% depending on focus state, but it

D27098: Bugfix: Konsole does not launch, optimize and simplify runner

alex added a comment. Ping :-) REPOSITORY R114 Plasma Addons BRANCH konsole_bugfix (branched from master) REVISION DETAIL https://phabricator.kde.org/D27098 To: alex, davidedmundson, ngraham, #plasma, #konsole, tcanabrava, hindenburg Cc: plasma-devel, Orage, LeGast00n,

D27495: Remove unnecessary code and function calls

This revision was automatically updated to reflect the committed changes. Closed by commit R120:86fd0f2f7176: Remove unnecessary code and function calls (authored by alex). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27495?vs=76009=78257 REVISION

Re: Drag and drop to system tray

"Also, since most System Tray icons are applets which hardly ever handle any files." You forgot about applications like Telegram, Skype, etc. These applications indeed accept files for sending. Currently if I want to send a file via drag and drop I have to open the window (e.g. Telegram) first

D28208: Move sni icon handling logic from data engine to applet

davidre added inline comments. INLINE COMMENTS > StatusNotifierItem.qml:84 > +} > +return 64; > +} Good to know! That was a straight copy from https://cgit.kde.org/kiconthemes.git/tree/src/kiconloader.cpp#n478 :D I'm sure we can find better sizing though, I

D28208: Move sni icon handling logic from data engine to applet

ngraham added inline comments. INLINE COMMENTS > StatusNotifierItem.qml:84 > +} > +return 64; > +} Most of these numbers correspond to standard icon sizes (e.g. `units.iconSize.smallMedium` == 22); maybe use those where possible > StatusNotifierItem.qml:90 > +

D26738: Launch plugin with argument, change signals

This revision was automatically updated to reflect the committed changes. Closed by commit R119:04e60d7e65b6: Launch plugin with argument, change signals (authored by alex). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26738?vs=73814=78254 REVISION

D28208: Move sni icon handling logic from data engine to applet

davidre added a comment. For now I tried to replicate `KIconLoader::drawOverlays` that is used in IconItem but that results in very small overlays. Because of this I added #vdg for opinions on better sizing. REPOSITORY R120 Plasma Workspace REVISION

D28208: Move sni icon handling logic from data engine to applet

davidre created this revision. davidre added reviewers: kmaterka, broulik, mart, Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidre requested review of this revision. REVISION SUMMARY The engine does complicated logig in order to provide a pre rendered

Re: Drag and drop to system tray

Hi, I think Martin means a behavior similar to the task manager where dragging a file over a window and waiting a little will raise that window so you can drag that file into the corresponding window. There's no plans to implement this and I personally think apps don't belong in System Tray

Re: Drag and drop to system tray

When you say system tray, what specifically are you referring to? There are definitely no plans to support dropping files onto the org.kde.plasma.systemtray containment.

Drag and drop to system tray

Hi, are there any plans to implement drap and drop support to system tray? So that it is possible to drag any file to an icon in the system tray, then the window of the corresponding app opens and then the file can be dropped in the right destination. Best regards, Martin

Re: CI talk (Was: re: Manner in which kde-gtk-config development is conducted)

El diumenge, 22 de març de 2020, a les 16:12:04 CET, Ben Cooksley va escriure: > On Mon, Mar 23, 2020 at 12:49 AM Albert Astals Cid wrote: > > > > El diumenge, 22 de març de 2020, a les 3:19:57 CET, Ben Cooksley va > > escriure: > > > Note however that images based upon Fedora or anything that

D28115: feat(kded): add a dbus method to lock current rotation

romangg added a comment. In D28115#632489 , @davidedmundson wrote: > How does mobile retrieve the current lockAutoRotate value? It could read it from the config file. But it would be better to add another dbus method for that.

D28115: feat(kded): add a dbus method to lock current rotation

davidedmundson added a comment. How does mobile retrieve the current lockAutoRotate value? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D28115 To: bshah, romangg Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus,

D28057: Fix/Allow folderview popup mode icon and list icon size

pereira.alex updated this revision to Diff 78238. pereira.alex added a comment. Fixing bug on changing icon size between list/grid view So with this commit, I fixed the bug that was happening explained in previous commit. Actually, this was what was happening that cause the opening of

D28115: feat(kded): add a dbus method to lock current rotation

This revision was automatically updated to reflect the committed changes. Closed by commit R104:7e98fd7c1b29: feat(kded): add a dbus method to lock current rotation (authored by bshah). REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28115?vs=78233=78234

D28115: feat(kded): add a dbus method to lock current rotation

bshah updated this revision to Diff 78233. bshah added a comment. whitespace REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28115?vs=78232=78233 BRANCH arcpatch-D28115 REVISION DETAIL https://phabricator.kde.org/D28115 AFFECTED FILES

D28115: feat(kded): add a dbus method to lock current rotation

romangg accepted this revision. romangg added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > config.cpp:103 > +} > +if(m_control->getAutoRotate(output) != value) { > +m_control->setAutoRotate(output, value); On push change to: `if

D28115: feat(kded): add a dbus method to lock current rotation

bshah updated this revision to Diff 78232. bshah added a comment. - rename methods to AutoRotate - write control file after change, thanks @romangg for suggestion REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28115?vs=77896=78232 BRANCH

Re: CI talk (Was: re: Manner in which kde-gtk-config development is conducted)

On Mon, Mar 23, 2020 at 12:41 AM Johan Ouwerkerk wrote: > > On Sun, Mar 22, 2020 at 3:20 AM Ben Cooksley wrote: > > > > We already do have a repository of artifacts :) > > You can find the public view of this at > > https://build-artifacts.kde.org/production/ > > > > > > > We already use Virtual

Re: CI talk (Was: re: Manner in which kde-gtk-config development is conducted)

On Mon, Mar 23, 2020 at 12:49 AM Albert Astals Cid wrote: > > El diumenge, 22 de març de 2020, a les 3:19:57 CET, Ben Cooksley va escriure: > > Note however that images based upon Fedora or anything that shares > > it's lineage (including CentOS and it's derivates) is strictly > > prohibited and

D28115: feat(kded): add a dbus method to lock current rotation

romangg requested changes to this revision. romangg added a comment. This revision now requires changes to proceed. Please call the functions `AutoRotate`. I failed to name it consistently in the code until now but let's go with AutoRotate from now on (and I will try to rename it where I

CI mail filtering (was Re: Manner in which kde-gtk-config development is conducted)

On 21/03/2020 22:38, Ben Cooksley wrote: On Sun, Mar 22, 2020 at 3:08 AM David Edmundson wrote: You're absolutely right that mistakes were made and have reason to be frustrated. kde-gtk-config is now maintained by new developers. Plasma has a new influx of new people which is good to see and

D28200: Enable wrapping of error messages which use KMessageWidget

develoot created this revision. develoot added a reviewer: VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. develoot requested review of this revision. REVISION SUMMARY Error messages should be shown to users no matter how much long it is. REPOSITORY R119 Plasma

Re: CI talk (Was: re: Manner in which kde-gtk-config development is conducted)

El diumenge, 22 de març de 2020, a les 3:19:57 CET, Ben Cooksley va escriure: > Note however that images based upon Fedora or anything that shares > it's lineage (including CentOS and it's derivates) is strictly > prohibited and won't be accepted for inclusion. I still find this highly annoying

Re: CI talk (Was: re: Manner in which kde-gtk-config development is conducted)

On Sun, Mar 22, 2020 at 3:20 AM Ben Cooksley wrote: > > We already do have a repository of artifacts :) > You can find the public view of this at > https://build-artifacts.kde.org/production/ > > > We already use Virtual Machines for both FreeBSD and Windows. > > The main problem here is that

D27669: [kstyle] Tools area

davidre added inline comments. INLINE COMMENTS > breezehelper.cpp:90 > +_decorationConfig->load(); > +if (qApp && qApp->property("KDE_COLOR_SCHEME_PATH").isValid()) { > +const auto path = > qApp->property("KDE_COLOR_SCHEME_PATH").toString(); I don't think you need

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

alex updated this revision to Diff 78205. alex added a comment. Add check if profilePath is empty REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28196?vs=78204=78205 BRANCH bookmarks_firefox_bugfix (branched from master) REVISION DETAIL

D28196: BUGFIX BookmarksRunner: Fix wrong default profile extraction, remove caching

alex created this revision. alex added reviewers: bruns, z3ntu, apol, broulik, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY Before this patch the path to the default profile database was once