[kio-extras] [Bug 366488] Too many sftp.so processes, not closing

https://bugs.kde.org/show_bug.cgi?id=366488 Bug Janitor Service changed: What|Removed |Added Status|NEEDSINFO |RESOLVED

[kio-extras] [Bug 345440] SFTP: Internal Error on deleting a folder without having permissions and wich is also mounted

https://bugs.kde.org/show_bug.cgi?id=345440 Bug Janitor Service changed: What|Removed |Added Resolution|WAITINGFORINFO |WORKSFORME Status|NEEDSINFO

[kio-extras] [Bug 376301] sftp.so not closing connections when ProxyCommand is configured

https://bugs.kde.org/show_bug.cgi?id=376301 Bug Janitor Service changed: What|Removed |Added Resolution|WAITINGFORINFO |WORKSFORME Status|NEEDSINFO

D28154: Add users KCM

cblack updated this revision to Diff 79184. cblack marked 3 inline comments as done. cblack added a comment. Address some feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=79181=79184 BRANCH arcpatch-D28154 REVISION DETAIL

D28154: Add users KCM

ngraham added inline comments. INLINE COMMENTS > ChangePassword.qml:65 > + > +onAccepted: !passwordWarning.visible && verifyField.text && > passwordField.text && passButton.apply() > + hitting the return key on this field should effectively click the Create button >

D27669: [kstyle] Tools area

ngraham added a comment. In D27669#640473 , @cblack wrote: > In D27669#639569 , @ngraham wrote: > > > Anyway I worked around that in D27669 , and I guess it's

D27669: [kstyle] Tools area

cblack added a comment. In D27669#639569 , @ngraham wrote: > Anyway I worked around that in D27669 , and I guess it's not really a huge deal for toolbar icons. > > One thing I notice is that the bottom

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.14 - Build # 19 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.14/19/ Project: kf5-qt5 SUSEQt5.14 Date of build: Fri, 03 Apr 2020 00:35:40 + Build duration: 17 min and counting JUnit Tests Name: (root) Failed: 0

D28154: Add users KCM

cblack updated this revision to Diff 79181. cblack marked 3 inline comments as done. cblack added a comment. Use better model roles REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=79180=79181 BRANCH arcpatch-D28154 REVISION DETAIL

D28154: Add users KCM

cblack updated this revision to Diff 79180. cblack marked an inline comment as done. cblack added a comment. Address feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=79173=79180 BRANCH arcpatch-D28154 REVISION DETAIL

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.14 - Build # 18 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.14/18/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 02 Apr 2020 23:17:09 + Build duration: 1 min 23 sec and counting CONSOLE OUTPUT [...truncated 1907

D28461: In sidebar mode show if a module is in default state or not

The-Feren-OS-Dev added a comment. How about instead of a blue dot there's instead an option in the SySe hamburger button menu to use search to filter out any settings pages where settings haven't been changed, meaning that only settings with changes made to them are then listed in the

D28526: [notifications] Hide close/configure buttons on mobile

broulik added a comment. I think we also want to stop the animation/circle thing, too? Maybe shove all of it in a loader? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28526 To: nicolasfella, #plasma, #plasma:_mobile Cc: broulik, plasma-devel, Orage,

D28526: [notifications] Hide close/configure buttons on mobile

nicolasfella created this revision. nicolasfella added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY The close button is not really needed since the notification can just be swiped

D28154: Add users KCM

cblack updated this revision to Diff 79173. cblack added a comment. Use a KJob to apply user configuration REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=79167=79173 BRANCH arcpatch-D28154 REVISION DETAIL

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

filipf added a comment. In D25728#576703 , @ngraham wrote: > Maybe what we should do is change the titlebar separator color in Breeze to be a pleasant dark gray like in the screenshot in @flipwise's latest comment instead of a garish blue, turn

D28154: Add users KCM

broulik added inline comments. INLINE COMMENTS > user.cpp:179 > +{ > +QtConcurrent::run([=]() { > +m_dbusIface->SetUserName(mName).waitForFinished(); No, just no. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg,

D28154: Add users KCM

cblack updated this revision to Diff 79167. cblack added a comment. Run apply in a separate thread REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=79165=79167 BRANCH arcpatch-D28154 REVISION DETAIL https://phabricator.kde.org/D28154

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

Codezela added a comment. In D25728#572044 , @filipf wrote: > In D25728#572043 , @anthonyfieroni wrote: > > > So with the patch is it drawn when it is ticked in window decoration? > > > Yes.

D28154: Add users KCM

cblack updated this revision to Diff 79165. cblack marked 2 inline comments as done. cblack added a comment. Address feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=79138=79165 BRANCH arcpatch-D28154 REVISION DETAIL

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

ngraham added a comment. With D27669 , it's probably time to revisit drawing this separator at all. We should probably be relying on the widget and/or decoration style to do it. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28236: [applet/taskmanager] Remove unnecessary icon size values set on PC3 toolbuttons

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R119:122a7ded1291: [applet/taskmanager] Remove unnecessary icon size values set on PC3 toolbuttons (authored by ngraham).

D28519: [KMenuEdit] Port QRegExp to QRegularExpression

apol accepted this revision. apol added a comment. This revision is now accepted and ready to land. It could make sense for you to test that the names are properly parsed besides just making sure it starts. REPOSITORY R103 KMenu Editor BRANCH l-QRE (branched from master) REVISION

D28517: Send notification when screencasting fails

broulik added inline comments. INLINE COMMENTS > screencaststream.cpp:372 > +const auto emitFailureNotification = [](const QString ) { > +KNotification *notification = new > KNotification(QStringLiteral("notification"), KNotification::CloseOnTimeout | >

D27100: [GTK Config] Parameterise GTK config editing

This revision was automatically updated to reflect the committed changes. Closed by commit R99:0580098ab4cd: [GTK Config] Parameterise GTK config editing (authored by gikari). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE

D28467: Converted to Page with a PlasmoidHeading in the heading

niccolove updated this revision to Diff 79155. niccolove added a comment. Fixed layout REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28467?vs=79000=79155 BRANCH master REVISION DETAIL https://phabricator.kde.org/D28467 AFFECTED FILES

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5a5e0bc0880b: [kcms/baloo] Refine UI and prepare for more indexing options in the future (authored by ngraham). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D28519: [KMenuEdit] Port QRegExp to QRegularExpression

ahmadsamir created this revision. ahmadsamir added reviewers: Plasma, davidedmundson, mlaurent. Herald added a project: Plasma. ahmadsamir requested review of this revision. TEST PLAN The code compiles and kmenuedit still starts as expected REPOSITORY R103 KMenu Editor BRANCH l-QRE

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ndavis accepted this revision. ndavis added a comment. This revision is now accepted and ready to land. In D28280#640239 , @ngraham wrote: > Currently there are only two choices, yes. However as mentioned before, one of the goals of this patch

D27979: Add top area to notifications

niccolove added a comment. I will add the padding in the todo list :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27979 To: niccolove, broulik, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2,

D27979: Add top area to notifications

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ca7a9bcbbc1f: Add top area to notifications (authored by niccolove). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27979?vs=79065=79149 REVISION DETAIL

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ngraham added a comment. Currently there are only two choices, yes. However as mentioned before, one of the goals of this patch is to future-proof the UI for the addition of more options, which is coming soon. REPOSITORY R119 Plasma Desktop REVISION DETAIL

D28280: [kcms/baloo] Refine UI and prepare for more indexing options in the future

ndavis added a comment. Why isn't a checkbox better than a combobox here? Aren't there only 2 opposite choices here? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28280 To: ngraham, #vdg, #baloo, #plasma Cc: ndavis, bruns, plasma-devel, Orage, LeGast00n,

D28517: Send notification when screencasting fails

This revision was automatically updated to reflect the committed changes. Closed by commit R838:d6d8e31ba270: Send notification when screencasting fails (authored by cblack). REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE

D28517: Send notification when screencasting fails

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Fair enough. REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop BRANCH cblack/screencast-notify-error (branched from master) REVISION DETAIL

D28517: Send notification when screencasting fails

cblack updated this revision to Diff 79145. cblack added a comment. Fix i18n call REPOSITORY R838 Flatpak Support: KDE Portal for XDG Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28517?vs=79142=79145 BRANCH cblack/screencast-notify-error (branched from master)

D28517: Send notification when screencasting fails

apol added inline comments. INLINE COMMENTS > ngraham wrote in screencaststream.cpp:385 > Are there more user-friendly and actionable strings we could for these error > messages? I have no idea what this means specifically and would read it as > "there was some gobbeldygook error." While I

D28517: Send notification when screencasting fails

ngraham added inline comments. INLINE COMMENTS > screencaststream.cpp:374 > +notification->setTitle(i18n("Failed to start screencasting")); > +notification->setText(i18n("Error: %1").arg(body)); > +notification->setIconName(QStringLiteral("data-error")); `.arg` is

D28154: Add users KCM

cblack added a comment. In D28154#640206 , @davidedmundson wrote: > > Drop group stubs; there will be bad UX because two different polkit actions (and thus two dialogs backtoback) would be needed for apply with groups > > Don't rule out the

D28154: Add users KCM

davidedmundson added a comment. > Drop group stubs; there will be bad UX because two different polkit actions (and thus two dialogs backtoback) would be needed for apply with groups Don't rule out the obvious other option there - changing accountsservice. It already has all the code,

D28517: Send notification when screencasting fails

cblack created this revision. cblack added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY A notification is sent when something goes wrong setting up screencasting. TEST PLAN

D27979: Add top area to notifications

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. The padding looks much better with default font settings: F8211692: Screenshot_20200402_090740.png I'm using 11pt Ubuntu though, not 10pt Noto

D28154: Add users KCM

ngraham added a comment. So it does. My bad, sorry. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage,

D27576: Kill Runner: Move config keys to new file

davidedmundson added a comment. > Quick question: I just realized that I committed the second commit with a wrong username (this will get rejected when I try to land the patch). git config user.name then git commit --amend --author "Your Name " REPOSITORY R120 Plasma

D27980: make opengl module support multiple dri devices

apol added inline comments. INLINE COMMENTS > opengl.cpp:281 > +if (ReadPipe("sysctl -n hw.dri.0.name", pci_info)) { > +DriInfo info{}; > +info.module = pci_info[0].mid(0, pci_info[0].indexOf(0x20)); the {} isn't necessary here. > opengl.cpp:290 > > -static bool

D28154: Add users KCM

broulik added a comment. That gallery comes from user manager right now, doesnt it? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To: cblack, #plasma, #vdg, ngraham Cc: crossi, The-Feren-OS-Dev, davidedmundson, broulik, filipf, ngraham, nicolasfella,

D28154: Add users KCM

ngraham added a comment. Wait, why are you adding the Konqis to this diff? You should use whatever framework provides the gallery instead of re-implementing all of that and duplicating the assets. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D28154 To:

D28514: Bumped minimum Qt5 version required to build.

This revision was automatically updated to reflect the committed changes. Closed by commit R122:5602920aeb85: bump to require Qt 5.14 (authored by jriddell). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28514?vs=79134=79140 REVISION DETAIL

D27980: make opengl module support multiple dri devices

sitter added inline comments. INLINE COMMENTS > apol wrote in opengl.cpp:281 > Go for it. Already is in latest diff ;) REPOSITORY R102 KInfoCenter REVISION DETAIL https://phabricator.kde.org/D27980 To: sitter Cc: pino, zzag, apol, adridg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev,

D28496: Hotfix for D28468 to fix broken variable refs

masonm added a comment. I am going to commit some unit tests for this so I don't miss something else :) REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28496 To: masonm, #kirigami, mart Cc: mart, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham,

D25549: [kcms/keyboard] Port away from KToolInvokation

This revision was automatically updated to reflect the committed changes. Closed by commit R119:13358835296e: [kcms/keyboard] Port away from KToolInvokation (authored by nicolasfella). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25549?vs=70360=79139

D28514: Bumped minimum Qt5 version required to build.

shenstoneporter added a comment. In D28514#640139 , @jriddell wrote: > Looks good. It would be nicer to just bump them all. Glad to help, I just noticed that the changes made previously with the commit:

D28154: Add users KCM

cblack updated this revision to Diff 79138. cblack marked 7 inline comments as done. cblack added a comment. Address feedback REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28154?vs=79099=79138 BRANCH arcpatch-D28154 REVISION DETAIL

D28512: Port Konsole and Kate runners and dataengine away from KToolInvocation

broulik updated this revision to Diff 79137. broulik edited the test plan for this revision. broulik added a comment. - Use new constructor introduced in D28515 REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D27980: make opengl module support multiple dri devices

apol added inline comments. INLINE COMMENTS > sitter wrote in opengl.cpp:281 > As it turns out the /proc/dri stuff was supposedly removed here > https://github.com/torvalds/linux/commit/cb6458f97b53d7f73043206c18014b3ca63ac345 > making this code entirely irrelevant since kernel 3.12. > Any

D28514: Bumped minimum Qt5 version required to build.

jriddell added a comment. Looks good. It would be nicer to just bump them all. REPOSITORY R122 Powerdevil REVISION DETAIL https://phabricator.kde.org/D28514 To: shenstoneporter Cc: jriddell, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D28514: Bumped minimum Qt5 version required to build.

shenstoneporter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. shenstoneporter requested review of this revision. REPOSITORY R122 Powerdevil BRANCH bump-qt5-version (branched from master) REVISION DETAIL https://phabricator.kde.org/D28514

D28154: Add users KCM

crossi added inline comments. INLINE COMMENTS > kcm.cpp:73 > + > +void KCMUser::defaults() > +{ Not necessary to override if you don't add your specific implementatioin. > kcm.cpp:78 > + > +void KCMUser::load() > +{ same here > user.cpp:53 > +mName = value; > +nameChanged(value); >

D28512: Port Konsole and Kate runners and dataengine away from KToolInvocation

dfaure added a comment. > I kinda feel CommandLauncherJob should have a QString executable, QStringList args constructor so I don't have to escape things myself? Sounds good, excellent idea. This would simplify the code in many callers. Please add :) It still needs to support the

D27980: make opengl module support multiple dri devices

adridg added inline comments. INLINE COMMENTS > apol wrote in opengl.cpp:335 > Probably want to list them all on BSD too, right @adridg? Possibly. I don't have any machines with multiple cards, so I can't tell -- I'd have to ask Niclas about this. I don't know if it's possible for the

D28512: Port Konsole and Kate runners and dataengine away from KToolInvocation

broulik created this revision. broulik added reviewers: Plasma, dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Instead use `CommandLauncherJob`. Also set `desktopFileName` for nicer startup feedback

D28438: Add per-partition total and all partitions sensors

This revision was automatically updated to reflect the committed changes. Closed by commit R106:0fbf39bc37a7: Add per-partition total and all partitions sensors (authored by ahiemstra). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28438?vs=78903=79130

D25549: [kcms/keyboard] Port away from KToolInvokation

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. Changed my mind. This is a kcm, so having a startup notification for kcm wouldn't bring a lot. Also you're not going to have a different env between kcmshell5 and

D28509: RFC: [libnotificationmanager] introduce the notification watcher

broulik added inline comments. INLINE COMMENTS > org.freedesktop.Notifications.xml:55 > > + > + Please don't put that on the fdo service > notificationwatcher.cpp:45 > +); > +QDBusConnection::sessionBus().call(msg, QDBus::NoBlock); > +} Do we not want to check if that

D28509: RFC: [libnotificationmanager] introduce the notification watcher

bshah created this revision. bshah added reviewers: Plasma, broulik, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. bshah requested review of this revision. REVISION SUMMARY This allows one to subscribe to notifications from notification server.

D28491: Properly store the powerdown action

This revision was automatically updated to reflect the committed changes. Closed by commit R122:a9abb0cb7924: Properly store the powerdown action (authored by apol). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28491?vs=79077=79121 REVISION DETAIL

D28487: Upstream of the ksysguard based plasmoids

mart updated this revision to Diff 79120. mart added a comment. - remove changes in shell/ REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28487?vs=79058=79120 BRANCH mart/mewSystemMonitor REVISION DETAIL https://phabricator.kde.org/D28487

D27979: Add top area to notifications

niccolove added a comment. Weird, I do see a margin. Do you have any idea what could case this issue (us seeing different things)? I assumed that the margin was given by the qml Heading default topmargin F8211176: Screenshot_20200402_112236.png

Looking for GSoC 2020 mentor

Dear Plasma developers, I am a student who wants to participate in the Google Summer of Code 2020 program. Currrently, I have an idea of my own, so I want to discuss with a mentor to validate that my idea is worthy for the program. After discussing with valerie on the #kde-soc channel on

D28305: WIP: Systemd Startup

davidedmundson updated this revision to Diff 79106. davidedmundson added a comment. Add xembedsniproxy and gdbusmenuproxy REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28305?vs=78922=79106 BRANCH master REVISION DETAIL

D28497: Use non-const iterators

This revision was automatically updated to reflect the committed changes. Closed by commit R111:b5036ff7f1d3: Use non-const iterators (authored by mart). REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28497?vs=79101=79103 REVISION DETAIL

D28487: Upstream of the ksysguard based plasmoids

davidedmundson added inline comments. INLINE COMMENTS > applet.h:29 > > +#include "scriptengine.h" > Can we split all the changes in shell/* REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D28487 To: mart, #plasma Cc: davidedmundson, mmustac, ahiemstra,

D28497: Use non-const iterators

mart created this revision. mart added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY on some GCC (here 7.5.0) it complains when one tries to reassign an iterator that was obtained via

D28487: Upstream of the ksysguard based plasmoids

mart added a comment. In D28487#639563 , @ahiemstra wrote: > In D28487#639476 , @mart wrote: > > > should faces be still installed under .local/share/ksysguard/sensorapplet/ or under share/plasma?

D27576: Kill Runner: Move config keys to new file

alex added a comment. Quick question: I just realized that I committed the second commit with a wrong username (this will get rejected when I try to land the patch). What is the best way to solve this? REPOSITORY R120 Plasma Workspace BRANCH arcpatch-D27576 REVISION DETAIL

D28485: Move QMimeData registration back to where it belongs

This revision was automatically updated to reflect the committed changes. Closed by commit R112:92ecad19708d: Move QMimeData registration back to where it belongs (authored by broulik). REPOSITORY R112 Milou CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28485?vs=79056=79100

D28461: In sidebar mode show if a module is in default state or not

bport added a comment. Yes we will need to have a probe for each KCM, and I currently look to reuse this probe in the KCM that will split a bit more data and UI. Some KCM like pulseaudio one don't need that for example, because there is no default setup REPOSITORY R124 System Settings