D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

[Nathaniel Graham]

ngraham added reviewers: VDG, Plasma.
ngraham added a comment.


  I agree with the premise that 0.2 steps are much too coarse, and have 
periodically groused about this myself. However I wonder if 0.05 is too fine? A 
slider with 41 ticks is screaming out "you used the wrong control for this!" 
Perhaps it should be a spinbox instead, or it should just be wider so the 
tickmarks don't look so closely spaced. #VDG 
 people, opinions?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29365

To: kurmikon, #vdg, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

[Nathaniel Graham]

ngraham added a comment.


  5.19 hasn't branched yet, so code landed in master will still make it there.
  
  With this patch, I still see Media Player itself with a blank icon after 
opening Gwenview. Is that expected?
  
  F8282515: Screenshot_20200503_215149.png 


INLINE COMMENTS

> ItemLoader.qml:33
>  }
> +console.warn("ItemLoader: Illegal State! Cannot determine source!")
>  return ""

"Illegal" is one of those scary words we try not to use, even in console spew. 
Consider changing this to "Invalid."

F8282506: Screenshot_20200503_214934.png 

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29344

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik, apol, 
davidedmundson
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D25375: Start of the accessibility KCM

[Nathaniel Graham]

ngraham added a comment.


  Ping?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25375

To: tcanabrava, ngraham, ervin
Cc: broulik, cblack, ervin, ognarb, mart, ngraham, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

D29395: Refactor MediaController

[Tranter Madi]

trmdi added a comment.


  In D29395#662576 , @ngraham wrote:
  
  > Now the inner image has a greater top margin than bottom margin. Also, 
could the artist and album be allowed to become two-line strings before 
eliding, maybe? F8282138: Screenshot_20200503_202710.png 

  
  
  There seems to be lots of wasted space whereas the text is truncated ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29395

To: cblack, #plasma
Cc: trmdi, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29395: Refactor MediaController

[Carson Black]

cblack added a comment.


  In D29395#662576 , @ngraham wrote:
  
  > Now the inner image has a greater top margin than bottom margin. Also, 
could the artist and album be allowed to become two-line strings before 
eliding, maybe? F8282138: Screenshot_20200503_202710.png 

  
  
  ... what? This patch doesn't (or shouldn't) result in visual changes.
  
  I don't notice any visual changes on my system.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29395

To: cblack, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29395: Refactor MediaController

[Nathaniel Graham]

ngraham added a comment.


  Now the inner image has a greater top margin than bottom margin. Also, could 
the artist and album be allowed to become two-line strings before eliding, 
maybe? F8282138: Screenshot_20200503_202710.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29395

To: cblack, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf added a comment.


  The permissions are wrong if we do `sudo make install` (the photos folder 
ends up being root owned). But it doesn't show up with `make install` either. 
Will investigate more in the morning.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29395: Refactor MediaController

[Carson Black]

cblack created this revision.
cblack added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack requested review of this revision.

REVISION SUMMARY
  MediaController is refactored to:
  
  1. make the code easier to read and therefore more maintainable
  2. stop dumping errors like there's no tomorrow into the console

TEST PLAN
  Use, ensure no regressions are found.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cblack/refactor-mediacontroller (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29395

AFFECTED FILES
  applets/mediacontroller/contents/ui/ExpandedRepresentation.qml
  applets/mediacontroller/contents/ui/Media.qml
  applets/mediacontroller/contents/ui/main.qml
  applets/mediacontroller/contents/ui/qmldir

To: cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Nathaniel Graham]

ngraham added a comment.


  Love the images! Do they actually show up for you in the KCM though? They 
don't for me.

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf created this revision.
filipf added reviewers: VDG, ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  This patch adds 12 photographic avatars in order to finish work on T9910 
.
  
  Sylistically they are simple and with only a single topic in focus.
  
  Sizes are 512x512, the formats .png. They've tested with our circular avatar 
template and cropped to fit it well.

REPOSITORY
  R128 User Manager

BRANCH
  add-photo-avatars (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29394

AFFECTED FILES
  src/pics/photos/Basketball.png
  src/pics/photos/Brushes.png
  src/pics/photos/Car.png
  src/pics/photos/Cocktail.png
  src/pics/photos/HotAirBalloon.png
  src/pics/photos/Joystick.png
  src/pics/photos/Keyboard.png
  src/pics/photos/Leopard.png
  src/pics/photos/Parrot.png
  src/pics/photos/RubixCube.png
  src/pics/photos/Shuttle.png
  src/pics/photos/Sunflower.png

To: filipf, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29394: Add photographic user avatars

[Filip Fila]

filipf added a comment.


  Sources:
  
  Basketball: https://www.pexels.com/photo/basketball-net-2169302/ (Pexels 
licence)
  Brushes: https://www.pexels.com/photo/abstract-art-artist-artistic-262034/ 
(CC0 licence)
  Car: 
https://www.pexels.com/photo/action-asphalt-auto-racing-automobile-274974 (CC0 
licence)
  Cocktail: https://www.pexels.com/photo/sea-sky-beach-holiday-68672/ (CC0)
  HotAirBalloon: 
https://www.pexels.com/photo/hot-air-balloon-on-mid-air-above-rock-formation-2893960/
 (Pexels licence)
  Joystick: https://www.pexels.com/photo/game-controller-159204/ (CC0 licence)
  Keyboard: https://unsplash.com/photos/WzKPT0IuUrU (Unsplash licence)
  Leopard: https://unsplash.com/photos/wYy3rvvgjAU (Unsplash licence)
  Parrot: https://unsplash.com/photos/V9VDd-2s3aE (Unsplash licence)
  RubikCube: https://unsplash.com/photos/liMvhbUq4Xg (Unsplash licence)
  Sunflower: https://unsplash.com/photos/XtXdHH-Ib7c (Unsplash licence)
  Shuttle: https://www.pexels.com/photo/flight-sky-earth-space-2159/ (CC0 
licence)

REPOSITORY
  R128 User Manager

REVISION DETAIL
  https://phabricator.kde.org/D29394

To: filipf, #vdg, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

kwallet-pam >= 5.18.4 and ecryptfs homes

[Albert Astals Cid]

Remember to CC me, I'm not subscribed to the list

Sadly, a fix i made for Plasma 5.18.4 so that kwallet-pam reads/stores the salt 
file inside the encrypted home dir (if there is one) means that if you had used 
kwallet-pam < 5.18.4 and now use kwallet-pam the salt file is not found and 
your kwallet is not auto-opened on login as you wanted.

SOLUTION 1:
 * read the salt file in the "authenticate step" (encrypted home if there is 
one still not mounted), keep it in memory
 * Read file the file again in the "open_session step" (encrypted home if there 
is one is now mounted), if there is no salt file, write it with what we have in 
memory


Problem A) The "old" file is still there outside the unencrypted home, which is 
not optimal

Problem B) This doesn't help people that have already updated to 5.18.4, since 
those will have a new salt file already in place



Potential solution to A) Keep the file descriptor for the "salt file from 
authenticate step" and if we find we have to use that file, delete or empty 
that fd
This is assuming that fd to "now unexisting paths because a folder was mounted 
or" are still valid/usable


Potential solution to B) If opening the wallet failed and there was a different 
salt file in the authenticate step file try to use the contents of the old salt 
file to open the wallet, if that succeds show a long dialog with instructions 
of what they should do (i would rather not overwrite salt files just in case)


SOLUTION 2:
 * Ignore it and hope people will read my blog 
https://tsdgeos.blogspot.com/2020/05/kwallet-pam-5184-and-ecryptfs-homes.html 





Problem with SOLUTION 1 is that it adds lots of code in a relative "sensitive" 
piece of code like a pam module for for what it is a one time thing.
Problem with SOLUTION 2 is that it's not a solution :D


Opinions?


Cheers,
  Albert

Remember to CC me, I'm not subscribed to the list

D29393: Use player "poster" as album cover if available

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt, ognarb.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Media Sessions artwork takes precedence, if set.

TEST PLAN
  Not sure how useful that is. I've hardly found any page that actually uses 
this. They either start playing right away or have a custom start player thing.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D29393

AFFECTED FILES
  extension/content-script.js
  host/mprisplugin.cpp
  host/mprisplugin.h

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22700: Sync scaling DPI from Plasma to SDDM

[Yunhe Guo]

guoyunhe added a comment.


  In D22700#662323 , @filipf wrote:
  
  > In D22700#662134 , @guoyunhe 
wrote:
  >
  > > When I press the synchronize button, it looks like the `-dpi 144` (scale 
x1.5) option makes the UI elements huge (feel like x2 scale or more):
  > >
  > > F8280985: IMG_20200503_152810.jpg 
  >
  >
  > -dpi 144 works the same for me in Plasma and SDDM, but do file a bug under 
systemsettings->kcm_sddm and copy paste what you have in 
`/etc/sddm.conf.d/kde_settings.conf`. I'll investigate.
  
  
  I think it is more likely an SDDM issue, because its document says so and the 
issue can be reproduced without using kcm_sddm. So I reported it here 
https://github.com/sddm/sddm/issues/1253

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22700

To: filipf, #plasma, davidedmundson, ngraham
Cc: guoyunhe, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22700: Sync scaling DPI from Plasma to SDDM

[Filip Fila]

filipf added a comment.


  In D22700#662134 , @guoyunhe wrote:
  
  > When I press the synchronize button, it looks like the `-dpi 144` (scale 
x1.5) option makes the UI elements huge (feel like x2 scale or more):
  >
  > F8280985: IMG_20200503_152810.jpg 
  
  
  -dpi 144 works the same for me in Plasma and SDDM, but do file a bug under 
systemsettings->kcm_sddm and copy paste what you have in 
`/etc/sddm.conf.d/kde_settings.conf`. I'll investigate.

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22700

To: filipf, #plasma, davidedmundson, ngraham
Cc: guoyunhe, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29380: [System Tray] Always draw the highlight behind the icon

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:3f06349549c1: [System Tray] Always draw the highlight 
behind the icon (authored by filipf).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29380?vs=81796=81809

REVISION DETAIL
  https://phabricator.kde.org/D29380

AFFECTED FILES
  applets/systemtray/package/contents/ui/CurrentItemHighLight.qml

To: filipf, kmaterka, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29386: [systemtray] Fix SNI icon not rendering

[Konrad Materka]

kmaterka added a comment.


  This patch is for "Plasma/5.18" branch only.
  Can we have it merged before 5.18.5?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29386

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29356: [applets/systemtray] Fix value read in some onXyxChanged connections

[Konrad Materka]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:efe4b603e92f: [applets/systemtray] Fix value read in some 
onXyxChanged connections (authored by kmaterka).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29356?vs=81726=81804

REVISION DETAIL
  https://phabricator.kde.org/D29356

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: kmaterka, #plasma_workspaces, #plasma, ngraham, apol, broulik, 
davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29386: [systemtray] Fix SNI icon not rendering

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson, broulik, 
ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
kmaterka requested review of this revision.

REVISION SUMMARY
  In some rare situations SNI icons are not rendered. It happens randomly, only 
some users are affected. It does not happen on every login.
  Only SNI icons are not rendered, Plasmoids are fine. Restarting plasmashell 
or re-adding systemtray applet helps.
  
  In QML all roles need to be defined before model is used. When data engines 
is used a a source for a data model, all roles has to be defined and proper 
value assigned (not a null QVariant). StatusNotifierItemSource does this 
properly, but in some situations it sets null QVariant for Icon. Setting 
empty/null QVariant removes key/role from the date set (DataConteiner 
implementation). If data model was loaded earlier or later when Icon has proper 
value it will work properly. In some rare situation it is possible that data 
model is loaded when Icon has null value assigned (in other words - removed), 
role is removed from the data model and not avaiable to system tray applet.
  
  This fix makes sure that there is always a value for Icon role. To check if 
icon is null native method has to be used - QML does not understand that QIcon 
can be null.
  
  BUG: 419305
  FIXED-IN: 5.18.5

TEST PLAN
  I don't have any reliable method to reproduce this issue.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D29386

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h
  dataengines/statusnotifieritem/statusnotifieritemsource.cpp

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29384: KCM Runners: Use setAppendServiceFile method for plugin selector

[Alexander Lohnau]

alex updated this revision to Diff 81801.
alex added a comment.


  Formatting

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29384?vs=81800=81801

BRANCH
  append_runner_service_file (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29384

AFFECTED FILES
  kcms/runners/kcm.cpp

To: alex, #plasma, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29384: KCM Runners: Use setAppendServiceFile method for plugin selector

[Alexander Lohnau]

alex created this revision.
alex added reviewers: Plasma, ngraham, meven.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  This is required for T13079: Make runner KCMs easier to use 
.
  
  Depends on D29201 

TEST PLAN
  Print the constructor arguments from a runner KCM.
  You should see the file name.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  append_runner_service_file (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29384

AFFECTED FILES
  kcms/runners/kcm.cpp

To: alex, #plasma, ngraham, meven
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29380: [System Tray] Always draw the highlight behind the icon

[Konrad Materka]

kmaterka accepted this revision.
kmaterka added a comment.
This revision is now accepted and ready to land.


  OK, accepted

REPOSITORY
  R120 Plasma Workspace

BRANCH
  draw-behind-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29380

To: filipf, kmaterka, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29380: [System Tray] Always draw the highlight behind the icon

[Filip Fila]

filipf updated this revision to Diff 81796.
filipf added a comment.


  move the code change to CurrentItemHighlight.qml

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29380?vs=81785=81796

BRANCH
  draw-behind-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29380

AFFECTED FILES
  applets/systemtray/package/contents/ui/CurrentItemHighLight.qml

To: filipf, kmaterka, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D22700: Sync scaling DPI from Plasma to SDDM

[Yunhe Guo]

guoyunhe added a comment.


  When I press the synchronize button, it looks like the `-dpi 144` (scale 
x1.5) option makes the UI elements huge (feel like x2 scale or more):
  
  F8280985: IMG_20200503_152810.jpg 

REPOSITORY
  R123 SDDM Configuration Panel (KCM)

REVISION DETAIL
  https://phabricator.kde.org/D22700

To: filipf, #plasma, davidedmundson, ngraham
Cc: guoyunhe, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> NotificationItem.qml:118
> +Layout.preferredWidth: notificationHeading.implicitWidth
> +id: headingElement
> +

Put `id` at the top

> NotificationItem.qml:122
> +imagePath: "widgets/plasmoidheading"
> +prefix: 'header'
> +anchors.fill: parent

Use `"`

> NotificationItem.qml:123
> +prefix: 'header'
> +anchors.fill: parent
> +anchors.topMargin: -margins.top

You can group those

  anchors {
  fill: parent
  topMargin: ...
  ...
  }

> NotificationItem.qml:173
>  Layout.preferredHeight: implicitHeight
> +Layout.fillWidth: true
>  textFormat: Text.PlainText

Keep it where it was

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

[Niccolò Venerandi]

niccolove updated this revision to Diff 81791.
niccolove added a comment.


  Fix very long application names

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=81750=81791

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationHeader.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29380: [System Tray] Always draw the highlight behind the icon

[Konrad Materka]

kmaterka requested changes to this revision.
kmaterka added a comment.
This revision now requires changes to proceed.


  The same treatment is needed in `HiddenItemsView` to. Just move `z: -1` to 
`CurrentItemHighLight` component so that your fix will cover both cases.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29380

To: filipf, kmaterka, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29380: [System Tray] Always draw the highlight behind the icon

[Filip Fila]

filipf created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
filipf requested review of this revision.

REVISION SUMMARY
  There was a slight issue introduced with D28109 
: the systray highlight can now cover up 
the icons it's highlighting.
  
  This isn't really an issue with Breeze because it uses a line for a 
highlight, but it is for themes that use a filled-style highlight.
  
  I set a z value for the highlight that should ensure it's now drawn only 
behind the icon.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  draw-behind-icons (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29380

AFFECTED FILES
  applets/systemtray/package/contents/ui/main.qml

To: filipf
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29379: Unassign activity from vault on activity deletion

[Ivan Čukić]

ivan updated this revision to Diff 81780.

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29379?vs=81779=81780

REVISION DETAIL
  https://phabricator.kde.org/D29379

AFFECTED FILES
  kded/service.cpp
  kded/service.h

To: ivan, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29379: Unassign activity from vault on activity deletion

[Ivan Čukić]

ivan created this revision.
ivan added a reviewer: ngraham.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ivan requested review of this revision.

REVISION SUMMARY
  CCBUG: 420784

REPOSITORY
  R845 Plasma Vault

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29379

AFFECTED FILES
  CMakeLists.txt
  kded/service.cpp
  kded/service.h

To: ivan, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

[Filip Fila]

filipf added a comment.


  Ok, so the message can indeed still be turned on.
  
  Setting:
  `~/.config/plasmarc [General] immutability=2 (or 4)`
  
  ... does not work, however the following does:
  
  `~/.config/kdeglobals [KDE Action Restrictions][$i] 
plasma/plasmashell/unlockedDesktop=false`
  
  Which means that if widget locking now only exists as a restriction... 
perhaps it would make more sense to change the text of this inline message to 
say "Layout changes have been restricted by the system administrator"?
  Otherwise telling a restricted user that widgets are locked isn't helpful 
since they can't (and shouldn't) unlock their widgets?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29366

To: filipf, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29359: Add context for "Automatic" strings

[Yuri Chornoivan]

yurchor updated this revision to Diff 81774.
yurchor added a comment.


  Use "comment" instead of "context", fix extracomment according to
  
  https://tsdgeos.blogspot.com/2011/05/qt-designer-texts-disambiguation-vs.html

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29359?vs=81736=81774

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29359

AFFECTED FILES
  libs/editor/settings/ui/802-1x.ui
  libs/editor/settings/ui/connectionwidget.ui
  libs/editor/settings/ui/infiniband.ui
  libs/editor/settings/ui/ipv4.ui
  libs/editor/settings/ui/ipv6.ui
  libs/editor/settings/ui/wificonnectionwidget.ui
  libs/editor/settings/ui/wiredconnectionwidget.ui

To: yurchor, #plasma, jgrulich, davidedmundson, ngraham, ecuadra
Cc: ecuadra, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart