D23518: Disable media controls and tabsrunner in Firefox again

[Radoslav Georgiev]

rgeorgiev added a comment.


  I think media controls should be enabled by default in private mode in 
Firefox.  The reason why I think so is that Firefox has an option which allows 
the user to enable or disable each individual extension in incognito mode.  It 
even asks the user about this explicitly on installation of an extension which 
has the capability to run in this mode.
  
  I understand the point about leakage of private information from incognito 
windows but I think the general (and most straightforward) solution to this 
problem is just to disable the extension in private mode.

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D23518

To: broulik, #plasma, fvogt, davidbekham, ngraham, davidedmundson
Cc: rgeorgiev, davidedmundson, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

Re: Monday meeting notes for 9/11/2020

[David Redondo]

Am Montag, 9. November 2020, 15:22:51 CET schrieb Nate Graham:
> On 11/9/20 5:18 AM, Marco Martin wrote:
> > Missing form David Redondo:
> > * I made a simple patch so QMenus are polished before creating the
> > platform window
> > * https://codereview.qt-project.org/c/qt/qtbase/+/320154
> > 
> > *  Which was the cause for ugly menus appearing in some places
> 
> Nice! Does this fix https://bugs.kde.org/show_bug.cgi?id=428095 or
> https://bugsfiles.kde.org/attachment.cgi?id=133043 or both or neither?
> 
> Nate

Would need some investigation,
the instance which led me to the above was right clicking on menu bars.
However I found one place where the application was the cause by explicitly
creating the window right after constructing the menu (submitted a MR for that 
too of course)

David

D6628: Fix and normalize license in .desktop files

[Joan Maspons]

maspons added inline comments.

INLINE COMMENTS

> metadata.desktop:49
>  X-KDE-PluginInfo-Depends=
> -X-KDE-PluginInfo-License=GPL
>  X-KDE-PluginInfo-EnabledByDefault=true

Are the changes from GPL to LGPL intended?

> metadata.desktop:60
>  X-KDE-PluginInfo-Depends=
> -X-KDE-PluginInfo-License=GPL
>  X-KDE-PluginInfo-EnabledByDefault=true

Are the changes from GPL to LGPL intended?

> metadata.desktop:66
>  X-KDE-PluginInfo-Depends=
> -X-KDE-PluginInfo-License=GPL
>  X-KDE-PluginInfo-EnabledByDefault=true

Are the changes from GPL to LGPL intended?

> metadata.desktop:115
>  X-KDE-PluginInfo-Depends=
> -X-KDE-PluginInfo-License=GPL
>  X-KDE-PluginInfo-EnabledByDefault=true

Are the changes from GPL to LGPL intended?

> plasma-toolbox-paneltoolbox.desktop:119
>  X-KDE-PluginInfo-EnabledByDefault=true
> -X-KDE-PluginInfo-License=GPL
>  X-KDE-PluginInfo-Name=org.kde.paneltoolbox

Are the changes from GPL to LGPL intended?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6628

To: sebas, #plasma, sitter, mart, broulik
Cc: maspons, bam, mak, mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

Re: Monday meeting notes for 9/11/2020

[Nate Graham]

On 11/9/20 5:18 AM, Marco Martin wrote:

Missing form David Redondo:
* I made a simple patch so QMenus are polished before creating the 
platform window
* https://codereview.qt-project.org/c/qt/qtbase/+/320154 


*  Which was the cause for ugly menus appearing in some places


Nice! Does this fix https://bugs.kde.org/show_bug.cgi?id=428095 or 
https://bugsfiles.kde.org/attachment.cgi?id=133043 or both or neither?


Nate

Re: Fix 'Connections' warnings in QML

[Nate Graham]

One big fix is fine IMO.

Nate



On 11/9/20 6:53 AM, Konrad Materka wrote:

Aleix,

Yes, I know frameworks have lower dependencies - I just wanted to fix 
QML warnings in Plasma Workspace. The question is:

Is it OK to do this in one bug change, or should I split it into smaller?

Konrad

pon., 9 lis 2020 o 14:23 Aleix Pol > napisał(a):


Hi Konrad,
It's okay to fix them in Plasma. Most of the ones we still have though
are in frameworks that still depend on Qt 5.12 and it's not trivial to
address this problem over there.

Aleix

On Mon, Nov 9, 2020 at 10:25 AM Konrad Materka mailto:mate...@gmail.com>> wrote:
 >
 > Hi,
 >
 > With Qt 5.15 we have tons of warnings like:
 > QML Connections: Implicitly defined onFoo properties in
Connections are deprecated.
 >
 > Qt 5.15 is now a minimum requirement for Plasma Workspace, so
nothing is blokcking to migrate to new syntax.
 >
 > Is it OK to fix them in one massive MR or better to do that one
by one (I mean one applet/module at a time)?

D6628: Fix and normalize license in .desktop files

[Matthias Klumpp]

mak added a comment.


  In D6628#676722 , @bam wrote:
  
  > Thanks for clarifying.
  >
  > In D6628#676721 , @mak wrote:
  >
  > > So, this change looks fine to me now, as it is :-)
  >
  >
  > And yet it was changed again! :-D
  >  
https://github.com/KDE/plasma-desktop/commit/05c230733a1b9d16c0e52eb54955c62d340b94e3
  
  
  :-D - *That* change also looks good, and apparently it doesn't break 
anything. The "GPL-2.0+"-style identifiers are encouraged by AppStream as much 
as "GPL-2.0-or-later", but "GPLv2.0+" is considered legacy. Its curious that AS 
would even validate this stuff though, as it doesn't look into desktop-entry 
files (but maybe some auto-generation is at play here).

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6628

To: sebas, #plasma, sitter, mart, broulik
Cc: bam, mak, mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

Re: Fix 'Connections' warnings in QML

[Konrad Materka]

Aleix,

Yes, I know frameworks have lower dependencies - I just wanted to fix QML
warnings in Plasma Workspace. The question is:
Is it OK to do this in one bug change, or should I split it into smaller?

Konrad

pon., 9 lis 2020 o 14:23 Aleix Pol  napisał(a):

> Hi Konrad,
> It's okay to fix them in Plasma. Most of the ones we still have though
> are in frameworks that still depend on Qt 5.12 and it's not trivial to
> address this problem over there.
>
> Aleix
>
> On Mon, Nov 9, 2020 at 10:25 AM Konrad Materka  wrote:
> >
> > Hi,
> >
> > With Qt 5.15 we have tons of warnings like:
> > QML Connections: Implicitly defined onFoo properties in Connections are
> deprecated.
> >
> > Qt 5.15 is now a minimum requirement for Plasma Workspace, so nothing is
> blokcking to migrate to new syntax.
> >
> > Is it OK to fix them in one massive MR or better to do that one by one
> (I mean one applet/module at a time)?
>

Re: Fix 'Connections' warnings in QML

[Aleix Pol]

Hi Konrad,
It's okay to fix them in Plasma. Most of the ones we still have though
are in frameworks that still depend on Qt 5.12 and it's not trivial to
address this problem over there.

Aleix

On Mon, Nov 9, 2020 at 10:25 AM Konrad Materka  wrote:
>
> Hi,
>
> With Qt 5.15 we have tons of warnings like:
> QML Connections: Implicitly defined onFoo properties in Connections are 
> deprecated.
>
> Qt 5.15 is now a minimum requirement for Plasma Workspace, so nothing is 
> blokcking to migrate to new syntax.
>
> Is it OK to fix them in one massive MR or better to do that one by one (I 
> mean one applet/module at a time)?
>
> --
> Regards:
> Konrad Materka

D6628: Fix and normalize license in .desktop files

[Andrey Butirsky]

bam added a comment.


  Thanks for clarifying.
  
  In D6628#676721 , @mak wrote:
  
  > So, this change looks fine to me now, as it is :-)
  
  
  And yet it was changed again! :-D
  
https://github.com/KDE/plasma-desktop/commit/05c230733a1b9d16c0e52eb54955c62d340b94e3

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6628

To: sebas, #plasma, sitter, mart, broulik
Cc: bam, mak, mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D6628: Fix and normalize license in .desktop files

[Matthias Klumpp]

mak added a comment.


  In D6628#676720 , @sitter wrote:
  
  > These aren't SPDX identifiers but kaboutlicense keywords 
https://api.kde.org/frameworks/kcoreaddons/html/kaboutdata_8cpp_source.html#l00397
  
  
  Makes sense.
  @bam As far as the "legacy syntax" is concerned: SPDX broke their conventions 
multiple times, so on the AppStream side I really got sick of these breaking 
changes and any syntax is fine. On the KDE side, switching the kaboutlicense 
keywords to SPDX is probably a bigger endeavour, and may not actually be worth 
the effort (I would guess that there may be some break risk here). So, this 
change looks fine to me now, as it is :-)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6628

To: sebas, #plasma, sitter, mart, broulik
Cc: bam, mak, mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D6628: Fix and normalize license in .desktop files

[Harald Sitter]

sitter added a comment.


  These aren't SPDX identifiers but kaboutlicense keywords 
https://api.kde.org/frameworks/kcoreaddons/html/kaboutdata_8cpp_source.html#l00397

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6628

To: sebas, #plasma, sitter, mart, broulik
Cc: bam, mak, mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

Re: Monday meeting notes for 9/11/2020

[Marco Martin]

Missing form David Redondo:
* I made a simple patch so QMenus are polished before creating the platform
window
*  https://codereview.qt-project.org/c/qt/qtbase/+/320154
*  Which was the cause for ugly menus appearing in some places

On Mon, Nov 9, 2020 at 1:16 PM Marco Martin  wrote:

> David E
> * First thing to discuss -  there's a KDE community ML thread that
> says we didn't follow procedures wrt telemetry policy
> * There's a line that says "must have two reviewers" and then suggests
> two mailing lists
> * what should be done? a thread on kde-community for each place?
> [krop]: the purpose of the user feedback is not clearly identife,
> needs better wording
> [d_ed] krop: so what needs clarifying, the "it's for Plasma" aspect of it?
> * In terms of other Plasma news
>  - SDDM 0.19.0 had a release
>  - There's some major breakage wrt some annoying race condition when
> people have multiple cards
>  [fvogt] And there are some reports that the security fix somehow
> broke with the prop. nvidia driver, which I don't understand (yet)
>  [d_ed] FWIW any breakage isn't universal - I'm booting using it here
> * In general we do need to improve our testing on SDDM, it's harder to
> deploy than other apps so we have fewer people running master
>
> Luca:
> * Major breakage in plasma-framework
>   KDE bug 428811 in frameworks-plasma (libplasma) "Visual regression:
> margins no longer honored for Folder View in applet
> * it will be in 5.76, needs a revert or a fix
> [Marco] will look at it today
>
> JustinZ
> * Been doing loads of bug triage but that's about it. I'm new af, hi 👋
>
> Fabian:
> * openQA found that kwin didn't get the color scheme from the lnf:
> https://bugs.kde.org/show_bug.cgi?id=428771
> * The kconfig notify mechanism doesn't seem that reliable either
> * It's opt-in and in many cases just doesn't work...
> * That's all I've got (to complain about) for now
>
>
> Nico
> * I fixed volume button handling in PlaMo:
> https://invent.kde.org/plasma/plasma-phone-components/-/merge_requests/102
> * That uncovered an issue in KWin:
> https://bugs.kde.org/show_bug.cgi?id=428859
> KDE bug 428859 in kwin (wayland-generic) "OSDs are maximized when
> using Maximized window placement policy" [normal,]
> https://bugs.kde.org/show_bug.cgi?id=428859
> * But I see zzag is already on it. nice
> * The main thing I want to talk about is the clang-formatting of Plasma.
> * I updated an older patch for this and did some manual intervention:
> https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/381
> * One of the concerns was that enums are folded into one line
> * One can prevent that by including a trailing comma, which is a good
> idea regardless, so I made
> https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/434
> * The remaining concerns are mostly about clang-format being quite
> aggressive in putting things on a single line.
> * I see a few possible resolutions:
>  1) We live with it
>  2) We refactor those lines to be shorter
>  3) We use `// clang-format off` directives to prevent formatting
> where it would be too bad
>  4) We give clang-format a line length limit that prevents it from
> formatting
>
> Kai Uwe
> * Not much from me.
> * I promise I'll have a look at the p-b-i patch from fvogt tonight...
>
> https://invent.kde.org/plasma/plasma-browser-integration/-/merge_requests/14
> * Also figured out the panel margin situaton with the new panel
> padding/"bleed into the border" stuff, nicolove will fix
> * (I have a gap on the left and right of my panel I can't click)
>
> David R
> * I was away at the end of last week
> * Disable bouncy cursor during ksplash
> ** https://invent.kde.org/plasma/kwin/-/merge_requests/416
> * Fix ctrl+q only working on second press in plasma-systemmonitor
> ** https://invent.kde.org/frameworks/kirigami/-/merge_requests/149
> * Fix collapsed icons not being centered in kirigami drawer
> ** https://invent.kde.org/frameworks/kirigami/-/merge_requests/150
> * Needs review so we can get it inot next bugfix release:
> ** https://invent.kde.org/plasma/khotkeys/-/merge_requests/6
>
> Bhushan
> * Not much to add, but I had been mostly working on PlaMo things
> * I also did some rework of keyboard_interface for grab_keyboard stuff
>
> Carl
> ## Kirigami
> https://invent.kde.org/frameworks/kirigami/-/merge_requests/128
> https://invent.kde.org/frameworks/kirigami/-/merge_requests/153
> https://invent.kde.org/frameworks/kirigami/-/merge_requests/146 (merged)
> ## Website
> Kde.org/plasma-desktop is now translated in a few languages \o/
>
> Aleix
> * I have mostly been working on the surface activation wayland protocol.
> * I have a PoC implementation for plasma as server and Qt as clients
> and it's working as expected, still it will take some time until the
> work is useful to  the userbase
>
> Arjen
> * biggest thing is that we did the public preview release of
> plasma-systemmonitor last week
> * see
> https://quantumproductions.info/articles/2020-2020-11/pl

Monday meeting notes for 9/11/2020

[Marco Martin]

David E
* First thing to discuss -  there's a KDE community ML thread that
says we didn't follow procedures wrt telemetry policy
* There's a line that says "must have two reviewers" and then suggests
two mailing lists
* what should be done? a thread on kde-community for each place?
[krop]: the purpose of the user feedback is not clearly identife,
needs better wording
[d_ed] krop: so what needs clarifying, the "it's for Plasma" aspect of it?
* In terms of other Plasma news
 - SDDM 0.19.0 had a release
 - There's some major breakage wrt some annoying race condition when
people have multiple cards
 [fvogt] And there are some reports that the security fix somehow
broke with the prop. nvidia driver, which I don't understand (yet)
 [d_ed] FWIW any breakage isn't universal - I'm booting using it here
* In general we do need to improve our testing on SDDM, it's harder to
deploy than other apps so we have fewer people running master

Luca:
* Major breakage in plasma-framework
  KDE bug 428811 in frameworks-plasma (libplasma) "Visual regression:
margins no longer honored for Folder View in applet
* it will be in 5.76, needs a revert or a fix
[Marco] will look at it today

JustinZ
* Been doing loads of bug triage but that's about it. I'm new af, hi 👋

Fabian:
* openQA found that kwin didn't get the color scheme from the lnf:
https://bugs.kde.org/show_bug.cgi?id=428771
* The kconfig notify mechanism doesn't seem that reliable either
* It's opt-in and in many cases just doesn't work...
* That's all I've got (to complain about) for now


Nico
* I fixed volume button handling in PlaMo:
https://invent.kde.org/plasma/plasma-phone-components/-/merge_requests/102
* That uncovered an issue in KWin: https://bugs.kde.org/show_bug.cgi?id=428859
KDE bug 428859 in kwin (wayland-generic) "OSDs are maximized when
using Maximized window placement policy" [normal,]
https://bugs.kde.org/show_bug.cgi?id=428859
* But I see zzag is already on it. nice
* The main thing I want to talk about is the clang-formatting of Plasma.
* I updated an older patch for this and did some manual intervention:
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/381
* One of the concerns was that enums are folded into one line
* One can prevent that by including a trailing comma, which is a good
idea regardless, so I made
https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/434
* The remaining concerns are mostly about clang-format being quite
aggressive in putting things on a single line.
* I see a few possible resolutions:
 1) We live with it
 2) We refactor those lines to be shorter
 3) We use `// clang-format off` directives to prevent formatting
where it would be too bad
 4) We give clang-format a line length limit that prevents it from formatting

Kai Uwe
* Not much from me.
* I promise I'll have a look at the p-b-i patch from fvogt tonight...
https://invent.kde.org/plasma/plasma-browser-integration/-/merge_requests/14
* Also figured out the panel margin situaton with the new panel
padding/"bleed into the border" stuff, nicolove will fix
* (I have a gap on the left and right of my panel I can't click)

David R
* I was away at the end of last week
* Disable bouncy cursor during ksplash
** https://invent.kde.org/plasma/kwin/-/merge_requests/416
* Fix ctrl+q only working on second press in plasma-systemmonitor
** https://invent.kde.org/frameworks/kirigami/-/merge_requests/149
* Fix collapsed icons not being centered in kirigami drawer
** https://invent.kde.org/frameworks/kirigami/-/merge_requests/150
* Needs review so we can get it inot next bugfix release:
** https://invent.kde.org/plasma/khotkeys/-/merge_requests/6

Bhushan
* Not much to add, but I had been mostly working on PlaMo things
* I also did some rework of keyboard_interface for grab_keyboard stuff

Carl
## Kirigami
https://invent.kde.org/frameworks/kirigami/-/merge_requests/128
https://invent.kde.org/frameworks/kirigami/-/merge_requests/153
https://invent.kde.org/frameworks/kirigami/-/merge_requests/146 (merged)
## Website
Kde.org/plasma-desktop is now translated in a few languages \o/

Aleix
* I have mostly been working on the surface activation wayland protocol.
* I have a PoC implementation for plasma as server and Qt as clients
and it's working as expected, still it will take some time until the
work is useful to  the userbase

Arjen
* biggest thing is that we did the public preview release of
plasma-systemmonitor last week
* see 
https://quantumproductions.info/articles/2020-2020-11/plasma-system-monitor-preview-release
if you haven't already
* it has been very well received as far as I can tell
* I've mostly been working on that release last week, with a few
smaller bugfixes that came out of it
* and a bunch of things on bko during the weekend as well
* is a bit weird is that some users are reporting incredibly low
framerates on wayland only
* i've yet to investigate properly since the last time I tried the
wayland session the entire session was running at unus

D6628: Fix and normalize license in .desktop files

[Andrey Butirsky]

bam added a comment.


  > Starting version 2.0, it is no longer valid to use the + operator in a 
license identifier
  
  should we address it?
  https://en.wikipedia.org/wiki/Software_Package_Data_Exchange#Deprecated_syntax

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6628

To: sebas, #plasma, sitter, mart, broulik
Cc: bam, mak, mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

Fix 'Connections' warnings in QML

[Konrad Materka]

Hi,

With Qt 5.15 we have tons of warnings like:
QML Connections: Implicitly defined onFoo properties in Connections are
deprecated.

Qt 5.15 is now a minimum requirement for Plasma Workspace, so nothing is
blokcking to migrate to new syntax.

Is it OK to fix them in one massive MR or better to do that one by one (I
mean one applet/module at a time)?

-- 
Regards:
Konrad Materka